The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.
| Tag Class | Total number of occurrences | Tag strings used by tag class |
|---|---|---|
| FIXME's | 5 | FIXME |
| TODO's | 121 | TODO |
Each tag is detailed below:
Number of occurrences found in the code: 5
| org.kuali.rice.krad.datadictionary.AttributeDefinition | Line |
|---|---|
| JLR - need to recreate this functionality using the ValidCharsConstraint logic | 219 |
| org.kuali.rice.krad.datadictionary.validation.capability.LookupConstrainable | Line |
| rename to getLookupConstraint() | 27 |
| org.kuali.rice.krad.datadictionary.validation.processor.CaseConstraintProcessor | Line |
| not sure if the definition and attribute value reader should change under this case | 73 |
| org.kuali.rice.krad.datadictionary.validation.processor.ValidCharactersConstraintProcessor | Line |
| This shouldn't surface label key itself to the user - it should look up the label key, but this needs to be implemented in Rice | 189 |
| org.kuali.rice.krad.util.ObjectUtils | Line |
| (laran) This dependence should be inverted. Instead of having a core class depend on PojoPropertyUtilsBean, which is in the web layer, the web layer should depend downward to the core. | 213 |
Number of occurrences found in the code: 121
| org.kuali.rice.krad.bo.AdHocRouteWorkgroupId | Line |
|---|---|
| Implement the equals() and hashCode() methods. | 28 |
| org.kuali.rice.krad.criteria.CriteriaLookupDaoJpa | Line |
| There has to be a better way to do this. | 128 |
| org.kuali.rice.krad.datadictionary.AttributeDefinition | Line |
| rename to control once ControlDefinition is removed | 74 |
| This may not be required since we now use ComplexAttributeDefinition | 93 |
| currently requiring a control or controlField, but this should not be case (AttrField should probably do the check) | 314 |
| org.kuali.rice.krad.datadictionary.DataDictionary | Line |
| determine property type using generics type definition | 548 |
| org.kuali.rice.krad.datadictionary.DataDictionaryIndexMapper | Line |
| arh14 - THIS METHOD NEEDS JAVADOCS | 214 |
| org.kuali.rice.krad.datadictionary.DocumentCollectionPath | Line |
| mpham - THIS METHOD NEEDS JAVADOCS | 65 |
| org.kuali.rice.krad.datadictionary.DocumentValuePathGroup | Line |
| mpham - THIS METHOD NEEDS JAVADOCS | 65 |
| org.kuali.rice.krad.datadictionary.RoutingTypeDefinition | Line |
| wliang - THIS METHOD NEEDS JAVADOCS | 65 |
| org.kuali.rice.krad.datadictionary.mask.MaskFormatterSubString | Line |
| MOVE TO UNIT TEST: move this validation into the unit tests | 38 |
| org.kuali.rice.krad.datadictionary.validation.ValidationPattern | Line |
| UNIT TEST: compile all patterns to test | 92 |
| org.kuali.rice.krad.datadictionary.validation.constraint.FixedPointPatternConstraint | Line |
| delyea don't forget to fill this in. | 26 |
| org.kuali.rice.krad.datadictionary.validation.constraint.IntegerPatternConstraint | Line |
| Administrator don't forget to fill this in. | 26 |
| org.kuali.rice.krad.datadictionary.validation.processor.BasePrerequisiteConstraintProcessor | Line |
| Does this code need to be able to look at more than just the other immediate members of the object? | 45 |
| org.kuali.rice.krad.datadictionary.validation.processor.RangeConstraintProcessor | Line |
| decide if there is any reason why the following would be insufficient - i.e. if something numeric could still be cast to String at this point | 82 |
| JLR - need a code review of the conversions below to make sure this is the best way to ensure accuracy across all numerics This will throw NumberFormatException if the value is 'NaN' or infinity... probably shouldn't be a NFE but something more intelligible at a higher level | 106 |
| org.kuali.rice.krad.document.DocumentBase | Line |
| Auto-generated method stub | 129 |
| Auto-generated method stub | 461 |
| better error handling at the lower level and a better error message are needed here | 488 |
| org.kuali.rice.krad.document.MaintenanceDocumentBase | Line |
| - build out with bo label once we get the data dictionary stuff in place build out the right classname | 175 |
| refactor this out into a method | 380 |
| need to convert this from using struts form file refreshAttachment(); | 659 |
| better error handling at the lower level and a better error message are needed here | 739 |
| org.kuali.rice.krad.lookup.LookupableImpl | Line |
| delyea: where to take into account the sort ascending value (old KNS appeared to ignore?) | 82 |
| force uppercase will be done in binding at some point | 147 |
| delyea - is this the best way to set that the entire set has a returnable row? | 151 |
| check secure fields if (field.isSecure()) { field.setSecure(false); field.setDisplayMaskValue(null); field.setEncryptedValue(null); } | 409 |
| need formatting on default value and make sure it works when control converts from checkbox to radio | 416 |
| this will be done by the uif validation service at some point | 441 |
| ; need hooks for code generated components and also this doesn't have lifecycle which could change fields | 471 |
| need to handle returning anchor | 571 |
| need to handle returning anchor | 725 |
| do not hardcode the _self string | 738 |
| org.kuali.rice.krad.maintenance.MaintainableImpl | Line |
| should this write some sort of missing message on the old side instead? | 414 |
| org.kuali.rice.krad.maintenance.MaintenanceUtils | Line |
| implement real authorization for Maintenance Document Save/Route - KULNRVSYS-948 | 135 |
| org.kuali.rice.krad.rules.MaintenanceDocumentRuleBase | Line |
| when/if we have standard support for DO retrieval, do this check for DO's | 710 |
| Good suggestion from Aaron, dont bother checking the DB, if all of the objects PK fields dont have values. If any are null or empty, then we're done. The current way wont fail, but it will make a wasteful DB call that may not be necessary, and we want to minimize these. | 716 |
| should this be getting labels from the view dictionary use the DataDictionary service to translate field name into human-readable label | 755 |
| org.kuali.rice.krad.uif.component.Component | Line |
| javadoc | 408 |
| this should not be on component interface since it only applies if the layout manager supports it, need some sort of layoutOptions map for field level options that depend on the manager | 425 |
| this should not be on component interface since it only applies if the layout manager supports it, need some sort of layoutOptions map for field level options that depend on the manager | 450 |
| org.kuali.rice.krad.uif.component.ComponentBase | Line |
| does conditional render have the el placeholder? if so this will not work | 157 |
| setting of the control names should probably be done in finalize, and we need KeepExpression on progressiveRender and conditionalRefresh | 164 |
| org.kuali.rice.krad.uif.container.CollectionGroup | Line |
| is this necessary to call again? | 200 |
| org.kuali.rice.krad.uif.container.MaintenanceActiveCollectionFilter | Line |
| if newly added line, show record If only new and no old add the newline | 61 |
| org.kuali.rice.krad.uif.container.TreeGroup | Line |
| set object path for prototypes equal to the tree group object path? | 65 |
| hack */ ".rootElement", "root"); | 131 |
| org.kuali.rice.krad.uif.field.ActionField | Line |
| possibly fix some other way - this is a workaround, prevents showing history and showing home again on actions which submit the form | 157 |
| org.kuali.rice.krad.uif.field.AttributeField | Line |
| should this check the view#readOnly? | 206 |
| Check authorization if (attributeSecurity.isMask() && !boAuthzService.canFullyUnmaskField(user,dataObjectClass, field.getPropertyName(), null)) { | 335 |
| format by type | 356 |
| format by type | 385 |
| org.kuali.rice.krad.uif.field.ErrorsField | Line |
| this may be changed to: if this is set on a field it will attempt show client side validation errors in the closest parent container error container | 395 |
| org.kuali.rice.krad.uif.field.LookupAttributeField | Line |
| what about formatter? | 92 |
| delyea: FieldUtils.createAndPopulateFieldsForLookup used to allow for a set of property names to be passed in via the URL parameters of the lookup url to set fields as 'read only' | 113 |
| org.kuali.rice.krad.uif.layout.TableLayoutManager | Line |
| implement repeat header | 210 |
| remove once we have modifier | 227 |
| org.kuali.rice.krad.uif.modifier.CompareFieldCreateModifier | Line |
| add script for value changed? | 228 |
| org.kuali.rice.krad.uif.service.ViewService | Line |
| remove once can get beans by type | 90 |
| org.kuali.rice.krad.uif.service.impl.AttributeQueryServiceImpl | Line |
| need to apply formatter for field or have method in object property utils | 79 |
| org.kuali.rice.krad.uif.service.impl.ViewHelperServiceImpl | Line |
| need to handle updating client state for component refresh | 209 |
| duplicate ID check | 280 |
| initialize from dictionary | 307 |
| should check to see if there is an add line method on the collection parent and if so call that instead of just adding to the collection (so that sequence can be set) | 1031 |
| this should invoke rules, subclasses like the document view should create the document add line event | 1063 |
| look into other ways of identifying a line so we can deal with unordered collections | 1086 |
| this should invoke rules, sublclasses like the document view should create the document delete line event | 1115 |
| need to put this in data object service so logic can be reused | 1160 |
| duplicate identifier check | 1185 |
| this should go through our formatters | 1261 |
| org.kuali.rice.krad.uif.util.ClientValidationUtils | Line |
| make this show the fields its requiring | 591 |
| org.kuali.rice.krad.uif.util.ComponentFactory | Line |
| how to deal with remotable field regexContraintMsg? | 339 |
| org.kuali.rice.krad.uif.util.ExpressionUtils | Line |
| In progress, adjusting paths in expressions if (defaultPathSet) { String adjustedExpression = ""; | 80 |
| org.kuali.rice.krad.uif.util.ScriptUtils | Line |
| should this go through property editors? | 99 |
| org.kuali.rice.krad.uif.util.UifBeanFactoryPostProcessor | Line |
| this only handles one level of nesting | 171 |
| this is not handled correctly | 474 |
| org.kuali.rice.krad.uif.view.History | Line |
| Possibly move so it can be used for the actual view title, not just history | 381 |
| org.kuali.rice.krad.uif.view.HistoryEntry | Line |
| a variety of these settings are not used in the current implementation of breadcrumbs and history, they may be removed later if they prove unuseful in future changes | 25 |
| unsure of use | 137 |
| org.kuali.rice.krad.uif.view.LookupView | Line |
| need to check lookupForm.isAtLeastOneRowHasActions() somewhere | 139 |
| work into view lifecycle LookupViewHelperService lookupViewHelperService = (LookupViewHelperService) getViewHelperService(); Set<String> readOnlyFields = lookupViewHelperService.getConditionallyReadOnlyPropertyNames(); Set<String> requiredFields = lookupViewHelperService.getConditionallyRequiredPropertyNames(); Set<String> hiddenFields = lookupViewHelperService.getConditionallyHiddenPropertyNames(); if ( (readOnlyFields != null && !readOnlyFields.isEmpty()) || (requiredFields != null && !requiredFields.isEmpty()) || (hiddenFields != null && !hiddenFields.isEmpty()) ) { for (Field field : getResultsGroup().getItems()) { if (AttributeField.class.isAssignableFrom(field.getClass())) { AttributeField attributeField = (AttributeField) field; if (readOnlyFields != null && readOnlyFields.contains(attributeField.getBindingInfo().getBindingName())) { attributeField.setReadOnly(true); } if (requiredFields != null && requiredFields.contains(attributeField.getBindingInfo().getBindingName())) { attributeField.setRequired(Boolean.TRUE); } if (hiddenFields != null && hiddenFields.contains(attributeField.getBindingInfo().getBindingName())) { attributeField.setControl(LookupInquiryUtils.generateCustomLookupControlFromExisting(HiddenControl.class, null)); } } } } | 170 |
| org.kuali.rice.krad.uif.view.View | Line |
| move to VHS initialize if (initializedComponentIds.contains(component.getId())) { throw new RiceRuntimeException( "Circular reference or duplicate id found for component with id: " + component.getId()); } initializedComponentIds.add(component.getId()); | 249 |
| fix this generic issue | 940 |
| org.kuali.rice.krad.uif.widget.Inquiry | Line |
| need general format util that uses spring | 174 |
| this should set base inquiry URL from module service as well, but right now set for KNS | 212 |
| org.kuali.rice.krad.uif.widget.QuickFinder | Line |
| --No comment-- | 189 |
| displayedFieldnames in org.kuali.rice.kns.lookup.LookupUtils.generateFieldConversions(BusinessObject, String, DataObjectRelationship, String, List, String) | 221 |
| displayedFieldnames and displayedQFFieldNames in generateLookupParameters(BusinessObject, String, DataObjectRelationship, String, List, String) | 235 |
| org.kuali.rice.krad.uif.widget.TableTools | Line |
| does this handle multiple rows correctly? | 146 |
| org.kuali.rice.krad.util.KRADUtils | Line |
| this method will probably need to be exposed in a public KRADUtils class as it is used by several different modules. That will have to wait until ModuleService and KualiModuleService are moved to core though. | 154 |
| need to apply formatting to return value once util class is ready | 435 |
| org.kuali.rice.krad.util.ObjectUtils | Line |
| The rules about this dot notation needs to be explained in Confluence using examples. | 229 |
| genericize collectionContainsObjectWithIdentitcalKey() to leverage this method? | 714 |
| org.kuali.rice.krad.web.bind.UifConfigurableWebBindingInitializer | Line |
| do we need this since we are switching to spring tags | 48 |
| org.kuali.rice.krad.web.bind.UifViewBeanWrapper | Line |
| clear cache? | 189 |
| clear cache? | 196 |
| org.kuali.rice.krad.web.controller.DocumentControllerBase | Line |
| authorization on document actions if (KEWConstants.SUPERUSER_COMMAND.equalsIgnoreCase(command)) { form.setSuppressAllButtons(true); } | 132 |
| turn this back on refreshAdHocRoutingWorkgroupLookups(request, form); | 205 |
| if the happens we may need to save form to session or account for it | 212 |
| prerules kualiDocumentFormBase.setDerivedValuesOnForm(request); ActionForward preRulesForward = promptBeforeValidation(mapping, form, request, response); if (preRulesForward != null) { return preRulesForward; } | 244 |
| adhoc recipients getDocumentService().routeDocument(document, form.getAnnotation(), combineAdHocRecipients(kualiDocumentFormBase)); | 260 |
| this needs more analysis before porting can finish | 469 |
| does this really belong in the loop if | 476 |
| need to look at screen, will most of this just be bound to the | 497 |
| need to move containsSensitiveDataPatternMatch to util class in krad | 547 |
| not ready for question framework yet | 571 |
| figure out what to return | 588 |
| org.kuali.rice.krad.web.controller.MaintenanceDocumentController | Line |
| getting double view if we call base, not sure how to handle so pasting in superclass code super.docHandler(formBase, request, response); * begin copy/paste from the base | 68 |
| set state in view form.setReadOnly(true); | 89 |
| should be in the view as permission | 209 |
| org.kuali.rice.krad.web.controller.UifControllerBase | Line |
| should use property editors once we have util class | 272 |
| this needs setup for lightbox and possible home location property | 312 |
| this code still needs to handle reference refreshes | 398 |
| lookup anchors and doc number? | 488 |
| should call module service to get full URL, but right now it is coded to direct to the KNS lookups Map<String, String> parameterMap = new HashMap<String, String>(); Enumeration<Object> e = lookupParameters.keys(); while (e.hasMoreElements()) { String paramName = (String) e.nextElement(); parameterMap.put(paramName, lookupParameters.getProperty(paramName)); } | 519 |
| add constant to UifParameters | 637 |
| org.kuali.rice.krad.web.controller.UifControllerHandlerInterceptor | Line |
| do we need to clear the messages before this so that formatting and validation errors done during the binding are not cleared out? | 70 |
| org.kuali.rice.krad.web.form.LookupForm | Line |
| replace with check to history | 97 |
| org.kuali.rice.krad.web.form.UifFormBase | Line |
| make sure action parameters are getting reinitialized on each request | 348 |
| org.kuali.rice.krad.web.session.NonSerializableSessionListener | Line |
| May want to have a way to turn this off that way we aren't incurring the overhead of testing every session object if it is serializable by actually serializing it! | 15 |
