The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.krad.bo.AdHocRouteWorkgroupId.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 66 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.krad.bo.SessionDocument.getSerializedDocumentForm() may expose internal representation by returning SessionDocument.serializedDocumentForm | MALICIOUS_CODE | EI_EXPOSE_REP | 60 | Medium |
| org.kuali.rice.krad.bo.SessionDocument.setSerializedDocumentForm(byte[]) may expose internal representation by storing an externally mutable object into SessionDocument.serializedDocumentForm | MALICIOUS_CODE | EI_EXPOSE_REP2 | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: org.kuali.rice.krad.bo.authorization.BusinessObjectAuthorizerBase.persistenceStructureService | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to collectionClasses in org.kuali.rice.krad.datadictionary.DataDictionary.buildReadDescriptor(Class, String) | STYLE | DLS_DEAD_LOCAL_STORE | 653 | Medium |
| Dead store to collectionClasses in org.kuali.rice.krad.datadictionary.DataDictionary.getCollectionElementClass(Class, String) | STYLE | DLS_DEAD_LOCAL_STORE | 594 | Medium |
| Dead store to indexName in org.kuali.rice.krad.datadictionary.DataDictionary.indexSource(String) | STYLE | DLS_DEAD_LOCAL_STORE | 129 | Medium |
| org.kuali.rice.krad.datadictionary.DataDictionary.persistenceStructureService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| Write to static field org.kuali.rice.krad.datadictionary.DataDictionary.validateEBOs from instance method org.kuali.rice.krad.datadictionary.DataDictionary.validateDD(boolean) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 203 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| ComplexAttributeDefinition is incompatible with expected argument type String in org.kuali.rice.krad.datadictionary.DataDictionaryEntryBase.setComplexAttributes(List) | CORRECTNESS | GC_UNRELATED_TYPES | 100 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.datadictionary.DataObjectEntry.getJstlKey() uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 75 | Medium |
| Redundant nullcheck of org.kuali.rice.krad.datadictionary.DataObjectEntry.dataObjectClass, which is known to be non-null in org.kuali.rice.krad.datadictionary.DataObjectEntry.getJstlKey() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 75 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of sourceClass in org.kuali.rice.krad.datadictionary.PrimitiveAttributeDefinition.completeValidation(Class, Class) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 102 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.datadictionary.UifDictionaryIndex.buildTypeIndex(Map) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 308 | Medium |
| Method org.kuali.rice.krad.datadictionary.UifDictionaryIndex.buildTypeIndex(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 308 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to regexString in org.kuali.rice.krad.datadictionary.validation.CharacterLevelValidationPattern.getRegexPattern() | STYLE | DLS_DEAD_LOCAL_STORE | 82 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.krad.datadictionary.validation.DictionaryObjectAttributeValueReader defines clone() but doesn't implement Cloneable | BAD_PRACTICE | CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE | 38 | High |
| Method org.kuali.rice.krad.datadictionary.validation.DictionaryObjectAttributeValueReader.isParentAttributeNull() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 163 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.krad.datadictionary.validation.ValidationUtils.getBoolean(Object) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 240 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to key in org.kuali.rice.krad.datadictionary.validation.constraint.AlphaNumericPatternConstraint.getLabelKey() | STYLE | DLS_DEAD_LOCAL_STORE | 39 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to key in org.kuali.rice.krad.datadictionary.validation.constraint.AlphaPatternConstraint.getLabelKey() | STYLE | DLS_DEAD_LOCAL_STORE | 60 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.datadictionary.validation.processor.CollectionSizeConstraintProcessor.processSingleCollectionSizeConstraint(DictionaryValidationResult, Collection, CollectionSizeConstraint, AttributeValueReader) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 74 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.krad.datadictionary.validation.result.ConstraintValidationResult.getErrorParameters() may expose internal representation by returning ConstraintValidationResult.errorParameters | MALICIOUS_CODE | EI_EXPOSE_REP | 106 | Medium |
| org.kuali.rice.krad.datadictionary.validation.result.ConstraintValidationResult.setErrorParameters(String[]) may expose internal representation by storing an externally mutable object into ConstraintValidationResult.errorParameters | MALICIOUS_CODE | EI_EXPOSE_REP2 | 113 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.rice.krad.datadictionary.validation.result.EntryValidationResult.entryName | PERFORMANCE | URF_UNREAD_FIELD | 32 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.kuali.rice.krad.document.MaintenanceDocumentBase.validateBusinessRules(KualiDocumentEvent), since all org.kuali.rice.krad.document.MaintenanceDocumentBase are instances of org.kuali.rice.krad.document.MaintenanceDocument | STYLE | BC_VACUOUS_INSTANCEOF | 708 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.krad.document.authorization.DocumentAuthorizerBase.LOG isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 43 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method call in new org.kuali.rice.krad.exception.ExceptionIncident(Exception, Map) passes null for nonnull parameter of initialize(Exception, Map) | CORRECTNESS | NP_NULL_PARAM_DEREF | 79 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.krad.inquiry.InquirableImpl.SUPER_CLASS_TRANSLATOR_LIST isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 71 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.lookup.LookupUtils.forceUppercase(Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 115 | Medium |
| Method org.kuali.rice.krad.lookup.LookupUtils.getExternalizableBusinessObjectFieldValues(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 329 | Medium |
| Method org.kuali.rice.krad.lookup.LookupUtils.preprocessDateFields(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 243 | Medium |
| Method org.kuali.rice.krad.lookup.LookupUtils.removeExternalizableBusinessObjectFieldValues(Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 313 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.uif.view.View to org.kuali.rice.krad.uif.view.LookupView in org.kuali.rice.krad.lookup.LookupableImpl.performInitialization(View, Object) | STYLE | BC_UNCONFIRMED_CAST | 121 | Medium |
| Dead store to lookupView in org.kuali.rice.krad.lookup.LookupableImpl.getMaintenanceActionLink(LinkField, Object, String) | STYLE | DLS_DEAD_LOCAL_STORE | 707 | Medium |
| Dead store to searchUsingOnlyPrimaryKeyValues in org.kuali.rice.krad.lookup.LookupableImpl.getSearchResults(LookupForm, Map, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 170 | Medium |
| Dead store to pkNames in org.kuali.rice.krad.lookup.LookupableImpl.performSearch(LookupForm, Map, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 152 | Medium |
| Dead store to user in org.kuali.rice.krad.lookup.LookupableImpl.performSearch(LookupForm, Map, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 153 | Medium |
| Dead store to dataObjectExample in org.kuali.rice.krad.lookup.LookupableImpl.validateSearchParameterWildcardAndOperators(InputField, String) | STYLE | DLS_DEAD_LOCAL_STORE | 513 | Medium |
| Method org.kuali.rice.krad.lookup.LookupableImpl.setMultiValueLookupSelect(InputField, Object) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 805 | Medium |
| org.kuali.rice.krad.lookup.LookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 74 | Medium |
| Method org.kuali.rice.krad.lookup.LookupableImpl.getActionUrlHref(LookupForm, Object, String, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 759 | Medium |
| Method org.kuali.rice.krad.lookup.LookupableImpl.getReturnUrlParameters(LookupView, LookupForm, Object) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 674 | Medium |
| Method org.kuali.rice.krad.lookup.LookupableImpl.getSearchResultsForEBO(Map, boolean) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 262 | Medium |
| Method org.kuali.rice.krad.lookup.LookupableImpl.processSearchCriteria(LookupForm, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 222 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docOrBoClass in org.kuali.rice.krad.rules.DocumentRuleBase.isAddHocRoutePersonValid(Document, AdHocRoutePerson) | STYLE | DLS_DEAD_LOCAL_STORE | 387 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on org.kuali.rice.krad.util.ErrorMessage.getMessageParameters() in org.kuali.rice.krad.rules.MaintenanceDocumentRuleBase.showErrorMap() | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 1094 | Medium |
| org.kuali.rice.krad.rules.MaintenanceDocumentRuleBase.LOG isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 73 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.DocumentFormBase in org.kuali.rice.krad.uif.authorization.DocumentAuthorizerBase.getActionFlags(UifFormBase, Person, Set) | STYLE | BC_UNCONFIRMED_CAST | 51 | Medium |
| org.kuali.rice.krad.uif.authorization.DocumentAuthorizerBase.LOG isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 42 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.DocumentFormBase in org.kuali.rice.krad.uif.authorization.DocumentPresentationControllerBase.getActionFlags(UifFormBase) | STYLE | BC_UNCONFIRMED_CAST | 42 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.kuali.rice.krad.uif.authorization.InquiryPresentationControllerBase.isExportSupported(InquiryView) | STYLE | REC_CATCH_EXCEPTION | 65 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.krad.uif.component.MethodInvokerConfig.getArgumentTypes() may expose internal representation by returning MethodInvokerConfig.argumentTypes | MALICIOUS_CODE | EI_EXPOSE_REP | 58 | Medium |
| org.kuali.rice.krad.uif.component.MethodInvokerConfig.setArgumentTypes(Class[]) may expose internal representation by storing an externally mutable object into MethodInvokerConfig.argumentTypes | MALICIOUS_CODE | EI_EXPOSE_REP2 | 67 | Medium |
| Read of unwritten field staticMethod in org.kuali.rice.krad.uif.component.MethodInvokerConfig.getMethodArgumentTypes() | CORRECTNESS | NP_UNWRITTEN_FIELD | 78 | Medium |
| Unwritten field: org.kuali.rice.krad.uif.component.MethodInvokerConfig.staticMethod | CORRECTNESS | UWF_UNWRITTEN_FIELD | 77 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.kuali.rice.krad.uif.component.Ordered shadows the simple name of implemented interface org.springframework.core.Ordered | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_INTERFACE | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.krad.uif.container.CollectionGroupBuilder.buildLine(View, Object, CollectionGroup, String, List, boolean, Object, int) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 248 | Medium |
| org.kuali.rice.krad.uif.container.CollectionGroupBuilder.removeNonRenderLineFields(View, Object, CollectionGroup, List, Object, int) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 332 | Medium |
| Method org.kuali.rice.krad.uif.container.CollectionGroupBuilder.performCollectionFiltering(View, Object, CollectionGroup, Collection) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 130 | Medium |
| Method org.kuali.rice.krad.uif.container.CollectionGroupBuilder.removeNonRenderLineFields(View, Object, CollectionGroup, List, Object, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 331 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.uif.field.ActionField.performFinalize(View, Object, Component) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 148 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.uif.field.AttributeQuery.getQueryFieldMappingJsString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 137 | Medium |
| Method org.kuali.rice.krad.uif.field.AttributeQuery.getQueryMethodArgumentFieldsJsString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 179 | Medium |
| Method org.kuali.rice.krad.uif.field.AttributeQuery.getReturnFieldMappingJsString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 159 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.krad.uif.field.FieldBase.performFinalize(View, Object, Component) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 96 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of selectControl at line 70 of value previously dereferenced in org.kuali.rice.krad.uif.layout.CollectionLayoutUtils.setControlValueToLineIdentifier(Field, Object) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 70 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.uif.layout.StackedLayoutManager.buildLineHeaderText(Object, Group) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 201 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.uif.layout.TableLayoutManager.addHeaderField(Field, int) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 369 | Medium |
| org.kuali.rice.krad.uif.layout.TableLayoutManager.buildLine(View, Object, CollectionGroup, List, List, String, List, String, Object, int) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 229 | Medium |
| Method org.kuali.rice.krad.uif.layout.TableLayoutManager.buildLine(View, Object, CollectionGroup, List, List, String, List, String, Object, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 218 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.uif.service.impl.ViewHelperServiceImpl.buildClientSideStateScript(View, Map, boolean) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 782 | Medium |
| org.kuali.rice.krad.uif.service.impl.ViewHelperServiceImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 84 | Medium |
| Method org.kuali.rice.krad.uif.service.impl.ViewHelperServiceImpl.populateViewFromRequestParameters(View, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 127 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.uif.util.ClientValidationUtils.createRule(InputField, Constraint, String, View) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 376 | Medium |
| Method org.kuali.rice.krad.uif.util.ClientValidationUtils.generateValidatorMessagesOption() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 135 | Medium |
| Method org.kuali.rice.krad.uif.util.ClientValidationUtils.getMustOccurStatement(InputField, MustOccurConstraint) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 627 | Medium |
| Method org.kuali.rice.krad.uif.util.ClientValidationUtils.processWhenConstraint(InputField, View, CaseConstraint, WhenConstraint, String, String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 293 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.krad.uif.util.CloneUtils.deepCloneObject(Object, Map) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 106 | Medium |
| Load of known null value in org.kuali.rice.krad.uif.util.CloneUtils.internalField(Object, String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 292 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Impossible cast from org.kuali.rice.krad.uif.control.TextControl to org.kuali.rice.krad.uif.control.TextAreaControl in org.kuali.rice.krad.uif.util.ComponentFactory.translateRemotableField(RemotableAttributeField) | CORRECTNESS | BC_IMPOSSIBLE_CAST | 434 | High |
| Possible null pointer dereference of component in org.kuali.rice.krad.uif.util.ComponentFactory.getNewInstanceForRefresh(View, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 146 | Medium |
| Value of control from previous case is overwritten here due to switch statement fall through | CORRECTNESS | SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH | 481 | High |
| Switch statement found in org.kuali.rice.krad.uif.util.ComponentFactory.getControl(UifConstants$ControlType) where one case falls through to the next case | STYLE | SF_SWITCH_FALLTHROUGH | 479 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.uif.util.ComponentUtils.sort(List, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 393 | Medium |
| Method org.kuali.rice.krad.uif.util.ComponentUtils.updateContextForLine(Component, Object, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 352 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to defaultPathSet in org.kuali.rice.krad.uif.util.ExpressionUtils.adjustPropertyExpressions(View, Object) | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
| Method org.kuali.rice.krad.uif.util.ExpressionUtils.processExpression(String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 149 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.uif.util.LookupInquiryUtils.getLinkTitleText(String, Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 108 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.uif.util.ScriptUtils.translateValue(Object) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 58 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.uif.util.UifBeanFactoryPostProcessor.removeExpressionsByPrefix(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 373 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.uif.util.ViewModelUtils.getPropertyTypeByClassAndView(View, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 85 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.uif.view.History.getGeneratedBreadcrumbs() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 208 | Medium |
| Method org.kuali.rice.krad.uif.view.History.getGeneratedCurrentBreadcrumb() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 241 | Medium |
| Method org.kuali.rice.krad.uif.view.History.getHistoryParameterString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 168 | Medium |
| Method org.kuali.rice.krad.uif.view.History.setCurrent(UifFormBase, HttpServletRequest) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 347 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.krad.util.KRADUtils.getIntegerValue(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 121 | Medium |
| Method org.kuali.rice.krad.util.KRADUtils.buildMapParameterString(Map) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 284 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to equals() with null argument in org.kuali.rice.krad.util.ObjectUtils.isNull(Object) | CORRECTNESS | EC_NULL_ARG | 836 | Medium |
| Method org.kuali.rice.krad.util.ObjectUtils.createHybridBusinessObject(BusinessObject, BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 194 | Medium |
| Method org.kuali.rice.krad.util.ObjectUtils.equalByKeys(PersistableBusinessObject, PersistableBusinessObject) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 673 | Medium |
| Method org.kuali.rice.krad.util.ObjectUtils.materializeSubObjectsToDepth(PersistableBusinessObject, int) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 936 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.rice.krad.util.documentserializer.DocumentSerializationState$SerializationPropertyElement be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.rice.krad.util.documentserializer.SerializationState$SerializationPropertyElement be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 35 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.DocumentFormBase in org.kuali.rice.krad.web.controller.DocumentControllerBase.cancel(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 236 | Medium |
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.DocumentFormBase in org.kuali.rice.krad.web.controller.DocumentControllerBase.deleteNote(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 552 | Medium |
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.DocumentFormBase in org.kuali.rice.krad.web.controller.DocumentControllerBase.downloadAttachment(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 595 | Medium |
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.DocumentFormBase in org.kuali.rice.krad.web.controller.DocumentControllerBase.insertNote(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 466 | Medium |
| org.kuali.rice.krad.web.controller.DocumentControllerBase.DOCUMENT_LOAD_COMMANDS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 98 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.IncidentReportForm in org.kuali.rice.krad.web.controller.IncidentReportController.submitReport(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 57 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.InquiryForm in org.kuali.rice.krad.web.controller.InquiryController.export(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 106 | Medium |
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.InquiryForm in org.kuali.rice.krad.web.controller.InquiryController.start(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 75 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.LookupForm in org.kuali.rice.krad.web.controller.LookupController.cancel(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 130 | Medium |
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.LookupForm in org.kuali.rice.krad.web.controller.LookupController.start(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 116 | Medium |
| Method org.kuali.rice.krad.web.controller.LookupController.search(LookupForm, BindingResult, HttpServletRequest, HttpServletResponse) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 184 | Medium |
| Method org.kuali.rice.krad.web.controller.LookupController.returnSelected(LookupForm, BindingResult, HttpServletRequest, HttpServletResponse) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 230 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.DocumentFormBase to org.kuali.rice.krad.web.form.MaintenanceForm in org.kuali.rice.krad.web.controller.MaintenanceDocumentController.docHandler(DocumentFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 75 | Medium |
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.MaintenanceForm in org.kuali.rice.krad.web.controller.MaintenanceDocumentController.start(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 124 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.krad.web.form.LookupForm.processBooleanParameter(String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 161 | Medium |
| org.kuali.rice.krad.web.form.LookupForm.processBooleanParameter(String) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 163 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.krad.web.form.UifFormBase defines non-transient non-serializable instance field attachmentFile | BAD_PRACTICE | SE_BAD_FIELD | Medium |
