PMD Results

The following document contains the results of PMD 4.2.5.

Files

org/kuali/rice/krad/bo/DocumentHeader.java

ViolationLine
Avoid duplicate imports such as 'org.kuali.rice.core.api.exception.RiceRuntimeException'27

org/kuali/rice/krad/bo/authorization/BusinessObjectAuthorizerBase.java

ViolationLine
Avoid unused private fields such as 'persistenceStructureService'.42

org/kuali/rice/krad/criteria/CriteriaLookupDaoJpa.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.core.api.criteria.CriteriaLookupService'8
Avoid unused method parameters such as 'queryClass'.86 - 114
Avoid unused method parameters such as 'criteria'.125 - 132
Avoid unused method parameters such as 'queryClass'.125 - 132

org/kuali/rice/krad/criteria/CriteriaLookupDaoOjb.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.core.api.criteria.CriteriaDateTimeValue'10
Avoid unused imports such as 'org.kuali.rice.core.api.criteria.CriteriaLookupService'11
Avoid unused method parameters such as 'criteria'.124 - 130

org/kuali/rice/krad/criteria/CriteriaLookupDaoProxy.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.core.api.CoreApiServiceLocator'19
Avoid unused imports such as 'org.kuali.rice.krad.service.KRADServiceLocator'26

org/kuali/rice/krad/datadictionary/BusinessObjectEntry.java

ViolationLine
Avoid unused imports such as 'java.util.List'23

org/kuali/rice/krad/datadictionary/DataDictionary.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.datadictionary.exception.CompletionException'26
Avoid unused local variables such as 'indexName'.130
These nested if statements could be combined644 - 672
Avoid empty catch blocks721 - 723

org/kuali/rice/krad/datadictionary/DataDictionaryIndexMapper.java

ViolationLine
Avoid empty catch blocks146 - 148
Avoid empty catch blocks164 - 165

org/kuali/rice/krad/datadictionary/DataObjectEntry.java

ViolationLine
No need to import a type that lives in the same package20

org/kuali/rice/krad/datadictionary/InactivationBlockingDefinition.java

ViolationLine
These nested if statements could be combined49 - 53

org/kuali/rice/krad/datadictionary/UifDictionaryIndex.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.uif.component.Component'23
Avoid unused imports such as 'org.kuali.rice.krad.uif.util.ComponentUtils'24

org/kuali/rice/krad/datadictionary/ViewTypeDictionaryIndex.java

ViolationLine
No need to import a type that lives in the same package18

org/kuali/rice/krad/datadictionary/WorkflowAttributes.java

ViolationLine
An empty statement (semicolon) not part of a loop38

org/kuali/rice/krad/datadictionary/validation/CharacterLevelValidationPattern.java

ViolationLine
Avoid unused local variables such as 'regexString'.82

org/kuali/rice/krad/datadictionary/validation/DictionaryObjectAttributeValueReader.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.datadictionary.ComplexAttributeDefinition'23
Avoid empty catch blocks130 - 132

org/kuali/rice/krad/datadictionary/validation/ValidationUtils.java

ViolationLine
Avoid empty catch blocks61 - 63

org/kuali/rice/krad/datadictionary/validation/constraint/AlphaNumericPatternConstraint.java

ViolationLine
Avoid unused local variables such as 'key'.39
Overriding method merely calls super58 - 60

org/kuali/rice/krad/datadictionary/validation/constraint/AlphaPatternConstraint.java

ViolationLine
Avoid unused local variables such as 'key'.60

org/kuali/rice/krad/datadictionary/validation/constraint/BaseConstraint.java

ViolationLine
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.29

org/kuali/rice/krad/datadictionary/validation/constraint/CharsetPatternConstraint.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.core.api.config.property.ConfigurationService'19
Avoid unused imports such as 'org.kuali.rice.krad.service.KRADServiceLocator'20

org/kuali/rice/krad/datadictionary/validation/constraint/DatePatternConstraint.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.core.api.config.property.ConfigurationService'26
Avoid unused imports such as 'org.kuali.rice.krad.service.KRADServiceLocator'27
Avoid unused imports such as 'org.kuali.rice.krad.uif.UifConstants'28
Avoid empty if statements57 - 59
Avoid empty if statements62 - 64

org/kuali/rice/krad/datadictionary/validation/constraint/ValidCharactersConstraint.java

ViolationLine
Avoid unused imports such as 'java.util.ArrayList'3
Avoid unused imports such as 'java.util.List'4

org/kuali/rice/krad/datadictionary/validation/constraint/ValidCharactersPatternConstraint.java

ViolationLine
Overriding method merely calls super36 - 38

org/kuali/rice/krad/datadictionary/validation/constraint/ValidDataPatternConstraint.java

ViolationLine
Avoid unused imports such as 'java.util.ArrayList'18
Avoid unused imports such as 'java.util.List'19
Avoid unused imports such as 'org.kuali.rice.krad.uif.UifConstants'22
Overriding method merely calls super39 - 41

org/kuali/rice/krad/datadictionary/validation/processor/ExistenceConstraintProcessor.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.datadictionary.DataObjectEntry'19

org/kuali/rice/krad/datadictionary/validation/result/EntryValidationResult.java

ViolationLine
Avoid unused private fields such as 'entryName'.28

org/kuali/rice/krad/document/Document.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.exception.ValidationException'28
Avoid unused imports such as 'java.util.Map'36

org/kuali/rice/krad/document/DocumentBase.java

ViolationLine
These nested if statements could be combined242 - 246
These nested if statements could be combined505 - 529

org/kuali/rice/krad/document/MaintenanceDocumentBase.java

ViolationLine
These nested if statements could be combined714 - 726
Avoid empty if statements744 - 751

org/kuali/rice/krad/document/TransactionalDocumentBase.java

ViolationLine
Avoid unused private fields such as 'LOG'.29

org/kuali/rice/krad/document/authorization/DocumentAuthorizerBase.java

ViolationLine
These nested if statements could be combined121 - 126

org/kuali/rice/krad/document/authorization/TransactionalDocumentPresentationControllerBase.java

ViolationLine
Avoid unused private fields such as 'LOG'.29

org/kuali/rice/krad/lookup/LookupUtils.java

ViolationLine
Avoid unused imports such as 'java.util.StringTokenizer'44
Avoid empty catch blocks87 - 89

org/kuali/rice/krad/lookup/LookupableImpl.java

ViolationLine
Avoid unused local variables such as 'pkNames'.152
Avoid unused local variables such as 'user'.153
Avoid unused local variables such as 'searchUsingOnlyPrimaryKeyValues'.170
Avoid unused local variables such as 'lookupView'.225
Avoid unused local variables such as 'lookupView'.446
Avoid unused local variables such as 'dataObjectExample'.511
These nested if statements could be combined535 - 545
Avoid unused local variables such as 'lookupView'.714

org/kuali/rice/krad/rules/DocumentRuleBase.java

ViolationLine
Avoid unused local variables such as 'docOrBoClass'.386

org/kuali/rice/krad/rules/MaintenanceDocumentRuleBase.java

ViolationLine
These nested if statements could be combined711 - 733
These nested if statements could be combined1066 - 1068

org/kuali/rice/krad/uif/authorization/DocumentAuthorizerBase.java

ViolationLine
These nested if statements could be combined106 - 109

org/kuali/rice/krad/uif/authorization/DocumentPresentationControllerBase.java

ViolationLine
Avoid empty catch blocks240 - 242

org/kuali/rice/krad/uif/component/MethodInvokerConfig.java

ViolationLine
Overriding method merely calls super43 - 45

org/kuali/rice/krad/uif/container/CollectionFilter.java

ViolationLine
No need to import a type that lives in the same package3

org/kuali/rice/krad/uif/container/CollectionGroup.java

ViolationLine
These nested if statements could be combined124 - 130

org/kuali/rice/krad/uif/container/CollectionGroupBuilder.java

ViolationLine
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.206
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.290

org/kuali/rice/krad/uif/control/ControlBase.java

ViolationLine
Avoid unused private fields such as 'ariaHTML'.31

org/kuali/rice/krad/uif/control/GroupControl.java

ViolationLine
These nested if statements could be combined70 - 72

org/kuali/rice/krad/uif/field/AttributeField.java

ViolationLine
Avoid unused private fields such as 'customValidatorClass'.85

org/kuali/rice/krad/uif/field/ErrorsField.java

ViolationLine
These nested if statements could be combined306 - 311

org/kuali/rice/krad/uif/field/FieldBase.java

ViolationLine
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.96

org/kuali/rice/krad/uif/field/LookupAttributeField.java

ViolationLine
These nested if statements could be combined107 - 109

org/kuali/rice/krad/uif/layout/BoxLayoutManager.java

ViolationLine
These nested if statements could be combined96 - 99
These nested if statements could be combined103 - 106

org/kuali/rice/krad/uif/layout/TableLayoutManager.java

ViolationLine
These nested if statements could be combined149 - 151
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.228

org/kuali/rice/krad/uif/modifier/CompareFieldCreateModifier.java

ViolationLine
Avoid unused private fields such as 'LOG'.49

org/kuali/rice/krad/uif/modifier/ComponentConvertModifier.java

ViolationLine
These nested if statements could be combined88 - 91

org/kuali/rice/krad/uif/service/ViewHelperService.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.web.form.UifFormBase'22

org/kuali/rice/krad/uif/service/ViewTypeService.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.uif.UifConstants'18
Avoid unused imports such as 'org.kuali.rice.krad.uif.view.View'19

org/kuali/rice/krad/uif/service/impl/ViewHelperServiceImpl.java

ViolationLine
Avoid unused local variables such as 'layoutManager'.296
Avoid empty if statements306 - 308

org/kuali/rice/krad/uif/util/ClientValidationUtils.java

ViolationLine
An operation on an Immutable object (String, BigDecimal or BigInteger) won't change the object itself188
Avoid empty if statements728 - 730

org/kuali/rice/krad/uif/util/CloneUtils.java

ViolationLine
Avoid empty if statements81 - 83
Avoid empty if statements84 - 86
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.101

org/kuali/rice/krad/uif/util/ExpressionUtils.java

ViolationLine
Avoid unused local variables such as 'defaultPathSet'.56
These nested if statements could be combined141 - 143
These nested if statements could be combined281 - 318
These nested if statements could be combined314 - 316

org/kuali/rice/krad/uif/util/LookupInquiryUtils.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.core.api.config.property.ConfigurationService'20
Avoid unused imports such as 'org.kuali.rice.core.api.util.ConcreteKeyValue'22
Avoid unused imports such as 'org.kuali.rice.core.api.util.KeyValue'23
Avoid unused imports such as 'org.kuali.rice.krad.datadictionary.AttributeDefinition'25
Avoid unused imports such as 'org.kuali.rice.krad.uif.control.CheckboxControl'28
Avoid unused imports such as 'org.kuali.rice.krad.uif.control.Control'29
Avoid unused imports such as 'org.kuali.rice.krad.uif.control.RadioGroupControl'30
Avoid unused imports such as 'org.kuali.rice.krad.uif.control.TextAreaControl'31
Avoid unused imports such as 'org.kuali.rice.krad.uif.field.AttributeField'32
Avoid unused imports such as 'java.util.ArrayList'38
Avoid unused imports such as 'java.util.List'39

org/kuali/rice/krad/uif/util/UifBeanFactoryPostProcessor.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.datadictionary.DataDictionary'21

org/kuali/rice/krad/uif/util/UifWebUtils.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.core.api.exception.RiceRuntimeException'15
Avoid unused imports such as 'org.kuali.rice.krad.uif.UifConstants.ViewType'30

org/kuali/rice/krad/uif/util/ViewModelUtils.java

ViolationLine
Avoid unused imports such as 'org.springframework.beans.PropertyValue'16
Avoid empty catch blocks162 - 164
Avoid empty catch blocks164 - 166

org/kuali/rice/krad/uif/view/LookupView.java

ViolationLine
Avoid unused private fields such as 'lookupCriteriaEnabled'.80
Avoid unused private fields such as 'supplementalActionsEnabled'.81
Avoid unused private fields such as 'disableSearchButtons'.82

org/kuali/rice/krad/uif/view/View.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.uif.component.BindingInfo'24

org/kuali/rice/krad/uif/widget/LightBoxLookup.java

ViolationLine
Avoid unused imports such as 'java.util.HashMap'13
Avoid unused imports such as 'org.apache.commons.lang.StringUtils'15

org/kuali/rice/krad/util/KRADUtils.java

ViolationLine
Avoid unused imports such as 'java.lang.annotation.Annotation'37
Unnecessary final modifier in final class62 - 78
Unnecessary final modifier in final class83 - 95
Unnecessary final modifier in final class107 - 113
Unnecessary final modifier in final class467 - 469

org/kuali/rice/krad/util/ObjectUtils.java

ViolationLine
Avoid empty catch blocks243 - 245
Avoid empty catch blocks245 - 247
Avoid empty catch blocks298 - 300
Avoid empty catch blocks303 - 305
An empty statement (semicolon) not part of a loop597
These nested if statements could be combined828 - 830
These nested if statements could be combined918 - 920

org/kuali/rice/krad/util/documentserializer/PropertySerializabilityEvaluatorBase.java

ViolationLine
These nested if statements could be combined112 - 114

org/kuali/rice/krad/web/bind/UifHandlerExceptionResolver.java

ViolationLine
Avoid unused imports such as 'java.util.Map'30

org/kuali/rice/krad/web/bind/UifServletRequestDataBinder.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.uif.UifConstants'20

org/kuali/rice/krad/web/bind/UifViewBeanWrapper.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.core.api.exception.RiceRuntimeException'18
These nested if statements could be combined85 - 87
Avoid empty catch blocks162 - 164

org/kuali/rice/krad/web/controller/UifAnnotationMethodHandleAdapter.java

ViolationLine
These nested if statements could be combined42 - 45

org/kuali/rice/krad/web/controller/UifControllerHandlerInterceptor.java

ViolationLine
Avoid unused private fields such as 'LOG'.44

org/kuali/rice/krad/web/form/IncidentReportForm.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.uif.UifConstants'19

org/kuali/rice/krad/web/form/InquiryForm.java

ViolationLine
Avoid unused private fields such as 'LOG'.34

org/kuali/rice/krad/web/form/LookupForm.java

ViolationLine
Avoid unused imports such as 'java.util.ArrayList'28
Avoid unused imports such as 'java.util.List'31
These nested if statements could be combined98 - 101
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.161

org/kuali/rice/krad/web/form/MaintenanceForm.java

ViolationLine
Overriding method merely calls super45 - 47

org/kuali/rice/krad/workflow/service/WorkflowDocumentService.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.kew.exception.ResourceUnavailableException'21