PMD Results

The following document contains the results of PMD 4.2.2.

Files

ObJectRelationalBridge - org/apache/ojb/broker/MtoNImplementor.java

ViolationLine
Avoid unused constructor parameters such as 'pb'.46 - 49

ObJectRelationalBridge - org/apache/ojb/broker/accesslayer/ChainingIterator.java

ViolationLine
Avoid unused private fields such as 'disableLifeCycleEvents'.57
These nested if statements could be combined97 - 101
These nested if statements could be combined353 - 362

ObJectRelationalBridge - org/apache/ojb/broker/accesslayer/ConnectionFactoryPooledImpl.java

ViolationLine
Avoid empty catch blocks104
Avoid empty catch blocks118
Avoid empty catch blocks286 - 289

ObJectRelationalBridge - org/apache/ojb/broker/accesslayer/ConnectionManagerImpl.java

ViolationLine
Avoid empty catch blocks275 - 278

ObJectRelationalBridge - org/apache/ojb/broker/accesslayer/JdbcAccessImpl.java

ViolationLine
Avoid empty catch blocks125
Avoid empty catch blocks521

ObJectRelationalBridge - org/apache/ojb/broker/accesslayer/RowReader.java

ViolationLine
Avoid unused imports such as 'java.sql.ResultSet'21

ObJectRelationalBridge - org/apache/ojb/broker/accesslayer/RsIterator.java

ViolationLine
Avoid empty catch blocks606 - 609
These nested if statements could be combined825 - 850
Overriding method merely calls super923 - 926

ObJectRelationalBridge - org/apache/ojb/broker/accesslayer/StatementManager.java

ViolationLine
Avoid unused method parameters such as 'crit'.258 - 261
Avoid unused method parameters such as 'stmt'.258 - 261
Avoid unused method parameters such as 'crit'.270 - 273
Avoid unused method parameters such as 'stmt'.270 - 273
Avoid unused method parameters such as 'crit'.282 - 285
Avoid unused method parameters such as 'stmt'.282 - 285

ObJectRelationalBridge - org/apache/ojb/broker/accesslayer/conversions/BlankString2NullFieldConversion.java

ViolationLine
These nested if statements could be combined36 - 37

ObJectRelationalBridge - org/apache/ojb/broker/accesslayer/sql/SqlProcedureStatement.java

ViolationLine
Avoid unused private fields such as 'logger'.41

ObJectRelationalBridge - org/apache/ojb/broker/accesslayer/sql/SqlQueryStatement.java

ViolationLine
These nested if statements could be combined1041 - 1052

ObJectRelationalBridge - org/apache/ojb/broker/ant/PreparedModel.java

ViolationLine
Avoid unused local variables such as 'result'.143

ObJectRelationalBridge - org/apache/ojb/broker/ant/RepositoryVerifierHandler.java

ViolationLine
Avoid unused private fields such as 'm_repository'.51
Avoid unused private fields such as 'm_CurrentCLD'.53
Avoid unused private fields such as 'm_CurrentORD'.55
Avoid unused private fields such as 'm_CurrentCOD'.56
Avoid unused local variables such as 'isoLevel'.213
Avoid unused local variables such as 'classExtent'.250
Avoid unused local variables such as 'refClass'.308
Avoid unused local variables such as 'oCollectionClass'.337
Avoid unused local variables such as 'oElementClassRef'.353
Avoid empty catch blocks378 - 381

ObJectRelationalBridge - org/apache/ojb/broker/ant/WriteDataToDatabaseCommand.java

ViolationLine
These nested if statements could be combined160 - 163

ObJectRelationalBridge - org/apache/ojb/broker/ant/WriteDtdToFileCommand.java

ViolationLine
Avoid unused local variables such as 'dtdWriter'.74

ObJectRelationalBridge - org/apache/ojb/broker/cache/ObjectCacheDefaultImpl.java

ViolationLine
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.169
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.171

ObJectRelationalBridge - org/apache/ojb/broker/cache/ObjectCacheEmptyImpl.java

ViolationLine
Avoid unused constructor parameters such as 'prop'.57 - 60
Avoid unused constructor parameters such as 'broker'.57 - 60

ObJectRelationalBridge - org/apache/ojb/broker/cache/ObjectCacheJCSImpl.java

ViolationLine
Avoid unused constructor parameters such as 'prop'.69 - 72
Avoid unused constructor parameters such as 'broker'.69 - 72
Avoid empty catch blocks118 - 121

ObJectRelationalBridge - org/apache/ojb/broker/cache/ObjectCacheJCSPerClassImpl.java

ViolationLine
Avoid unused constructor parameters such as 'prop'.67 - 69
Avoid unused constructor parameters such as 'broker'.67 - 69

ObJectRelationalBridge - org/apache/ojb/broker/cache/ObjectCacheLocalDefaultImpl.java

ViolationLine
Avoid unused constructor parameters such as 'broker'.82 - 85

ObJectRelationalBridge - org/apache/ojb/broker/cache/ObjectCachePerBrokerImpl.java

ViolationLine
Avoid unused constructor parameters such as 'prop'.63 - 68

ObJectRelationalBridge - org/apache/ojb/broker/cache/ObjectCachePerClassImpl.java

ViolationLine
Avoid unused constructor parameters such as 'prop'.40 - 43

ObJectRelationalBridge - org/apache/ojb/broker/cache/ObjectCacheSoftImpl.java

ViolationLine
Avoid unused constructor parameters such as 'properties'.55 - 62
Avoid unused constructor parameters such as 'broker'.55 - 62
These nested if statements could be combined225 - 228

ObJectRelationalBridge - org/apache/ojb/broker/core/IdentityFactoryImpl.java

ViolationLine
Avoid empty if statements160 - 165

ObJectRelationalBridge - org/apache/ojb/broker/core/MtoNBroker.java

ViolationLine
Overriding method merely calls super479 - 482

ObJectRelationalBridge - org/apache/ojb/broker/core/PersistenceBrokerBean.java

ViolationLine
Avoid unused private fields such as 'm_ctx'.109
Avoid unused private fields such as 'm_ojbRepository'.110

ObJectRelationalBridge - org/apache/ojb/broker/core/PersistenceBrokerFactoryDefaultImpl.java

ViolationLine
Avoid empty catch blocks116 - 119

ObJectRelationalBridge - org/apache/ojb/broker/core/PersistenceBrokerFactorySyncImpl.java

ViolationLine
Avoid empty catch blocks173 - 175
Overriding method merely calls super590 - 593

ObJectRelationalBridge - org/apache/ojb/broker/core/PersistenceBrokerHandle.java

ViolationLine
Overriding method merely calls super33 - 36

ObJectRelationalBridge - org/apache/ojb/broker/core/PersistenceBrokerImpl.java

ViolationLine
These nested if statements could be combined496 - 508
These nested if statements could be combined838 - 840
These nested if statements could be combined881 - 892

ObJectRelationalBridge - org/apache/ojb/broker/core/QueryReferenceBroker.java

ViolationLine
These nested if statements could be combined798 - 802

ObJectRelationalBridge - org/apache/ojb/broker/core/proxy/ProxyHelper.java

ViolationLine
Avoid unused imports such as 'java.lang.ref.SoftReference'18

ObJectRelationalBridge - org/apache/ojb/broker/locking/LockManagerInMemoryImpl.java

ViolationLine
These nested if statements could be combined499 - 504

ObJectRelationalBridge - org/apache/ojb/broker/locking/LockManagerServlet.java

ViolationLine
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.157
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.162
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.173 - 174
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.179
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.184
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.189
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.194

ObJectRelationalBridge - org/apache/ojb/broker/metadata/ArgumentDescriptor.java

ViolationLine
Unnecessary final modifier in final class198 - 209
Unnecessary final modifier in final class215 - 228
Unnecessary final modifier in final class236 - 239

ObJectRelationalBridge - org/apache/ojb/broker/metadata/ClassDescriptor.java

ViolationLine
These nested if statements could be combined1349 - 1354
Avoid empty catch blocks1362 - 1367

ObJectRelationalBridge - org/apache/ojb/broker/metadata/ConnectionDescriptorXmlHandler.java

ViolationLine
These nested if statements could be combined441

ObJectRelationalBridge - org/apache/ojb/broker/metadata/DescriptorRepository.java

ViolationLine
These nested if statements could be combined276 - 280
These nested if statements could be combined368 - 371

ObJectRelationalBridge - org/apache/ojb/broker/metadata/JdbcMetadataUtils.java

ViolationLine
Avoid empty catch blocks274 - 275
Avoid empty catch blocks302 - 303
Avoid empty catch blocks323 - 324

ObJectRelationalBridge - org/apache/ojb/broker/metadata/JdbcTypesHelper.java

ViolationLine
Avoid empty catch blocks251 - 254
Avoid empty catch blocks967 - 970

ObJectRelationalBridge - org/apache/ojb/broker/metadata/RepositoryPersistor.java

ViolationLine
Avoid empty catch blocks359 - 361

ObJectRelationalBridge - org/apache/ojb/broker/metadata/RepositoryXmlHandler.java

ViolationLine
Avoid empty if statements779 - 782
These nested if statements could be combined991
These nested if statements could be combined1050

ObJectRelationalBridge - org/apache/ojb/broker/platforms/BlobWrapper.java

ViolationLine
Avoid empty catch blocks80 - 83

ObJectRelationalBridge - org/apache/ojb/broker/platforms/ClobWrapper.java

ViolationLine
Avoid empty catch blocks79 - 82

ObJectRelationalBridge - org/apache/ojb/broker/platforms/PlatformInformixImpl.java

ViolationLine
Avoid empty catch blocks46 - 49
Avoid empty catch blocks58 - 61

ObJectRelationalBridge - org/apache/ojb/broker/platforms/PlatformOracle9iImpl.java

ViolationLine
These nested if statements could be combined500 - 504
These nested if statements could be combined522 - 526
Avoid empty catch blocks660 - 663
Avoid empty catch blocks669 - 672

ObJectRelationalBridge - org/apache/ojb/broker/platforms/PlatformOracleImpl.java

ViolationLine
Avoid empty catch blocks430 - 433

ObJectRelationalBridge - org/apache/ojb/broker/platforms/PlatformPostgreSQLImpl.java

ViolationLine
These nested if statements could be combined187

ObJectRelationalBridge - org/apache/ojb/broker/platforms/PlatformWLOracle9iImpl.java

ViolationLine
Avoid empty catch blocks235 - 238
Avoid empty catch blocks250 - 253

ObJectRelationalBridge - org/apache/ojb/broker/transaction/tm/JBossTransactionManagerFactory.java

ViolationLine
No need to import a type that lives in the same package18

ObJectRelationalBridge - org/apache/ojb/broker/transaction/tm/JOnASTransactionManagerFactory.java

ViolationLine
No need to import a type that lives in the same package18

ObJectRelationalBridge - org/apache/ojb/broker/transaction/tm/OrionTransactionManagerFactory.java

ViolationLine
No need to import a type that lives in the same package18

ObJectRelationalBridge - org/apache/ojb/broker/transaction/tm/SunOneTransactionManagerFactory.java

ViolationLine
No need to import a type that lives in the same package18

ObJectRelationalBridge - org/apache/ojb/broker/transaction/tm/TransactionManagerFactoryFactory.java

ViolationLine
No need to import a type that lives in the same package21

ObJectRelationalBridge - org/apache/ojb/broker/transaction/tm/WebSphereTransactionManagerFactory.java

ViolationLine
No need to import a type that lives in the same package19

ObJectRelationalBridge - org/apache/ojb/broker/transaction/tm/WeblogicTransactionManagerFactory.java

ViolationLine
No need to import a type that lives in the same package18

ObJectRelationalBridge - org/apache/ojb/broker/util/Base64.java

ViolationLine
Avoid unused private fields such as 'BAD_ENCODING'.97
Avoid unused private methods such as 'encode3to4(byte)'.290
Avoid empty catch blocks436 - 439
Avoid empty catch blocks444 - 447
Avoid empty catch blocks452 - 455
Avoid empty catch blocks753 - 756
Avoid empty catch blocks761 - 764

ObJectRelationalBridge - org/apache/ojb/broker/util/BrokerHelper.java

ViolationLine
These nested if statements could be combined109 - 110

ObJectRelationalBridge - org/apache/ojb/broker/util/ClassHelper.java

ViolationLine
Avoid empty catch blocks239 - 240
Avoid empty catch blocks257 - 258
Avoid empty catch blocks377 - 378

ObJectRelationalBridge - org/apache/ojb/broker/util/GUID.java

ViolationLine
These nested if statements could be combined97 - 100

ObJectRelationalBridge - org/apache/ojb/broker/util/ReferenceMap.java

ViolationLine
Avoid empty while statements613 - 615
Ensure you override both equals() and hashCode()981
Ensure you override both equals() and hashCode()1000

ObJectRelationalBridge - org/apache/ojb/broker/util/batch/PreparedStatementInvocationHandler.java

ViolationLine
Avoid empty catch blocks64 - 67
Avoid empty catch blocks97 - 100

ObJectRelationalBridge - org/apache/ojb/broker/util/configuration/impl/OjbConfigurator.java

ViolationLine
Avoid unused private fields such as 'log'.36

ObJectRelationalBridge - org/apache/ojb/broker/util/dbhandling/TorqueDBHandling.java

ViolationLine
Avoid unused local variables such as 'modelTask'.266
Avoid unused local variables such as 'sqlTask'.396

ObJectRelationalBridge - org/apache/ojb/broker/util/logging/LoggerFactoryImpl.java

ViolationLine
Avoid empty catch blocks193

ObJectRelationalBridge - org/apache/ojb/broker/util/logging/LoggingConfiguration.java

ViolationLine
Avoid empty catch blocks151 - 152
Avoid empty catch blocks192 - 193
Avoid empty catch blocks209 - 210

ObJectRelationalBridge - org/apache/ojb/broker/util/logging/PoorMansLoggerImpl.java

ViolationLine
Avoid empty catch blocks301 - 304
Avoid empty catch blocks318 - 321

ObJectRelationalBridge - org/apache/ojb/broker/util/logging/StringBufferLoggerImpl.java

ViolationLine
Avoid empty catch blocks53 - 56
Avoid empty catch blocks64 - 67
Avoid empty catch blocks77 - 80

ObJectRelationalBridge - org/apache/ojb/broker/util/sequence/SequenceManagerHelper.java

ViolationLine
Avoid empty catch blocks364 - 367

ObJectRelationalBridge - org/apache/ojb/broker/util/sequence/SequenceManagerNativeImpl.java

ViolationLine
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet.158

ObJectRelationalBridge - org/apache/ojb/broker/util/sequence/SequenceManagerStoredProcedureImpl.java

ViolationLine
Avoid empty catch blocks259 - 262

ObJectRelationalBridge - org/apache/ojb/odmg/Image.java

ViolationLine
These nested if statements could be combined398 - 401
These nested if statements could be combined415 - 421

ObJectRelationalBridge - org/apache/ojb/odmg/ImplementationImpl.java

ViolationLine
Avoid empty catch blocks342 - 345

ObJectRelationalBridge - org/apache/ojb/odmg/JTATxManager.java

ViolationLine
Avoid empty catch blocks237 - 239

ObJectRelationalBridge - org/apache/ojb/odmg/NamedRootsMap.java

ViolationLine
Avoid empty catch blocks217 - 219

ObJectRelationalBridge - org/apache/ojb/odmg/ObjectEnvelopeOrdering.java

ViolationLine
These nested if statements could be combined438 - 442
These nested if statements could be combined479 - 483
These nested if statements could be combined527 - 531
These nested if statements could be combined568 - 573
These nested if statements could be combined617 - 622
These nested if statements could be combined659 - 663

ObJectRelationalBridge - org/apache/ojb/odmg/ObjectEnvelopeTable.java

ViolationLine
Avoid empty if statements292 - 294

ObJectRelationalBridge - org/apache/ojb/odmg/TransactionImpl.java

ViolationLine
These nested if statements could be combined1019 - 1025

ObJectRelationalBridge - org/apache/ojb/odmg/collections/DListImpl.java

ViolationLine
Avoid empty catch blocks186 - 188
Avoid empty catch blocks229 - 231
Ensure you override both equals() and hashCode()460

ObJectRelationalBridge - org/apache/ojb/odmg/collections/DSetImpl.java

ViolationLine
Overriding method merely calls super138 - 141
Overriding method merely calls super143 - 146

ObJectRelationalBridge - org/apache/ojb/odmg/locking/InMemoryLockMapImpl.java

ViolationLine
These nested if statements could be combined415 - 419

ObJectRelationalBridge - org/apache/ojb/odmg/locking/RepeatableReadStrategy.java

ViolationLine
These nested if statements could be combined83 - 84

ObJectRelationalBridge - org/apache/ojb/odmg/locking/SerializableStrategy.java

ViolationLine
These nested if statements could be combined99 - 100

ObJectRelationalBridge - org/apache/ojb/odmg/oql/OQLLexer.java

ViolationLine
Avoid unused imports such as 'antlr.ANTLRException'27
Avoid unused imports such as 'antlr.CharScanner'30
Avoid unused imports such as 'antlr.CommonToken'35
Avoid unused imports such as 'antlr.MismatchedCharException'38
Avoid unused imports such as 'antlr.SemanticException'43
Avoid unused local variables such as 'theRetToken'.109
Avoid unused local variables such as '_token'.112
Avoid unused local variables such as '_saveIndex'.299
Avoid unused local variables such as '_saveIndex'.312
Avoid unused local variables such as '_saveIndex'.325
Avoid unused local variables such as '_saveIndex'.338
Avoid unused local variables such as '_saveIndex'.351
Avoid unused local variables such as '_saveIndex'.364
Avoid unused local variables such as '_saveIndex'.377
Avoid unused local variables such as '_saveIndex'.392
Avoid unused local variables such as '_saveIndex'.406
Avoid unused local variables such as '_saveIndex'.419
Avoid unused local variables such as '_saveIndex'.432
Avoid unused local variables such as '_saveIndex'.445
Avoid unused local variables such as '_saveIndex'.458
Avoid unused local variables such as '_saveIndex'.471
Avoid unused local variables such as '_saveIndex'.485
Avoid unused local variables such as '_saveIndex'.499
Avoid unused local variables such as '_saveIndex'.513
Avoid unused local variables such as '_saveIndex'.527
Avoid unused local variables such as '_saveIndex'.540
Avoid unused local variables such as '_saveIndex'.553
Avoid unused local variables such as '_saveIndex'.566
Avoid unused local variables such as '_saveIndex'.579
Avoid unused local variables such as '_saveIndex'.592
Avoid unused local variables such as '_saveIndex'.654
Avoid unused local variables such as '_saveIndex'.699
Avoid unused local variables such as '_saveIndex'.725
Avoid unused local variables such as '_saveIndex'.738
Avoid unused local variables such as '_saveIndex'.789
Avoid empty if statements815 - 816
Avoid empty if statements863 - 864
Avoid unused local variables such as '_saveIndex'.979
Avoid unused local variables such as '_saveIndex'.1015
Avoid unused local variables such as '_saveIndex'.1065

ObJectRelationalBridge - org/apache/ojb/odmg/oql/OQLParser.java

ViolationLine
Avoid unused imports such as 'antlr.TokenStreamIOException'23
Avoid unused imports such as 'antlr.ANTLRException'24
Avoid unused imports such as 'antlr.LLkParser'25
Avoid unused imports such as 'antlr.MismatchedTokenException'30
Avoid unused imports such as 'antlr.SemanticException'31
Avoid empty if statements84 - 85
Avoid empty if statements118 - 119
Avoid empty if statements133 - 134
Avoid empty if statements179 - 180
Avoid empty if statements192 - 193
Avoid empty if statements204 - 205
Avoid empty catch blocks302 - 303
Avoid empty if statements426 - 427
Avoid empty if statements502 - 503
Avoid empty if statements772 - 773
Avoid empty if statements854 - 855
Avoid empty if statements897 - 898
Avoid empty if statements909 - 910
Avoid empty if statements946 - 947
Avoid empty if statements1125 - 1126

ObJectRelationalBridge - org/apache/ojb/odmg/oql/OQLQueryImpl.java

ViolationLine
Avoid unused constructor parameters such as 'pbKey'.76 - 78

ObJectRelationalBridge - org/apache/ojb/otm/copy/ReflectiveObjectCopyStrategy.java

ViolationLine
Unnecessary final modifier in final class61 - 64
These nested if statements could be combined115 - 127

ObJectRelationalBridge - org/apache/ojb/otm/copy/SerializeObjectCopyStrategy.java

ViolationLine
Avoid empty catch blocks69 - 72

ObJectRelationalBridge - org/apache/ojb/otm/core/BaseConnection.java

ViolationLine
Avoid unused local variables such as 'ctxObject'.414

ObJectRelationalBridge - org/apache/ojb/otm/core/ConcreteEditingContext.java

ViolationLine
These nested if statements could be combined253 - 267
Ensure you override both equals() and hashCode()606
These nested if statements could be combined635 - 674
Avoid unused private fields such as '_collections'.1569
Avoid unused local variables such as 'lockManager'.1595