The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.
| Tag Class | Total number of occurrences | Tag strings used by tag class |
|---|---|---|
| FIXME's | 0 | FIXME |
| TODO's | 70 | TODO |
Each tag is detailed below:
Number of occurrences found in the code: 70
| org.apache.ojb.broker.PersistenceBroker | Line |
|---|---|
| handle cache problems | 348 |
| delete more than one row if possible | 349 |
| org.apache.ojb.broker.accesslayer.BasePrefetcher | Line |
| this is a quick fix ! | 118 |
| org.apache.ojb.broker.accesslayer.ConnectionManagerImpl | Line |
| avoid this cast | 61 |
| org.apache.ojb.broker.accesslayer.JdbcAccessImpl | Line |
| refactor auto-increment handling, auto-increment should only be supported by PK fields? FieldDescriptor[] fields = cld.getPkFields(); | 787 |
| org.apache.ojb.broker.accesslayer.RsIterator | Line |
| how does prefetchRelationships handle QueryBySQL instances? Is it ok to pass query object? | 189 |
| org.apache.ojb.broker.accesslayer.StatementManager | Line |
| Find a better solution to handle OJB within JBoss --> the JCA implementation should solve this problem | 68 |
| org.apache.ojb.broker.accesslayer.sql.SqlGeneratorDefaultImpl | Line |
| Should we support a procedure call for this too?? | 168 |
| Why do we need this method? | 317 |
| org.apache.ojb.broker.accesslayer.sql.SqlQueryStatement | Line |
| BRJ : This needs refactoring, it looks kind of weird | 1178 |
| add super ClassDescriptor | 1439 |
| parameters list shold be modified when the form is reduced to DNF. | 1797 |
| org.apache.ojb.broker.accesslayer.sql.SqlSelectStatement | Line |
| do not use the superclassfield anymore, just assume that the id is the same in both tables - @see PBroker.storeToDb | 411 |
| org.apache.ojb.broker.cache.ObjectCacheTwoLevelImpl | Line |
| Fix cast. Cast is needed to get access to ReferenceBroker class in PBImpl, see method #lookup | 128 |
| org.apache.ojb.broker.core.MtoNBroker | Line |
| find better solution for m:n handling | 61 |
| to be implemented, must change MtoNImplementor deleteMtoNImplementor(wanted,leftObject) || deleteMtoNImplementor(wanted,rightObject) | 295 |
| org.apache.ojb.broker.core.PersistenceBrokerFactoryDefaultImpl | Line |
| is this useful? | 192 |
| is this useful? | 201 |
| org.apache.ojb.broker.core.PersistenceBrokerFactorySyncImpl | Line |
| Not sure if we should held TransactionBox instances per thread or per transaction object identity. As far as I know it is possible in JTA that thread A starts a tx and thread B commits the tx, thus I start with tx identity as key in registry | 521 |
| org.apache.ojb.broker.core.PersistenceBrokerImpl | Line |
| This workaround doesn't allow 'null' for PK fields | 1778 |
| org.apache.ojb.broker.core.QueryReferenceBroker | Line |
| Should we made this class independend from PB implementation class and only use PB interface methods? | 63 |
| this is a quick fix ! | 345 |
| org.apache.ojb.broker.core.proxy.AbstractProxyFactory | Line |
| Provide handling for pluggable collection proxy implementations | 639 |
| org.apache.ojb.broker.core.proxy.CollectionProxyDefaultImpl | Line |
| returned ManageableCollection should extend Collection to avoid this cast | 191 |
| org.apache.ojb.broker.core.proxy.ProxyFactory | Line |
| Provide handling for pluggable collection proxy implementations | 200 |
| org.apache.ojb.broker.core.proxy.ProxyHelper | Line |
| Provide handling for pluggable collection proxy implementations | 166 |
| org.apache.ojb.broker.metadata.ClassDescriptor | Line |
| Shouldn't the HashMap in DescriptorRepository be updated as well? | 403 |
| drop this method? | 1588 |
| drop this method? | 1596 |
| org.apache.ojb.broker.metadata.ConnectionDescriptorXmlHandler | Line |
| Reading of metadata are split in two classes {@link RepositoryXmlHandler} and {@link ConnectionDescriptorXmlHandler}. Thus we should only read relevant tags in this classes. In further versions we should split repository.dtd in two parts, one for connetion metadata, one for pc object metadata. </p> | 37 |
| org.apache.ojb.broker.metadata.FieldTypeClasses | Line |
| does this make sense?? or Struct instances always Locator objects? | 318 |
| org.apache.ojb.broker.metadata.JdbcMetadataUtils | Line |
| We might be able to use this: metadata.getDatabaseProductName(); | 291 |
| org.apache.ojb.broker.metadata.MetadataManager | Line |
| Be more strict in per thread mode and throw a exception when not find descriptor for calling thread? if (repository == null) { throw new MetadataException("Can't find a DescriptorRepository for current thread, don't forget" + " to set a DescriptorRepository if enable per thread changes before perform other action"); } | 212 |
| adopt copy/clone methods for metadata classes? | 277 |
| adopt copy/clone methods for metadata classes? | 322 |
| org.apache.ojb.broker.metadata.ProcedureDescriptor | Line |
| We may be able to 'pre-calculate' the results of this loop by just checking arguments as they are added The only problem is that the 'isReturnedbyProcedure' property can be modified once the argument is added to this procedure. If that occurs, then 'pre-calculated' results will be inacccurate. | 147 |
| org.apache.ojb.broker.metadata.RepositoryPersistor | Line |
| Refactoring of the metadata reading/handling? | 60 |
| We should re-design the configuration file reading | 252 |
| make this configurable | 300 |
| org.apache.ojb.broker.metadata.RepositoryXmlHandler | Line |
| Reading of metadata are split in two classes {@link RepositoryXmlHandler} and {@link ConnectionDescriptorXmlHandler}. Thus we should only read relevant tags in this classes. In further versions we should split repository.dtd in two parts, one for connetion metadata, one for pc object metadata. </p> | 36 |
| remove this or make offical feature persistent field | 315 |
| org.apache.ojb.broker.metadata.fieldaccess.PersistentFieldBase | Line |
| Default constructor only needed to support PersistentFieldFactory#usesAccessorsAndMutators() method - find a better solution. Make 'public' to allow helper class to instantiate class. | 44 |
| org.apache.ojb.broker.metadata.fieldaccess.PersistentFieldDirectImpl | Line |
| don't make costly proxy test on field level use return field.get(target); | 189 |
| don't make costly proxy test on field level use field.set(target, value); | 220 |
| org.apache.ojb.broker.platforms.PlatformMsAccessImpl | Line |
| implement ms-access escaping | 124 |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl | Line |
| Optimization: use ROWNUM to minimize the effects of not having server side cursors see http://asktom.oracle.com/pls/ask/f?p=4950:8:::::F4950_P8_DISPLAYID:127412348064 | 58 |
| If using Oracle update batching with the thin driver, throw exception on 4k limit | 426 |
| If using Oracle update batching with the thin driver, throw exception on 2k limit | 439 |
| org.apache.ojb.broker.platforms.PlatformWLOracle9iImpl | Line |
| Optimization: use ROWNUM to minimize the effects of not having server side cursors see http://asktom.oracle.com/pls/ask/f?p=4950:8:::::F4950_P8_DISPLAYID:127412348064 | 49 |
| If using Oracle update batching with the thin driver, throw exception on 4k limit | 280 |
| If using Oracle update batching with the thin driver, throw exception on 2k limit | 295 |
| org.apache.ojb.broker.query.QueryByCriteria | Line |
| to be removed when Criteria#addGroupBy is removed | 386 |
| to be removed when Criteria#addOrderBy is removed | 458 |
| to be removed when Criteria#addPrefetchedRelationship is removed | 485 |
| org.apache.ojb.broker.util.BrokerHelper | Line |
| Do we need this check?? String could be nullified, why should we assume it's 'null' on empty string? | 274 |
| Use ColumnName. This is a temporary solution because we cannot yet resolve multiple columns in the same attribute. | 577 |
| Add support for databases that do not support COUNT DISTINCT over multiple columns if (getPlatform().supportsMultiColumnCountDistinct()) { columns[0] = "count(distinct " + getPlatform().concatenate(keyColumns) + ")"; } else { columns = keyColumns; } | 592 |
| --No comment-- | 649 |
| This method should be moved to {@link org.apache.ojb.broker.accesslayer.JdbcAccess} before 1.1 release. | 698 |
| org.apache.ojb.broker.util.SqlHelper | Line |
| cannot resolve multiple attributes in expression ie: price - bonus | 83 |
| org.apache.ojb.broker.util.sequence.SequenceManagerMSSQLGuidImpl | Line |
| never used? remove? /** * returns a unique Object for class clazz and field fieldName. * the returned Object is unique accross all tables in the extent of clazz. */ protected Object getUniqueObject(FieldDescriptor field) throws SequenceManagerException { return getUniqueString(field); } | 132 |
| org.apache.ojb.odmg.DatabaseImpl | Line |
| remove this workaround In managed environments only wrapped tx are returned, so we have to extract the real tx first | 59 |
| org.apache.ojb.odmg.J2EETransactionImpl | Line |
| find out why it's being called twice and fix it. | 43 |
| org.apache.ojb.odmg.JTATxManager | Line |
| only need for development | 91 |
| org.apache.ojb.odmg.ObjectEnvelope | Line |
| do we really need to materialize?? | 102 |
| How to handle version fields incremented by the DB? always refresh the version fields, because these fields will change when written to DB | 215 |
| org.apache.ojb.odmg.ObjectEnvelopeTable | Line |
| remove cast | 746 |
| org.apache.ojb.odmg.TransactionImpl | Line |
| not needed on delete - or? When optimistic locking is used we should always use the specified object instance to use the last version of the object | 585 |
| org.apache.ojb.odmg.locking.InMemoryLockMapImpl | Line |
| smarter solution in future | 72 |
| org.apache.ojb.otm.core.BaseConnection | Line |
| remove all from editing context. | 301 |
