PMD Results

The following document contains the results of PMD 4.2.5.

Files

org/kuali/rice/kns/datadictionary/BusinessObjectEntry.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.datadictionary.DataDictionaryException'18
Avoid unused imports such as 'org.kuali.rice.krad.datadictionary.InactivationBlockingDefinition'19
Avoid unused imports such as 'org.kuali.rice.krad.datadictionary.exception.ClassValidationException'20

org/kuali/rice/kns/datadictionary/DocumentEntry.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.document.authorization.DocumentAuthorizer'20
Avoid unused imports such as 'org.kuali.rice.krad.document.authorization.DocumentPresentationController'21

org/kuali/rice/kns/datadictionary/FieldDefinition.java

ViolationLine
These nested if statements could be combined274 - 276
These nested if statements could be combined280 - 282

org/kuali/rice/kns/datadictionary/MaintainableCollectionDefinition.java

ViolationLine
These nested if statements could be combined125 - 127

org/kuali/rice/kns/datadictionary/MaintainableFieldDefinition.java

ViolationLine
These nested if statements could be combined195 - 197
These nested if statements could be combined201 - 203

org/kuali/rice/kns/datadictionary/MaintenanceDocumentEntry.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.datadictionary.DataDictionary'21
Avoid unused imports such as 'org.kuali.rice.krad.datadictionary.ReferenceDefinition'22
Avoid unused imports such as 'org.kuali.rice.krad.datadictionary.exception.AttributeValidationException'23
Avoid unused imports such as 'org.kuali.rice.krad.datadictionary.exception.ClassValidationException'24
Avoid unused imports such as 'org.kuali.rice.krad.document.authorization.MaintenanceDocumentAuthorizer'30

org/kuali/rice/kns/datadictionary/control/ControlDefinitionBase.java

ViolationLine
Ensure you override both equals() and hashCode()412

org/kuali/rice/kns/datadictionary/validation/MaintenanceDocumentAttributeValueReader.java

ViolationLine
These nested if statements could be combined99 - 101

org/kuali/rice/kns/document/authorization/FieldRestriction.java

ViolationLine
These nested if statements could be combined270 - 278
These nested if statements could be combined274 - 276

org/kuali/rice/kns/document/authorization/MaintenanceDocumentRestrictionsBase.java

ViolationLine
No need to import a type that lives in the same package21
No need to import a type that lives in the same package22
No need to import a type that lives in the same package23

org/kuali/rice/kns/kim/role/PrincipalDerivedRoleTypeServiceImpl.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.kim.api.role.Role'26
No need to import a type that lives in the same package29

org/kuali/rice/kns/kim/role/RoleTypeServiceBase.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.kim.api.role.Role'21

org/kuali/rice/kns/kim/type/DataDictionaryTypeServiceBase.java

ViolationLine
These nested if statements could be combined241 - 253
Avoid empty catch blocks263 - 265
Avoid empty catch blocks434 - 436
Avoid empty catch blocks448 - 450

org/kuali/rice/kns/lookup/AbstractLookupableHelperServiceImpl.java

ViolationLine
These nested if statements could be combined377 - 386
These nested if statements could be combined974 - 976
These nested if statements could be combined1022 - 1029
Avoid unused local variables such as 'fieldsForLookup'.1098

org/kuali/rice/kns/lookup/ExportViewHelper.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.util.GlobalVariables'37

org/kuali/rice/kns/lookup/HtmlData.java

ViolationLine
Avoid unused private methods such as 'getBusinessObjectAuthorizationService()'.207

org/kuali/rice/kns/lookup/KualiLookupableImpl.java

ViolationLine
Avoid unused private fields such as 'LOG'.39

org/kuali/rice/kns/lookup/LookupUtils.java

ViolationLine
These nested if statements could be combined430 - 449
These nested if statements could be combined503 - 505
Avoid unused local variables such as 'attributeRefName'.560
Avoid unused method parameters such as 'nestedObjectPrefix'.630 - 667

org/kuali/rice/kns/maintenance/KualiGlobalMaintainableImpl.java

ViolationLine
These nested if statements could be combined161 - 163
These nested if statements could be combined169 - 171

org/kuali/rice/kns/maintenance/KualiMaintainableImpl.java

ViolationLine
Avoid empty if statements371 - 377
These nested if statements could be combined394 - 397
Avoid empty if statements427 - 435
Avoid unused local variables such as 'cachedValues'.687
These nested if statements could be combined1261 - 1299
Avoid unused local variables such as 'catchme'.1273
Avoid unused local variables such as 'catchme'.1351

org/kuali/rice/kns/maintenance/rules/MaintenanceDocumentRuleBase.java

ViolationLine
Avoid empty catch blocks139 - 141
These nested if statements could be combined767 - 789
These nested if statements could be combined1127 - 1129

org/kuali/rice/kns/rules/PromptBeforeValidationBase.java

ViolationLine
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.221

org/kuali/rice/kns/util/ActionFormUtilMap.java

ViolationLine
These nested if statements could be combined48 - 52

org/kuali/rice/kns/util/FieldUtils.java

ViolationLine
Avoid unused private methods such as 'containsIntermediateNull(Object,String)'.716
These nested if statements could be combined772 - 778
Avoid empty if statements986 - 989
These nested if statements could be combined1038 - 1040
Avoid unused local variables such as 'propertyName'.1177
Unnecessary final modifier in final class1427 - 1431
Unnecessary final modifier in final class1440 - 1442

org/kuali/rice/kns/util/InactiveRecordsHidingUtils.java

ViolationLine
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.83

org/kuali/rice/kns/util/MaintenanceUtils.java

ViolationLine
Unnecessary final modifier in final class156 - 169
Unnecessary final modifier in final class171 - 198
Unnecessary final modifier in final class223 - 225
Unnecessary final modifier in final class227 - 230
Avoid unused private methods such as 'getMaintenanceDocumentService()'.357
Avoid unused private methods such as 'getWorkflowDocumentService()'.364
Avoid unused private methods such as 'getKualiConfigurationService()'.371
Avoid unused private methods such as 'getKualiExceptionIncidentService()'.378

org/kuali/rice/kns/util/WebUtils.java

ViolationLine
Avoid unused local variables such as 'params'.376
Avoid unused local variables such as 'files'.394
These nested if statements could be combined475 - 478
These nested if statements could be combined526 - 529

org/kuali/rice/kns/util/documentserlializer/MaintenanceDocumentPropertySerializibilityEvaluator.java

ViolationLine
Avoid empty if statements69 - 71

org/kuali/rice/kns/web/struts/action/KualiAction.java

ViolationLine
Avoid unused private fields such as 'OUTPUT_ENCRYPTION_WARNING'.78
Avoid unused method parameters such as 'response'.243 - 254
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.521
These nested if statements could be combined607 - 609
Avoid unused method parameters such as 'response'.762 - 795

org/kuali/rice/kns/web/struts/action/KualiDocumentActionBase.java

ViolationLine
These nested if statements could be combined1166 - 1183
Avoid empty catch blocks1306 - 1307
Avoid unused local variables such as 'newNote'.1475

org/kuali/rice/kns/web/struts/action/KualiHelpAction.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.kns.datadictionary.DocumentEntry'32
Avoid unused local variables such as 'label'.317
Avoid unused local variables such as 'objectDescription'.318
Avoid unused local variables such as 'helpForm'.461

org/kuali/rice/kns/web/struts/action/KualiInquiryAction.java

ViolationLine
Avoid unused local variables such as 'kualiInquirable'.299

org/kuali/rice/kns/web/struts/action/KualiLookupAction.java

ViolationLine
Avoid empty if statements121 - 123
These nested if statements could be combined133 - 135
Avoid unused method parameters such as 'request'.164 - 168

org/kuali/rice/kns/web/struts/action/KualiMaintenanceDocumentAction.java

ViolationLine
These nested if statements could be combined240 - 257
Avoid empty catch blocks255
Avoid empty catch blocks796 - 798
Avoid empty catch blocks799 - 801
Avoid empty catch blocks802 - 804
These nested if statements could be combined837 - 840
Avoid unused local variables such as 'documentAuthorizer'.960
Avoid unused local variables such as 'newBo'.966
Avoid unused local variables such as 'maintenanceDocumentAuthorizer'.1002

org/kuali/rice/kns/web/struts/form/InquiryForm.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.service.KRADServiceLocator'30
Avoid unused private fields such as 'inactiveRecordDisplay'.81

org/kuali/rice/kns/web/struts/form/KualiDocumentFormBase.java

ViolationLine
These nested if statements could be combined352 - 354

org/kuali/rice/kns/web/struts/form/KualiForm.java

ViolationLine
Overriding method merely calls super429 - 431

org/kuali/rice/kns/web/struts/form/KualiMaintenanceForm.java

ViolationLine
These nested if statements could be combined119 - 153
These nested if statements could be combined191 - 194
These nested if statements could be combined197 - 200
Avoid unused local variables such as 'docTypeName'.458

org/kuali/rice/kns/web/struts/form/KualiTableRenderFormMetadata.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.kew.exception.WorkflowException'21

org/kuali/rice/kns/web/struts/form/LookupForm.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.krad.service.KRADServiceLocator'25
Avoid unused local variables such as 'ddService'.148
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.227
These nested if statements could be combined327 - 330

org/kuali/rice/kns/web/struts/form/MultipleValueLookupForm.java

ViolationLine
Avoid unused private fields such as 'LOG'.37

org/kuali/rice/kns/web/struts/form/pojo/PojoFormBase.java

ViolationLine
Avoid empty catch blocks185 - 187
Avoid unused method parameters such as 'requestParams'.241 - 259

org/kuali/rice/kns/web/struts/form/pojo/PojoPropertyUtilsBean.java

ViolationLine
Avoid empty catch blocks291 - 292

org/kuali/rice/kns/web/ui/FieldBridge.java

ViolationLine
These nested if statements could be combined258 - 260
These nested if statements could be combined280 - 282
These nested if statements could be combined504 - 506

org/kuali/rice/kns/web/ui/Section.java

ViolationLine
These nested if statements could be combined193 - 195

org/kuali/rice/kns/web/ui/SectionBridge.java

ViolationLine
Avoid unused private methods such as 'getBusinessObjectAuthorizationService()'.65
Avoid unused local variables such as 'row'.103
These nested if statements could be combined356 - 682