The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.student.contract.model.Dictionary defines non-transient non-serializable instance field inlineConstraint | BAD_PRACTICE | SE_BAD_FIELD | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.student.contract.model.Field defines non-transient non-serializable instance field inlineConstraint | BAD_PRACTICE | SE_BAD_FIELD | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.contract.model.State.getEffectiveDate() may expose internal representation by returning State.effectiveDate | MALICIOUS_CODE | EI_EXPOSE_REP | 202 | Medium |
| org.kuali.student.contract.model.State.getExpirationDate() may expose internal representation by returning State.expirationDate | MALICIOUS_CODE | EI_EXPOSE_REP | 211 | Medium |
| org.kuali.student.contract.model.State.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into State.effectiveDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 206 | Medium |
| org.kuali.student.contract.model.State.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into State.expirationDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 215 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.contract.model.Type.getEffectiveDate() may expose internal representation by returning Type.effectiveDate | MALICIOUS_CODE | EI_EXPOSE_REP | 220 | Medium |
| org.kuali.student.contract.model.Type.getExpirationDate() may expose internal representation by returning Type.expirationDate | MALICIOUS_CODE | EI_EXPOSE_REP | 229 | Medium |
| org.kuali.student.contract.model.Type.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into Type.effectiveDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 224 | Medium |
| org.kuali.student.contract.model.Type.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into Type.expirationDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 233 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to schemas in org.kuali.student.contract.model.impl.ServiceContractModelPescXsdLoader.parse() | STYLE | DLS_DEAD_LOCAL_STORE | 149 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.contract.model.util.MessageStructureHierarchyDumper.model | PERFORMANCE | URF_UNREAD_FIELD | 27 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.contract.model.validation.OrchestrationModelValidator.finder | PERFORMANCE | URF_UNREAD_FIELD | 37 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.kuali.student.contract.model.validation.ServiceMethodValidator.findService(String), since all org.kuali.student.contract.model.ServiceContractModel are instances of org.kuali.student.contract.model.ServiceContractModel | STYLE | BC_VACUOUS_INSTANCEOF | 80 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.contract.model.validation.XmlTypesValidator.model | PERFORMANCE | URF_UNREAD_FIELD | 36 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.contract.writer.XmlWriter.writeCommentBox(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 178 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to keys in org.kuali.student.contract.writer.search.SearchModelWriter.getJPQLImplementations() | STYLE | DLS_DEAD_LOCAL_STORE | 300 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.contract.writer.service.PureJavaInfcBeanWriter.directory | PERFORMANCE | URF_UNREAD_FIELD | 49 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.contract.writer.service.PureJavaInfcInfcWriter.directory | PERFORMANCE | URF_UNREAD_FIELD | 49 | Medium |
| Unread field: org.kuali.student.contract.writer.service.PureJavaInfcInfcWriter.service | PERFORMANCE | URF_UNREAD_FIELD | 51 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.contract.writer.service.PureJavaInfcServiceWriter.directory | PERFORMANCE | URF_UNREAD_FIELD | 49 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.contract.writer.service.ServiceExceptionWriter.directory | PERFORMANCE | URF_UNREAD_FIELD | 41 | Medium |
| Unread field: org.kuali.student.contract.writer.service.ServiceExceptionWriter.model | PERFORMANCE | URF_UNREAD_FIELD | 40 | Medium |
| Unread field: org.kuali.student.contract.writer.service.ServiceExceptionWriter.rootPackage | PERFORMANCE | URF_UNREAD_FIELD | 42 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to outputFileNames in org.kuali.student.datadictionary.mojo.KSDictionaryDocMojo.execute() | STYLE | DLS_DEAD_LOCAL_STORE | 146 | Medium |
| Unwritten field: org.kuali.student.datadictionary.mojo.KSDictionaryDocMojo.project | CORRECTNESS | UWF_UNWRITTEN_FIELD | 79 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.kuali.student.datadictionary.util.Dictionary2BeanComparer.compareAddDiscrepancy(List, String, boolean, boolean) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 122 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Suspicious comparison of Integer references in org.kuali.student.datadictionary.util.DictionaryFormatter.calcLength(AttributeDefinition) | CORRECTNESS | RC_REF_COMPARISON | 854 | High |
| Private method org.kuali.student.datadictionary.util.DictionaryFormatter.calcOverride(String, Object, Object) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 1041 | Medium |
| Private method org.kuali.student.datadictionary.util.DictionaryFormatter.calcOverride(String, String, String) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 1025 | Medium |
| Private method org.kuali.student.datadictionary.util.DictionaryFormatter.calcOverride(String, LookupConstraint, LookupConstraint) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 991 | Medium |
| Private method org.kuali.student.datadictionary.util.DictionaryFormatter.calcOverride(String, ValidCharactersConstraint, ValidCharactersConstraint) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 1005 | Medium |
| Private method org.kuali.student.datadictionary.util.DictionaryFormatter.calcOverride(String, boolean, boolean) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 1018 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.datadictionary.util.DictionaryFormatter$AttributeDefinitionNameComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 514 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.datadictionary.util.DictionaryTesterHelper.doTest() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 61 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to pattern in org.kuali.student.datadictionary.util.DictionaryValidator.validateValidChars(AttributeDefinition, ValidCharactersConstraint) | STYLE | DLS_DEAD_LOCAL_STORE | 260 | Medium |
| Unread field: org.kuali.student.datadictionary.util.DictionaryValidator.alreadyValidated | PERFORMANCE | URF_UNREAD_FIELD | 44 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.kuali.student.datadictionary.util.KradDictionaryCreator.predefinedFieldMap from instance method new org.kuali.student.datadictionary.util.KradDictionaryCreator(String, ServiceContractModel, String, boolean, boolean) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 739 | High |
| Write to static field org.kuali.student.datadictionary.util.KradDictionaryCreator.endsWithMap from instance method new org.kuali.student.datadictionary.util.KradDictionaryCreator(String, ServiceContractModel, String, boolean, boolean) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 774 | Medium |
| Write to static field org.kuali.student.datadictionary.util.KradDictionaryCreator.typeMap from instance method new org.kuali.student.datadictionary.util.KradDictionaryCreator(String, ServiceContractModel, String, boolean, boolean) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 797 | Medium |
| Method new org.kuali.student.datadictionary.util.KradDictionaryCreator(String, ServiceContractModel, String, boolean, boolean) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 741 | Medium |
