The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.torque.engine.database.model.Table.toString() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 895 | Medium |
| Method org.apache.torque.engine.database.model.Table.acquireConstraintName(String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 251 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.torque.engine.database.model.TypeMap.initialize() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 355 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Usage of GetResource in org.apache.torque.engine.database.transform.DTDResolver.readFromClasspath(String) may be unsafe if class is extended | BAD_PRACTICE | UI_INHERITANCE_UNSAFE_GETRESOURCE | 83 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.torque.engine.database.transform.XmlToData$ColumnValue be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 185 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.torque.engine.database.transform.XmlToData$DataRow be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 164 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.torque.engine.platform.PlatformMysqlImpl.getSequenceNextVal(Connection, String, String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 131 | Medium |
| Method org.apache.torque.engine.platform.PlatformMysqlImpl.getSequenceNextVal(Connection, String, String) may fail to clean up java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 126 | Medium |
| Method org.apache.torque.engine.platform.PlatformMysqlImpl.getViewDefinition(Connection, String, String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 154 | Medium |
| Method org.apache.torque.engine.platform.PlatformMysqlImpl.getViewDefinition(Connection, String, String) may fail to clean up java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 149 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.torque.engine.platform.PlatformOracleImpl.getSequenceNextVal(Connection, String, String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 117 | Medium |
| Method org.apache.torque.engine.platform.PlatformOracleImpl.getSequenceNextVal(Connection, String, String) may fail to clean up java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 112 | Medium |
| Method org.apache.torque.engine.platform.PlatformOracleImpl.getViewDefinition(Connection, String, String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 138 | Medium |
| Method org.apache.torque.engine.platform.PlatformOracleImpl.getViewDefinition(Connection, String, String) may fail to clean up java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 134 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.torque.task.TorqueDataModelTask.getDataModelDbMap() may expose internal representation by returning TorqueDataModelTask.dataModelDbMap | MALICIOUS_CODE | EI_EXPOSE_REP | 121 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.torque.task.TorqueMergeXMLDoc.writeXMLToFile(Document) may fail to clean up java.io.Writer | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 170 | Medium |
| org.apache.torque.task.TorqueMergeXMLDoc.writeXMLToFile(Document) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 170 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.torque.task.TorqueSQLExec.execute() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 401 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.torque.task.TorqueSQLExec$Transaction.runTransaction(PrintStream) may fail to clean up java.io.Reader | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 764 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.torque.task.TorqueXMLWithDesc.writeXMLToFile(Document) may fail to clean up java.io.Writer | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 114 | Medium |
| org.apache.torque.task.TorqueXMLWithDesc.writeXMLToFile(Document) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 114 | Medium |
| Unread field: org.apache.torque.task.TorqueXMLWithDesc.inputFileString | PERFORMANCE | URF_UNREAD_FIELD | 46 | Medium |
| Unread field: org.apache.torque.task.TorqueXMLWithDesc.outputFileString | PERFORMANCE | URF_UNREAD_FIELD | 41 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.core.db.torque.FilteredPropertyCopier.copyProperties(Object, Object) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 50 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.kuali.core.db.torque.KualiTorqueDataDumpTask.generateXML(Platform) | STYLE | REC_CATCH_EXCEPTION | 357 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.core.db.torque.KualiTorqueSQLTask.createSqlDbMap() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 84 | Medium |
| Method org.kuali.core.db.torque.KualiTorqueSQLTask.createSqlDbMap() may fail to clean up java.io.OutputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 108 | Medium |
| org.kuali.core.db.torque.KualiTorqueSQLTask.createSqlDbMap() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 108 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.core.db.torque.KualiTorqueSchemaDumpTask.getColumns(DatabaseMetaData, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 447 | Medium |
| org.kuali.core.db.torque.KualiTorqueSchemaDumpTask.serialize() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 111 | Medium |
