PMD Results

The following document contains the results of PMD 4.2.5.

Files

org/kuali/rice/kim/impl/group/GroupInternalService.java

ViolationLine
No need to import a type that lives in the same package18

org/kuali/rice/kim/impl/group/GroupLookupableImpl.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.kim.impl.role.RoleBo'12
Avoid unused imports such as 'org.kuali.rice.kim.impl.role.RoleDao'13
Avoid unused imports such as 'org.kuali.rice.kim.impl.services.KimImplServiceLocator'14
Avoid unused imports such as 'org.kuali.rice.krad.util.KRADConstants'16
Avoid duplicate imports such as 'org.kuali.rice.core.api.criteria.PredicateFactory.and'27
Avoid duplicate imports such as 'org.kuali.rice.core.api.criteria.PredicateFactory.lessThan'28

org/kuali/rice/kim/impl/group/GroupServiceBase.java

ViolationLine
Avoid unused private fields such as 'criteriaLookupService'.24

org/kuali/rice/kim/impl/group/GroupServiceImpl.java

ViolationLine
These nested if statements could be combined552 - 554

org/kuali/rice/kim/impl/identity/IdentityCurrentAndArchivedServiceImpl.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.kim.api.identity.principal.EntityNamePrincipalName'37
Avoid unused imports such as 'java.util.List'44
Avoid unused imports such as 'java.util.Map'45

org/kuali/rice/kim/impl/identity/PersonImpl.java

ViolationLine
The null check here is misplaced; if the variable is null therell be a NullPointerException178
These nested if statements could be combined198 - 204

org/kuali/rice/kim/impl/identity/PersonLookupableImpl.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.core.api.criteria.Predicate'4
Avoid unused imports such as 'org.kuali.rice.core.api.criteria.PredicateUtils'5
Avoid unused imports such as 'org.kuali.rice.core.api.criteria.QueryByCriteria'6
Avoid unused imports such as 'org.kuali.rice.kim.api.KimConstants'7
Avoid unused imports such as 'org.kuali.rice.kim.api.group.Group'8
Avoid unused imports such as 'org.kuali.rice.kim.api.group.GroupQueryResults'9
Avoid unused imports such as 'org.kuali.rice.kim.api.group.GroupService'10
Avoid unused imports such as 'org.kuali.rice.kim.impl.group.GroupBo'14
Avoid unused imports such as 'java.sql.Timestamp'18
Avoid unused imports such as 'java.util.ArrayList'19
Avoid unused imports such as 'java.util.Calendar'20
Avoid unused imports such as 'java.util.HashMap'21

org/kuali/rice/kim/impl/identity/PersonServiceImpl.java

ViolationLine
Avoid unused local variables such as 'externalIdentifierCriteria'.360
These nested if statements could be combined388 - 404
These nested if statements could be combined565 - 567

org/kuali/rice/kim/impl/permission/PermissionServiceImpl.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.kim.api.role.Role'36
These nested if statements could be combined202 - 204

org/kuali/rice/kim/impl/responsibility/ResponsibilityServiceImpl.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.kim.api.role.Role'22
Avoid unused method parameters such as 'namespaceCode'.188 - 198
Avoid unused method parameters such as 'namespaceCode'.228 - 237
Avoid unused method parameters such as 'qualification'.423 - 428

org/kuali/rice/kim/impl/responsibility/ReviewResponsibilityMaintainable.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.kim.api.responsibility.Responsibility'23
Avoid unused imports such as 'org.kuali.rice.kim.impl.common.attribute.KimAttributeDataBo'25
Avoid unused imports such as 'org.kuali.rice.kim.impl.permission.PermissionTemplateBo'26

org/kuali/rice/kim/impl/role/RoleDao.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.kim.api.role.RoleMember'4
Avoid unused imports such as 'org.kuali.rice.kim.api.role.RoleMembership'5

org/kuali/rice/kim/impl/role/RoleDaoOjb.java

ViolationLine
Avoid unused imports such as 'org.kuali.rice.kim.api.role.Role'23
Avoid unused imports such as 'org.kuali.rice.kim.api.role.RoleMember'24
Avoid unused imports such as 'org.kuali.rice.kim.api.role.RoleMembership'25
Avoid unused private methods such as 'getPrincipalIdsForPrincipalName(String)'.390
Avoid unused private methods such as 'hasCoreRoleMemberCriteria(Map)'.674
Avoid unused private methods such as 'hasExtraRoleMemberCriteria(Map)'.683
Avoid unused private methods such as 'getRoleMembersRoles(String,String)'.689
Avoid unused private methods such as 'getRoleMembersGroupIds(String,String)'.697

org/kuali/rice/kim/impl/role/RoleServiceBase.java

ViolationLine
These nested if statements could be combined91 - 94

org/kuali/rice/kim/impl/role/RoleServiceImpl.java

ViolationLine
Avoid unused imports such as 'org.joda.time.DateTime'6
Avoid unused imports such as 'org.kuali.rice.kim.api.responsibility.Responsibility'16
Avoid unused imports such as 'org.kuali.rice.kim.impl.responsibility.ResponsibilityAttributeBo'37
Avoid unused imports such as 'org.kuali.rice.kim.impl.responsibility.ResponsibilityBo'38
These nested if statements could be combined905 - 907
These nested if statements could be combined917 - 919
Avoid unused local variables such as 'delegateMember'.1194
Avoid unused private methods such as 'deleteNullMemberAttributeData(List)'.1598
Avoid unused private methods such as 'deleteNullDelegationMemberAttributeData(List)'.1608