The following document contains the results of PMD 4.2.5.
Violation | Line |
---|---|
No need to import a type that lives in the same package | 18 |
Violation | Line |
---|---|
Avoid unused imports such as 'org.kuali.rice.kim.impl.role.RoleBo' | 12 |
Avoid unused imports such as 'org.kuali.rice.kim.impl.role.RoleDao' | 13 |
Avoid unused imports such as 'org.kuali.rice.kim.impl.services.KimImplServiceLocator' | 14 |
Avoid unused imports such as 'org.kuali.rice.krad.util.KRADConstants' | 16 |
Avoid duplicate imports such as 'org.kuali.rice.core.api.criteria.PredicateFactory.and' | 27 |
Avoid duplicate imports such as 'org.kuali.rice.core.api.criteria.PredicateFactory.lessThan' | 28 |
Violation | Line |
---|---|
Avoid unused private fields such as 'criteriaLookupService'. | 24 |
Violation | Line |
---|---|
These nested if statements could be combined | 552 - 554 |
Violation | Line |
---|---|
Avoid unused imports such as 'org.kuali.rice.kim.api.identity.principal.EntityNamePrincipalName' | 37 |
Avoid unused imports such as 'java.util.List' | 44 |
Avoid unused imports such as 'java.util.Map' | 45 |
Violation | Line |
---|---|
The null check here is misplaced; if the variable is null therell be a NullPointerException | 178 |
These nested if statements could be combined | 198 - 204 |
Violation | Line |
---|---|
Avoid unused imports such as 'org.kuali.rice.core.api.criteria.Predicate' | 4 |
Avoid unused imports such as 'org.kuali.rice.core.api.criteria.PredicateUtils' | 5 |
Avoid unused imports such as 'org.kuali.rice.core.api.criteria.QueryByCriteria' | 6 |
Avoid unused imports such as 'org.kuali.rice.kim.api.KimConstants' | 7 |
Avoid unused imports such as 'org.kuali.rice.kim.api.group.Group' | 8 |
Avoid unused imports such as 'org.kuali.rice.kim.api.group.GroupQueryResults' | 9 |
Avoid unused imports such as 'org.kuali.rice.kim.api.group.GroupService' | 10 |
Avoid unused imports such as 'org.kuali.rice.kim.impl.group.GroupBo' | 14 |
Avoid unused imports such as 'java.sql.Timestamp' | 18 |
Avoid unused imports such as 'java.util.ArrayList' | 19 |
Avoid unused imports such as 'java.util.Calendar' | 20 |
Avoid unused imports such as 'java.util.HashMap' | 21 |
Violation | Line |
---|---|
Avoid unused local variables such as 'externalIdentifierCriteria'. | 360 |
These nested if statements could be combined | 388 - 404 |
These nested if statements could be combined | 565 - 567 |
Violation | Line |
---|---|
Avoid unused imports such as 'org.kuali.rice.kim.api.role.Role' | 36 |
These nested if statements could be combined | 202 - 204 |
Violation | Line |
---|---|
Avoid unused imports such as 'org.kuali.rice.kim.api.role.Role' | 22 |
Avoid unused method parameters such as 'namespaceCode'. | 188 - 198 |
Avoid unused method parameters such as 'namespaceCode'. | 228 - 237 |
Avoid unused method parameters such as 'qualification'. | 423 - 428 |
Violation | Line |
---|---|
Avoid unused imports such as 'org.kuali.rice.kim.api.responsibility.Responsibility' | 23 |
Avoid unused imports such as 'org.kuali.rice.kim.impl.common.attribute.KimAttributeDataBo' | 25 |
Avoid unused imports such as 'org.kuali.rice.kim.impl.permission.PermissionTemplateBo' | 26 |
Violation | Line |
---|---|
Avoid unused imports such as 'org.kuali.rice.kim.api.role.RoleMember' | 4 |
Avoid unused imports such as 'org.kuali.rice.kim.api.role.RoleMembership' | 5 |
Violation | Line |
---|---|
Avoid unused imports such as 'org.kuali.rice.kim.api.role.Role' | 23 |
Avoid unused imports such as 'org.kuali.rice.kim.api.role.RoleMember' | 24 |
Avoid unused imports such as 'org.kuali.rice.kim.api.role.RoleMembership' | 25 |
Avoid unused private methods such as 'getPrincipalIdsForPrincipalName(String)'. | 390 |
Avoid unused private methods such as 'hasCoreRoleMemberCriteria(Map)'. | 674 |
Avoid unused private methods such as 'hasExtraRoleMemberCriteria(Map)'. | 683 |
Avoid unused private methods such as 'getRoleMembersRoles(String,String)'. | 689 |
Avoid unused private methods such as 'getRoleMembersGroupIds(String,String)'. | 697 |
Violation | Line |
---|---|
These nested if statements could be combined | 91 - 94 |
Violation | Line |
---|---|
Avoid unused imports such as 'org.joda.time.DateTime' | 6 |
Avoid unused imports such as 'org.kuali.rice.kim.api.responsibility.Responsibility' | 16 |
Avoid unused imports such as 'org.kuali.rice.kim.impl.responsibility.ResponsibilityAttributeBo' | 37 |
Avoid unused imports such as 'org.kuali.rice.kim.impl.responsibility.ResponsibilityBo' | 38 |
These nested if statements could be combined | 905 - 907 |
These nested if statements could be combined | 917 - 919 |
Avoid unused local variables such as 'delegateMember'. | 1194 |
Avoid unused private methods such as 'deleteNullMemberAttributeData(List)'. | 1598 |
Avoid unused private methods such as 'deleteNullDelegationMemberAttributeData(List)'. | 1608 |