The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.
| Tag Class | Total number of occurrences | Tag strings used by tag class |
|---|---|---|
| FIXME's | 38 | FIXME |
| TODO's | 445 | TODO |
Each tag is detailed below:
Number of occurrences found in the code: 38
| org.apache.ojb.broker.platforms.KualiMySQLSequenceManagerImpl | Line |
|---|---|
| should we be closing this connection in a finally block? | 46 |
| should we be closing this result set in a finally block? | 53 |
| org.kuali.rice.core.api.resourceloader.ResourceLoaderContainer | Line |
| RICE MODULARITY | 73 |
| RICE MODULARITY | 79 |
| RICE MODULARITY | 92 |
| org.kuali.rice.core.framework.persistence.jdbc.sql.SqlBuilder | Line |
| wtf - weird! | 187 |
| org.kuali.rice.core.impl.config.module.ModuleConfigurer | Line |
| this class must be put in an API module somehow | 54 |
| attempting to see if this fixes the ksb tests... | 86 |
| org.kuali.rice.core.impl.resourceloader.RiceResourceLoaderFactory | Line |
| RICE MODULARITY hack to not break the hack in ResourceLoaderContainer.moveKSBLoadersDownHack(); | 46 |
| org.kuali.rice.core.util.type.TypeUtils | Line |
| wtf is this? | 52 |
| org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImpl | Line |
| this causes null pointer - actionItemExt.setGroup(actionItem.getGroup()); actionItemExt.setLastApprovedDate(actionItem.getLastApprovedDate()); actionItemExt.setRowStyleClass(); | 122 |
| org.kuali.rice.kew.actionrequest.dao.impl.ActionRequestDAOJpaImpl | Line |
| should be jpa bulk update? | 65 |
| org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl | Line |
| ctk - make sure and check that it's ok to do this here. I may move this out to the doc search processor | 448 |
| any reason this is inside this "if" instead of the outer one, like above - this seems inconsistent | 1027 |
| org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl | Line |
| ctk - make sure and check that it's ok to do this here. I may move this out to the doc search processor | 333 |
| org.kuali.rice.kew.config.ThinClientKEWConfigurer | Line |
| RICE MODULARITY need to fix this class at some point | 26 |
| org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder | Line |
| don't force this when dd changes are in, instead delete line 1 row below and uncomment one two lines below | 113 |
| org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter | Line |
| definitely not the best place for this | 219 |
| org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor | Line |
| Chris get rid of all sortable references! | 57 |
| org.kuali.rice.kew.doctype.DocumentTypePolicyEnum | Line |
| needs docs | 31 |
| org.kuali.rice.kew.dto.DTOConverter | Line |
| we assume there is only one for now | 186 |
| org.kuali.rice.kew.engine.node.dao.impl.RouteNodeDAOJpaImpl | Line |
| Can we do this better using just the JPQL query? | 109 |
| Not sure this query is returning what it needs to | 121 |
| org.kuali.rice.kew.engine.node.var.SetVarNode | Line |
| validation should be checked in documenttypexmlparser to start with | 65 |
| org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImpl | Line |
| Should this check for hibernate LockAcquisitionException | 138 |
| org.kuali.rice.kew.rule.GenericRoleAttribute | Line |
| ok, this MUST return true, as it IS evaluated (don't know why) maybe investigate only calling isMatch on rule attributes as it doesn't seem that matching is relevant for role attributes...is it? throw new UnsupportedOperationException("Role attributes do not implement isMatch"); | 68 |
| org.kuali.rice.kew.rule.dao.impl.RuleAttributeDAOJpaImpl | Line |
| This query is returning multiple rows, which one should it return | 97 |
| org.kuali.rice.kew.rule.dao.impl.RuleDAOJpaImpl | Line |
| nothing uses this, it's not in ruleDAO interface public List findRuleBaseValuesByObjectGraph(RuleBaseValues ruleBaseValues) { ruleBaseValues.setCurrentInd(Boolean.TRUE); ruleBaseValues.setTemplateRuleInd(Boolean.FALSE); return (List) new QueryByObject(entityManager,ruleBaseValues).toQuery().getResultList(); } | 208 |
| org.kuali.rice.kew.rule.service.impl.RuleServiceTest | Line |
| When the operation below throws the expected exception (when JPA/Hibernate is used), it appears to do so while returning from the method call (at which time the expected-to-fail saving operation gets committed by Hibernate). Unfortunately, the exception gets thrown at the wrong time when returning, because any attempts to run subsequent unit tests or unit test methods during the same JUnit test run will fail, due to NOWAIT exceptions during test case startup. | 344 |
| org.kuali.rice.kim.document.rule.AttributeValidationHelper | Line |
| This does not use the correct error path yet - may need to be moved up so that the error path is known Also, the above code would overwrite messages on the same attributes (namespaceCode) but on different rows | 122 |
| org.kuali.rice.kim.service.impl.KimModuleService | Line |
| needs to send unbounded flag | 122 |
| org.kuali.rice.kim.service.impl.UiDocumentServiceImpl | Line |
| Huh!?!?, control is a Map in the above code but a ControlDefinition here?!?!? Maybe this should use the AttributesMapBuilder code to create this | 297 |
| This should be pulling by the PK, not using another method which pulls multiple records and then finds the right one here! | 2117 |
| org.kuali.rice.kim.service.support.impl.KimTypeServiceBase | Line |
| I don't like this - if two attributes have the same sort code, they will overwrite each other | 768 |
| org.kuali.rice.kns.authorization.PermissionDerivedRoleTypeServiceImpl | Line |
| dangerous - data changes could cause an infinite loop - should add thread-local to trap state and abort | 95 |
| org.kuali.rice.kns.util.ObjectUtils | Line |
| (laran) This dependence should be inverted. Instead of having a core class depend on PojoPropertyUtilsBean, which is in the web layer, the web layer should depend downward to the core. | 212 |
| org.kuali.rice.kns.web.struts.action.KualiLookupAction | Line |
| any reason this is inside this "if" instead of the outer one, like above - this seems inconsistent | 307 |
| org.kuali.rice.kns.web.ui.Field | Line |
| this one definitely seems iffy, could be confused with regular fieldType, is there another better name or can this go away? | 109 |
Number of occurrences found in the code: 445
| mocks.MockJavaMailSender | Line |
|---|---|
| g - THIS METHOD NEEDS JAVADOCS | 52 |
| g - THIS METHOD NEEDS JAVADOCS | 62 |
| g - THIS METHOD NEEDS JAVADOCS | 72 |
| g - THIS METHOD NEEDS JAVADOCS | 82 |
| g - THIS METHOD NEEDS JAVADOCS | 92 |
| g - THIS METHOD NEEDS JAVADOCS | 102 |
| g - THIS METHOD NEEDS JAVADOCS | 112 |
| mocks.MockRuleServiceImpl | Line |
| ewestfal - THIS METHOD NEEDS JAVADOCS | 73 |
| org.apache.ojb.broker.platforms.PlatformMckoiImpl | Line |
| Shold we throw some kind of exception here if the escape character is different ? | 175 |
| org.kuali.rice.core.api.criteria.CriteriaTest | Line |
| add a test which tests jaxb with all possible combinations of expressions to make sure they are all getting serialized properly | 104 |
| org.kuali.rice.core.api.criteria.PersonQueryResults | Line |
| --No comment-- | 37 |
| org.kuali.rice.core.api.parameter.ParameterQueryResults | Line |
| --No comment-- | 35 |
| org.kuali.rice.core.framework.persistence.jdbc.sql.Criteria | Line |
| Rewrite this class with a better criteria building algorithm. | 45 |
| org.kuali.rice.core.framework.persistence.jdbc.sql.SqlBuilder | Line |
| What to do here now that the JPA version does not extend platform aware? | 116 |
| What to do here now that the JPA version does not extend platform aware? | 315 |
| org.kuali.rice.core.framework.persistence.jpa.RiceNumericStringSequenceStyleGenerator | Line |
| Make sure this generator works with MySQL, and verify that the correct numeric Hibernate Type is being used in the configure() method override. | 31 |
| Should we add a configuration parameter for allowing users to specify a different supported Hibernate numeric Type if desired? | 40 |
| org.kuali.rice.core.framework.persistence.jpa.metadata.EntityDescriptor | Line |
| Cache by name and probably by class | 142 |
| Cache by name and probably by class | 155 |
| org.kuali.rice.core.framework.persistence.jpa.metadata.MetadataManager | Line |
| Should we add inverse join columns? | 591 |
| Implement default name See: http://www.oracle.com/technology/products/ias/toplink/jpa/resources/toplink-jpa-annotations.html#JoinColumn | 645 |
| org.kuali.rice.core.framework.persistence.ojb.TransactionManagerFactory | Line |
| what to do here return KSBServiceLocator.getTransactionManager(); | 61 |
| org.kuali.rice.core.framework.persistence.platform.DatabasePlatform | Line |
| Had to move this down into embedded source because of the OJB dependencies. This probably will go away once we get rid of the embedded plugin. | 27 |
| refactor to use a parsed Date object or milliseconds instead of date String | 67 |
| This method should be replaced by the "prepared statement" functionality in the future. | 122 |
| org.kuali.rice.core.impl.config.property.AbstractBaseConfig | Line |
| why was this using ConfigContext.getCurrentConfig in the rice BaseConfig | 123 |
| can this be moved to default config file | 172 |
| why going to currentContextConfig | 173 |
| org.kuali.rice.core.impl.config.property.HierarchicalConfigParser | Line |
| consider implementing with iteration instead of recursion, and using the jakarta commons support for parameter expansion | 212 |
| org.kuali.rice.core.impl.impex.xml.ClassLoaderEntityResolver | Line |
| maybe prefix should be changed from "resource:" to "internal:" or just "workflow:" given that it can be resolved in arbitrary ways other than ClassLoader "resources" | 31 |
| revisit making this more sophisticated than just the classloader of this class (thread context classloader? plugin classloader?) | 72 |
| org.kuali.rice.core.impl.impex.xml.XmlExporterServiceImpl | Line |
| KULRICE-4420 - this needs cleanup | 67 |
| org.kuali.rice.core.impl.impex.xml.XmlImpexRegistryImpl | Line |
| --No comment-- | 27 |
| org.kuali.rice.core.impl.parameter.ParameterRepositoryServiceImpl | Line |
| - implement this operation | 177 |
| org.kuali.rice.core.impl.persistence.dao.GenericDaoOjb | Line |
| g1zhang - THIS METHOD NEEDS JAVADOCS | 305 |
| g1zhang - THIS METHOD NEEDS JAVADOCS | 318 |
| org.kuali.rice.core.mail.EmailContent | Line |
| supercede this with Spring framework and/or JavaMail mail classes | 22 |
| org.kuali.rice.core.util.ClassLoaderUtils | Line |
| why not make this so that it throws ClassNoteFoundException and doesn't return null? this is more standard behavior... | 135 |
| org.kuali.rice.core.web.format.Formatter | Line |
| add registry for non-navigable classes so there's a way to disable formatting selectively for given types contained in arrays or Collections. | 274 |
| org.kuali.rice.core.web.format.PhoneNumberFormatter | Line |
| foreign phone numbers can be different lengths end Kuali Foundation modification | 35 |
| org.kuali.rice.core.web.format.TypeFormatter | Line |
| Auto-generated method stub | 39 |
| Auto-generated method stub | 44 |
| org.kuali.rice.edl.impl.EDLServlet | Line |
| Fix this in a better way (reworking the command structure maybe?) fix for KULRICE-4057 to make sure we don't destory docContent on empty command params | 95 |
| Do we not want to set the content type for the response? | 107 |
| org.kuali.rice.edl.impl.OfficeOfAffirmativeActionTest | Line |
| --No comment-- | 107 |
| --No comment-- | 111 |
| --No comment-- | 115 |
| --No comment-- | 119 |
| org.kuali.rice.edl.impl.components.ValidationComponent | Line |
| in the future, allow this to be pluggable, hardcode for now | 106 |
| remove - handled this in the widgets Element edlElement = EDLXmlUtils.getEDLContent(dom, false); Element edlSubElement = EDLXmlUtils.getOrCreateChildElement(edlElement, "data", true); NodeList versionNodes = edlSubElement.getChildNodes(); for (int i = 0; i < versionNodes.getLength(); i++) { Element version = (Element) versionNodes.item(i); String current = version.getAttribute("current"); if (current == "true") { NodeList fieldNodes = version.getChildNodes(); for (int j = 0; j < fieldNodes.getLength(); j++) { Element field = (Element) fieldNodes.item(j); String fieldName = field.getAttribute("name"); if(fieldName.equals(key)) { field.setAttribute("invalid", "true"); break; } } } } | 117 |
| org.kuali.rice.edl.impl.components.WorkflowDocumentActions | Line |
| the problem here is that the XML is still updated on a cancel so we end up without any attribute content in the document content | 112 |
| org.kuali.rice.edl.impl.components.WorkgroupWorkflowEDLConfigComponent | Line |
| add support for namespace here! | 70 |
| org.kuali.rice.kcb.exception.KCBCheckedException | Line |
| arh14 - THIS CONSTRUCTOR NEEDS A JAVADOC | 35 |
| Auto-generated constructor stub | 37 |
| org.kuali.rice.kcb.service.impl.MessageDelivererRegistryServiceImpl | Line |
| we'll need to implement a plugin registry discovery mechanism long term. | 49 |
| org.kuali.rice.kcb.web.spring.UserPreferencesController | Line |
| does not traverse bus yet | 84 |
| org.kuali.rice.ken.deliverer.impl.KEWActionListMessageDeliverer | Line |
| move hardcoded web controller actions here... | 133 |
| org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl | Line |
| modify clone recipient list so that: | 405 |
| org.kuali.rice.ken.service.impl.NotificationServiceImpl | Line |
| implement pessimistic locking on the message delivery | 193 |
| implement pessimistic locking on all these message deliveries now, do dispatch in reverse...dismiss each message delivery via the appropriate deliverer | 218 |
| locking mark as unlocked messageDelivery.setLockedDate(null); | 244 |
| org.kuali.rice.ken.services.impl.NotificationRecipientServiceKimImplTest | Line |
| --No comment-- | 57 |
| org.kuali.rice.ken.util.Util | Line |
| optimize this | 197 |
| org.kuali.rice.ken.util.XslSourceResolver | Line |
| Auto-generated constructor stub | 37 |
| org.kuali.rice.ken.xpath.XPathTest | Line |
| optimize this | 90 |
| org.kuali.rice.kew.actionlist.OutboxTest | Line |
| this can no longer be set on the fly and grabbed through the preference service (default values are set at startup) | 234 |
| this is a prime candidate for a mocking tool | 235 |
| org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImpl | Line |
| , merge will not update the outboxitem pointer to the merged entity | 538 |
| org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOOjbImpl | Line |
| delyea: add all workgroups here? orCrit.addOrCriteria(userCrit); orCrit.addOrCriteria(groupCrit); crit.addAndCriteria(orCrit); crit.addEqualTo("delegationType", KEWConstants.DELEGATION_PRIMARY); filter.setDelegationType(KEWConstants.DELEGATION_PRIMARY); filter.setExcludeDelegationType(false); filteredByItems += filteredByItems.length() > 0 ? ", " : ""; filteredByItems += "Primary Delegator Id"; filterOn = true; } else if (filter.getDelegatorId().trim().equals(KEWConstants.ALL_CODE)) { // user wishes to see all secondary delegations crit.addEqualTo("workflowId", user.getWorkflowUserId().getWorkflowId()); crit.addEqualTo("delegationType", KEWConstants.DELEGATION_SECONDARY); filter.setDelegationType(KEWConstants.DELEGATION_SECONDARY); filter.setExcludeDelegationType(false); filteredByItems += filteredByItems.length() > 0 ? ", " : ""; filteredByItems += "Secondary Delegator Id"; filterOn = true; } else if (filter.getPrimaryDelegateId() != null && !"".equals(filter.getPrimaryDelegateId().trim())) { // user wishes to see primary delegation for a single user Criteria userCrit = new Criteria(); Criteria groupCrit = new Criteria(); Criteria orCrit = new Criteria(); userCrit.addEqualTo("delegatorWorkflowId", user.getWorkflowUserId().getWorkflowId()); | 380 |
| delyea: add all workgroups here? orCrit.addOrCriteria(userCrit); orCrit.addOrCriteria(groupCrit); crit.addAndCriteria(orCrit); crit.addEqualTo("delegationType", KEWConstants.DELEGATION_PRIMARY); filter.setDelegationType(KEWConstants.DELEGATION_PRIMARY); filter.setExcludeDelegationType(false); filteredByItems += filteredByItems.length() > 0 ? ", " : ""; filteredByItems += "Primary Delegator Id"; filterOn = true; } else if (filter.getDelegatorId() != null && !"".equals(filter.getDelegatorId().trim())) { // user wishes to see secondary delegation for a single user crit.addEqualTo("workflowId", user.getWorkflowUserId().getWorkflowId()); crit.addEqualTo("delegationType", KEWConstants.DELEGATION_SECONDARY); filter.setDelegationType(KEWConstants.DELEGATION_SECONDARY); filter.setExcludeDelegationType(false); Criteria userCrit = new Criteria(); Criteria groupCrit = new Criteria(); if (filter.isExcludeDelegatorId()) { Criteria userNull = new Criteria(); userCrit.addNotEqualTo("delegatorWorkflowId", filter.getDelegatorId()); userNull.addIsNull("delegatorWorkflowId"); userCrit.addOrCriteria(userNull); Criteria groupNull = new Criteria(); groupCrit.addNotEqualTo("delegatorWorkgroupId", filter.getDelegatorId()); groupNull.addIsNull("delegatorWorkgroupId"); groupCrit.addOrCriteria(groupNull); crit.addAndCriteria(userCrit); crit.addAndCriteria(groupCrit); } else { Criteria orCrit = new Criteria(); userCrit.addEqualTo("delegatorWorkflowId", filter.getDelegatorId()); groupCrit.addEqualTo("delegatorWorkgroupId", filter.getDelegatorId()); orCrit.addOrCriteria(userCrit); orCrit.addOrCriteria(groupCrit); crit.addAndCriteria(orCrit); } filteredByItems += filteredByItems.length() > 0 ? ", " : ""; filteredByItems += "SeDelegator Id"; filterOn = true; } else if (StringUtils.isBlank(filter.getPrimaryDelegateId()) && StringUtils.isBlank(filter.getDelegatorId())) { crit.addEqualTo("workflowId", user.getWorkflowUserId().getWorkflowId()); if (filter.getDelegationType() != null && !"".equals(filter.getDelegationType().trim())) { if (filter.isExcludeDelegationType()) { Criteria critNotEqual = new Criteria(); Criteria critNull = new Criteria(); critNotEqual.addNotEqualTo("delegationType", filter.getDelegationType()); critNull.addIsNull("delegationType"); critNotEqual.addOrCriteria(critNull); crit.addAndCriteria(critNotEqual); } else { crit.addEqualTo("delegationType", filter.getDelegationType()); } } } | 405 |
| org.kuali.rice.kew.actionrequest.dao.impl.ActionRequestDAOJpaImpl | Line |
| Runtime might not be the right thing to do here... | 255 |
| org.kuali.rice.kew.actionrequest.dao.impl.ActionRequestDAOOjbImpl | Line |
| Runtime might not be the right thing to do here... | 113 |
| org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl | Line |
| this still won't work in certain cases when checking from the root | 792 |
| since we only store the workgroup id for workgroup requests, if the user is in a workgroup that has a request than we need get all the requests with workgroup ids and see if our user is in that group | 988 |
| org.kuali.rice.kew.actions.ActionRegistryImpl | Line |
| ActionTakenEvent is not an interface so we can't fetch them through the GlobalResourceLoader, for now, just use the ObjectDefinitionResolver | 114 |
| the exception handling here is a bit wonky | 118 |
| org.kuali.rice.kew.actions.AdHocRouteTest | Line |
| test adhocing of approve requests | 282 |
| org.kuali.rice.kew.actions.MoveDocumentAction | Line |
| this whole bit is a bit hacky at the moment | 120 |
| org.kuali.rice.kew.actions.ReturnToPreviousNodeAction | Line |
| will this work properly in the case of an ALL APPROVE role requests with some of the requests already completed? | 99 |
| might not need this, if so, do role check | 183 |
| what if the activeNodeInstance already has next nodes? | 400 |
| really we need to call transitionTo on this node, how can we do that? this isn't an issue yet because we only allow simple nodes and split nodes at the moment which do no real work on transitionTo but we may need to enhance that in the future | 410 |
| org.kuali.rice.kew.actions.RouteDocumentAction | Line |
| this will get all pending AR's even if they haven't been in an action list... This seems bad | 99 |
| org.kuali.rice.kew.actions.SuperUserActionRequestApproveEvent | Line |
| this should be checked | 88 |
| org.kuali.rice.kew.actions.SuperUserApproveEvent | Line |
| this is used because calling this code from SuperUserAction without it causes an optimistic lock | 63 |
| org.kuali.rice.kew.actiontaken.ActionTakenValue | Line |
| this stinks to have to have a dependency on UserSession here | 108 |
| this stinks to have to have a dependency on UserSession here | 142 |
| org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOJpaImpl | Line |
| perhaps runtime isn't the best here, maybe a dao runtime exception | 121 |
| org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOOjbImpl | Line |
| perhaps runtime isn't the best here, maybe a dao runtime exception | 111 |
| org.kuali.rice.kew.batch.XmlIngestionTest | Line |
| beef this up need a reliable way to test if the file arrived in the right date-stamped subdirectory (maybe just pick the last, or first directory?) | 161 |
| org.kuali.rice.kew.batch.XmlPollerServiceImpl | Line |
| try reading the pending file or stop? | 216 |
| org.kuali.rice.kew.batch.XmlSchemaTest | Line |
| finish this test when we figure out how to conveniently use namespaces with XPath | 103 |
| org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl | Line |
| ideally implement KNS updates to make this not require code from the parent | 116 |
| set the criteria on this from below method instead of this (so we're not calling out twice for the same object) | 122 |
| can we add something to this to get it to highlight the right field too? Maybe in arg1 | 157 |
| additional BORestrictions through generator or component to lock down per document? | 222 |
| where to get these from? HtmlData returnUrl = new AnchorHtmlData(); | 234 |
| find a better place for this | 269 |
| change this to an enum (or another dd property) | 272 |
| check exisiting formatter here, ideally we should be getting this formatter from col.getFormatter in most cases formatters | 311 |
| can we call into a method in the result processor to get this (or set something on the criteria) propValue = maskValueIfNecessary(element.getClass(), col.getPropertyName(), propValue, businessObjectRestrictions); | 352 |
| change to grab URL from config variable | 361 |
| chris - this method should call the criteria processor adapter which will call the criteria processor (either standard or custom) and massage the data into the proper format this is called by setbo in super(which is called by form) so should be called when the page needs refreshing | 483 |
| move over code that checks for doctype (actually should that be in the refresh, since that's where the doc type will be coming back to?) | 487 |
| This should probably be moved into spring injection since it's a constant | 525 |
| chris - this method should call the criteria processor adapter which will call the criteria processor (either standard or custom) and massage the data into the proper format this is called by setbo in super(which is called by form) so should be called when the page needs refreshing | 568 |
| move over code that checks for doctype (actually should that be in the refresh, since that's where the doc type will be coming back to?) | 572 |
| This should probably be moved into spring injection since it's a constant | 606 |
| also check if standard here (maybe from object if use criteria) | 680 |
| chris - THIS METHOD NEEDS JAVADOCS return super.checkForAdditionalFields(fieldValues); | 857 |
| can we add something to this to get it to highlight the right field too? Maybe in arg1 | 912 |
| is there a better way to override a single field value? | 1059 |
| Chris - (2 stage clear) set the isOnlyDocTypeFilled, to true if only doc type coming in (besides hidden) and false otherwise) | 1240 |
| org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl | Line |
| chris - THIS METHOD NEEDS JAVADOCS | 93 |
| KNS updates to make this not require code from the parent | 112 |
| move this into actual adapter as well | 118 |
| where to get these from? | 165 |
| convert columns either here or in the getColumns method ADDED (3) | 169 |
| change to grab URL from config variable | 250 |
| move this into adapter | 295 |
| temporary work around until is a criteria | 309 |
| chris - this method should call the criteria processor adapter which will call the criteria processor (either standard or custom) and massage the data into the proper format this is called by setbo in super(which is called by form) so should be called when the page needs refreshing | 361 |
| move over code that checks for doctype (actually should that be in the refresh, since that's where the doc type will be coming back to?) | 365 |
| get this from parameters (or bo?) | 384 |
| same Doc type if(docType==oldDocType) { | 387 |
| same Doc type | 394 |
| ctk Add this code back in when KNS impacting changes are worked back | 407 |
| also check if standard here (maybe from object if use criteria) | 430 |
| move these strings to constants (probably after moving this to criteria | 436 |
| org.kuali.rice.kew.clientapp.ThinClientTest | Line |
| remove when http://jira.codehaus.org/browse/SUREFIRE-535 is fixed | 164 |
| org.kuali.rice.kew.config.KEWConfigurer | Line |
| Because a lot of our lifecycles live behind the embedded plugin and the KEWConfigurer does not, this is a simple measure to load these without having to deal with the removal of the embedded plugin right away. | 114 |
| org.kuali.rice.kew.config.ThinClientKEWConfigurer | Line |
| this seems like a total hack the way this is happening, see the addModulesResourceLoaders // method RiceConfigurer as well kewConfigurer.getResourceLoadersToRegister(); } | 45 |
| org.kuali.rice.kew.config.ThinClientResourceLoader | Line |
| we need to add support for other invocation protocols and implementations, but for now... | 185 |
| org.kuali.rice.kew.docsearch.CustomDocumentSearchGeneratorTest | Line |
| delyea - adding underscore below invalidates via REGEX but doesn't blow up on route or addSearchable? | 195 |
| org.kuali.rice.kew.docsearch.DocSearchCriteriaDTO | Line |
| this is here for historic reasons and has been replaced by a managed state in the CriteriaDTO... eliminate | 595 |
| chris - THIS METHOD NEEDS JAVADOCS | 805 |
| org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder | Line |
| Chris, Should be reevaluated in whole after released for KFS This method ... | 88 |
| org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter | Line |
| remove this and use service locator or try helper in WorkflowUtils if sufficient | 45 |
| instead of hardcoding these let's see about getting them from spring | 158 |
| special processing for some field types | 187 |
| can these be used directly in values finder also there is an option key and value property that could probably be used by all of these | 205 |
| fix this in criteria this field shouldn't be blank values otherwise have to reset this for some reason | 212 |
| move to values finder class | 222 |
| can these be used directly in values finder also there is an option key and value property that could probably be used by all of these | 232 |
| fix this in criteria this field shouldn't be blank values otherwise have to reset this for some reason | 239 |
| chris - How should this handle advanced? I thought we were only hiding main | 369 |
| org.kuali.rice.kew.docsearch.DocumentSearchGenerator | Line |
| delyea - documentation | 29 |
| org.kuali.rice.kew.docsearch.DocumentSearchTest | Line |
| Add some wildcard testing for the document type attribute once wildcards are usable with it. | 339 |
| org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator | Line |
| do we really want to allow the document search if there is no User Session? This is mainly to allow for the unit tests to run but I wonder if we need to push the concept of the "executing user" into the doc search api in some way... | 1011 |
| this is currently concatenating strings together with HTML elements, this seems bad in this location, perhaps we should move this to the web layer (and perhaps enhance the searchable attributes portion of the DocSearchDTO data structure?) | 1055 |
| we should probably clean this up some, but we are going to exclude those KeyValues that have a null label. This will happen in the case of Quickfinders which don't really represent criteria anyway. Note however, that it is legal for the label to be the empty string. At some point we will probably need to do some more work to untangle this mess | 1732 |
| org.kuali.rice.kew.docsearch.dao.impl.DocumentSearchDAOJdbcImpl | Line |
| delyea - look at refactoring | 95 |
| delyea: use searchable attribute count here? | 157 |
| org.kuali.rice.kew.docsearch.dao.impl.DocumentSearchDAOOjbImpl | Line |
| delyea - look at refactoring | 95 |
| delyea: use searchable attribute count here? | 166 |
| org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute | Line |
| after face-to-face work in december 2008, this was throwing a nullpointerexception for lookups with date pickers assuming this code will go away after the document search conversion | 524 |
| org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttributeTest | Line |
| put document content here? | 1019 |
| this is currently commented out because we can't test this properly through the unit test since the filtering of the column actually happens in the web-tier. Shoudl this be the case? Maybe we need to re-examine when we refactor document search. | 1214 |
| org.kuali.rice.kew.doctype.ApplicationDocumentStatusId | Line |
| Finish implementing this method. Compare o to pk and return true or false. | 94 |
| Implement this method | 99 |
| org.kuali.rice.kew.doctype.DocumentTypePermissionServiceTest | Line |
| set up actual KIM permissions in DB and verify this permission works | 53 |
| org.kuali.rice.kew.doctype.DocumentTypePolicyId | Line |
| Implement the equals() and hashCode() methods. | 27 |
| Finish implementing this method. Compare o to pk and return true or false. | 98 |
| Implement this method | 103 |
| org.kuali.rice.kew.doctype.service.impl.DocumentTypePermissionServiceImpl | Line |
| See KULRICE-3490, make assembly of permission details dynamic based on db config | 371 |
| org.kuali.rice.kew.document.DocumentTypeMaintainable | Line |
| delyea - do we need to call this multiple times as in "DocumentTypeServiceImpl.save(DocumentType, boolean)" | 149 |
| org.kuali.rice.kew.document.RoutingRuleMaintainable | Line |
| can we just let the locking key be the primary key? (ruleBaseValuesId) | 140 |
| org.kuali.rice.kew.document.RoutingRuleMaintainableBusRule | Line |
| hook validation of rule data into PreRules | 266 |
| org.kuali.rice.kew.dto.DTOConverter | Line |
| delyea - should below be using actionRequest.getRoleName()? | 512 |
| should this be private? If so, rename to convertActionRequestDTO for consistency. | 660 |
| org.kuali.rice.kew.engine.BlanketApproveEngine | Line |
| document magical join node workage (ask Eric) | 111 |
| this has been set arbitrarily high because the implemented processing model here will probably not work for large parallel object graphs. This needs to be re-evaluated, see KULWF-459. | 112 |
| org.kuali.rice.kew.engine.CompatUtils | Line |
| potential for infinite recursion here if their document type has loops in it. Should this be a concern? If their routing version is really "route level" then there should be no cycles. | 55 |
| org.kuali.rice.kew.engine.SequentialRoutingTest | Line |
| when we are able to, we should also verify the RouteNodeInstances are correct | 123 |
| org.kuali.rice.kew.engine.StandardWorkflowEngine | Line |
| throw a new 'RoutingException' which holds the RoutingState | 148 |
| update document content on context? | 227 |
| more info in message | 265 |
| extract this into some sort of component which handles transitioning document state | 386 |
| is the logic for going processed still going to be valid? | 404 |
| perhaps the policies could also be factored out? | 409 |
| factor out this magical post processing | 412 |
| what route method name to pass to this? | 486 |
| in some cases, someone may modify the route header in the post processor, if we don't save before and reload after we will get an optimistic lock exception, we need to work on a better solution for this! | 571 |
| get the routeContext in this method - it should be a better object than the nodeInstance | 574 |
| get the routeContext in this method - it should be a better object than the nodeInstance | 602 |
| get the routeContext in this method - it should be a better object than the nodeInstance | 610 |
| this shows up in a few places and could totally be extracted to a method | 638 |
| get the routeContext in this method - it should be a better object than the nodeInstance | 661 |
| get the routeContext in this method - it should be a better object than the nodeInstance | 673 |
| org.kuali.rice.kew.engine.simulation.SimulationEngine | Line |
| set document content | 133 |
| delyea - deep copy below | 490 |
| org.kuali.rice.kew.engine.transition.DynamicTransitionEngine | Line |
| interate the all the nodes and attach the dynamic node as the 'process' don't include the dynamic node instance in the routing structure - require a correctly built graph change dynamic node signiture to next node because of above reconcile branching if necessary | 39 |
| implement this feature throw new UnsupportedOperationException("Need to implement support for branch generation!"); | 108 |
| org.kuali.rice.kew.help.web.HelpAction | Line |
| hook up KIM permissions to this | 76 |
| hook up KIM permissions to this | 97 |
| hook up KIM permissions to this | 109 |
| implement the help search as a lookupable, rendering this code redundant | 153 |
| org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl | Line |
| is there a reason we reload the document here? | 197 |
| org.kuali.rice.kew.notes.web.AttachmentServlet | Line |
| This should probably be put into KEWConstants when contributed back to Rice 1.0.3 | 54 |
| org.kuali.rice.kew.plugin.HotDeployer | Line |
| somehow the code which checks for new plugins and which loads plugins initially needs to be consolidated, maybe with some sort of set of PluginLocators? or something along those lines? | 101 |
| org.kuali.rice.kew.plugin.PluginRegistryFactory | Line |
| maybe ensure that if these directories are the same, that only one gets through | 39 |
| org.kuali.rice.kew.plugin.ServerPluginRegistry | Line |
| make the delay configurable | 69 |
| org.kuali.rice.kew.plugin.ZipFilePluginLoader | Line |
| how to handle locked files under windows?!? This will throw an IOException in this case. | 119 |
| org.kuali.rice.kew.postprocessor.DocumentRouteLevelChange | Line |
| for now we will include the new node-based routing fields onto this object to avoid an interface change to the PostProcessor interface. | 29 |
| org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl | Line |
| Should this happen??? | 137 |
| org.kuali.rice.kew.responsibility.dao.ResponsibilityIdDAO | Line |
| To change the template for this generated type comment go to Window - Preferences - Java - Code Style - Code Templates | 23 |
| org.kuali.rice.kew.responsibility.service.impl.ResponsibilityIdServiceImpl | Line |
| To change the template for this generated type comment go to Window - Preferences - Java - Code Style - Code Templates | 26 |
| org.kuali.rice.kew.routeheader.AppDocStatusTest | Line |
| when we are able to, we should also verify the RouteNodeInstances are correct | 130 |
| when we are able to, we should also verify the RouteNodeInstances are correct | 211 |
| org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue | Line |
| the isRouteLevelDocument junk can be ripped out | 266 |
| org.kuali.rice.kew.routeheader.StandardDocumentContent | Line |
| can we have application content without a root node? | 117 |
| org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImpl | Line |
| What cache do we clear when using JPA | 151 |
| What cache do we clear when using JPA | 172 |
| org.kuali.rice.kew.routeheader.service.impl.WorkflowDocumentServiceImpl | Line |
| As with superUserReturnDocumentToPreviousNode, we allow for the passing in of a document ID here to allow for the document load inside the current running transaction. Otherwise we get an optimistic lock exception when attempting to save the branch after the transition to the 'A' status. | 347 |
| As with superUserReturnDocumentToPreviousNode, we allow for the passing in of a document ID here to allow for the document load inside the current running transaction. Otherwise we get an optimistic lock exception when attempting to save the branch after the transition to the 'A' status. | 392 |
| remove this implementation in favor of having the SuperUserAction call through the WorkflowDocument object. This method is here to resolve KULWF-727 where we were getting an optimistic lock exception from the super user screen on return to previous node. This allows us to load the DocumentRouteHeaderValue inside of the transaction interceptor so that we can stay within the same PersistenceBroker cache. | 401 |
| org.kuali.rice.kew.routemodule.RouteModuleRemoteAdapter | Line |
| add new findActionRequests to RouteModuleRemote | 54 |
| this should be moved to a validate somewhere's... | 70 |
| org.kuali.rice.kew.routing.web.ClientAppDocHandlerRedirectAction | Line |
| what should happen here if parms are missing; no proper ActionForward from here | 84 |
| org.kuali.rice.kew.rule.AbstractWorkflowAttribute | Line |
| document these two methods ... what are these for? | 66 |
| org.kuali.rice.kew.rule.FlexRM | Line |
| really the route context just needs to be able to support nested create and clears (i.e. a Stack model similar to transaction intercepting in Spring) and we wouldn't have to do this | 172 |
| org.kuali.rice.kew.rule.GenericWorkflowAttribute | Line |
| implement me! | 139 |
| this is not fully implemented! e.g. generic property map like StandardGenericXmlAttribute | 155 |
| org.kuali.rice.kew.rule.TemplateRuleSelector | Line |
| really the route context just needs to be able to support nested create and clears (i.e. a Stack model similar to transaction intercepting in Spring) and we wouldn't have to do this | 84 |
| org.kuali.rice.kew.rule.bo.RuleBaseValuesLookupableHelperServiceImpl | Line |
| jjhanso - THIS METHOD NEEDS JAVADOCS return super.performLookup(lookupForm, resultTable, bounded); | 454 |
| org.kuali.rice.kew.rule.bo.RuleDelegationLookupableHelperServiceImpl | Line |
| jjhanso - THIS METHOD NEEDS JAVADOCS return super.performLookup(lookupForm, resultTable, bounded); | 424 |
| org.kuali.rice.kew.rule.dao.impl.RuleDAOJpaImpl | Line |
| clear the cache | 449 |
| org.kuali.rice.kew.rule.dao.impl.RuleDelegationDAOJpaImpl | Line |
| jjhanso - THIS METHOD NEEDS JAVADOCS | 91 |
| jjhanso - THIS METHOD NEEDS JAVADOCS | 104 |
| org.kuali.rice.kew.rule.service.impl.RuleServiceImpl | Line |
| if more than one delegate is edited from the create delegation screen (which currently can not happen), then this logic will not work. | 192 |
| consolidate this method with makeCurrent. The reason there's a seperate implementation is because the original makeCurrent(...) could not properly handle versioning a List of multiple rules (including multiple delegates rules for a single parent. ALso, this work is being done for a patch so we want to mitigate the impact on the existing rule code. | 246 |
| this method ended up being a mess, we should get rid of this as soon as we can | 1123 |
| FIXME: need to copy the rule expression here too? | 1324 |
| this method is extremely slow, if we could implement a more optimized query here, that would help tremendously | 1421 |
| org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute | Line |
| possibly simplify this even further by making WorkflowAttributeValidationError a WorkflowServiceError, and dispense with custom error generators... | 616 |
| org.kuali.rice.kew.server.BeanConverterTester | Line |
| there is some crossover between this test and the DocumentContentTest, do we really need both of them??? | 106 |
| org.kuali.rice.kew.server.DTOConverterTest | Line |
| there is some crossover between this test and the DocumentContentTest, do we really need both of them??? | 105 |
| org.kuali.rice.kew.service.WorkflowDocument | Line |
| delyea - refactor this to take into account non-initiator owned documents | 763 |
| org.kuali.rice.kew.service.impl.WorkflowUtilityWebServiceImpl | Line |
| confirm that the initiator is not already there in the actionstaken | 516 |
| org.kuali.rice.kew.support.xstream.XStreamSafeEvaluatorTest | Line |
| we currently can't support xpath expressions that start with .// When we can, uncomment this test code. nodeList = (NodeList)xpath.evaluate(XPATH_GLOBAL_VALUE, node, XPathConstants.NODESET); assertEquals("There should be two value elements.", 2, nodeList.getLength()); // evaluate as xstreamsafe nodeList = (NodeList)xpath.evaluate(wrapXStreamSafe(XPATH_GLOBAL_VALUE), node, XPathConstants.NODESET); assertEquals("There should be three value elements now.", 3, nodeList.getLength()); | 174 |
| org.kuali.rice.kew.test.FakeService | Line |
| consider merging with {@link TestServiceInterface}/{@link GenericTestService} in KSB module | 24 |
| org.kuali.rice.kew.test.FakeServiceImpl | Line |
| consider merging with {@link TestServiceInterface}/{@link GenericTestService} in KSB module | 26 |
| org.kuali.rice.kew.useroptions.UserOptionsId | Line |
| Implement the equals() and hashCode() methods. | 26 |
| org.kuali.rice.kew.util.ConfigStringLookup | Line |
| temporarily disabling configuration parameter resolution against the racms because it's been causing some issues | 50 |
| org.kuali.rice.kew.webservice.impl.SimpleDocumentActionsWebServiceImpl | Line |
| how do we want to handle a "Complete" request? | 243 |
| how do we want to handle a "Complete" request? | 361 |
| is this necessary? | 720 |
| do we need to return the standard result set? results = createResults(workflowDocument); | 724 |
| is this necessary? | 777 |
| do we need to return the standard result set? results = createResults(workflowDocument); | 781 |
| is this necessary? | 837 |
| org.kuali.rice.kew.xml.ClassLoaderEntityResolver | Line |
| maybe prefix should be changed from "resource:" to "internal:" or just "workflow:" given that it can be resolved in arbitrary ways other than ClassLoader "resources" | 31 |
| revisit making this more sophisticated than just the classloader of this class (thread context classloader? plugin classloader?) | 72 |
| org.kuali.rice.kew.xml.DocumentTypeXmlParser | Line |
| have a validation function that takes an xpath statement and blows chunks if that statement returns false | 345 |
| org.kuali.rice.kew.xml.RuleExtensionXmlParser | Line |
| need test case for this | 97 |
| org.kuali.rice.kew.xml.export.GroupXmlExporter | Line |
| jjhanso - THIS METHOD NEEDS JAVADOCS | 81 |
| org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator | Line |
| I noticed that the original implementation of this method was not doing the following work so I'm just tacking it on the end, there's probably a more elegent way to integrate it with the algorithm above... | 97 |
| we currently can't support expressions that start with .// | 151 |
| org.kuali.rice.kim.bo.entity.impl.KimEntityPhoneImpl | Line |
| get extension from country code table | 188 |
| append "+xxx" if country is not the default country | 189 |
| get extension from country code table | 232 |
| append "+xxx" if country is not the default country | 233 |
| org.kuali.rice.kim.bo.role.dto.KimPermissionInfo | Line |
| remove this and find a better way to do this. Should be done by next week with role doc task | 129 |
| org.kuali.rice.kim.bo.ui.GroupDocumentMember | Line |
| remove the default | 56 |
| org.kuali.rice.kim.bo.ui.KimDocumentRoleMember | Line |
| remove the default | 58 |
| org.kuali.rice.kim.bo.ui.KimDocumentRoleResponsibility | Line |
| this needs to be changed to use the KimResponsibilityInfo object but the changes are involved in the UiDocumentService based on the copyProperties method used to move the data to/from the document/real objects | 85 |
| org.kuali.rice.kim.bo.ui.KimDocumentRoleResponsibilityAction | Line |
| this needs to be changed to use the KimResponsibilityInfo object but the changes are involved in the UiDocumentService based on the copyProperties method used to move the data to/from the document/real objects | 84 |
| this needs to be changed to use the KimResponsibilityInfo object but the changes are involved in the UiDocumentService based on the copyProperties method used to move the data to/from the document/real objects | 163 |
| org.kuali.rice.kim.bo.ui.PersonDocumentPhone | Line |
| get extension from country code table | 162 |
| append "+xxx" if country is not the default country | 163 |
| org.kuali.rice.kim.client.acegi.KualiDistributedSessionExpiredAuthentication | Line |
| lsymms - THIS METHOD NEEDS JAVADOCS | 40 |
| lsymms - THIS METHOD NEEDS JAVADOCS | 50 |
| org.kuali.rice.kim.client.acegi.KualiDistributedSessionFilter | Line |
| Need to add check for missing DST (update {@link org.kuali.rice.kim.sesn.DistributedSession}) | 32 |
| org.kuali.rice.kim.dao.impl.KimRoleDaoJpa | Line |
| if no role id found that means principalname not matched, need to do something to force to return empty list | 373 |
| org.kuali.rice.kim.dao.impl.KimRoleDaoOjb | Line |
| if no role id found that means principalname not matched, need to do something to force to return empty list | 421 |
| org.kuali.rice.kim.document.rule.IdentityManagementGroupDocumentRule | Line |
| do not have detail bus rule yet, so just check this for now. | 152 |
| org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule | Line |
| do not have detail bus rule yet, so just check this for now. | 549 |
| org.kuali.rice.kim.document.rule.IdentityManagementRoleDocumentRule | Line |
| do not have detail bus rule yet, so just check this for now. | 581 |
| org.kuali.rice.kim.inquiry.PermissionInquirableImpl | Line |
| remove this | 144 |
| org.kuali.rice.kim.inquiry.ResponsibilityInquirableImpl | Line |
| remove this | 140 |
| org.kuali.rice.kim.lookup.KimLookupableHelperServiceImpl | Line |
| to let it rendering 'create new' and 'edit'/'copy' button | 43 |
| org.kuali.rice.kim.lookup.KimTypeLookupableHelperServiceImpl | Line |
| clean this up. | 84 |
| org.kuali.rice.kim.lookup.ResponsibilityLookupableHelperServiceImpl | Line |
| why is this not using the businessObject parmeter's class? | 89 |
| org.kuali.rice.kim.service.impl.GroupServiceBase | Line |
| should it check for valid group ids here? | 59 |
| org.kuali.rice.kim.service.impl.GroupServiceImpl | Line |
| - This could be optimized to get ids in one statement | 240 |
| org.kuali.rice.kim.service.impl.GroupUpdateServiceImpl | Line |
| sgibson - can this be used to change id? | 190 |
| org.kuali.rice.kim.service.impl.IdentityManagementServiceImpl | Line |
| cache this? | 819 |
| org.kuali.rice.kim.service.impl.IdentityServiceImpl | Line |
| - remove this hack... This is here because currently jpa only seems to be going 2 levels deep on the eager fetching. | 297 |
| - Use a DAO | 400 |
| - use a dao? | 420 |
| - what if principal not found, NullPointerException | 421 |
| org.kuali.rice.kim.service.impl.PermissionServiceImpl | Line |
| This could be made a little better by collecting the role IDs into a set and then processing the distinct list rather than a check for every permission | 222 |
| org.kuali.rice.kim.service.impl.PersonServiceImpl | Line |
| - now check if these people have the given role build a principal list | 333 |
| org.kuali.rice.kim.service.impl.RoleServiceBase | Line |
| pulling attribute IDs repeatedly is inefficient - consider caching the entire list as a map | 1225 |
| org.kuali.rice.kim.service.impl.RoleServiceImpl | Line |
| ? get groups for principal and get those as well? this implementation may be incomplete, as groups and sub-roles are not considered | 278 |
| org.kuali.rice.kim.service.impl.UiDocumentServiceImpl | Line |
| in order to resolve optimistic locking issue. has to get entity and set the version number if entity records matched Need to look into this. kimEntity = origEntity; | 170 |
| - remove this hack... This is here because currently jpa only seems to be going 2 levels deep on the eager fetching. | 658 |
| this should be replaced with the retrieval and storage of that value in the document tables and not re-retrieved here | 1257 |
| principalId is not ready here yet ? | 1303 |
| verify if you want to add && newRoleMember.isActive() condition to if... | 1375 |
| verify if you want to add && newRoleMember.isActive() condition to if... | 2196 |
| verify if you want to add && newRoleMember.isActive() condition to if... | 2373 |
| implement logic same as role members - do not insert qualifiers with blank values | 2429 |
| when a group is inactivated, inactivate the memberships of principals in that group and the memberships of that group in roles | 2573 |
| verify if you want to add && newGroupMember.isActive() condition to if... | 2646 |
| org.kuali.rice.kim.service.support.KimPermissionTypeService | Line |
| clarify this description | 42 |
| org.kuali.rice.kim.service.support.impl.KimTypeServiceBase | Line |
| will this work for user ID attributes? | 286 |
| Formatter for currency? | 479 |
| Formatter for currency? | 493 |
| this method looks like it could use some refactoring | 614 |
| use id for defnid ? definition.setId(typeAttribute.getKimAttributeId()); | 766 |
| org.kuali.rice.kim.sesn.DistributedSession | Line |
| add clear principals to clearSesn | 33 |
| org.kuali.rice.kim.sesn.timeouthandlers.AbstractTimeoutHandler | Line |
| change how TimoutHandlers choose fields from ndx to name. | 20 |
| org.kuali.rice.kim.sesn.timeouthandlers.DisabledTimeoutHandler | Line |
| lsymms - THIS METHOD NEEDS JAVADOCS | 33 |
| org.kuali.rice.kim.test.service.PermissionServiceTest | Line |
| - getting a SOAPFaultException on this call; fix and un-comment assertFalse(getPermissionService().hasPermissionByTemplateName("entity124pId", "KUALI", "Default", new AttributeSet())); | 68 |
| - jax-ws remoted service returns null; local return empty List. Fix webservice return | 86 |
| org.kuali.rice.kim.test.service.PersonServiceImplTest | Line |
| property is being appended in the wrong place - fix | 204 |
| org.kuali.rice.kim.web.struts.action.IdentityManagementPersonDocumentAction | Line |
| how should this forward be handled | 607 |
| org.kuali.rice.kim.web.struts.action.IdentityManagementRoleDocumentAction | Line |
| move this into the UI service - action should not be making ORM-layer calls | 114 |
| org.kuali.rice.kns.bo.AdHocRoutePersonId | Line |
| Implement the equals() and hashCode() methods. | 29 |
| org.kuali.rice.kns.bo.AdHocRouteRecipient | Line |
| we should not be referencing kew constants from this class and wedding ourselves to that workflow application Ad Hoc Route Recipient Business Object | 30 |
| org.kuali.rice.kns.bo.AdHocRouteWorkgroupId | Line |
| Implement the equals() and hashCode() methods. | 29 |
| org.kuali.rice.kns.dao.impl.LookupDaoJpa | Line |
| What to do here now that the JPA version does not extend platform aware? propertyName = getDbPlatform().getUpperCaseFunction() + "(__JPA_ALIAS[[0]]__." + propertyName + ")"; | 417 |
| org.kuali.rice.kns.dao.impl.NoteDaoJpa | Line |
| Notes - Chris move remoteObjectId string to constants | 72 |
| org.kuali.rice.kns.dao.impl.NoteDaoOjb | Line |
| Notes - Chris move remoteObjectId string to constants | 84 |
| Notes - Chris move remoteObjectId string to constants | 107 |
| org.kuali.rice.kns.datadictionary.DataDictionary | Line |
| determine property type using generics type definition | 407 |
| org.kuali.rice.kns.datadictionary.DataDictionaryIndexMapper | Line |
| arh14 - THIS METHOD NEEDS JAVADOCS | 166 |
| org.kuali.rice.kns.datadictionary.DocumentCollectionPath | Line |
| mpham - THIS METHOD NEEDS JAVADOCS | 65 |
| org.kuali.rice.kns.datadictionary.DocumentValuePathGroup | Line |
| mpham - THIS METHOD NEEDS JAVADOCS | 65 |
| org.kuali.rice.kns.datadictionary.LookupDefinition | Line |
| catch exception if service locator call fails | 157 |
| org.kuali.rice.kns.datadictionary.RoutingTypeDefinition | Line |
| wliang - THIS METHOD NEEDS JAVADOCS | 65 |
| org.kuali.rice.kns.datadictionary.exporter.AttributesMapBuilder | Line |
| consider whether to export class names from the attribute security | 98 |
| org.kuali.rice.kns.datadictionary.mask.MaskFormatterSubString | Line |
| MOVE TO UNIT TEST: move this validation into the unit tests | 34 |
| org.kuali.rice.kns.datadictionary.validation.ValidationPattern | Line |
| UNIT TEST: compile all patterns to test | 91 |
| org.kuali.rice.kns.document.DocumentAuthorizerBaseTest | Line |
| rewrite this test private static final Logger LOG = Logger.getLogger(DocumentAuthorizerBaseTest.class); | 24 |
| the test for preRouteEditAuthorization should be removed GlobalVariables.setUserSession(new UserSession("quickstart")); PessimisticLockTestDocumentAuthorizer lockDocumentAuthorizer = new PessimisticLockTestDocumentAuthorizer(); lockDocumentAuthorizer.USES_PESSIMISTIC_LOCKING = false; | 522 |
| sp20369 - THIS METHOD NEEDS JAVADOCS | 698 |
| org.kuali.rice.kns.document.DocumentBase | Line |
| Auto-generated method stub | 131 |
| Auto-generated method stub | 468 |
| better error handling at the lower level and a better error message are needed here | 495 |
| org.kuali.rice.kns.document.MaintenanceDocumentBase | Line |
| - build out with bo label once we get the data dictionary stuff in place build out the right classname | 180 |
| refactor this out into a method | 383 |
| better error handling at the lower level and a better error message are needed here | 734 |
| org.kuali.rice.kns.document.authorization.MaintenanceDocumentRestrictionsBase | Line |
| next block could probably be removed since the superclass would return null for a read-only field | 53 |
| org.kuali.rice.kns.inquiry.KualiInquirableImpl | Line |
| replace with inquiry menu bar | 392 |
| org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl | Line |
| why is this not using the businessObject parmeter's class? | 493 |
| org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl | Line |
| Fix? - this does not handle nested properties within the EBO. | 75 |
| org.kuali.rice.kns.lookup.LookupResultsServiceImpl | Line |
| use the other identifier | 164 |
| use the other identifier | 185 |
| org.kuali.rice.kns.lookup.LookupUtils | Line |
| chb: that should not be the case -- the relationship object the two rely upon should be established outside of the lookup/quickfinder code | 471 |
| org.kuali.rice.kns.maintenance.KualiGlobalMaintainableImpl | Line |
| this needs refactoring ... its kind of lame that we have this set of compound list statements, this should all be refactored. This could be moved into a method on all GBOs, like GBO.prepareForSave(), or even better, subclass KualiGlobalMaintainableImpl for each global, since this is all maintainable-related stuff. | 63 |
| remove this whole pseudo-assertion code block once this gets moved into a doc-specific maintainableImpl class. | 73 |
| Revisit this. Changing since getPrimaryKeys and listPrimaryKeyFieldNames are apparently same. May be we might want to replace listPrimaryKeyFieldNames with getPrimaryKeys... Not sure. | 79 |
| org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase | Line |
| Good suggestion from Aaron, dont bother checking the DB, if all of the objects PK fields dont have values. If any are null or empty, then we're done. The current way wont fail, but it will make a wasteful DB call that may not be necessary, and we want to minimize these. | 725 |
| org.kuali.rice.kns.org.kuali.rice.krad.app.persistence.jpa.RiceLocalContainerEntityManagerFactoryBean | Line |
| Add more vendor specific defaults... | 113 |
| org.kuali.rice.kns.service.KualiRuleServiceTest | Line |
| commenting thse out for now, need to analyze and see if it still makes sense with new notes"copied from document " + // sourceDocumentHeaderId); | 391 |
| org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl | Line |
| this requires intimate knowledge of DocumentHelperServiceImpl | 548 |
| org.kuali.rice.kns.service.impl.BusinessObjectDictionaryServiceImpl | Line |
| stupid, change to return int | 323 |
| org.kuali.rice.kns.service.impl.BusinessObjectMetaDataServiceImpl | Line |
| four different exit points?! | 195 |
| move out to a separate method so that the logic for finding the relationships is similar to primitiveReference | 302 |
| org.kuali.rice.kns.service.impl.DictionaryValidationServiceImpl | Line |
| Formatter for currency? | 449 |
| Formatter for currency? | 464 |
| org.kuali.rice.kns.service.impl.DocumentServiceImpl | Line |
| gah! this is awful | 819 |
| org.kuali.rice.kns.service.impl.KualiModuleServiceImpl | Line |
| Warning! Kludge! Hack! Will be replaced! KULRICE-2921 | 218 |
| org.kuali.rice.kns.service.impl.NoteServiceImpl | Line |
| this method seems awfully out of place in this service | 104 |
| Why is a deep copy being done? Nowhere that this is called uses the given note argument again after calling this method. | 116 |
| org.kuali.rice.kns.service.impl.PersistenceStructureServiceJpaImpl | Line |
| Write JPA Version | 109 |
| Write JPA Version | 140 |
| org.kuali.rice.kns.service.impl.RiceApplicationConfigurationMediationServiceImpl | Line |
| I think the code that's below here will actually pull in more than one reference to a particular application's config service if it is deployed in a cluster, it needs to only pull a single RiceApplicationConfigurationService implementation per service namespace. Also, may want to consider load balancing and failover in those cases? It might be best to try and utilize the client-side KSB proxies that handle a lot of this stuff for us | 98 |
| Need a better way to catch if service is not active (404 error) | 125 |
| org.kuali.rice.kns.util.FieldUtils | Line |
| do we need to prefix the universalIdAttributeName in Field as well? | 886 |
| assign the correct propertyName to the container in the first place. For now, I'm wary of the weird usages of constructContainerField(). | 1373 |
| org.kuali.rice.kns.util.KNSUtils | Line |
| this method will probably need to be exposed in a public KNSUtils class as it is used by several different modules. That will have to wait until ModuleService and KualiModuleService are moved to core though. | 135 |
| org.kuali.rice.kns.util.MaintenanceUtils | Line |
| implement real authorization for Maintenance Document Save/Route - KULNRVSYS-948 | 406 |
| org.kuali.rice.kns.util.ObjectUtils | Line |
| The rules about this dot notation needs to be explained in Confluence using examples. | 228 |
| genericize collectionContainsObjectWithIdentitcalKey() to leverage this method? | 711 |
| org.kuali.rice.kns.web.comparator.CellComparatorHelper | Line |
| , do we really need to create so many comparators (1 per each cell)? | 95 |
| org.kuali.rice.kns.web.struts.action.KualiAction | Line |
| create a method for this to be used by both lookup & inquiry ? | 654 |
| org.kuali.rice.kns.web.struts.action.KualiDocumentActionBase | Line |
| this should be pulled into a properties file | 302 |
| remove this when further testing passed if (form instanceof KualiDocumentFormBase) { UserSession userSession = (UserSession) request.getSession().getAttribute(RiceConstants.USER_SESSION_KEY); // force to recreate formkey in execute method if (document instanceof SessionDocument && userSession.retrieveObject(kualiDocumentFormBase.getFormKey()) != null) { userSession.removeObject(kualiDocumentFormBase.getFormKey());; } } | 548 |
| remove this when further testing passed if (form instanceof KualiDocumentFormBase) { UserSession userSession = (UserSession) request.getSession().getAttribute(RiceConstants.USER_SESSION_KEY); // force to recreate formkey in execute method if (document instanceof SessionDocument && userSession.retrieveObject(kualiDocumentFormBase.getFormKey()) != null) { userSession.removeObject(kualiDocumentFormBase.getFormKey());; } } | 588 |
| gah! this is awful | 1381 |
| org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction | Line |
| this code should be abstracted out into a helper also is it a problem that we're not calling setGenerateDefaultValues? it blanked out the below values when I did maybe we need a new generateDefaultValues that doesn't overwrite? | 315 |
| Cathy remember to delete this block of comments after I've tested. PersistableBusinessObject bo = document.getNewMaintainableObject().getBusinessObject(); Collection maintCollection = this.extractCollection(bo, collectionName); String docTypeName = ((MaintenanceDocument) maintenanceForm.getDocument()).getDocumentHeader().getWorkflowDocument().getDocumentType(); Class collectionClass = extractCollectionClass(docTypeName, collectionName); | 534 |
| sort of collection, new instance should be first | 677 |
| Should we keep this logic and continue using currentTabIndex as the key in the tabStates HashMap ? | 738 |
| Should we keep this logic and continue using currentTabIndex as the key in the tabStates HashMap ? | 865 |
| org.kuali.rice.kns.web.struts.form.KualiDocumentFormBase | Line |
| we should not be referencing kew constants from this class and wedding ourselves to that workflow application This class is the base action form for all documents. | 61 |
| is this still needed? I think it's obsolete now | 83 |
| Chris - Notes: remove the above and change the below from boNotes when notes are finished overriding note formatter to make sure they post back the full timestamp | 154 |
| rk implemented to account for caps coming from kuali user service from workflow | 570 |
| org.kuali.rice.kns.web.struts.form.KualiMaintenanceForm | Line |
| to be persisted in the lookup results service instead? | 89 |
| org.kuali.rice.kns.web.struts.form.LookupForm | Line |
| remove these once DD changes have been made | 467 |
| remove these once DD changes have been made | 472 |
| remove these once DD changes have been made | 477 |
| remove these once DD changes have been made | 482 |
| org.kuali.rice.kns.web.struts.pojo.PojoFormBase | Line |
| see KULOWF-194 testForPojoHack(this, keypath); | 181 |
| org.kuali.rice.kns.web.ui.FieldBridge | Line |
| St. Ailish says review this. A question was raised on 11-16-2006 Tuscon meeting as to why this is done here and not in the formatter. | 310 |
| org.kuali.rice.kns.web.ui.SectionBridge | Line |
| Revisit this. Changing since getPrimaryKeys and listPrimaryKeyFieldNames are apparently same. May be we might want to replace listPrimaryKeyFieldNames with getPrimaryKeys... Not sure. | 753 |
| org.kuali.rice.kns.workflow.DataDictionarySearchableAttributeTest | Line |
| Add the commented-out boolean search expressions back in once KULRICE-3698 is complete. | 186 |
| org.kuali.rice.kns.workflow.attribute.DataDictionarySearchableAttribute | Line |
| this is a workaround to hide the Field from the search criteria. This should be removed once hiding the entire Row is working | 256 |
| org.kuali.rice.kns.workflow.attribute.KualiXmlAttributeHelper | Line |
| - enter JIRA below removes wf:xstreamsafe( and ) below separates each wf:xstreamsafe() section into separate 'finds' | 55 |
| - Fix the document content element generation | 141 |
| org.kuali.rice.kns.workflow.service.impl.WorkflowDocumentServiceImpl | Line |
| make the 1 a constant | 365 |
| org.kuali.rice.krms.api.Asset | Line |
| make this pretty | 68 |
| org.kuali.rice.krms.api.EngineResults | Line |
| - need to determine what goes here... | 7 |
| org.kuali.rice.krms.api.ExecutionEnvironment | Line |
| we don't support updating facts, refactor this method | 26 |
| org.kuali.rice.krms.api.repository.ActionAttribute | Line |
| verify that the attributeDefinitionID field matches the id field in the builder | 191 |
| org.kuali.rice.krms.api.repository.KrmsTypeAttribute | Line |
| verify that the attributeDefinitionID field matches the id field in the builder | 198 |
| org.kuali.rice.krms.api.repository.Proposition | Line |
| check against valid values ? | 260 |
| org.kuali.rice.krms.api.repository.PropositionParameter | Line |
| isBlank or is null ??? | 171 |
| check against valid values | 185 |
| org.kuali.rice.krms.api.repository.RuleAttribute | Line |
| verify that the attributeDefinitionID field matches the id field in the builder | 191 |
| org.kuali.rice.krms.framework.AssetResolutionEngineTest | Line |
| test exception variants: - AssetResolver throws AssetResolutionException - AssetResolutionService is passed a null asset | 248 |
| what should the AssetResolutionService do if a resolver throws a RuntimeException? | 253 |
| org.kuali.rice.krms.framework.engine.AssetResolutionEngineImpl | Line |
| could cache these plans somewhere, since future agendas will likely require the same plans | 56 |
| try to extract some methods out to shorten this beast | 84 |
| is this right? will this make trouble? We've already visited this one | 123 |
| org.kuali.rice.krms.framework.engine.BasicExecutionEnvironment | Line |
| inject this (will have to make it non-final) | 37 |
| org.kuali.rice.krms.framework.engine.CollectionOfComparablesTermBasedProposition | Line |
| Something better than this | 31 |
| log this appropriately | 42 |
| org.kuali.rice.krms.framework.engine.ComparableTermBasedProposition | Line |
| Something better than this | 30 |
| org.kuali.rice.krms.framework.engine.EngineResultsImpl | Line |
| Auto-generated method stub | 24 |
| Auto-generated method stub | 30 |
| org.kuali.rice.krms.framework.engine.ExecutionOptions | Line |
| delete this? We're only using the enum thus far | 8 |
| org.kuali.rice.krms.framework.engine.StringTermBasedProposition | Line |
| remove? ComparableTermBasedProposition does this generically | 5 |
| org.kuali.rice.krms.framework.engine.result.Log4jResultListener | Line |
| Auto-generated method stub | 13 |
| org.kuali.rice.krms.framework.repository.ContextDefinition | Line |
| --No comment-- | 5 |
| org.kuali.rice.krms.impl.repository.RuleRepositoryContextProvider | Line |
| ...translate repository data model to execution model | 23 |
| org.kuali.rice.krms.impl.repository.SimpleRuleRepositoryImpl | Line |
| synchronize here | 43 |
| org.kuali.rice.ksb.config.xfire.XFireWSS4JInHandler | Line |
| Replace this class with cxf wss4j in interceptor | 31 |
| org.kuali.rice.ksb.config.xfire.XFireWSS4JOutHandler | Line |
| Replace this class with a cxf wss4j out interceptor | 30 |
| org.kuali.rice.ksb.messaging.DelayedAsynchronousServiceTest | Line |
| this isn't the best test ever because it's relying on waits and timing which is most likely doomed to occasional failure in the CI environment. If this occurs than I may need to yank this. A better long term solution would be to allow for the use of callbacks for delayed asynchronous services but that's not something I wanted to try to tackle at the moment | 73 |
| org.kuali.rice.ksb.messaging.JmsMessagingNoRun | Line |
| renable this test | 26 |
| org.kuali.rice.ksb.messaging.RemoteResourceServiceLocatorImpl | Line |
| What is this all about? | 206 |
| org.kuali.rice.ksb.messaging.RemotedServiceRegistryImpl | Line |
| we are not verifying that this read is not being done in dev mode in a test | 312 |
| org.kuali.rice.ksb.messaging.service.impl.BusAdminServiceImpl | Line |
| there's probably a better way to servisize or refactor this | 46 |
| org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector | Line |
| we need to add support for other invocation protocols and implementations, but for now... | 99 |
| org.kuali.rice.ksb.messaging.web.MessageQueueAction | Line |
| better error handling here | 396 |
| org.kuali.rice.ksb.messaging.web.ServiceRegistryAction | Line |
| is this what really constitutes a "refresh" of the service registry? | 59 |
| org.kuali.rice.ksb.security.soap.CXFWSS4JInInterceptor | Line |
| Replace this class with cxf wss4j in interceptor | 42 |
| org.kuali.rice.ksb.testclient1.JaxWsEchoServiceImpl | Line |
| Will Gomes - THIS METHOD NEEDS JAVADOCS | 40 |
| org.kuali.rice.test.data.UnitTestData | Line |
| Come back and add the JPQL equivalents | 39 |
| org.kuali.rice.test.lifecycles.SQLDataLoaderLifecycle | Line |
| may way to do something with the dataLoader | 59 |
