The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: org.kuali.rice.kns.authorization.BusinessObjectAuthorizerBase.persistenceStructureService | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kns.bo.AdHocRouteWorkgroupId.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.bo.SessionDocument.getSerializedDocumentForm() may expose internal representation by returning SessionDocument.serializedDocumentForm | MALICIOUS_CODE | EI_EXPOSE_REP | 62 | Medium |
| org.kuali.rice.kns.bo.SessionDocument.setSerializedDocumentForm(byte[]) may expose internal representation by storing an externally mutable object into SessionDocument.serializedDocumentForm | MALICIOUS_CODE | EI_EXPOSE_REP2 | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to collectionClasses in org.kuali.rice.kns.datadictionary.DataDictionary.buildReadDescriptor(Class, String) | STYLE | DLS_DEAD_LOCAL_STORE | 513 | Medium |
| Dead store to collectionClasses in org.kuali.rice.kns.datadictionary.DataDictionary.getCollectionElementClass(Class, String) | STYLE | DLS_DEAD_LOCAL_STORE | 454 | Medium |
| Dead store to indexName in org.kuali.rice.kns.datadictionary.DataDictionary.indexSource(String) | STYLE | DLS_DEAD_LOCAL_STORE | 119 | Medium |
| org.kuali.rice.kns.datadictionary.DataDictionary.persistenceStructureService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| Write to static field org.kuali.rice.kns.datadictionary.DataDictionary.validateEBOs from instance method org.kuali.rice.kns.datadictionary.DataDictionary.validateDD() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 180 | High |
| Write to static field org.kuali.rice.kns.datadictionary.DataDictionary.validateEBOs from instance method org.kuali.rice.kns.datadictionary.DataDictionary.validateDD(boolean) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 168 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of sourceClass in org.kuali.rice.kns.datadictionary.PrimitiveAttributeDefinition.completeValidation(Class, Class) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 103 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.ButtonControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 30 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.CheckboxControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 29 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.ControlDefinitionBase defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 411 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.CurrencyControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 37 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.FileControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.HiddenControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 27 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.KualiUserControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 48 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.LinkControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.LookupHiddenControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 28 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.LookupReadonlyControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 28 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.MultiselectControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 27 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.RadioControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 28 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.SelectControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 32 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.TextControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 29 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.TextareaControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 27 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.WorkflowWorkgroupControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 32 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to regexString in org.kuali.rice.kns.datadictionary.validation.CharacterLevelValidationPattern.getRegexPattern() | STYLE | DLS_DEAD_LOCAL_STORE | 81 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of exportMap in org.kuali.rice.kns.datadictionary.validation.charlevel.RegexValidationPattern.extendExportMap(ExportMap) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 53 | High |
| Nullcheck of exportMap at line 58 of value previously dereferenced in org.kuali.rice.kns.datadictionary.validation.charlevel.RegexValidationPattern.extendExportMap(ExportMap) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 53 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.kuali.rice.kns.document.MaintenanceDocumentBase.validateBusinessRules(KualiDocumentEvent), since all org.kuali.rice.kns.document.MaintenanceDocumentBase are instances of org.kuali.rice.kns.document.MaintenanceDocument | STYLE | BC_VACUOUS_INSTANCEOF | 707 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.document.authorization.DocumentAuthorizerBase.LOG isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 46 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.document.authorization.MaintenanceDocumentPresentationControllerBase.maintenanceDocumentDictionaryService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.inquiry.KualiInquirableImpl.businessObjectService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.kuali.rice.kns.inquiry.KualiInquirableImpl.SUPER_CLASS_TRANSLATOR_LIST isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 91 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to fieldsForLookup in org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 1094 | High |
| Dead store to fields in org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.setRows() | STYLE | DLS_DEAD_LOCAL_STORE | 1045 | Medium |
| org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.getSupplementalMenuBar() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 1366 | Medium |
| org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.RESULTS_DEFAULT_MAX_COLUMN_LENGTH should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 704 | Medium |
| Method org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.preprocessDateFields(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 1232 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to elementClass in org.kuali.rice.kns.lookup.HtmlData.getTitleText(String, Class, Map) | STYLE | DLS_DEAD_LOCAL_STORE | 214 | Medium |
| Method org.kuali.rice.kns.lookup.HtmlData.getTitleText(String, Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 217 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl.getExternalizableBusinessObjectFieldValues(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 159 | Medium |
| Method org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 227 | Medium |
| Method org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl.removeExternalizableBusinessObjectFieldValues(Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 142 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.lookup.LookupUtils.generateFieldConversions(BusinessObject, String, BusinessObjectRelationship, String, List, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 671 | Medium |
| Method org.kuali.rice.kns.lookup.LookupUtils.generateLookupParameters(BusinessObject, String, BusinessObjectRelationship, String, List, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 709 | Medium |
| Method org.kuali.rice.kns.lookup.LookupUtils.getNestedBusinessObject(BusinessObject, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 620 | Medium |
| Method org.kuali.rice.kns.lookup.LookupUtils.setFieldDirectInquiry(Field) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 494 | Medium |
| Write to static field org.kuali.rice.kns.lookup.LookupUtils.businessObjectDictionaryService from instance method org.kuali.rice.kns.lookup.LookupUtils.setBusinessObjectDictionaryService(BusinessObjectDictionaryService) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 76 | High |
| Write to static field org.kuali.rice.kns.lookup.LookupUtils.businessObjectMetaDataService from instance method org.kuali.rice.kns.lookup.LookupUtils.setBusinessObjectMetaDataService(BusinessObjectMetaDataService) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 96 | High |
| Write to static field org.kuali.rice.kns.lookup.LookupUtils.dataDictionaryService from instance method org.kuali.rice.kns.lookup.LookupUtils.setDataDictionaryService(DataDictionaryService) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 80 | High |
| Write to static field org.kuali.rice.kns.lookup.LookupUtils.dateTimeService from instance method org.kuali.rice.kns.lookup.LookupUtils.setDateTimeService(DateTimeService) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 88 | High |
| Write to static field org.kuali.rice.kns.lookup.LookupUtils.persistenceStructureService from instance method org.kuali.rice.kns.lookup.LookupUtils.setPersistenceStructureService(PersistenceStructureService) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 84 | High |
| Method org.kuali.rice.kns.lookup.LookupUtils.forceUppercase(Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 168 | Medium |
| Method org.kuali.rice.kns.lookup.LookupUtils.getPrimitiveReference(BusinessObject, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 576 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to cachedValues in org.kuali.rice.kns.maintenance.KualiMaintainableImpl.setGenerateDefaultValues(String) | STYLE | DLS_DEAD_LOCAL_STORE | 659 | Medium |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.getMultiValueIdentifierList(Collection, List) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 502 | Medium |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.hasBusinessObjectExisted(BusinessObject, List, List) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 514 | Medium |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.businessObjectAuthorizationService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.businessObjectDictionaryService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.businessObjectMetaDataService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.businessObjectService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.dataDictionaryService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.documentHelperService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.encryptionService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.maintenanceDocumentDictionaryService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.maintenanceDocumentService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.persistenceStructureService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.personService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.getMultiValueIdentifierList(Collection, List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 504 | Medium |
| Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.hasBusinessObjectExisted(BusinessObject, List, List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 516 | Medium |
| Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.decryptEncryptedData(Map, MaintenanceDocument, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 192 | Medium |
| Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.performFieldForceUpperCase(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 1322 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to fieldValues in org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase.putInactivationBlockingErrorOnPage(MaintenanceDocument, InactivationBlockingMetadata) | STYLE | DLS_DEAD_LOCAL_STORE | 310 | Medium |
| Invocation of toString on org.kuali.rice.kns.util.ErrorMessage.getMessageParameters() in org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase.showErrorMap() | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 1108 | Medium |
| org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase.LOG isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 80 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docOrBoClass in org.kuali.rice.kns.rules.DocumentRuleBase.isAddHocRoutePersonValid(Document, AdHocRoutePerson) | STYLE | DLS_DEAD_LOCAL_STORE | 388 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to meshedRows in org.kuali.rice.kns.util.FieldUtils.meshSections(List, List, List, String, boolean, MaintenanceDocumentRestrictions, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 1073 | Medium |
| Method org.kuali.rice.kns.util.FieldUtils.fixFieldForForm(Field, List, String, String, boolean, MaintenanceDocumentRestrictions, String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 842 | Medium |
| Method org.kuali.rice.kns.util.FieldUtils.populateBusinessObjectFromMap(BusinessObject, Map, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 732 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.util.InactiveRecordsHidingUtils.setShowInactiveRecords(Map, String, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 83 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.util.KNSUtils.getIntegerValue(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 102 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to equals() with null argument in org.kuali.rice.kns.util.ObjectUtils.isNull(Object) | CORRECTNESS | EC_NULL_ARG | 833 | Medium |
| Method org.kuali.rice.kns.util.ObjectUtils.createHybridBusinessObject(BusinessObject, BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 193 | Medium |
| Method org.kuali.rice.kns.util.ObjectUtils.equalByKeys(PersistableBusinessObject, PersistableBusinessObject) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 670 | Medium |
| Method org.kuali.rice.kns.util.ObjectUtils.materializeSubObjectsToDepth(PersistableBusinessObject, int) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 933 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.kns.web.struts.pojo.PojoFormBase to org.kuali.rice.kns.web.struts.form.KualiDocumentFormBase in org.kuali.rice.kns.util.WebUtils.isFormSessionDocument(PojoFormBase) | STYLE | BC_UNCONFIRMED_CAST | 482 | Medium |
| instanceof will always return true in org.kuali.rice.kns.util.WebUtils.getMethodToCallSettingAttribute(ActionForm, HttpServletRequest, String), since all org.apache.struts.action.ActionForm are instances of org.apache.struts.action.ActionForm | STYLE | BC_VACUOUS_INSTANCEOF | 185 | Medium |
| Dead store to params in org.kuali.rice.kns.util.WebUtils.getMultipartParameters(HttpServletRequest, ActionServletWrapper, ActionForm, ActionMapping) | STYLE | DLS_DEAD_LOCAL_STORE | 365 | High |
| Dead store to files in org.kuali.rice.kns.util.WebUtils.getMultipartParameters(HttpServletRequest, ActionServletWrapper, ActionForm, ActionMapping) | STYLE | DLS_DEAD_LOCAL_STORE | 383 | Medium |
| org.kuali.rice.kns.util.WebUtils.KEY_KUALI_FORM_IN_SESSION isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 488 | High |
| Method org.kuali.rice.kns.util.WebUtils.filterHtmlAndReplaceRiceMarkup(String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 714 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.rice.kns.util.documentserializer.DocumentSerializationState$SerializationPropertyElement be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 37 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.rice.kns.util.documentserializer.SerializationState$SerializationPropertyElement be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 35 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.web.EditablePropertiesHistoryHolder.getMaxHistoryLength() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 61 | Medium |
| org.kuali.rice.kns.web.EditablePropertiesHistoryHolder is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 40 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on textAreaParams in org.kuali.rice.kns.web.struts.action.KualiAction.getTextAreaParams(HttpServletRequest) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 1045 | Medium |
| Invocation of toString on inquiryParams in org.kuali.rice.kns.web.struts.action.KualiAction.performInquiry(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 657 | Medium |
| org.kuali.rice.kns.web.struts.action.KualiAction.performLookup(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 532 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to newNote in org.kuali.rice.kns.web.struts.action.KualiDocumentActionBase.deleteBONote(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 1464 | Medium |
| org.kuali.rice.kns.web.struts.action.KualiDocumentActionBase.DOCUMENT_LOAD_COMMANDS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 117 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.kns.web.struts.form.InquiryForm defines non-transient non-serializable instance field inquirable | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.web.struts.form.KualiForm.getHeaderNavigationTabs() may expose internal representation by returning KualiForm.headerNavigationTabs | MALICIOUS_CODE | EI_EXPOSE_REP | 277 | Medium |
| org.kuali.rice.kns.web.struts.form.KualiForm.setHeaderNavigationTabs(HeaderNavigation[]) may expose internal representation by storing an externally mutable object into KualiForm.headerNavigationTabs | MALICIOUS_CODE | EI_EXPOSE_REP2 | 286 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docTypeName in org.kuali.rice.kns.web.struts.form.KualiMaintenanceForm.getAdditionalSectionsFile() | STYLE | DLS_DEAD_LOCAL_STORE | 454 | Medium |
| Method org.kuali.rice.kns.web.struts.form.KualiMaintenanceForm.populate(HttpServletRequest) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 243 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ddService in org.kuali.rice.kns.web.struts.form.LookupForm.populate(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 147 | Medium |
| org.kuali.rice.kns.web.struts.form.LookupForm.populate(HttpServletRequest) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 226 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.kns.web.struts.form.MultipleValueLookupForm defines non-transient non-serializable instance field tableMetadata | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.web.struts.pojo.PojoFormBase.populate(HttpServletRequest) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 155 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.web.ui.Field.getPropertyValues() may expose internal representation by returning Field.propertyValues | MALICIOUS_CODE | EI_EXPOSE_REP | 1607 | Medium |
| org.kuali.rice.kns.web.ui.Field.setPropertyValues(String[]) may expose internal representation by storing an externally mutable object into Field.propertyValues | MALICIOUS_CODE | EI_EXPOSE_REP2 | 1611 | Medium |
| Method org.kuali.rice.kns.web.ui.Field.setLookupParameters(Map) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 883 | Medium |
| Method org.kuali.rice.kns.web.ui.Field.setFieldConversions(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 792 | Medium |
| Method org.kuali.rice.kns.web.ui.Field.setLookupParameters(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 880 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.web.ui.FieldBridge.getNewFormFields(CollectionDefinitionI, BusinessObject, Maintainable, List, Set, StringBuffer, String, boolean, int) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 398 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.web.ui.FormatAwareDecorator.createCollectionString(Object) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 75 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to row in org.kuali.rice.kns.web.ui.SectionBridge.toSection(Inquirable, InquirySectionDefinition, BusinessObject, InquiryRestrictions) | STYLE | DLS_DEAD_LOCAL_STORE | 101 | Medium |
| Dead store to sectionRows in org.kuali.rice.kns.web.ui.SectionBridge.toSection(Inquirable, InquirySectionDefinition, BusinessObject, InquiryRestrictions) | STYLE | DLS_DEAD_LOCAL_STORE | 107 | Medium |
| Method org.kuali.rice.kns.web.ui.SectionBridge.getContainerRows(Section, CollectionDefinitionI, BusinessObject, Maintainable, Maintainable, List, Set, StringBuffer, String, boolean, int, Inquirable) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 433 | Medium |
| Nullcheck of o at line 248 of value previously dereferenced in org.kuali.rice.kns.web.ui.SectionBridge.toSection(MaintainableSectionDefinition, BusinessObject, Maintainable, Maintainable, String, List, Set) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 215 | Medium |
