The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.
Tag Class | Total number of occurrences | Tag strings used by tag class |
---|---|---|
FIXME's | 122 | FIXME |
TODO's | 1128 | TODO |
Each tag is detailed below:
Number of occurrences found in the code: 122
org.kuali.student.common.assembly.util.IdTranslator | Line |
---|---|
workaround until orch dict can handle multi part keys on initiallookup defs | 61 |
org.kuali.student.common.dao.impl.AbstractSearchableCrudDaoImpl | Line |
SQL injection can occur here - or NOT if we need to assemble SQL to cover various ways one can compare criteria to a text | 116 |
org.kuali.student.common.dto.DtoConstants | Line |
Need to split out proposal states (ie. workflow states) versus dto states | 20 |
org.kuali.student.common.rice.StudentWorkflowConstants | Line |
The workflow doc type needs to be removed from ProposalWorkflowFilter | 6 |
org.kuali.student.common.search.service.impl.CrossSearchManager | Line |
this is pretty inefficient to loop through everything... a map structure for the cells might be better | 244 |
breaks are bad... but there is no map in the cells | 253 |
breaks are bad... but there is no map in the cells | 274 |
breaks are bad... but there is no map in the cells | 302 |
breaks are bad... but there is no map in the cells | 313 |
needs a handle to the result params data types here | 391 |
org.kuali.student.common.search.service.impl.SearchManagerImpl | Line |
should we change these to Operation Failed Exceptions? also we need to handle invalid parameters. | 153 |
org.kuali.student.common.ui.client.application.ViewContext | Line |
change state to proper default or null | 40 |
org.kuali.student.common.ui.client.configurable.mvc.DelayedToolView | Line |
? need to wire onReadyCallback into the model request, so that we aren't indicating that we're ready before the model is available? | 86 |
org.kuali.student.common.ui.client.configurable.mvc.layouts.TabbedSectionLayout | Line |
Better way to manage hierarchy, ordering, and handle to views | 51 |
this is not safe for all sorts of reasons, do not call handlers directly like this. | 106 |
keep or delete? | 132 |
org.kuali.student.common.ui.client.security.SpringSecurityLoginRedirectHandler | Line |
Need a way to get the proper redirect url, for now just reloading the page BrowserUtils.redirect(GWT.getHostPageBaseURL()); | 19 |
org.kuali.student.common.ui.client.util.SearchUtils | Line |
throw an exception? | 110 |
org.kuali.student.common.ui.client.validator.DataModelValidator | Line |
This is a temp solution for getting cross field min value | 649 |
This is a temp solution for getting cross field max value | 668 |
org.kuali.student.common.ui.client.widgets.containers.KSWrapper | Line |
notify current controller of the page change so it can perform an action | 102 |
before navigation event | 103 |
does this do anything? | 161 |
org.kuali.student.common.ui.client.widgets.list.KSSelectedList | Line |
do we need to do a search? is this method ever going to be called? | 384 |
org.kuali.student.common.ui.client.widgets.list.impl.KSLabelListImpl | Line |
Is there a better way to display selected item here without redrawing | 84 |
org.kuali.student.common.ui.client.widgets.pagetable.PagingScrollTableBuilder | Line |
workaround for incubator bug [KSCOR-225] This table to be replaced in M6 | 176 |
org.kuali.student.common.ui.client.widgets.search.KSPicker | Line |
should we search on values to populate drop down here or later when user will access the screen? | 208 |
This method of creating read is very inefficient, need better solution | 231 |
is this configuration error? | 319 |
what about the result id? | 361 |
what about the result ids? | 365 |
org.kuali.student.common.ui.client.widgets.search.SearchPanel | Line |
hack - comparison to 'optional' - replace with check against 'optional' field and update related lookup metadata | 488 |
throw an exception? | 499 |
remove because required field '*' indication will be part of FieldElement class | 566 |
hack - comparison to 'optional' - replace with check against 'optional' field and update related lookup metadata | 783 |
org.kuali.student.common.ui.client.widgets.search.SearchResultsTable | Line |
do we really need to recreate the table for every refresh? | 96 |
Do we still need this if condition? Added an else to the if(pagedResults) line to prevent searches being executed twice if the search name includes cross | 151 |
more detail info here | 183 |
org.kuali.student.common.ui.client.widgets.search.SwappablePanel | Line |
eventually we will need 'Search For' label as well. can the use of 'Search By' or 'Search For' be automatically implied or do we need another lookup configuration parameter? | 40 |
org.kuali.student.common.ui.client.widgets.search.TempSearchBackedTable | Line |
more detail info here | 99 |
auto adjusting width to fill table does not work with 1 column bug in incubator??? | 140 |
do we really need to recreate the table for every refresh? | 151 |
Undesirable solution to work with GWT 2.0 | 157 |
org.kuali.student.common.ui.client.widgets.suggestbox.SearchSuggestOracle | Line |
handle case when search for text is not appearing within search result - should not happen (misconfiguration) | 256 |
org.kuali.student.common.ui.client.widgets.suggestbox.SuggestPicker | Line |
Suggest picker marker interface, temporary fix? | 24 |
org.kuali.student.common.ui.server.gwt.old.AbstractBaseDataOrchestrationRpcGwtServlet | Line |
issues: -The Type/state config is hardcoded here which will cause troubles with different types and states -Workflow filter should be combined with this for save -The exception handling here needs standardization. Should RPC errors throw operation failed with just the message and log the message and exception? also should calls that return Boolean ever throw exceptions? | 46 |
should not pass empty id. What to do here? | 76 |
org.kuali.student.common.util.spring.MethodArgsToObjectEhcacheAdvice | Line |
This will result in inconsistent behvior if the value is the literal '<null>' vs being null | 106 |
org.kuali.student.core.comment.service.impl.TestCommentServiceImpl | Line |
validation needs to be tested, this code doesn't work and I need to refactor CommentInfo commentInfo = new CommentInfo(); RichTextInfo commentText = new RichTextInfo(); commentText.setFormatted("<p>comment>!@#02h%$</p>"); commentText.setPlain("comment"); commentInfo.setCommentText(commentText); commentInfo.setReferenceTypeKey("referenceKey"); commentInfo.setReferenceId("referenceId"); commentInfo.setEffectiveDate(new Date()); commentInfo.setExpirationDate(new Date()); | 129 |
org.kuali.student.core.document.service.impl.TestDocumentServiceImpl | Line |
validation needs to be tested, this code doesn't work and I need to refactor DocumentInfo documentInfo = new DocumentInfo(); RichTextInfo desc = new RichTextInfo(); desc.setFormatted("<p>document>!%/#;&@$</p>"); desc.setPlain("document"); documentInfo.setDesc(desc); documentInfo.setFileName("sample.pdf"); documentInfo.setEffectiveDate(new Date()); documentInfo.setExpirationDate(new Date()); documentInfo.setType("kuali.org.Document"); documentInfo.setState("active"); | 244 |
org.kuali.student.core.document.ui.server.upload.UploadServlet | Line |
Probably temporary solution for type on document info | 153 |
org.kuali.student.core.enumerationmanagement.service.impl.EnumerationManagementServiceImpl | Line |
need real validation | 66 |
need to get messages here | 114 |
need to get messages here | 176 |
org.kuali.student.core.organization.assembly.OrgProposalAssembler | Line |
should this be something like org.proposal? | 315 |
org.kuali.student.core.organization.service.impl.OrganizationServiceImpl | Line |
redo validation here and for all calls to create/update return validator.validateTypeStateObject(orgInfo, getObjectStructure("orgInfo")); | 758 |
org.kuali.student.core.organization.ui.client.mvc.controller.OrgProposalController | Line |
needs to check validation results and display messages if validation failed This was reviewd as part of KSCOR-220, deferred to KSCOR-225, can't be fixed until server side validation completed | 454 |
org.kuali.student.core.personsearch.service.impl.KsPerson | Line |
Either find a cleaner fix or go back to using PersonSerice | 38 |
org.kuali.student.core.statement.service.assembler.StatementTreeViewAssembler | Line |
Unsure now if this is an exception or just return null or empty assemblyNode | 47 |
org.kuali.student.core.statement.service.impl.TestStatementServiceImpl | Line |
- Investigate why adding clu1, clu3, clu2 works but adding clu1, clu2, clu3 doesn't work | 157 |
org.kuali.student.enrollment.class1.lu.service.impl.CluServiceImpl | Line |
, this should be DB time | 2937 |
org.kuali.student.enrollment.class1.roster.model.LprRosterEntity | Line |
Do we need to copy create and update time/id? | 201 |
org.kuali.student.enrollment.class2.acal.controller.AcademicCalendarController | Line |
Have to handle the error.. but for now, as it's causing issue, just skipping calculation when there are errors | 641 |
org.kuali.student.enrollment.class2.acal.keyvalue.AcademicTermTypeKeyValues | Line |
Should not call services for each collection row. Get all the available types once at the start.. not sure the init method to do that... | 47 |
org.kuali.student.enrollment.class2.acal.service.impl.CalendarSearchViewHelperServiceImpl | Line |
Find some better way to check the year | 98 |
org.kuali.student.enrollment.class2.appointment.service.impl.AppointmentViewHelperServiceImpl | Line |
Use Joda DateTime | 351 |
org.kuali.student.enrollment.class2.grading.controller.GradingController | Line |
Just a workaround as the propertyreplacer not working | 76 |
Not sure how to set a global error instead of for a field. If no fields mentioned, KRAD throwing error | 82 |
Not sure how to set a global error instead of for a field. If no fields mentioned, KRAD throwing error | 138 |
Not sure how to set a global error instead of for a field. If no fields mentioned, KRAD throwing error | 163 |
org.kuali.student.enrollment.class2.grading.service.impl.GradingServiceImpl | Line |
Hardcoded for core slice | 603 |
This method needs some code refactoring | 723 |
org.kuali.student.enrollment.class2.grading.service.impl.GradingViewHelperServiceImpl | Line |
Change it to use proper error handling | 277 |
org.kuali.student.enrollment.class2.registration.controller.RegistrationController | Line |
--No comment-- | 176 |
org.kuali.student.lum.common.client.lo.CategoryManagement | Line |
[KSCOR-225] user needs to specify what LoRepository they want category to tagged with | 643 |
org.kuali.student.lum.common.client.lo.LOCategoryBuilder | Line |
[KSCOR-225] Class needs to be rewritten to use KSPicker instead of SuggestPicker and use lookup config through metadata | 454 |
org.kuali.student.lum.common.client.lu.LUUIConstants | Line |
Duplicated from lum-api LUConstants | 30 |
org.kuali.student.lum.course.service.assembler.ActivityAssembler | Line |
Unsure now if this is an exception or just return null or empty assemblyNode | 60 |
org.kuali.student.lum.course.service.assembler.CourseAssembler | Line |
Unsure now if this is an exception or just return null or empty assemblyNode | 279 |
org.kuali.student.lum.course.service.assembler.CourseAssemblerConstants | Line |
follow Norm's Type Keys (this requires impex changes) public final static String COURSE_RESULT_TYPE_GRADE = "kuali.resultType.grades"; public final static String COURSE_RESULT_TYPE_CREDITS = "kuali.resultType.credits"; | 58 |
ask norm for these values | 76 |
ask norm about this value | 92 |
org.kuali.student.lum.course.service.assembler.CourseJointAssembler | Line |
is this ever used? | 65 |
Unsure now if this is an exception or just return null or empty assemblyNode | 83 |
org.kuali.student.lum.course.service.assembler.FormatAssembler | Line |
Unsure now if this is an exception or just return null or empty assemblyNode | 102 |
org.kuali.student.lum.course.service.impl.TestCourseServiceImpl | Line |
--No comment-- | 804 |
need a dictionary that defines StatamentTreeViewInfo | 925 |
need a dictionary that defines StatamentTreeViewInfo | 937 |
org.kuali.student.lum.lu.assembly.CluSetManagementAssembler | Line |
should have it's own proposal types | 59 |
--No comment-- | 526 |
--No comment-- | 531 |
--No comment-- | 535 |
org.kuali.student.lum.lu.entity.Clu | Line |
dates should be either set from the DB time as part of the insert statement, or set from the application. DB timestamp (CURRENT_TIMESTAMP) is preferred | 47 |
org.kuali.student.lum.lu.service.impl.LuServiceImpl | Line |
should be more checked service exceptions thrown | 2984 |
, this should be DB time | 3708 |
org.kuali.student.lum.lu.ui.course.client.configuration.CourseConfigurer | Line |
[KSCOR-225] Temporary fix til we have a real rich text editor addField(description, COURSE + "/" + DESCRIPTION, null); | 480 |
[KSCOR-225] Commented out search code to display drop down with only current user, and disable select | 788 |
org.kuali.student.lum.lu.ui.course.client.configuration.ViewCourseConfigurer | Line |
[KSCOR-225] Temp paths waiting for DOL changes | 77 |
[KSCOR-225] Initialize type and state from selected cluId | 83 |
org.kuali.student.lum.lu.ui.course.client.controllers.VersionsController | Line |
this is not updating the cluModel so state will not be updated in the model. May not be a problem. | 294 |
org.kuali.student.lum.lu.ui.course.client.controllers.ViewCourseController | Line |
this is not updating the cluModel so state will not be updated in the model. May not be a problem. | 163 |
org.kuali.student.lum.lu.ui.course.server.gwt.CourseDataService | Line |
calling getData after createNewCourseVersion is inefficient, but we need to have the transformations/filters be applied | 105 |
org.kuali.student.lum.lu.ui.main.client.widgets.ApplicationHeader | Line |
notify current controller of the page change so it can perform an action | 104 |
before navigation event | 105 |
the following code gets overridden | 159 |
org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer | Line |
do something else here, rework logic rootSection.redraw(); | 370 |
org.kuali.student.lum.program.client.major.edit.MajorEditController | Line |
This is ugly but gets us past a blocker issue. Theres something wrong with the way the models are handled in the major and variation controllers so they get out of sync. This is a temporary workaround | 174 |
org.kuali.student.lum.program.client.major.view.MajorViewController | Line |
Find a better way to do this. We shouldn't be maintaining two separate datamodels for progs and variations | 113 |
org.kuali.student.lum.program.service.assembler.CoreProgramAssembler | Line |
Unsure now if this is an exception or just return null or empty assemblyNode | 74 |
org.kuali.student.lum.program.service.assembler.CredentialProgramAssembler | Line |
Unsure now if this is an exception or just return null or empty assemblyNode | 79 |
org.kuali.student.lum.program.service.assembler.ProgramAssemblerConstants | Line |
ask norm about this value | 109 |
org.kuali.student.lum.program.service.assembler.ProgramVariationAssembler | Line |
Unsure now if this is an exception or just return null or empty assemblyNode | 78 |
org.kuali.student.lum.program.service.impl.ProgramRequirementAssembler | Line |
Unsure now if this is an exception or just return null or empty assemblyNode | 106 |
Derive from statement and rule types | 188 |
org.kuali.student.lum.program.service.impl.ProgramServiceImpl | Line |
, this validation should be moved into a custom validation class + configuration | 1407 |
error should return using message service and not static text | 1431 |
org.kuali.student.lum.program.service.impl.TestProgramServiceImpl | Line |
--No comment-- | 132 |
Updated version info isn't returned | 1077 |
org.kuali.student.lum.statement.typekey.ReqComponentFieldTypes | Line |
Why do we have test data in our code? | 54 |
org.kuali.student.r2.common.dto.DtoConstants | Line |
Need to split out proposal states (ie. workflow states) versus dto states | 43 |
org.kuali.student.r2.core.class1.enumerationmanagement.service.impl.EnumerationManagementServiceImpl | Line |
need real validation | 142 |
org.kuali.student.r2.core.class1.organization.service.impl.OrganizationServiceImpl | Line |
redo validation here and for all calls to create/update return validator.validateTypeStateObject(orgInfo, getObjectStructure("orgInfo")); | 235 |
Number of occurrences found in the code: 1128
org.kuali.rice.student.StudentStandaloneTestBase | Line |
---|---|
RICE-R2.0 UPGRADE - caching currently removed from rice. Will likely be added in KimApiServiceLocator.getIdentityService().flushAllCaches(); | 71 |
RICE-R2.0 UPGRADE - not sure flushInternalRoleCache is really the replacmenet for flushRoleCache - see previous TODO KimApiServiceLocator.getRoleService().flushInternalRoleCache(); KimApiServiceLocator.getRoleService().flushRoleCaches(); | 73 |
org.kuali.rice.student.StudentStandaloneTestBase | Line |
RICE-R2.0 UPGRADE - caching disabled in M7 will be revisited prior to 2.0 release KimApiServiceLocator.getIdentityService().flushAllCaches(); KimApiServiceLocator.getRoleService().flushRoleCaches(); | 74 |
org.kuali.rice.student.bo.KualiStudentKimAttributes | Line |
MARKED AS FINAL! | 233 |
org.kuali.rice.student.core.web.context.RiceWebApplicationContextProxy | Line |
- is there a refactor candidacy here? | 210 |
- is there a refactor candidacy here? | 219 |
- is there a refactor candidacy here? | 235 |
org.kuali.rice.test.data.UnitTestData | Line |
Come back and add the JPQL equivalents | 44 |
org.kuali.rice.test.lifecycles.JettyServerLifecycle | Line |
RICE-2.0 UPGRADE had to jump through hoops with M8 because getConfig was made private. Uncomment the following and remove the next block Config webappConfig = ConfigContext.getConfig(webappClassLoader); | 143 |
org.kuali.rice.test.lifecycles.SQLDataLoaderLifecycle | Line |
may way to do something with the dataLoader | 62 |
org.kuali.student.admin.messages.service.impl.MessageServiceImpl | Line |
RICE-M7 UPGRADE figure out why this soap binding stuff was here in the first place | 29 |
org.kuali.student.common.assembly.AddOneAssembler | Line |
Auto-generated method stub | 32 |
Auto-generated method stub | 38 |
Auto-generated method stub | 50 |
Auto-generated method stub | 65 |
Auto-generated method stub | 71 |
org.kuali.student.common.assembly.data.Data | Line |
probably need to add all of the other remove(type) methods | 607 |
what should be done if we try to query cluset/clus/0/_runtimeData where cluset/0 returns a string instead of Data throw an exception here? | 864 |
org.kuali.student.common.assembly.data.LookupMetadata | Line |
is DEFAULT needed? it has 0 references | 49 |
BUTTON has 0 references. Is it needed? | 56 |
org.kuali.student.common.assembly.data.LookupParamMetadata | Line |
none of these are used | 44 |
org.kuali.student.common.assembly.data.Metadata | Line |
When all dictionaries have been updated, this needs to be changed to a single value object. No need for it to be a list with new dictionary structure. | 55 |
dump lookup/etc info as well | 140 |
org.kuali.student.common.assembly.data.MetadataInterrogator | Line |
worry aboutg special validators | 216 |
worry about how this applies to non-strings? | 217 |
worry aboutg special validators | 304 |
worry about how this applies to non-strings? | 305 |
worry aboutg special validators | 323 |
worry about how this applies to non-strings? | 324 |
worry about hard coding ids | 341 |
Worry about hard coding the cut-off point | 345 |
org.kuali.student.common.assembly.data.QueryPath | Line |
revamp this method to use subList once GWT issue 1791 is fixed | 152 |
org.kuali.student.common.assembly.data.UILookupData | Line |
is DEFAULT needed? it has 0 references | 39 |
BUTTON has 0 references. Is it needed? | 46 |
org.kuali.student.common.assembly.dictionary.MetadataServiceImpl | Line |
figure out why path=courseInfo.creditOptions.type matches any structure that has a type on it so that lookup gets returned for all types | 573 |
org.kuali.student.common.assembly.dictionary.old.MetadataServiceImpl | Line |
--No comment-- | 48 |
org.kuali.student.common.assembly.helper.PropertyEnum | Line |
merge this to common, when merging Norm's generated stuff | 18 |
org.kuali.student.common.assembly.old.BaseAssembler | Line |
Below must be changed to use constants from KualiStudentKimAttributes class (class is currently in LUM) | 65 |
org.kuali.student.common.assembly.transform.AuthorizationFilter | Line |
If fields were masked, need to prevent masked values from being persisted. | 81 |
org.kuali.student.common.assembly.util.AssemblerUtils | Line |
need a "standard properties" enum for values that could be present on any object? | 94 |
need a "standard properties" enum for values that could be present on any object? | 123 |
org.kuali.student.common.dictionary.dto.ObjectStructureDefinition | Line |
do we need this? | 15 |
do we need this? | 21 |
org.kuali.student.common.dictionary.dto.ValidCharsConstraint | Line |
Should this be a list of values | 10 |
org.kuali.student.common.dictionary.old.dto.Field | Line |
there is no required here but there should be | 66 |
org.kuali.student.common.dictionary.service.impl.DictionaryFormatter | Line |
other more complex constraints | 751 |
org.kuali.student.common.dictionary.service.impl.DictionaryValidator | Line |
Cross compare to make sure min is not greater than max and that default value is valid itself | 133 |
make the date parser configurable like the validator is | 267 |
more validation | 330 |
more validation | 402 |
org.kuali.student.common.dto.DtoConstants | Line |
Ideally this method should not be hardcoded here. Also determining next state may be a more complicated and not just be a simple sequence. | 35 |
org.kuali.student.common.rice.StudentIdentityConstants | Line |
It seems wrong to include DOCUMENT_TYPE_NAME in an identity constants class | 44 |
org.kuali.student.common.rice.StudentWorkflowConstants | Line |
This class needs to be combined with org.kuali.student.StudentWorkflowConstants class found in ks-lum-rice | 3 |
org.kuali.student.common.search.service.impl.CrossSearchManager | Line |
get the types for the params! | 319 |
org.kuali.student.common.search.service.impl.SearchConfigValidator | Line |
validate | 23 |
org.kuali.student.common.ui.client.CommonUITest | Line |
Auto-generated method stub | 121 |
org.kuali.student.common.ui.client.application.KSAsyncCallback | Line |
Better detection of session timeout | 74 |
org.kuali.student.common.ui.client.configurable.mvc.DelayedToolView | Line |
Auto-generated method stub | 145 |
org.kuali.student.common.ui.client.configurable.mvc.binding.HasValueBinding | Line |
Type checking to ensure that the value type of widget matches model defintion | 47 |
org.kuali.student.common.ui.client.configurable.mvc.binding.MultiplicityItemBinding | Line |
modify this method to use QueryPath.add to build paths, rather than string manipulation | 52 |
org.kuali.student.common.ui.client.configurable.mvc.binding.RichTextBinding | Line |
Should these defaults be set in server assembly defaults? Commenting type and state as it is not required for rich text qPath = QueryPath.parse(richTextRoot + "type"); model.set(qPath, "kuali.not.applicable"); | 57 |
org.kuali.student.common.ui.client.configurable.mvc.layouts.MenuEditableSectionController | Line |
Change to put in section header | 90 |
org.kuali.student.common.ui.client.configurable.mvc.layouts.MenuSectionController | Line |
add description to the menu item | 290 |
org.kuali.student.common.ui.client.configurable.mvc.multiplicity.MultiplicityGroup | Line |
might want fields and nested multiplicities at the same time. Remove if/else | 201 |
Should copy widgets/bindings too? | 213 |
org.kuali.student.common.ui.client.configurable.mvc.multiplicity.MultiplicityGroupItem | Line |
Should this be an inner class in MultiplicityGroup? | 49 |
org.kuali.student.common.ui.client.configurable.mvc.multiplicity.MultiplicityTable | Line |
should just be 1 row def for a table - throw exception if > 1? | 75 |
org.kuali.student.common.ui.client.configurable.mvc.sections.BaseSection | Line |
Can we do this without checking for instanceof MG?? | 321 |
org.kuali.student.common.ui.client.configurable.mvc.sections.MultiplicitySection | Line |
--No comment-- | 69 |
org.kuali.student.common.ui.client.configurable.mvc.views.SectionView | Line |
review this, shouldn't it assign this.model = m? | 177 |
org.kuali.student.common.ui.client.configurable.mvc.views.VerticalSectionView | Line |
Auto-generated method stub | 93 |
org.kuali.student.common.ui.client.event.ExportEvent | Line |
Administrator - THIS METHOD NEEDS JAVADOCS | 31 |
org.kuali.student.common.ui.client.mvc.Controller | Line |
Nina how do you do loggin in GWT? final static Logger logger = Logger.getLogger(Controller.class); | 65 |
this logic needs to be reworked a bit... if an unchecked event has been bound locally, do we want to still fire it externally as well? | 358 |
add some automatic view context setting here, get and set | 466 |
Nina ??? Do we want to keep this seen in the light of the exportElements parameter | 603 |
org.kuali.student.common.ui.client.mvc.ViewComposite | Line |
Auto-generated method stub | 130 |
org.kuali.student.common.ui.client.mvc.history.HistoryManager | Line |
add the ability for view context to add a variety of additional attributes | 295 |
org.kuali.student.common.ui.client.service.SecurityRpcService | Line |
Expand to support additional auth/authz operations. | 24 |
org.kuali.student.common.ui.client.service.exceptions.OperationFailedException | Line |
A better solution for exceptions on client side. | 23 |
org.kuali.student.common.ui.client.util.ExportUtils | Line |
Nina - This can't be the correct way of getting handle to Controller, isn't there a better way?? | 110 |
org.kuali.student.common.ui.client.widgets.KSDatePicker | Line |
03/11/2009 - This widget currently only supports dates entered in the mm/dd/yyyy format. Known unresolved backspace bug in Firefox. | 36 |
org.kuali.student.common.ui.client.widgets.KSErrorDialog | Line |
maybe retrieve more error info | 124 |
actually gather client context info, such as browser version, user id, etc | 129 |
org.kuali.student.common.ui.client.widgets.KSItemLabel | Line |
--No comment-- | 163 |
org.kuali.student.common.ui.client.widgets.KSRichEditor | Line |
implement i18n | 35 |
org.kuali.student.common.ui.client.widgets.KSRichEditorAbstract | Line |
implement with a clean toolbar and i18n | 27 |
org.kuali.student.common.ui.client.widgets.field.layout.element.FieldElement | Line |
Do a check here to change the type of label based on widget type eventually | 236 |
show actual help window | 341 |
does nothing on warn, warn is not currently used | 411 |
does nothing on ok, ok is not currently used | 414 |
better way to generate unique id here? | 453 |
org.kuali.student.common.ui.client.widgets.field.layout.layouts.TableFieldLayout | Line |
Auto-generated method stub | 118 |
org.kuali.student.common.ui.client.widgets.field.layout.layouts.UnborderedHeadedLayout | Line |
rename styles to remove references to course format and activity | 28 |
org.kuali.student.common.ui.client.widgets.list.KSSelectedList | Line |
ryan - THIS METHOD NEEDS JAVADOCS | 302 |
org.kuali.student.common.ui.client.widgets.pagetable.GenericTableModel | Line |
return dynamic size when loading with RPC | 188 |
org.kuali.student.common.ui.client.widgets.search.KSPicker | Line |
Reviewed in M6 cleanup, unknown: Update to also work with a KSLabelList that doesn't require pre-population of all list items | 571 |
org.kuali.student.common.ui.client.widgets.search.SearchPanel | Line |
pass search to the table | 301 |
is this check needed here? probably. assuming string here | 306 |
is this null check needed here? probably. assuming string here | 485 |
make check more robust here/inserting params more robust do not pass to the search parameters that are empty | 486 |
use message call here | 553 |
Add handling of default value lists here | 557 |
need to handle date and other types here, how they are converted for search, etc | 597 |
Should be string only, needs type safety | 629 |
this should be a message key | 717 |
is this null check needed here? probably. assuming string here | 780 |
make check more robust here/inserting params more robust do not pass to the search parameters that are empty | 781 |
org.kuali.student.common.ui.client.widgets.search.SearchResultsTable | Line |
- there's a better way to do this | 124 |
org.kuali.student.common.ui.client.widgets.suggestbox.KSSuggestBox | Line |
implement some form of focus handling for SuggestBox | 38 |
ryan - THIS METHOD NEEDS JAVADOCS | 256 |
org.kuali.student.common.ui.client.widgets.table.summary.SummaryTableRow | Line |
Nina - Code Review - is it ok that i change to public... | 78 |
org.kuali.student.common.ui.client.widgets.table.summary.SummaryTableSection | Line |
handle custom widgets (multiplicity field widget initializer) | 173 |
handle custom widgets (multiplicity field widget initializer) | 233 |
org.kuali.student.common.ui.client.widgets.tabs.impl.KSTabPanelImpl | Line |
Auto-generated method stub | 65 |
Auto-generated method stub | 71 |
Auto-generated method stub | 77 |
Auto-generated method stub | 83 |
Auto-generated method stub | 89 |
Auto-generated method stub | 96 |
org.kuali.student.common.ui.server.applicationstate.ApplicationStateManager | Line |
The ApplicationStateManager needs to be reviewed as part of the code clean-up. | 19 |
org.kuali.student.common.ui.server.gwt.AbstractDataService | Line |
why do we have this reference in the base class???? | 42 |
Igor : Why do we check for this when getting the data for programs? | 53 |
org.kuali.student.common.ui.server.gwt.ExportDocumentDownload | Line |
Nina how must we handle exceptions here?? do something here | 28 |
org.kuali.student.common.ui.server.gwt.ExportGwtRpcServlet | Line |
Nina do we want this as a system Property?? | 34 |
org.kuali.student.common.ui.server.gwt.LogRpcGwtServlet | Line |
Use sl4j for logging | 36 |
org.kuali.student.common.ui.shared.IdAttributes | Line |
OBJECT_ID has no references | 10 |
org.kuali.student.common.ui.theme.standard.client.CommonImagesImpl | Line |
Auto-generated method stub | 97 |
org.kuali.student.common.validator.BeanConstraintDataProvider | Line |
fix it later. | 42 |
org.kuali.student.common.validator.DefaultValidatorImpl | Line |
parse fieldname from here | 355 |
What happens when the field is not in the dataProvider? | 406 |
There needs to be some mapping from PropertyUtils to the KS path Until then, this will only work for root level properties | 413 |
figure out what data should go here instead of null | 531 |
Implement lookup constraint | 539 |
org.kuali.student.common.validator.old.BeanConstraintDataProvider | Line |
fix it later. | 36 |
Should not be ignoring exception | 53 |
org.kuali.student.common.validator.old.Validator | Line |
Change this to 'default' when the change is made in xml | 47 |
Setup a mechanism to retrive referenced object structures nestedObjStruct = setupFactory.getObjectStructure(field .getFieldDescriptor().getObjectStructureRef()); | 227 |
What happens when the field is not in the dataProvider? | 546 |
Allow different processing based on the label | 600 |
Implement lookup constraint | 659 |
Implement TypeStateCase constraint | 663 |
org.kuali.student.core.assembly.transform.ProposalWorkflowFilter | Line |
this needs to be defined as a constant where all references will resolve | 120 |
RICE-R2.0 UPGRADE we can now supply the proposal status to the document here and we should be This will allow implementors to define workflow based on proposal state | 198 |
org.kuali.student.core.comments.ui.client.widgets.commenttool.CommentTool | Line |
use user id for now change to user name | 328 |
org.kuali.student.core.dictionary.service.TestBaseDictionary | Line |
fix reg ex so it allows 4.0 but excludes 4.1, 4.2 etc... assertNotNull (v.processValidCharConstraint ("test", vc, null, "4.1")); | 180 |
maybe allow these special characters | 277 |
maybe allow these special characters | 325 |
org.kuali.student.core.document.service.DocumentService | Line |
CHECK THESE VALUES | 52 |
org.kuali.student.core.document.ui.client.widgets.documenttool.DocumentList | Line |
Reviewed in M6, future fix: this will fail if the document does not exist BUT the relation does, needs a check for existance before delete | 151 |
org.kuali.student.core.enumerationmanagement.service.impl.EnumerationManagementServiceImpl | Line |
Kamal - THIS METHOD NEEDS JAVADOCS | 288 |
Kamal - THIS METHOD NEEDS JAVADOCS | 294 |
org.kuali.student.core.organization.assembly.OrgOrgRelationAssembler | Line |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 63 |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 98 |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 118 |
Auto-generated method stub | 293 |
org.kuali.student.core.organization.assembly.OrgPersonRelationAssembler | Line |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 65 |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 71 |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 110 |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 234 |
Auto-generated method stub | 240 |
org.kuali.student.core.organization.assembly.OrgPositionRestrictionAssembler | Line |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 61 |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 67 |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 91 |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 110 |
Auto-generated method stub | 222 |
org.kuali.student.core.organization.assembly.OrgProposalAssembler | Line |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 148 |
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS | 264 |
org.kuali.student.core.organization.dao.impl.OrganizationDaoImpl | Line |
Check query, not sure if matching against right orgKeyType value | 190 |
org.kuali.student.core.organization.service.impl.OrganizationAssembler | Line |
Use the person Service here Person person = personService.findPerson(orgPersonRelationInfo.getPersonId()); if (person == null) { throw new InvalidParameterException( "Person does not exist for id: " + orgPersonRelationInfo.getPersonId()); } orgPersonRelation.setPersonId(person.getId()); | 346 |
org.kuali.student.core.organization.service.impl.OrganizationServiceImpl | Line |
Flush out exceptions | 388 |
org.kuali.student.core.organization.ui.client.mvc.controller.OrgApplicationManager | Line |
Need to revisit for Org possibly | 90 |
org.kuali.student.core.organization.ui.client.mvc.view.CommonConfigurer | Line |
- when DOL is pushed farther down into LOBuilder, revert these 5 methods to returning void again. | 191 |
org.kuali.student.core.personsearch.service.impl.PersonSearch | Line |
map the old call parameters into the criteria parametsrs identityService.lookupEntityDefault(criteria, unbounded); | 43 |
org.kuali.student.core.personsearch.service.impl.QuickViewByGivenName | Line |
what is this search for? | 113 |
finish sorting | 142 |
Recognize alternate sort columns | 154 |
fix this | 195 |
org.kuali.student.core.proposal.service.impl.ProposalAssembler | Line |
Rework when JPA gets cascading deletes (2.0) | 150 |
org.kuali.student.core.rice.authorization.CollaboratorHelper | Line |
combine actionRequestEnum and ActionRequestType. Too similar. Only thing we need the enum for is human readable exceptions | 45 |
org.kuali.student.core.statement.service.impl.StatementAssembler | Line |
goes through the list of statements in statementTreeViewInfo and extract the statement ids | 533 |
Fix with LuService RC1.4 changes LuStatementTypeInfo stmtType = this.luService.getLuStatementType(statementInfo.getStatementTypeId()); stmt.setLuStatementType(stmtType); | 585 |
Fix with LuService RC1.4 changes ReqComponentType type = | 607 |
Fix with LuService RC1.4 changes stmt.setLuStatementType(this.luService.getLuStatementType(luNlStmt.getStatementTypeId())); | 618 |
org.kuali.student.core.statement.service.impl.TestStatementServiceImpl | Line |
This should test valid ReqCompFieldInfo types and values, too | 1450 |
org.kuali.student.core.statement.ui.client.widgets.rules.ReqCompEditWidget | Line |
use app context for text | 77 |
not sure if this will work all the time due to parallel nature of this code but running out of time | 220 |
save history | 458 |
we should mix the custom widgets with regular widgets | 461 |
org.kuali.student.core.statement.ui.client.widgets.rules.RuleManageWidget | Line |
use application context for all labels | 27 |
org.kuali.student.core.statement.ui.client.widgets.rules.RulePreviewWidget | Line |
app context for labels | 136 |
org.kuali.student.core.statement.ui.client.widgets.rules.RuleTable | Line |
do we need simple panel? | 34 |
org.kuali.student.core.statement.ui.client.widgets.rules.RuleTableManipulationWidget | Line |
remove req. compon.t | 299 |
org.kuali.student.core.statement.ui.client.widgets.rules.RulesUtil | Line |
clone file descriptor fields | 178 |
move to ks-lum and use constants in ReqComponentFieldTypes.java | 223 |
org.kuali.student.core.statement.ui.client.widgets.rules.StatementVO | Line |
do we really need this and do we need to duplicate this in sub rules? | 35 |
remove after refactoring rule table related classes, removing StatementVO | 40 |
org.kuali.student.core.statement.ui.client.widgets.rules.Token | Line |
use AndOrButton class int instead? | 20 |
org.kuali.student.core.statement.util.PropositionBuilder | Line |
--No comment-- | 247 |
--No comment-- | 365 |
--No comment-- | 384 |
--No comment-- | 420 |
--No comment-- | 427 |
org.kuali.student.core.test.BaseCase | Line |
RICE-2.0 UPGRADE had to jump through hoops with M8 because getConfig was made private. | 73 |
Uncomment the following and use that instead of iterating ClassLoader webappClassLoader = jettyServer.getContext().getClassLoader(); Config webappConfig = ConfigContext.getConfig(webappClassLoader); | 74 |
org.kuali.student.core.workflow.ui.client.views.CollaboratorSectionView | Line |
use real keys here person = new FieldDescriptor("collaboratorInfo", generateMessageInfo("Name"), personIdMeta); | 266 |
Is there a way to get first, last name from picker w/o parsing display value | 369 |
org.kuali.student.core.workflow.ui.client.widgets.WorkflowUtilities | Line |
This should come from the ReferenceModel like it does in CommentTool | 69 |
currently causing a lot of duplicate calls and has to be used carefully. Commented out for now. | 967 |
org.kuali.student.enrollment.acal.AcalReferenceDataParser | Line |
Some records don't have selection period end. Should this be calculated? | 305 |
Some records don't have selection period end | 398 |
Some records don't have selection period end | 482 |
org.kuali.student.enrollment.acal.constants.AcademicCalendarServiceConstants | Line |
replace "acal" in namespace with "academiccalendar" | 35 |
Map to Grading Start Date periods public static final String GRADING_PERIOD_START_TYPE_KEY = ???? | 64 |
org.kuali.student.enrollment.batchjobresults.infc.BatchJobResultItem | Line |
WORRY ABOUT SITUATIONS THAT ARE NOT ONE FOR ONE | 47 |
org.kuali.student.enrollment.class1.hold.service.impl.HoldServiceImpl | Line |
sambit - THIS METHOD NEEDS JAVADOCS | 77 |
sambit - THIS METHOD NEEDS JAVADOCS | 209 |
sambit - THIS METHOD NEEDS JAVADOCS | 283 |
sambit - THIS METHOD NEEDS JAVADOCS | 290 |
sambit - THIS METHOD NEEDS JAVADOCS | 297 |
sambit - THIS METHOD NEEDS JAVADOCS | 304 |
sambit - THIS METHOD NEEDS JAVADOCS | 312 |
sambit - THIS METHOD NEEDS JAVADOCS | 320 |
sambit - THIS METHOD NEEDS JAVADOCS | 328 |
org.kuali.student.enrollment.class1.lpr.model.LprTransactionEntity | Line |
determine if these are the static fields on the Entity. | 76 |
org.kuali.student.enrollment.class1.lpr.service.impl.LprServiceImpl | Line |
Kamal - THIS METHOD NEEDS JAVADOCS | 191 |
sambitpatnaik - THIS METHOD NEEDS JAVADOCS | 360 |
Mezba - the method createLprFromLprTransactionItem is no longer there, decide what to do | 473 |
this needs to be implemented for drop to work, read below Be careful with the implementation here, because we DO NOT want to delete all lprs that are matched by lui, person, and state, but instead only the ones that are related to the registration group we are dropping. It is VERY possible that a student could have the same course offering on their schedule twice with different reg groups, therefore deleting every LPR that matches that course offering id would be WRONG. In addition, it is possible that 2 reg groups that point to the same activity offering could be on the same schedule (this is more unlikely however and may be prevented by the system), and deleting both of those LPRs would be incorrect. So what we actually want to do is delete only lprs that have a direct relation to the reg group being dropped. However, there is no easy way currently to link these things together, one possible route is to get the original transactions and use their group id somehow, but this route may be flawed if the there is more than one succeeded transaction for the same reg group (VERY possible). There is no way currently (that I know of) to link the lprs for courseOffering, reg group, activities, and roster in a way that would be simple to determine by retrieving them from the db. This may be a possible hole in the service/db design. | 480 |
- change state to LprServiceConstants.DROPPED_STATE_KEY, rather than deleting | 508 |
- change state to LprServiceConstants.DROPPED_STATE_KEY, rather than deleting | 533 |
Mezba - the method createLprFromLprTransactionItem is no longer there, decide what to do | 541 |
sambit - THIS METHOD NEEDS JAVADOCS | 569 |
Mezba - implement method | 591 |
inject this impl with a lui service impl to get the atp to check LuiEntity lui = luiDao.find(entity.getLuiId()); if (StringUtils.equals(lui.getAtpId(), atpId)) { | 728 |
sambit - THIS METHOD NEEDS JAVADOCS | 759 |
Mezba - implement method | 787 |
Mezba - implement method | 800 |
Mezba - implement method | 807 |
Mezba - implement method | 817 |
Mezba - implement method | 826 |
org.kuali.student.enrollment.class1.lpr.service.impl.LprServiceMockImpl | Line |
check the rest of the readonly fields that are specified on the create to make sure they match the info object | 267 |
org.kuali.student.enrollment.class1.lpr.service.impl.TestLprServiceMockImpl | Line |
test that it handles validation failures | 319 |
test that it handles validation failures | 395 |
org.kuali.student.enrollment.class1.lpr.service.impl.mock.CriteriaMatcherInMemory | Line |
Deal with lists if (ad.getMaximumNumberOfElements() == null) { return false; } if (ad.getMaximumNumberOfElements() <= 1) { return false; } | 91 |
make sure the key is the same as the name | 170 |
org.kuali.student.enrollment.class1.lrc.service.impl.LRCServiceImpl | Line |
implement method | 73 |
implement method | 81 |
implement method | 120 |
implement method | 127 |
implement method | 136 |
implement method | 167 |
implement method | 175 |
implement method | 184 |
implement method | 191 |
implement method | 199 |
implement method | 217 |
org.kuali.student.enrollment.class1.lrr.service.impl.LearningResultRecordServiceImpl | Line |
implement method | 44 |
implement method | 79 |
implement method | 169 |
implement method | 176 |
implement method | 184 |
implement method | 192 |
implement method | 201 |
implement method | 211 |
implement method | 219 |
sambit - THIS METHOD NEEDS JAVADOCS | 250 |
org.kuali.student.enrollment.class1.lrr.termresolver.CompletedCoursesResolver | Line |
analyze actual cost | 94 |
org.kuali.student.enrollment.class1.lu.service.impl.CluServiceImpl | Line |
is the is the best method of doing this? what if the user passes in a new made up id, does that mean we have orphaned richtexts? | 1199 |
maybe this is unnecessary, contract specifies not null | 1586 |
maybe this is unnecessary, contract specifies not null | 1650 |
take this check out? R1 had this throwing an aleady exists exception but it is possible though unlikely for there to be two different relations between the same clu and Lo So we took out the AlreadyExistException in R2 BUT something might be depending on this So I kept it throwing an exception but changed it to throw an OperationFailed instead | 2145 |
Copy r2 request to an R1 request | 2368 |
copy R1 result to an R2 result | 2371 |
check if this should be set from outside | 2891 |
org.kuali.student.enrollment.class1.lu.termresolver.CourseSetResolver | Line |
analyze for a relevant cost | 44 |
org.kuali.student.enrollment.class1.lui.model.LuiEntity | Line |
find the old matching one and update that one instead of clobbbering and resetting | 127 |
org.kuali.student.enrollment.class1.lui.model.LuiFeeEntity | Line |
obj.setFeeAmounts(feeAmounts) | 130 |
org.kuali.student.enrollment.class1.lui.service.impl.LuServiceAssembler | Line |
dto.setCluCriteria() | 302 |
org.kuali.student.enrollment.class1.lui.service.impl.LuiServiceImpl | Line |
--No comment-- | 422 |
--No comment-- | 432 |
org.kuali.student.enrollment.class2.academicrecord.service.assembler.StudentCourseRecordAssembler | Line |
The code or number of the primary activity. how to determine which activity is primary? | 77 |
org.kuali.student.enrollment.class2.acal.controller.AcademicCalendarController | Line |
FIXME: Have to handle the error.. but for now, as it's causing issue, just skipping calculation when there are errors | 353 |
FIXME: Have to handle the error.. but for now, as it's causing issue, just skipping calculation when there are errors | 404 |
FIXME: Have to handle the error.. but for now, as it's causing issue, just skipping calculation when there are errors | 565 |
hard-coded for now, going to call OrgService | 659 |
delete completely from db, when "deleted" state is available, update the event with state ="deleted" | 711 |
org.kuali.student.enrollment.class2.acal.controller.CalendarSearchController | Line |
... | 54 |
- get real ContextInfo | 262 |
org.kuali.student.enrollment.class2.acal.controller.HolidayCalendarController | Line |
change to putError, when error reload fixed GlobalVariables.getMessageMap().putInfo(KRADConstants.GLOBAL_ERRORS, RiceKeyConstants.ERROR_CUSTOM, "ERROR: The adding holiday start date should not be later than the end date."); return false; }else if (timeDiff == 0 ) { holidayInfo.setIsDateRange(false); }else { holidayInfo.setIsDateRange(true); } | 111 |
hard-coded for now, going to call OrgService | 505 |
org.kuali.student.enrollment.class2.acal.dto.HolidayWrapper | Line |
... | 25 |
org.kuali.student.enrollment.class2.acal.dto.TimeSetWrapper | Line |
... | 26 |
org.kuali.student.enrollment.class2.acal.form.AcademicCalendarForm | Line |
... | 33 |
org.kuali.student.enrollment.class2.acal.form.CalendarSearchForm | Line |
... | 30 |
org.kuali.student.enrollment.class2.acal.keyvalue.AcademicTermStateKeyValues | Line |
Build real context. | 30 |
org.kuali.student.enrollment.class2.acal.keyvalue.AcademicTermTypeKeyValues | Line |
Build real context. | 43 |
org.kuali.student.enrollment.class2.acal.keyvalue.AcalEventTypeKeyValues | Line |
Build real context. | 59 |
org.kuali.student.enrollment.class2.acal.keyvalue.AtpStateKeyValues | Line |
... | 38 |
Build real context. | 55 |
org.kuali.student.enrollment.class2.acal.keyvalue.HolidayTypeKeyValues | Line |
... | 34 |
Build real context. | 52 |
org.kuali.student.enrollment.class2.acal.keyvalue.HolidayWrapperListFinder | Line |
--No comment-- | 73 |
org.kuali.student.enrollment.class2.acal.keyvalue.TermKeyValues | Line |
remove this when we figure out why KRAD defaultValue property is not working | 75 |
org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperLookupableImpl | Line |
fix the search by Admin Org. Switch from credential program to admin org cuased issues | 44 |
org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperMaintainableImpl | Line |
Need to handle new added Terms plus keyDates | 163 |
redo this string creation. the switch from credential program type to adminOrgId caused some issues | 312 |
org.kuali.student.enrollment.class2.acal.service.assembler.HolidayCalendarAssembler | Line |
fix this essentially flawed mechanism -- that happens because of the assembler structure it really should take in as a paraemter the existing ATP, if there is one and find/match the campus keys there and update the set of attributes not replacing them doing it this way we lose the original id of attribute on update the making it hard (wrong?) to store it later | 54 |
org.kuali.student.enrollment.class2.acal.service.decorators.AcademicCalendarServiceCalculationDecorator | Line |
Disabling usage of mapping until service supports the reuse of dates | 212 |
Need a way to only create a KeyDate in order to associate it with multiple Terms | 224 |
calculate keyDate effective dates | 227 |
the milestone is being populated with the first possible occurance - it is possible the ATP could span more than a years time | 295 |
org.kuali.student.enrollment.class2.acal.service.impl.AcademicCalendarServiceImpl | Line |
Li Pan - THIS METHOD NEEDS JAVADOCS | 107 |
Li Pan - THIS METHOD NEEDS JAVADOCS | 113 |
Li Pan - THIS METHOD NEEDS JAVADOCS | 120 |
Li Pan - THIS METHOD NEEDS JAVADOCS | 173 |
move this to a validation layer | 216 |
Li Pan - THIS METHOD NEEDS JAVADOCS | 588 |
move this to a validation layer | 671 |
move this to a validation layer | 676 |
Li Pan - THIS METHOD NEEDS JAVADOCS | 835 |
change this when the new contract gets merged in because it does not have the refobject uri as a parameter | 845 |
sambit - THIS METHOD NEEDS JAVADOCS | 1146 |
sambit - THIS METHOD NEEDS JAVADOCS | 1258 |
sambit - THIS METHOD NEEDS JAVADOCS | 1265 |
sambit - THIS METHOD NEEDS JAVADOCS | 1285 |
sambit - THIS METHOD NEEDS JAVADOCS | 1305 |
sambit - THIS METHOD NEEDS JAVADOCS return null; | 1312 |
sambit - THIS METHOD NEEDS JAVADOCS | 1348 |
sambit - THIS METHOD NEEDS JAVADOCS | 1372 |
validate type key is a valid term type | 1378 |
sambit - THIS METHOD NEEDS JAVADOCS | 1384 |
sambit - THIS METHOD NEEDS JAVADOCS | 1391 |
sambit - THIS METHOD NEEDS JAVADOCS | 1397 |
sambit - THIS METHOD NEEDS JAVADOCS | 1403 |
sambit - THIS METHOD NEEDS JAVADOCS | 1409 |
sambit - THIS METHOD NEEDS JAVADOCS | 1416 |
--No comment-- | 1422 |
sambit - THIS METHOD NEEDS JAVADOCS | 1429 |
sambit - THIS METHOD NEEDS JAVADOCS | 1436 |
sambit - THIS METHOD NEEDS JAVADOCS | 1480 |
sambit - THIS METHOD NEEDS JAVADOCS | 1486 |
sambit - THIS METHOD NEEDS JAVADOCS | 1517 |
sambit - THIS METHOD NEEDS JAVADOCS | 1523 |
sambit - THIS METHOD NEEDS JAVADOCS | 1529 |
sambit - THIS METHOD NEEDS JAVADOCS | 1612 |
sambit - THIS METHOD NEEDS JAVADOCS | 1619 |
sambit - THIS METHOD NEEDS JAVADOCS | 1644 |
Sambit - THIS METHOD NEEDS JAVADOCS | 1707 |
sambit - THIS METHOD NEEDS JAVADOCS | 1742 |
sambit - THIS METHOD NEEDS JAVADOCS | 1843 |
sambit - THIS METHOD NEEDS JAVADOCS | 1850 |
sambit - THIS METHOD NEEDS JAVADOCS | 1857 |
sambit - THIS METHOD NEEDS JAVADOCS | 1902 |
org.kuali.student.enrollment.class2.acal.service.impl.AcademicCalendarViewHelperServiceImpl | Line |
- if > 1 result, find calendar with latest end date? | 148 |
- if > 1 result, find calendar with latest end date? | 264 |
--No comment-- | 286 |
hard-coded for now, going to call OrgService | 1157 |
org.kuali.student.enrollment.class2.acal.service.impl.HolidayCalendarViewHelperServiceInquirableImpl | Line |
... | 34 |
- where does context come from? | 83 |
org.kuali.student.enrollment.class2.acal.service.impl.HolidayCalendarWrapperInquiryViewHelperServiceImpl | Line |
hard-coded for now, going to call OrgService | 89 |
org.kuali.student.enrollment.class2.acal.service.impl.TestAcademicCalendarServiceImpl | Line |
test exception aspect & get dictionary ready, this is expected | 158 |
- need actual ProgramTypeKey attribute in test database sql | 201 |
test exception aspect & get dictionary ready, this is expected | 279 |
--No comment-- | 596 |
check terms were copied properly | 951 |
should the milestone be saved in the calculation method or is that a seperate call? | 987 |
org.kuali.student.enrollment.class2.acal.util.CalendarConstants | Line |
... | 21 |
org.kuali.student.enrollment.class2.acal.util.CommonUtils | Line |
... | 26 |
org.kuali.student.enrollment.class2.appointment.controller.RegistrationWindowsController | Line |
... | 46 |
pull out all windows for that period and add to the collection | 162 |
log window == null message | 280 |
log exception | 284 |
- get real ContextInfo | 411 |
org.kuali.student.enrollment.class2.appointment.dto.StudentGroupWrapper | Line |
... | 22 |
org.kuali.student.enrollment.class2.appointment.keyvalue.PeriodForAppWindowKeyDatesFinder | Line |
--No comment-- | 59 |
- get real ContextInfo | 100 |
org.kuali.student.enrollment.class2.appointment.keyvalue.PeriodKeyDatesFinder | Line |
-- Log exception | 61 |
- get real ContextInfo | 98 |
org.kuali.student.enrollment.class2.appointment.keyvalue.RegWindowTypeKeyValues | Line |
Build real context. | 30 |
remove check after data is fixed | 36 |
org.kuali.student.enrollment.class2.appointment.keyvalue.SlotRuleForAppWindowKeyValuesFinder | Line |
... | 36 |
Build real context. | 60 |
org.kuali.student.enrollment.class2.appointment.service.AppointmentViewHelperService | Line |
... | 26 |
org.kuali.student.enrollment.class2.appointment.service.impl.AppointmentViewHelperServiceImpl | Line |
... | 54 |
Default to some value if nothing is entered(Service team needs to make up some real types or make not nullable) | 242 |
(should be moved into common util class) | 344 |
org.kuali.student.enrollment.class2.appointment.service.impl.StudentGroupWrapperLookupableImpl | Line |
... | 39 |
org.kuali.student.enrollment.class2.appointment.util.AppointmentConstants | Line |
... | 21 |
org.kuali.student.enrollment.class2.appointment.util.AppointmentSlotRuleTypeConversion | Line |
... | 28 |
org.kuali.student.enrollment.class2.courseoffering.service.decorators.CourseOfferingServiceCalculationDecorator | Line |
Not hard code "Active" but use a constant ... except these are R1 States | 92 |
set the schedule request to null as well | 158 |
continue traversing down the formats and activities updating from the canonical | 186 |
implement this complex logic | 221 |
org.kuali.student.enrollment.class2.courseoffering.service.decorators.R1CourseServiceHelper | Line |
Consider adding a shortcut by getting the current version of the course and comparing that first instead of all versions of the course | 99 |
if no version exists for the target term should we return null instead? | 105 |
consider sorting this in reverse order so the latest versions are checked first | 110 |
check the status of the course to make sure it is active, superseded or retired but it cannot be draft or otherwise in-active shortcut if the terms match | 122 |
find out if the course's Effective and expiration dates can be used so I don't have to fetch all the terms to compare start/end dates | 130 |
org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingInfoMaintainableImpl | Line |
- all exception handling in this method needs to 'manually' roll back what has been changed in the database before the exception was caught | 47 |
- this entire method needs more complete exception handling; then remove this | 73 |
remove this fake generation when we are getting real times from the form | 170 |
fix this to set the schedule id from the schedule service | 171 |
Change this formatOffering to actual one when implementing | 194 |
remove this fake generation below when we are getting real times from the form | 299 |
org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingServiceImpl | Line |
- remove when KSENROLL-247 is resolved | 65 |
speed this up by calling the bulk lui methods? | 205 |
use custom search | 288 |
move this logic to the calculation decorator do the persistence layer doesn't have this logic mixed in with it | 421 |
check that the lui being updated is an activity not another kind of lui copy to lui | 840 |
check that the lui being deleted is an activity not another kind of lui | 858 |
implement LuiService.getLuiIdsByRelation and call it instead | 918 |
org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingServiceMockImpl | Line |
check included terms | 172 |
check the rest of the readonly fields that are specified on the create to make sure they match the info object | 258 |
move this logic to the calculation decorator do the persistence layer doesn't have this logic mixed in with it copy from cannonical | 263 |
check the rest of the readonly fields that are specified on the create to make sure they match the info object | 368 |
check the rest of the readonly fields that are specified on the create to make sure they match the info object | 513 |
org.kuali.student.enrollment.class2.courseoffering.service.impl.LuiServiceMockImpl | Line |
--No comment-- | 229 |
org.kuali.student.enrollment.class2.courseoffering.service.impl.TestCourseOfferingServiceImpl | Line |
delete this file this once all the tests have been moved over to the new mock framework | 48 |
Is this necessary? | 190 |
org.kuali.student.enrollment.class2.courseoffering.service.impl.TestCourseOfferingServiceImplWithMocks | Line |
test for these things assertEquals(course.getUnitsContentOwnerOrgIds(), info.getUnitsContentOwnerOrgIds()); assertEquals(course.getUnitsDeploymentOrgIds(), info.getUnitsDeploymentOrgIds()); assertEquals(course.getGradingOptions(), info.getGradingOptionIds()); assertEquals(course.getCreditOptionIds(), info.getCreditOptionIds()); assertEquals(new R1ToR2CopyHelper().copyCourseExpenditure(course.getExpenditure()), info.getExpenditure()); assertEquals(new R1ToR2CopyHelper().copyCourseFeeList(course.getFeeIds()), info.getFeeIds()); assertEquals(new R1ToR2CopyHelper().copyInstructors(course.getInstructors()), info.getInstructors()); | 116 |
add this back in and test for it instructors.add(instructor); | 147 |
turn these tests back on once we get the corresponding JPA entities working assertEquals(orig.getActivityOfferingTypeKeys().size(), info.getActivityOfferingTypeKeys().size()); assertEquals(orig.getActivityOfferingTypeKeys().get(0), info.getActivityOfferingTypeKeys().get(0)); | 235 |
org.kuali.student.enrollment.class2.courseoffering.service.transformer.CourseOfferingTransformer | Line |
to copy Grading Option Id as well and this should be filtered on type? | 39 |
the following mapping undecided on wiki gradeRosterLevelTypeKey fundingSource isFinancialAidEligible registrationOrderTypeKey | 154 |
--No comment-- | 173 |
which one shouldbe copied ? | 176 |
org.kuali.student.enrollment.class2.courseoffering.service.transformer.RegistrationGroupTransformer | Line |
co.setIsHonorsOffering(isHonorsOffering) -- lui.getLuiCodes() ? | 23 |
co.getIsHonorsOffering() --store in a generic lui luCodes type of field? | 52 |
org.kuali.student.enrollment.class2.courseofferingset.model.SocRolloverResultEntity | Line |
store the option keys | 61 |
load the option keys | 100 |
org.kuali.student.enrollment.class2.courseofferingset.service.decorators.CourseOfferingReverseRolloverRunner | Line |
implement these options | 106 |
push this logic into the course offering service | 233 |
add a cascading delete for course offferings | 248 |
org.kuali.student.enrollment.class2.courseofferingset.service.decorators.CourseOfferingRolloverRunner | Line |
implement these options | 93 |
org.kuali.student.enrollment.class2.courseofferingset.service.decorators.CourseOfferingSetServiceCalculationDecorator | Line |
try to find the soc in the target term and use it instead of just creating a new one | 75 |
add bulk ops to CourseOfferingService so this can call them to delete all for a term or delete all for a subject area intead of doing it one by one | 200 |
handle sub-terms before returning false | 225 |
handle sub-terms before returning false | 235 |
handle sub-terms before returning false | 245 |
add the published course offering state to the constants if (info.getStateKey().equals(CourseOfferingServiceConstants.PUBLISHED_STATE_KEY) { | 260 |
add the published course offering state to the constants if (info.getStateKey().equals(CourseOfferingServiceConstants.PUBLISHED_STATE_KEY) { | 275 |
add the published course offering state to the constants if (!ao.getStateKey().equals(CourseOfferingServiceConstants.PUBLISHED_STATE_KEY) { | 291 |
add the published course offering state to the constants if (!ao.getStateKey().equals(CourseOfferingServiceConstants.SCHEDULED_STATE_KEY) { | 308 |
push this logic down into the JPA layer for efficiency once the logic for the counts gets settled on My GUT says that they may want more counts than just the 2 we are getting now... I.e. count of warnings? | 325 |
org.kuali.student.enrollment.class2.courseofferingset.service.impl.CourseOfferingSetServiceMockImpl | Line |
check the rest of the readonly fields that are specified on the create to make sure they match the info object | 121 |
check the rest of the readonly fields that are specified on the create to make sure they match the info object | 448 |
org.kuali.student.enrollment.class2.courseregistration.service.impl.CourseRegistrationServiceImpl | Line |
copy the transaction item and change the type of the new one to be ADD TO WAITLIST and then on that item mark the original with a state of failed | 197 |
fill in nlUsageType and language parameters once the implementation actually uses them | 302 |
sambit - THIS METHOD NEEDS JAVADOCS | 360 |
sambit - THIS METHOD NEEDS JAVADOCS | 367 |
sambit - THIS METHOD NEEDS JAVADOCS | 374 |
sambit - THIS METHOD NEEDS JAVADOCS | 381 |
sambit - THIS METHOD NEEDS JAVADOCS | 388 |
sambit - THIS METHOD NEEDS JAVADOCS | 395 |
- rules and waitlist implementation needed | 402 |
sambit - THIS METHOD NEEDS JAVADOCS | 409 |
since we're creating at a minimum 3 lprs per course reg we shouldn't loop through all of them. need a way to get directly to the grade roster | 569 |
- post core slice need to ensure that the list has one | 632 |
Auto-generated method stub | 764 |
Auto-generated method stub | 775 |
Auto-generated method stub | 784 |
Auto-generated method stub | 793 |
Auto-generated method stub | 802 |
Auto-generated method stub | 811 |
Auto-generated method stub | 823 |
Auto-generated method stub | 832 |
Auto-generated method stub | 842 |
Auto-generated method stub | 851 |
Auto-generated method stub | 860 |
Auto-generated method stub | 869 |
org.kuali.student.enrollment.class2.courseregistration.service.impl.CourseRegistrationServiceMockImpl | Line |
figure out credits | 800 |
org.kuali.student.enrollment.class2.courseregistration.termresolver.EnrolledCoursesResolver | Line |
analyze actual cost | 53 |
org.kuali.student.enrollment.class2.grading.assembler.GradeValuesGroupAssembler | Line |
implement method | 41 |
org.kuali.student.enrollment.class2.grading.controller.GradingController | Line |
Needs to be a client side method instead of handling at server side | 112 |
org.kuali.student.enrollment.class2.grading.service.assembler.GradeRosterAssembler | Line |
implement method | 36 |
org.kuali.student.enrollment.class2.grading.service.assembler.GradeRosterEntryAssembler | Line |
implement method | 35 |
org.kuali.student.enrollment.class2.grading.service.impl.GradingServiceImpl | Line |
implement method. | 73 |
implement method. | 95 |
implement method. | 119 |
implement method. | 173 |
implement method. | 196 |
implement method. | 224 |
implement method. | 250 |
implement method. | 272 |
implement method. | 349 |
implement method. | 371 |
throw exception if null? | 460 |
implement method. | 488 |
implement method. | 512 |
implement method. | 641 |
sambit - THIS METHOD NEEDS JAVADOCS | 668 |
need type value for calculated grade | 794 |
Get grading options from courseRegistration instead of courseOffering. | 837 |
need type value for calculated grade | 864 |
org.kuali.student.enrollment.class2.grading.service.impl.GradingViewHelperServiceImpl | Line |
- is this correct? | 211 |
- is this correct? | 213 |
org.kuali.student.enrollment.class2.registration.controller.RegistrationController | Line |
statement service wasnt working correctly when tested, commented out for now | 248 |
right now getOfferingsByIds throws a not supported exception return getCourseOfferingService().getActivityOfferingsByIds(regGroup.getActivityOfferingIds(), context); | 304 |
fix this to get the meeting schedule from the schedule Id and the schedule service | 336 |
check this logic Assuming registration successful if no errors returned | 464 |
org.kuali.student.enrollment.class2.registration.dto.ActivityOfferingWrapper | Line |
this is a hack to parse for human readable - it should be going to some service to get a human readable name for this activity | 36 |
org.kuali.student.enrollment.class2.registration.form.RegistrationForm | Line |
- remove this cast below if CourseRegistrationInfo.getCourseOffering() method is fixed | 119 |
fix this to get the meeting schedule from the schedule Id and the schedule service | 125 |
- convert type key to actual activity type | 132 |
org.kuali.student.enrollment.class2.registration.service.RegistrationViewHelperServiceImpl | Line |
RICE=M9 UPGRADE Replace call to "getSummaryMessageField" to use one of the new ContainerBase message field widgets, I suspect this should use getErrorsField | 92 |
org.kuali.student.enrollment.courseoffering.dto.RegistrationGroupActiviesOptionsInfo | Line |
... | 9 |
org.kuali.student.enrollment.courseoffering.dto.RegistrationGroupTemplateInfo | Line |
... | 10 |
org.kuali.student.enrollment.courseoffering.infc.CourseOffering | Line |
Skip this section for core slice development | 258 |
org.kuali.student.enrollment.courseoffering.infc.RegistrationGroupActiviesOptions | Line |
... | 4 |
org.kuali.student.enrollment.courseoffering.service.CourseOfferingService | Line |
The exact types that can be specified here have not yet been defined | 381 |
org.kuali.student.enrollment.courseoffering.service.R1ToR2CopyHelper | Line |
worry about using the toString method for the id | 32 |
deep copy the dates | 56 |
Deep copy the dates | 195 |
deail with ranges perhaps by interrogating the result values to see if it is a range? | 202 |
org.kuali.student.enrollment.grading.service.GradingService | Line |
- do we need to change the output to an object instead of boolean? | 417 |
org.kuali.student.enrollment.lrr.service.LearningResultRecordService | Line |
CHECK THESE VALUES | 48 |
org.kuali.student.enrollment.lui.service.LuiService | Line |
--No comment-- | 426 |
??? Retrieves the list of related LUI Ids for the specified LUI Id and LU to LU relation type. (getLuiIdsByRelation from the other direction). | 444 |
??? Retrieves the list of related LUI information for the specified LUI Id and LU to LU relation type (getLuisByRelatedLuiAndRelationType from the other direction). | 462 |
org.kuali.student.enrollment.main.form.LaunchForm | Line |
... | 21 |
org.kuali.student.kim.identity.mock.MockConfig | Line |
sambit - THIS METHOD NEEDS JAVADOCS | 250 |
sambit - THIS METHOD NEEDS JAVADOCS | 256 |
sambit - THIS METHOD NEEDS JAVADOCS | 262 |
sambit - THIS METHOD NEEDS JAVADOCS | 268 |
sambit - THIS METHOD NEEDS JAVADOCS | 274 |
sambit - THIS METHOD NEEDS JAVADOCS | 280 |
sambit - THIS METHOD NEEDS JAVADOCS | 286 |
sambit - THIS METHOD NEEDS JAVADOCS | 292 |
org.kuali.student.kim.permission.mock.PermissionServiceMockImpl | Line |
implement this check | 74 |
implement this check | 79 |
implement this check | 84 |
Implement this | 137 |
Larry Symms wanted to take a look at this | 201 |
org.kuali.student.kim.permission.mock.RoleServiceMockImpl | Line |
implement check | 187 |
RICE=M9 UPGRADE The function of this method has been internalized in rice m9 The function of this method has been internalized in rice m9 | 266 |
RICE=M9 UPGRADE The function of this method has been internalized in rice m9 The function of this method has been internalized in rice m9 | 286 |
org.kuali.student.lum.common.client.lo.CategoryDataUtil | Line |
- doesn't work on the client; what to do? | 27 |
- LoCategoryInfoAssembler, w/ an assemble method so we can just do categoriesData.add(LoCategoryInfoAssembler.assemble(cat)) instead of all the above | 46 |
- this should't be necessary when DOL pushed down into LOPicker and its LOCategoryBuilder catInfo.setAttributes(catHelper.getAttributes()); | 69 |
- LoCategoryInfoAssembler, w/ a disassemble method so we can just do categoriesData.add(LoCategoryInfoAssembler.disassemble(catData)) instead of all the above | 75 |
org.kuali.student.lum.common.client.lo.LOCategoryBuilder | Line |
show actual help window | 225 |
do we need null checks? | 368 |
- need to somehow ensure that categoryTypeMap is initialized before redraw() | 639 |
- need to somehow ensure that categoryTypeMap is initialized before redraw() String typeName = "ERROR: uninitialized categoryTypeMap"; if (null != categoryTypeMap) { typeName = categoryTypeMap.get(typeKey).getName(); } categoryTable.setWidget(row, col++, new KSLabel(name + CATEGORY_TYPE_SEPARATOR + typeName)); KSLabel deleteLabel = new KSLabel("[x]"); deleteLabel.addStyleName("KS-LOBuilder-Search-Link"); deleteLabel.addClickHandler(deleteHandler); categoryTable.setWidget(row, col++, deleteLabel); row++; col = 0; | 648 |
org.kuali.student.lum.common.client.lo.OutlineNode | Line |
M4 - some way to subclass OutlineNode? | 27 |
org.kuali.student.lum.common.server.LoCategoryDataService | Line |
Check that only LO categories are coming through this way. LOs are persisted only in the context of a CLU? | 47 |
org.kuali.student.lum.course.service.assembler.CourseAssembler | Line |
Use CluAssemblerUtils | 746 |
Auto-generated method stub | 749 |
This is pretty much a copy of the FormatAssembler's disassembleActivities code... maybe can be made generic | 931 |
This is pretty much a copy of the disassembleJoints code... maybe can be made generic | 1096 |
org.kuali.student.lum.course.service.impl.CourseDataGenerator | Line |
make it return A, B, C... | 229 |
org.kuali.student.lum.course.service.impl.TestCourseServiceImpl | Line |
- check its contents | 170 |
- check its contents | 175 |
- check effective/expiration dates | 184 |
- check feeInfo | 186 |
- check joints | 188 |
- check metaInfo | 189 |
- check variotions | 217 |
org.kuali.student.lum.kim.StudentIdentityServiceImpl | Line |
RICE=M9 UPGRADE Check that the values for the portName and targetNamespace still make sense for rice-2.0 | 41 |
org.kuali.student.lum.kim.role.type.KSActionRequestDerivedRoleTypeServiceImpl | Line |
RICE=M7 UPGRADE deal with WorkflowUtility being deprecated | 167 |
org.kuali.student.lum.lo.dao.impl.LoDaoImpl | Line |
- will need more general logic here when we have relationships other than "includes" hopefully dictionary-driven List<Lo> parents = getIncludingLos(loId); for (Lo parent : parents) { parent.getRelatedLos().remove(child); update(parent); } | 101 |
- gotta be a constant somewhere, or perhaps pull from dictionary | 116 |
- gotta be a constant somewhere, or perhaps pull from dictionary | 123 |
- "&& [not a top-level LO for another CLU]" when LO's are reused throw new DependentObjectsExistException("LoLoRelation(" + loLoRelationId + ") cannot be deleted without orphaning Lo(s)."); } | 191 |
- remove when logic has been completely pilfered as appropriate | 238 |
- null out hierarchy | 334 |
org.kuali.student.lum.lu.assembly.CluSetManagementAssembler | Line |
Split out CluInfo assembly to its own class | 54 |
Auto-generated method stub | 520 |
org.kuali.student.lum.lu.service.impl.LuServiceAssembler | Line |
dto.setCluCriteria() | 317 |
org.kuali.student.lum.lu.service.impl.LuServiceImpl | Line |
is the is the best method of doing this? what if the user passes in a new made up id, does that mean we have orphaned richtexts? | 1238 |
maybe this is unnecessary, contract specifies not null | 1620 |
maybe this is unnecessary, contract specifies not null | 1666 |
Auto-generated method stub | 2190 |
Is it possible we need to search up the cluset hierarchies? If Cluset A contains clu 1 and cluset B contains cluset A, do we also return cluset B as a dependency? | 3264 |
check if this should be set from outside | 3659 |
org.kuali.student.lum.lu.ui.course.client.configuration.CourseConfigurer | Line |
people and permissions will use a different button than continue | 198 |
customize multiplicity and change "Percentage" label into LUConstants.AMOUNT | 1028 |
customize multiplicity and change "Percentage" label into LUConstants.AMOUNT | 1050 |
org.kuali.student.lum.lu.ui.course.client.configuration.CourseSummaryConfigurer | Line |
use messages here | 296 |
next 3 methods below should be moved into some kind of multiplicity helper class | 648 |
Auto-generated method stub | 805 |
org.kuali.student.lum.lu.ui.course.client.controllers.CourseProposalController | Line |
get from messages | 169 |
Is this correct... do we want to stop view change if we can't restore the data? Possibly traps the user if we don't it messes up saves, possibly warn the user that it failed and continue? | 818 |
org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsManageView | Line |
cache it for each statement type? | 107 |
until we figure out how to detect changes, always return true | 226 |
how to check whether rule changed or not? !(ruleManageWidget.getLogicExpression().equals(originalLogicExpression) && getAllReqCompNLs().equals(originalReqCompNL)); | 238 |
? | 280 |
org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsViewController | Line |
show dialog if user clicks on a menu from Manage Rules page | 80 |
org.kuali.student.lum.lu.ui.course.client.widgets.CourseWorkflowActionList | Line |
use messages | 84 |
Inactivate | 109 |
Retire | 116 |
create Retire dialog | 126 |
use message e.g. activateCurrentInstr, activateModificationInstr | 128 |
create Inactivate dialog | 132 |
message | 150 |
message | 153 |
use messages | 163 |
add Retire and Inactivate Dialogs | 189 |
org.kuali.student.lum.lu.ui.dependency.client.views.DependencyAnalysisView | Line |
This should not use hard-coded result columns | 251 |
This code copied from program screens, need common reusable code | 363 |
This code copied from Program summary, need to create reusable version for this and program summary | 508 |
This code copied from Program summary, need to create reusable version for this and program summary | 520 |
org.kuali.student.lum.lu.ui.dependency.client.widgets.DependencyResultPanel | Line |
This may need to be replaced with document to surface handle print/export | 64 |
org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer | Line |
add cluset and clurange here | 132 |
change this to custom layoutcontroller here to support multiple model ids? | 226 |
change this to custom layoutcontroller here to support multiple model ids? | 312 |
retrieve cluset by id and | 324 |
retrieve cluset by id and | 362 |
- when DOL is pushed farther down into LOBuilder, revert these 5 methods to returning void again. | 544 |
- when DOL is pushed farther down into LOBuilder, revert these 5 methods to returning void again. | 546 |
org.kuali.student.lum.lu.ui.tools.client.widgets.SearchBackedTable | Line |
use this as a token to get a message from message service instead | 142 |
org.kuali.student.lum.program.client.requirements.ProgramRequirementsDataModel | Line |
how can we reliably know that we need to reload rules (or not) String programId = (model == null ? null : (String)((DataModel)model).getRoot().get("id")); String modelProgramId = ((DataModel)modelIn).getRoot().get(ProgramConstants.ID); if ((modelProgramId == null) || (!modelProgramId.equals(programId))) { | 73 |
clonedProgReqInfo.setAttributes(); | 493 |
clonedProgReqInfo.setLearningObjectives(); | 494 |
clonedProgReqInfo.setMetaInfo(); | 495 |
org.kuali.student.lum.program.client.requirements.ProgramRequirementsManageView | Line |
cache it for each statement type? | 97 |
until we figure out how to detect changes, always return true | 226 |
how to check whether rule changed or not? !(ruleManageWidget.getLogicExpression().equals(originalLogicExpression) && getAllReqCompNLs().equals(originalReqCompNL)); | 238 |
? | 280 |
org.kuali.student.lum.program.client.requirements.ProgramRequirementsSummaryView | Line |
rework to use Configurer if possible | 488 |
org.kuali.student.lum.program.client.requirements.ProgramRequirementsViewController | Line |
show dialog if user clicks on a menu from Manage Rules page | 99 |
put back if we will NOT reset rules every time user comes to PREVIEW page above... | 141 |
org.kuali.student.lum.program.server.CoreProgramDataService | Line |
find a better way to get this search, param and resultcolumn names | 79 |
org.kuali.student.lum.program.server.MajorDisciplineDataService | Line |
Just Major Discipline for now - need to check for other types later | 37 |
org.kuali.student.lum.program.server.MajorDisciplineRpcServlet | Line |
temporary fix - see KSLUM 1421 | 92 |
org.kuali.student.lum.program.server.transform.CoreCredentialProgramFilter | Line |
find a better way to get search, param and resultcolumn names | 81 |
org.kuali.student.lum.program.service.ProgramService | Line |
CHECK THESE VALUES | 56 |
org.kuali.student.lum.program.service.assembler.MajorDisciplineAssembler | Line |
- is it an error if there's more than one core program? | 97 |
IDs for objects w/o ids | 135 |
Check for ProgramAssemblerConstants.CERTIFICATE_RESULTS too | 218 |
org.kuali.student.lum.program.service.assembler.ProgramAssemblerUtils | Line |
maybe this should be in CluAssemblerUtils?? | 109 |
maybe this should be in CluAssemblerUtils?? | 126 |
- do we need to validate that? | 1055 |
org.kuali.student.lum.program.service.impl.ProgramDataGeneratorUtils | Line |
maybe need it later | 21 |
org.kuali.student.lum.program.service.impl.ProgramServiceImpl | Line |
Auto-generated method stub | 123 |
Auto-generated method stub | 448 |
Auto-generated method stub | 479 |
Auto-generated method stub | 509 |
Auto-generated method stub | 569 |
Auto-generated method stub | 576 |
Auto-generated method stub | 584 |
Auto-generated method stub | 593 |
Auto-generated method stub | 630 |
Auto-generated method stub | 639 |
Auto-generated method stub | 647 |
Auto-generated method stub | 736 |
Auto-generated method stub | 775 |
Auto-generated method stub | 822 |
Auto-generated method stub | 847 |
Auto-generated method stub | 879 |
Auto-generated method stub | 886 |
Auto-generated method stub | 894 |
Auto-generated method stub | 901 |
Auto-generated method stub | 909 |
Auto-generated method stub | 916 |
Auto-generated method stub | 925 |
Auto-generated method stub | 934 |
Auto-generated method stub | 941 |
- when CRUD for a second ProgramInfo is implemented, pull common code up from its process*() and this | 959 |
org.kuali.student.lum.program.service.impl.TestProgramServiceImpl | Line |
catalog descr | 221 |
catalog pub targets | 222 |
effectiveDate Calendar effectiveDate = GregorianCalendar.getInstance(); effectiveDate.set(1984, 7, 1, 0, 0, 0); Date testDate = new Date(effectiveDate.getTimeInMillis()); assertTrue(major.getEffectiveDate().compareTo(testDate) == 0); | 318 |
catalog descr | 335 |
createTime Calendar createTime = GregorianCalendar.getInstance(); createTime.set(2009, 4, 7, 12, 5, 36); testDate = new Date(createTime.getTimeInMillis()); assertTrue(major.getEffectiveDate().compareTo(testDate) == 0); | 399 |
assertEquals("ANTH", createdMD.getCode()); | 493 |
effectiveDate Calendar effectiveDate = GregorianCalendar.getInstance(); effectiveDate.set(1984, 7, 1, 0, 0, 0); Date testDate = new Date(effectiveDate.getTimeInMillis()); assertTrue(createdMD.getEffectiveDate().compareTo(testDate) == 0); | 524 |
assertEquals("00f5f8c5-fff1-4c8b-92fc-789b891e0849", createdMD.getOrgCoreProgram().getId()); | 561 |
createTime Calendar createTime = GregorianCalendar.getInstance(); createTime.set(2009, 4, 7, 12, 5, 36); testDate = new Date(createTime.getTimeInMillis()); assertTrue(createdMD.getEffectiveDate().compareTo(testDate) == 0); | 618 |
checkReqComponentType(reqComponent.getRequiredComponentType(), reqComponent2.getRequiredComponentType()); | 754 |
add version update | 1063 |
add version update | 1179 |
this should actually be passing; get working again after today's change of AdminOrgInfo's to those orgs ID's in Program-related DTOs assertEquals("testOrgId", target.getDivisionsContentOwner().get(0)); | 1291 |
update versioning | 1415 |
org.kuali.student.lum.service.assembler.CluAssemblerUtils | Line |
Check this for proper handling of multiple CluResultInfos? If this is not a create, lookup the results for this clu | 83 |
Auto-generated method stub | 173 |
org.kuali.student.lum.statement.config.context.AtpContextImplTest | Line |
Auto-generated method stub | 133 |
Auto-generated method stub | 143 |
Auto-generated method stub | 153 |
Auto-generated method stub | 162 |
Auto-generated method stub | 170 |
Auto-generated method stub | 184 |
Auto-generated method stub | 192 |
Auto-generated method stub | 199 |
Auto-generated method stub | 207 |
Auto-generated method stub | 213 |
Auto-generated method stub | 221 |
Auto-generated method stub | 229 |
Auto-generated method stub | 237 |
Auto-generated method stub | 245 |
Auto-generated method stub | 253 |
Auto-generated method stub | 260 |
Auto-generated method stub | 269 |
Auto-generated method stub | 277 |
Auto-generated method stub | 285 |
Auto-generated method stub | 293 |
Auto-generated method stub | 301 |
Auto-generated method stub | 308 |
Auto-generated method stub | 317 |
Auto-generated method stub | 325 |
Auto-generated method stub | 333 |
Auto-generated method stub | 342 |
Auto-generated method stub | 351 |
Auto-generated method stub | 360 |
Auto-generated method stub | 370 |
Auto-generated method stub | 381 |
Auto-generated method stub | 392 |
Auto-generated method stub | 401 |
Auto-generated method stub | 410 |
Auto-generated method stub | 419 |
Auto-generated method stub | 428 |
Auto-generated method stub | 435 |
Auto-generated method stub | 444 |
Auto-generated method stub | 451 |
Auto-generated method stub | 459 |
Auto-generated method stub | 466 |
Auto-generated method stub | 475 |
Auto-generated method stub | 484 |
Auto-generated method stub | 491 |
Kamal - THIS METHOD NEEDS JAVADOCS | 497 |
Kamal - THIS METHOD NEEDS JAVADOCS | 503 |
org.kuali.student.lum.statement.config.context.LrcContextImplTest | Line |
Auto-generated method stub | 207 |
Auto-generated method stub | 219 |
Auto-generated method stub | 228 |
Auto-generated method stub | 236 |
Auto-generated method stub | 245 |
Auto-generated method stub | 253 |
Auto-generated method stub | 260 |
Auto-generated method stub | 269 |
Auto-generated method stub | 277 |
Auto-generated method stub | 285 |
Auto-generated method stub | 293 |
Auto-generated method stub | 300 |
Auto-generated method stub | 308 |
Auto-generated method stub | 316 |
Auto-generated method stub | 324 |
Auto-generated method stub | 332 |
Auto-generated method stub | 339 |
Auto-generated method stub | 347 |
Auto-generated method stub | 355 |
Auto-generated method stub | 371 |
Auto-generated method stub | 388 |
Auto-generated method stub | 402 |
Auto-generated method stub | 410 |
Auto-generated method stub | 422 |
Auto-generated method stub | 431 |
Auto-generated method stub | 438 |
Auto-generated method stub | 447 |
Auto-generated method stub | 454 |
Auto-generated method stub | 462 |
Auto-generated method stub | 469 |
Auto-generated method stub | 478 |
Auto-generated method stub | 487 |
Auto-generated method stub | 494 |
Kamal - THIS METHOD NEEDS JAVADOCS | 500 |
Kamal - THIS METHOD NEEDS JAVADOCS | 506 |
org.kuali.student.lum.statement.config.context.LuContextImplTest | Line |
Auto-generated method stub | 292 |
Auto-generated method stub | 302 |
Auto-generated method stub | 313 |
Auto-generated method stub | 322 |
Auto-generated method stub | 332 |
Auto-generated method stub | 342 |
Auto-generated method stub | 354 |
Auto-generated method stub | 365 |
Auto-generated method stub | 375 |
Auto-generated method stub | 386 |
Auto-generated method stub | 396 |
Auto-generated method stub | 406 |
Auto-generated method stub | 418 |
Auto-generated method stub | 427 |
Auto-generated method stub | 436 |
Auto-generated method stub | 445 |
Auto-generated method stub | 454 |
Auto-generated method stub | 463 |
Auto-generated method stub | 472 |
Auto-generated method stub | 481 |
Auto-generated method stub | 490 |
Auto-generated method stub | 499 |
Auto-generated method stub | 508 |
Auto-generated method stub | 517 |
Auto-generated method stub | 526 |
Auto-generated method stub | 535 |
Auto-generated method stub | 544 |
Auto-generated method stub | 553 |
Auto-generated method stub | 561 |
Auto-generated method stub | 576 |
Auto-generated method stub | 584 |
Auto-generated method stub | 592 |
Auto-generated method stub | 601 |
Auto-generated method stub | 609 |
Auto-generated method stub | 617 |
Auto-generated method stub | 626 |
Auto-generated method stub | 635 |
Auto-generated method stub | 644 |
Auto-generated method stub | 651 |
Auto-generated method stub | 659 |
Auto-generated method stub | 667 |
Auto-generated method stub | 675 |
Auto-generated method stub | 683 |
Auto-generated method stub | 692 |
Auto-generated method stub | 700 |
Auto-generated method stub | 708 |
Auto-generated method stub | 716 |
Auto-generated method stub | 723 |
Auto-generated method stub | 732 |
Auto-generated method stub | 741 |
Auto-generated method stub | 758 |
Auto-generated method stub | 767 |
Auto-generated method stub | 775 |
Auto-generated method stub | 782 |
Auto-generated method stub | 790 |
Auto-generated method stub | 798 |
Auto-generated method stub | 807 |
Auto-generated method stub | 816 |
Auto-generated method stub | 825 |
Auto-generated method stub | 832 |
Auto-generated method stub | 841 |
Auto-generated method stub | 848 |
Auto-generated method stub | 856 |
Auto-generated method stub | 863 |
Auto-generated method stub | 871 |
Auto-generated method stub | 878 |
Auto-generated method stub | 887 |
Auto-generated method stub | 894 |
Auto-generated method stub | 902 |
Auto-generated method stub | 910 |
Auto-generated method stub | 916 |
Auto-generated method stub | 924 |
Auto-generated method stub | 932 |
Auto-generated method stub | 941 |
Auto-generated method stub | 949 |
Auto-generated method stub | 957 |
Auto-generated method stub | 965 |
Auto-generated method stub | 973 |
Auto-generated method stub | 982 |
Auto-generated method stub | 990 |
Auto-generated method stub | 999 |
Auto-generated method stub | 1008 |
Auto-generated method stub | 1017 |
Auto-generated method stub | 1026 |
Auto-generated method stub | 1034 |
Auto-generated method stub | 1042 |
Auto-generated method stub | 1049 |
Auto-generated method stub | 1058 |
Auto-generated method stub | 1067 |
Auto-generated method stub | 1076 |
Auto-generated method stub | 1085 |
Auto-generated method stub | 1095 |
Auto-generated method stub | 1105 |
Auto-generated method stub | 1116 |
Auto-generated method stub | 1127 |
Auto-generated method stub | 1138 |
Auto-generated method stub | 1149 |
Auto-generated method stub | 1160 |
Auto-generated method stub | 1169 |
Auto-generated method stub | 1179 |
Auto-generated method stub | 1190 |
Auto-generated method stub | 1199 |
Auto-generated method stub | 1208 |
Auto-generated method stub | 1217 |
Auto-generated method stub | 1226 |
Auto-generated method stub | 1235 |
Auto-generated method stub | 1244 |
Auto-generated method stub | 1253 |
Auto-generated method stub | 1262 |
Auto-generated method stub | 1271 |
Auto-generated method stub | 1277 |
Auto-generated method stub | 1283 |
Auto-generated method stub | 1292 |
Auto-generated method stub | 1299 |
Auto-generated method stub | 1308 |
Auto-generated method stub | 1315 |
Auto-generated method stub | 1323 |
Auto-generated method stub | 1330 |
Auto-generated method stub | 1339 |
Auto-generated method stub | 1348 |
Auto-generated method stub | 1355 |
Auto-generated method stub | 1365 |
Auto-generated method stub | 1375 |
Auto-generated method stub | 1395 |
Auto-generated method stub | 1404 |
Auto-generated method stub | 1413 |
Auto-generated method stub | 1423 |
Auto-generated method stub | 1432 |
Auto-generated method stub | 1442 |
org.kuali.student.lum.statement.config.context.OrganizationContextImplTest | Line |
Auto-generated method stub | 124 |
Auto-generated method stub | 136 |
Auto-generated method stub | 148 |
Auto-generated method stub | 157 |
Auto-generated method stub | 166 |
Auto-generated method stub | 174 |
Auto-generated method stub | 182 |
Auto-generated method stub | 191 |
Auto-generated method stub | 200 |
Auto-generated method stub | 207 |
Auto-generated method stub | 215 |
Auto-generated method stub | 224 |
Auto-generated method stub | 233 |
Auto-generated method stub | 240 |
Auto-generated method stub | 249 |
Auto-generated method stub | 258 |
Auto-generated method stub | 268 |
Auto-generated method stub | 277 |
Auto-generated method stub | 286 |
Auto-generated method stub | 295 |
Auto-generated method stub | 304 |
Auto-generated method stub | 311 |
Auto-generated method stub | 320 |
Auto-generated method stub | 330 |
Auto-generated method stub | 339 |
Auto-generated method stub | 348 |
Auto-generated method stub | 358 |
Auto-generated method stub | 366 |
Auto-generated method stub | 372 |
Auto-generated method stub | 389 |
Auto-generated method stub | 398 |
Auto-generated method stub | 408 |
Auto-generated method stub | 417 |
Auto-generated method stub | 426 |
Auto-generated method stub | 435 |
Auto-generated method stub | 444 |
Auto-generated method stub | 453 |
Auto-generated method stub | 462 |
Auto-generated method stub | 473 |
Auto-generated method stub | 485 |
Auto-generated method stub | 495 |
Auto-generated method stub | 507 |
Auto-generated method stub | 516 |
Auto-generated method stub | 525 |
Auto-generated method stub | 535 |
Auto-generated method stub | 545 |
Auto-generated method stub | 551 |
Auto-generated method stub | 557 |
Auto-generated method stub | 566 |
Auto-generated method stub | 573 |
Auto-generated method stub | 582 |
Auto-generated method stub | 589 |
Auto-generated method stub | 597 |
Auto-generated method stub | 604 |
Auto-generated method stub | 613 |
Auto-generated method stub | 622 |
Auto-generated method stub | 629 |
org.kuali.student.lum.ui.requirements.util.StatementServiceMock | Line |
Auto-generated method stub | 357 |
Auto-generated method stub | 366 |
org.kuali.student.lum.workflow.CoursePostProcessorBase | Line |
set states of other approved courses to superseded | 131 |
We are not able to reuse the code in CourseStateUtil for dependency reason. | 162 |
org.kuali.student.lum.workflow.KualiStudentPostProcessorBase | Line |
evaluate group or role level changes by not using isUserRequest() | 145 |
org.kuali.student.lum.workflow.qualifierresolver.CocOrgTypeQualifierResolver | Line |
The following annotation needs to be udpated on role definition. | 29 |
org.kuali.student.lum.workflow.search.OrgSearchAttribute | Line |
RICE=M9 UPGRADE check that replacing getDocumentAttributes with extractDocumentAttributes is really the intended behavior | 42 |
RICE-M7 UPGRADE I think this is correct but I'm not sure | 56 |
org.kuali.student.r2.common.criteria.impl.CriteriaLookupDaoJpaImpl | Line |
There has to be a better way to do this. | 157 |
org.kuali.student.r2.common.criteria.transform.TransformTest | Line |
Rewrote the Rename Transform to honor the RiceContract then configure it here to test it transform = new RenameTransform(renames); | 59 |
Rewrote the Rename Transform to honor the RiceContract then configure it here to test it transform = new RenameTransform(renames); | 72 |
Rewrote the Rename Transform to honor the RiceContract then configure it here to test it transform = new RenameTransform(renames); | 110 |
org.kuali.student.r2.common.dao.CriteriaLookupDaoJpaImpl | Line |
There has to be a better way to do this. | 163 |
org.kuali.student.r2.common.datadictionary.RiceDataDictionaryValidatorImplDoesNotWorkButShould | Line |
figure why this does not validate anything | 33 |
org.kuali.student.r2.common.datadictionary.TestRiceDataDictionaryValidatorImplAgainstAcal | Line |
RICE-M9 UPGRADE | 321 |
RICE-M9 UPGRADE | 439 |
org.kuali.student.r2.common.datadictionary.TestRiceDataDictionaryValidatorImplAgainstAtp | Line |
RICE-M9 UPGRADE | 129 |
org.kuali.student.r2.common.datadictionary.infc.AttributeDefinitionInfc | Line |
figure out how to handle sub-objects. I.e. using dot notation? | 35 |
get Rice to rename this to getMinOccurs to it matches the setter. | 68 |
Get RICE to rename this getMaxOccurs so it matches the setter | 78 |
Get RICE to set a value that means UNBOUNDED, perhaps 999999999 | 79 |
Ask RICE to create an interface for ValidCharactersConstraint so we can return that instead of the generic constraint | 208 |
org.kuali.student.r2.common.datadictionary.infc.DictionaryEntry | Line |
determine how/if this works with the than the "unique" flag on attribute definition | 76 |
determine how/if this works with the id | 77 |
org.kuali.student.r2.common.datadictionary.util.CriteriaValidatorParser | Line |
Consider getting all the errors and throw them as a group instead of as we find them | 106 |
org.kuali.student.r2.common.datadictionary.util.TestBaseValidCharsDictionary | Line |
RICE-M9 UPGRADE | 50 |
fix reg ex so it allows 4.0 but excludes 4.1, 4.2 etc... assertNotNull (v.processValidCharConstraint ("test", vc, null, "4.1")); | 214 |
maybe allow these special characters | 310 |
maybe allow these special characters | 355 |
org.kuali.student.r2.common.dto.DtoConstants | Line |
Ideally this method should not be hardcoded here. Also determining next state may be a more complicated and not just be a simple sequence. | 58 |
org.kuali.student.r2.common.entity.MetaEntity | Line |
- need a BaseEntity(HasMeta) to deal w/ version, id, and other fields | 57 |
org.kuali.student.r2.common.infc.Comparison | Line |
Decide for complex Lists can they be checked to see how many occurences they have? | 55 |
Decide on other operators | 56 |
Deicde on operators to search collections inside such as any | 57 |
Decide how to search on dynamic attributes | 58 |
org.kuali.student.r2.common.infc.Criteria | Line |
Decide if null or empty list is ok? I.e. can you get ALL? | 30 |
org.kuali.student.r2.common.infc.MeetingSchedule | Line |
This interface should eventually move into the scheduling service domain | 26 |
org.kuali.student.r2.common.infc.RichText | Line |
Define what format is to be used? Is it assumed to be HTML? or WORD? or Wiki? | 41 |
org.kuali.student.r2.common.infc.Status | Line |
switch this to hold a count or something, a boolean that always is true is confusing. | 29 |
Figure out where the message came from because it is not in the R1 wiki https://wiki.kuali.org/display/KULSTU/statusInfo+Structure | 32 |
org.kuali.student.r2.common.infc.ValidationResult | Line |
decide if this is a key that then gets resolved into a real localized message using the message service or the final localized message itself | 60 |
find out how repeating substructures are handled in this notation, with [n] occurrence brackets? | 74 |
org.kuali.student.r2.common.service.impl.BaseAssembler | Line |
Delete leftovers here if behavior is desired | 103 |
fix this to conform to the real ref object uri but this is good enough for now to identify the type | 125 |
org.kuali.student.r2.common.util.RichTextHelper | Line |
actually implement a real conversion | 49 |
actually implement a real conversion | 57 |
org.kuali.student.r2.common.util.constants.LprRosterServiceConstants | Line |
rename the one above to the one below as they point to the same thing | 45 |
switch these constants to those above since they now point to the same thing | 64 |
org.kuali.student.r2.common.util.constants.LprServiceConstants | Line |
rename the one above to the one below as they point to the same thing | 77 |
switch these constants to those above since they now point to the same thing | 99 |
org.kuali.student.r2.core.class1.appointment.model.AppointmentSlotAttributeEntity | Line |
... | 28 |
org.kuali.student.r2.core.class1.appointment.model.AppointmentSlotEntity | Line |
... | 38 |
org.kuali.student.r2.core.class1.appointment.model.AppointmentWindowAttributeEntity | Line |
... | 28 |
org.kuali.student.r2.core.class1.appointment.model.AppointmentWindowEntity | Line |
... | 42 |
org.kuali.student.r2.core.class1.appointment.service.decorators.AppointmentServiceDecorator | Line |
... | 41 |
org.kuali.student.r2.core.class1.appointment.service.decorators.AppointmentServiceValidationDecorator | Line |
... | 23 |
org.kuali.student.r2.core.class1.appointment.service.impl.AppointmentServiceImpl | Line |
... | 51 |
Figure out what else to put in status | 231 |
Figure out what else to put in status | 247 |
Check what to do in inconsistency between appointmentWindowTypeKey and type in appointmentWindowInfo | 326 |
Handle removal of orphan RichTextEntities | 365 |
sambit - THIS METHOD NEEDS JAVADOCS | 535 |
org.kuali.student.r2.core.class1.appointment.service.impl.AppointmentServiceImplHelper | Line |
... | 43 |
Determine if there should be a check between apptType/slotId and apptInfo counterparts Need to manually set the entity since appointmentInfo only has an id for its corresponding AppointmentSlot | 84 |
Current implementation only supports minutes. Except thrown at start of this method for any other | 197 |
Currently, unsupported | 199 |
verify this is valid | 417 |
Perhaps do something else? Throw an exception? | 429 |
Figure this out (should it be taken care of) | 524 |
Figure out how to do this List<AtpInfo> infoList = atpService.getAtpsByMilestone(apptWin.getPeriodMilestoneId(), contextInfo); if (infoList.size() != 1) { throw new InvalidParameterException("Should only return one ATP"); } AtpInfo info = infoList.get(0); List<MilestoneInfo> milestoneList = atpService.getMilestonesForAtp(info.getId(), contextInfo); boolean found = false; for (MilestoneInfo milestone: milestoneList) { if (milestone.getTypeKey().equals(AtpServiceConstants.MILESTONE_DROP_DATE_TYPE_KEY)) { slotInfo.setEndDate(milestone.getEndDate()); found = true; break; } } if (!found) { throw new OperationFailedException("Drop date milestone not found"); } | 670 |
org.kuali.student.r2.core.class1.appointment.service.impl.TestAppointmentServiceImpl | Line |
... | 47 |
Eventually set the type once there is a type to set to | 169 |
Change for | 992 |
org.kuali.student.r2.core.class1.atp.service.impl.AtpServiceImpl | Line |
--No comment-- | 165 |
Why is this check here? Is there such a restriction? the model allos there to be many such relations over time if (checkRelationExistence(atpAtpRelationInfo)) { throw new DataValidationErrorException("The Atp-Atp relation already exists. atp=" + atpAtpRelationInfo.getAtpId() + ", relatedAtp=" + atpAtpRelationInfo.getRelatedAtpId()); } | 678 |
org.kuali.student.r2.core.class1.atp.service.impl.AtpServiceMockImpl | Line |
--No comment-- | 163 |
Put the check once methods to access milestons/atp using relations are added to the service | 428 |
org.kuali.student.r2.core.class1.atp.service.impl.TestAtpServiceImpl | Line |
should the milestone be saved in the calculation method or is that a seperate call? | 801 |
org.kuali.student.r2.core.class1.hold.mock.HoldServiceMockImpl | Line |
sambit - THIS METHOD NEEDS JAVADOCS | 249 |
sambit - THIS METHOD NEEDS JAVADOCS | 255 |
sambit - THIS METHOD NEEDS JAVADOCS | 309 |
org.kuali.student.r2.core.class1.organization.service.impl.OrganizationAssembler | Line |
Use the person Service here Person person = personService.findPerson(orgPersonRelationInfo.getPersonId()); if (person == null) { throw new InvalidParameterException( "Person does not exist for id: " + orgPersonRelationInfo.getPersonId()); } orgPersonRelation.setPersonId(person.getId()); | 416 |
org.kuali.student.r2.core.class1.process.CourseRegistrationServiceProcessCheckDecorator | Line |
implement in phase II | 75 |
org.kuali.student.r2.core.class1.process.krms.termresolver.CurrentDateResolver | Line |
Analyze, though probably not much to check here | 54 |
org.kuali.student.r2.core.class1.process.krms.termresolver.MilestoneByTypeResolver | Line |
Analyze | 75 |
org.kuali.student.r2.core.class1.process.krms.termresolver.MilestoneResolver | Line |
Analyze | 61 |
org.kuali.student.r2.core.class1.process.krms.termresolver.RegistrationHoldsTermResolver | Line |
Analyze | 74 |
org.kuali.student.r2.core.class1.process.krms.termresolver.StudentDeceasedTermResolver | Line |
analyze | 71 |
org.kuali.student.r2.core.class1.process.krms.termresolver.SummerOnlyStudentTermResolver | Line |
Analyze | 76 |
org.kuali.student.r2.core.class1.process.service.decorators.ProcessServiceValidationDecorator | Line |
remove | 57 |
Need to add dictionary entry | 58 |
check for existing | 84 |
remove | 128 |
Need to add dictionary entry | 129 |
check for existing | 158 |
remove | 177 |
populate dictionary entry | 178 |
check for existing | 218 |
remove | 301 |
Need to add dictionary entry | 302 |
org.kuali.student.r2.core.class1.process.service.impl.ProcessServiceImpl | Line |
--No comment-- | 76 |
--No comment-- | 86 |
--No comment-- | 95 |
--No comment-- | 104 |
--No comment-- | 112 |
--No comment-- | 121 |
--No comment-- | 132 |
--No comment-- | 141 |
--No comment-- | 151 |
--No comment-- | 159 |
--No comment-- | 169 |
--No comment-- | 179 |
--No comment-- | 234 |
--No comment-- | 242 |
--No comment-- | 250 |
--No comment-- | 261 |
--No comment-- | 391 |
--No comment-- | 399 |
--No comment-- | 410 |
--No comment-- | 597 |
--No comment-- | 606 |
--No comment-- | 620 |
incorporate context | 771 |
move to validation decorator? | 774 |
org.kuali.student.r2.core.class1.scheduling.model.ScheduleRequestComponentEntity | Line |
Left as @Column per Sambit, TBD: Change the following to join relations | 22 |
All the following need to change to using entities, leaving as ids per @Sambit | 50 |
All the following need to change to using entities, leaving as ids per @Sambit | 62 |
org.kuali.student.r2.core.class1.search.SearchServiceHardwiredImpl | Line |
... | 33 |
org.kuali.student.r2.core.class1.state.model.LifecycleEntity | Line |
Uncomment when/if we figure out if we store xxx_KEY as such in the DB instead of as ID | 22 |
org.kuali.student.r2.core.class1.state.model.StateEntity | Line |
Uncomment when/if we figure out if we store xxx_KEY as such in the DB instead of as ID | 25 |
consider storing this as a related JPA entity instead of as a string | 37 |
org.kuali.student.r2.core.class1.state.service.impl.StateServiceMockImpl | Line |
look at the criteria | 103 |
look at the criteria | 110 |
check for valid info | 117 |
call validate | 128 |
call validate | 144 |
look at criteria | 203 |
look at criteria | 209 |
check for valid info | 220 |
call validate | 247 |
org.kuali.student.r2.core.class1.type.service.impl.TypeServiceMockImpl | Line |
implement | 52 |
implement | 57 |
implement | 62 |
implement | 67 |
implement | 86 |
implement | 100 |
implement | 105 |
implement | 110 |
implement | 115 |
implement | 120 |
implement | 125 |
implement | 155 |
implement | 160 |
implement | 165 |
implement | 170 |
org.kuali.student.r2.core.exemption.infc.ExemptionRequest | Line |
understand the exact usage of this. | 105 |
org.kuali.student.r2.core.exemption.service.ExemptionServiceMockImpl | Line |
check the rest of the readonly fields that are specified on the create to make sure they match the info object | 57 |
check the rest of the readonly fields that are specified on the create to make sure they match the info object | 173 |
org.kuali.student.r2.core.fee.dao.EnrollmentFeeDao | Line |
... | 25 |
org.kuali.student.r2.core.fee.model.EnrollmentFeeAttributeEntity | Line |
... | 28 |
org.kuali.student.r2.core.fee.model.EnrollmentFeeEntity | Line |
... | 32 |
org.kuali.student.r2.core.fee.service.impl.TestFeeServiceImpl | Line |
... | 41 |
org.kuali.student.r2.core.population.infc.PopulationRule | Line |
Figure out how this can be persisted | 41 |
org.kuali.student.r2.core.population.service.PopulationServiceMockImpl | Line |
implement other logic | 166 |
org.kuali.student.r2.core.population.service.PopulationServiceMockImplTest | Line |
test attaching rule to a population | 169 |
org.kuali.student.r2.core.process.ProcessPocAtpServiceDecoratorTest | Line |
re-enable after refactoring | 35 |
org.kuali.student.r2.core.process.ProcessPocExemptionServiceDecoratorTest | Line |
re-enable after refactoring | 33 |
org.kuali.student.r2.core.process.ProcessPocJavaIntegrationTest | Line |
re-enable after refactoring | 48 |
Shouldn't this message say something about the fact that the student has an extention but it is even too late for that? | 324 |
org.kuali.student.r2.core.process.ProcessPocKrmsIntegrationTest | Line |
re-enable after refactoring | 39 |
org.kuali.student.r2.core.process.infc.Instruction | Line |
revisit rules that evaluate to ATPs. | 71 |
org.kuali.student.r2.core.process.service.impl.TestProcessServiceImpl | Line |
--No comment-- | 173 |
org.kuali.student.r2.core.statement.util.PropositionBuilder | Line |
--No comment-- | 243 |
--No comment-- | 358 |
--No comment-- | 376 |
--No comment-- | 411 |
--No comment-- | 417 |
org.kuali.student.r2.lum.course.infc.LoDisplay | Line |
... | 13 |
org.kuali.student.r2.lum.lo.infc.LoRepository | Line |
JAVADOCS | 9 |
org.kuali.student.r2.lum.program.dto.assembly.ProgramIdentifierAssembly | Line |
--No comment-- | 43 |
org.kuali.student.r2.lum.program.service.ProgramService | Line |
CHECK THESE VALUES | 51 |
org.kuali.student.r2.lum.program.service.ProgramServiceDecorator | Line |
sambit - THIS METHOD NEEDS JAVADOCS | 285 |
org.kuali.student.security.filter.AuthenticationGwtRpcFilter | Line |
handle this | 44 |
org.kuali.student.security.filter.KSLogoutFilter | Line |
handle this | 74 |
org.kuali.student.security.filter.ProxyTicketRetrieverFilter | Line |
handle this | 51 |
org.kuali.student.security.filter.ProxyTicketRetrieverFilterSTS | Line |
handle this | 65 |