The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.common.client.helpers.RecentlyViewedHelper.dependants isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 11 | High |
| org.kuali.student.lum.common.client.helpers.RecentlyViewedHelper.recentlyViewedDocs isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 10 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.lum.common.client.lo.CategoryManagement$DeleteConfirmationDialog.nameTextBox | PERFORMANCE | URF_UNREAD_FIELD | 362 | Medium |
| Unread field: org.kuali.student.lum.common.client.lo.CategoryManagement$DeleteConfirmationDialog.spacer | PERFORMANCE | URF_UNREAD_FIELD | 358 | Medium |
| Unread field: org.kuali.student.lum.common.client.lo.CategoryManagement$DeleteConfirmationDialog.typeListBox | PERFORMANCE | URF_UNREAD_FIELD | 363 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.common.client.lo.CategoryManagementTable$CategoryRow be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 75 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.kuali.student.lum.common.client.lo.LOBuilder.messageGroup from instance method new org.kuali.student.lum.common.client.lo.LOBuilder(String, String, String, String, String, Metadata) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 83 | High |
| Write to static field org.kuali.student.lum.common.client.lo.LOBuilder.repoKey from instance method new org.kuali.student.lum.common.client.lo.LOBuilder(String, String, String, String, String, Metadata) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 82 | High |
| Write to static field org.kuali.student.lum.common.client.lo.LOBuilder.startOfPath from instance method new org.kuali.student.lum.common.client.lo.LOBuilder(String, String, String, String, String, Metadata) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 84 | High |
| Write to static field org.kuali.student.lum.common.client.lo.LOBuilder.state from instance method new org.kuali.student.lum.common.client.lo.LOBuilder(String, String, String, String, String, Metadata) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 81 | High |
| Write to static field org.kuali.student.lum.common.client.lo.LOBuilder.type from instance method new org.kuali.student.lum.common.client.lo.LOBuilder(String, String, String, String, String, Metadata) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 80 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.lum.common.client.lo.LOBuilderBinding.setModelValue(LOBuilder, DataModel, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 39 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.common.client.lo.LOCategoryBuilder$CreateLoCancelGroup be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 735 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.common.client.lo.LOCategoryBuilder$LOCategoryPicker be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 452 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.common.client.lo.LOCategoryBuilder$LOCategoryTypeInfoList be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 537 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.lum.common.client.lo.TreeStringBinding$StringTreeStructure.getCategoriesString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 161 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.common.client.widgets.BuildCluSetWidget$3.exec(List) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 163 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.common.client.widgets.Calendar.getTime() may expose internal representation by returning Calendar.date | MALICIOUS_CODE | EI_EXPOSE_REP | 157 | Medium |
| org.kuali.student.lum.common.client.widgets.Calendar.setTime(Date) may expose internal representation by storing an externally mutable object into Calendar.date | MALICIOUS_CODE | EI_EXPOSE_REP2 | 97 | Medium |
| org.kuali.student.lum.common.client.widgets.Calendar defines equals(Calendar) method and uses Object.equals(Object) | CORRECTNESS | EQ_SELF_USE_OBJECT | 214 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.kuali.student.lum.common.client.widgets.CluSetEditorWidget(CluSetRetriever, Enum, String, String, boolean, Callback, String, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 105 | Medium |
| Call to equals() comparing different types in org.kuali.student.lum.common.client.widgets.CluSetEditorWidget.findLookupMetadataByLookupId(String, List, List) | CORRECTNESS | EC_UNRELATED_TYPES | 512 | High |
| Possible null pointer dereference of CluSetEditorWidget.showCluRangeDetailsHandlerRegs in org.kuali.student.lum.common.client.widgets.CluSetEditorWidget.addClusetItemViewHandler(CluSetRangeDataHelper, KSItemLabel, LookupMetadata, Data, SearchRequest) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 356 | Medium |
| Possible null pointer dereference of CluSetEditorWidget.cluSetType in org.kuali.student.lum.common.client.widgets.CluSetEditorWidget.setupEditor() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 291 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$1.exec(Metadata) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 95 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$CluSetBinding be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 644 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of model in org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$CluSetRangeBinding.setWidgetValue(HasDataValue, DataModel, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 677 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$KSItemLabelPanelPair be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 588 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$KSSelectedListPanelPair be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 567 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.common.client.widgets.CluSetHelper.getReferenceable() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 166 | Medium |
| org.kuali.student.lum.common.client.widgets.CluSetHelper.getReusable() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 151 | Medium |
| org.kuali.student.lum.common.client.widgets.CluSetHelper.setReferenceable(Boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 159 | Medium |
| org.kuali.student.lum.common.client.widgets.CluSetHelper.setReusable(Boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 144 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.common.client.widgets.CluSetRangeModelUtil.INSTANCE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 13 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from com.google.gwt.user.client.ui.Widget to org.kuali.student.common.ui.client.widgets.impl.KSDropDownImpl in org.kuali.student.lum.common.client.widgets.GradeWidget$2.exec(Widget) | STYLE | BC_UNCONFIRMED_CAST | 92 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.common.client.widgets.GregorianCalendar defines clone() but doesn't implement Cloneable | BAD_PRACTICE | CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE | 362 | Medium |
| org.kuali.student.lum.common.client.widgets.GregorianCalendar defines equals(GregorianCalendar) method and uses Object.equals(Object) | CORRECTNESS | EQ_SELF_USE_OBJECT | 326 | High |
| org.kuali.student.lum.common.client.widgets.GregorianCalendar.daysInMonth should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 54 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: org.kuali.student.lum.common.client.widgets.SwitchSection.deletionParentKeys | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
