Tag List Report

The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.

Tag ClassTotal number of occurrencesTag strings used by tag class
FIXME's123FIXME
TODO's1234TODO

Each tag is detailed below:

FIXME's

Number of occurrences found in the code: 123

org.kuali.student.common.assembly.util.IdTranslatorLine
workaround until orch dict can handle multi part keys on initiallookup defs61
org.kuali.student.common.dao.impl.AbstractSearchableCrudDaoImplLine
SQL injection can occur here - or NOT if we need to assemble SQL to cover various ways one can compare criteria to a text116
org.kuali.student.common.dto.DtoConstantsLine
Need to split out proposal states (ie. workflow states) versus dto states20
org.kuali.student.common.rice.StudentWorkflowConstantsLine
The workflow doc type needs to be removed from ProposalWorkflowFilter6
org.kuali.student.common.search.service.impl.CrossSearchManagerLine
this is pretty inefficient to loop through everything... a map structure for the cells might be better244
breaks are bad... but there is no map in the cells253
breaks are bad... but there is no map in the cells274
breaks are bad... but there is no map in the cells302
breaks are bad... but there is no map in the cells313
needs a handle to the result params data types here391
org.kuali.student.common.search.service.impl.SearchManagerImplLine
should we change these to Operation Failed Exceptions? also we need to handle invalid parameters.153
org.kuali.student.common.ui.client.application.ViewContextLine
change state to proper default or null40
org.kuali.student.common.ui.client.configurable.mvc.DelayedToolViewLine
? need to wire onReadyCallback into the model request, so that we aren't indicating that we're ready before the model is available?86
org.kuali.student.common.ui.client.configurable.mvc.layouts.TabbedSectionLayoutLine
Better way to manage hierarchy, ordering, and handle to views51
this is not safe for all sorts of reasons, do not call handlers directly like this.106
keep or delete?132
org.kuali.student.common.ui.client.security.SpringSecurityLoginRedirectHandlerLine
Need a way to get the proper redirect url, for now just reloading the page BrowserUtils.redirect(GWT.getHostPageBaseURL());19
org.kuali.student.common.ui.client.util.SearchUtilsLine
throw an exception?110
org.kuali.student.common.ui.client.validator.DataModelValidatorLine
This is a temp solution for getting cross field min value649
This is a temp solution for getting cross field max value668
org.kuali.student.common.ui.client.widgets.containers.KSWrapperLine
notify current controller of the page change so it can perform an action102
before navigation event103
does this do anything?161
org.kuali.student.common.ui.client.widgets.list.KSSelectedListLine
do we need to do a search? is this method ever going to be called?384
org.kuali.student.common.ui.client.widgets.list.impl.KSLabelListImplLine
Is there a better way to display selected item here without redrawing84
org.kuali.student.common.ui.client.widgets.pagetable.PagingScrollTableBuilderLine
workaround for incubator bug [KSCOR-225] This table to be replaced in M6176
org.kuali.student.common.ui.client.widgets.search.KSPickerLine
should we search on values to populate drop down here or later when user will access the screen?208
This method of creating read is very inefficient, need better solution231
is this configuration error?319
what about the result id?361
what about the result ids?365
org.kuali.student.common.ui.client.widgets.search.SearchPanelLine
hack - comparison to 'optional' - replace with check against 'optional' field and update related lookup metadata488
throw an exception?499
remove because required field '*' indication will be part of FieldElement class566
hack - comparison to 'optional' - replace with check against 'optional' field and update related lookup metadata783
org.kuali.student.common.ui.client.widgets.search.SearchResultsTableLine
do we really need to recreate the table for every refresh?96
Do we still need this if condition? Added an else to the if(pagedResults) line to prevent searches being executed twice if the search name includes cross151
more detail info here183
org.kuali.student.common.ui.client.widgets.search.SwappablePanelLine
eventually we will need 'Search For' label as well. can the use of 'Search By' or 'Search For' be automatically implied or do we need another lookup configuration parameter?40
org.kuali.student.common.ui.client.widgets.search.TempSearchBackedTableLine
more detail info here99
auto adjusting width to fill table does not work with 1 column bug in incubator???140
do we really need to recreate the table for every refresh?151
Undesirable solution to work with GWT 2.0157
org.kuali.student.common.ui.client.widgets.suggestbox.SearchSuggestOracleLine
handle case when search for text is not appearing within search result - should not happen (misconfiguration)256
org.kuali.student.common.ui.client.widgets.suggestbox.SuggestPickerLine
Suggest picker marker interface, temporary fix?24
org.kuali.student.common.ui.server.gwt.old.AbstractBaseDataOrchestrationRpcGwtServletLine
issues: -The Type/state config is hardcoded here which will cause troubles with different types and states -Workflow filter should be combined with this for save -The exception handling here needs standardization. Should RPC errors throw operation failed with just the message and log the message and exception? also should calls that return Boolean ever throw exceptions?46
should not pass empty id. What to do here?76
org.kuali.student.common.util.spring.MethodArgsToObjectEhcacheAdviceLine
This will result in inconsistent behvior if the value is the literal '<null>' vs being null106
org.kuali.student.core.comment.service.impl.TestCommentServiceImplLine
validation needs to be tested, this code doesn't work and I need to refactor CommentInfo commentInfo = new CommentInfo(); RichTextInfo commentText = new RichTextInfo(); commentText.setFormatted("<p>comment&gt;!@#02h%$</p>"); commentText.setPlain("comment"); commentInfo.setCommentText(commentText); commentInfo.setReferenceTypeKey("referenceKey"); commentInfo.setReferenceId("referenceId"); commentInfo.setEffectiveDate(new Date()); commentInfo.setExpirationDate(new Date());129
org.kuali.student.core.document.service.impl.TestDocumentServiceImplLine
validation needs to be tested, this code doesn't work and I need to refactor DocumentInfo documentInfo = new DocumentInfo(); RichTextInfo desc = new RichTextInfo(); desc.setFormatted("<p>document&gt;!%/#;&amp;@$</p>"); desc.setPlain("document"); documentInfo.setDesc(desc); documentInfo.setFileName("sample.pdf"); documentInfo.setEffectiveDate(new Date()); documentInfo.setExpirationDate(new Date()); documentInfo.setType("kuali.org.Document"); documentInfo.setState("active");244
org.kuali.student.core.document.ui.server.upload.UploadServletLine
Probably temporary solution for type on document info153
org.kuali.student.core.enumerationmanagement.service.impl.EnumerationManagementServiceImplLine
need real validation66
need to get messages here114
need to get messages here176
org.kuali.student.core.organization.assembly.OrgProposalAssemblerLine
should this be something like org.proposal?315
org.kuali.student.core.organization.service.impl.OrganizationServiceImplLine
redo validation here and for all calls to create/update return validator.validateTypeStateObject(orgInfo, getObjectStructure("orgInfo"));758
org.kuali.student.core.organization.ui.client.mvc.controller.OrgProposalControllerLine
needs to check validation results and display messages if validation failed This was reviewd as part of KSCOR-220, deferred to KSCOR-225, can't be fixed until server side validation completed454
org.kuali.student.core.personsearch.service.impl.KsPersonLine
Either find a cleaner fix or go back to using PersonSerice38
org.kuali.student.core.statement.service.assembler.StatementTreeViewAssemblerLine
Unsure now if this is an exception or just return null or empty assemblyNode47
org.kuali.student.core.statement.service.impl.TestStatementServiceImplLine
- Investigate why adding clu1, clu3, clu2 works but adding clu1, clu2, clu3 doesn't work157
org.kuali.student.enrollment.class1.lpr.model.LprRosterEntityLine
Do we need to copy create and update time/id?203
org.kuali.student.enrollment.class1.lpr.service.impl.LuiPersonRelationServiceImplLine
Remove entries from KSEN_LPRROSTER_LUI_RELTN, attributes and desc449
org.kuali.student.enrollment.class1.lu.service.impl.CluServiceImplLine
, this should be DB time2937
org.kuali.student.enrollment.class2.acal.controller.AcademicCalendarControllerLine
Have to handle the error.. but for now, as it's causing issue, just skipping calculation when there are errors617
org.kuali.student.enrollment.class2.acal.service.impl.CalendarSearchViewHelperServiceImplLine
Find some better way to check the year98
org.kuali.student.enrollment.class2.appointment.service.impl.AppointmentViewHelperServiceImplLine
Use Joda DateTime355
org.kuali.student.enrollment.class2.courseoffering.dto.ActivityOfferingFormObjectLine
As we dont have Lui types in DB and in mock, just assigning term state for now to get the ui working...19
org.kuali.student.enrollment.class2.courseregistration.service.assembler.CourseRegistrationAssemblerLine
Needs sure whether this ResultValuesGroup loading should be a part of the above assemble methods44
org.kuali.student.enrollment.class2.grading.controller.GradingControllerLine
Just a workaround as the propertyreplacer not working76
Not sure how to set a global error instead of for a field. If no fields mentioned, KRAD throwing error82
Not sure how to set a global error instead of for a field. If no fields mentioned, KRAD throwing error138
Not sure how to set a global error instead of for a field. If no fields mentioned, KRAD throwing error163
org.kuali.student.enrollment.class2.grading.service.impl.GradingServiceImplLine
Hardcoded for core slice601
This method needs some code refactoring721
org.kuali.student.enrollment.class2.grading.service.impl.GradingViewHelperServiceImplLine
Change it to use proper error handling277
org.kuali.student.lum.common.client.lo.CategoryManagementLine
[KSCOR-225] user needs to specify what LoRepository they want category to tagged with643
org.kuali.student.lum.common.client.lo.LOCategoryBuilderLine
[KSCOR-225] Class needs to be rewritten to use KSPicker instead of SuggestPicker and use lookup config through metadata454
org.kuali.student.lum.common.client.lu.LUUIConstantsLine
Duplicated from lum-api LUConstants30
org.kuali.student.lum.course.service.assembler.ActivityAssemblerLine
Unsure now if this is an exception or just return null or empty assemblyNode60
org.kuali.student.lum.course.service.assembler.CourseAssemblerLine
Unsure now if this is an exception or just return null or empty assemblyNode279
org.kuali.student.lum.course.service.assembler.CourseAssemblerConstantsLine
follow Norm's Type Keys (this requires impex changes) public final static String COURSE_RESULT_TYPE_GRADE = "kuali.resultType.grades"; public final static String COURSE_RESULT_TYPE_CREDITS = "kuali.resultType.credits";58
ask norm for these values76
ask norm about this value92
org.kuali.student.lum.course.service.assembler.CourseJointAssemblerLine
is this ever used?65
Unsure now if this is an exception or just return null or empty assemblyNode83
org.kuali.student.lum.course.service.assembler.FormatAssemblerLine
Unsure now if this is an exception or just return null or empty assemblyNode102
org.kuali.student.lum.course.service.impl.TestCourseServiceImplLine
--No comment--804
need a dictionary that defines StatamentTreeViewInfo925
need a dictionary that defines StatamentTreeViewInfo937
org.kuali.student.lum.lu.assembly.CluSetManagementAssemblerLine
should have it's own proposal types59
--No comment--526
--No comment--531
--No comment--535
org.kuali.student.lum.lu.entity.CluLine
dates should be either set from the DB time as part of the insert statement, or set from the application. DB timestamp (CURRENT_TIMESTAMP) is preferred47
org.kuali.student.lum.lu.service.impl.LuServiceImplLine
should be more checked service exceptions thrown2984
, this should be DB time3708
org.kuali.student.lum.lu.ui.course.client.configuration.CourseConfigurerLine
[KSCOR-225] Temporary fix til we have a real rich text editor addField(description, COURSE + "/" + DESCRIPTION, null);480
[KSCOR-225] Commented out search code to display drop down with only current user, and disable select788
org.kuali.student.lum.lu.ui.course.client.configuration.ViewCourseConfigurerLine
[KSCOR-225] Temp paths waiting for DOL changes77
[KSCOR-225] Initialize type and state from selected cluId83
org.kuali.student.lum.lu.ui.course.client.controllers.VersionsControllerLine
this is not updating the cluModel so state will not be updated in the model. May not be a problem.294
org.kuali.student.lum.lu.ui.course.client.controllers.ViewCourseControllerLine
this is not updating the cluModel so state will not be updated in the model. May not be a problem.163
org.kuali.student.lum.lu.ui.course.server.gwt.CourseDataServiceLine
calling getData after createNewCourseVersion is inefficient, but we need to have the transformations/filters be applied105
org.kuali.student.lum.lu.ui.main.client.widgets.ApplicationHeaderLine
notify current controller of the page change so it can perform an action104
before navigation event105
the following code gets overridden159
org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurerLine
do something else here, rework logic rootSection.redraw();370
org.kuali.student.lum.program.client.major.edit.MajorEditControllerLine
This is ugly but gets us past a blocker issue. Theres something wrong with the way the models are handled in the major and variation controllers so they get out of sync. This is a temporary workaround174
org.kuali.student.lum.program.client.major.view.MajorViewControllerLine
Find a better way to do this. We shouldn't be maintaining two separate datamodels for progs and variations113
org.kuali.student.lum.program.service.assembler.CoreProgramAssemblerLine
Unsure now if this is an exception or just return null or empty assemblyNode74
org.kuali.student.lum.program.service.assembler.CredentialProgramAssemblerLine
Unsure now if this is an exception or just return null or empty assemblyNode79
org.kuali.student.lum.program.service.assembler.ProgramAssemblerConstantsLine
ask norm about this value109
org.kuali.student.lum.program.service.assembler.ProgramVariationAssemblerLine
Unsure now if this is an exception or just return null or empty assemblyNode78
org.kuali.student.lum.program.service.impl.ProgramRequirementAssemblerLine
Unsure now if this is an exception or just return null or empty assemblyNode106
Derive from statement and rule types188
org.kuali.student.lum.program.service.impl.ProgramServiceImplLine
, this validation should be moved into a custom validation class + configuration1407
error should return using message service and not static text1431
org.kuali.student.lum.program.service.impl.TestProgramServiceImplLine
--No comment--132
Updated version info isn't returned1077
org.kuali.student.lum.statement.typekey.ReqComponentFieldTypesLine
Why do we have test data in our code?54
org.kuali.student.r2.common.dto.DtoConstantsLine
Need to split out proposal states (ie. workflow states) versus dto states43
org.kuali.student.r2.core.class1.enumerationmanagement.service.impl.EnumerationManagementServiceImplLine
need real validation142
org.kuali.student.r2.core.class1.organization.service.impl.OrganizationServiceImplLine
redo validation here and for all calls to create/update return validator.validateTypeStateObject(orgInfo, getObjectStructure("orgInfo"));235

TODO's

Number of occurrences found in the code: 1234

org.kuali.rice.krms.test.AbstractBoTestLine
do this fur eel80
org.kuali.rice.krms.test.KSLumAbstractBoTestLine
do this fur eel76
NINA somthing wrong with Type contextBuilder.setTypeId(krmsContextTypeDefinition.getId());92
org.kuali.rice.krms.test.KSLumKRMSDataSetupTestLine
Auto-generated method stub847
NINA Add the context link to the Term Specification873
org.kuali.rice.krms.test.ValidationIntegrationTestLine
do this fur eel287
org.kuali.rice.student.StudentStandaloneTestBaseLine
RICE-R2.0 UPGRADE - caching currently removed from rice. Will likely be added in KimApiServiceLocator.getIdentityService().flushAllCaches();71
RICE-R2.0 UPGRADE - not sure flushInternalRoleCache is really the replacmenet for flushRoleCache - see previous TODO KimApiServiceLocator.getRoleService().flushInternalRoleCache(); KimApiServiceLocator.getRoleService().flushRoleCaches();73
org.kuali.rice.student.StudentStandaloneTestBaseLine
RICE-R2.0 UPGRADE - caching disabled in M7 will be revisited prior to 2.0 release KimApiServiceLocator.getIdentityService().flushAllCaches(); KimApiServiceLocator.getRoleService().flushRoleCaches();74
org.kuali.rice.student.bo.KualiStudentKimAttributesLine
MARKED AS FINAL!233
org.kuali.rice.student.core.web.context.RiceWebApplicationContextProxyLine
- is there a refactor candidacy here?210
- is there a refactor candidacy here?219
- is there a refactor candidacy here?235
org.kuali.rice.test.data.UnitTestDataLine
Come back and add the JPQL equivalents44
org.kuali.rice.test.lifecycles.JettyServerLifecycleLine
RICE-2.0 UPGRADE had to jump through hoops with M8 because getConfig was made private. Uncomment the following and remove the next block Config webappConfig = ConfigContext.getConfig(webappClassLoader);143
org.kuali.rice.test.lifecycles.SQLDataLoaderLifecycleLine
may way to do something with the dataLoader62
org.kuali.student.admin.messages.service.impl.MessageServiceImplLine
RICE-M7 UPGRADE figure out why this soap binding stuff was here in the first place29
org.kuali.student.common.assembly.AddOneAssemblerLine
Auto-generated method stub32
Auto-generated method stub38
Auto-generated method stub50
Auto-generated method stub65
Auto-generated method stub71
org.kuali.student.common.assembly.data.DataLine
probably need to add all of the other remove(type) methods607
what should be done if we try to query cluset/clus/0/_runtimeData where cluset/0 returns a string instead of Data throw an exception here?864
org.kuali.student.common.assembly.data.LookupMetadataLine
is DEFAULT needed? it has 0 references49
BUTTON has 0 references. Is it needed?56
org.kuali.student.common.assembly.data.LookupParamMetadataLine
none of these are used44
org.kuali.student.common.assembly.data.MetadataLine
When all dictionaries have been updated, this needs to be changed to a single value object. No need for it to be a list with new dictionary structure.55
dump lookup/etc info as well140
org.kuali.student.common.assembly.data.MetadataInterrogatorLine
worry aboutg special validators216
worry about how this applies to non-strings?217
worry aboutg special validators304
worry about how this applies to non-strings?305
worry aboutg special validators323
worry about how this applies to non-strings?324
worry about hard coding ids341
Worry about hard coding the cut-off point345
org.kuali.student.common.assembly.data.QueryPathLine
revamp this method to use subList once GWT issue 1791 is fixed152
org.kuali.student.common.assembly.data.UILookupDataLine
is DEFAULT needed? it has 0 references39
BUTTON has 0 references. Is it needed?46
org.kuali.student.common.assembly.dictionary.MetadataServiceImplLine
figure out why path=courseInfo.creditOptions.type matches any structure that has a type on it so that lookup gets returned for all types573
org.kuali.student.common.assembly.dictionary.old.MetadataServiceImplLine
--No comment--48
org.kuali.student.common.assembly.helper.PropertyEnumLine
merge this to common, when merging Norm's generated stuff18
org.kuali.student.common.assembly.old.BaseAssemblerLine
Below must be changed to use constants from KualiStudentKimAttributes class (class is currently in LUM)65
org.kuali.student.common.assembly.transform.AuthorizationFilterLine
If fields were masked, need to prevent masked values from being persisted.81
org.kuali.student.common.assembly.util.AssemblerUtilsLine
need a "standard properties" enum for values that could be present on any object?94
need a "standard properties" enum for values that could be present on any object?123
org.kuali.student.common.dictionary.dto.ObjectStructureDefinitionLine
do we need this?15
do we need this?21
org.kuali.student.common.dictionary.dto.ValidCharsConstraintLine
Should this be a list of values10
org.kuali.student.common.dictionary.old.dto.FieldLine
there is no required here but there should be66
org.kuali.student.common.dictionary.service.impl.DictionaryFormatterLine
other more complex constraints751
org.kuali.student.common.dictionary.service.impl.DictionaryValidatorLine
Cross compare to make sure min is not greater than max and that default value is valid itself133
make the date parser configurable like the validator is267
more validation330
more validation402
org.kuali.student.common.dto.DtoConstantsLine
Ideally this method should not be hardcoded here. Also determining next state may be a more complicated and not just be a simple sequence.35
org.kuali.student.common.rice.StudentIdentityConstantsLine
It seems wrong to include DOCUMENT_TYPE_NAME in an identity constants class44
org.kuali.student.common.rice.StudentWorkflowConstantsLine
This class needs to be combined with org.kuali.student.StudentWorkflowConstants class found in ks-lum-rice3
org.kuali.student.common.search.service.impl.CrossSearchManagerLine
get the types for the params!319
org.kuali.student.common.search.service.impl.SearchConfigValidatorLine
validate23
org.kuali.student.common.ui.client.CommonUITestLine
Auto-generated method stub121
org.kuali.student.common.ui.client.application.KSAsyncCallbackLine
Better detection of session timeout74
org.kuali.student.common.ui.client.configurable.mvc.DelayedToolViewLine
Auto-generated method stub145
org.kuali.student.common.ui.client.configurable.mvc.binding.HasValueBindingLine
Type checking to ensure that the value type of widget matches model defintion47
org.kuali.student.common.ui.client.configurable.mvc.binding.MultiplicityItemBindingLine
modify this method to use QueryPath.add to build paths, rather than string manipulation52
org.kuali.student.common.ui.client.configurable.mvc.binding.RichTextBindingLine
Should these defaults be set in server assembly defaults? Commenting type and state as it is not required for rich text qPath = QueryPath.parse(richTextRoot + "type"); model.set(qPath, "kuali.not.applicable");57
org.kuali.student.common.ui.client.configurable.mvc.layouts.MenuEditableSectionControllerLine
Change to put in section header90
org.kuali.student.common.ui.client.configurable.mvc.layouts.MenuSectionControllerLine
add description to the menu item290
org.kuali.student.common.ui.client.configurable.mvc.multiplicity.MultiplicityGroupLine
might want fields and nested multiplicities at the same time. Remove if/else201
Should copy widgets/bindings too?213
org.kuali.student.common.ui.client.configurable.mvc.multiplicity.MultiplicityGroupItemLine
Should this be an inner class in MultiplicityGroup?49
org.kuali.student.common.ui.client.configurable.mvc.multiplicity.MultiplicityTableLine
should just be 1 row def for a table - throw exception if > 1?75
org.kuali.student.common.ui.client.configurable.mvc.sections.BaseSectionLine
Can we do this without checking for instanceof MG??321
org.kuali.student.common.ui.client.configurable.mvc.sections.MultiplicitySectionLine
--No comment--69
org.kuali.student.common.ui.client.configurable.mvc.views.SectionViewLine
review this, shouldn't it assign this.model = m?177
org.kuali.student.common.ui.client.configurable.mvc.views.VerticalSectionViewLine
Auto-generated method stub93
org.kuali.student.common.ui.client.event.ExportEventLine
Administrator - THIS METHOD NEEDS JAVADOCS31
org.kuali.student.common.ui.client.mvc.ControllerLine
Nina how do you do loggin in GWT? final static Logger logger = Logger.getLogger(Controller.class);65
this logic needs to be reworked a bit... if an unchecked event has been bound locally, do we want to still fire it externally as well?358
add some automatic view context setting here, get and set466
Nina ??? Do we want to keep this seen in the light of the exportElements parameter603
org.kuali.student.common.ui.client.mvc.ViewCompositeLine
Auto-generated method stub130
org.kuali.student.common.ui.client.mvc.history.HistoryManagerLine
add the ability for view context to add a variety of additional attributes295
org.kuali.student.common.ui.client.service.SecurityRpcServiceLine
Expand to support additional auth/authz operations.24
org.kuali.student.common.ui.client.service.exceptions.OperationFailedExceptionLine
A better solution for exceptions on client side.23
org.kuali.student.common.ui.client.util.ExportUtilsLine
Nina - This can't be the correct way of getting handle to Controller, isn't there a better way??110
org.kuali.student.common.ui.client.widgets.KSDatePickerLine
03/11/2009 - This widget currently only supports dates entered in the mm/dd/yyyy format. Known unresolved backspace bug in Firefox.36
org.kuali.student.common.ui.client.widgets.KSErrorDialogLine
maybe retrieve more error info124
actually gather client context info, such as browser version, user id, etc129
org.kuali.student.common.ui.client.widgets.KSItemLabelLine
--No comment--163
org.kuali.student.common.ui.client.widgets.KSRichEditorLine
implement i18n35
org.kuali.student.common.ui.client.widgets.KSRichEditorAbstractLine
implement with a clean toolbar and i18n27
org.kuali.student.common.ui.client.widgets.field.layout.element.FieldElementLine
Do a check here to change the type of label based on widget type eventually236
show actual help window341
does nothing on warn, warn is not currently used411
does nothing on ok, ok is not currently used414
better way to generate unique id here?453
org.kuali.student.common.ui.client.widgets.field.layout.layouts.TableFieldLayoutLine
Auto-generated method stub118
org.kuali.student.common.ui.client.widgets.field.layout.layouts.UnborderedHeadedLayoutLine
rename styles to remove references to course format and activity28
org.kuali.student.common.ui.client.widgets.list.KSSelectedListLine
ryan - THIS METHOD NEEDS JAVADOCS302
org.kuali.student.common.ui.client.widgets.pagetable.GenericTableModelLine
return dynamic size when loading with RPC188
org.kuali.student.common.ui.client.widgets.search.KSPickerLine
Reviewed in M6 cleanup, unknown: Update to also work with a KSLabelList that doesn't require pre-population of all list items571
org.kuali.student.common.ui.client.widgets.search.SearchPanelLine
pass search to the table301
is this check needed here? probably. assuming string here306
is this null check needed here? probably. assuming string here485
make check more robust here/inserting params more robust do not pass to the search parameters that are empty486
use message call here553
Add handling of default value lists here557
need to handle date and other types here, how they are converted for search, etc597
Should be string only, needs type safety629
this should be a message key717
is this null check needed here? probably. assuming string here780
make check more robust here/inserting params more robust do not pass to the search parameters that are empty781
org.kuali.student.common.ui.client.widgets.search.SearchResultsTableLine
- there's a better way to do this124
org.kuali.student.common.ui.client.widgets.suggestbox.KSSuggestBoxLine
implement some form of focus handling for SuggestBox38
ryan - THIS METHOD NEEDS JAVADOCS256
org.kuali.student.common.ui.client.widgets.table.summary.SummaryTableRowLine
Nina - Code Review - is it ok that i change to public...78
org.kuali.student.common.ui.client.widgets.table.summary.SummaryTableSectionLine
handle custom widgets (multiplicity field widget initializer)173
handle custom widgets (multiplicity field widget initializer)233
org.kuali.student.common.ui.client.widgets.tabs.impl.KSTabPanelImplLine
Auto-generated method stub65
Auto-generated method stub71
Auto-generated method stub77
Auto-generated method stub83
Auto-generated method stub89
Auto-generated method stub96
org.kuali.student.common.ui.server.applicationstate.ApplicationStateManagerLine
The ApplicationStateManager needs to be reviewed as part of the code clean-up.19
org.kuali.student.common.ui.server.gwt.AbstractDataServiceLine
why do we have this reference in the base class????42
Igor : Why do we check for this when getting the data for programs?53
org.kuali.student.common.ui.server.gwt.ExportDocumentDownloadLine
Nina how must we handle exceptions here?? do something here28
org.kuali.student.common.ui.server.gwt.ExportGwtRpcServletLine
Nina do we want this as a system Property??34
org.kuali.student.common.ui.server.gwt.LogRpcGwtServletLine
Use sl4j for logging36
org.kuali.student.common.ui.shared.IdAttributesLine
OBJECT_ID has no references10
org.kuali.student.common.ui.theme.standard.client.CommonImagesImplLine
Auto-generated method stub97
org.kuali.student.common.validator.BeanConstraintDataProviderLine
fix it later.42
org.kuali.student.common.validator.DefaultValidatorImplLine
parse fieldname from here355
What happens when the field is not in the dataProvider?406
There needs to be some mapping from PropertyUtils to the KS path Until then, this will only work for root level properties413
figure out what data should go here instead of null531
Implement lookup constraint539
org.kuali.student.common.validator.old.BeanConstraintDataProviderLine
fix it later.36
Should not be ignoring exception53
org.kuali.student.common.validator.old.ValidatorLine
Change this to 'default' when the change is made in xml47
Setup a mechanism to retrive referenced object structures nestedObjStruct = setupFactory.getObjectStructure(field .getFieldDescriptor().getObjectStructureRef());227
What happens when the field is not in the dataProvider?546
Allow different processing based on the label600
Implement lookup constraint659
Implement TypeStateCase constraint663
org.kuali.student.core.assembly.transform.ProposalWorkflowFilterLine
this needs to be defined as a constant where all references will resolve120
RICE-R2.0 UPGRADE we can now supply the proposal status to the document here and we should be This will allow implementors to define workflow based on proposal state198
org.kuali.student.core.comments.ui.client.widgets.commenttool.CommentToolLine
use user id for now change to user name328
org.kuali.student.core.dictionary.service.TestBaseDictionaryLine
fix reg ex so it allows 4.0 but excludes 4.1, 4.2 etc... assertNotNull (v.processValidCharConstraint ("test", vc, null, "4.1"));180
maybe allow these special characters277
maybe allow these special characters325
org.kuali.student.core.document.service.DocumentServiceLine
CHECK THESE VALUES52
org.kuali.student.core.document.ui.client.widgets.documenttool.DocumentListLine
Reviewed in M6, future fix: this will fail if the document does not exist BUT the relation does, needs a check for existance before delete151
org.kuali.student.core.enumerationmanagement.service.impl.EnumerationManagementServiceImplLine
Kamal - THIS METHOD NEEDS JAVADOCS288
Kamal - THIS METHOD NEEDS JAVADOCS294
org.kuali.student.core.organization.assembly.OrgOrgRelationAssemblerLine
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS63
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS98
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS118
Auto-generated method stub293
org.kuali.student.core.organization.assembly.OrgPersonRelationAssemblerLine
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS65
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS71
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS110
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS234
Auto-generated method stub240
org.kuali.student.core.organization.assembly.OrgPositionRestrictionAssemblerLine
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS61
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS67
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS91
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS110
Auto-generated method stub222
org.kuali.student.core.organization.assembly.OrgProposalAssemblerLine
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS148
Neerav Agrawal - THIS METHOD NEEDS JAVADOCS264
org.kuali.student.core.organization.dao.impl.OrganizationDaoImplLine
Check query, not sure if matching against right orgKeyType value190
org.kuali.student.core.organization.service.impl.OrganizationAssemblerLine
Use the person Service here Person person = personService.findPerson(orgPersonRelationInfo.getPersonId()); if (person == null) { throw new InvalidParameterException( "Person does not exist for id: " + orgPersonRelationInfo.getPersonId()); } orgPersonRelation.setPersonId(person.getId());346
org.kuali.student.core.organization.service.impl.OrganizationServiceImplLine
Flush out exceptions388
org.kuali.student.core.organization.ui.client.mvc.controller.OrgApplicationManagerLine
Need to revisit for Org possibly90
org.kuali.student.core.organization.ui.client.mvc.view.CommonConfigurerLine
- when DOL is pushed farther down into LOBuilder, revert these 5 methods to returning void again.191
org.kuali.student.core.personsearch.service.impl.PersonSearchLine
map the old call parameters into the criteria parametsrs identityService.lookupEntityDefault(criteria, unbounded);43
org.kuali.student.core.personsearch.service.impl.QuickViewByGivenNameLine
what is this search for?113
finish sorting142
Recognize alternate sort columns154
fix this195
org.kuali.student.core.proposal.service.impl.ProposalAssemblerLine
Rework when JPA gets cascading deletes (2.0)150
org.kuali.student.core.rice.authorization.CollaboratorHelperLine
combine actionRequestEnum and ActionRequestType. Too similar. Only thing we need the enum for is human readable exceptions45
org.kuali.student.core.statement.service.impl.StatementAssemblerLine
goes through the list of statements in statementTreeViewInfo and extract the statement ids533
Fix with LuService RC1.4 changes LuStatementTypeInfo stmtType = this.luService.getLuStatementType(statementInfo.getStatementTypeId()); stmt.setLuStatementType(stmtType);585
Fix with LuService RC1.4 changes ReqComponentType type =607
Fix with LuService RC1.4 changes stmt.setLuStatementType(this.luService.getLuStatementType(luNlStmt.getStatementTypeId()));618
org.kuali.student.core.statement.service.impl.TestStatementServiceImplLine
This should test valid ReqCompFieldInfo types and values, too1450
org.kuali.student.core.statement.ui.client.widgets.rules.ReqCompEditWidgetLine
use app context for text77
not sure if this will work all the time due to parallel nature of this code but running out of time220
save history458
we should mix the custom widgets with regular widgets461
org.kuali.student.core.statement.ui.client.widgets.rules.RuleManageWidgetLine
use application context for all labels27
org.kuali.student.core.statement.ui.client.widgets.rules.RulePreviewWidgetLine
app context for labels136
org.kuali.student.core.statement.ui.client.widgets.rules.RuleTableLine
do we need simple panel?34
org.kuali.student.core.statement.ui.client.widgets.rules.RuleTableManipulationWidgetLine
remove req. compon.t299
org.kuali.student.core.statement.ui.client.widgets.rules.RulesUtilLine
clone file descriptor fields178
move to ks-lum and use constants in ReqComponentFieldTypes.java223
org.kuali.student.core.statement.ui.client.widgets.rules.StatementVOLine
do we really need this and do we need to duplicate this in sub rules?35
remove after refactoring rule table related classes, removing StatementVO40
org.kuali.student.core.statement.ui.client.widgets.rules.TokenLine
use AndOrButton class int instead?20
org.kuali.student.core.statement.util.PropositionBuilderLine
--No comment--247
--No comment--365
--No comment--384
--No comment--420
--No comment--427
org.kuali.student.core.test.BaseCaseLine
RICE-2.0 UPGRADE had to jump through hoops with M8 because getConfig was made private.73
Uncomment the following and use that instead of iterating ClassLoader webappClassLoader = jettyServer.getContext().getClassLoader(); Config webappConfig = ConfigContext.getConfig(webappClassLoader);74
org.kuali.student.core.workflow.ui.client.views.CollaboratorSectionViewLine
use real keys here person = new FieldDescriptor("collaboratorInfo", generateMessageInfo("Name"), personIdMeta);266
Is there a way to get first, last name from picker w/o parsing display value369
org.kuali.student.core.workflow.ui.client.widgets.WorkflowUtilitiesLine
This should come from the ReferenceModel like it does in CommentTool69
currently causing a lot of duplicate calls and has to be used carefully. Commented out for now.967
org.kuali.student.enrollment.acal.AcalReferenceDataParserLine
Some records don't have selection period end. Should this be calculated?305
Some records don't have selection period end398
Some records don't have selection period end482
org.kuali.student.enrollment.acal.constants.AcademicCalendarServiceConstantsLine
replace "acal" in namespace with "academiccalendar"35
Map to Grading Start Date periods public static final String GRADING_PERIOD_START_TYPE_KEY = ????64
org.kuali.student.enrollment.batchjobresults.infc.BatchJobResultItemLine
WORRY ABOUT SITUATIONS THAT ARE NOT ONE FOR ONE47
org.kuali.student.enrollment.class1.hold.service.impl.HoldServiceImplLine
sambit - THIS METHOD NEEDS JAVADOCS77
sambit - THIS METHOD NEEDS JAVADOCS209
sambit - THIS METHOD NEEDS JAVADOCS283
sambit - THIS METHOD NEEDS JAVADOCS290
sambit - THIS METHOD NEEDS JAVADOCS297
sambit - THIS METHOD NEEDS JAVADOCS304
sambit - THIS METHOD NEEDS JAVADOCS312
sambit - THIS METHOD NEEDS JAVADOCS320
sambit - THIS METHOD NEEDS JAVADOCS328
org.kuali.student.enrollment.class1.lpr.model.LuiPersonRelationEntityLine
fix this it was trying to use the entity from LRC directly here! instead need to create a new JPA entity to hold the lpr to rvg mapping List<String> rvGroupIds = new ArrayList(); if (null != getResultValuesGroups()) { for (ResultValuesGroupEntity rvGroup : getResultValuesGroups()) { rvGroupIds.add(rvGroup.getId()); } } lprInfo.setResultValuesGroupKeys(rvGroupIds);170
org.kuali.student.enrollment.class1.lpr.service.decorators.LuiPersonRelationServiceAuthorizationDecoratorLine
Auto-generated method stub50
org.kuali.student.enrollment.class1.lpr.service.impl.LuiPersonRelationServiceImplLine
Kamal - THIS METHOD NEEDS JAVADOCS182
Kamal - THIS METHOD NEEDS JAVADOCS236
Kamal - THIS METHOD NEEDS JAVADOCS242
Kamal - THIS METHOD NEEDS JAVADOCS248
Kamal - THIS METHOD NEEDS JAVADOCS273
sambitpatnaik - THIS METHOD NEEDS JAVADOCS365
sambit - THIS METHOD NEEDS JAVADOCS582
sambit - THIS METHOD NEEDS JAVADOCS588
sambit - THIS METHOD NEEDS JAVADOCS682
sambit - THIS METHOD NEEDS JAVADOCS688
this needs to be implemented for drop to work, read below Be careful with the implementation here, because we DO NOT want to delete all lprs that are matched by lui, person, and state, but instead only the ones that are related to the registration group we are dropping. It is VERY possible that a student could have the same course offering on their schedule twice with different reg groups, therefore deleting every LPR that matches that course offering id would be WRONG. In addition, it is possible that 2 reg groups that point to the same activity offering could be on the same schedule (this is more unlikely however and may be prevented by the system), and deleting both of those LPRs would be incorrect. So what we actually want to do is delete only lprs that have a direct relation to the reg group being dropped. However, there is no easy way currently to link these things together, one possible route is to get the original transactions and use their group id somehow, but this route may be flawed if the there is more than one succeeded transaction for the same reg group (VERY possible). There is no way currently (that I know of) to link the lprs for courseOffering, reg group, activities, and roster in a way that would be simple to determine by retrieving them from the db. This may be a possible hole in the service/db design.706
- change state to LuiPersonRelationServiceConstants.DROPPED_STATE_KEY, rather than deleting731
- change state to LuiPersonRelationServiceConstants.DROPPED_STATE_KEY, rather than deleting753
sambit - THIS METHOD NEEDS JAVADOCS784
sambit - THIS METHOD NEEDS JAVADOCS790
Rewrite this so it searches on requesting person NOT person in item and on ATP that is now in the transaction798
sambit - THIS METHOD NEEDS JAVADOCS841
inject this impl with a lui service impl to get the atp to check LuiEntity lui = luiDao.find(entity.getLuiId()); if (StringUtils.equals(lui.getAtpId(), atpId)) {972
sambit - THIS METHOD NEEDS JAVADOCS999
org.kuali.student.enrollment.class1.lpr.service.impl.mock.CriteriaMatcherInMemoryLine
Deal with lists if (ad.getMaximumNumberOfElements() == null) { return false; } if (ad.getMaximumNumberOfElements() <= 1) { return false; }91
make sure the key is the same as the name170
org.kuali.student.enrollment.class1.lpr.service.impl.mock.LuiPersonRelationServiceMockImplLine
Add this method to the service interface247
Auto-generated method stub394
Auto-generated method stub400
Auto-generated method stub426
Auto-generated method stub436
sambit - THIS METHOD NEEDS JAVADOCS444
sambitpatnaik - THIS METHOD NEEDS JAVADOCS458
sambitpatnaik - THIS METHOD NEEDS JAVADOCS471
sambitpatnaik - THIS METHOD NEEDS JAVADOCS485
sambit - THIS METHOD NEEDS JAVADOCS494
sambit - THIS METHOD NEEDS JAVADOCS503
sambit - THIS METHOD NEEDS JAVADOCS510
sambit - THIS METHOD NEEDS JAVADOCS518
- THIS METHOD NEEDS JAVADOCS526
sambit - THIS METHOD NEEDS JAVADOCS534
sambit - THIS METHOD NEEDS JAVADOCS541
sambit - THIS METHOD NEEDS JAVADOCS548
sambit - THIS METHOD NEEDS JAVADOCS556
sambit - THIS METHOD NEEDS JAVADOCS563
sambit - THIS METHOD NEEDS JAVADOCS571
sambit - THIS METHOD NEEDS JAVADOCS579
sambit - THIS METHOD NEEDS JAVADOCS587
sambit - THIS METHOD NEEDS JAVADOCS596
sambit - THIS METHOD NEEDS JAVADOCS604
sambit - THIS METHOD NEEDS JAVADOCS612
sambit - THIS METHOD NEEDS JAVADOCS627
sambit - THIS METHOD NEEDS JAVADOCS635
sambit - THIS METHOD NEEDS JAVADOCS643
sambit - THIS METHOD NEEDS JAVADOCS651
sambit - THIS METHOD NEEDS JAVADOCS659
sambit - THIS METHOD NEEDS JAVADOCS667
sambit - THIS METHOD NEEDS JAVADOCS675
sambit - THIS METHOD NEEDS JAVADOCS683
sambit - THIS METHOD NEEDS JAVADOCS691
sambit - THIS METHOD NEEDS JAVADOCS699
sambit - THIS METHOD NEEDS JAVADOCS707
sambit - THIS METHOD NEEDS JAVADOCS715
sambit - THIS METHOD NEEDS JAVADOCS724
sambit - THIS METHOD NEEDS JAVADOCS731
org.kuali.student.enrollment.class1.lrc.service.impl.LRCServiceImplLine
implement method73
implement method81
implement method120
implement method127
implement method136
implement method167
implement method175
implement method184
implement method191
implement method199
implement method217
org.kuali.student.enrollment.class1.lrr.service.impl.LearningResultRecordServiceImplLine
implement method44
implement method79
implement method169
implement method176
implement method184
implement method192
implement method201
implement method211
implement method219
sambit - THIS METHOD NEEDS JAVADOCS250
org.kuali.student.enrollment.class1.lrr.termresolver.CompletedCoursesResolverLine
analyze actual cost94
org.kuali.student.enrollment.class1.lu.service.impl.CluServiceImplLine
is the is the best method of doing this? what if the user passes in a new made up id, does that mean we have orphaned richtexts?1199
maybe this is unnecessary, contract specifies not null1586
maybe this is unnecessary, contract specifies not null1650
take this check out? R1 had this throwing an aleady exists exception but it is possible though unlikely for there to be two different relations between the same clu and Lo So we took out the AlreadyExistException in R2 BUT something might be depending on this So I kept it throwing an exception but changed it to throw an OperationFailed instead2145
Copy r2 request to an R1 request2368
copy R1 result to an R2 result2371
check if this should be set from outside2891
org.kuali.student.enrollment.class1.lu.termresolver.CourseSetResolverLine
analyze for a relevant cost44
org.kuali.student.enrollment.class1.lui.model.LuiEntityLine
map the attributes (merge and delete orphans, don't do delete all and add all)217
org.kuali.student.enrollment.class1.lui.model.LuiFeeEntityLine
obj.setFeeAmounts(feeAmounts)130
org.kuali.student.enrollment.class1.lui.model.LuiIdentifierEntityLine
This will cause all sorts of leftovers and duplicate data65
org.kuali.student.enrollment.class1.lui.service.impl.LuServiceAssemblerLine
dto.setCluCriteria()302
org.kuali.student.enrollment.class1.lui.service.impl.LuiServiceImplLine
--No comment--462
--No comment--473
org.kuali.student.enrollment.class2.academicrecord.service.assembler.StudentCourseRecordAssemblerLine
The code or number of the primary activity. how to determine which activity is primary?58
org.kuali.student.enrollment.class2.acal.controller.AcademicCalendarControllerLine
FIXME: Have to handle the error.. but for now, as it's causing issue, just skipping calculation when there are errors335
FIXME: Have to handle the error.. but for now, as it's causing issue, just skipping calculation when there are errors383
hard-coded for now, going to call OrgService634
delete completely from db, when "deleted" state is available, update the event with state ="deleted"686
org.kuali.student.enrollment.class2.acal.controller.CalendarSearchControllerLine
...54
- get real ContextInfo263
org.kuali.student.enrollment.class2.acal.controller.HolidayCalendarControllerLine
change to putError, when error reload fixed GlobalVariables.getMessageMap().putInfo(KRADConstants.GLOBAL_ERRORS, RiceKeyConstants.ERROR_CUSTOM, "ERROR: The adding holiday start date should not be later than the end date."); return false; }else if (timeDiff == 0 ) { holidayInfo.setIsDateRange(false); }else { holidayInfo.setIsDateRange(true); }111
hard-coded for now, going to call OrgService453
org.kuali.student.enrollment.class2.acal.dto.TimeSetWrapperLine
...26
org.kuali.student.enrollment.class2.acal.form.AcademicCalendarFormLine
...33
org.kuali.student.enrollment.class2.acal.form.CalendarSearchFormLine
...30
org.kuali.student.enrollment.class2.acal.keyvalue.AcademicTermStateKeyValuesLine
Build real context.56
org.kuali.student.enrollment.class2.acal.keyvalue.AcademicTermTypeKeyValuesLine
Build real context.71
org.kuali.student.enrollment.class2.acal.keyvalue.AcalEventTypeKeyValuesLine
Build real context.85
org.kuali.student.enrollment.class2.acal.keyvalue.AtpStateKeyValuesLine
...43
Build real context.96
Build real context.106
Build real context.117
org.kuali.student.enrollment.class2.acal.keyvalue.HolidayTypeKeyValuesLine
...39
Build real context.84
org.kuali.student.enrollment.class2.acal.keyvalue.TermKeyValuesLine
remove this when we figure out why KRAD defaultValue property is not working76
org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperLookupableImplLine
fix the search by Admin Org. Switch from credential program to admin org cuased issues46
org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperMaintainableImplLine
Need to handle new added Terms plus keyDates157
redo this string creation. the switch from credential program type to adminOrgId caused some issues306
org.kuali.student.enrollment.class2.acal.service.assembler.HolidayCalendarAssemblerLine
fix this essentially flawed mechanism -- that happens because of the assembler structure it really should take in as a paraemter the existing ATP, if there is one and find/match the campus keys there and update the set of attributes not replacing them doing it this way we lose the original id of attribute on update the making it hard (wrong?) to store it later54
org.kuali.student.enrollment.class2.acal.service.decorators.AcademicCalendarServiceCalculationDecoratorLine
Disabling usage of mapping until service supports the reuse of dates212
Need a way to only create a KeyDate in order to associate it with multiple Terms224
calculate keyDate effective dates227
the milestone is being populated with the first possible occurance - it is possible the ATP could span more than a years time295
org.kuali.student.enrollment.class2.acal.service.impl.AcademicCalendarServiceImplLine
Li Pan - THIS METHOD NEEDS JAVADOCS108
Li Pan - THIS METHOD NEEDS JAVADOCS114
Li Pan - THIS METHOD NEEDS JAVADOCS121
Li Pan - THIS METHOD NEEDS JAVADOCS174
move this to a validation layer217
Li Pan - THIS METHOD NEEDS JAVADOCS589
move this to a validation layer672
move this to a validation layer677
Li Pan - THIS METHOD NEEDS JAVADOCS836
change this when the new contract gets merged in because it does not have the refobject uri as a parameter846
sambit - THIS METHOD NEEDS JAVADOCS1147
sambit - THIS METHOD NEEDS JAVADOCS1259
sambit - THIS METHOD NEEDS JAVADOCS1266
sambit - THIS METHOD NEEDS JAVADOCS1286
sambit - THIS METHOD NEEDS JAVADOCS1306
sambit - THIS METHOD NEEDS JAVADOCS return null;1313
sambit - THIS METHOD NEEDS JAVADOCS1349
sambit - THIS METHOD NEEDS JAVADOCS1373
validate type key is a valid term type1379
sambit - THIS METHOD NEEDS JAVADOCS1385
sambit - THIS METHOD NEEDS JAVADOCS1392
sambit - THIS METHOD NEEDS JAVADOCS1398
sambit - THIS METHOD NEEDS JAVADOCS1404
sambit - THIS METHOD NEEDS JAVADOCS1410
sambit - THIS METHOD NEEDS JAVADOCS1417
--No comment--1423
sambit - THIS METHOD NEEDS JAVADOCS1430
sambit - THIS METHOD NEEDS JAVADOCS1437
sambit - THIS METHOD NEEDS JAVADOCS1481
sambit - THIS METHOD NEEDS JAVADOCS1487
sambit - THIS METHOD NEEDS JAVADOCS1518
sambit - THIS METHOD NEEDS JAVADOCS1524
sambit - THIS METHOD NEEDS JAVADOCS1530
sambit - THIS METHOD NEEDS JAVADOCS1613
sambit - THIS METHOD NEEDS JAVADOCS1620
sambit - THIS METHOD NEEDS JAVADOCS1645
Sambit - THIS METHOD NEEDS JAVADOCS1708
sambit - THIS METHOD NEEDS JAVADOCS1743
sambit - THIS METHOD NEEDS JAVADOCS1844
sambit - THIS METHOD NEEDS JAVADOCS1851
sambit - THIS METHOD NEEDS JAVADOCS1858
sambit - THIS METHOD NEEDS JAVADOCS1903
org.kuali.student.enrollment.class2.acal.service.impl.AcademicCalendarViewHelperServiceImplLine
- if > 1 result, find calendar with latest end date?152
- if > 1 result, find calendar with latest end date?268
--No comment--290
--No comment--1121
hard-coded for now, going to call OrgService1168
org.kuali.student.enrollment.class2.acal.service.impl.HolidayCalendarViewHelperServiceInquirableImplLine
...34
- where does context come from?83
org.kuali.student.enrollment.class2.acal.service.impl.HolidayCalendarWrapperInquiryViewHelperServiceImplLine
hard-coded for now, going to call OrgService89
org.kuali.student.enrollment.class2.acal.service.impl.TestAcademicCalendarServiceImplLine
test exception aspect & get dictionary ready, this is expected158
- need actual ProgramTypeKey attribute in test database sql201
test exception aspect & get dictionary ready, this is expected279
--No comment--596
check terms were copied properly951
should the milestone be saved in the calculation method or is that a seperate call?987
org.kuali.student.enrollment.class2.acal.util.CalendarConstantsLine
...21
org.kuali.student.enrollment.class2.acal.util.CommonUtilsLine
...26
org.kuali.student.enrollment.class2.appointment.controller.RegistrationWindowsControllerLine
...46
pull out all windows for that period and add to the collection162
log window == null message280
log exception284
- get real ContextInfo411
org.kuali.student.enrollment.class2.appointment.dto.StudentGroupWrapperLine
...22
org.kuali.student.enrollment.class2.appointment.keyvalue.PeriodForAppWindowKeyDatesFinderLine
--No comment--59
- get real ContextInfo100
org.kuali.student.enrollment.class2.appointment.keyvalue.PeriodKeyDatesFinderLine
-- Log exception61
- get real ContextInfo98
org.kuali.student.enrollment.class2.appointment.keyvalue.RegWindowTypeKeyValuesLine
Build real context.30
remove check after data is fixed36
org.kuali.student.enrollment.class2.appointment.keyvalue.SlotRuleForAppWindowKeyValuesFinderLine
...36
Build real context.60
org.kuali.student.enrollment.class2.appointment.service.AppointmentViewHelperServiceLine
...26
org.kuali.student.enrollment.class2.appointment.service.impl.AppointmentViewHelperServiceImplLine
...54
Default to some value if nothing is entered(Service team needs to make up some real types or make not nullable)246
(should be moved into common util class)348
org.kuali.student.enrollment.class2.appointment.service.impl.StudentGroupWrapperLookupableImplLine
...39
org.kuali.student.enrollment.class2.appointment.util.AppointmentConstantsLine
...21
org.kuali.student.enrollment.class2.appointment.util.AppointmentSlotRuleTypeConversionLine
...28
org.kuali.student.enrollment.class2.courseoffering.controller.CourseOfferingRolloverControllerLine
...43
Put in last rollover date (Kirk says this may be unnecessary in new wireframes 5/18/2012)88
org.kuali.student.enrollment.class2.courseoffering.dto.FormatOfferingInfoFormObjectLine
...24
org.kuali.student.enrollment.class2.courseoffering.form.CourseOfferingRolloverManagementFormLine
...23
org.kuali.student.enrollment.class2.courseoffering.service.FormatOfferingInfoMaintainableLine
...22
org.kuali.student.enrollment.class2.courseoffering.service.decorators.R1CourseServiceHelperLine
Consider adding a shortcut by getting the current version of the course and comparing that first instead of all versions of the course103
if no version exists for the target term should we return null instead?109
consider sorting this in reverse order so the latest versions are checked first114
Remove hack once data is valid (converts kuali.atp.term.xxx to 2008Fall, which is what is in Acal)124
check the status of the course to make sure it is active, superseded or retired but it cannot be draft or otherwise in-active shortcut if the terms match139
find out if the course's Effective and expiration dates can be used so I don't have to fetch all the terms to compare start/end dates147
Fix hack once term data is good151
Hack167
org.kuali.student.enrollment.class2.courseoffering.service.impl.ActivityOfferingInquirableImplLine
...30
org.kuali.student.enrollment.class2.courseoffering.service.impl.ActivityOfferingLookupableImplLine
...35
org.kuali.student.enrollment.class2.courseoffering.service.impl.AdvanceActivityOfferingLookupableImplLine
need to log --> find more than one term for specified termCode51
need to log --> find more than one CO for specified courseOfferingCode72
org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingInfoMaintainableImplLine
- all exception handling in this method needs to 'manually' roll back what has been changed in the database before the exception was caught50
- this entire method needs more complete exception handling; then remove this76
remove this fake generation when we are getting real times from the form172
fix this to set the schedule id from the schedule service173
Change this formatOffering to actual one when implementing196
remove this fake generation below when we are getting real times from the form301
org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingServiceBusinessLogicImplLine
Not hard code "Active" but use a constant ... except these are R1 States116
set the schedule request to null as well183
continue traversing down the formats and activities updating from the canonical210
implement this complex logic This is protected because it is explected that implementing instituations will vary widely in this implementation245
org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingServiceImplLine
- remove when KSENROLL-247 is resolved58
speed this up by calling the bulk lui methods?197
use custom search286
This method does not override anything why is it here?309
This method does not override anything why is it here?317
This method does not override anything why is it here?324
This fixes a DB required field error--find more meaningful value.685
This fixes a DB required field error--find more meaningful value.854
check that the lui being updated is an activity not another kind of lui copy to lui907
check that the lui being deleted is an activity not another kind of lui932
implement LuiService.getLuiIdsByRelatedLuiAndRelationType and call it instead995
org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingServiceMockImplLine
check included terms168
check the rest of the readonly fields that are specified on the create to make sure they match the info object254
move this logic to the calculation decorator do the persistence layer doesn't have this logic mixed in with it copy from cannonical259
check the rest of the readonly fields that are specified on the create to make sure they match the info object364
check the rest of the readonly fields that are specified on the create to make sure they match the info object504
org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingViewHelperServiceImplLine
...50
Find sensible way to rewrap exception that acal service may throw Find the term (alas, I think it does approximate search)62
How does one get rid of hard-coding "atpCode"?65
Ideally, use socService.getCourseOfferingsBySoc()223
Currently, deleteCourseOfferingsByTerm is not implemented in SOC service228
Force rollover to run synchronously for now288
org.kuali.student.enrollment.class2.courseoffering.service.impl.EnrollmentFeeInquirableImplLine
...33
org.kuali.student.enrollment.class2.courseoffering.service.impl.EnrollmentFeeLookupableImplLine
...46
org.kuali.student.enrollment.class2.courseoffering.service.impl.FormatOfferingInfoInquirableImplLine
...29
org.kuali.student.enrollment.class2.courseoffering.service.impl.FormatOfferingInfoLookupableImplLine
...32
org.kuali.student.enrollment.class2.courseoffering.service.impl.FormatOfferingInfoMaintainableImplLine
...41
org.kuali.student.enrollment.class2.courseoffering.service.impl.LuiServiceMockImplLine
--No comment--229
org.kuali.student.enrollment.class2.courseoffering.service.impl.SocRolloverResultItemInfoInquirableImplLine
...36
org.kuali.student.enrollment.class2.courseoffering.service.impl.SocRolloverResultItemInfoLookupableImplLine
...35
org.kuali.student.enrollment.class2.courseoffering.service.impl.TestCourseOfferingServiceImplLine
delete this file this once all the tests have been moved over to the new mock framework46
org.kuali.student.enrollment.class2.courseoffering.service.impl.TestCourseOfferingServiceImplWithMocksLine
test for these things assertEquals(course.getUnitsContentOwnerOrgIds(), info.getUnitsContentOwnerOrgIds()); assertEquals(course.getUnitsDeploymentOrgIds(), info.getUnitsDeploymentOrgIds()); assertEquals(course.getGradingOptions(), info.getGradingOptionIds()); assertEquals(course.getCreditOptionIds(), info.getCreditOptionIds()); assertEquals(new R1ToR2CopyHelper().copyCourseExpenditure(course.getExpenditure()), info.getExpenditure()); assertEquals(new R1ToR2CopyHelper().copyCourseFeeList(course.getFeeIds()), info.getFeeIds()); assertEquals(new R1ToR2CopyHelper().copyInstructors(course.getInstructors()), info.getInstructors());132
add this back in and test for it instructors.add(instructor);163
turn these tests back on once we get the corresponding JPA entities working assertEquals(orig.getActivityOfferingTypeKeys().size(), info.getActivityOfferingTypeKeys().size()); assertEquals(orig.getActivityOfferingTypeKeys().get(0), info.getActivityOfferingTypeKeys().get(0));251
org.kuali.student.enrollment.class2.courseoffering.service.transformer.CourseOfferingTransformerLine
the following mapping undecided on wiki gradeRosterLevelTypeKey fundingSource isFinancialAidEligible registrationOrderTypeKey215
org.kuali.student.enrollment.class2.courseoffering.service.transformer.RegistrationGroupTransformerLine
co.setIsHonorsOffering(isHonorsOffering) -- lui.getLuiCodes() ?23
co.getIsHonorsOffering() --store in a generic lui luCodes type of field?52
org.kuali.student.enrollment.class2.courseoffering.util.ActivityOfferingConstantsLine
...19
org.kuali.student.enrollment.class2.courseoffering.util.CourseOfferingResourceLoaderLine
...32
org.kuali.student.enrollment.class2.courseofferingset.model.SocRolloverResultEntityLine
store the option keys61
load the option keys100
org.kuali.student.enrollment.class2.courseofferingset.service.impl.CourseOfferingReverseRolloverRunnerLine
implement these options106
push this logic into the course offering service233
add a cascading delete for course offferings248
org.kuali.student.enrollment.class2.courseofferingset.service.impl.CourseOfferingRolloverRunnerLine
implement these options93
org.kuali.student.enrollment.class2.courseofferingset.service.impl.CourseOfferingSetServiceBusinessLogicImplLine
try to find the soc in the target term and use it instead of just creating a new one107
add bulk ops to CourseOfferingService so this can call them to delete all for a term or delete all for a subject area intead of doing it one by one234
handle sub-terms before returning false259
handle sub-terms before returning false269
handle sub-terms before returning false279
add the published course offering state to the constants if (info.getStateKey().equals(CourseOfferingServiceConstants.PUBLISHED_STATE_KEY) {294
add the published course offering state to the constants if (info.getStateKey().equals(CourseOfferingServiceConstants.PUBLISHED_STATE_KEY) {309
add the published course offering state to the constants if (!ao.getStateKey().equals(CourseOfferingServiceConstants.PUBLISHED_STATE_KEY) {325
add the published course offering state to the constants if (!ao.getStateKey().equals(CourseOfferingServiceConstants.SCHEDULED_STATE_KEY) {342
org.kuali.student.enrollment.class2.courseofferingset.service.impl.CourseOfferingSetServiceImplLine
implement this logic with direct counts for efficiency once the logic for the counts settles down. My GUT says that they may want more counts than just the 2 we are getting now... I.e. count of warnings?347
implement this as a JPQL search379
org.kuali.student.enrollment.class2.courseofferingset.service.impl.CourseOfferingSetServiceMockImplLine
check the rest of the readonly fields that are specified on the create to make sure they match the info object140
check the rest of the readonly fields that are specified on the create to make sure they match the info object511
org.kuali.student.enrollment.class2.courseregistration.service.assembler.CourseWaitlistEntryAssemblerLine
sambit - THIS METHOD NEEDS JAVADOCS13
sambit - THIS METHOD NEEDS JAVADOCS19
org.kuali.student.enrollment.class2.courseregistration.service.assembler.RegRequestAssemblerLine
- sambit . Post Core Slice, move this logic out of assembler and handle exception properly61
sambit - THIS METHOD NEEDS JAVADOCS101
sambit - THIS METHOD NEEDS JAVADOCS106
org.kuali.student.enrollment.class2.courseregistration.service.assembler.RegResponseAssemblerLine
use53
org.kuali.student.enrollment.class2.courseregistration.service.impl.CourseRegistrationServiceImplLine
copy the transaction item and change the type of the new one to be ADD TO WAITLIST and then on that item mark the original with a state of failed194
sambit - THIS METHOD NEEDS JAVADOCS288
fill in nlUsageType and language parameters once the implementation actually uses them306
sambit - THIS METHOD NEEDS JAVADOCS364
sambit - THIS METHOD NEEDS JAVADOCS371
sambit - THIS METHOD NEEDS JAVADOCS378
sambit - THIS METHOD NEEDS JAVADOCS385
sambit - THIS METHOD NEEDS JAVADOCS392
sambit - THIS METHOD NEEDS JAVADOCS399
- rules and waitlist implementation needed406
sambit - THIS METHOD NEEDS JAVADOCS413
sambit - THIS METHOD NEEDS JAVADOCS440
sambit - THIS METHOD NEEDS JAVADOCS453
since we're creating at a minimum 3 lprs per course reg we shouldn't loop through all of them. need a way to get directly to the grade roster579
sambit - THIS METHOD NEEDS JAVADOCS605
sambit - THIS METHOD NEEDS JAVADOCS612
sambit - THIS METHOD NEEDS JAVADOCS636
sambit - THIS METHOD NEEDS JAVADOCS643
sambit - THIS METHOD NEEDS JAVADOCS650
sambit - THIS METHOD NEEDS JAVADOCS657
sambit - THIS METHOD NEEDS JAVADOCS664
sambit - THIS METHOD NEEDS JAVADOCS671
sambit - THIS METHOD NEEDS JAVADOCS678
sambit - THIS METHOD NEEDS JAVADOCS685
sambit - THIS METHOD NEEDS JAVADOCS692
sambit - THIS METHOD NEEDS JAVADOCS699
sambit - THIS METHOD NEEDS JAVADOCS706
sambit - THIS METHOD NEEDS JAVADOCS713
- post core slice need to ensure that the list has one751
sambit - THIS METHOD NEEDS JAVADOCS875
sambit - THIS METHOD NEEDS JAVADOCS882
sambit - THIS METHOD NEEDS JAVADOCS889
sambit - THIS METHOD NEEDS JAVADOCS896
sambit - THIS METHOD NEEDS JAVADOCS903
sambit - THIS METHOD NEEDS JAVADOCS910
sambit - THIS METHOD NEEDS JAVADOCS917
sambit - THIS METHOD NEEDS JAVADOCS924
sambit - THIS METHOD NEEDS JAVADOCS944
sambit - THIS METHOD NEEDS JAVADOCS951
sambit - THIS METHOD NEEDS JAVADOCS958
sambit - THIS METHOD NEEDS JAVADOCS965
sambit - THIS METHOD NEEDS JAVADOCS972
org.kuali.student.enrollment.class2.courseregistration.termresolver.EnrolledCoursesResolverLine
analyze actual cost53
org.kuali.student.enrollment.class2.grading.assembler.GradeValuesGroupAssemblerLine
implement method41
org.kuali.student.enrollment.class2.grading.controller.GradingControllerLine
Needs to be a client side method instead of handling at server side112
org.kuali.student.enrollment.class2.grading.service.assembler.GradeRosterAssemblerLine
implement method36
org.kuali.student.enrollment.class2.grading.service.assembler.GradeRosterEntryAssemblerLine
implement method37
org.kuali.student.enrollment.class2.grading.service.impl.GradingServiceImplLine
implement method.71
implement method.93
implement method.117
implement method.171
implement method.194
implement method.222
implement method.248
implement method.270
implement method.347
implement method.369
throw exception if null?458
implement method.486
implement method.510
implement method.639
sambit - THIS METHOD NEEDS JAVADOCS666
need type value for calculated grade792
Get grading options from courseRegistration instead of courseOffering.835
need type value for calculated grade862
org.kuali.student.enrollment.class2.grading.service.impl.GradingViewHelperServiceImplLine
- is this correct?211
- is this correct?213
org.kuali.student.enrollment.class2.registration.controller.RegistrationControllerLine
statement service wasnt working correctly when tested, commented out for now246
right now getOfferingsByIds throws a not supported exception return getCourseOfferingService().getActivityOfferingsByIds(regGroup.getActivityOfferingIds(), context);302
fix this to get the meeting schedule from the schedule Id and the schedule service334
check this logic Assuming registration successful if no errors returned448
org.kuali.student.enrollment.class2.registration.dto.ActivityOfferingWrapperLine
this is a hack to parse for human readable - it should be going to some service to get a human readable name for this activity36
org.kuali.student.enrollment.class2.registration.form.RegistrationFormLine
- remove this cast below if CourseRegistrationInfo.getCourseOffering() method is fixed117
fix this to get the meeting schedule from the schedule Id and the schedule service123
- convert type key to actual activity type130
org.kuali.student.enrollment.class2.registration.service.RegistrationViewHelperServiceImplLine
RICE=M9 UPGRADE Replace call to "getSummaryMessageField" to use one of the new ContainerBase message field widgets, I suspect this should use getErrorsField90
org.kuali.student.enrollment.common.util.ContextBuilderLine
...24
org.kuali.student.enrollment.courseoffering.dto.RegistrationGroupActiviesOptionsInfoLine
...9
org.kuali.student.enrollment.courseoffering.dto.RegistrationGroupTemplateInfoLine
...10
org.kuali.student.enrollment.courseoffering.infc.CourseOfferingLine
Skip this section for core slice development241
org.kuali.student.enrollment.courseoffering.infc.RegistrationGroupActiviesOptionsLine
...4
org.kuali.student.enrollment.courseoffering.service.CourseOfferingServiceLine
The exact types that can be specified here have not yet been defined331
org.kuali.student.enrollment.courseoffering.service.R1ToR2CopyHelperLine
worry about using the toString method for the id32
deep copy the dates56
Deep copy the dates195
deail with ranges perhaps by interrogating the result values to see if it is a range?202
org.kuali.student.enrollment.courseregistration.service.CourseRegistrationServiceLine
This is WIP now, DO NOT IMPLEMENT470
org.kuali.student.enrollment.grading.service.GradingServiceLine
- do we need to change the output to an object instead of boolean?417
org.kuali.student.enrollment.lpr.service.LuiPersonRelationServiceLine
check the need of such a method in class 2, if none exist delete this. public List<String> getAllValidLuisForPerson(@WebParam(name = "personId") String personId, @WebParam(name = "luiPersonRelationTypeKey") String luiPersonRelationTypeKey, @WebParam(name = "relationState") String relationState, @WebParam(name = "atpId") String atpId, @WebParam(name = "context") ContextInfo context) throws DoesNotExistException, DisabledIdentifierException, InvalidParameterException, MissingParameterException, OperationFailedException, PermissionDeniedException;452
Add requesting person Id and ATP id to these signature934
Think about recasting this to return Transaction Items instead, that is what we really want here and if we have to track back to the Transaction then put the transaction id on the item so that can be done.1026
Think about recasting this to return Transaction Items instead, that is what we really want here and if we have to track back to the Transaction then put the transaction id on the item so that can be done.1051
Think about recasting this to return Transaction Items instead, that is what we really want here and if we have to track back to the Transaction then put the transaction id on the item so that can be done.1090
Think about recasting this to return Transaction Items instead, that is what we really want here and if we have to track back to the Transaction then put the transaction id on the item so that can be done.1111
This method originally also additionally filtered on transaction state but other evidence had it by lpr type consider adding back in so I took it out. Perhaps it should be added back in.1130
org.kuali.student.enrollment.lrr.service.LearningResultRecordServiceLine
CHECK THESE VALUES48
org.kuali.student.enrollment.lui.service.LuiServiceLine
--No comment--421
??? Retrieves the list of related LUI Ids for the specified LUI Id and LU to LU relation type. (getLuiIdsByRelatedLuiAndRelationType from the other direction).439
??? Retrieves the list of related LUI information for the specified LUI Id and LU to LU relation type (getLuisByRelatedLuiAndRelationType from the other direction).457
org.kuali.student.enrollment.main.form.LaunchFormLine
...21
org.kuali.student.kim.identity.mock.MockConfigLine
sambit - THIS METHOD NEEDS JAVADOCS250
sambit - THIS METHOD NEEDS JAVADOCS256
sambit - THIS METHOD NEEDS JAVADOCS262
sambit - THIS METHOD NEEDS JAVADOCS268
sambit - THIS METHOD NEEDS JAVADOCS274
sambit - THIS METHOD NEEDS JAVADOCS280
sambit - THIS METHOD NEEDS JAVADOCS286
sambit - THIS METHOD NEEDS JAVADOCS292
org.kuali.student.kim.permission.mock.PermissionServiceMockImplLine
implement this check74
implement this check79
implement this check84
Implement this137
Larry Symms wanted to take a look at this201
org.kuali.student.kim.permission.mock.RoleServiceMockImplLine
implement check187
RICE=M9 UPGRADE The function of this method has been internalized in rice m9 The function of this method has been internalized in rice m9266
RICE=M9 UPGRADE The function of this method has been internalized in rice m9 The function of this method has been internalized in rice m9286
org.kuali.student.krms.TestKRMSCreateAgendasPhase1Line
KSKRMS not sure where the Attributes fit in and how they link up int contextAttrSequenceIndex = 0; List<KrmsTypeAttribute.Builder> contextAttributeBuilders = new ArrayList<KrmsTypeAttribute.Builder>(); for (KrmsAttributeDefinition attrDef : ksLumAttributeDefinitions.values()) { contextAttributeBuilders.add(KrmsTypeAttribute.Builder.create(null, attrDef.getId(), contextAttrSequenceIndex)); contextAttrSequenceIndex += 1;754
org.kuali.student.krms.TestKRMSCreateTermSpecificationLine
Figure out how to set the Description206
KSKRMS not sure where the Attributes fit in and how they link up int contextAttrSequenceIndex = 0; List<KrmsTypeAttribute.Builder> contextAttributeBuilders = new ArrayList<KrmsTypeAttribute.Builder>(); for (KrmsAttributeDefinition attrDef : ksLumAttributeDefinitions.values()) { contextAttributeBuilders.add(KrmsTypeAttribute.Builder.create(null, attrDef.getId(), contextAttrSequenceIndex)); contextAttrSequenceIndex += 1;343
org.kuali.student.lum.common.client.lo.CategoryDataUtilLine
- doesn't work on the client; what to do?27
- LoCategoryInfoAssembler, w/ an assemble method so we can just do categoriesData.add(LoCategoryInfoAssembler.assemble(cat)) instead of all the above46
- this should't be necessary when DOL pushed down into LOPicker and its LOCategoryBuilder catInfo.setAttributes(catHelper.getAttributes());69
- LoCategoryInfoAssembler, w/ a disassemble method so we can just do categoriesData.add(LoCategoryInfoAssembler.disassemble(catData)) instead of all the above75
org.kuali.student.lum.common.client.lo.LOCategoryBuilderLine
show actual help window225
do we need null checks?368
- need to somehow ensure that categoryTypeMap is initialized before redraw()639
- need to somehow ensure that categoryTypeMap is initialized before redraw() String typeName = "ERROR: uninitialized categoryTypeMap"; if (null != categoryTypeMap) { typeName = categoryTypeMap.get(typeKey).getName(); } categoryTable.setWidget(row, col++, new KSLabel(name + CATEGORY_TYPE_SEPARATOR + typeName)); KSLabel deleteLabel = new KSLabel("[x]"); deleteLabel.addStyleName("KS-LOBuilder-Search-Link"); deleteLabel.addClickHandler(deleteHandler); categoryTable.setWidget(row, col++, deleteLabel); row++; col = 0;648
org.kuali.student.lum.common.client.lo.OutlineNodeLine
M4 - some way to subclass OutlineNode?27
org.kuali.student.lum.common.server.LoCategoryDataServiceLine
Check that only LO categories are coming through this way. LOs are persisted only in the context of a CLU?47
org.kuali.student.lum.course.service.assembler.CourseAssemblerLine
Use CluAssemblerUtils746
Auto-generated method stub749
This is pretty much a copy of the FormatAssembler's disassembleActivities code... maybe can be made generic931
This is pretty much a copy of the disassembleJoints code... maybe can be made generic1096
org.kuali.student.lum.course.service.impl.CourseDataGeneratorLine
make it return A, B, C...229
org.kuali.student.lum.course.service.impl.TestCourseServiceImplLine
- check its contents170
- check its contents175
- check effective/expiration dates184
- check feeInfo186
- check joints188
- check metaInfo189
- check variotions217
org.kuali.student.lum.kim.StudentIdentityServiceImplLine
RICE=M9 UPGRADE Check that the values for the portName and targetNamespace still make sense for rice-2.041
org.kuali.student.lum.kim.role.type.KSActionRequestDerivedRoleTypeServiceImplLine
RICE=M7 UPGRADE deal with WorkflowUtility being deprecated167
org.kuali.student.lum.lo.dao.impl.LoDaoImplLine
- will need more general logic here when we have relationships other than "includes" hopefully dictionary-driven List<Lo> parents = getIncludingLos(loId); for (Lo parent : parents) { parent.getRelatedLos().remove(child); update(parent); }101
- gotta be a constant somewhere, or perhaps pull from dictionary116
- gotta be a constant somewhere, or perhaps pull from dictionary123
- "&& [not a top-level LO for another CLU]" when LO's are reused throw new DependentObjectsExistException("LoLoRelation(" + loLoRelationId + ") cannot be deleted without orphaning Lo(s)."); }191
- remove when logic has been completely pilfered as appropriate238
- null out hierarchy334
org.kuali.student.lum.lu.assembly.CluSetManagementAssemblerLine
Split out CluInfo assembly to its own class54
Auto-generated method stub520
org.kuali.student.lum.lu.service.impl.LuServiceAssemblerLine
dto.setCluCriteria()317
org.kuali.student.lum.lu.service.impl.LuServiceImplLine
is the is the best method of doing this? what if the user passes in a new made up id, does that mean we have orphaned richtexts?1238
maybe this is unnecessary, contract specifies not null1620
maybe this is unnecessary, contract specifies not null1666
Auto-generated method stub2190
Is it possible we need to search up the cluset hierarchies? If Cluset A contains clu 1 and cluset B contains cluset A, do we also return cluset B as a dependency?3264
check if this should be set from outside3659
org.kuali.student.lum.lu.ui.course.client.configuration.CourseConfigurerLine
people and permissions will use a different button than continue198
customize multiplicity and change "Percentage" label into LUConstants.AMOUNT1028
customize multiplicity and change "Percentage" label into LUConstants.AMOUNT1050
org.kuali.student.lum.lu.ui.course.client.configuration.CourseSummaryConfigurerLine
use messages here296
next 3 methods below should be moved into some kind of multiplicity helper class648
Auto-generated method stub805
org.kuali.student.lum.lu.ui.course.client.controllers.CourseProposalControllerLine
get from messages169
Is this correct... do we want to stop view change if we can't restore the data? Possibly traps the user if we don't it messes up saves, possibly warn the user that it failed and continue?818
org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsManageViewLine
cache it for each statement type?107
until we figure out how to detect changes, always return true226
how to check whether rule changed or not? !(ruleManageWidget.getLogicExpression().equals(originalLogicExpression) && getAllReqCompNLs().equals(originalReqCompNL));238
?280
org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsViewControllerLine
show dialog if user clicks on a menu from Manage Rules page80
org.kuali.student.lum.lu.ui.course.client.widgets.CourseWorkflowActionListLine
use messages84
Inactivate109
Retire116
create Retire dialog126
use message e.g. activateCurrentInstr, activateModificationInstr128
create Inactivate dialog132
message150
message153
use messages163
add Retire and Inactivate Dialogs189
org.kuali.student.lum.lu.ui.dependency.client.views.DependencyAnalysisViewLine
This should not use hard-coded result columns251
This code copied from program screens, need common reusable code363
This code copied from Program summary, need to create reusable version for this and program summary508
This code copied from Program summary, need to create reusable version for this and program summary520
org.kuali.student.lum.lu.ui.dependency.client.widgets.DependencyResultPanelLine
This may need to be replaced with document to surface handle print/export64
org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurerLine
add cluset and clurange here132
change this to custom layoutcontroller here to support multiple model ids?226
change this to custom layoutcontroller here to support multiple model ids?312
retrieve cluset by id and324
retrieve cluset by id and362
- when DOL is pushed farther down into LOBuilder, revert these 5 methods to returning void again.544
- when DOL is pushed farther down into LOBuilder, revert these 5 methods to returning void again.546
org.kuali.student.lum.lu.ui.tools.client.widgets.SearchBackedTableLine
use this as a token to get a message from message service instead142
org.kuali.student.lum.program.client.requirements.ProgramRequirementsDataModelLine
how can we reliably know that we need to reload rules (or not) String programId = (model == null ? null : (String)((DataModel)model).getRoot().get("id")); String modelProgramId = ((DataModel)modelIn).getRoot().get(ProgramConstants.ID); if ((modelProgramId == null) || (!modelProgramId.equals(programId))) {73
clonedProgReqInfo.setAttributes();493
clonedProgReqInfo.setLearningObjectives();494
clonedProgReqInfo.setMetaInfo();495
org.kuali.student.lum.program.client.requirements.ProgramRequirementsManageViewLine
cache it for each statement type?97
until we figure out how to detect changes, always return true226
how to check whether rule changed or not? !(ruleManageWidget.getLogicExpression().equals(originalLogicExpression) && getAllReqCompNLs().equals(originalReqCompNL));238
?280
org.kuali.student.lum.program.client.requirements.ProgramRequirementsSummaryViewLine
rework to use Configurer if possible488
org.kuali.student.lum.program.client.requirements.ProgramRequirementsViewControllerLine
show dialog if user clicks on a menu from Manage Rules page99
put back if we will NOT reset rules every time user comes to PREVIEW page above...141
org.kuali.student.lum.program.server.CoreProgramDataServiceLine
find a better way to get this search, param and resultcolumn names79
org.kuali.student.lum.program.server.MajorDisciplineDataServiceLine
Just Major Discipline for now - need to check for other types later37
org.kuali.student.lum.program.server.MajorDisciplineRpcServletLine
temporary fix - see KSLUM 142192
org.kuali.student.lum.program.server.transform.CoreCredentialProgramFilterLine
find a better way to get search, param and resultcolumn names81
org.kuali.student.lum.program.service.ProgramServiceLine
CHECK THESE VALUES56
org.kuali.student.lum.program.service.assembler.MajorDisciplineAssemblerLine
- is it an error if there's more than one core program?97
IDs for objects w/o ids135
Check for ProgramAssemblerConstants.CERTIFICATE_RESULTS too218
org.kuali.student.lum.program.service.assembler.ProgramAssemblerUtilsLine
maybe this should be in CluAssemblerUtils??109
maybe this should be in CluAssemblerUtils??126
- do we need to validate that?1055
org.kuali.student.lum.program.service.impl.ProgramDataGeneratorUtilsLine
maybe need it later21
org.kuali.student.lum.program.service.impl.ProgramServiceImplLine
Auto-generated method stub123
Auto-generated method stub448
Auto-generated method stub479
Auto-generated method stub509
Auto-generated method stub569
Auto-generated method stub576
Auto-generated method stub584
Auto-generated method stub593
Auto-generated method stub630
Auto-generated method stub639
Auto-generated method stub647
Auto-generated method stub736
Auto-generated method stub775
Auto-generated method stub822
Auto-generated method stub847
Auto-generated method stub879
Auto-generated method stub886
Auto-generated method stub894
Auto-generated method stub901
Auto-generated method stub909
Auto-generated method stub916
Auto-generated method stub925
Auto-generated method stub934
Auto-generated method stub941
- when CRUD for a second ProgramInfo is implemented, pull common code up from its process*() and this959
org.kuali.student.lum.program.service.impl.TestProgramServiceImplLine
catalog descr221
catalog pub targets222
effectiveDate Calendar effectiveDate = GregorianCalendar.getInstance(); effectiveDate.set(1984, 7, 1, 0, 0, 0); Date testDate = new Date(effectiveDate.getTimeInMillis()); assertTrue(major.getEffectiveDate().compareTo(testDate) == 0);318
catalog descr335
createTime Calendar createTime = GregorianCalendar.getInstance(); createTime.set(2009, 4, 7, 12, 5, 36); testDate = new Date(createTime.getTimeInMillis()); assertTrue(major.getEffectiveDate().compareTo(testDate) == 0);399
assertEquals("ANTH", createdMD.getCode());493
effectiveDate Calendar effectiveDate = GregorianCalendar.getInstance(); effectiveDate.set(1984, 7, 1, 0, 0, 0); Date testDate = new Date(effectiveDate.getTimeInMillis()); assertTrue(createdMD.getEffectiveDate().compareTo(testDate) == 0);524
assertEquals("00f5f8c5-fff1-4c8b-92fc-789b891e0849", createdMD.getOrgCoreProgram().getId());561
createTime Calendar createTime = GregorianCalendar.getInstance(); createTime.set(2009, 4, 7, 12, 5, 36); testDate = new Date(createTime.getTimeInMillis()); assertTrue(createdMD.getEffectiveDate().compareTo(testDate) == 0);618
checkReqComponentType(reqComponent.getRequiredComponentType(), reqComponent2.getRequiredComponentType());754
add version update1063
add version update1179
this should actually be passing; get working again after today's change of AdminOrgInfo's to those orgs ID's in Program-related DTOs assertEquals("testOrgId", target.getDivisionsContentOwner().get(0));1291
update versioning1415
org.kuali.student.lum.service.assembler.CluAssemblerUtilsLine
Check this for proper handling of multiple CluResultInfos? If this is not a create, lookup the results for this clu83
Auto-generated method stub173
org.kuali.student.lum.statement.config.context.AtpContextImplTestLine
Auto-generated method stub133
Auto-generated method stub143
Auto-generated method stub153
Auto-generated method stub162
Auto-generated method stub170
Auto-generated method stub184
Auto-generated method stub192
Auto-generated method stub199
Auto-generated method stub207
Auto-generated method stub213
Auto-generated method stub221
Auto-generated method stub229
Auto-generated method stub237
Auto-generated method stub245
Auto-generated method stub253
Auto-generated method stub260
Auto-generated method stub269
Auto-generated method stub277
Auto-generated method stub285
Auto-generated method stub293
Auto-generated method stub301
Auto-generated method stub308
Auto-generated method stub317
Auto-generated method stub325
Auto-generated method stub333
Auto-generated method stub342
Auto-generated method stub351
Auto-generated method stub360
Auto-generated method stub370
Auto-generated method stub381
Auto-generated method stub392
Auto-generated method stub401
Auto-generated method stub410
Auto-generated method stub419
Auto-generated method stub428
Auto-generated method stub435
Auto-generated method stub444
Auto-generated method stub451
Auto-generated method stub459
Auto-generated method stub466
Auto-generated method stub475
Auto-generated method stub484
Auto-generated method stub491
Kamal - THIS METHOD NEEDS JAVADOCS497
Kamal - THIS METHOD NEEDS JAVADOCS503
org.kuali.student.lum.statement.config.context.LrcContextImplTestLine
Auto-generated method stub207
Auto-generated method stub219
Auto-generated method stub228
Auto-generated method stub236
Auto-generated method stub245
Auto-generated method stub253
Auto-generated method stub260
Auto-generated method stub269
Auto-generated method stub277
Auto-generated method stub285
Auto-generated method stub293
Auto-generated method stub300
Auto-generated method stub308
Auto-generated method stub316
Auto-generated method stub324
Auto-generated method stub332
Auto-generated method stub339
Auto-generated method stub347
Auto-generated method stub355
Auto-generated method stub371
Auto-generated method stub388
Auto-generated method stub402
Auto-generated method stub410
Auto-generated method stub422
Auto-generated method stub431
Auto-generated method stub438
Auto-generated method stub447
Auto-generated method stub454
Auto-generated method stub462
Auto-generated method stub469
Auto-generated method stub478
Auto-generated method stub487
Auto-generated method stub494
Kamal - THIS METHOD NEEDS JAVADOCS500
Kamal - THIS METHOD NEEDS JAVADOCS506
org.kuali.student.lum.statement.config.context.LuContextImplTestLine
Auto-generated method stub292
Auto-generated method stub302
Auto-generated method stub313
Auto-generated method stub322
Auto-generated method stub332
Auto-generated method stub342
Auto-generated method stub354
Auto-generated method stub365
Auto-generated method stub375
Auto-generated method stub386
Auto-generated method stub396
Auto-generated method stub406
Auto-generated method stub418
Auto-generated method stub427
Auto-generated method stub436
Auto-generated method stub445
Auto-generated method stub454
Auto-generated method stub463
Auto-generated method stub472
Auto-generated method stub481
Auto-generated method stub490
Auto-generated method stub499
Auto-generated method stub508
Auto-generated method stub517
Auto-generated method stub526
Auto-generated method stub535
Auto-generated method stub544
Auto-generated method stub553
Auto-generated method stub561
Auto-generated method stub576
Auto-generated method stub584
Auto-generated method stub592
Auto-generated method stub601
Auto-generated method stub609
Auto-generated method stub617
Auto-generated method stub626
Auto-generated method stub635
Auto-generated method stub644
Auto-generated method stub651
Auto-generated method stub659
Auto-generated method stub667
Auto-generated method stub675
Auto-generated method stub683
Auto-generated method stub692
Auto-generated method stub700
Auto-generated method stub708
Auto-generated method stub716
Auto-generated method stub723
Auto-generated method stub732
Auto-generated method stub741
Auto-generated method stub758
Auto-generated method stub767
Auto-generated method stub775
Auto-generated method stub782
Auto-generated method stub790
Auto-generated method stub798
Auto-generated method stub807
Auto-generated method stub816
Auto-generated method stub825
Auto-generated method stub832
Auto-generated method stub841
Auto-generated method stub848
Auto-generated method stub856
Auto-generated method stub863
Auto-generated method stub871
Auto-generated method stub878
Auto-generated method stub887
Auto-generated method stub894
Auto-generated method stub902
Auto-generated method stub910
Auto-generated method stub916
Auto-generated method stub924
Auto-generated method stub932
Auto-generated method stub941
Auto-generated method stub949
Auto-generated method stub957
Auto-generated method stub965
Auto-generated method stub973
Auto-generated method stub982
Auto-generated method stub990
Auto-generated method stub999
Auto-generated method stub1008
Auto-generated method stub1017
Auto-generated method stub1026
Auto-generated method stub1034
Auto-generated method stub1042
Auto-generated method stub1049
Auto-generated method stub1058
Auto-generated method stub1067
Auto-generated method stub1076
Auto-generated method stub1085
Auto-generated method stub1095
Auto-generated method stub1105
Auto-generated method stub1116
Auto-generated method stub1127
Auto-generated method stub1138
Auto-generated method stub1149
Auto-generated method stub1160
Auto-generated method stub1169
Auto-generated method stub1179
Auto-generated method stub1190
Auto-generated method stub1199
Auto-generated method stub1208
Auto-generated method stub1217
Auto-generated method stub1226
Auto-generated method stub1235
Auto-generated method stub1244
Auto-generated method stub1253
Auto-generated method stub1262
Auto-generated method stub1271
Auto-generated method stub1277
Auto-generated method stub1283
Auto-generated method stub1292
Auto-generated method stub1299
Auto-generated method stub1308
Auto-generated method stub1315
Auto-generated method stub1323
Auto-generated method stub1330
Auto-generated method stub1339
Auto-generated method stub1348
Auto-generated method stub1355
Auto-generated method stub1365
Auto-generated method stub1375
Auto-generated method stub1395
Auto-generated method stub1404
Auto-generated method stub1413
Auto-generated method stub1423
Auto-generated method stub1432
Auto-generated method stub1442
org.kuali.student.lum.statement.config.context.OrganizationContextImplTestLine
Auto-generated method stub124
Auto-generated method stub136
Auto-generated method stub148
Auto-generated method stub157
Auto-generated method stub166
Auto-generated method stub174
Auto-generated method stub182
Auto-generated method stub191
Auto-generated method stub200
Auto-generated method stub207
Auto-generated method stub215
Auto-generated method stub224
Auto-generated method stub233
Auto-generated method stub240
Auto-generated method stub249
Auto-generated method stub258
Auto-generated method stub268
Auto-generated method stub277
Auto-generated method stub286
Auto-generated method stub295
Auto-generated method stub304
Auto-generated method stub311
Auto-generated method stub320
Auto-generated method stub330
Auto-generated method stub339
Auto-generated method stub348
Auto-generated method stub358
Auto-generated method stub366
Auto-generated method stub372
Auto-generated method stub389
Auto-generated method stub398
Auto-generated method stub408
Auto-generated method stub417
Auto-generated method stub426
Auto-generated method stub435
Auto-generated method stub444
Auto-generated method stub453
Auto-generated method stub462
Auto-generated method stub473
Auto-generated method stub485
Auto-generated method stub495
Auto-generated method stub507
Auto-generated method stub516
Auto-generated method stub525
Auto-generated method stub535
Auto-generated method stub545
Auto-generated method stub551
Auto-generated method stub557
Auto-generated method stub566
Auto-generated method stub573
Auto-generated method stub582
Auto-generated method stub589
Auto-generated method stub597
Auto-generated method stub604
Auto-generated method stub613
Auto-generated method stub622
Auto-generated method stub629
org.kuali.student.lum.ui.requirements.util.StatementServiceMockLine
Auto-generated method stub357
Auto-generated method stub366
org.kuali.student.lum.workflow.CoursePostProcessorBaseLine
set states of other approved courses to superseded131
We are not able to reuse the code in CourseStateUtil for dependency reason.162
org.kuali.student.lum.workflow.KualiStudentPostProcessorBaseLine
evaluate group or role level changes by not using isUserRequest()145
org.kuali.student.lum.workflow.qualifierresolver.CocOrgTypeQualifierResolverLine
The following annotation needs to be udpated on role definition.29
org.kuali.student.lum.workflow.search.OrgSearchAttributeLine
RICE=M9 UPGRADE check that replacing getDocumentAttributes with extractDocumentAttributes is really the intended behavior42
RICE-M7 UPGRADE I think this is correct but I'm not sure56
org.kuali.student.r2.common.criteria.impl.CriteriaLookupDaoJpaImplLine
There has to be a better way to do this.157
org.kuali.student.r2.common.criteria.transform.TransformTestLine
Rewrote the Rename Transform to honor the RiceContract then configure it here to test it transform = new RenameTransform(renames);59
Rewrote the Rename Transform to honor the RiceContract then configure it here to test it transform = new RenameTransform(renames);72
Rewrote the Rename Transform to honor the RiceContract then configure it here to test it transform = new RenameTransform(renames);110
org.kuali.student.r2.common.dao.CriteriaLookupDaoJpaImplLine
There has to be a better way to do this.163
org.kuali.student.r2.common.datadictionary.RiceDataDictionaryValidatorImplDoesNotWorkButShouldLine
figure why this does not validate anything33
org.kuali.student.r2.common.datadictionary.TestRiceDataDictionaryValidatorImplAgainstAcalLine
RICE-M9 UPGRADE321
RICE-M9 UPGRADE439
org.kuali.student.r2.common.datadictionary.TestRiceDataDictionaryValidatorImplAgainstAtpLine
RICE-M9 UPGRADE129
org.kuali.student.r2.common.datadictionary.infc.AttributeDefinitionInfcLine
figure out how to handle sub-objects. I.e. using dot notation?35
get Rice to rename this to getMinOccurs to it matches the setter.68
Get RICE to rename this getMaxOccurs so it matches the setter78
Get RICE to set a value that means UNBOUNDED, perhaps 99999999979
Ask RICE to create an interface for ValidCharactersConstraint so we can return that instead of the generic constraint208
org.kuali.student.r2.common.datadictionary.infc.DictionaryEntryLine
determine how/if this works with the than the "unique" flag on attribute definition76
determine how/if this works with the id77
org.kuali.student.r2.common.datadictionary.util.CriteriaValidatorParserLine
Consider getting all the errors and throw them as a group instead of as we find them106
org.kuali.student.r2.common.datadictionary.util.TestBaseValidCharsDictionaryLine
RICE-M9 UPGRADE50
fix reg ex so it allows 4.0 but excludes 4.1, 4.2 etc... assertNotNull (v.processValidCharConstraint ("test", vc, null, "4.1"));214
maybe allow these special characters310
maybe allow these special characters355
org.kuali.student.r2.common.dto.DtoConstantsLine
Ideally this method should not be hardcoded here. Also determining next state may be a more complicated and not just be a simple sequence.58
org.kuali.student.r2.common.entity.MetaEntityLine
- need a BaseEntity(HasMeta) to deal w/ version, id, and other fields51
org.kuali.student.r2.common.infc.ComparisonLine
Decide for complex Lists can they be checked to see how many occurences they have?55
Decide on other operators56
Deicde on operators to search collections inside such as any57
Decide how to search on dynamic attributes58
org.kuali.student.r2.common.infc.CriteriaLine
Decide if null or empty list is ok? I.e. can you get ALL?30
org.kuali.student.r2.common.infc.MeetingScheduleLine
This interface should eventually move into the scheduling service domain26
org.kuali.student.r2.common.infc.RichTextLine
Define what format is to be used? Is it assumed to be HTML? or WORD? or Wiki?41
org.kuali.student.r2.common.infc.StatusLine
switch this to hold a count or something, a boolean that always is true is confusing.29
Figure out where the message came from because it is not in the R1 wiki https://wiki.kuali.org/display/KULSTU/statusInfo+Structure32
org.kuali.student.r2.common.infc.ValidationResultLine
decide if this is a key that then gets resolved into a real localized message using the message service or the final localized message itself60
find out how repeating substructures are handled in this notation, with [n] occurrence brackets?74
org.kuali.student.r2.common.service.impl.BaseAssemblerLine
Delete leftovers here if behavior is desired103
fix this to conform to the real ref object uri but this is good enough for now to identify the type125
org.kuali.student.r2.common.util.RichTextHelperLine
actually implement a real conversion49
actually implement a real conversion57
org.kuali.student.r2.common.util.constants.LuiPersonRelationServiceConstantsLine
rename the one above to the one below as they point to the same thing71
switch these constants to those above since they now point to the same thing90
org.kuali.student.r2.core.class1.appointment.model.AppointmentSlotAttributeEntityLine
...28
org.kuali.student.r2.core.class1.appointment.model.AppointmentSlotEntityLine
...38
org.kuali.student.r2.core.class1.appointment.model.AppointmentWindowAttributeEntityLine
...28
org.kuali.student.r2.core.class1.appointment.model.AppointmentWindowEntityLine
...42
org.kuali.student.r2.core.class1.appointment.service.decorators.AppointmentServiceDecoratorLine
...41
org.kuali.student.r2.core.class1.appointment.service.decorators.AppointmentServiceValidationDecoratorLine
...23
org.kuali.student.r2.core.class1.appointment.service.impl.AppointmentServiceImplLine
...51
Figure out what else to put in status230
Figure out what else to put in status246
Check what to do in inconsistency between appointmentWindowTypeKey and type in appointmentWindowInfo325
Handle removal of orphan RichTextEntities364
sambit - THIS METHOD NEEDS JAVADOCS534
org.kuali.student.r2.core.class1.appointment.service.impl.AppointmentServiceImplHelperLine
...43
Determine if there should be a check between apptType/slotId and apptInfo counterparts Need to manually set the entity since appointmentInfo only has an id for its corresponding AppointmentSlot85
Current implementation only supports minutes. Except thrown at start of this method for any other198
Currently, unsupported200
verify this is valid419
Perhaps do something else? Throw an exception?431
Figure this out (should it be taken care of)526
Figure out how to do this List<AtpInfo> infoList = atpService.getAtpsByMilestone(apptWin.getPeriodMilestoneId(), contextInfo); if (infoList.size() != 1) { throw new InvalidParameterException("Should only return one ATP"); } AtpInfo info = infoList.get(0); List<MilestoneInfo> milestoneList = atpService.getMilestonesForAtp(info.getId(), contextInfo); boolean found = false; for (MilestoneInfo milestone: milestoneList) { if (milestone.getTypeKey().equals(AtpServiceConstants.MILESTONE_DROP_DATE_TYPE_KEY)) { slotInfo.setEndDate(milestone.getEndDate()); found = true; break; } } if (!found) { throw new OperationFailedException("Drop date milestone not found"); }672
org.kuali.student.r2.core.class1.appointment.service.impl.TestAppointmentServiceImplLine
...47
Eventually set the type once there is a type to set to169
Change for992
org.kuali.student.r2.core.class1.atp.service.impl.AtpServiceImplLine
--No comment--165
Why is this check here? Is there such a restriction? the model allos there to be many such relations over time if (checkRelationExistence(atpAtpRelationInfo)) { throw new DataValidationErrorException("The Atp-Atp relation already exists. atp=" + atpAtpRelationInfo.getAtpId() + ", relatedAtp=" + atpAtpRelationInfo.getRelatedAtpId()); }680
org.kuali.student.r2.core.class1.atp.service.impl.AtpServiceMockImplLine
--No comment--163
Put the check once methods to access milestons/atp using relations are added to the service428
org.kuali.student.r2.core.class1.atp.service.impl.TestAtpServiceImplLine
should the milestone be saved in the calculation method or is that a seperate call?801
org.kuali.student.r2.core.class1.hold.mock.HoldServiceMockImplLine
sambit - THIS METHOD NEEDS JAVADOCS249
sambit - THIS METHOD NEEDS JAVADOCS255
sambit - THIS METHOD NEEDS JAVADOCS309
org.kuali.student.r2.core.class1.organization.service.impl.OrganizationAssemblerLine
Use the person Service here Person person = personService.findPerson(orgPersonRelationInfo.getPersonId()); if (person == null) { throw new InvalidParameterException( "Person does not exist for id: " + orgPersonRelationInfo.getPersonId()); } orgPersonRelation.setPersonId(person.getId());416
org.kuali.student.r2.core.class1.process.CourseRegistrationServiceProcessCheckDecoratorLine
implement in phase II73
org.kuali.student.r2.core.class1.process.krms.termresolver.CurrentDateResolverLine
Analyze, though probably not much to check here54
org.kuali.student.r2.core.class1.process.krms.termresolver.MilestoneByTypeResolverLine
Analyze75
org.kuali.student.r2.core.class1.process.krms.termresolver.MilestoneResolverLine
Analyze61
org.kuali.student.r2.core.class1.process.krms.termresolver.RegistrationHoldsTermResolverLine
Analyze74
org.kuali.student.r2.core.class1.process.krms.termresolver.StudentDeceasedTermResolverLine
analyze71
org.kuali.student.r2.core.class1.process.krms.termresolver.SummerOnlyStudentTermResolverLine
Analyze76
org.kuali.student.r2.core.class1.process.service.decorators.ProcessServiceValidationDecoratorLine
remove56
Need to add dictionary entry57
check for existing83
remove127
Need to add dictionary entry128
check for existing157
remove176
populate dictionary entry177
check for existing225
remove311
Need to add dictionary entry312
org.kuali.student.r2.core.class1.process.service.impl.ProcessServiceImplLine
--No comment--85
--No comment--95
--No comment--104
--No comment--113
--No comment--121
--No comment--130
--No comment--140
--No comment--149
--No comment--159
--No comment--167
--No comment--177
--No comment--187
--No comment--242
--No comment--250
--No comment--258
--No comment--268
--No comment--397
--No comment--405
--No comment--415
--No comment--610
--No comment--619
--No comment--632
incorporate context782
move to validation decorator?785
org.kuali.student.r2.core.class1.scheduling.model.ScheduleRequestComponentEntityLine
Left as @Column per Sambit, TBD: Change the following to join relations22
All the following need to change to using entities, leaving as ids per @Sambit50
All the following need to change to using entities, leaving as ids per @Sambit62
org.kuali.student.r2.core.class1.search.SearchServiceHardwiredImplLine
...33
org.kuali.student.r2.core.class1.state.model.LifecycleEntityLine
Uncomment when/if we figure out if we store xxx_KEY as such in the DB instead of as ID22
org.kuali.student.r2.core.class1.state.model.StateEntityLine
Uncomment when/if we figure out if we store xxx_KEY as such in the DB instead of as ID25
consider storing this as a related JPA entity instead of as a string37
org.kuali.student.r2.core.class1.state.service.impl.StateServiceMockImplLine
look at the criteria103
look at the criteria110
check for valid info117
call validate128
call validate144
look at criteria203
look at criteria209
check for valid info220
call validate247
org.kuali.student.r2.core.class1.type.service.impl.TypeServiceMockImplLine
implement52
implement57
implement62
implement67
implement86
implement100
implement105
implement110
implement115
implement120
implement125
implement155
implement160
implement165
implement170
org.kuali.student.r2.core.exemption.service.ExemptionServiceMockImplLine
sambit - THIS METHOD NEEDS JAVADOCS284
org.kuali.student.r2.core.fee.dao.EnrollmentFeeDaoLine
...25
org.kuali.student.r2.core.fee.model.EnrollmentFeeAttributeEntityLine
...28
org.kuali.student.r2.core.fee.model.EnrollmentFeeEntityLine
...33
org.kuali.student.r2.core.fee.service.impl.TestFeeServiceImplLine
...41
org.kuali.student.r2.core.population.infc.PopulationRuleLine
Figure out how this can be persisted41
org.kuali.student.r2.core.population.service.PopulationServiceMockImplLine
implement other logic166
org.kuali.student.r2.core.population.service.PopulationServiceMockImplTestLine
test attaching rule to a population169
org.kuali.student.r2.core.process.ProcessPocAtpServiceDecoratorTestLine
re-enable after refactoring35
org.kuali.student.r2.core.process.ProcessPocExemptionServiceDecoratorTestLine
re-enable after refactoring32
org.kuali.student.r2.core.process.ProcessPocJavaIntegrationTestLine
re-enable after refactoring45
Shouldn't this message say something about the fact that the student has an extention but it is even too late for that?321
org.kuali.student.r2.core.process.ProcessPocKrmsIntegrationTestLine
re-enable after refactoring39
org.kuali.student.r2.core.process.infc.InstructionLine
revisit rules that evaluate to ATPs.71
org.kuali.student.r2.core.process.service.impl.TestProcessServiceImplLine
--No comment--175
org.kuali.student.r2.core.statement.util.PropositionBuilderLine
--No comment--243
--No comment--358
--No comment--376
--No comment--411
--No comment--417
org.kuali.student.r2.lum.course.infc.LoDisplayLine
...13
org.kuali.student.r2.lum.lo.infc.LoRepositoryLine
JAVADOCS9
org.kuali.student.r2.lum.program.dto.assembly.ProgramIdentifierAssemblyLine
--No comment--43
org.kuali.student.r2.lum.program.service.ProgramServiceLine
CHECK THESE VALUES51
org.kuali.student.r2.lum.program.service.ProgramServiceDecoratorLine
sambit - THIS METHOD NEEDS JAVADOCS285
org.kuali.student.security.filter.AuthenticationGwtRpcFilterLine
handle this44
org.kuali.student.security.filter.KSLogoutFilterLine
handle this74
org.kuali.student.security.filter.ProxyTicketRetrieverFilterLine
handle this51
org.kuali.student.security.filter.ProxyTicketRetrieverFilterSTSLine
handle this65