The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.student.enrollment.class2.acal.form.AcademicCalendarForm in org.kuali.student.enrollment.class2.acal.controller.AcademicCalendarController.start(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 77 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.student.enrollment.class2.acal.form.CalendarSearchForm in org.kuali.student.enrollment.class2.acal.controller.CalendarSearchController.start(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.student.enrollment.class2.acal.form.HolidayCalendarForm in org.kuali.student.enrollment.class2.acal.controller.HolidayCalendarController.addLine(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 66 | Medium |
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.student.enrollment.class2.acal.form.HolidayCalendarForm in org.kuali.student.enrollment.class2.acal.controller.HolidayCalendarController.start(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 138 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.dto.AcademicTermWrapper.getEndDate() may expose internal representation by returning AcademicTermWrapper.endDate | MALICIOUS_CODE | EI_EXPOSE_REP | 93 | Medium |
| org.kuali.student.enrollment.class2.acal.dto.AcademicTermWrapper.getStartDate() may expose internal representation by returning AcademicTermWrapper.startDate | MALICIOUS_CODE | EI_EXPOSE_REP | 85 | Medium |
| org.kuali.student.enrollment.class2.acal.dto.AcademicTermWrapper.setEndDate(Date) may expose internal representation by storing an externally mutable object into AcademicTermWrapper.endDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 97 | Medium |
| org.kuali.student.enrollment.class2.acal.dto.AcademicTermWrapper.setStartDate(Date) may expose internal representation by storing an externally mutable object into AcademicTermWrapper.startDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 89 | Medium |
| Unused field: org.kuali.student.enrollment.class2.acal.dto.AcademicTermWrapper.isAlreadySaved | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused field: org.kuali.student.enrollment.class2.acal.dto.AcademicTermWrapper.isOfficial | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.dto.HolidayWrapper defines compareTo(HolidayWrapper) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 103 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.dto.TimeSetWrapper.getEndDate() may expose internal representation by returning TimeSetWrapper.endDate | MALICIOUS_CODE | EI_EXPOSE_REP | 83 | Medium |
| org.kuali.student.enrollment.class2.acal.dto.TimeSetWrapper.getStartDate() may expose internal representation by returning TimeSetWrapper.startDate | MALICIOUS_CODE | EI_EXPOSE_REP | 75 | Medium |
| org.kuali.student.enrollment.class2.acal.dto.TimeSetWrapper.setEndDate(Date) may expose internal representation by storing an externally mutable object into TimeSetWrapper.endDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 87 | Medium |
| org.kuali.student.enrollment.class2.acal.dto.TimeSetWrapper.setStartDate(Date) may expose internal representation by storing an externally mutable object into TimeSetWrapper.startDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 79 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.form.AcademicCalendarForm.getUpdateTimeString() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 114 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.form.HolidayCalendarForm.getUpdateTimeString() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 144 | Medium |
| org.kuali.student.enrollment.class2.acal.form.HolidayCalendarForm.getNewCalendarEndDate() may expose internal representation by returning HolidayCalendarForm.newCalendarEndDate | MALICIOUS_CODE | EI_EXPOSE_REP | 105 | Medium |
| org.kuali.student.enrollment.class2.acal.form.HolidayCalendarForm.getNewCalendarStartDate() may expose internal representation by returning HolidayCalendarForm.newCalendarStartDate | MALICIOUS_CODE | EI_EXPOSE_REP | 98 | Medium |
| org.kuali.student.enrollment.class2.acal.form.HolidayCalendarForm.setNewCalendarEndDate(Date) may expose internal representation by storing an externally mutable object into HolidayCalendarForm.newCalendarEndDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 108 | Medium |
| org.kuali.student.enrollment.class2.acal.form.HolidayCalendarForm.setNewCalendarStartDate(Date) may expose internal representation by storing an externally mutable object into HolidayCalendarForm.newCalendarStartDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 101 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of states in org.kuali.student.enrollment.class2.acal.keyvalue.AtpStateKeyValues.getKeyValues(ViewModel) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 81 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to hcList in org.kuali.student.enrollment.class2.acal.keyvalue.HolidayWrapperListFinder.buildOfficialHolidayCalendarInfoList(Integer) | STYLE | DLS_DEAD_LOCAL_STORE | 90 | Medium |
| Dead store to holidayCalendarInfoList in org.kuali.student.enrollment.class2.acal.keyvalue.HolidayWrapperListFinder.getKeyValues(ViewModel) | STYLE | DLS_DEAD_LOCAL_STORE | 50 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.service.AcademicCalendarInfoInquiryViewHelperServiceImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 14 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.service.AcademicCalendarInfoLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 18 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.enrollment.class2.acal.service.AcademicCalendarInfoMaintainableImpl.getYearFromDate(Date) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 134 | Medium |
| org.kuali.student.enrollment.class2.acal.service.AcademicCalendarInfoMaintainableImpl.getAcademicCalendarKey(AcademicCalendarInfo) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 113 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperInquiryViewHelperServiceImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 21 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to academicCalendarName in org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperLookupableImpl.getSearchResults(LookupForm, Map, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 36 | Medium |
| Dead store to credentialProgramType in org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperLookupableImpl.getSearchResults(LookupForm, Map, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 37 | Medium |
| org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 23 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to theKeyDateInfoType in org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperMaintainableImpl.getKeyDateInfoKey(KeyDateInfo) | STYLE | DLS_DEAD_LOCAL_STORE | 334 | Medium |
| Method org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperMaintainableImpl.getYearFromDate(Date) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 367 | Medium |
| org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperMaintainableImpl.getAcademicCalendarKey(AcademicCalendarInfo) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 302 | Medium |
| org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperMaintainableImpl.getKeyDateInfoKey(KeyDateInfo) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 328 | Medium |
| org.kuali.student.enrollment.class2.acal.service.AcademicCalendarWrapperMaintainableImpl.getTermInfoName(TermInfo) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 358 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to acalInfoList in org.kuali.student.enrollment.class2.acal.service.AcademicTermLookupableImpl.getSearchResults(LookupForm, Map, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 46 | High |
| org.kuali.student.enrollment.class2.acal.service.AcademicTermLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.service.TermInfoInquiryViewHelperServiceImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 14 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.service.TermInfoLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 20 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.enrollment.class2.acal.service.TermInfoMaintainableImpl.getYearFromDate(Date) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 136 | Medium |
| org.kuali.student.enrollment.class2.acal.service.TermInfoMaintainableImpl.getTermInfoKey(TermInfo) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 115 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.service.TermLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31 | Medium |
| Method org.kuali.student.enrollment.class2.acal.service.TermLookupableImpl.getActionUrlHref(LookupForm, Object, String, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 70 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.service.TermWrapperInquiryViewHelperServiceImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 22 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.service.TermWrapperLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 21 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.enrollment.class2.acal.service.TermWrapperMaintainableImpl.getYearFromDate(Date) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 226 | Medium |
| org.kuali.student.enrollment.class2.acal.service.TermWrapperMaintainableImpl.getKeyDateInfoKey(KeyDateInfo, String) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 237 | Medium |
| org.kuali.student.enrollment.class2.acal.service.TermWrapperMaintainableImpl.getTermInfoKey(TermInfo) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 205 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.service.impl.CalendarSearchViewHelperServiceImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 27 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to holidayCalendarInfoList in org.kuali.student.enrollment.class2.acal.service.impl.HolidayCalendarLookupableImpl.getSearchResults(LookupForm, Map, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 31 | Medium |
| org.kuali.student.enrollment.class2.acal.service.impl.HolidayCalendarLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 22 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.service.impl.HolidayCalendarViewHelperServiceInquirableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 38 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.acal.service.impl.HolidayCalendarWrapperInquiryViewHelperServiceImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 23 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to holidayCalendarInfoList in org.kuali.student.enrollment.class2.acal.service.impl.HolidayCalendarWrapperLookupableImpl.getSearchResults(LookupForm, Map, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 34 | Medium |
| org.kuali.student.enrollment.class2.acal.service.impl.HolidayCalendarWrapperLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 24 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.student.enrollment.class2.appointment.form.RegistrationWindowsManagementForm in org.kuali.student.enrollment.class2.appointment.controller.RegistrationWindowsController.deleteLine(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 258 | Medium |
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.student.enrollment.class2.appointment.form.RegistrationWindowsManagementForm in org.kuali.student.enrollment.class2.appointment.controller.RegistrationWindowsController.start(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 76 | Medium |
| org.kuali.student.enrollment.class2.appointment.controller.RegistrationWindowsController._getSimpleDate(Date) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 316 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.appointment.dto.AppointmentWindowWrapper.getAssignmentsCreated() may expose internal representation by returning AppointmentWindowWrapper.assignmentsCreated | MALICIOUS_CODE | EI_EXPOSE_REP | 154 | Medium |
| org.kuali.student.enrollment.class2.appointment.dto.AppointmentWindowWrapper.setAssignmentsCreated(Date) may expose internal representation by storing an externally mutable object into AppointmentWindowWrapper.assignmentsCreated | MALICIOUS_CODE | EI_EXPOSE_REP2 | 158 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.kuali.student.enrollment.class2.appointment.form.RegistrationWindowsManagementForm() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 30 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.kuali.student.enrollment.class2.appointment.keyvalue.SlotRuleForAppWindowKeyValuesFinder.getKeyValues(ViewModel) | STYLE | DLS_DEAD_LOCAL_STORE | 61 | Medium |
| org.kuali.student.enrollment.class2.appointment.keyvalue.SlotRuleForAppWindowKeyValuesFinder is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 40 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.appointment.service.impl.AppointmentViewHelperServiceImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 58 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of ? in org.kuali.student.enrollment.class2.appointment.service.impl.AppointmentWindowWrapperInquiryViewHelperServiceImpl.retrieveDataObject(Map) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 81 | High |
| Possible null pointer dereference of ? in org.kuali.student.enrollment.class2.appointment.service.impl.AppointmentWindowWrapperInquiryViewHelperServiceImpl.retrieveDataObject(Map) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 81 | High |
| Exception is caught when Exception is not thrown in org.kuali.student.enrollment.class2.appointment.service.impl.AppointmentWindowWrapperInquiryViewHelperServiceImpl.retrieveDataObject(Map) | STYLE | REC_CATCH_EXCEPTION | 95 | High |
| org.kuali.student.enrollment.class2.appointment.service.impl.AppointmentWindowWrapperInquiryViewHelperServiceImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to windowWrapperList in org.kuali.student.enrollment.class2.appointment.service.impl.AppointmentWindowWrapperLookupableImpl.getSearchResults(LookupForm, Map, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 49 | Medium |
| org.kuali.student.enrollment.class2.appointment.service.impl.AppointmentWindowWrapperLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.enrollment.class2.appointment.service.impl.StudentGroupWrapperLookupableImpl.getSearchResults(LookupForm, Map, boolean) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 56 | Medium |
| org.kuali.student.enrollment.class2.appointment.service.impl.StudentGroupWrapperLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 43 | Medium |
| Method org.kuali.student.enrollment.class2.appointment.service.impl.StudentGroupWrapperLookupableImpl.getSearchResults(LookupForm, Map, boolean) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 56 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.appointment.util.AppointmentSlotRuleTypeConversion.DELIMITER isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 37 | High |
| org.kuali.student.enrollment.class2.appointment.util.AppointmentSlotRuleTypeConversion.MINUTE_IN_SECS isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 35 | High |
| org.kuali.student.enrollment.class2.appointment.util.AppointmentSlotRuleTypeConversion.SECOND_IN_MILLIS isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 34 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.student.enrollment.class2.courseoffering.form.CourseOfferingRolloverManagementForm in org.kuali.student.enrollment.class2.courseoffering.controller.CourseOfferingRolloverController.start(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 61 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.student.enrollment.class2.courseoffering.keyvalue.SubjectAreaKeyValues defines non-transient non-serializable instance field subjectAreasComparator | BAD_PRACTICE | SE_BAD_FIELD | High | |
| Class org.kuali.student.enrollment.class2.courseoffering.keyvalue.SubjectAreaKeyValues defines non-transient non-serializable instance field enumService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.enrollment.class2.courseoffering.keyvalue.SubjectAreaKeyValues$SubjectAreasComparator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 84 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to formObject in org.kuali.student.enrollment.class2.courseoffering.service.impl.ActivityOfferingMaintainableImpl.processAfterNew(MaintenanceDocument, Map) | STYLE | DLS_DEAD_LOCAL_STORE | 71 | Medium |
| Dead store to activityOfferingInfo in org.kuali.student.enrollment.class2.courseoffering.service.impl.ActivityOfferingMaintainableImpl.saveDataObject() | STYLE | DLS_DEAD_LOCAL_STORE | 47 | Medium |
| org.kuali.student.enrollment.class2.courseoffering.service.impl.ActivityOfferingMaintainableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 25 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.courseoffering.service.impl.AdvanceActivityOfferingLookupableImpl.getSearchResults(LookupForm, Map, boolean) forgets to throw new Exception(String) | CORRECTNESS | RV_EXCEPTION_NOT_THROWN | 55 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingInfoInquirableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 16 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingInfoLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 24 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to aoFetched in org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingViewHelperServiceImpl._verify(CourseOfferingInfo, FormatOfferingInfo, ActivityOfferingInfo) | STYLE | DLS_DEAD_LOCAL_STORE | 179 | Medium |
| Dead store to coFetched in org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingViewHelperServiceImpl._verify(CourseOfferingInfo, FormatOfferingInfo, ActivityOfferingInfo) | STYLE | DLS_DEAD_LOCAL_STORE | 177 | Medium |
| Dead store to foFetched in org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingViewHelperServiceImpl._verify(CourseOfferingInfo, FormatOfferingInfo, ActivityOfferingInfo) | STYLE | DLS_DEAD_LOCAL_STORE | 178 | Medium |
| Method call in org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingViewHelperServiceImpl.createSocCoFoAoForTerm(String, CourseOfferingRolloverManagementForm) passes null for nonnull parameter of _verify(CourseOfferingInfo, FormatOfferingInfo, ActivityOfferingInfo) | CORRECTNESS | NP_NULL_PARAM_DEREF | 195 | High |
| Exception is caught when Exception is not thrown in org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingViewHelperServiceImpl.cleanSourceTerm(String, CourseOfferingRolloverManagementForm) | STYLE | REC_CATCH_EXCEPTION | 420 | Medium |
| Exception is caught when Exception is not thrown in org.kuali.student.enrollment.class2.courseoffering.service.impl.CourseOfferingViewHelperServiceImpl.cleanTargetTerm(String, CourseOfferingRolloverManagementForm) | STYLE | REC_CATCH_EXCEPTION | 355 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to formObject in org.kuali.student.enrollment.class2.courseoffering.service.impl.EnrollmentFeeMaintainableImpl.processAfterNew(MaintenanceDocument, Map) | STYLE | DLS_DEAD_LOCAL_STORE | 88 | Medium |
| Dead store to feeInfo in org.kuali.student.enrollment.class2.courseoffering.service.impl.EnrollmentFeeMaintainableImpl.saveDataObject() | STYLE | DLS_DEAD_LOCAL_STORE | 64 | Medium |
| org.kuali.student.enrollment.class2.courseoffering.service.impl.EnrollmentFeeMaintainableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 27 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.courseoffering.service.impl.FormatOfferingInfoLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to formatOfferingInfoUpdated in org.kuali.student.enrollment.class2.courseoffering.service.impl.FormatOfferingInfoMaintainableImpl.saveDataObject() | STYLE | DLS_DEAD_LOCAL_STORE | 73 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.courseoffering.service.impl.SocRolloverResultInfoInquirableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 14 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.courseoffering.service.impl.SocRolloverResultInfoLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 21 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.courseoffering.service.impl.SocRolloverResultItemInfoInquirableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 40 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.enrollment.class2.courseoffering.service.impl.SocRolloverResultItemInfoLookupableImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 39 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.student.enrollment.class2.grading.form.GradingForm defines non-transient non-serializable instance field acalService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.enrollment.class2.grading.form.GradingForm defines non-transient non-serializable instance field coService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to courseOfferingList in org.kuali.student.enrollment.class2.grading.keyvalue.CourseOfferingForGradingKeyValues.getKeyValues() | STYLE | DLS_DEAD_LOCAL_STORE | 51 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to save in org.kuali.student.enrollment.class2.grading.service.impl.GradingViewHelperServiceImpl.submitGradeRoster(GradingForm) | STYLE | DLS_DEAD_LOCAL_STORE | 188 | Medium |
| Dead store to collectionGroup in org.kuali.student.enrollment.class2.grading.service.impl.GradingViewHelperServiceImpl.unAssignGrade(View, Object, String, Integer) | STYLE | DLS_DEAD_LOCAL_STORE | 82 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.student.enrollment.class2.registration.form.RegistrationForm in org.kuali.student.enrollment.class2.registration.controller.RegistrationController.showRegistration(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 169 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.enrollment.class2.registration.dto.MeetingScheduleWrapper.getJsScheduleObject() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 91 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.kuali.student.enrollment.uif.control.ScheduleControl$dayTypes doesn't start with an upper case letter | BAD_PRACTICE | NM_CLASS_NAMING_CONVENTION | 42 | Medium |
