The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.ui.server.gwt.AbstractDataService.isAuthorized(PermissionType, Map) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 136 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to stdResp in org.kuali.student.core.assembly.transform.ProposalWorkflowFilter.updateWorkflow(ProposalInfo, Data, Map) | STYLE | DLS_DEAD_LOCAL_STORE | 231 | Medium |
| Call to equals() comparing different types in org.kuali.student.core.assembly.transform.ProposalWorkflowFilter.updateWorkflow(ProposalInfo, Data, Map) | CORRECTNESS | EC_UNRELATED_TYPES | 228 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.student.core.authorization.ui.server.gwt.AuthorizationRpcGwtServlet defines non-transient non-serializable instance field permissionService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to method of static java.text.DateFormat in org.kuali.student.core.comments.ui.client.widgets.commenttool.CommentTool.redrawCommentsTable(List) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 346 | Medium |
| Unread field: org.kuali.student.core.comments.ui.client.widgets.commenttool.CommentTool.buttonPanel | PERFORMANCE | URF_UNREAD_FIELD | 106 | Medium |
| Unread field: org.kuali.student.core.comments.ui.client.widgets.commenttool.CommentTool.referenceAttributes | PERFORMANCE | URF_UNREAD_FIELD | 561 | Medium |
| Unread field: org.kuali.student.core.comments.ui.client.widgets.commenttool.CommentTool.viewEnum | PERFORMANCE | URF_UNREAD_FIELD | 85 | Medium |
| Unread field: org.kuali.student.core.comments.ui.client.widgets.commenttool.CommentTool.viewName | PERFORMANCE | URF_UNREAD_FIELD | 84 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.core.comments.ui.client.widgets.decisiontool.DecisionPanel.decisionTypeKey | PERFORMANCE | URF_UNREAD_FIELD | 73 | Medium |
| Unused field: org.kuali.student.core.comments.ui.client.widgets.decisiontool.DecisionPanel.proposalNameHeader | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused field: org.kuali.student.core.comments.ui.client.widgets.decisiontool.DecisionPanel.title | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused field: org.kuali.student.core.comments.ui.client.widgets.decisiontool.DecisionPanel.titlePanel | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.core.comments.ui.client.widgets.decisiontool.DecisionPanel$RationaleRow be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 219 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.core.comments.ui.client.widgets.decisiontool.FieldAscendingRowComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 432 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.core.comments.ui.client.widgets.decisiontool.FieldDescendingRowComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 452 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.student.core.comments.ui.server.CommentRpcGwtServlet defines non-transient non-serializable instance field identityService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to metadata in org.kuali.student.core.document.ui.client.widgets.documenttool.DocumentTool.setupMultiplicityConfig(MultiplicityConfiguration$MultiplicityType, MultiplicityConfiguration$StyleType, String, String, String, Map, List) | STYLE | DLS_DEAD_LOCAL_STORE | 352 | Medium |
| Unread field: org.kuali.student.core.document.ui.client.widgets.documenttool.DocumentTool.refDocRelationTypeKey; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 80 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| integral division result cast to double or float in org.kuali.student.core.document.ui.client.widgets.documenttool.DocumentTool$3$1$1$1.addFileProgress(FileStatus) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 224 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of createdDoc in org.kuali.student.core.document.ui.server.upload.UploadServlet.doPost(HttpServletRequest, HttpServletResponse) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 180 | Medium |
| Exception is caught when Exception is not thrown in org.kuali.student.core.document.ui.server.upload.UploadServlet.doPost(HttpServletRequest, HttpServletResponse) | STYLE | REC_CATCH_EXCEPTION | 201 | Medium |
| Class org.kuali.student.core.document.ui.server.upload.UploadServlet defines non-transient non-serializable instance field LOG | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.document.ui.server.upload.UploadServlet defines non-transient non-serializable instance field documentService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.core.document.ui.server.upload.UploadServlet$DocumentProgressListener be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 57 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to parentRelations in org.kuali.student.core.organization.assembly.OrgOrgRelationAssembler.get(String) | STYLE | DLS_DEAD_LOCAL_STORE | 77 | Medium |
| Dead store to relations in org.kuali.student.core.organization.assembly.OrgOrgRelationAssembler.get(String) | STYLE | DLS_DEAD_LOCAL_STORE | 76 | Medium |
| Dead store to validationResults in org.kuali.student.core.organization.assembly.OrgOrgRelationAssembler.save(Data) | STYLE | DLS_DEAD_LOCAL_STORE | 110 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to relations in org.kuali.student.core.organization.assembly.OrgPersonRelationAssembler.get(String) | STYLE | DLS_DEAD_LOCAL_STORE | 77 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to positions in org.kuali.student.core.organization.assembly.OrgPositionRestrictionAssembler.get(String) | STYLE | DLS_DEAD_LOCAL_STORE | 73 | Medium |
| Dead store to validationResults in org.kuali.student.core.organization.assembly.OrgPositionRestrictionAssembler.save(Data) | STYLE | DLS_DEAD_LOCAL_STORE | 103 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to positions in org.kuali.student.core.organization.assembly.OrgProposalAssembler.get(String) | STYLE | DLS_DEAD_LOCAL_STORE | 110 | High |
| Dead store to relations in org.kuali.student.core.organization.assembly.OrgProposalAssembler.get(String) | STYLE | DLS_DEAD_LOCAL_STORE | 111 | High |
| Dead store to orgInfo in org.kuali.student.core.organization.assembly.OrgProposalAssembler.get(String) | STYLE | DLS_DEAD_LOCAL_STORE | 109 | Medium |
| Dead store to relationData in org.kuali.student.core.organization.assembly.OrgProposalAssembler.save(Data) | STYLE | DLS_DEAD_LOCAL_STORE | 185 | Medium |
| Dead store to validationResults in org.kuali.student.core.organization.assembly.OrgProposalAssembler.save(Data) | STYLE | DLS_DEAD_LOCAL_STORE | 155 | Medium |
| org.kuali.student.core.organization.assembly.OrgProposalAssembler.ORG_PROPOSAL_DATA_TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 63 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to orgInfoPath in org.kuali.student.core.organization.ui.client.mvc.controller.OrgProposalController.setButtonPermission() | STYLE | DLS_DEAD_LOCAL_STORE | 343 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.core.organization.ui.client.mvc.view.CommonConfigurer.WITH_DIVIDER | PERFORMANCE | URF_UNREAD_FIELD | 56 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: org.kuali.student.core.organization.ui.client.mvc.view.OrgPositionTypePicker.orgPosTypeList | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to lbl in new org.kuali.student.core.organization.ui.client.mvc.view.OrgTree() | STYLE | DLS_DEAD_LOCAL_STORE | 57 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to orgName in org.kuali.student.core.organization.ui.client.mvc.view.OrgTree$1.onOpen(OpenEvent) | STYLE | DLS_DEAD_LOCAL_STORE | 66 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.core.organization.ui.client.view.OrgEntryPoint.content | PERFORMANCE | URF_UNREAD_FIELD | 46 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.student.core.organization.ui.server.gwt.OrgRpcGwtServlet defines non-transient non-serializable instance field LOG | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.organization.ui.server.gwt.OrgRpcGwtServlet defines non-transient non-serializable instance field identityServiceNonCached | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.organization.ui.server.gwt.OrgRpcGwtServlet defines non-transient non-serializable instance field service | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.core.organization.ui.theme.standard.client.OrgCssImpl.getCssString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to stdResp in org.kuali.student.core.rice.authorization.CollaboratorHelper.removeCollaborator(String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 114 | Medium |
| Call to equals() comparing different types in org.kuali.student.core.rice.authorization.CollaboratorHelper.addCollaborator(String, String, String, String, String, String, boolean, String) | CORRECTNESS | EC_UNRELATED_TYPES | 65 | High |
| Call to equals() comparing different types in org.kuali.student.core.rice.authorization.CollaboratorHelper.getCollaborators(String) | CORRECTNESS | EC_UNRELATED_TYPES | 145 | High |
| Nullcheck of info at line 154 of value previously dereferenced in org.kuali.student.core.rice.authorization.CollaboratorHelper.getCollaborators(String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 154 | Medium |
| Class org.kuali.student.core.rice.authorization.CollaboratorHelper defines non-transient non-serializable instance field documentTypeService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.rice.authorization.CollaboratorHelper defines non-transient non-serializable instance field identityService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.rice.authorization.CollaboratorHelper defines non-transient non-serializable instance field permissionService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.rice.authorization.CollaboratorHelper defines non-transient non-serializable instance field roleService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.rice.authorization.CollaboratorHelper defines non-transient non-serializable instance field workflowDocumentActionsService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.rice.authorization.CollaboratorHelper defines non-transient non-serializable instance field workflowDocumentService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.core.statement.ui.client.widgets.rules.ReqCompEditWidget.NO_SELECTION_TEXT; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 50 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.core.statement.ui.client.widgets.rules.RuleExpressionEditor.ruleChanged | PERFORMANCE | URF_UNREAD_FIELD | 54 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of tokenList in org.kuali.student.core.statement.ui.client.widgets.rules.RuleExpressionParser.checkCondition(List, List, int, List) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 221 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless control flow in org.kuali.student.core.statement.ui.client.widgets.rules.RuleInfo.statementVOIsDegroupAble(List, List) | STYLE | UCF_USELESS_CONTROL_FLOW | 202 | Medium |
| Uninitialized read of statementVO in new org.kuali.student.core.statement.ui.client.widgets.rules.RuleInfo() | CORRECTNESS | UR_UNINIT_READ | 31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of RulePreviewWidget.stmtTreeInfo in org.kuali.student.core.statement.ui.client.widgets.rules.RulePreviewWidget.displayRule() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 84 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.core.statement.ui.client.widgets.rules.RulePreviewWidget$SubRuleInfo be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 255 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.core.statement.ui.client.widgets.rules.RuleTableManipulationWidget.isOperatorChecked | PERFORMANCE | URF_UNREAD_FIELD | 68 | Medium |
| Unread field: org.kuali.student.core.statement.ui.client.widgets.rules.RuleTableManipulationWidget.separator1 | PERFORMANCE | URF_UNREAD_FIELD | 50 | Medium |
| Unread field: org.kuali.student.core.statement.ui.client.widgets.rules.RuleTableManipulationWidget.separator2 | PERFORMANCE | URF_UNREAD_FIELD | 51 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method call in org.kuali.student.core.statement.ui.client.widgets.rules.RuleTableManipulationWidget$7.onClick(ClickEvent) passes null for nonnull parameter of RuleTableManipulationWidget.redraw(StatementTreeViewInfo, boolean, Boolean) | CORRECTNESS | NP_NULL_PARAM_DEREF | 244 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.kuali.student.core.statement.ui.client.widgets.rules.RulesUtil.clone(ReqComponentTypeInfo) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 167 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of parent in org.kuali.student.core.statement.ui.client.widgets.rules.StatementVO.doSimplify(StatementVO, StatementVO) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 680 | Medium |
| Nullcheck of statementVO at line 755 of value previously dereferenced in org.kuali.student.core.statement.ui.client.widgets.rules.StatementVO.doConvertToExpression(StringBuilder, StatementVO, boolean) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 753 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.core.statement.ui.client.widgets.rules.Token.hashCode() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 107 | Medium |
| org.kuali.student.core.statement.ui.client.widgets.rules.Token.And isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 20 | Medium |
| org.kuali.student.core.statement.ui.client.widgets.rules.Token.Condition isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 24 | Medium |
| org.kuali.student.core.statement.ui.client.widgets.rules.Token.EndParenthesis isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 23 | Medium |
| org.kuali.student.core.statement.ui.client.widgets.rules.Token.Or isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 21 | Medium |
| org.kuali.student.core.statement.ui.client.widgets.rules.Token.StartParenthesis isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 22 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.core.statement.ui.client.widgets.table.ExpressionNode.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 20 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.core.statement.ui.client.widgets.table.Node.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 25 | Medium |
| Unused field: org.kuali.student.core.statement.ui.client.widgets.table.Node.id | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to rf in org.kuali.student.core.statement.ui.client.widgets.table.SectionTable.applyDataRowStyles() | STYLE | DLS_DEAD_LOCAL_STORE | 87 | Medium |
| new org.kuali.student.core.statement.ui.client.widgets.table.SectionTable(Object[][]) may expose internal representation by storing an externally mutable object into SectionTable.rowData | MALICIOUS_CODE | EI_EXPOSE_REP2 | 42 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.core.workflow.ui.client.views.CollaboratorSectionView.refreshCollaboratorsTable() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 437 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.core.workflow.ui.client.widgets.WorkflowUtilities.loaded | PERFORMANCE | URF_UNREAD_FIELD | 112 | Medium |
| Unused field: org.kuali.student.core.workflow.ui.client.widgets.WorkflowUtilities.approveSaveActionEvent | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused field: org.kuali.student.core.workflow.ui.client.widgets.WorkflowUtilities.startWorkflowSaveActionEvent | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to username in org.kuali.student.core.workflow.ui.server.gwt.WorkflowRpcGwtServlet.getDataIdFromWorkflowId(String) | STYLE | DLS_DEAD_LOCAL_STORE | 323 | Medium |
| Exception is caught when Exception is not thrown in org.kuali.student.core.workflow.ui.server.gwt.WorkflowRpcGwtServlet.getActionsRequested(String) | STYLE | REC_CATCH_EXCEPTION | 266 | Medium |
| Exception is caught when Exception is not thrown in org.kuali.student.core.workflow.ui.server.gwt.WorkflowRpcGwtServlet.performWorkflowDocumentAction(String, String, String) | STYLE | REC_CATCH_EXCEPTION | 117 | Medium |
| Self assignment of field WorkflowRpcGwtServlet.workflowDocumentService in org.kuali.student.core.workflow.ui.server.gwt.WorkflowRpcGwtServlet.setWorkflowDocumentService(WorkflowDocumentService) | CORRECTNESS | SA_FIELD_SELF_ASSIGNMENT | 396 | High |
| Class org.kuali.student.core.workflow.ui.server.gwt.WorkflowRpcGwtServlet defines non-transient non-serializable instance field LOG | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.workflow.ui.server.gwt.WorkflowRpcGwtServlet defines non-transient non-serializable instance field identityService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.workflow.ui.server.gwt.WorkflowRpcGwtServlet defines non-transient non-serializable instance field permissionService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.workflow.ui.server.gwt.WorkflowRpcGwtServlet defines non-transient non-serializable instance field workflowDocumentActionsService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.workflow.ui.server.gwt.WorkflowRpcGwtServlet defines non-transient non-serializable instance field workflowDocumentService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.core.workflow.ui.server.gwt.WorkflowRpcGwtServlet defines non-transient non-serializable instance field workflowDocumentTypeService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
