FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
1577504

Files

ClassBugs
org.kuali.student.core.atp.entity.Atp4
org.kuali.student.core.atp.entity.DateRange4
org.kuali.student.core.atp.entity.Milestone2
org.kuali.student.core.atp.service.impl.AtpServiceImpl4
org.kuali.student.core.comment.entity.Comment4
org.kuali.student.core.comment.entity.Tag4
org.kuali.student.core.document.entity.Document4
org.kuali.student.core.document.entity.DocumentCategory4
org.kuali.student.core.document.entity.RefDocRelation4
org.kuali.student.core.enumerationmanagement.entity.EnumeratedValue4
org.kuali.student.core.messages.service.impl.MessageServiceMock1
org.kuali.student.core.organization.entity.Org4
org.kuali.student.core.organization.entity.OrgHierarchy4
org.kuali.student.core.organization.entity.OrgOrgRelation4
org.kuali.student.core.organization.entity.OrgPersonRelation4
org.kuali.student.core.organization.service.impl.OrganizationServiceImpl2
org.kuali.student.core.personsearch.service.impl.PersonSearch1
org.kuali.student.core.personsearch.service.impl.QuickViewByGivenName1
org.kuali.student.core.proposal.entity.Proposal4
org.kuali.student.core.statement.entity.RefStatementRelation4
org.kuali.student.core.statement.entity.ReqComponent4
org.kuali.student.core.statement.naturallanguage.translators.NaturalLanguageTranslatorImpl2
org.kuali.student.core.statement.naturallanguage.translators.StatementParser1
org.kuali.student.core.statement.service.assembler.StatementTreeViewAssembler1

org.kuali.student.core.atp.entity.Atp

BugCategoryDetailsLinePriority
org.kuali.student.core.atp.entity.Atp.getEndDate() may expose internal representation by returning Atp.endDateMALICIOUS_CODEEI_EXPOSE_REP101Medium
org.kuali.student.core.atp.entity.Atp.getStartDate() may expose internal representation by returning Atp.startDateMALICIOUS_CODEEI_EXPOSE_REP93Medium
org.kuali.student.core.atp.entity.Atp.setEndDate(Date) may expose internal representation by storing an externally mutable object into Atp.endDateMALICIOUS_CODEEI_EXPOSE_REP2105Medium
org.kuali.student.core.atp.entity.Atp.setStartDate(Date) may expose internal representation by storing an externally mutable object into Atp.startDateMALICIOUS_CODEEI_EXPOSE_REP297Medium

org.kuali.student.core.atp.entity.DateRange

BugCategoryDetailsLinePriority
org.kuali.student.core.atp.entity.DateRange.getEndDate() may expose internal representation by returning DateRange.endDateMALICIOUS_CODEEI_EXPOSE_REP109Medium
org.kuali.student.core.atp.entity.DateRange.getStartDate() may expose internal representation by returning DateRange.startDateMALICIOUS_CODEEI_EXPOSE_REP101Medium
org.kuali.student.core.atp.entity.DateRange.setEndDate(Date) may expose internal representation by storing an externally mutable object into DateRange.endDateMALICIOUS_CODEEI_EXPOSE_REP2113Medium
org.kuali.student.core.atp.entity.DateRange.setStartDate(Date) may expose internal representation by storing an externally mutable object into DateRange.startDateMALICIOUS_CODEEI_EXPOSE_REP2105Medium

org.kuali.student.core.atp.entity.Milestone

BugCategoryDetailsLinePriority
org.kuali.student.core.atp.entity.Milestone.getMilestoneDate() may expose internal representation by returning Milestone.milestoneDateMALICIOUS_CODEEI_EXPOSE_REP87Medium
org.kuali.student.core.atp.entity.Milestone.setMilestoneDate(Date) may expose internal representation by storing an externally mutable object into Milestone.milestoneDateMALICIOUS_CODEEI_EXPOSE_REP291Medium

org.kuali.student.core.atp.service.impl.AtpServiceImpl

BugCategoryDetailsLinePriority
Method call in org.kuali.student.core.atp.service.impl.AtpServiceImpl.addDateRange(String, String, DateRangeInfo) passes null for nonnull parameter of AtpAssembler.toDateRangeInfo(DateRange)CORRECTNESSNP_NULL_PARAM_DEREF93Medium
Method call in org.kuali.student.core.atp.service.impl.AtpServiceImpl.addMilestone(String, String, MilestoneInfo) passes null for nonnull parameter of AtpAssembler.toMilestoneInfo(Milestone)CORRECTNESSNP_NULL_PARAM_DEREF137Medium
Method call in org.kuali.student.core.atp.service.impl.AtpServiceImpl.createAtp(String, String, AtpInfo) passes null for nonnull parameter of AtpAssembler.toAtpInfo(Atp)CORRECTNESSNP_NULL_PARAM_DEREF167Medium
Method org.kuali.student.core.atp.service.impl.AtpServiceImpl.CheckMissingParameters(String[], Object[]) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION101Medium

org.kuali.student.core.comment.entity.Comment

BugCategoryDetailsLinePriority
org.kuali.student.core.comment.entity.Comment.getEffectiveDate() may expose internal representation by returning Comment.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP110Medium
org.kuali.student.core.comment.entity.Comment.getExpirationDate() may expose internal representation by returning Comment.expirationDateMALICIOUS_CODEEI_EXPOSE_REP124Medium
org.kuali.student.core.comment.entity.Comment.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into Comment.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP2117Medium
org.kuali.student.core.comment.entity.Comment.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into Comment.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2131Medium

org.kuali.student.core.comment.entity.Tag

BugCategoryDetailsLinePriority
org.kuali.student.core.comment.entity.Tag.getEffectiveDate() may expose internal representation by returning Tag.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP118Medium
org.kuali.student.core.comment.entity.Tag.getExpirationDate() may expose internal representation by returning Tag.expirationDateMALICIOUS_CODEEI_EXPOSE_REP132Medium
org.kuali.student.core.comment.entity.Tag.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into Tag.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP2125Medium
org.kuali.student.core.comment.entity.Tag.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into Tag.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2139Medium

org.kuali.student.core.document.entity.Document

BugCategoryDetailsLinePriority
org.kuali.student.core.document.entity.Document.getEffectiveDate() may expose internal representation by returning Document.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP138Medium
org.kuali.student.core.document.entity.Document.getExpirationDate() may expose internal representation by returning Document.expirationDateMALICIOUS_CODEEI_EXPOSE_REP152Medium
org.kuali.student.core.document.entity.Document.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into Document.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP2145Medium
org.kuali.student.core.document.entity.Document.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into Document.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2159Medium

org.kuali.student.core.document.entity.DocumentCategory

BugCategoryDetailsLinePriority
org.kuali.student.core.document.entity.DocumentCategory.getEffectiveDate() may expose internal representation by returning DocumentCategory.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP96Medium
org.kuali.student.core.document.entity.DocumentCategory.getExpirationDate() may expose internal representation by returning DocumentCategory.expirationDateMALICIOUS_CODEEI_EXPOSE_REP110Medium
org.kuali.student.core.document.entity.DocumentCategory.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into DocumentCategory.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP2103Medium
org.kuali.student.core.document.entity.DocumentCategory.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into DocumentCategory.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2117Medium

org.kuali.student.core.document.entity.RefDocRelation

BugCategoryDetailsLinePriority
org.kuali.student.core.document.entity.RefDocRelation.getEffectiveDate() may expose internal representation by returning RefDocRelation.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP110Medium
org.kuali.student.core.document.entity.RefDocRelation.getExpirationDate() may expose internal representation by returning RefDocRelation.expirationDateMALICIOUS_CODEEI_EXPOSE_REP118Medium
org.kuali.student.core.document.entity.RefDocRelation.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into RefDocRelation.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP2114Medium
org.kuali.student.core.document.entity.RefDocRelation.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into RefDocRelation.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2122Medium

org.kuali.student.core.enumerationmanagement.entity.EnumeratedValue

BugCategoryDetailsLinePriority
org.kuali.student.core.enumerationmanagement.entity.EnumeratedValue.getEffectiveDate() may expose internal representation by returning EnumeratedValue.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP106Medium
org.kuali.student.core.enumerationmanagement.entity.EnumeratedValue.getExpirationDate() may expose internal representation by returning EnumeratedValue.expirationDateMALICIOUS_CODEEI_EXPOSE_REP114Medium
org.kuali.student.core.enumerationmanagement.entity.EnumeratedValue.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into EnumeratedValue.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP2110Medium
org.kuali.student.core.enumerationmanagement.entity.EnumeratedValue.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into EnumeratedValue.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2118Medium

org.kuali.student.core.messages.service.impl.MessageServiceMock

BugCategoryDetailsLinePriority
Method org.kuali.student.core.messages.service.impl.MessageServiceMock.getMessages(String, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR176Medium

org.kuali.student.core.organization.entity.Org

BugCategoryDetailsLinePriority
org.kuali.student.core.organization.entity.Org.getEffectiveDate() may expose internal representation by returning Org.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP113Medium
org.kuali.student.core.organization.entity.Org.getExpirationDate() may expose internal representation by returning Org.expirationDateMALICIOUS_CODEEI_EXPOSE_REP121Medium
org.kuali.student.core.organization.entity.Org.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into Org.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP2117Medium
org.kuali.student.core.organization.entity.Org.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into Org.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2125Medium

org.kuali.student.core.organization.entity.OrgHierarchy

BugCategoryDetailsLinePriority
org.kuali.student.core.organization.entity.OrgHierarchy.getEffectiveDate() may expose internal representation by returning OrgHierarchy.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP110Medium
org.kuali.student.core.organization.entity.OrgHierarchy.getExpirationDate() may expose internal representation by returning OrgHierarchy.expirationDateMALICIOUS_CODEEI_EXPOSE_REP118Medium
org.kuali.student.core.organization.entity.OrgHierarchy.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into OrgHierarchy.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP2114Medium
org.kuali.student.core.organization.entity.OrgHierarchy.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into OrgHierarchy.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2122Medium

org.kuali.student.core.organization.entity.OrgOrgRelation

BugCategoryDetailsLinePriority
org.kuali.student.core.organization.entity.OrgOrgRelation.getEffectiveDate() may expose internal representation by returning OrgOrgRelation.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP129Medium
org.kuali.student.core.organization.entity.OrgOrgRelation.getExpirationDate() may expose internal representation by returning OrgOrgRelation.expirationDateMALICIOUS_CODEEI_EXPOSE_REP137Medium
org.kuali.student.core.organization.entity.OrgOrgRelation.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into OrgOrgRelation.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP2133Medium
org.kuali.student.core.organization.entity.OrgOrgRelation.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into OrgOrgRelation.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2141Medium

org.kuali.student.core.organization.entity.OrgPersonRelation

BugCategoryDetailsLinePriority
org.kuali.student.core.organization.entity.OrgPersonRelation.getEffectiveDate() may expose internal representation by returning OrgPersonRelation.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP100Medium
org.kuali.student.core.organization.entity.OrgPersonRelation.getExpirationDate() may expose internal representation by returning OrgPersonRelation.expirationDateMALICIOUS_CODEEI_EXPOSE_REP108Medium
org.kuali.student.core.organization.entity.OrgPersonRelation.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into OrgPersonRelation.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP2104Medium
org.kuali.student.core.organization.entity.OrgPersonRelation.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into OrgPersonRelation.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2112Medium

org.kuali.student.core.organization.service.impl.OrganizationServiceImpl

BugCategoryDetailsLinePriority
Method call in org.kuali.student.core.organization.service.impl.OrganizationServiceImpl.addPositionRestrictionToOrg(String, String, OrgPositionRestrictionInfo) passes null for nonnull parameter of OrganizationAssembler.toOrgPositionRestrictionInfo(OrgPositionRestriction)CORRECTNESSNP_NULL_PARAM_DEREF102Medium
Method call in org.kuali.student.core.organization.service.impl.OrganizationServiceImpl.createOrgPersonRelation(String, String, String, OrgPersonRelationInfo) passes null for nonnull parameter of OrganizationAssembler.toOrgPersonRelationInfo(OrgPersonRelation)CORRECTNESSNP_NULL_PARAM_DEREF167Medium

org.kuali.student.core.personsearch.service.impl.PersonSearch

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.student.core.personsearch.service.impl.PersonSearch.convertEntityToPerson(KimEntityDefaultInfo, KimPrincipal), since all RuntimeException are instances of RuntimeExceptionSTYLEBC_VACUOUS_INSTANCEOF74Medium

org.kuali.student.core.personsearch.service.impl.QuickViewByGivenName

BugCategoryDetailsLinePriority
Nullcheck of ? at line 174 of value previously dereferenced in org.kuali.student.core.personsearch.service.impl.QuickViewByGivenName.search(IdentityManagementService, SearchRequest)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE151Medium

org.kuali.student.core.proposal.entity.Proposal

BugCategoryDetailsLinePriority
org.kuali.student.core.proposal.entity.Proposal.getEffectiveDate() may expose internal representation by returning Proposal.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP155Medium
org.kuali.student.core.proposal.entity.Proposal.getExpirationDate() may expose internal representation by returning Proposal.expirationDateMALICIOUS_CODEEI_EXPOSE_REP163Medium
org.kuali.student.core.proposal.entity.Proposal.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into Proposal.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP2159Medium
org.kuali.student.core.proposal.entity.Proposal.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into Proposal.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2167Medium

org.kuali.student.core.statement.entity.RefStatementRelation

BugCategoryDetailsLinePriority
org.kuali.student.core.statement.entity.RefStatementRelation.getEffectiveDate() may expose internal representation by returning RefStatementRelation.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP123Medium
org.kuali.student.core.statement.entity.RefStatementRelation.getExpirationDate() may expose internal representation by returning RefStatementRelation.expirationDateMALICIOUS_CODEEI_EXPOSE_REP131Medium
org.kuali.student.core.statement.entity.RefStatementRelation.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into RefStatementRelation.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP2127Medium
org.kuali.student.core.statement.entity.RefStatementRelation.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into RefStatementRelation.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2135Medium

org.kuali.student.core.statement.entity.ReqComponent

BugCategoryDetailsLinePriority
org.kuali.student.core.statement.entity.ReqComponent.getEffectiveDate() may expose internal representation by returning ReqComponent.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP92Medium
org.kuali.student.core.statement.entity.ReqComponent.getExpirationDate() may expose internal representation by returning ReqComponent.expirationDateMALICIOUS_CODEEI_EXPOSE_REP100Medium
org.kuali.student.core.statement.entity.ReqComponent.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into ReqComponent.effectiveDateMALICIOUS_CODEEI_EXPOSE_REP296Medium
org.kuali.student.core.statement.entity.ReqComponent.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into ReqComponent.expirationDateMALICIOUS_CODEEI_EXPOSE_REP2104Medium

org.kuali.student.core.statement.naturallanguage.translators.NaturalLanguageTranslatorImpl

BugCategoryDetailsLinePriority
Inconsistent synchronization of org.kuali.student.core.statement.naturallanguage.translators.NaturalLanguageTranslatorImpl.reqComponentTranslator; locked 75% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC50Medium
Inconsistent synchronization of org.kuali.student.core.statement.naturallanguage.translators.NaturalLanguageTranslatorImpl.statementTranslator; locked 75% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC59Medium

org.kuali.student.core.statement.naturallanguage.translators.StatementParser

BugCategoryDetailsLinePriority
Nullcheck of rootStatement at line 199 of value previously dereferenced in org.kuali.student.core.statement.naturallanguage.translators.StatementParser.traverseStatementTreeAndReduce(Statement, boolean, Statement)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE181Medium

org.kuali.student.core.statement.service.assembler.StatementTreeViewAssembler

BugCategoryDetailsLinePriority
Potentially dangerous use of non-short-circuit logic in org.kuali.student.core.statement.service.assembler.StatementTreeViewAssembler.disassemble(StatementTreeViewInfo, BaseDTOAssemblyNode$NodeOperation)STYLENS_DANGEROUS_NON_SHORT_CIRCUIT54High