The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.ProgramClientConstants.CREDENTIAL_PROGRAM should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 36 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.ProgramUtils.df isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 33 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.kuali.student.lum.program.client.core.CoreManager.eventBus from instance method new org.kuali.student.lum.program.client.core.CoreManager() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 30 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.kuali.student.lum.program.client.credential.CredentialManager.eventBus from instance method new org.kuali.student.lum.program.client.credential.CredentialManager() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 30 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.AddSpecializationEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 11 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.AfterSaveEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 13 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.ChangeViewEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 11 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.MetadataLoadedEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 15 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.ModelLoadedEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 12 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.ProgramViewEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 11 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.RemoveSpecializationEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 11 | High |
| Unread field: org.kuali.student.lum.program.client.events.RemoveSpecializationEvent.id | PERFORMANCE | URF_UNREAD_FIELD | 16 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.SpecializationCreatedEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 11 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.SpecializationSaveEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 13 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.SpecializationUpdateEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 13 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.StateChangeEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 12 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.StoreRequirementIDsEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 10 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.StoreSpecRequirementIDsEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 10 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.events.UpdateEvent.TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 13 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of MajorManager.programModel in org.kuali.student.lum.program.client.major.MajorManager.getVariationEditController() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 132 | Medium |
| Method call in org.kuali.student.lum.program.client.major.MajorManager.getVariationViewController() passes null for nonnull parameter of new org.kuali.student.lum.program.client.variation.view.VariationViewController(DataModel, ViewContext, HandlerManager, MajorController) | CORRECTNESS | NP_NULL_PARAM_DEREF | 93 | Medium |
| Write to static field org.kuali.student.lum.program.client.major.MajorManager.eventBus from instance method new org.kuali.student.lum.program.client.major.MajorManager() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 44 | High |
| Write to static field org.kuali.student.lum.program.client.major.MajorManager.eventBus from instance method org.kuali.student.lum.program.client.major.MajorManager.getMajorEditController() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 204 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.program.client.major.edit.MajorKeyProgramInfoEditConfiguration$DiplomaBinding be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 148 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of workflowUtilities at line 129 of value previously dereferenced in org.kuali.student.lum.program.client.major.proposal.MajorProposalSummaryConfiguration.buildLayout() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 129 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.lum.program.client.requirements.ProgramRequirementsDataModel$5.onSuccess(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 245 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.kuali.student.lum.program.client.requirements.ProgramRequirementsDataModel$requirementState doesn't start with an upper case letter | BAD_PRACTICE | NM_CLASS_NAMING_CONVENTION | 46 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.lum.program.client.requirements.ProgramRequirementsManageView.originalReqCompNL | PERFORMANCE | URF_UNREAD_FIELD | 183 | Medium |
| Unused field: org.kuali.student.lum.program.client.requirements.ProgramRequirementsManageView.originalLogicExpression | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.client.requirements.ProgramRequirementsSummaryView.tempStmtTreeID should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 68 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to row in org.kuali.student.lum.program.client.variation.edit.VariationEditController$3.onEvent(ModelLoadedEvent) | STYLE | DLS_DEAD_LOCAL_STORE | 90 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.program.client.variation.edit.VariationInformationEditConfiguration$DiplomaBinding be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 116 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.lum.program.client.versions.ProgramSelectVersionsView.metadataServiceAsync | PERFORMANCE | URF_UNREAD_FIELD | 38 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.lum.program.client.widgets.ProgramSideBar.viewContext | PERFORMANCE | URF_UNREAD_FIELD | 71 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.lum.program.server.CoreProgramStateChangeServiceImpl.updatePreviousVersions(CoreProgramInfo, String, String, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 114 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.lum.program.server.CredentialProgramStateChangeServiceImpl.updatePreviousVersions(CredentialProgramInfo, String, String, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 116 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.server.MajorDisciplineProposalRpcServlet.isProposal(String, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 225 | Medium |
| Method org.kuali.student.lum.program.server.MajorDisciplineProposalRpcServlet.storeProgramRequirements(Map, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 73 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.program.server.MajorDisciplineRpcServlet.isProposal(String, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 255 | Medium |
| Method org.kuali.student.lum.program.server.MajorDisciplineRpcServlet.storeProgramRequirements(Map, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 109 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.lum.program.server.MajorDisciplineStateChangeServiceImpl.updatePreviousVersions(MajorDisciplineInfo, String, String, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 179 | Medium |
