The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of cluSetInfo in org.kuali.student.lum.lu.assembly.CluSetManagementAssembler.upWrap(CluSetInfo) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 199 | Medium |
| Redundant nullcheck of saveValidationResults which is known to be null in org.kuali.student.lum.lu.assembly.CluSetManagementAssembler.saveCluSet(Data) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 299 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to a in org.kuali.student.lum.lu.assembly.CluSetManagementIdTranslatorAssemblerFilter.translateIds(Data, AssemblerFilter$AssemblerManagerAccessable) | STYLE | DLS_DEAD_LOCAL_STORE | 60 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.lu.ui.browseprogram.client.views.BrowseProgramView$ViewCourseCallback be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 177 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.student.lum.lu.ui.course.client.controllers.CourseProposalController to org.kuali.student.lum.lu.ui.course.client.controllers.CourseAdminController in org.kuali.student.lum.lu.ui.course.client.configuration.CourseAdminConfigurer.configure(CourseProposalController) | STYLE | BC_UNCONFIRMED_CAST | 58 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.student.lum.lu.ui.course.client.controllers.CourseProposalController to org.kuali.student.lum.lu.ui.course.client.controllers.CourseAdminRetireController in org.kuali.student.lum.lu.ui.course.client.configuration.CourseAdminRetireConfigurer.configure(CourseProposalController) | STYLE | BC_UNCONFIRMED_CAST | 46 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.student.lum.lu.ui.course.client.controllers.CourseProposalController to org.kuali.student.lum.lu.ui.course.client.controllers.CourseAdminWithoutVersionController in org.kuali.student.lum.lu.ui.course.client.configuration.CourseAdminWithoutVersionConfigurer.configure(CourseProposalController) | STYLE | BC_UNCONFIRMED_CAST | 56 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.lu.ui.course.client.configuration.CourseProposalConfigurer$PersonList be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 814 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.lu.ui.course.client.configuration.CourseProposalConfigurer$ProposerPersonList be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 862 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of statementTreeViewInfos in org.kuali.student.lum.lu.ui.course.client.configuration.CourseSummaryConfigurer$6.setWidgetValue(FlowPanel, DataModel, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 881 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.lu.ui.course.client.configuration.CourseSummaryConfigurer$8.setWidgetValue(HTML, DataModel, String) ignores return value of String.replace(CharSequence, CharSequence) | CORRECTNESS | RV_RETURN_VALUE_IGNORED | 1207 | High |
| org.kuali.student.lum.lu.ui.course.client.configuration.CourseSummaryConfigurer$8.setWidgetValue(HTML, DataModel, String) ignores return value of String.trim() | CORRECTNESS | RV_RETURN_VALUE_IGNORED | 1208 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to idType in org.kuali.student.lum.lu.ui.course.client.controllers.ViewCourseController.init(Callback) | STYLE | DLS_DEAD_LOCAL_STORE | 185 | Medium |
| Unread field: org.kuali.student.lum.lu.ui.course.client.controllers.ViewCourseController.REFERENCE_TYPE; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 87 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on Throwable.getStackTrace() in org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsDataModel.getStmtTypeInfo(String) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 299 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsDataModel$5.onSuccess(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 202 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsDataModel$requirementState doesn't start with an upper case letter | BAD_PRACTICE | NM_CLASS_NAMING_CONVENTION | 46 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsManageView.originalReqCompNL | PERFORMANCE | URF_UNREAD_FIELD | 182 | Medium |
| Unused field: org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsManageView.originalLogicExpression | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.lum.lu.ui.course.client.views.CurriculumHomeView.cluProposalRpcServiceAsync | PERFORMANCE | URF_UNREAD_FIELD | 27 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.lum.lu.ui.course.client.views.SelectVersionsView.metadataServiceAsync | PERFORMANCE | URF_UNREAD_FIELD | 40 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet defines non-transient non-serializable instance field courseService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet defines non-transient non-serializable instance field luService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet defines non-transient non-serializable instance field stateChangeService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet defines non-transient non-serializable instance field statementService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Method org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet.storeCourseStatements(String, String, Map, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 65 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.lu.ui.course.server.gwt.CourseStateChangeServiceImpl.changeState(String, String, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 49 | Medium |
| Method org.kuali.student.lum.lu.ui.course.server.gwt.CourseStateChangeServiceImpl.updateCourseVersionStates(CourseInfo, String, CourseInfo, String, boolean, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 188 | Medium |
| Call to equals() comparing different types in org.kuali.student.lum.lu.ui.course.server.gwt.CourseStateChangeServiceImpl.updateCourseVersionStates(CourseInfo, String, CourseInfo, String, boolean, String) | CORRECTNESS | EC_UNRELATED_TYPES | 151 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.student.lum.lu.ui.course.server.gwt.CreditCourseProposalRpcGwtServlet defines non-transient non-serializable instance field copyCourseService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of cluType at line 286 of value previously dereferenced in org.kuali.student.lum.lu.ui.dependency.client.views.DependencyAnalysisView$5.onSuccess(SearchResult) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 286 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from com.google.gwt.user.client.ui.Widget to org.kuali.student.lum.lu.ui.dependency.client.widgets.DependencyResultPanel$DependencyTypeSection in org.kuali.student.lum.lu.ui.dependency.client.widgets.DependencyResultPanel$DependencySection.addWidget(Widget) | STYLE | BC_UNCONFIRMED_CAST | 163 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.student.lum.lu.ui.dependency.server.DependencyAnalysisRpcServlet defines non-transient non-serializable instance field programService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.lum.lu.ui.dependency.server.DependencyAnalysisRpcServlet defines non-transient non-serializable instance field statementService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of result at line 49 of value previously dereferenced in org.kuali.student.lum.lu.ui.main.client.configuration.AcknowledgeView$1.onSuccess(Map) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 48 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.lum.lu.ui.main.client.configuration.CopyCourseSearchPanel.validationCallback | PERFORMANCE | URF_UNREAD_FIELD | 35 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.lu.ui.main.client.controllers.ApplicationController.contentPanel isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 30 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.lu.ui.main.client.controllers.CurriculumHomeController$RunAsyncGetView be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 80 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of result at line 125 of value previously dereferenced in org.kuali.student.lum.lu.ui.main.client.widgets.ApplicationHeader$1.onSuccess(Map) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 124 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.lum.lu.ui.tools.client.configuration.CatalogBrowserConfigurer.formatMetadata(Metadata, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 104 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to cluRangeFieldEditDescriptor in org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer.addClusetDetailsSections(SectionView, String) | STYLE | DLS_DEAD_LOCAL_STORE | 135 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer$CluSetEditOptionList be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 617 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer$ModelIdPlaceHolder be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 603 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsManagementController$9.exec(List) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 314 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.lu.ui.tools.client.configuration.ClusetView$1$1.onSuccess(Metadata) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 110 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.lu.ui.tools.client.widgets.BrowsePanel$SelectButtonClickHandler be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 114 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.lu.ui.tools.client.widgets.KSBrowser$ExecuteNextSearchCallback be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 91 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.student.lum.lu.ui.tools.client.widgets.KSBrowser$ViewCourseCallback be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 117 | Medium |
| Unread field: org.kuali.student.lum.lu.ui.tools.client.widgets.KSBrowser$ViewCourseCallback.controller | PERFORMANCE | URF_UNREAD_FIELD | 118 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetDataService.isAuthorized(PermissionType, Map) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 75 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of cluSetInfo in org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetManagementRpcGwtServlet.upWrap(CluSetInfo) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 147 | Medium |
| Method org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetManagementRpcGwtServlet.getCluInformations(List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 209 | Medium |
| Class org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetManagementRpcGwtServlet defines non-transient non-serializable instance field lrcService | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetManagementRpcGwtServlet defines non-transient non-serializable instance field luService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
