The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.assembly.data.Data is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 40 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.assembly.data.Data$DataValue.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 103 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.assembly.data.Data$DateValue.get() may expose internal representation by returning Data$DateValue.value | MALICIOUS_CODE | EI_EXPOSE_REP | 124 | Medium |
| new org.kuali.student.common.assembly.data.Data$DateValue(Date) may expose internal representation by storing an externally mutable object into Data$DateValue.value | MALICIOUS_CODE | EI_EXPOSE_REP2 | 119 | Medium |
| org.kuali.student.common.assembly.data.Data$DateValue.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 135 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.assembly.data.Data$DoubleValue.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 167 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.assembly.data.Data$FloatValue.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 199 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.assembly.data.Data$IntegerValue.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 287 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.assembly.data.Data$LongValue.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 326 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.assembly.data.Data$ShortValue.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 372 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.assembly.data.Data$TimeValue.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 525 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.assembly.data.Data$TimestampValue.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 493 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Suspicious comparison of Integer references in org.kuali.student.common.assembly.dictionary.MetadataFormatter.calcLength(Metadata) | CORRECTNESS | RC_REF_COMPARISON | 598 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.kuali.student.common.assembly.dictionary.MetadataServiceImpl.processCaseConstraint(ConstraintMetadata, CaseConstraint, String, String, String, String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 392 | Medium |
| Possible null pointer dereference of paramType on path that might be infeasible in org.kuali.student.common.assembly.dictionary.MetadataServiceImpl.matchesType(String, String) | STYLE | NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE | 660 | Medium |
| Method org.kuali.student.common.assembly.dictionary.MetadataServiceImpl.addLookupstoMetadata(String, Metadata, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 691 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.common.assembly.dictionary.MetadataServiceImpl$RecursionCounter.increment(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 65 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to value in org.kuali.student.common.assembly.dictionary.old.MetadataServiceImpl.convertDefaultValue(Data$DataType, Object) | STYLE | DLS_DEAD_LOCAL_STORE | 437 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.common.assembly.dictionary.old.MetadataServiceImpl$RecursionCounter.increment(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 73 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of metadata which is known to be null in org.kuali.student.common.assembly.transform.TransformationManager.transform(Object, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 35 | Medium |
| Redundant nullcheck of metadata which is known to be null in org.kuali.student.common.assembly.transform.TransformationManager.transform(Object, String, Map) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 46 | Medium |
| Redundant nullcheck of metadata which is known to be null in org.kuali.student.common.assembly.transform.TransformationManager.transform(Data, Class) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.dictionary.service.impl.DictionaryCreator.execute(Class, String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 68 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.dictionary.service.impl.DictionaryFormatter$FieldDefinitionNameComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 221 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.dictionary.service.impl.DictionaryServiceImpl.getDictionaryContext() may expose internal representation by returning DictionaryServiceImpl.dictionaryContext | MALICIOUS_CODE | EI_EXPOSE_REP | 63 | Medium |
| new org.kuali.student.common.dictionary.service.impl.DictionaryServiceImpl(String[]) may expose internal representation by storing an externally mutable object into DictionaryServiceImpl.dictionaryContext | MALICIOUS_CODE | EI_EXPOSE_REP2 | 34 | Medium |
| org.kuali.student.common.dictionary.service.impl.DictionaryServiceImpl.setDictionaryContext(String[]) may expose internal representation by storing an externally mutable object into DictionaryServiceImpl.dictionaryContext | MALICIOUS_CODE | EI_EXPOSE_REP2 | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Double assignment of os in org.kuali.student.common.dictionary.service.impl.DictionaryTesterHelper.doTestOnClass(String, ApplicationContext) | STYLE | SA_LOCAL_DOUBLE_ASSIGNMENT | 138 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to pattern in org.kuali.student.common.dictionary.service.impl.DictionaryValidator.validateValidChars(FieldDefinition, ValidCharsConstraint) | STYLE | DLS_DEAD_LOCAL_STORE | 312 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.dictionary.service.impl.old.DictionaryServiceSpringImpl.getDictionaryContext() may expose internal representation by returning DictionaryServiceSpringImpl.dictionaryContext | MALICIOUS_CODE | EI_EXPOSE_REP | 89 | Medium |
| new org.kuali.student.common.dictionary.service.impl.old.DictionaryServiceSpringImpl(String[]) may expose internal representation by storing an externally mutable object into DictionaryServiceSpringImpl.dictionaryContext | MALICIOUS_CODE | EI_EXPOSE_REP2 | 52 | Medium |
| org.kuali.student.common.dictionary.service.impl.old.DictionaryServiceSpringImpl.setDictionaryContext(String[]) may expose internal representation by storing an externally mutable object into DictionaryServiceSpringImpl.dictionaryContext | MALICIOUS_CODE | EI_EXPOSE_REP2 | 93 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.entity.BaseType.getEffectiveDate() may expose internal representation by returning BaseType.effectiveDate | MALICIOUS_CODE | EI_EXPOSE_REP | 39 | Medium |
| org.kuali.student.common.entity.BaseType.getExpirationDate() may expose internal representation by returning BaseType.expirationDate | MALICIOUS_CODE | EI_EXPOSE_REP | 47 | Medium |
| org.kuali.student.common.entity.BaseType.setEffectiveDate(Date) may expose internal representation by storing an externally mutable object into BaseType.effectiveDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 43 | Medium |
| org.kuali.student.common.entity.BaseType.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into BaseType.expirationDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 51 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.entity.Meta.getCreateTime() may expose internal representation by returning Meta.createTime | MALICIOUS_CODE | EI_EXPOSE_REP | 53 | Medium |
| org.kuali.student.common.entity.Meta.getUpdateTime() may expose internal representation by returning Meta.updateTime | MALICIOUS_CODE | EI_EXPOSE_REP | 69 | Medium |
| org.kuali.student.common.entity.Meta.setCreateTime(Date) may expose internal representation by storing an externally mutable object into Meta.createTime | MALICIOUS_CODE | EI_EXPOSE_REP2 | 57 | Medium |
| org.kuali.student.common.entity.Meta.setUpdateTime(Date) may expose internal representation by storing an externally mutable object into Meta.updateTime | MALICIOUS_CODE | EI_EXPOSE_REP2 | 73 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.entity.Version.getCurrentVersionEnd() may expose internal representation by returning Version.currentVersionEnd | MALICIOUS_CODE | EI_EXPOSE_REP | 41 | Medium |
| org.kuali.student.common.entity.Version.getCurrentVersionStart() may expose internal representation by returning Version.currentVersionStart | MALICIOUS_CODE | EI_EXPOSE_REP | 33 | Medium |
| org.kuali.student.common.entity.Version.setCurrentVersionEnd(Date) may expose internal representation by storing an externally mutable object into Version.currentVersionEnd | MALICIOUS_CODE | EI_EXPOSE_REP2 | 45 | Medium |
| org.kuali.student.common.entity.Version.setCurrentVersionStart(Date) may expose internal representation by storing an externally mutable object into Version.currentVersionStart | MALICIOUS_CODE | EI_EXPOSE_REP2 | 37 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method call in org.kuali.student.common.search.service.impl.CrossSearchManager.meetsCriteria(Map, CrossSearchTypeInfo, JoinCriteriaInfo) passes null for nonnull parameter of compare(CrossSearchManager$DataType, String, String, JoinComparisonInfo$ComparisonType) | CORRECTNESS | NP_NULL_PARAM_DEREF | 321 | Medium |
| Method call in org.kuali.student.common.search.service.impl.CrossSearchManager.meetsCriteria(Map, CrossSearchTypeInfo, JoinCriteriaInfo) passes null for nonnull parameter of compare(CrossSearchManager$DataType, String, String, JoinComparisonInfo$ComparisonType) | CORRECTNESS | NP_NULL_PARAM_DEREF | 321 | Medium |
| Method call in org.kuali.student.common.search.service.impl.CrossSearchManager.meetsCriteria(Map, CrossSearchTypeInfo, JoinCriteriaInfo) passes null for nonnull parameter of compare(CrossSearchManager$DataType, String, String, JoinComparisonInfo$ComparisonType) | CORRECTNESS | NP_NULL_PARAM_DEREF | 321 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method call in org.kuali.student.common.search.service.impl.CrossSearchManager$SearchResultRowComparator.compare(SearchResultRow, SearchResultRow) passes null for nonnull parameter of Integer.parseInt(String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 194 | Medium |
| Method call in org.kuali.student.common.search.service.impl.CrossSearchManager$SearchResultRowComparator.compare(SearchResultRow, SearchResultRow) passes null for nonnull parameter of Integer.parseInt(String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 195 | Medium |
| Method call in org.kuali.student.common.search.service.impl.CrossSearchManager$SearchResultRowComparator.compare(SearchResultRow, SearchResultRow) passes null for nonnull parameter of java.text.DateFormat.parse(String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 206 | Medium |
| Method call in org.kuali.student.common.search.service.impl.CrossSearchManager$SearchResultRowComparator.compare(SearchResultRow, SearchResultRow) passes null for nonnull parameter of java.text.DateFormat.parse(String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 207 | Medium |
| org.kuali.student.common.search.service.impl.CrossSearchManager$SearchResultRowComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 161 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: org.kuali.student.common.search.service.impl.SearchConfigFormatter.os | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.student.common.search.service.impl.SearchConfigValidator.queryMap | PERFORMANCE | URF_UNREAD_FIELD | 18 | Medium |
| Unread field: org.kuali.student.common.search.service.impl.SearchConfigValidator.searchInfoTypeMap | PERFORMANCE | URF_UNREAD_FIELD | 17 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant comparison of non-null value to null in org.kuali.student.common.validator.DefaultValidatorImpl.validateField(List, FieldDefinition, ObjectStructureDefinition, ConstraintDataProvider, Stack, Object, ObjectStructureDefinition) | STYLE | RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE | 225 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.kuali.student.common.validator.ValidatorFactory.validatorList; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 81 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.validator.ValidatorUtils.getBoolean(Object) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 191 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.student.common.validator.old.BeanConstraintDataProvider.initialize(Object) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 48 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant comparison of non-null value to null in org.kuali.student.common.validator.old.Validator.validateField(Field, Type, State, ObjectStructure, ConstraintDataProvider, Stack) | STYLE | RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE | 265 | Medium |
| Nullcheck of value at line 452 of value previously dereferenced in org.kuali.student.common.validator.old.Validator.processConstraint(List, ConstraintSelector, Field, Type, State, ObjectStructure, Object, ConstraintDataProvider, Validator$BaseConstraintBean, Stack) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 435 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.student.common.validator.old.ValidatorUtils.getBoolean(Object) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 176 | Medium |
