FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
3083600

Files

ClassBugs
org.kuali.student.lum.program.client.ProgramClientConstants1
org.kuali.student.lum.program.client.ProgramUtils1
org.kuali.student.lum.program.client.core.CoreManager1
org.kuali.student.lum.program.client.credential.CredentialManager1
org.kuali.student.lum.program.client.events.AddSpecializationEvent1
org.kuali.student.lum.program.client.events.AfterSaveEvent1
org.kuali.student.lum.program.client.events.ChangeViewEvent1
org.kuali.student.lum.program.client.events.MetadataLoadedEvent1
org.kuali.student.lum.program.client.events.ModelLoadedEvent1
org.kuali.student.lum.program.client.events.ProgramViewEvent1
org.kuali.student.lum.program.client.events.RemoveSpecializationEvent2
org.kuali.student.lum.program.client.events.SpecializationCreatedEvent1
org.kuali.student.lum.program.client.events.SpecializationSaveEvent1
org.kuali.student.lum.program.client.events.SpecializationUpdateEvent1
org.kuali.student.lum.program.client.events.StateChangeEvent1
org.kuali.student.lum.program.client.events.StoreRequirementIDsEvent1
org.kuali.student.lum.program.client.events.StoreSpecRequirementIDsEvent1
org.kuali.student.lum.program.client.events.UpdateEvent1
org.kuali.student.lum.program.client.major.ActionType1
org.kuali.student.lum.program.client.major.MajorManager1
org.kuali.student.lum.program.client.major.edit.MajorInformationEditConfiguration$DiplomaBinding1
org.kuali.student.lum.program.client.requirements.ProgramRequirementsDataModel$51
org.kuali.student.lum.program.client.requirements.ProgramRequirementsDataModel$requirementState1
org.kuali.student.lum.program.client.requirements.ProgramRequirementsManageView2
org.kuali.student.lum.program.client.requirements.ProgramRequirementsSummaryView1
org.kuali.student.lum.program.client.variation.edit.VariationEditController$31
org.kuali.student.lum.program.client.variation.edit.VariationInformationEditConfiguration$DiplomaBinding1
org.kuali.student.lum.program.client.versions.ProgramSelectVersionsView1
org.kuali.student.lum.program.client.widgets.ProgramSideBar1
org.kuali.student.lum.program.server.MajorDisciplineRpcServlet3
org.kuali.student.lum.program.server.transform.CoreCredentialProgramFilter2

org.kuali.student.lum.program.client.ProgramClientConstants

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.ProgramClientConstants.CREDENTIAL_PROGRAM should be package protectedMALICIOUS_CODEMS_PKGPROTECT36Medium

org.kuali.student.lum.program.client.ProgramUtils

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.ProgramUtils.df isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL35High

org.kuali.student.lum.program.client.core.CoreManager

BugCategoryDetailsLinePriority
Write to static field org.kuali.student.lum.program.client.core.CoreManager.eventBus from instance method new org.kuali.student.lum.program.client.core.CoreManager()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD30High

org.kuali.student.lum.program.client.credential.CredentialManager

BugCategoryDetailsLinePriority
Write to static field org.kuali.student.lum.program.client.credential.CredentialManager.eventBus from instance method new org.kuali.student.lum.program.client.credential.CredentialManager()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD30High

org.kuali.student.lum.program.client.events.AddSpecializationEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.AddSpecializationEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL11High

org.kuali.student.lum.program.client.events.AfterSaveEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.AfterSaveEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL13High

org.kuali.student.lum.program.client.events.ChangeViewEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.ChangeViewEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL11High

org.kuali.student.lum.program.client.events.MetadataLoadedEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.MetadataLoadedEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL15High

org.kuali.student.lum.program.client.events.ModelLoadedEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.ModelLoadedEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL12High

org.kuali.student.lum.program.client.events.ProgramViewEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.ProgramViewEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL11High

org.kuali.student.lum.program.client.events.RemoveSpecializationEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.RemoveSpecializationEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL11High
Unread field: org.kuali.student.lum.program.client.events.RemoveSpecializationEvent.idPERFORMANCEURF_UNREAD_FIELD16Medium

org.kuali.student.lum.program.client.events.SpecializationCreatedEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.SpecializationCreatedEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL11High

org.kuali.student.lum.program.client.events.SpecializationSaveEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.SpecializationSaveEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL13High

org.kuali.student.lum.program.client.events.SpecializationUpdateEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.SpecializationUpdateEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL13High

org.kuali.student.lum.program.client.events.StateChangeEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.StateChangeEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL12High

org.kuali.student.lum.program.client.events.StoreRequirementIDsEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.StoreRequirementIDsEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL10High

org.kuali.student.lum.program.client.events.StoreSpecRequirementIDsEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.StoreSpecRequirementIDsEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL10High

org.kuali.student.lum.program.client.events.UpdateEvent

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.events.UpdateEvent.TYPE isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL13High

org.kuali.student.lum.program.client.major.ActionType

BugCategoryDetailsLinePriority
Incorrect lazy initialization and update of static field org.kuali.student.lum.program.client.major.ActionType.values in org.kuali.student.lum.program.client.major.ActionType.getValues()MT_CORRECTNESSLI_LAZY_INIT_UPDATE_STATIC30High

org.kuali.student.lum.program.client.major.MajorManager

BugCategoryDetailsLinePriority
Write to static field org.kuali.student.lum.program.client.major.MajorManager.eventBus from instance method new org.kuali.student.lum.program.client.major.MajorManager()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD42High

org.kuali.student.lum.program.client.major.edit.MajorInformationEditConfiguration$DiplomaBinding

BugCategoryDetailsLinePriority
Should org.kuali.student.lum.program.client.major.edit.MajorInformationEditConfiguration$DiplomaBinding be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC136Medium

org.kuali.student.lum.program.client.requirements.ProgramRequirementsDataModel$5

BugCategoryDetailsLinePriority
Method org.kuali.student.lum.program.client.requirements.ProgramRequirementsDataModel$5.onSuccess(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR247Medium

org.kuali.student.lum.program.client.requirements.ProgramRequirementsDataModel$requirementState

BugCategoryDetailsLinePriority
The class name org.kuali.student.lum.program.client.requirements.ProgramRequirementsDataModel$requirementState doesn't start with an upper case letterBAD_PRACTICENM_CLASS_NAMING_CONVENTION48Medium

org.kuali.student.lum.program.client.requirements.ProgramRequirementsManageView

BugCategoryDetailsLinePriority
Unread field: org.kuali.student.lum.program.client.requirements.ProgramRequirementsManageView.originalReqCompNLPERFORMANCEURF_UNREAD_FIELD182Medium
Unused field: org.kuali.student.lum.program.client.requirements.ProgramRequirementsManageView.originalLogicExpressionPERFORMANCEUUF_UNUSED_FIELDMedium

org.kuali.student.lum.program.client.requirements.ProgramRequirementsSummaryView

BugCategoryDetailsLinePriority
org.kuali.student.lum.program.client.requirements.ProgramRequirementsSummaryView.tempStmtTreeID should be package protectedMALICIOUS_CODEMS_PKGPROTECT68Medium

org.kuali.student.lum.program.client.variation.edit.VariationEditController$3

BugCategoryDetailsLinePriority
Dead store to row in org.kuali.student.lum.program.client.variation.edit.VariationEditController$3.onEvent(ModelLoadedEvent)STYLEDLS_DEAD_LOCAL_STORE89Medium

org.kuali.student.lum.program.client.variation.edit.VariationInformationEditConfiguration$DiplomaBinding

BugCategoryDetailsLinePriority
Should org.kuali.student.lum.program.client.variation.edit.VariationInformationEditConfiguration$DiplomaBinding be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC114Medium

org.kuali.student.lum.program.client.versions.ProgramSelectVersionsView

BugCategoryDetailsLinePriority
Unread field: org.kuali.student.lum.program.client.versions.ProgramSelectVersionsView.metadataServiceAsyncPERFORMANCEURF_UNREAD_FIELD38Medium

org.kuali.student.lum.program.client.widgets.ProgramSideBar

BugCategoryDetailsLinePriority
Unread field: org.kuali.student.lum.program.client.widgets.ProgramSideBar.viewContextPERFORMANCEURF_UNREAD_FIELD68Medium

org.kuali.student.lum.program.server.MajorDisciplineRpcServlet

BugCategoryDetailsLinePriority
Class org.kuali.student.lum.program.server.MajorDisciplineRpcServlet defines non-transient non-serializable instance field programServiceBAD_PRACTICESE_BAD_FIELDMedium
Class org.kuali.student.lum.program.server.MajorDisciplineRpcServlet defines non-transient non-serializable instance field statementServiceBAD_PRACTICESE_BAD_FIELDMedium
Method org.kuali.student.lum.program.server.MajorDisciplineRpcServlet.storeProgramRequirements(Map, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR49Medium

org.kuali.student.lum.program.server.transform.CoreCredentialProgramFilter

BugCategoryDetailsLinePriority
Unread field: org.kuali.student.lum.program.server.transform.CoreCredentialProgramFilter.programServicePERFORMANCEURF_UNREAD_FIELD71Medium
Unused field: org.kuali.student.lum.program.server.transform.CoreCredentialProgramFilter.metadataServicePERFORMANCEUUF_UNUSED_FIELDMedium