FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
316 43 0 0

Files

Class Bugs
org.kuali.student.lum.lu.assembly.CluSetManagementAssembler 2
org.kuali.student.lum.lu.assembly.CluSetManagementIdTranslatorAssemblerFilter 1
org.kuali.student.lum.lu.ui.course.client.configuration.CourseConfigurer 4
org.kuali.student.lum.lu.ui.course.client.configuration.CourseConfigurer$PersonList 1
org.kuali.student.lum.lu.ui.course.client.configuration.CourseConfigurer$ProposerPersonList 1
org.kuali.student.lum.lu.ui.course.client.configuration.CourseSummaryConfigurer$8 2
org.kuali.student.lum.lu.ui.course.client.controllers.ViewCourseController 2
org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsDataModel 1
org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsDataModel$5 1
org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsDataModel$requirementState 1
org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsManageView 2
org.kuali.student.lum.lu.ui.course.client.views.CurriculumHomeView 1
org.kuali.student.lum.lu.ui.course.client.views.SelectVersionsView 1
org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet 6
org.kuali.student.lum.lu.ui.main.client.controllers.ApplicationController 1
org.kuali.student.lum.lu.ui.main.client.widgets.ApplicationHeader$1 1
org.kuali.student.lum.lu.ui.tools.client.configuration.CatalogBrowserConfigurer 1
org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer 1
org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer$CluSetEditOptionList 1
org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer$ModelIdPlaceHolder 1
org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsManagementController$9 1
org.kuali.student.lum.lu.ui.tools.client.configuration.ClusetView$1$1 1
org.kuali.student.lum.lu.ui.tools.client.widgets.BrowsePanel$SelectButtonClickHandler 1
org.kuali.student.lum.lu.ui.tools.client.widgets.KSBrowser$ExecuteNextSearchCallback 1
org.kuali.student.lum.lu.ui.tools.client.widgets.KSBrowser$ViewCourseCallback 2
org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetDataService 1
org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetManagementRpcGwtServlet 4

org.kuali.student.lum.lu.assembly.CluSetManagementAssembler

Bug Category Details Line Priority
Possible null pointer dereference of cluSetInfo in org.kuali.student.lum.lu.assembly.CluSetManagementAssembler.upWrap(CluSetInfo) CORRECTNESS NP_NULL_ON_SOME_PATH 198 Medium
Redundant nullcheck of saveValidationResults which is known to be null in org.kuali.student.lum.lu.assembly.CluSetManagementAssembler.saveCluSet(Data) STYLE RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE 298 Medium

org.kuali.student.lum.lu.assembly.CluSetManagementIdTranslatorAssemblerFilter

Bug Category Details Line Priority
Dead store to a in org.kuali.student.lum.lu.assembly.CluSetManagementIdTranslatorAssemblerFilter.translateIds(Data, AssemblerFilter$AssemblerManagerAccessable) STYLE DLS_DEAD_LOCAL_STORE 60 Medium

org.kuali.student.lum.lu.ui.course.client.configuration.CourseConfigurer

Bug Category Details Line Priority
Field CourseConfigurer.groupName masks field in superclass org.kuali.student.common.ui.client.configurable.mvc.Configurer CORRECTNESS MF_CLASS_MASKS_FIELD 113-1175 High
Field CourseConfigurer.modelDefinition masks field in superclass org.kuali.student.common.ui.client.configurable.mvc.Configurer CORRECTNESS MF_CLASS_MASKS_FIELD 113-1175 Medium
Field CourseConfigurer.state masks field in superclass org.kuali.student.common.ui.client.configurable.mvc.Configurer CORRECTNESS MF_CLASS_MASKS_FIELD 113-1175 Medium
Field CourseConfigurer.type masks field in superclass org.kuali.student.common.ui.client.configurable.mvc.Configurer CORRECTNESS MF_CLASS_MASKS_FIELD 113-1175 Medium

org.kuali.student.lum.lu.ui.course.client.configuration.CourseConfigurer$PersonList

Bug Category Details Line Priority
Should org.kuali.student.lum.lu.ui.course.client.configuration.CourseConfigurer$PersonList be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 775-817 Medium

org.kuali.student.lum.lu.ui.course.client.configuration.CourseConfigurer$ProposerPersonList

Bug Category Details Line Priority
Should org.kuali.student.lum.lu.ui.course.client.configuration.CourseConfigurer$ProposerPersonList be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 822-826 Medium

org.kuali.student.lum.lu.ui.course.client.configuration.CourseSummaryConfigurer$8

Bug Category Details Line Priority
org.kuali.student.lum.lu.ui.course.client.configuration.CourseSummaryConfigurer$8.setWidgetValue(HTML, DataModel, String) ignores return value of String.replace(CharSequence, CharSequence) CORRECTNESS RV_RETURN_VALUE_IGNORED 825 High
org.kuali.student.lum.lu.ui.course.client.configuration.CourseSummaryConfigurer$8.setWidgetValue(HTML, DataModel, String) ignores return value of String.trim() CORRECTNESS RV_RETURN_VALUE_IGNORED 826 High

org.kuali.student.lum.lu.ui.course.client.controllers.ViewCourseController

Bug Category Details Line Priority
Dead store to idType in org.kuali.student.lum.lu.ui.course.client.controllers.ViewCourseController.init(Callback) STYLE DLS_DEAD_LOCAL_STORE 175 Medium
Unread field: org.kuali.student.lum.lu.ui.course.client.controllers.ViewCourseController.REFERENCE_TYPE; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 82 Medium

org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsDataModel

Bug Category Details Line Priority
Invocation of toString on Throwable.getStackTrace() in org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsDataModel.getStmtTypeInfo(String) CORRECTNESS DMI_INVOKING_TOSTRING_ON_ARRAY 298 Medium

org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsDataModel$5

Bug Category Details Line Priority
Method org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsDataModel$5.onSuccess(Map) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 198 Medium

org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsDataModel$requirementState

Bug Category Details Line Priority
The class name org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsDataModel$requirementState doesn't start with an upper case letter BAD_PRACTICE NM_CLASS_NAMING_CONVENTION 46 Medium

org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsManageView

Bug Category Details Line Priority
Unread field: org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsManageView.originalReqCompNL PERFORMANCE URF_UNREAD_FIELD 173 Medium
Unused field: org.kuali.student.lum.lu.ui.course.client.requirements.CourseRequirementsManageView.originalLogicExpression PERFORMANCE UUF_UNUSED_FIELD Not available Medium

org.kuali.student.lum.lu.ui.course.client.views.CurriculumHomeView

Bug Category Details Line Priority
Private method org.kuali.student.lum.lu.ui.course.client.views.CurriculumHomeView.addIfPermitted(PermissionType, String) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 78-79 Medium

org.kuali.student.lum.lu.ui.course.client.views.SelectVersionsView

Bug Category Details Line Priority
Unread field: org.kuali.student.lum.lu.ui.course.client.views.SelectVersionsView.metadataServiceAsync PERFORMANCE URF_UNREAD_FIELD 40 Medium

org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet

Bug Category Details Line Priority
Dead store to currVerPrevState in org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet.updateCourseVersionStates(CourseInfo, String, CourseInfo, String, boolean, Date) STYLE DLS_DEAD_LOCAL_STORE 166 Medium
org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet.changeState(String, String, Date) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 143 Medium
Method org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet.updateCourseVersionStates(CourseInfo, String, CourseInfo, String, boolean, Date) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 198 Medium
Class org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet defines non-transient non-serializable instance field courseService BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet defines non-transient non-serializable instance field statementService BAD_PRACTICE SE_BAD_FIELD Not available Medium
Method org.kuali.student.lum.lu.ui.course.server.gwt.CourseRpcGwtServlet.storeCourseStatements(String, Map, Map) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 65 Medium

org.kuali.student.lum.lu.ui.main.client.controllers.ApplicationController

Bug Category Details Line Priority
org.kuali.student.lum.lu.ui.main.client.controllers.ApplicationController.contentPanel isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 20 High

org.kuali.student.lum.lu.ui.main.client.widgets.ApplicationHeader$1

Bug Category Details Line Priority
Nullcheck of result at line 122 of value previously dereferenced in org.kuali.student.lum.lu.ui.main.client.widgets.ApplicationHeader$1.onSuccess(Map) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 121 Medium

org.kuali.student.lum.lu.ui.tools.client.configuration.CatalogBrowserConfigurer

Bug Category Details Line Priority
Method org.kuali.student.lum.lu.ui.tools.client.configuration.CatalogBrowserConfigurer.formatMetadata(Metadata, String) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 109 Medium

org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer

Bug Category Details Line Priority
Dead store to cluRangeFieldEditDescriptor in org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer.addClusetDetailsSections(SectionView, String) STYLE DLS_DEAD_LOCAL_STORE 135 Medium

org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer$CluSetEditOptionList

Bug Category Details Line Priority
Should org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer$CluSetEditOptionList be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 617-626 Medium

org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer$ModelIdPlaceHolder

Bug Category Details Line Priority
Should org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsConfigurer$ModelIdPlaceHolder be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 603-613 Medium

org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsManagementController$9

Bug Category Details Line Priority
org.kuali.student.lum.lu.ui.tools.client.configuration.CluSetsManagementController$9.exec(List) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 325 Medium

org.kuali.student.lum.lu.ui.tools.client.configuration.ClusetView$1$1

Bug Category Details Line Priority
org.kuali.student.lum.lu.ui.tools.client.configuration.ClusetView$1$1.onSuccess(Metadata) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 107 Medium

org.kuali.student.lum.lu.ui.tools.client.widgets.BrowsePanel$SelectButtonClickHandler

Bug Category Details Line Priority
Should org.kuali.student.lum.lu.ui.tools.client.widgets.BrowsePanel$SelectButtonClickHandler be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 118-127 Medium

org.kuali.student.lum.lu.ui.tools.client.widgets.KSBrowser$ExecuteNextSearchCallback

Bug Category Details Line Priority
Should org.kuali.student.lum.lu.ui.tools.client.widgets.KSBrowser$ExecuteNextSearchCallback be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 88-103 Medium

org.kuali.student.lum.lu.ui.tools.client.widgets.KSBrowser$ViewCourseCallback

Bug Category Details Line Priority
Should org.kuali.student.lum.lu.ui.tools.client.widgets.KSBrowser$ViewCourseCallback be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 111-125 Medium
Unread field: org.kuali.student.lum.lu.ui.tools.client.widgets.KSBrowser$ViewCourseCallback.controller PERFORMANCE URF_UNREAD_FIELD 112 Medium

org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetDataService

Bug Category Details Line Priority
org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetDataService.isAuthorized(PermissionType, Map) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 73 Medium

org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetManagementRpcGwtServlet

Bug Category Details Line Priority
Possible null pointer dereference of cluSetInfo in org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetManagementRpcGwtServlet.upWrap(CluSetInfo) CORRECTNESS NP_NULL_ON_SOME_PATH 147 Medium
Method org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetManagementRpcGwtServlet.getCluInformations(List) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 209 Medium
Class org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetManagementRpcGwtServlet defines non-transient non-serializable instance field lrcService BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.kuali.student.lum.lu.ui.tools.server.gwt.CluSetManagementRpcGwtServlet defines non-transient non-serializable instance field luService BAD_PRACTICE SE_BAD_FIELD Not available Medium