FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
171 34 0 0

Files

Class Bugs
org.kuali.student.lum.common.client.helpers.RecentlyViewedHelper 2
org.kuali.student.lum.common.client.lo.LOBuilder 5
org.kuali.student.lum.common.client.lo.LOBuilderBinding 1
org.kuali.student.lum.common.client.lo.LOCategoryBuilder$CreateLoCancelGroup 1
org.kuali.student.lum.common.client.lo.LOCategoryBuilder$LOCategoryPicker 1
org.kuali.student.lum.common.client.lo.LOCategoryBuilder$LOCategoryTypeInfoList 1
org.kuali.student.lum.common.client.lo.TreeStringBinding$StringTreeStructure 1
org.kuali.student.lum.common.client.widgets.BuildCluSetWidget$3 1
org.kuali.student.lum.common.client.widgets.Calendar 3
org.kuali.student.lum.common.client.widgets.CluSetEditorWidget 3
org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$1 1
org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$CluSetBinding 1
org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$CluSetRangeBinding 1
org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$KSItemLabelPanelPair 1
org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$KSSelectedListPanelPair 1
org.kuali.student.lum.common.client.widgets.CluSetHelper 4
org.kuali.student.lum.common.client.widgets.CluSetRangeModelUtil 1
org.kuali.student.lum.common.client.widgets.GregorianCalendar 3
org.kuali.student.lum.common.client.widgets.SearchResultsLightBox 1
org.kuali.student.lum.common.client.widgets.SwitchSection 1

org.kuali.student.lum.common.client.helpers.RecentlyViewedHelper

Bug Category Details Line Priority
org.kuali.student.lum.common.client.helpers.RecentlyViewedHelper.dependants isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 11 High
org.kuali.student.lum.common.client.helpers.RecentlyViewedHelper.recentlyViewedDocs isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 10 High

org.kuali.student.lum.common.client.lo.LOBuilder

Bug Category Details Line Priority
Write to static field org.kuali.student.lum.common.client.lo.LOBuilder.messageGroup from instance method new org.kuali.student.lum.common.client.lo.LOBuilder(String, String, String, String, Metadata) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 80 High
Write to static field org.kuali.student.lum.common.client.lo.LOBuilder.repoKey from instance method new org.kuali.student.lum.common.client.lo.LOBuilder(String, String, String, String, Metadata) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 79 High
Write to static field org.kuali.student.lum.common.client.lo.LOBuilder.state from instance method new org.kuali.student.lum.common.client.lo.LOBuilder(String, String, String, String, Metadata) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 78 High
Write to static field org.kuali.student.lum.common.client.lo.LOBuilder.type from instance method new org.kuali.student.lum.common.client.lo.LOBuilder(String, String, String, String, Metadata) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 77 High
Unused field: org.kuali.student.lum.common.client.lo.LOBuilder.searchWindow PERFORMANCE UUF_UNUSED_FIELD Not available Medium

org.kuali.student.lum.common.client.lo.LOBuilderBinding

Bug Category Details Line Priority
Method org.kuali.student.lum.common.client.lo.LOBuilderBinding.setModelValue(LOBuilder, DataModel, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 33 Medium

org.kuali.student.lum.common.client.lo.LOCategoryBuilder$CreateLoCancelGroup

Bug Category Details Line Priority
Should org.kuali.student.lum.common.client.lo.LOCategoryBuilder$CreateLoCancelGroup be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 716-749 Medium

org.kuali.student.lum.common.client.lo.LOCategoryBuilder$LOCategoryPicker

Bug Category Details Line Priority
Should org.kuali.student.lum.common.client.lo.LOCategoryBuilder$LOCategoryPicker be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 436-516 Medium

org.kuali.student.lum.common.client.lo.LOCategoryBuilder$LOCategoryTypeInfoList

Bug Category Details Line Priority
Should org.kuali.student.lum.common.client.lo.LOCategoryBuilder$LOCategoryTypeInfoList be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 521-558 Medium

org.kuali.student.lum.common.client.lo.TreeStringBinding$StringTreeStructure

Bug Category Details Line Priority
Method org.kuali.student.lum.common.client.lo.TreeStringBinding$StringTreeStructure.getCategoriesString() concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 160 Medium

org.kuali.student.lum.common.client.widgets.BuildCluSetWidget$3

Bug Category Details Line Priority
org.kuali.student.lum.common.client.widgets.BuildCluSetWidget$3.exec(List) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 163 Medium

org.kuali.student.lum.common.client.widgets.Calendar

Bug Category Details Line Priority
org.kuali.student.lum.common.client.widgets.Calendar.getTime() may expose internal representation by returning Calendar.date MALICIOUS_CODE EI_EXPOSE_REP 157 Medium
org.kuali.student.lum.common.client.widgets.Calendar.setTime(Date) may expose internal representation by storing an externally mutable object into Calendar.date MALICIOUS_CODE EI_EXPOSE_REP2 97 Medium
org.kuali.student.lum.common.client.widgets.Calendar defines equals(Calendar) method and uses Object.equals(Object) CORRECTNESS EQ_SELF_USE_OBJECT 214 Medium

org.kuali.student.lum.common.client.widgets.CluSetEditorWidget

Bug Category Details Line Priority
new org.kuali.student.lum.common.client.widgets.CluSetEditorWidget(CluSetRetriever, Enum, String, String, boolean, Callback, String, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 105 Medium
Call to equals() comparing different types in org.kuali.student.lum.common.client.widgets.CluSetEditorWidget.findLookupMetadataByLookupId(String, List, List) CORRECTNESS EC_UNRELATED_TYPES 505 High
Possible null pointer dereference of CluSetEditorWidget.showCluRangeDetailsHandlerRegs in org.kuali.student.lum.common.client.widgets.CluSetEditorWidget.addClusetItemViewHandler(CluSetRangeDataHelper, KSItemLabel, LookupMetadata, Data, SearchRequest) CORRECTNESS NP_NULL_ON_SOME_PATH 349 Medium

org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$1

Bug Category Details Line Priority
org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$1.exec(Metadata) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 95 Medium

org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$CluSetBinding

Bug Category Details Line Priority
Should org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$CluSetBinding be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 637-648 Medium

org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$CluSetRangeBinding

Bug Category Details Line Priority
Possible null pointer dereference of model in org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$CluSetRangeBinding.setWidgetValue(HasDataValue, DataModel, String) CORRECTNESS NP_NULL_ON_SOME_PATH 670 Medium

org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$KSItemLabelPanelPair

Bug Category Details Line Priority
Should org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$KSItemLabelPanelPair be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 581-596 Medium

org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$KSSelectedListPanelPair

Bug Category Details Line Priority
Should org.kuali.student.lum.common.client.widgets.CluSetEditorWidget$KSSelectedListPanelPair be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 560-575 Medium

org.kuali.student.lum.common.client.widgets.CluSetHelper

Bug Category Details Line Priority
org.kuali.student.lum.common.client.widgets.CluSetHelper.getReferenceable() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 166 Medium
org.kuali.student.lum.common.client.widgets.CluSetHelper.getReusable() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 151 Medium
org.kuali.student.lum.common.client.widgets.CluSetHelper.setReferenceable(Boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 159 Medium
org.kuali.student.lum.common.client.widgets.CluSetHelper.setReusable(Boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 144 Medium

org.kuali.student.lum.common.client.widgets.CluSetRangeModelUtil

Bug Category Details Line Priority
org.kuali.student.lum.common.client.widgets.CluSetRangeModelUtil.INSTANCE isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 13 High

org.kuali.student.lum.common.client.widgets.GregorianCalendar

Bug Category Details Line Priority
org.kuali.student.lum.common.client.widgets.GregorianCalendar defines clone() but doesn't implement Cloneable BAD_PRACTICE CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE 362-364 Medium
org.kuali.student.lum.common.client.widgets.GregorianCalendar defines equals(GregorianCalendar) method and uses Object.equals(Object) CORRECTNESS EQ_SELF_USE_OBJECT 326 High
org.kuali.student.lum.common.client.widgets.GregorianCalendar.daysInMonth should be both final and package protected MALICIOUS_CODE MS_FINAL_PKGPROTECT 54 Medium

org.kuali.student.lum.common.client.widgets.SearchResultsLightBox

Bug Category Details Line Priority
Unread field: org.kuali.student.lum.common.client.widgets.SearchResultsLightBox.searchRpcServiceAsync PERFORMANCE URF_UNREAD_FIELD 18 Medium

org.kuali.student.lum.common.client.widgets.SwitchSection

Bug Category Details Line Priority
Unused field: org.kuali.student.lum.common.client.widgets.SwitchSection.deletionParentKeys PERFORMANCE UUF_UNUSED_FIELD Not available Medium