The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field MaintenanceDocumentEntry.allowsNewOrCopy masks field in superclass org.kuali.rice.krad.datadictionary.MaintenanceDocumentEntry | CORRECTNESS | MF_CLASS_MASKS_FIELD | 43 | High |
| Field MaintenanceDocumentEntry.allowsRecordDeletion masks field in superclass org.kuali.rice.krad.datadictionary.MaintenanceDocumentEntry | CORRECTNESS | MF_CLASS_MASKS_FIELD | 43 | High |
| Field MaintenanceDocumentEntry.documentAuthorizerClass masks field in superclass org.kuali.rice.krad.datadictionary.DocumentEntry | CORRECTNESS | MF_CLASS_MASKS_FIELD | 43 | High |
| Field MaintenanceDocumentEntry.documentPresentationControllerClass masks field in superclass org.kuali.rice.krad.datadictionary.DocumentEntry | CORRECTNESS | MF_CLASS_MASKS_FIELD | 43 | High |
| Field MaintenanceDocumentEntry.lockingKeys masks field in superclass org.kuali.rice.krad.datadictionary.MaintenanceDocumentEntry | CORRECTNESS | MF_CLASS_MASKS_FIELD | 43 | High |
| Field MaintenanceDocumentEntry.preserveLockingKeysOnCopy masks field in superclass org.kuali.rice.krad.datadictionary.MaintenanceDocumentEntry | CORRECTNESS | MF_CLASS_MASKS_FIELD | 43 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.ButtonControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.CheckboxControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 30 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.ControlDefinitionBase defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 413 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.CurrencyControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 38 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.FileControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 32 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.HiddenControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 28 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.KualiUserControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 49 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.LinkControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 30 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.LookupHiddenControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 29 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.LookupReadonlyControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 29 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.MultiselectControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 28 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.RadioControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 29 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.SelectControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 33 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.TextControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 30 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.TextareaControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 28 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.WorkflowWorkgroupControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 33 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of exportMap in org.kuali.rice.kns.datadictionary.validation.charlevel.RegexValidationPattern.extendExportMap(ExportMap) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 53 | High |
| Nullcheck of exportMap at line 58 of value previously dereferenced in org.kuali.rice.kns.datadictionary.validation.charlevel.RegexValidationPattern.extendExportMap(ExportMap) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 53 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.document.MaintenanceDocumentBase is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of fieldRestriction in org.kuali.rice.kns.document.authorization.MaintenanceDocumentRestrictionsBase.getFieldRestriction(String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 53 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.inquiry.KualiInquirableImpl.businessObjectService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to fieldsForLookup in org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 1098 | High |
| Dead store to fields in org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.setRows() | STYLE | DLS_DEAD_LOCAL_STORE | 1049 | Medium |
| org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.getSupplementalMenuBar() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 1371 | Medium |
| org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.RESULTS_DEFAULT_MAX_COLUMN_LENGTH should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 707 | Medium |
| Method org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.preprocessDateFields(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 1236 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.lookup.HtmlData.getTitleText(String, Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 217 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl.getExternalizableBusinessObjectFieldValues(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 162 | Medium |
| Method org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 230 | Medium |
| Method org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl.removeExternalizableBusinessObjectFieldValues(Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 145 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.lookup.LookupUtils.generateFieldConversions(BusinessObject, String, DataObjectRelationship, String, List, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 603 | Medium |
| Method org.kuali.rice.kns.lookup.LookupUtils.generateLookupParameters(BusinessObject, String, DataObjectRelationship, String, List, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 642 | Medium |
| Method org.kuali.rice.kns.lookup.LookupUtils.getNestedBusinessObject(BusinessObject, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 551 | Medium |
| Method org.kuali.rice.kns.lookup.LookupUtils.setFieldDirectInquiry(Field) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 424 | Medium |
| Method org.kuali.rice.kns.lookup.LookupUtils.getPrimitiveReference(BusinessObject, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 507 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to cachedValues in org.kuali.rice.kns.maintenance.KualiMaintainableImpl.setGenerateDefaultValues(String) | STYLE | DLS_DEAD_LOCAL_STORE | 686 | Medium |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.getMultiValueIdentifierList(Collection, List) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 535 | Medium |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.hasBusinessObjectExisted(BusinessObject, List, List) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 549 | Medium |
| Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.getMultiValueIdentifierList(Collection, List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 537 | Medium |
| Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.hasBusinessObjectExisted(BusinessObject, List, List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 551 | Medium |
| Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.decryptEncryptedData(Map, MaintenanceDocument, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 152 | Medium |
| Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.performFieldForceUpperCase(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 1334 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on org.kuali.rice.krad.util.ErrorMessage.getMessageParameters() in org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase.showErrorMap() | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 1156 | Medium |
| org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase.LOG isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 83 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.rules.PromptBeforeValidationBase.askOrAnalyzeYesNoQuestion(String, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 221 | Medium |
| org.kuali.rice.kns.rules.PromptBeforeValidationBase.LOG isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 47 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.rice.kns.rules.PromptBeforeValidationBase$ContextSession be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 73 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.rice.kns.rules.PromptBeforeValidationBase$IsAskingException be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 54 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.util.AuditError.getParams() may expose internal representation by returning AuditError.params | MALICIOUS_CODE | EI_EXPOSE_REP | 103 | Medium |
| org.kuali.rice.kns.util.AuditError.setParams(String[]) may expose internal representation by storing an externally mutable object into AuditError.params | MALICIOUS_CODE | EI_EXPOSE_REP2 | 112 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to field in org.kuali.rice.kns.util.FieldUtils.convertRemotableAttributeFields(List) | STYLE | DLS_DEAD_LOCAL_STORE | 1431 | Medium |
| Dead store to meshedRows in org.kuali.rice.kns.util.FieldUtils.meshSections(List, List, List, String, boolean, MaintenanceDocumentRestrictions, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 1081 | Medium |
| Method org.kuali.rice.kns.util.FieldUtils.fixFieldForForm(Field, List, String, String, boolean, MaintenanceDocumentRestrictions, String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 850 | Medium |
| Method org.kuali.rice.kns.util.FieldUtils.populateBusinessObjectFromMap(BusinessObject, Map, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 740 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.util.InactiveRecordsHidingUtils.setShowInactiveRecords(Map, String, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 83 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.kns.web.struts.form.pojo.PojoFormBase to org.kuali.rice.kns.web.struts.form.KualiDocumentFormBase in org.kuali.rice.kns.util.WebUtils.isFormSessionDocument(PojoFormBase) | STYLE | BC_UNCONFIRMED_CAST | 494 | Medium |
| instanceof will always return true in org.kuali.rice.kns.util.WebUtils.getMethodToCallSettingAttribute(ActionForm, HttpServletRequest, String), since all org.apache.struts.action.ActionForm are instances of org.apache.struts.action.ActionForm | STYLE | BC_VACUOUS_INSTANCEOF | 186 | Medium |
| Dead store to params in org.kuali.rice.kns.util.WebUtils.getMultipartParameters(HttpServletRequest, ActionServletWrapper, ActionForm, ActionMapping) | STYLE | DLS_DEAD_LOCAL_STORE | 376 | High |
| Dead store to files in org.kuali.rice.kns.util.WebUtils.getMultipartParameters(HttpServletRequest, ActionServletWrapper, ActionForm, ActionMapping) | STYLE | DLS_DEAD_LOCAL_STORE | 394 | Medium |
| org.kuali.rice.kns.util.WebUtils.KEY_KUALI_FORM_IN_SESSION isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 500 | High |
| Method org.kuali.rice.kns.util.WebUtils.filterHtmlAndReplaceRiceMarkup(String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 748 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.web.EditablePropertiesHistoryHolder.getMaxHistoryLength() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 63 | Medium |
| org.kuali.rice.kns.web.EditablePropertiesHistoryHolder is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 41 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on textAreaParams in org.kuali.rice.kns.web.struts.action.KualiAction.getTextAreaParams(HttpServletRequest) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 1047 | Medium |
| Invocation of toString on inquiryParams in org.kuali.rice.kns.web.struts.action.KualiAction.performInquiry(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 658 | Medium |
| org.kuali.rice.kns.web.struts.action.KualiAction.performLookup(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 533 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to newNote in org.kuali.rice.kns.web.struts.action.KualiDocumentActionBase.deleteBONote(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 1472 | Medium |
| org.kuali.rice.kns.web.struts.action.KualiDocumentActionBase.DOCUMENT_LOAD_COMMANDS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 120 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to cancelForward in org.kuali.rice.kns.web.struts.action.KualiExceptionHandlerAction.executeException(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 127 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to helpForm in org.kuali.rice.kns.web.struts.action.KualiHelpAction.getHelpUrlByNamespace(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 462 | Medium |
| org.kuali.rice.kns.web.struts.action.KualiHelpAction.getAttributeValidationPatternName(AttributeDefinition) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 135 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to kualiInquirable in org.kuali.rice.kns.web.struts.action.KualiInquiryAction.toggleTab(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 299 | Medium |
| Load of known null value in org.kuali.rice.kns.web.struts.action.KualiInquiryAction.export(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 365 | Medium |
| Method org.kuali.rice.kns.web.struts.action.KualiInquiryAction.getRoleQualification(ActionForm, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 97 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to displayList in org.kuali.rice.kns.web.struts.action.KualiLookupAction.search(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 197 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to documentAuthorizer in org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction.clearUnauthorizedNewFields(MaintenanceDocument) | STYLE | DLS_DEAD_LOCAL_STORE | 960 | Medium |
| Dead store to newBo in org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction.clearUnauthorizedNewFields(MaintenanceDocument) | STYLE | DLS_DEAD_LOCAL_STORE | 966 | Medium |
| Dead store to maintenanceDocumentAuthorizer in org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction.populateAuthorizationFields(KualiDocumentFormBase) | STYLE | DLS_DEAD_LOCAL_STORE | 1002 | Medium |
| Redundant nullcheck of collectionName, which is known to be non-null in org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction.deleteLine(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 830 | Medium |
| Method org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction.copyParametersToBO(Map, PersistableBusinessObject) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 374 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to displayList in org.kuali.rice.kns.web.struts.action.KualiMultipleValueLookupAction.search(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 93 | Medium |
| Method org.kuali.rice.kns.web.struts.action.KualiMultipleValueLookupAction.getMaxRowsPerPage(MultipleValueLookupForm) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 614 | Medium |
| Possible null pointer dereference of resultTable in org.kuali.rice.kns.web.struts.action.KualiMultipleValueLookupAction.performMultipleValueLookup(MultipleValueLookupForm, List, int, boolean) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 344 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.kns.web.struts.form.InquiryForm defines non-transient non-serializable instance field inquirable | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.web.struts.form.KualiForm.getHeaderNavigationTabs() may expose internal representation by returning KualiForm.headerNavigationTabs | MALICIOUS_CODE | EI_EXPOSE_REP | 278 | Medium |
| org.kuali.rice.kns.web.struts.form.KualiForm.setHeaderNavigationTabs(HeaderNavigation[]) may expose internal representation by storing an externally mutable object into KualiForm.headerNavigationTabs | MALICIOUS_CODE | EI_EXPOSE_REP2 | 287 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docTypeName in org.kuali.rice.kns.web.struts.form.KualiMaintenanceForm.getAdditionalSectionsFile() | STYLE | DLS_DEAD_LOCAL_STORE | 458 | Medium |
| Method org.kuali.rice.kns.web.struts.form.KualiMaintenanceForm.populate(HttpServletRequest) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 244 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ddService in org.kuali.rice.kns.web.struts.form.LookupForm.populate(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 148 | Medium |
| org.kuali.rice.kns.web.struts.form.LookupForm.populate(HttpServletRequest) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 227 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.kns.web.struts.form.MultipleValueLookupForm defines non-transient non-serializable instance field tableMetadata | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.web.struts.form.pojo.PojoFormBase.populate(HttpServletRequest) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 155 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.web.ui.Field.getPropertyValues() may expose internal representation by returning Field.propertyValues | MALICIOUS_CODE | EI_EXPOSE_REP | 1608 | Medium |
| org.kuali.rice.kns.web.ui.Field.setPropertyValues(String[]) may expose internal representation by storing an externally mutable object into Field.propertyValues | MALICIOUS_CODE | EI_EXPOSE_REP2 | 1612 | Medium |
| Method org.kuali.rice.kns.web.ui.Field.setLookupParameters(Map) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 884 | Medium |
| Method org.kuali.rice.kns.web.ui.Field.setFieldConversions(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 793 | Medium |
| Method org.kuali.rice.kns.web.ui.Field.setLookupParameters(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 881 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.web.ui.FieldBridge.getNewFormFields(CollectionDefinitionI, BusinessObject, Maintainable, List, Set, StringBuffer, String, boolean, int) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 411 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.web.ui.FormatAwareDecorator.createCollectionString(Object) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 77 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to row in org.kuali.rice.kns.web.ui.SectionBridge.toSection(Inquirable, InquirySectionDefinition, BusinessObject, InquiryRestrictions) | STYLE | DLS_DEAD_LOCAL_STORE | 103 | Medium |
| Dead store to sectionRows in org.kuali.rice.kns.web.ui.SectionBridge.toSection(Inquirable, InquirySectionDefinition, BusinessObject, InquiryRestrictions) | STYLE | DLS_DEAD_LOCAL_STORE | 109 | Medium |
| Method org.kuali.rice.kns.web.ui.SectionBridge.getContainerRows(Section, CollectionDefinitionI, BusinessObject, Maintainable, Maintainable, List, Set, StringBuffer, String, boolean, int, Inquirable) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 435 | Medium |
| Nullcheck of o at line 250 of value previously dereferenced in org.kuali.rice.kns.web.ui.SectionBridge.toSection(MaintainableSectionDefinition, BusinessObject, Maintainable, Maintainable, String, List, Set) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 217 | Medium |
