FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
151745502

Files

ClassBugs
org.apache.commons.httpclient.contrib.ssl.EasySSLProtocolSocketFactory1
org.kuali.rice.ken.bo.NotificationChannel3
org.kuali.rice.ken.dao.impl.NotificationMessegeDeliveryDaoJpa1
org.kuali.rice.ken.service.impl.KENAPIServiceImpl1
org.kuali.rice.ken.service.impl.NotificationChannelServiceImpl2
org.kuali.rice.ken.service.impl.NotificationContentTypeServiceImpl2
org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl2
org.kuali.rice.ken.service.impl.NotificationMessageDeliveryAutoRemovalServiceImpl1
org.kuali.rice.ken.util.Util6
org.kuali.rice.ken.web.spring.ContentTypeController5
org.kuali.rice.ken.web.spring.UserPreferencesController4
org.kuali.rice.kew.actionitem.ActionItemComparator1
org.kuali.rice.kew.actionlist.ActionListFilter8
org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImpl1
org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOOjbImpl1
org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl4
org.kuali.rice.kew.actionlist.web.ActionListAction$ActionItemComparator1
org.kuali.rice.kew.actionlist.web.ActionListForm2
org.kuali.rice.kew.actionrequest.ActionRequestFactory1
org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl2
org.kuali.rice.kew.actions.DisapproveAction1
org.kuali.rice.kew.actions.LogDocumentActionAction1
org.kuali.rice.kew.actions.SuperUserActionTakenEvent1
org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOJpaImpl1
org.kuali.rice.kew.attribute.XMLAttributeUtils2
org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl5
org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl10
org.kuali.rice.kew.config.ThinClientResourceLoader2
org.kuali.rice.kew.docsearch.DocSearchUtils2
org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder4
org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter1
org.kuali.rice.kew.docsearch.SearchableAttributeDateTimeValue1
org.kuali.rice.kew.docsearch.SearchableAttributeFloatValue1
org.kuali.rice.kew.docsearch.SearchableAttributeLongValue1
org.kuali.rice.kew.docsearch.SearchableAttributeStringValue1
org.kuali.rice.kew.docsearch.StandardDocumentSearchCriteriaProcessor1
org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator10
org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor6
org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor$DisplayValues1
org.kuali.rice.kew.docsearch.dao.impl.DocumentSearchDAOOjbImpl2
org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl3
org.kuali.rice.kew.docsearch.web.SearchAttributeFormContainer3
org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute4
org.kuali.rice.kew.doctype.DocumentTypeAttribute1
org.kuali.rice.kew.doctype.DocumentTypePolicy2
org.kuali.rice.kew.doctype.DocumentTypeSecurity1
org.kuali.rice.kew.doctype.bo.DocumentType1
org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOJpaImpl1
org.kuali.rice.kew.doctype.service.impl.DocumentSecurityServiceImpl1
org.kuali.rice.kew.doctype.service.impl.DocumentTypeServiceImpl1
org.kuali.rice.kew.document.RoutingRuleMaintainableBusRule1
org.kuali.rice.kew.documentoperation.web.DocumentOperationAction2
org.kuali.rice.kew.documentoperation.web.DocumentOperationForm6
org.kuali.rice.kew.dto.DTOConverter5
org.kuali.rice.kew.engine.BlanketApproveEngine$ProcessEntry1
org.kuali.rice.kew.engine.CompatUtils4
org.kuali.rice.kew.engine.StandardWorkflowEngine2
org.kuali.rice.kew.engine.node.FYIByNetworkId1
org.kuali.rice.kew.engine.node.KRAMetaRuleNode$FinalApproverContext1
org.kuali.rice.kew.engine.node.NodeJotter2
org.kuali.rice.kew.engine.node.NodeType$ExtensionDepthComparator1
org.kuali.rice.kew.engine.node.Process1
org.kuali.rice.kew.engine.node.RequestsNode$FinalApproverContext1
org.kuali.rice.kew.engine.node.RoleNode$RoleRequestSorter1
org.kuali.rice.kew.engine.node.RouteNodeUtils$RouteNodeSorter1
org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode3
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl1
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$NodeInstanceIdSorter1
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$RouteNodeSorter1
org.kuali.rice.kew.engine.simulation.SimulationEngine2
org.kuali.rice.kew.help.service.impl.HelpServiceImpl1
org.kuali.rice.kew.help.web.HelpForm1
org.kuali.rice.kew.impl.action.WorkflowDocumentActionsServiceImpl1
org.kuali.rice.kew.mail.service.impl.ActionListEmailServiceImpl2
org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl2
org.kuali.rice.kew.notes.Note1
org.kuali.rice.kew.notes.web.AttachmentServlet1
org.kuali.rice.kew.notes.web.NoteAction7
org.kuali.rice.kew.plugin.PluginConfig1
org.kuali.rice.kew.plugin.PluginEnvironment1
org.kuali.rice.kew.plugin.PluginNameComparator1
org.kuali.rice.kew.plugin.ServerPluginRegistry1
org.kuali.rice.kew.plugin.ZipFilePluginLoader1
org.kuali.rice.kew.preferences.service.impl.PreferencesServiceImpl1
org.kuali.rice.kew.quicklinks.ActionListStats1
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOJpaImpl1
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$11
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$21
org.kuali.rice.kew.resourceloader.CoreResourceLoader1
org.kuali.rice.kew.role.XPathQualifierResolver$ResolverConfig1
org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue5
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImpl1
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl5
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl$11
org.kuali.rice.kew.routeheader.service.impl.WorkflowDocumentServiceImpl1
org.kuali.rice.kew.rule.FlexRM3
org.kuali.rice.kew.rule.GroupRuleResponsibility1
org.kuali.rice.kew.rule.KRAMetaRuleEngine1
org.kuali.rice.kew.rule.PersonRuleResponsibility1
org.kuali.rice.kew.rule.RuleBaseValues3
org.kuali.rice.kew.rule.RuleDelegation1
org.kuali.rice.kew.rule.RuleExpressionDef1
org.kuali.rice.kew.rule.RuleExtension1
org.kuali.rice.kew.rule.RuleExtensionValue1
org.kuali.rice.kew.rule.RuleRoutingAttribute1
org.kuali.rice.kew.rule.TemplateRuleSelector1
org.kuali.rice.kew.rule.bo.RuleTemplate1
org.kuali.rice.kew.rule.bo.RuleTemplateAttribute1
org.kuali.rice.kew.rule.dao.impl.RuleDAOJpaImpl1
org.kuali.rice.kew.rule.dao.impl.RuleDAOOjbImpl1
org.kuali.rice.kew.rule.service.impl.RuleDelegationServiceImpl1
org.kuali.rice.kew.rule.service.impl.RuleServiceImpl$RuleDelegationSorter2
org.kuali.rice.kew.rule.web.RoutingReportAction2
org.kuali.rice.kew.rule.web.RoutingReportAction$RouteReportRuleTemplateContainer1
org.kuali.rice.kew.rule.web.WebRuleBaseValues2
org.kuali.rice.kew.rule.web.WebRuleResponsibility2
org.kuali.rice.kew.rule.web.WebRuleResponsibility$DelegationRulesProxy1
org.kuali.rice.kew.rule.web.WebRuleUtils1
org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute2
org.kuali.rice.kew.service.impl.KEWModuleService1
org.kuali.rice.kew.service.impl.WorkflowUtilityWebServiceImpl3
org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl15
org.kuali.rice.kew.stats.web.StatsForm5
org.kuali.rice.kew.superuser.web.SuperUserAction1
org.kuali.rice.kew.superuser.web.SuperUserForm2
org.kuali.rice.kew.useroptions.UserOptions1
org.kuali.rice.kew.useroptions.UserOptionsId1
org.kuali.rice.kew.util.ByteArrayDataSource2
org.kuali.rice.kew.util.Utilities$PrioritySorter1
org.kuali.rice.kew.util.Utilities$RouteLogActionRequestSorter1
org.kuali.rice.kew.web.FilterMapping1
org.kuali.rice.kew.web.UserLoginFilter1
org.kuali.rice.kew.xml.AbstractTransformationFilter$CurrentElement1
org.kuali.rice.kew.xml.DocumentTypeXmlParser2
org.kuali.rice.kew.xml.DocumentTypeXmlParser$DocTypeNode1
org.kuali.rice.kew.xml.DocumentTypeXmlParser$RoutePathContext1
org.kuali.rice.kew.xml.GroupXmlParser1
org.kuali.rice.kew.xml.HelpEntryXmlParser1
org.kuali.rice.kew.xml.RuleTemplateXmlParser2
org.kuali.rice.kew.xml.RuleXmlParser2
org.kuali.rice.kew.xml.UserXmlParser1
org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$DocumentTypeParentComparator2
org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$SplitJoinContext1
org.kuali.rice.kew.xml.export.GroupXmlExporter1
org.kuali.rice.kew.xml.export.RuleTemplateXmlExporter1
org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$SimpleNodeList1
org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$XPathSegment1
org.kuali.rice.kim.bo.impl.GenericPermission1
org.kuali.rice.kim.bo.impl.PersonImpl2
org.kuali.rice.kim.bo.ui.PersonDocumentRole2
org.kuali.rice.kim.document.GenericPermissionMaintainable1
org.kuali.rice.kim.document.IdentityManagementKimDocument2
org.kuali.rice.kim.document.rule.AttributeValidationHelper3
org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule2
org.kuali.rice.kim.impl.responsibility.ResponsibilityInquirableImpl1
org.kuali.rice.kim.impl.responsibility.ResponsibilityInternalServiceImpl2
org.kuali.rice.kim.impl.responsibility.ResponsibilityLookupableHelperServiceImpl2
org.kuali.rice.kim.impl.type.KimTypeAttributesHelper4
org.kuali.rice.kim.impl.type.KimTypeQualifierResolver1
org.kuali.rice.kim.impl.type.KimTypeServiceBase7
org.kuali.rice.kim.inquiry.PermissionInquirableImpl1
org.kuali.rice.kim.lookup.GroupLookupableHelperServiceImpl1
org.kuali.rice.kim.lookup.KimDocumentRoleMemberLookupableHelperServiceImpl2
org.kuali.rice.kim.lookup.PermissionLookupableHelperServiceImpl2
org.kuali.rice.kim.lookup.PersonLookupableHelperServiceImpl1
org.kuali.rice.kim.lookup.RoleLookupableHelperServiceImpl1
org.kuali.rice.kim.lookup.RoleMemberLookupableHelperServiceImpl2
org.kuali.rice.kim.rules.ui.PersonDocumentDelegationMemberRule1
org.kuali.rice.kim.service.impl.GroupInternalServiceImpl$MembersDiff1
org.kuali.rice.kim.service.impl.KimModuleService2
org.kuali.rice.kim.service.impl.PermissionServiceImpl1
org.kuali.rice.kim.service.impl.PermissionUpdateServiceImpl1
org.kuali.rice.kim.service.impl.PersonServiceImpl7
org.kuali.rice.kim.service.impl.UiDocumentServiceImpl9
org.kuali.rice.kim.service.impl.UiDocumentServiceImpl$GroupMemberNameComparator1
org.kuali.rice.kim.web.struts.action.IdentityManagementPersonDocumentAction1
org.kuali.rice.kim.web.struts.action.IdentityManagementRoleDocumentAction1
org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl3
org.kuali.rice.kns.service.impl.BusinessObjectMetaDataServiceImpl1
org.kuali.rice.kns.service.impl.BusinessObjectSerializerServiceImpl1
org.kuali.rice.kns.service.impl.DataDictionaryServiceImpl1
org.kuali.rice.kns.service.impl.DictionaryValidationServiceImpl1
org.kuali.rice.kns.service.impl.MaintenanceDocumentDictionaryServiceImpl2
org.kuali.rice.kns.web.struts.action.KualiActionServlet1
org.kuali.rice.kns.web.struts.action.KualiActionServlet$KualiActionServletConfig1
org.kuali.rice.krad.dao.impl.BusinessObjectDaoJpa1
org.kuali.rice.krad.dao.impl.LookupDaoJpa7
org.kuali.rice.krad.dao.impl.LookupDaoOjb7
org.kuali.rice.krad.dao.impl.PersistenceDaoJpa1
org.kuali.rice.krad.dao.proxy.DocumentHeaderDaoProxy1
org.kuali.rice.krad.dao.proxy.MaintenanceDocumentDaoProxy1
org.kuali.rice.krad.dao.proxy.NoteDaoProxy1
org.kuali.rice.krad.dao.proxy.PersistedLookupMetadataDaoProxy1
org.kuali.rice.krad.dao.proxy.PersistenceDaoProxy1
org.kuali.rice.krad.document.authorization.MaintenanceDocumentAuthorizerBase1
org.kuali.rice.krad.service.impl.AttachmentServiceImpl4
org.kuali.rice.krad.service.impl.BusinessObjectSerializerServiceImpl1
org.kuali.rice.krad.service.impl.BusinessObjectServiceImpl1
org.kuali.rice.krad.service.impl.DataObjectMetaDataServiceImpl1
org.kuali.rice.krad.service.impl.DictionaryValidationServiceImpl1
org.kuali.rice.krad.service.impl.DocumentServiceImpl1
org.kuali.rice.krad.service.impl.InactivateableFromToServiceImpl1
org.kuali.rice.krad.service.impl.InactivationBlockingDisplayServiceImpl1
org.kuali.rice.krad.service.impl.KualiExceptionIncidentServiceImpl1
org.kuali.rice.krad.service.impl.MaintenanceDocumentServiceImpl1
org.kuali.rice.krad.service.impl.ModuleServiceBase2
org.kuali.rice.krad.service.impl.PersistenceStructureServiceJpaImpl3
org.kuali.rice.krad.service.impl.PersistenceStructureServiceOjbImpl3
org.kuali.rice.krad.service.impl.PostProcessorServiceImpl1
org.kuali.rice.krad.service.impl.PredicateFactoryLookup1
org.kuali.rice.krad.service.impl.RiceApplicationConfigurationMediationServiceImpl2
org.kuali.rice.krad.service.impl.SessionDocumentServiceImpl1
org.kuali.rice.krad.uif.service.impl.ExpressionEvaluatorServiceImpl1
org.kuali.rice.krad.uif.service.impl.InquiryViewTypeServiceImpl1
org.kuali.rice.krad.uif.service.impl.LookupViewTypeServiceImpl1
org.kuali.rice.krad.uif.service.impl.MaintenanceViewTypeServiceImpl1
org.kuali.rice.krad.workflow.attribute.DataDictionaryDocumentSearchCustomizer1
org.kuali.rice.krad.workflow.attribute.DataDictionarySearchableAttribute2
org.kuali.rice.krad.workflow.attribute.KualiXmlAttributeHelper1
org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl2
org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl$RoutingAttributeTracker2
org.kuali.rice.ksb.cache.RiceCacheAdministratorImpl1
org.kuali.rice.ksb.cache.RiceDistributedCacheListener2
org.kuali.rice.ksb.impl.registry.ServiceDescriptorBo1
org.kuali.rice.ksb.messaging.HttpException1
org.kuali.rice.ksb.messaging.MessageServiceInvoker1
org.kuali.rice.ksb.messaging.dao.impl.MessageQueueDAOOjbImpl1
org.kuali.rice.ksb.messaging.exceptionhandling.DefaultMessageExceptionHandler2
org.kuali.rice.ksb.messaging.quartz.KSBSchedulerFactoryBean2
org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector3
org.kuali.rice.ksb.messaging.serviceproxies.MessageSendingTransactionSynchronization2
org.kuali.rice.ksb.messaging.servlet.KSBDispatcherServlet2
org.kuali.rice.ksb.messaging.threadpool.PriorityBlockingQueuePersistedMessageComparator1
org.kuali.rice.ksb.messaging.web.MessageQueueAction2
org.kuali.rice.ksb.messaging.web.ThreadPoolForm1
org.kuali.rice.ksb.security.SignatureVerifyingInputStream1
org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer3
org.kuali.rice.ksb.security.admin.service.impl.JavaSecurityManagementServiceImpl1
org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction4
org.kuali.rice.ksb.util.KSBConstants1

org.apache.commons.httpclient.contrib.ssl.EasySSLProtocolSocketFactory

BugCategoryDetailsLinePriority
org.apache.commons.httpclient.contrib.ssl.EasySSLProtocolSocketFactory.equals(Object) fails for subtypesBAD_PRACTICEEQ_GETCLASS_AND_CLASS_CONSTANT221Medium

org.kuali.rice.ken.bo.NotificationChannel

BugCategoryDetailsLinePriority
Equals method for org.kuali.rice.ken.bo.NotificationChannel assumes the argument is of type NotificationChannelBAD_PRACTICEBC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS260Medium
org.kuali.rice.ken.bo.NotificationChannel defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE260High
org.kuali.rice.ken.bo.NotificationChannel.equals(Object) does not check for null argumentBAD_PRACTICENP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT260High

org.kuali.rice.ken.dao.impl.NotificationMessegeDeliveryDaoJpa

BugCategoryDetailsLinePriority
Dead store to lockedDeliveries in org.kuali.rice.ken.dao.impl.NotificationMessegeDeliveryDaoJpa.getLockedDeliveries(Class, GenericDao)STYLEDLS_DEAD_LOCAL_STORE101Medium

org.kuali.rice.ken.service.impl.KENAPIServiceImpl

BugCategoryDetailsLinePriority
Unread field: org.kuali.rice.ken.service.impl.KENAPIServiceImpl.prefsServicePERFORMANCEURF_UNREAD_FIELD51Medium

org.kuali.rice.ken.service.impl.NotificationChannelServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.ken.service.impl.NotificationChannelServiceImpl.getAllNotificationChannels() invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR77Medium
org.kuali.rice.ken.service.impl.NotificationChannelServiceImpl.getSubscribableChannels() invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR68Medium

org.kuali.rice.ken.service.impl.NotificationContentTypeServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.ken.service.impl.NotificationContentTypeServiceImpl.getAllCurrentContentTypes() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR133Medium
org.kuali.rice.ken.service.impl.NotificationContentTypeServiceImpl.getNotificationContentType(String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR61Medium

org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of d in org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl.parseSerializedNotificationXml(byte[]) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION563Medium
Possible null pointer dereference of d2 in org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl.parseSerializedNotificationXml(byte[]) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION573Medium

org.kuali.rice.ken.service.impl.NotificationMessageDeliveryAutoRemovalServiceImpl

BugCategoryDetailsLinePriority
Dead store to firstMessageDelivery in org.kuali.rice.ken.service.impl.NotificationMessageDeliveryAutoRemovalServiceImpl.processWorkItems(Collection)STYLEDLS_DEAD_LOCAL_STORE71Medium

org.kuali.rice.ken.util.Util

BugCategoryDetailsLinePriority
Primitive value is boxed and then immediately unboxed in org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED295Medium
org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR295Medium
Method org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR311Medium
Method org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR281Medium
org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR278Medium
org.kuali.rice.ken.util.Util.transformContent(Notification) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR173Medium

org.kuali.rice.ken.web.spring.ContentTypeController

BugCategoryDetailsLinePriority
org.kuali.rice.ken.web.spring.ContentTypeController.displayContentTypeForm(HttpServletRequest, HttpServletResponse) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR121Medium
Write to static field org.kuali.rice.ken.web.spring.ContentTypeController.view from instance method org.kuali.rice.ken.web.spring.ContentTypeController.addContentType(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD143High
Write to static field org.kuali.rice.ken.web.spring.ContentTypeController.view from instance method org.kuali.rice.ken.web.spring.ContentTypeController.displayContentTypeForm(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD114High
Write to static field org.kuali.rice.ken.web.spring.ContentTypeController.view from instance method org.kuali.rice.ken.web.spring.ContentTypeController.displayContentTypes(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD96High
Write to static field org.kuali.rice.ken.web.spring.ContentTypeController.view from instance method org.kuali.rice.ken.web.spring.ContentTypeController.updateContentType(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD182High

org.kuali.rice.ken.web.spring.UserPreferencesController

BugCategoryDetailsLinePriority
Write to static field org.kuali.rice.ken.web.spring.UserPreferencesController.view from instance method org.kuali.rice.ken.web.spring.UserPreferencesController.displayActionListPreferences(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD87High
Write to static field org.kuali.rice.ken.web.spring.UserPreferencesController.view from instance method org.kuali.rice.ken.web.spring.UserPreferencesController.displayUserPreferences(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD103High
Write to static field org.kuali.rice.ken.web.spring.UserPreferencesController.view from instance method org.kuali.rice.ken.web.spring.UserPreferencesController.subscribeToChannel(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD135High
Write to static field org.kuali.rice.ken.web.spring.UserPreferencesController.view from instance method org.kuali.rice.ken.web.spring.UserPreferencesController.unsubscribeFromChannel(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD176High

org.kuali.rice.kew.actionitem.ActionItemComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actionitem.ActionItemComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE29Medium

org.kuali.rice.kew.actionlist.ActionListFilter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actionlist.ActionListFilter.getCreateDateFrom() may expose internal representation by returning ActionListFilter.createDateFromMALICIOUS_CODEEI_EXPOSE_REP69Medium
org.kuali.rice.kew.actionlist.ActionListFilter.getCreateDateTo() may expose internal representation by returning ActionListFilter.createDateToMALICIOUS_CODEEI_EXPOSE_REP149Medium
org.kuali.rice.kew.actionlist.ActionListFilter.getLastAssignedDateFrom() may expose internal representation by returning ActionListFilter.lastAssignedDateFromMALICIOUS_CODEEI_EXPOSE_REP155Medium
org.kuali.rice.kew.actionlist.ActionListFilter.getLastAssignedDateTo() may expose internal representation by returning ActionListFilter.lastAssignedDateToMALICIOUS_CODEEI_EXPOSE_REP135Medium
org.kuali.rice.kew.actionlist.ActionListFilter.setCreateDateFrom(Date) may expose internal representation by storing an externally mutable object into ActionListFilter.createDateFromMALICIOUS_CODEEI_EXPOSE_REP272Medium
org.kuali.rice.kew.actionlist.ActionListFilter.setCreateDateTo(Date) may expose internal representation by storing an externally mutable object into ActionListFilter.createDateToMALICIOUS_CODEEI_EXPOSE_REP2152Medium
org.kuali.rice.kew.actionlist.ActionListFilter.setLastAssignedDateFrom(Date) may expose internal representation by storing an externally mutable object into ActionListFilter.lastAssignedDateFromMALICIOUS_CODEEI_EXPOSE_REP2158Medium
org.kuali.rice.kew.actionlist.ActionListFilter.setLastAssignedDateTo(Date) may expose internal representation by storing an externally mutable object into ActionListFilter.lastAssignedDateToMALICIOUS_CODEEI_EXPOSE_REP2138Medium

org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImpl

BugCategoryDetailsLinePriority
Dead store to filterDescription in org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImpl.addToFilterDescription(String, String)STYLEDLS_DEAD_LOCAL_STORE446High

org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOOjbImpl

BugCategoryDetailsLinePriority
Dead store to filterDescription in org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOOjbImpl.addToFilterDescription(String, String)STYLEDLS_DEAD_LOCAL_STORE551High

org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of docType in org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl.validateActionItem(ActionItem)CORRECTNESSNP_NULL_ON_SOME_PATH263Medium
Possible null pointer dereference of docType in org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl.validateActionItem(ActionItem)CORRECTNESSNP_NULL_ON_SOME_PATH263Medium
Possible null pointer dereference of docType in org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl.validateActionItem(ActionItem)CORRECTNESSNP_NULL_ON_SOME_PATH263Medium
Nullcheck of docType at line 267 of value previously dereferenced in org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl.validateActionItem(ActionItem)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE263Medium

org.kuali.rice.kew.actionlist.web.ActionListAction$ActionItemComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actionlist.web.ActionListAction$ActionItemComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE801Medium

org.kuali.rice.kew.actionlist.web.ActionListForm

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actionlist.web.ActionListForm.getOutboxItems() may expose internal representation by returning ActionListForm.outboxItemsMALICIOUS_CODEEI_EXPOSE_REP285Medium
org.kuali.rice.kew.actionlist.web.ActionListForm.setOutboxItems(String[]) may expose internal representation by storing an externally mutable object into ActionListForm.outboxItemsMALICIOUS_CODEEI_EXPOSE_REP2289Medium

org.kuali.rice.kew.actionrequest.ActionRequestFactory

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.actionrequest.ActionRequestFactory.addRoleResponsibilityRequest(List, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR396Medium

org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl

BugCategoryDetailsLinePriority
Questionable cast from Collection to abstract class java.util.List in org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl.findAllValidRequests(String, Collection, String)STYLEBC_BAD_CAST_TO_ABSTRACT_COLLECTION526High
Dead store to matchedArs in org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl.findAllValidRequests(String, Collection, String)STYLEDLS_DEAD_LOCAL_STORE524High

org.kuali.rice.kew.actions.DisapproveAction

BugCategoryDetailsLinePriority
Nullcheck of systemUserWorkgroup at line 182 of value previously dereferenced in org.kuali.rice.kew.actions.DisapproveAction.generateNotifications(RouteNodeInstance)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE182Medium

org.kuali.rice.kew.actions.LogDocumentActionAction

BugCategoryDetailsLinePriority
Dead store to actionTaken in org.kuali.rice.kew.actions.LogDocumentActionAction.recordAction()STYLEDLS_DEAD_LOCAL_STORE79Medium

org.kuali.rice.kew.actions.SuperUserActionTakenEvent

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actions.SuperUserActionTakenEvent.AUTHORIZATION isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL47High

org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOJpaImpl

BugCategoryDetailsLinePriority
Impossible cast from org.kuali.rice.core.framework.persistence.jpa.criteria.QueryByCriteria to java.util.List in org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOJpaImpl.findByDocumentIdIgnoreCurrentInd(String)CORRECTNESSBC_IMPOSSIBLE_CAST95High

org.kuali.rice.kew.attribute.XMLAttributeUtils

BugCategoryDetailsLinePriority
Call to equals() comparing unrelated class and interface in org.kuali.rice.kew.attribute.XMLAttributeUtils.establishFieldLookup(Field, Node)CORRECTNESSEC_UNRELATED_CLASS_AND_INTERFACE48High
Call to equals() comparing unrelated class and interface in org.kuali.rice.kew.attribute.XMLAttributeUtils.establishFieldLookup(Field, Node)CORRECTNESSEC_UNRELATED_CLASS_AND_INTERFACE45High

org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Impossible downcast of toArray() result to String[] in org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl.setRowsAfterClear(DocSearchCriteriaDTO, Map)CORRECTNESSBC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY644High
Class org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl defines non-transient non-serializable instance field dateTimeServiceBAD_PRACTICESE_BAD_FIELDMedium
Class org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl defines non-transient non-serializable instance field processorBAD_PRACTICESE_BAD_FIELDMedium
org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter stored into non-transient field DocSearchCriteriaDTOLookupableHelperServiceImpl.processorBAD_PRACTICESE_BAD_FIELD_STORE501Medium
org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter stored into non-transient field DocSearchCriteriaDTOLookupableHelperServiceImpl.processorBAD_PRACTICESE_BAD_FIELD_STORE582Medium

org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
instanceof will always return false in org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean), since a String can't be a BooleanCORRECTNESSBC_IMPOSSIBLE_INSTANCEOF209Medium
instanceof will always return false in org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean), since a String can't be a java.sql.DateCORRECTNESSBC_IMPOSSIBLE_INSTANCEOF215Medium
instanceof will always return false in org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean), since a String can't be a java.util.CollectionCORRECTNESSBC_IMPOSSIBLE_INSTANCEOF221Medium
Dead store to pkNames in org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean)STYLEDLS_DEAD_LOCAL_STORE144Medium
Dead store to returnKeys in org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean)STYLEDLS_DEAD_LOCAL_STORE143Medium
Dead store to user in org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean)STYLEDLS_DEAD_LOCAL_STORE145Medium
Class org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl defines non-transient non-serializable instance field dateTimeServiceBAD_PRACTICESE_BAD_FIELDMedium
Class org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl defines non-transient non-serializable instance field processorBAD_PRACTICESE_BAD_FIELDMedium
org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter stored into non-transient field DocumentRouteHeaderValueLookupableHelperServiceImpl.processorBAD_PRACTICESE_BAD_FIELD_STORE378Medium
Method org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.constructCriteria(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR297Medium

org.kuali.rice.kew.config.ThinClientResourceLoader

BugCategoryDetailsLinePriority
org.kuali.rice.kew.config.ThinClientResourceLoader.configureDefaultHttpClientParams(HttpParams) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR233Medium
Method org.kuali.rice.kew.config.ThinClientResourceLoader.initializeHttpClientParams() makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR199Medium

org.kuali.rice.kew.docsearch.DocSearchUtils

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kew.docsearch.DocSearchUtils.addSearchableAttributesToCriteria(DocSearchCriteriaDTO, List, String, boolean), since all org.kuali.rice.kns.web.ui.Field are instances of org.kuali.rice.kns.web.ui.FieldSTYLEBC_VACUOUS_INSTANCEOF304Medium
instanceof will always return true in org.kuali.rice.kew.docsearch.DocSearchUtils.buildSearchableAttributesFromString(String, String), since all org.kuali.rice.kns.web.ui.Field are instances of org.kuali.rice.kns.web.ui.FieldSTYLEBC_VACUOUS_INSTANCEOF129Medium

org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder.addSearchableAttributesToCriteria(DocSearchCriteriaDTO, Map), since all org.kuali.rice.kns.web.ui.Field are instances of org.kuali.rice.kns.web.ui.FieldSTYLEBC_VACUOUS_INSTANCEOF107Medium
Method org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder.populateCriteria(Map) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION59Medium
Method org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder.addSearchableAttributesToCriteria(DocSearchCriteriaDTO, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR139Medium
Method org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder.populateCriteria(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR48Medium

org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter

BugCategoryDetailsLinePriority
Dead store to searchAttRows in org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter.getRows(DocumentType, List, boolean, boolean)STYLEDLS_DEAD_LOCAL_STORE70Medium

org.kuali.rice.kew.docsearch.SearchableAttributeDateTimeValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.SearchableAttributeDateTimeValue.isRangeValid(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL205Medium

org.kuali.rice.kew.docsearch.SearchableAttributeFloatValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.SearchableAttributeFloatValue.isRangeValid(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL241Medium

org.kuali.rice.kew.docsearch.SearchableAttributeLongValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.SearchableAttributeLongValue.isRangeValid(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL234Medium

org.kuali.rice.kew.docsearch.SearchableAttributeStringValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.SearchableAttributeStringValue.isRangeValid(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL159Medium

org.kuali.rice.kew.docsearch.StandardDocumentSearchCriteriaProcessor

BugCategoryDetailsLinePriority
Self assignment of field StandardDocumentSearchCriteriaProcessor.searchingUser in org.kuali.rice.kew.docsearch.StandardDocumentSearchCriteriaProcessor.setSearchingUser(String)CORRECTNESSSA_FIELD_SELF_ASSIGNMENT50High

org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator

BugCategoryDetailsLinePriority
Dead store to queryTableColumnName in org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.generateSearchableAttributeSql(SearchAttributeCriteriaComponent, String, int)STYLEDLS_DEAD_LOCAL_STORE642Medium
Method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.getDocRouteStatusSql(String, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION1693Medium
Method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.getViewerSql(String, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION1513Medium
Write to static field org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.searchableAttributes from instance method new org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD97High
Write to static field org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.searchableAttributes from instance method new org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator(List)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD105High
Write to static field org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.criteria from instance method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.setCriteria(DocSearchCriteriaDTO)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD113High
Write to static field org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.searchableAttributes from instance method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.setSearchableAttributes(List)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD121High
Write to static field org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.searchingUser from instance method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.setSearchingUser(String)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD129High
Method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.combineAndFormatSearchableComponents(List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR453Medium
Method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.getSearchableAttributeSql(List, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR624Medium

org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor.addSearchableAttributeColumnsBasedOnFields(List, DocSearchCriteriaDTO, List), since all org.kuali.rice.kns.web.ui.Field are instances of org.kuali.rice.kns.web.ui.FieldSTYLEBC_VACUOUS_INSTANCEOF285Medium
instanceof will always return true in org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor.getFields(DocSearchCriteriaDTO, List), since all org.kuali.rice.kns.web.ui.Field are instances of org.kuali.rice.kns.web.ui.FieldSTYLEBC_VACUOUS_INSTANCEOF382Medium
instanceof will always return true in org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor.setUpCustomDisplayColumns(DocSearchCriteriaDTO, List), since all org.kuali.rice.kns.web.ui.Column are instances of org.kuali.rice.kns.web.ui.ColumnSTYLEBC_VACUOUS_INSTANCEOF95Medium
instanceof will always return true in org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor.setUpCustomDisplayColumns(DocSearchCriteriaDTO, List), since all org.kuali.rice.kns.web.ui.Field are instances of org.kuali.rice.kns.web.ui.FieldSTYLEBC_VACUOUS_INSTANCEOF98Medium
Dead store to sortable in org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor.constructColumnUsingKey(String, String, Boolean)STYLEDLS_DEAD_LOCAL_STORE741High
org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor.addCustomColumn(List, Column) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR338Medium

org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor$DisplayValues

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor$DisplayValues be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC417Medium

org.kuali.rice.kew.docsearch.dao.impl.DocumentSearchDAOOjbImpl

BugCategoryDetailsLinePriority
Dead store to docList in org.kuali.rice.kew.docsearch.dao.impl.DocumentSearchDAOOjbImpl.getList(DocumentSearchGenerator, DocSearchCriteriaDTO, Integer, String)STYLEDLS_DEAD_LOCAL_STORE68Medium
Dead store to documentSecurityService in org.kuali.rice.kew.docsearch.dao.impl.DocumentSearchDAOOjbImpl.getList(DocumentSearchGenerator, DocSearchCriteriaDTO, Integer, String)STYLEDLS_DEAD_LOCAL_STORE67Medium

org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl.saveSearch(String, DocSearchCriteriaDTO) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION527Medium
Private method org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl.validateNetworkId(List) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD353Medium
Private method org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl.validateNumber(List) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD395Medium

org.kuali.rice.kew.docsearch.web.SearchAttributeFormContainer

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.web.SearchAttributeFormContainer.getValues() may expose internal representation by returning SearchAttributeFormContainer.valuesMALICIOUS_CODEEI_EXPOSE_REP100Medium
new org.kuali.rice.kew.docsearch.web.SearchAttributeFormContainer(String, String[]) may expose internal representation by storing an externally mutable object into SearchAttributeFormContainer.valuesMALICIOUS_CODEEI_EXPOSE_REP245Medium
org.kuali.rice.kew.docsearch.web.SearchAttributeFormContainer.setValues(String[]) may expose internal representation by storing an externally mutable object into SearchAttributeFormContainer.valuesMALICIOUS_CODEEI_EXPOSE_REP2104Medium

org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute.getBooleanValue(NamedNodeMap, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL572Medium
org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute.getBooleanWithPotentialOverrides(ArrayList, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL564Medium
Method org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute.getSearchContent(DocumentSearchContext) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION102Medium
Private method org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute.getBooleanWithPotentialOverrides(String, NamedNodeMap, NamedNodeMap, NamedNodeMap) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD547Medium

org.kuali.rice.kew.doctype.DocumentTypeAttribute

BugCategoryDetailsLinePriority
org.kuali.rice.kew.doctype.DocumentTypeAttribute defines compareTo(Object) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS151Medium

org.kuali.rice.kew.doctype.DocumentTypePolicy

BugCategoryDetailsLinePriority
org.kuali.rice.kew.doctype.DocumentTypePolicy.copy(boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR159Medium
org.kuali.rice.kew.doctype.DocumentTypePolicy.copy(boolean) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR155Medium

org.kuali.rice.kew.doctype.DocumentTypeSecurity

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in new org.kuali.rice.kew.doctype.DocumentTypeSecurity(String, String)STYLEREC_CATCH_EXCEPTION267Medium

org.kuali.rice.kew.doctype.bo.DocumentType

BugCategoryDetailsLinePriority
Method new org.kuali.rice.kew.doctype.bo.DocumentType() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR124Medium

org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOJpaImpl

BugCategoryDetailsLinePriority
Dead store to docType in org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOJpaImpl.delete(DocumentType)STYLEDLS_DEAD_LOCAL_STORE62Medium

org.kuali.rice.kew.doctype.service.impl.DocumentSecurityServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.doctype.service.impl.DocumentSecurityServiceImpl.isAuthenticatedByPermission(String, String, String, Map, Map, SecuritySession) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR228Medium

org.kuali.rice.kew.doctype.service.impl.DocumentTypeServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.doctype.service.impl.DocumentTypeServiceImpl.versionAndSave(DocumentType) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR238Medium

org.kuali.rice.kew.document.RoutingRuleMaintainableBusRule

BugCategoryDetailsLinePriority
Dead store to extensions in org.kuali.rice.kew.document.RoutingRuleMaintainableBusRule.setRuleAttributeErrors(RuleBaseValues)STYLEDLS_DEAD_LOCAL_STORE240High

org.kuali.rice.kew.documentoperation.web.DocumentOperationAction

BugCategoryDetailsLinePriority
Dead store to ruleTemplate in org.kuali.rice.kew.documentoperation.web.DocumentOperationAction.refresh(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE629Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationAction.getDocument(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION128Medium

org.kuali.rice.kew.documentoperation.web.DocumentOperationForm

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getActionItemOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR173Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getActionRequestOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR145Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getActionTakenOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR152Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getBranchOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR166Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getNodeStateDeleteOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR180Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getRouteNodeInstanceOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR159Medium

org.kuali.rice.kew.dto.DTOConverter

BugCategoryDetailsLinePriority
Impossible downcast of toArray() result to String[] in org.kuali.rice.kew.dto.DTOConverter.convertDocumentSearchCriteriaDTO(DocumentSearchCriteriaDTO)CORRECTNESSBC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY1461High
Method org.kuali.rice.kew.dto.DTOConverter.createDocumentContentSection(Document, Element, List, String, String, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION550Medium
Method org.kuali.rice.kew.dto.DTOConverter.createDocumentContentSection(Document, Element, WorkflowAttributeDefinitionDTO[], String, String, DocumentType) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION407Medium
Method org.kuali.rice.kew.dto.DTOConverter.convertDocumentSearchCriteriaDTO(DocumentSearchCriteriaDTO) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR1456Medium
Method org.kuali.rice.kew.dto.DTOConverter.convertRouteHeader(DocumentRouteHeaderValue, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR146Medium

org.kuali.rice.kew.engine.BlanketApproveEngine$ProcessEntry

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.engine.BlanketApproveEngine$ProcessEntry be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC262Medium

org.kuali.rice.kew.engine.CompatUtils

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.CompatUtils.getLevelForNode(DocumentType, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR50Medium
Method org.kuali.rice.kew.engine.CompatUtils.getLevelForNode(RouteNode, String, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR69Medium
Method org.kuali.rice.kew.engine.CompatUtils.getNodeForLevel(DocumentType, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR78Medium
Method org.kuali.rice.kew.engine.CompatUtils.getNodeForLevel(RouteNode, Integer, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR100Medium

org.kuali.rice.kew.engine.StandardWorkflowEngine

BugCategoryDetailsLinePriority
Dead store to processContext in org.kuali.rice.kew.engine.StandardWorkflowEngine.process(String, String)STYLEDLS_DEAD_LOCAL_STORE137Medium
Method org.kuali.rice.kew.engine.StandardWorkflowEngine.handleBackwardCompatibility(RouteContext, RouteNodeInstance) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR345Medium

org.kuali.rice.kew.engine.node.FYIByNetworkId

BugCategoryDetailsLinePriority
Dead store to documentId in org.kuali.rice.kew.engine.node.FYIByNetworkId.process(RouteContext, RouteHelper)STYLEDLS_DEAD_LOCAL_STORE52Medium

org.kuali.rice.kew.engine.node.KRAMetaRuleNode$FinalApproverContext

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.engine.node.KRAMetaRuleNode$FinalApproverContext be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC218Medium

org.kuali.rice.kew.engine.node.NodeJotter

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.node.NodeJotter.orchestrateOutput(RouteNodeInstance, NodeType, NodeJotter$SplitJoinContext, int) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION72Medium
Method org.kuali.rice.kew.engine.node.NodeJotter.outputNodeInstanceToLog(RouteNodeInstance, NodeType, int) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION93Medium

org.kuali.rice.kew.engine.node.NodeType$ExtensionDepthComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.NodeType$ExtensionDepthComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE181Medium

org.kuali.rice.kew.engine.node.Process

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.node.Process.getVersionNumber() invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR132Medium

org.kuali.rice.kew.engine.node.RequestsNode$FinalApproverContext

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.engine.node.RequestsNode$FinalApproverContext be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC250Medium

org.kuali.rice.kew.engine.node.RoleNode$RoleRequestSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.RoleNode$RoleRequestSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE212Medium

org.kuali.rice.kew.engine.node.RouteNodeUtils$RouteNodeSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.RouteNodeUtils$RouteNodeSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE158Medium

org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode

BugCategoryDetailsLinePriority
Dead store to documentType in org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode.transitioningOutOf(RouteContext, RouteHelper)STYLEDLS_DEAD_LOCAL_STORE160Medium
Possible null pointer dereference of result in org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode.transitioningOutOf(RouteContext, RouteHelper)CORRECTNESSNP_NULL_ON_SOME_PATH196Medium
Nullcheck of requestNodeStop at line 247 of value previously dereferenced in org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode.canTransitionFrom(HierarchyProvider, HierarchyProvider$Stop, Collection, RouteHelper)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE247Medium

org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl.searchNodeGraphBackward(NodeGraphContext, NodeMatcher) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR317Medium

org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$NodeInstanceIdSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$NodeInstanceIdSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE399Medium

org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$RouteNodeSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$RouteNodeSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE391Medium

org.kuali.rice.kew.engine.simulation.SimulationEngine

BugCategoryDetailsLinePriority
Dead store to processContext in org.kuali.rice.kew.engine.simulation.SimulationEngine.process(String, String)STYLEDLS_DEAD_LOCAL_STORE135Medium
Method org.kuali.rice.kew.engine.simulation.SimulationEngine.createSimulationDocument(String, SimulationCriteria, RouteContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR320Medium

org.kuali.rice.kew.help.service.impl.HelpServiceImpl

BugCategoryDetailsLinePriority
Dead store to errors in org.kuali.rice.kew.help.service.impl.HelpServiceImpl.validateHelpEntry(HelpEntry)STYLEDLS_DEAD_LOCAL_STORE108High

org.kuali.rice.kew.help.web.HelpForm

BugCategoryDetailsLinePriority
Class org.kuali.rice.kew.help.web.HelpForm defines non-transient non-serializable instance field helpEntryBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kew.impl.action.WorkflowDocumentActionsServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.impl.action.WorkflowDocumentActionsServiceImpl.determineRequestedActionsInternal(DocumentRouteHeaderValue, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR319Medium

org.kuali.rice.kew.mail.service.impl.ActionListEmailServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.mail.service.impl.ActionListEmailServiceImpl.getActionListItemsStat(Collection) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR552Medium
Method org.kuali.rice.kew.mail.service.impl.ActionListEmailServiceImpl.getDailyWeeklyMessageBody(Collection) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR531Medium

org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl.generateExceptionGroupRequests(RouteContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR151Medium
Method call in org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl.placeInExceptionRouting(String, PersistedMessageBO, String) passes null for nonnull parameter of placeInExceptionRouting(String, RouteNodeInstance, PersistedMessageBO, RouteContext, DocumentRouteHeaderValue, boolean)CORRECTNESSNP_NULL_PARAM_DEREF64Medium

org.kuali.rice.kew.notes.Note

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.notes.Note.getVersionNumber() invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR260Medium

org.kuali.rice.kew.notes.web.AttachmentServlet

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.kuali.rice.kew.notes.web.AttachmentServlet.doPost(HttpServletRequest, HttpServletResponse)STYLEREC_CATCH_EXCEPTION120Medium

org.kuali.rice.kew.notes.web.NoteAction

BugCategoryDetailsLinePriority
org.kuali.rice.kew.notes.web.NoteAction.initForm(HttpServletRequest, ActionForm) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR212Medium
org.kuali.rice.kew.notes.web.NoteAction.retrieveNoteList(HttpServletRequest, NoteForm) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR241Medium
Method org.kuali.rice.kew.notes.web.NoteAction.edit(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR116Medium
Method org.kuali.rice.kew.notes.web.NoteAction.retrieveNoteList(HttpServletRequest, NoteForm) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR259Medium
Method org.kuali.rice.kew.notes.web.NoteAction.retrieveNoteList(HttpServletRequest, NoteForm) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR235Medium
note could be null and is guaranteed to be dereferenced in org.kuali.rice.kew.notes.web.NoteAction.getAuthorData(Note)CORRECTNESSNP_GUARANTEED_DEREF282Medium
Nullcheck of routeHeader at line 223 of value previously dereferenced in org.kuali.rice.kew.notes.web.NoteAction.retrieveNoteList(HttpServletRequest, NoteForm)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE223Medium

org.kuali.rice.kew.plugin.PluginConfig

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.plugin.PluginConfig.getObjects() makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR104Medium

org.kuali.rice.kew.plugin.PluginEnvironment

BugCategoryDetailsLinePriority
Inconsistent synchronization of org.kuali.rice.kew.plugin.PluginEnvironment.supressStartupFailure; locked 50% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC146Medium

org.kuali.rice.kew.plugin.PluginNameComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kew.plugin.PluginNameComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE26Medium

org.kuali.rice.kew.plugin.ServerPluginRegistry

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.plugin.ServerPluginRegistry.loadPlugins(File) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR141Medium

org.kuali.rice.kew.plugin.ZipFilePluginLoader

BugCategoryDetailsLinePriority

org.kuali.rice.kew.preferences.service.impl.PreferencesServiceImpl

BugCategoryDetailsLinePriority
Dead store to stagingDirectory in org.kuali.rice.kew.preferences.service.impl.PreferencesServiceImpl.getPreferences(String)STYLEDLS_DEAD_LOCAL_STORE96Medium

org.kuali.rice.kew.quicklinks.ActionListStats

BugCategoryDetailsLinePriority
org.kuali.rice.kew.quicklinks.ActionListStats defines compareTo(Object) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS62Medium

org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOJpaImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOJpaImpl.getInitiatedDocumentTypesList(String) invokes substring(0), which returns the original valueSTYLEDMI_USELESS_SUBSTRING96Medium

org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$1

BugCategoryDetailsLinePriority
A prepared statement is generated from a nonconstant String at org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$1.doInPersistenceBroker(PersistenceBroker) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING63High

org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$2

BugCategoryDetailsLinePriority
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$2.doInPersistenceBroker(PersistenceBroker) invokes substring(0), which returns the original valueSTYLEDMI_USELESS_SUBSTRING155Medium

org.kuali.rice.kew.resourceloader.CoreResourceLoader

BugCategoryDetailsLinePriority
org.kuali.rice.kew.resourceloader.CoreResourceLoader.useRemoteEmailServices() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR105Medium

org.kuali.rice.kew.role.XPathQualifierResolver$ResolverConfig

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.role.XPathQualifierResolver$ResolverConfig be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC227Medium

org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue

BugCategoryDetailsLinePriority
Method new org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR159Medium
Comparison of String parameter using == or != in org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue.setRouteStatus(String, boolean) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ691High
Method org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue.getCurrentRouteLevelName() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION306Medium
Method org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue.applyDocumentUpdate(DocumentUpdate) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR821Medium
Method org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue.from(Document) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR1206Medium

org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImpl.findPendingByResponsibilityIds(Set) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION215Medium

org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findByDocTypeAndAppId(String, String) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR395Medium
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findByDocTypeAndAppId(String, String) may fail to close PreparedStatementBAD_PRACTICEODR_OPEN_DATABASE_RESOURCE389Medium
Method org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findPendingByResponsibilityIds(Set) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION214Medium
Method org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findPendingByResponsibilityIds(Set) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE225High

org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl$1

BugCategoryDetailsLinePriority

org.kuali.rice.kew.routeheader.service.impl.WorkflowDocumentServiceImpl

BugCategoryDetailsLinePriority
Dead store to principal in org.kuali.rice.kew.routeheader.service.impl.WorkflowDocumentServiceImpl.takeMassActions(String, List)STYLEDLS_DEAD_LOCAL_STORE450Medium

org.kuali.rice.kew.rule.FlexRM

BugCategoryDetailsLinePriority
Dead store to actionRequests in org.kuali.rice.kew.rule.FlexRM.getActionRequests(DocumentRouteHeaderValue, RouteNode, RouteNodeInstance, String)STYLEDLS_DEAD_LOCAL_STORE208Medium
Private method org.kuali.rice.kew.rule.FlexRM.makeActionRequests(ActionRequestFactory, RouteContext, RuleBaseValues, DocumentRouteHeaderValue, ActionRequestValue, RuleDelegation) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD246Medium

org.kuali.rice.kew.rule.GroupRuleResponsibility

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.GroupRuleResponsibility doesn't override RuleResponsibility.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS26Medium

org.kuali.rice.kew.rule.KRAMetaRuleEngine

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.KRAMetaRuleEngine.getStatements() may expose internal representation by returning KRAMetaRuleEngine.statementsMALICIOUS_CODEEI_EXPOSE_REP70Medium

org.kuali.rice.kew.rule.PersonRuleResponsibility

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.PersonRuleResponsibility doesn't override RuleResponsibility.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS27Medium

org.kuali.rice.kew.rule.RuleBaseValues

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.RuleBaseValues.getRuleExtensionValueLabels() uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES185Medium
Method org.kuali.rice.kew.rule.RuleBaseValues.addRuleResponsibility(RuleResponsibility) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR269Medium
Call to equals() comparing different types in org.kuali.rice.kew.rule.RuleBaseValues.getResponsibility(Long)CORRECTNESSEC_UNRELATED_TYPES344High

org.kuali.rice.kew.rule.RuleDelegation

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.RuleDelegation.copy(boolean) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR84Medium

org.kuali.rice.kew.rule.RuleExpressionDef

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.RuleExpressionDef defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE100High

org.kuali.rice.kew.rule.RuleExtension

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.RuleExtension defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE158High

org.kuali.rice.kew.rule.RuleExtensionValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.RuleExtensionValue defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE118High

org.kuali.rice.kew.rule.RuleRoutingAttribute

BugCategoryDetailsLinePriority
Nullcheck of ruleRoutingElement at line 169 of value previously dereferenced in org.kuali.rice.kew.rule.RuleRoutingAttribute.parseDocContent(DocumentContent)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE169Medium

org.kuali.rice.kew.rule.TemplateRuleSelector

BugCategoryDetailsLinePriority
Dead store to documentContent in org.kuali.rice.kew.rule.TemplateRuleSelector.selectRules(RouteContext, DocumentRouteHeaderValue, RouteNodeInstance, String, Timestamp)STYLEDLS_DEAD_LOCAL_STORE92Medium

org.kuali.rice.kew.rule.bo.RuleTemplate

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.bo.RuleTemplate.DEFAULT_OPTION_KEYS should be package protectedMALICIOUS_CODEMS_PKGPROTECT57Medium

org.kuali.rice.kew.rule.bo.RuleTemplateAttribute

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.bo.RuleTemplateAttribute defines compareTo(RuleTemplateAttribute) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS94Medium

org.kuali.rice.kew.rule.dao.impl.RuleDAOJpaImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.dao.impl.RuleDAOJpaImpl.fetchAllRules(boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR126Medium

org.kuali.rice.kew.rule.dao.impl.RuleDAOOjbImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.dao.impl.RuleDAOOjbImpl.fetchAllRules(boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR124Medium

org.kuali.rice.kew.rule.service.impl.RuleDelegationServiceImpl

BugCategoryDetailsLinePriority
Load of known null value in org.kuali.rice.kew.rule.service.impl.RuleDelegationServiceImpl.findByResponsibilityId(String, boolean)STYLENP_LOAD_OF_KNOWN_NULL_VALUE200Medium

org.kuali.rice.kew.rule.service.impl.RuleServiceImpl$RuleDelegationSorter

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.service.impl.RuleServiceImpl$RuleDelegationSorter.compare(Object, Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR1224Medium
Should org.kuali.rice.kew.rule.service.impl.RuleServiceImpl$RuleDelegationSorter be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC1219Medium

org.kuali.rice.kew.rule.web.RoutingReportAction

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.web.RoutingReportAction.calculateRoute(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR147Medium
Method org.kuali.rice.kew.rule.web.RoutingReportAction.populateActionRequestsWithRouteLevelInformationAndIterateMagicCounter(RouteNode, List, long) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR295Medium

org.kuali.rice.kew.rule.web.RoutingReportAction$RouteReportRuleTemplateContainer

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.rule.web.RoutingReportAction$RouteReportRuleTemplateContainer be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC277Medium

org.kuali.rice.kew.rule.web.WebRuleBaseValues

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.web.WebRuleBaseValues.loadFields() uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES108Medium
Method org.kuali.rice.kew.rule.web.WebRuleBaseValues.loadFieldsWithDefaultValues() uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES214Medium

org.kuali.rice.kew.rule.web.WebRuleResponsibility

BugCategoryDetailsLinePriority
Dead store to o in org.kuali.rice.kew.rule.web.WebRuleResponsibility.injectWebMembers()STYLEDLS_DEAD_LOCAL_STORE148Medium
org.kuali.rice.kew.rule.web.WebRuleResponsibility doesn't override org.kuali.rice.kew.rule.RuleResponsibility.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS53Medium

org.kuali.rice.kew.rule.web.WebRuleResponsibility$DelegationRulesProxy

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.web.WebRuleResponsibility$DelegationRulesProxy is serializable and an inner classBAD_PRACTICESE_INNER_CLASS457Medium

org.kuali.rice.kew.rule.web.WebRuleUtils

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.web.WebRuleUtils.transformFieldConversions(List, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR313Medium

org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute

BugCategoryDetailsLinePriority
Nullcheck of map at line 502 of value previously dereferenced in org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute.getDocContent()CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE502Medium
Method org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute.getDocContent() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION493Medium

org.kuali.rice.kew.service.impl.KEWModuleService

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.service.impl.KEWModuleService.getExternalizableBusinessObjectInquiryUrl(Class, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR167Medium

org.kuali.rice.kew.service.impl.WorkflowUtilityWebServiceImpl

BugCategoryDetailsLinePriority
Dead store to principalId in org.kuali.rice.kew.service.impl.WorkflowUtilityWebServiceImpl.getDocumentStatusTransitionHistory(String)STYLEDLS_DEAD_LOCAL_STORE1101Medium
Method org.kuali.rice.kew.service.impl.WorkflowUtilityWebServiceImpl.routeNodeHasApproverActionRequest(String, String, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR681Medium
Method org.kuali.rice.kew.service.impl.WorkflowUtilityWebServiceImpl.routeNodeHasApproverActionRequest(DocumentType, String, RouteNode, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR706Medium

org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.DocumentsRoutedReport(Stats, Date, Date) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR95Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumActiveItemsReport(Stats) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR59Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumInitiatedDocsByDocTypeReport(Stats) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR153Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumUsersReport(Stats) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR128Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumberOfDocTypesReport(Stats) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR75Medium

org.kuali.rice.kew.stats.web.StatsForm

BugCategoryDetailsLinePriority
org.kuali.rice.kew.stats.web.StatsForm.getBeginningDate() may expose internal representation by returning StatsForm.beginningDateMALICIOUS_CODEEI_EXPOSE_REP248Medium
org.kuali.rice.kew.stats.web.StatsForm.getEndingDate() may expose internal representation by returning StatsForm.endingDateMALICIOUS_CODEEI_EXPOSE_REP256Medium
org.kuali.rice.kew.stats.web.StatsForm.setBeginningDate(Date) may expose internal representation by storing an externally mutable object into StatsForm.beginningDateMALICIOUS_CODEEI_EXPOSE_REP2252Medium
org.kuali.rice.kew.stats.web.StatsForm.setEndingDate(Date) may expose internal representation by storing an externally mutable object into StatsForm.endingDateMALICIOUS_CODEEI_EXPOSE_REP2260Medium
Class org.kuali.rice.kew.stats.web.StatsForm defines non-transient non-serializable instance field statsBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kew.superuser.web.SuperUserAction

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.superuser.web.SuperUserAction.actionRequestApprove(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES221Medium

org.kuali.rice.kew.superuser.web.SuperUserForm

BugCategoryDetailsLinePriority
org.kuali.rice.kew.superuser.web.SuperUserForm.getActionRequestRunPostProcessorCheck() may expose internal representation by returning SuperUserForm.actionRequestRunPostProcessorCheckMALICIOUS_CODEEI_EXPOSE_REP254Medium
org.kuali.rice.kew.superuser.web.SuperUserForm.setActionRequestRunPostProcessorCheck(String[]) may expose internal representation by storing an externally mutable object into SuperUserForm.actionRequestRunPostProcessorCheckMALICIOUS_CODEEI_EXPOSE_REP2257Medium

org.kuali.rice.kew.useroptions.UserOptions

BugCategoryDetailsLinePriority
org.kuali.rice.kew.useroptions.UserOptions defines compareTo(Object) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS117Medium

org.kuali.rice.kew.useroptions.UserOptionsId

BugCategoryDetailsLinePriority
Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kew.useroptions.UserOptionsId.equals(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE46Medium

org.kuali.rice.kew.util.ByteArrayDataSource

BugCategoryDetailsLinePriority
new org.kuali.rice.kew.util.ByteArrayDataSource(byte[], String) may expose internal representation by storing an externally mutable object into ByteArrayDataSource.dataMALICIOUS_CODEEI_EXPOSE_REP260Medium

org.kuali.rice.kew.util.Utilities$PrioritySorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.util.Utilities$PrioritySorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE101Medium

org.kuali.rice.kew.util.Utilities$RouteLogActionRequestSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.util.Utilities$RouteLogActionRequestSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE124Medium

org.kuali.rice.kew.web.FilterMapping

BugCategoryDetailsLinePriority
org.kuali.rice.kew.web.FilterMapping defines compareTo(FilterMapping) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS358Medium

org.kuali.rice.kew.web.UserLoginFilter

BugCategoryDetailsLinePriority
Unread field: org.kuali.rice.kew.web.UserLoginFilter.filterConfigPERFORMANCEURF_UNREAD_FIELD72Medium

org.kuali.rice.kew.xml.AbstractTransformationFilter$CurrentElement

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.AbstractTransformationFilter$CurrentElement be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC143Medium

org.kuali.rice.kew.xml.DocumentTypeXmlParser

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.xml.DocumentTypeXmlParser.checkForOrphanedRouteNodes(Node, Node) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION951Medium
Method org.kuali.rice.kew.xml.DocumentTypeXmlParser.parseAllDocumentTypes(Document) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR234Medium

org.kuali.rice.kew.xml.DocumentTypeXmlParser$DocTypeNode

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.DocumentTypeXmlParser$DocTypeNode be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC1454Medium

org.kuali.rice.kew.xml.DocumentTypeXmlParser$RoutePathContext

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.DocumentTypeXmlParser$RoutePathContext be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC1428Medium

org.kuali.rice.kew.xml.GroupXmlParser

BugCategoryDetailsLinePriority
Dead store to kimTypeAttributes in org.kuali.rice.kew.xml.GroupXmlParser.parseGroup(Element)STYLEDLS_DEAD_LOCAL_STORE148Medium

org.kuali.rice.kew.xml.HelpEntryXmlParser

BugCategoryDetailsLinePriority

org.kuali.rice.kew.xml.RuleTemplateXmlParser

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.xml.RuleTemplateXmlParser.parseRuleTemplateAttribute(Element, RuleTemplate) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR504Medium
Method org.kuali.rice.kew.xml.RuleTemplateXmlParser.updateRuleDefaults(Element, RuleTemplate) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR315Medium

org.kuali.rice.kew.xml.RuleXmlParser

BugCategoryDetailsLinePriority
Dead store to delegations in org.kuali.rice.kew.xml.RuleXmlParser.parseResponsibility(Element, RuleBaseValues)STYLEDLS_DEAD_LOCAL_STORE381Medium
Method org.kuali.rice.kew.xml.RuleXmlParser.setDefaultRuleValues(RuleBaseValues) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR344Medium

org.kuali.rice.kew.xml.UserXmlParser

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.xml.UserXmlParser.constructEntity(Element) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR138Medium

org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$DocumentTypeParentComparator

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$DocumentTypeParentComparator.getDepth(DocumentType) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR512Medium
Should org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$DocumentTypeParentComparator be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC497Medium

org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$SplitJoinContext

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$SplitJoinContext be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC521Medium

org.kuali.rice.kew.xml.export.GroupXmlExporter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.xml.export.GroupXmlExporter.exportGroup(Element, Group) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR87Medium

org.kuali.rice.kew.xml.export.RuleTemplateXmlExporter

BugCategoryDetailsLinePriority
Redundant nullcheck of defaultActionOption, which is known to be non-null in org.kuali.rice.kew.xml.export.RuleTemplateXmlExporter.exportDefaults(Element, RuleTemplate)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE136Medium

org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$SimpleNodeList

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$SimpleNodeList be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC254Medium

org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$XPathSegment

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$XPathSegment be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC228Medium

org.kuali.rice.kim.bo.impl.GenericPermission

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.bo.impl.GenericPermission.setDetailValues(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR126Medium

org.kuali.rice.kim.bo.impl.PersonImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kim.bo.impl.PersonImpl.identityService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kim.bo.impl.PersonImpl.personService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium

org.kuali.rice.kim.bo.ui.PersonDocumentRole

BugCategoryDetailsLinePriority
The field org.kuali.rice.kim.bo.ui.PersonDocumentRole.attributeEntry is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium
The field org.kuali.rice.kim.bo.ui.PersonDocumentRole.definitions is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium

org.kuali.rice.kim.document.GenericPermissionMaintainable

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kim.document.GenericPermissionMaintainable.prepareBusinessObject(BusinessObject), since all org.kuali.rice.kim.bo.impl.GenericPermission are instances of org.kuali.rice.krad.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF106Medium

org.kuali.rice.kim.document.IdentityManagementKimDocument

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from org.kuali.rice.krad.datadictionary.AttributeDefinition to org.kuali.rice.krad.datadictionary.KimAttributeDefinition in org.kuali.rice.kim.document.IdentityManagementKimDocument.getKimAttributeDefnId(AttributeDefinition)STYLEBC_UNCONFIRMED_CAST154Medium
org.kuali.rice.kim.document.IdentityManagementKimDocument is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID56Medium

org.kuali.rice.kim.document.rule.AttributeValidationHelper

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.document.rule.AttributeValidationHelper.convertErrors(String, Map, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR157Medium
Method org.kuali.rice.kim.document.rule.AttributeValidationHelper.convertErrorsForMappedFields(String, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR143Medium
Method org.kuali.rice.kim.document.rule.AttributeValidationHelper.moveValidationErrorsToErrorMap(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR124Medium

org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule.checkUnassignableRoles(IdentityManagementPersonDocument) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR185Medium
Method org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule.checkUnpopulatableGroups(IdentityManagementPersonDocument) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR203Medium

org.kuali.rice.kim.impl.responsibility.ResponsibilityInquirableImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.impl.responsibility.ResponsibilityInquirableImpl.buildInquirableLink(Object, String, Inquiry) uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES63Medium

org.kuali.rice.kim.impl.responsibility.ResponsibilityInternalServiceImpl

BugCategoryDetailsLinePriority
Read of unwritten field responsibilityService in org.kuali.rice.kim.impl.responsibility.ResponsibilityInternalServiceImpl.areActionsAtAssignmentLevelById(String)CORRECTNESSNP_UNWRITTEN_FIELD153Medium
Unwritten field: org.kuali.rice.kim.impl.responsibility.ResponsibilityInternalServiceImpl.responsibilityServiceCORRECTNESSUWF_UNWRITTEN_FIELD153Medium

org.kuali.rice.kim.impl.responsibility.ResponsibilityLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.impl.responsibility.ResponsibilityLookupableHelperServiceImpl.getMemberSearchResults(Map, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR105Medium
Synchronization performed on java.util.concurrent.ConcurrentMap in org.kuali.rice.kim.impl.responsibility.ResponsibilityLookupableHelperServiceImpl.getResponsibilitiesWithResponsibilitySearchCriteria(Map, boolean)MT_CORRECTNESSJLM_JSR166_UTILCONCURRENT_MONITORENTER216Medium

org.kuali.rice.kim.impl.type.KimTypeAttributesHelper

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from org.kuali.rice.krad.datadictionary.AttributeDefinition to org.kuali.rice.krad.datadictionary.KimAttributeDefinition in org.kuali.rice.kim.impl.type.KimTypeAttributesHelper.getKimAttributeDefnId(AttributeDefinition)STYLEBC_UNCONFIRMED_CAST79Medium
org.kuali.rice.kim.impl.type.KimTypeAttributesHelper is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID47Medium
Unwritten field: org.kuali.rice.kim.impl.type.KimTypeAttributesHelper.attributesCORRECTNESSUWF_UNWRITTEN_FIELD55Medium
Method org.kuali.rice.kim.impl.type.KimTypeAttributesHelper.getAttributeValue(Map, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR126Medium

org.kuali.rice.kim.impl.type.KimTypeQualifierResolver

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.type.KimTypeQualifierResolver.typeServices isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL62High

org.kuali.rice.kim.impl.type.KimTypeServiceBase

BugCategoryDetailsLinePriority
instanceof will always return false in org.kuali.rice.kim.impl.type.KimTypeServiceBase.extractErrorsFromGlobalVariablesErrorMap(String), since a org.springframework.util.AutoPopulatingList can't be a StringCORRECTNESSBC_IMPOSSIBLE_INSTANCEOF517Medium
instanceof will always return true in org.kuali.rice.kim.impl.type.KimTypeServiceBase.extractErrorsFromGlobalVariablesErrorMap(String), since all org.springframework.util.AutoPopulatingList are instances of java.util.ListSTYLEBC_VACUOUS_INSTANCEOF520Medium
Method org.kuali.rice.kim.impl.type.KimTypeServiceBase.extractErrorsFromGlobalVariablesErrorMap(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION526Medium
Method org.kuali.rice.kim.impl.type.KimTypeServiceBase.areAllAttributeValuesEmpty(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR900Medium
Method org.kuali.rice.kim.impl.type.KimTypeServiceBase.getAttributeValue(Map, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR915Medium
Method org.kuali.rice.kim.impl.type.KimTypeServiceBase.validateAttributes(String, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR185Medium
Method org.kuali.rice.kim.impl.type.KimTypeServiceBase.validateReferencesExistAndActive(KimType, Map, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR269Medium

org.kuali.rice.kim.inquiry.PermissionInquirableImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.inquiry.PermissionInquirableImpl.buildInquirableLink(Object, String, Inquiry) uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES68Medium

org.kuali.rice.kim.lookup.GroupLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.lookup.GroupLookupableHelperServiceImpl.getSearchResults(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR139Medium

org.kuali.rice.kim.lookup.KimDocumentRoleMemberLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Call to equals() comparing different types in org.kuali.rice.kim.lookup.KimDocumentRoleMemberLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean)CORRECTNESSEC_UNRELATED_TYPES66High
Call to equals() comparing different types in org.kuali.rice.kim.lookup.KimDocumentRoleMemberLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean)CORRECTNESSEC_UNRELATED_TYPES66High

org.kuali.rice.kim.lookup.PermissionLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.lookup.PermissionLookupableHelperServiceImpl.getMemberSearchResults(Map, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR121Medium
Synchronization performed on java.util.concurrent.ConcurrentMap in org.kuali.rice.kim.lookup.PermissionLookupableHelperServiceImpl.getPermissionsWithPermissionSearchCriteria(Map, boolean)MT_CORRECTNESSJLM_JSR166_UTILCONCURRENT_MONITORENTER235Medium

org.kuali.rice.kim.lookup.PersonLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Class org.kuali.rice.kim.lookup.PersonLookupableHelperServiceImpl defines non-transient non-serializable instance field titleBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kim.lookup.RoleLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.lookup.RoleLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR243Medium

org.kuali.rice.kim.lookup.RoleMemberLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.lookup.RoleMemberLookupableHelperServiceImpl.getActualSizeIfTruncated(List) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR300Medium
Redundant nullcheck of groups which is known to be null in org.kuali.rice.kim.lookup.RoleMemberLookupableHelperServiceImpl.buildRoleSearchCriteria(Map)STYLERCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE186Medium

org.kuali.rice.kim.rules.ui.PersonDocumentDelegationMemberRule

BugCategoryDetailsLinePriority
Dead store to document in org.kuali.rice.kim.rules.ui.PersonDocumentDelegationMemberRule.processAddPersonDelegationMember(AddPersonDelegationMemberEvent)STYLEDLS_DEAD_LOCAL_STORE42Medium

org.kuali.rice.kim.service.impl.GroupInternalServiceImpl$MembersDiff

BugCategoryDetailsLinePriority
Should org.kuali.rice.kim.service.impl.GroupInternalServiceImpl$MembersDiff be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC128Medium

org.kuali.rice.kim.service.impl.KimModuleService

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.service.impl.KimModuleService.getExternalizableBusinessObjectsList(Class, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR124Medium
Method org.kuali.rice.kim.service.impl.KimModuleService.getUrlParameters(String, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR211Medium

org.kuali.rice.kim.service.impl.PermissionServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.service.impl.PermissionServiceImpl.getMatchingPermissions(List, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR290Medium

org.kuali.rice.kim.service.impl.PermissionUpdateServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.service.impl.PermissionUpdateServiceImpl.savePermission(String, String, String, String, String, boolean, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR90Medium

org.kuali.rice.kim.service.impl.PersonServiceImpl

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kim.service.impl.PersonServiceImpl.convertEntityToPerson(EntityDefault, Principal), since all RuntimeException are instances of RuntimeExceptionSTYLEBC_VACUOUS_INSTANCEOF190Medium
Method org.kuali.rice.kim.service.impl.PersonServiceImpl.findPeople(Map, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR337Medium
Synchronization performed on java.util.concurrent.ConcurrentMap in org.kuali.rice.kim.service.impl.PersonServiceImpl.addPersonToCache(Person)MT_CORRECTNESSJLM_JSR166_UTILCONCURRENT_MONITORENTER211Medium
Method org.kuali.rice.kim.service.impl.PersonServiceImpl.convertPersonPropertiesToEntityProperties(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR429Medium
Method org.kuali.rice.kim.service.impl.PersonServiceImpl.findPeopleInternal(Map, boolean) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR377Medium
Method org.kuali.rice.kim.service.impl.PersonServiceImpl.getNonPersonSearchCriteria(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR640Medium
Method org.kuali.rice.kim.service.impl.PersonServiceImpl.resolvePrincipalNamesToPrincipalIds(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR705Medium

org.kuali.rice.kim.service.impl.UiDocumentServiceImpl

BugCategoryDetailsLinePriority
Dead store to origRole in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.saveRole(IdentityManagementRoleDocument)STYLEDLS_DEAD_LOCAL_STORE2019High
Dead store to pndMember in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadGroupMembers(IdentityManagementGroupDocument, List)STYLEDLS_DEAD_LOCAL_STORE2537Medium
Dead store to pndGroupQualifier in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadGroupQualifiers(IdentityManagementGroupDocument, Map)STYLEDLS_DEAD_LOCAL_STORE2563Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.getAttributeEntries(AttributeDefinitionMap) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR276Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadDelegationMemberQualifiers(IdentityManagementPersonDocument, AttributeDefinitionMap, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR478Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadDelegationMemberQualifiers(IdentityManagementRoleDocument, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR1968Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadGroupQualifiers(IdentityManagementGroupDocument, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR2570Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadRoleMemberQualifiers(IdentityManagementRoleDocument, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR1868Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.populateDocRoleQualifier(String, List, AttributeDefinitionMap) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR741Medium

org.kuali.rice.kim.service.impl.UiDocumentServiceImpl$GroupMemberNameComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kim.service.impl.UiDocumentServiceImpl$GroupMemberNameComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE2523Medium

org.kuali.rice.kim.web.struts.action.IdentityManagementPersonDocumentAction

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.web.struts.action.IdentityManagementPersonDocumentAction.addEmpInfo(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR218Medium

org.kuali.rice.kim.web.struts.action.IdentityManagementRoleDocumentAction

BugCategoryDetailsLinePriority
Method call in org.kuali.rice.kim.web.struts.action.IdentityManagementRoleDocumentAction.addResponsibility(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) passes null for nonnull parameter of org.kuali.rice.kim.document.IdentityManagementRoleDocument.addResponsibility(KimDocumentRoleResponsibility)CORRECTNESSNP_NULL_PARAM_DEREF268Medium

org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl.getButtonFieldPermissionDetails(Object, String) uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES623Medium
Unused field: org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl.dataDictionaryServicePERFORMANCEUUF_UNUSED_FIELDMedium
Unused field: org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl.documentHelperServicePERFORMANCEUUF_UNUSED_FIELDMedium

org.kuali.rice.kns.service.impl.BusinessObjectMetaDataServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.service.impl.BusinessObjectMetaDataServiceImpl.getNestedBOClass(BusinessObject, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION361Medium

org.kuali.rice.kns.service.impl.BusinessObjectSerializerServiceImpl

BugCategoryDetailsLinePriority

org.kuali.rice.kns.service.impl.DataDictionaryServiceImpl

BugCategoryDetailsLinePriority

org.kuali.rice.kns.service.impl.DictionaryValidationServiceImpl

BugCategoryDetailsLinePriority

org.kuali.rice.kns.service.impl.MaintenanceDocumentDictionaryServiceImpl

BugCategoryDetailsLinePriority
Dead store to subItems in org.kuali.rice.kns.service.impl.MaintenanceDocumentDictionaryServiceImpl.getMaintainableItem(String, String)STYLEDLS_DEAD_LOCAL_STORE400Medium
org.kuali.rice.kns.service.impl.MaintenanceDocumentDictionaryServiceImpl.LOG isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL50High

org.kuali.rice.kns.web.struts.action.KualiActionServlet

BugCategoryDetailsLinePriority
Class org.kuali.rice.kns.web.struts.action.KualiActionServlet defines non-transient non-serializable instance field serverConfigOverrideBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kns.web.struts.action.KualiActionServlet$KualiActionServletConfig

BugCategoryDetailsLinePriority
Should org.kuali.rice.kns.web.struts.action.KualiActionServlet$KualiActionServletConfig be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC115Medium

org.kuali.rice.krad.dao.impl.BusinessObjectDaoJpa

BugCategoryDetailsLinePriority
Unused field: org.kuali.rice.krad.dao.impl.BusinessObjectDaoJpa.ojbCollectionHelperPERFORMANCEUUF_UNUSED_FIELDMedium

org.kuali.rice.krad.dao.impl.LookupDaoJpa

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.dao.impl.LookupDaoJpa.executeSearch(Class, Criteria, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR202Medium
Comparison of String parameter using == or != in org.kuali.rice.krad.dao.impl.LookupDaoJpa.addLogicalOperatorCriteria(String, String, Class, boolean, Criteria, String) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ581Medium
Potentially dangerous use of non-short-circuit logic in org.kuali.rice.krad.dao.impl.LookupDaoJpa.findObjectByMap(Object, Map)STYLENS_DANGEROUS_NON_SHORT_CIRCUIT351High
Method org.kuali.rice.krad.dao.impl.LookupDaoJpa.addInactivateableFromToCurrentCriteria(Object, String, Criteria, Map) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION534Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoJpa.findCountByMap(Object, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR80Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoJpa.findObjectByMap(Object, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR347Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoJpa.getCollectionCriteriaFromMap(PersistableBusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR134Medium

org.kuali.rice.krad.dao.impl.LookupDaoOjb

BugCategoryDetailsLinePriority
Dead store to searchResults in org.kuali.rice.krad.dao.impl.LookupDaoOjb.executeSearch(Class, Criteria, boolean)STYLEDLS_DEAD_LOCAL_STORE150Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoOjb.executeSearch(Class, Criteria, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR156Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoOjb.findCountByMap(Object, Map) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR253Medium
Potentially dangerous use of non-short-circuit logic in org.kuali.rice.krad.dao.impl.LookupDaoOjb.findObjectByMap(Object, Map)STYLENS_DANGEROUS_NON_SHORT_CIRCUIT272High
Method org.kuali.rice.krad.dao.impl.LookupDaoOjb.findCountByMap(Object, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR225Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoOjb.findObjectByMap(Object, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR268Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoOjb.getCollectionCriteriaFromMap(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR89Medium

org.kuali.rice.krad.dao.impl.PersistenceDaoJpa

BugCategoryDetailsLinePriority

org.kuali.rice.krad.dao.proxy.DocumentHeaderDaoProxy

BugCategoryDetailsLinePriority
Dead store to START_INDEX in org.kuali.rice.krad.dao.proxy.DocumentHeaderDaoProxy.getDao(Class)STYLEDLS_DEAD_LOCAL_STORE28Medium

org.kuali.rice.krad.dao.proxy.MaintenanceDocumentDaoProxy

BugCategoryDetailsLinePriority
Dead store to START_INDEX in org.kuali.rice.krad.dao.proxy.MaintenanceDocumentDaoProxy.getDao(Class)STYLEDLS_DEAD_LOCAL_STORE32Medium

org.kuali.rice.krad.dao.proxy.NoteDaoProxy

BugCategoryDetailsLinePriority
Dead store to START_INDEX in org.kuali.rice.krad.dao.proxy.NoteDaoProxy.getDao(Class)STYLEDLS_DEAD_LOCAL_STORE32Medium

org.kuali.rice.krad.dao.proxy.PersistedLookupMetadataDaoProxy

BugCategoryDetailsLinePriority
Dead store to START_INDEX in org.kuali.rice.krad.dao.proxy.PersistedLookupMetadataDaoProxy.getDao(Class)STYLEDLS_DEAD_LOCAL_STORE32Medium

org.kuali.rice.krad.dao.proxy.PersistenceDaoProxy

BugCategoryDetailsLinePriority
Dead store to entityManager in org.kuali.rice.krad.dao.proxy.PersistenceDaoProxy.getDao(Class)STYLEDLS_DEAD_LOCAL_STORE59Medium

org.kuali.rice.krad.document.authorization.MaintenanceDocumentAuthorizerBase

BugCategoryDetailsLinePriority
org.kuali.rice.krad.document.authorization.MaintenanceDocumentAuthorizerBase.documentDictionaryService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium

org.kuali.rice.krad.service.impl.AttachmentServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.service.impl.AttachmentServiceImpl.createAttachment(PersistableBusinessObject, String, String, int, InputStream, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR92Medium
org.kuali.rice.krad.service.impl.AttachmentServiceImpl.deleteAttachmentContents(Attachment) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE166Medium
org.kuali.rice.krad.service.impl.AttachmentServiceImpl.deletePendingAttachmentsModifiedBefore(long) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE246Medium
org.kuali.rice.krad.service.impl.AttachmentServiceImpl.moveAttachmentFromPending(Attachment, String) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE155Medium

org.kuali.rice.krad.service.impl.BusinessObjectSerializerServiceImpl

BugCategoryDetailsLinePriority
Dead store to maintenanceDocumentEntry in org.kuali.rice.krad.service.impl.BusinessObjectSerializerServiceImpl.getPropertySerizabilityEvaluator(Object)STYLEDLS_DEAD_LOCAL_STORE60Medium

org.kuali.rice.krad.service.impl.BusinessObjectServiceImpl

BugCategoryDetailsLinePriority
Possible doublecheck on org.kuali.rice.krad.service.impl.BusinessObjectServiceImpl.illegalBusinessObjectsForSaveInitialized in org.kuali.rice.krad.service.impl.BusinessObjectServiceImpl.isBusinessObjectAllowedForSave(PersistableBusinessObject)MT_CORRECTNESSDC_DOUBLECHECK124Medium

org.kuali.rice.krad.service.impl.DataObjectMetaDataServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.service.impl.DataObjectMetaDataServiceImpl.equalsByPrimaryKeys(Object, Object) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR123Medium

org.kuali.rice.krad.service.impl.DictionaryValidationServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.service.impl.DictionaryValidationServiceImpl.validateBusinessObjectsFromDescriptors(Object, PropertyDescriptor[], int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR398Medium

org.kuali.rice.krad.service.impl.DocumentServiceImpl

BugCategoryDetailsLinePriority
Inconsistent synchronization of org.kuali.rice.krad.service.impl.DocumentServiceImpl.workflowDocumentService; locked 66% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC1151Medium

org.kuali.rice.krad.service.impl.InactivateableFromToServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.service.impl.InactivateableFromToServiceImpl.buildGroupByValueString(BusinessObject, List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION195Medium

org.kuali.rice.krad.service.impl.InactivationBlockingDisplayServiceImpl

BugCategoryDetailsLinePriority
Unread field: org.kuali.rice.krad.service.impl.InactivationBlockingDisplayServiceImpl.persistenceServicePERFORMANCEURF_UNREAD_FIELD135Medium

org.kuali.rice.krad.service.impl.KualiExceptionIncidentServiceImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of exceptionIncident in org.kuali.rice.krad.service.impl.KualiExceptionIncidentServiceImpl.report(KualiExceptionIncident)CORRECTNESSNP_NULL_ON_SOME_PATH189High

org.kuali.rice.krad.service.impl.MaintenanceDocumentServiceImpl

BugCategoryDetailsLinePriority
Dead store to user in org.kuali.rice.krad.service.impl.MaintenanceDocumentServiceImpl.clearUnauthorizedNewFields(MaintenanceDocument)STYLEDLS_DEAD_LOCAL_STORE299Medium

org.kuali.rice.krad.service.impl.ModuleServiceBase

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.service.impl.ModuleServiceBase.getExternalizableBusinessObjectLookupUrl(Class, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR231Medium
Method org.kuali.rice.krad.service.impl.ModuleServiceBase.getUrlParameters(String, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR192Medium

org.kuali.rice.krad.service.impl.PersistenceStructureServiceJpaImpl

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.krad.service.impl.PersistenceStructureServiceJpaImpl.listCollectionObjectTypes(PersistableBusinessObject), since all org.kuali.rice.krad.bo.PersistableBusinessObject are instances of org.kuali.rice.krad.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF606Medium
instanceof will always return true in org.kuali.rice.krad.service.impl.PersistenceStructureServiceJpaImpl.listReferenceObjectFields(PersistableBusinessObject), since all org.kuali.rice.krad.bo.PersistableBusinessObject are instances of org.kuali.rice.krad.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF621Medium
org.kuali.rice.krad.service.impl.PersistenceStructureServiceJpaImpl.referenceConversionMap isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL59High

org.kuali.rice.krad.service.impl.PersistenceStructureServiceOjbImpl

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.krad.service.impl.PersistenceStructureServiceOjbImpl.listCollectionObjectTypes(PersistableBusinessObject), since all org.kuali.rice.krad.bo.PersistableBusinessObject are instances of org.kuali.rice.krad.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF648Medium
instanceof will always return true in org.kuali.rice.krad.service.impl.PersistenceStructureServiceOjbImpl.listReferenceObjectFields(PersistableBusinessObject), since all org.kuali.rice.krad.bo.PersistableBusinessObject are instances of org.kuali.rice.krad.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF663Medium
org.kuali.rice.krad.service.impl.PersistenceStructureServiceOjbImpl.referenceConversionMap isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL63High

org.kuali.rice.krad.service.impl.PostProcessorServiceImpl

BugCategoryDetailsLinePriority
Call to equals() comparing different types in org.kuali.rice.krad.service.impl.PostProcessorServiceImpl.doActionTaken(ActionTakenEventDTO)CORRECTNESSEC_UNRELATED_TYPES143High

org.kuali.rice.krad.service.impl.PredicateFactoryLookup

BugCategoryDetailsLinePriority
Dead store to caseInsensitive in org.kuali.rice.krad.service.impl.PredicateFactoryLookup.createFromComplexCriteriaValue(Class, String, String, String)STYLEDLS_DEAD_LOCAL_STORE183Medium

org.kuali.rice.krad.service.impl.RiceApplicationConfigurationMediationServiceImpl

BugCategoryDetailsLinePriority
Synchronization performed on java.util.concurrent.ConcurrentMap in org.kuali.rice.krad.service.impl.RiceApplicationConfigurationMediationServiceImpl.getConfigurationParameter(String, String)MT_CORRECTNESSJLM_JSR166_UTILCONCURRENT_MONITORENTER75Medium
Synchronization performed on java.util.concurrent.ConcurrentMap in org.kuali.rice.krad.service.impl.RiceApplicationConfigurationMediationServiceImpl.getNonDatabaseComponents()MT_CORRECTNESSJLM_JSR166_UTILCONCURRENT_MONITORENTER115Medium

org.kuali.rice.krad.service.impl.SessionDocumentServiceImpl

BugCategoryDetailsLinePriority
Dead store to key in org.kuali.rice.krad.service.impl.SessionDocumentServiceImpl.setDocumentForm(DocumentFormBase, UserSession, String)STYLEDLS_DEAD_LOCAL_STORE214Medium

org.kuali.rice.krad.uif.service.impl.ExpressionEvaluatorServiceImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of replacers in org.kuali.rice.krad.uif.service.impl.ExpressionEvaluatorServiceImpl.evaluatePropertyReplacers(Object, Object, Map)CORRECTNESSNP_NULL_ON_SOME_PATH148Medium

org.kuali.rice.krad.uif.service.impl.InquiryViewTypeServiceImpl

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from org.kuali.rice.krad.uif.container.View to org.kuali.rice.krad.uif.container.InquiryView in org.kuali.rice.krad.uif.service.impl.InquiryViewTypeServiceImpl.getParametersFromView(View)STYLEBC_UNCONFIRMED_CAST48Medium

org.kuali.rice.krad.uif.service.impl.LookupViewTypeServiceImpl

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from org.kuali.rice.krad.uif.container.View to org.kuali.rice.krad.uif.container.LookupView in org.kuali.rice.krad.uif.service.impl.LookupViewTypeServiceImpl.getParametersFromView(View)STYLEBC_UNCONFIRMED_CAST48Medium

org.kuali.rice.krad.uif.service.impl.MaintenanceViewTypeServiceImpl

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from org.kuali.rice.krad.uif.container.View to org.kuali.rice.krad.uif.container.MaintenanceView in org.kuali.rice.krad.uif.service.impl.MaintenanceViewTypeServiceImpl.getParametersFromView(View)STYLEBC_UNCONFIRMED_CAST61Medium

org.kuali.rice.krad.workflow.attribute.DataDictionaryDocumentSearchCustomizer

BugCategoryDetailsLinePriority
Class org.kuali.rice.krad.workflow.attribute.DataDictionaryDocumentSearchCustomizer defines non-transient non-serializable instance field documentSearchGeneratorBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.krad.workflow.attribute.DataDictionarySearchableAttribute

BugCategoryDetailsLinePriority
Dead store to boEntry in org.kuali.rice.krad.workflow.attribute.DataDictionarySearchableAttribute.createFieldRowsForBusinessObject(Class)STYLEDLS_DEAD_LOCAL_STORE440Medium
Method org.kuali.rice.krad.workflow.attribute.DataDictionarySearchableAttribute.validateUserSearchInputs(Map, DocumentSearchContext) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR207Medium

org.kuali.rice.krad.workflow.attribute.KualiXmlAttributeHelper

BugCategoryDetailsLinePriority
Dead store to theEnd in org.kuali.rice.krad.workflow.attribute.KualiXmlAttributeHelper.getXPathTerms(Element)STYLEDLS_DEAD_LOCAL_STORE431Medium

org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl.buildSearchableFixnumAttribute(String, Object) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR319Medium
Method org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl.copyQualifications(Map, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR186Medium

org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl$RoutingAttributeTracker

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl$RoutingAttributeTracker.checkPoint() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR506Medium
Should org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl$RoutingAttributeTracker be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC483Medium

org.kuali.rice.ksb.cache.RiceCacheAdministratorImpl

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.cache.RiceCacheAdministratorImpl.loadCacheSettings() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR145Medium

org.kuali.rice.ksb.cache.RiceDistributedCacheListener

BugCategoryDetailsLinePriority
Primitive value is boxed and then immediately unboxed in org.kuali.rice.ksb.cache.RiceDistributedCacheListener.initialize(Cache, Config)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED65Medium
org.kuali.rice.ksb.cache.RiceDistributedCacheListener.initialize(Cache, Config) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR65Medium

org.kuali.rice.ksb.impl.registry.ServiceDescriptorBo

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.impl.registry.ServiceDescriptorBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID60Medium

org.kuali.rice.ksb.messaging.HttpException

BugCategoryDetailsLinePriority

org.kuali.rice.ksb.messaging.MessageServiceInvoker

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.MessageServiceInvoker.run() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR77Medium

org.kuali.rice.ksb.messaging.dao.impl.MessageQueueDAOOjbImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.ksb.messaging.dao.impl.MessageQueueDAOOjbImpl.findByValues(Map, int) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR87Medium

org.kuali.rice.ksb.messaging.exceptionhandling.DefaultMessageExceptionHandler

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.exceptionhandling.DefaultMessageExceptionHandler.getImmediateExceptionRouting() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR143Medium
Method org.kuali.rice.ksb.messaging.exceptionhandling.DefaultMessageExceptionHandler.requeue(Throwable, PersistedMessageBO) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR93Medium

org.kuali.rice.ksb.messaging.quartz.KSBSchedulerFactoryBean

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.quartz.KSBSchedulerFactoryBean.afterPropertiesSet() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR68Medium
Unused field: org.kuali.rice.ksb.messaging.quartz.KSBSchedulerFactoryBean.transactionManagerPERFORMANCEUUF_UNUSED_FIELDMedium

org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector.configureDefaultHttpClientParams(HttpParams) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR139Medium
Method org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector.configureDefaultHttpClientParams(HttpParams) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR132Medium
Method org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector.initializeHttpClientParams() makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR118Medium

org.kuali.rice.ksb.messaging.serviceproxies.MessageSendingTransactionSynchronization

BugCategoryDetailsLinePriority
Write to static field org.kuali.rice.ksb.messaging.serviceproxies.MessageSendingTransactionSynchronization.CALLED_TRANS_COMMITTED from instance method org.kuali.rice.ksb.messaging.serviceproxies.MessageSendingTransactionSynchronization.afterCompletion(int)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD53Medium
Write to static field org.kuali.rice.ksb.messaging.serviceproxies.MessageSendingTransactionSynchronization.CALLED_TRANS_ROLLEDBACKED from instance method org.kuali.rice.ksb.messaging.serviceproxies.MessageSendingTransactionSynchronization.afterCompletion(int)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD56Medium

org.kuali.rice.ksb.messaging.servlet.KSBDispatcherServlet

BugCategoryDetailsLinePriority
Class org.kuali.rice.ksb.messaging.servlet.KSBDispatcherServlet defines non-transient non-serializable instance field cxfServletControllerBAD_PRACTICESE_BAD_FIELDMedium
Class org.kuali.rice.ksb.messaging.servlet.KSBDispatcherServlet defines non-transient non-serializable instance field httpInvokerHandlerBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.ksb.messaging.threadpool.PriorityBlockingQueuePersistedMessageComparator

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.threadpool.PriorityBlockingQueuePersistedMessageComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE32Medium

org.kuali.rice.ksb.messaging.web.MessageQueueAction

BugCategoryDetailsLinePriority
Method org.kuali.rice.ksb.messaging.web.MessageQueueAction.quickRequeueMessage(PersistedMessageBO) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR205Medium
Call to equals() comparing different types in org.kuali.rice.ksb.messaging.web.MessageQueueAction.establishRequiredState(HttpServletRequest, ActionForm)CORRECTNESSEC_UNRELATED_TYPES338High

org.kuali.rice.ksb.messaging.web.ThreadPoolForm

BugCategoryDetailsLinePriority
Class org.kuali.rice.ksb.messaging.web.ThreadPoolForm defines non-transient non-serializable instance field threadPoolBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.ksb.security.SignatureVerifyingInputStream

BugCategoryDetailsLinePriority
new org.kuali.rice.ksb.security.SignatureVerifyingInputStream(byte[], Signature, InputStream) may expose internal representation by storing an externally mutable object into SignatureVerifyingInputStream.digitalSignatureMALICIOUS_CODEEI_EXPOSE_REP240Medium

org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer.getCreateDate() may expose internal representation by returning KeyStoreEntryDataContainer.createDateMALICIOUS_CODEEI_EXPOSE_REP82Medium
new org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer(String, Date) may expose internal representation by storing an externally mutable object into KeyStoreEntryDataContainer.createDateMALICIOUS_CODEEI_EXPOSE_REP250Medium
org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer.setCreateDate(Date) may expose internal representation by storing an externally mutable object into KeyStoreEntryDataContainer.createDateMALICIOUS_CODEEI_EXPOSE_REP289Medium

org.kuali.rice.ksb.security.admin.service.impl.JavaSecurityManagementServiceImpl

BugCategoryDetailsLinePriority
Unread field: org.kuali.rice.ksb.security.admin.service.impl.JavaSecurityManagementServiceImpl.CLIENT_CERT_EXPIRATION_DAYS; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC58Medium

org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction

BugCategoryDetailsLinePriority
Dead store to form in org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction.clear(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE81High
Dead store to form in org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction.generateClientKeyStore(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE121High
Dead store to data in org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction.generateClientKeyStore(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE100Medium
The parameter form to org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction.clear(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) is dead upon entry but overwrittenCORRECTNESSIP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN81High

org.kuali.rice.ksb.util.KSBConstants

BugCategoryDetailsLinePriority
Method org.kuali.rice.ksb.util.KSBConstants.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR71Medium