The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.core.framework.persistence.jdbc.datasource.RiceXADataSource doesn't override org.enhydra.jdbc.standard.StandardDataSource.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 44 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.core.framework.persistence.jdbc.datasource.RiceXADataSource$PreparedStatementCachingConnection doesn't override org.apache.commons.dbcp.DelegatingConnection.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 142 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.core.framework.persistence.jdbc.sql.Criteria.getParameteres(List, Map) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 391 | Medium |
| Method org.kuali.rice.core.framework.persistence.jdbc.sql.Criteria.prepareParameters(Query, List, Map) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 411 | Medium |
| Method org.kuali.rice.core.framework.persistence.jdbc.sql.Criteria.buildWhere(Criteria) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 367 | Medium |
| Method org.kuali.rice.core.framework.persistence.jdbc.sql.Criteria.in(String, List, Class) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 266 | Medium |
| Method org.kuali.rice.core.framework.persistence.jdbc.sql.Criteria.notIn(String, List, Class) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 277 | Medium |
| Method org.kuali.rice.core.framework.persistence.jdbc.sql.Criteria.toQuery(QueryByCriteria$QueryByCriteriaType) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 325 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.rice.core.framework.persistence.jdbc.sql.Criteria$AndCriteria be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 427 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.rice.core.framework.persistence.jdbc.sql.Criteria$ExistsCriteria be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 443 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.rice.core.framework.persistence.jdbc.sql.Criteria$OrCriteria be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 435 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String parameter using == or != in org.kuali.rice.core.framework.persistence.jdbc.sql.SqlBuilder.addLogicalOperatorCriteria(String, String, Class, boolean, Criteria, String, boolean) | BAD_PRACTICE | ES_COMPARING_PARAMETER_STRING_WITH_EQ | 180 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to otherClass in org.kuali.rice.core.framework.persistence.jpa.CompositePrimaryKeyBase.equals(Object) | STYLE | DLS_DEAD_LOCAL_STORE | 33 | Medium |
| org.kuali.rice.core.framework.persistence.jpa.CompositePrimaryKeyBase.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | 32 | High |
| Nullcheck of o at line 37 of value previously dereferenced in org.kuali.rice.core.framework.persistence.jpa.CompositePrimaryKeyBase.equals(Object) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 33 | High |
| Exception is caught when Exception is not thrown in org.kuali.rice.core.framework.persistence.jpa.CompositePrimaryKeyBase.toString() | STYLE | REC_CATCH_EXCEPTION | 138 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.core.framework.persistence.jpa.OrmUtils.isJpaAnnotated(Class) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 140 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to valueLen in org.kuali.rice.core.framework.persistence.jpa.criteria.Criteria.fixSearchPattern(String) | STYLE | DLS_DEAD_LOCAL_STORE | 393 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.core.framework.persistence.jpa.metadata.CollectionDescriptor.getCascade() may expose internal representation by returning CollectionDescriptor.cascade | MALICIOUS_CODE | EI_EXPOSE_REP | 86 | Medium |
| org.kuali.rice.core.framework.persistence.jpa.metadata.CollectionDescriptor.setCascade(CascadeType[]) may expose internal representation by storing an externally mutable object into CollectionDescriptor.cascade | MALICIOUS_CODE | EI_EXPOSE_REP2 | 90 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.core.framework.persistence.jpa.metadata.EntityDescriptor defines non-transient non-serializable instance field sequence | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.core.framework.persistence.jpa.metadata.FieldDescriptor defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 208 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.core.framework.persistence.jpa.metadata.MetadataManager.convertPrimaryKeyMapToObject(Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 217 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.core.framework.persistence.jpa.metadata.ObjectDescriptor.getCascade() may expose internal representation by returning ObjectDescriptor.cascade | MALICIOUS_CODE | EI_EXPOSE_REP | 68 | Medium |
| org.kuali.rice.core.framework.persistence.jpa.metadata.ObjectDescriptor.setCascade(CascadeType[]) may expose internal representation by storing an externally mutable object into ObjectDescriptor.cascade | MALICIOUS_CODE | EI_EXPOSE_REP2 | 72 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.kuali.rice.core.framework.persistence.jpa.type.HibernateKualiDecimalPercentFieldType.nullSafeGet(ResultSet, String[], Object), since all java.math.BigDecimal are instances of java.math.BigDecimal | STYLE | BC_VACUOUS_INSTANCEOF | 52 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.kuali.rice.core.framework.persistence.jpa.type.HibernateKualiDecimalPercentageFieldType.nullSafeGet(ResultSet, String[], Object), since all java.math.BigDecimal are instances of java.math.BigDecimal | STYLE | BC_VACUOUS_INSTANCEOF | 47 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.kuali.rice.core.framework.persistence.jpa.type.HibernateKualiIntegerFieldType.nullSafeGet(ResultSet, String[], Object), since all Long are instances of Long | STYLE | BC_VACUOUS_INSTANCEOF | 47 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Impossible cast from org.kuali.rice.core.util.type.KualiInteger to Long in org.kuali.rice.core.framework.persistence.jpa.type.HibernateKualiIntegerPercentageFieldType.nullSafeSet(PreparedStatement, Object, int) | CORRECTNESS | BC_IMPOSSIBLE_CAST | 73 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.kuali.rice.core.framework.persistence.jpa.type.HibernateKualiPercentFieldType.nullSafeGet(ResultSet, String[], Object), since all java.math.BigDecimal are instances of java.math.BigDecimal | STYLE | BC_VACUOUS_INSTANCEOF | 48 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.kuali.rice.core.framework.persistence.ojb.BaseOjbConfigurer(String[], String) may expose internal representation by storing an externally mutable object into BaseOjbConfigurer.jcdAliases | MALICIOUS_CODE | EI_EXPOSE_REP2 | 100 | Medium |
| org.kuali.rice.core.framework.persistence.ojb.BaseOjbConfigurer.setJcdAliases(String[]) may expose internal representation by storing an externally mutable object into BaseOjbConfigurer.jcdAliases | MALICIOUS_CODE | EI_EXPOSE_REP2 | 246 | Medium |
| Bug | Category | Details | Line | Priority |
|---|
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of source, which is known to be non-null in org.kuali.rice.core.framework.persistence.ojb.conversion.OjbCharBooleanConversion.javaToSql(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 32 | Medium |
| Redundant nullcheck of source, which is known to be non-null in org.kuali.rice.core.framework.persistence.ojb.conversion.OjbCharBooleanConversion.sqlToJava(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 57 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of source, which is known to be non-null in org.kuali.rice.core.framework.persistence.ojb.conversion.OjbCharBooleanConversion2.javaToSql(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 33 | Medium |
| Redundant nullcheck of source, which is known to be non-null in org.kuali.rice.core.framework.persistence.ojb.conversion.OjbCharBooleanConversion2.sqlToJava(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 60 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.core.framework.persistence.ojb.conversion.OjbKualiIntegerFieldConversion.javaToSql(Object) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 32 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.core.framework.persistence.platform.MySQLDatabasePlatform.getNextValSQL(String, EntityManager) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 90 | Medium |
| Method org.kuali.rice.core.framework.persistence.platform.MySQLDatabasePlatform.getNextValSQL(String, PersistenceBroker) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 68 | Medium |
| org.kuali.rice.core.framework.persistence.platform.MySQLDatabasePlatform.getNextValSQL(String, PersistenceBroker) may fail to close PreparedStatement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 60 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.core.framework.persistence.platform.OracleDatabasePlatform.getNextValSQL(String, EntityManager) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 66 | Medium |
| Method org.kuali.rice.core.framework.persistence.platform.OracleDatabasePlatform.getNextValSQL(String, PersistenceBroker) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 81 | Medium |
