The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.kuali.rice.krad.UserSession.hasMatchingSessionTicket(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 299 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krad.app.persistence.jpa.RiceLocalContainerEntityManagerFactoryBean.prepareJpaVendorAdapter(Config, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 81 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The field org.kuali.rice.krad.bo.AdHocRoutePerson.person is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.krad.bo.AdHocRoutePersonId.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 66 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.kuali.rice.krad.bo.AdHocRouteRecipient.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 38 | Medium |
Method new org.kuali.rice.krad.bo.AdHocRouteRecipient() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 58 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krad.bo.PersistableAttachmentBase.getAttachmentContent() may expose internal representation by returning PersistableAttachmentBase.attachmentContent | MALICIOUS_CODE | EI_EXPOSE_REP | 44 | Medium |
org.kuali.rice.krad.bo.PersistableAttachmentBase.setAttachmentContent(byte[]) may expose internal representation by storing an externally mutable object into PersistableAttachmentBase.attachmentContent | MALICIOUS_CODE | EI_EXPOSE_REP2 | 53 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krad.util.AuditError.getParams() may expose internal representation by returning AuditError.params | MALICIOUS_CODE | EI_EXPOSE_REP | 103 | Medium |
org.kuali.rice.krad.util.AuditError.setParams(String[]) may expose internal representation by storing an externally mutable object into AuditError.params | MALICIOUS_CODE | EI_EXPOSE_REP2 | 112 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krad.util.BeanPropertyComparator$1 stored into non-transient field BeanPropertyComparator.booleanComparator | BAD_PRACTICE | SE_BAD_FIELD_STORE | 78 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krad.util.ErrorMessage.getMessageParameters() may expose internal representation by returning ErrorMessage.messageParameters | MALICIOUS_CODE | EI_EXPOSE_REP | 75 | Medium |
org.kuali.rice.krad.util.ErrorMessage.setMessageParameters(String[]) may expose internal representation by storing an externally mutable object into ErrorMessage.messageParameters | MALICIOUS_CODE | EI_EXPOSE_REP2 | 71 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.kuali.rice.krad.util.MessageMap.getMessageCount(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 358 | Medium |
Method org.kuali.rice.krad.util.MessageMap.merge(Map, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 88 | Medium |