The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.edl.impl.EDLXmlUtils.addErrorsAndMessagesToDocument(Document, List, List, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 240 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.edl.impl.UserAction.ANNOTATABLE_ACTIONS is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 78 | High |
| org.kuali.rice.edl.impl.UserAction.EDITABLE_ACTIONS is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 88 | High |
| org.kuali.rice.edl.impl.UserAction.LOAD_ACTIONS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 58 | Medium |
| org.kuali.rice.edl.impl.UserAction.REPLACE_VERSION_ACTIONS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 63 | Medium |
| org.kuali.rice.edl.impl.UserAction.VALIDATABLE_ACTIONS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.edl.impl.components.NoteConfigComponent.retrieveNoteList(NoteConfigComponent$NoteForm, EDLContext) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 193 | Medium |
| Method org.kuali.rice.edl.impl.components.NoteConfigComponent.editNote(NoteConfigComponent$NoteForm) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 208 | Medium |
| Method org.kuali.rice.edl.impl.components.NoteConfigComponent.retrieveNoteList(NoteConfigComponent$NoteForm, EDLContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 192 | Medium |
| Method org.kuali.rice.edl.impl.components.NoteConfigComponent.retrieveNoteList(NoteConfigComponent$NoteForm, EDLContext) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 168 | Medium |
| note could be null and is guaranteed to be dereferenced in org.kuali.rice.edl.impl.components.NoteConfigComponent.getAuthorData(Note) | CORRECTNESS | NP_GUARANTEED_DEREF | 862 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method new org.kuali.rice.edl.impl.components.NoteConfigComponent$NoteForm(RequestParser) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 636 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.edl.impl.components.SelectControlEDLComponent.updateDOM(Document, Element, EDLContext) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 64 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: org.kuali.rice.edl.impl.components.ValidationComponent.edlContext | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.edl.impl.components.VersioningPreprocessor.findCurrentVersion(Document) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 82 | Medium |
| Method org.kuali.rice.edl.impl.components.VersioningPreprocessor.updateDOM(Document, Element, EDLContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 56 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to requestParser in org.kuali.rice.edl.impl.components.WorkflowDocumentActions.doPostProcessWork(Document, EDLContext) | STYLE | DLS_DEAD_LOCAL_STORE | 94 | Medium |
