The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.core.impl.component.ComponentId.equals(Object) is unusual | STYLE | EQ_UNUSUAL | 52 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to rootResourceLoader in org.kuali.rice.core.impl.config.module.ModuleConfigurer.initializeResourceLoaders() | STYLE | DLS_DEAD_LOCAL_STORE | 298 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.core.impl.config.property.AbstractBaseConfig.getBatchMode() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 79 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.core.impl.config.property.BaseConfig.getBatchMode() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 306 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.core.impl.config.property.ConfigFactoryBean.CONFIG_OVERRIDE_LOCATION isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.kuali.rice.core.impl.config.property.ConfigLogger.logConfig(Config) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 63 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.core.impl.config.property.HierarchicalConfigParser.parse(String, Map, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 129 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.kuali.rice.core.impl.config.property.JAXBConfigImpl$ConfigNamespaceURIFilter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 590 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Uninitialized read of desKey in new org.kuali.rice.core.impl.encryption.DemonstrationGradeEncryptionServiceImpl() | CORRECTNESS | UR_UNINIT_READ | 49 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.core.impl.encryption.NoEncryptionEncryptionServiceImpl.decrypt(String) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 51 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Inconsistent synchronization of org.kuali.rice.core.impl.mocks.RiceCacheAdministratorMock.cache; locked 63% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | Medium | |
Inconsistent synchronization of org.kuali.rice.core.impl.mocks.RiceCacheAdministratorMock.groupToKeyMap; locked 71% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | Medium | |
Inconsistent synchronization of org.kuali.rice.core.impl.mocks.RiceCacheAdministratorMock.keyToGroupMap; locked 71% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | Medium | |
Incorrect lazy initialization of static field org.kuali.rice.core.impl.mocks.RiceCacheAdministratorMock.$callSiteArray in org.kuali.rice.core.impl.mocks.RiceCacheAdministratorMock.$getCallSiteArray() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.core.impl.parameter.ParameterId.equals(Object) is unusual | STYLE | EQ_UNUSUAL | 59 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.core.impl.parameter.ParameterRepositoryServiceImpl.getParameterValueAsBoolean(ParameterKey) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 116 | Medium |
Potentially dangerous use of non-short-circuit logic in org.kuali.rice.core.impl.parameter.ParameterRepositoryServiceImpl.getParameter(ParameterKey) | STYLE | NS_DANGEROUS_NON_SHORT_CIRCUIT | 97 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.kuali.rice.core.impl.resourceloader.SimpleServiceLocator.getContents(String, boolean) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 45 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.kuali.rice.core.impl.resourceloader.SpringResourceLoader.getContents(String, boolean) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 125 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.kuali.rice.core.impl.util.spring.AnnotationAndNameMatchingTransactionAttributeSource.setTimeout(TransactionAttribute) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 73 | Medium |
org.kuali.rice.core.impl.util.spring.AnnotationAndNameMatchingTransactionAttributeSource doesn't override org.springframework.transaction.interceptor.NameMatchTransactionAttributeSource.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 29 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.kuali.rice.core.mail.MailSenderFactoryBean$SimpleAuthenticator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 90 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method new org.kuali.rice.core.util.ImmutableProperties(Properties) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 37 | Medium |