FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
1022300

org.kuali.rice.core.impl.component.ComponentId

BugCategoryDetailsLinePriority
org.kuali.rice.core.impl.component.ComponentId.equals(Object) is unusualSTYLEEQ_UNUSUAL52Medium

org.kuali.rice.core.impl.config.module.ModuleConfigurer

BugCategoryDetailsLinePriority
Dead store to rootResourceLoader in org.kuali.rice.core.impl.config.module.ModuleConfigurer.initializeResourceLoaders()STYLEDLS_DEAD_LOCAL_STORE298Medium

org.kuali.rice.core.impl.config.property.AbstractBaseConfig

BugCategoryDetailsLinePriority
org.kuali.rice.core.impl.config.property.AbstractBaseConfig.getBatchMode() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR79Medium

org.kuali.rice.core.impl.config.property.BaseConfig

BugCategoryDetailsLinePriority
org.kuali.rice.core.impl.config.property.BaseConfig.getBatchMode() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR306Medium

org.kuali.rice.core.impl.config.property.ConfigFactoryBean

BugCategoryDetailsLinePriority
org.kuali.rice.core.impl.config.property.ConfigFactoryBean.CONFIG_OVERRIDE_LOCATION isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINALHigh

org.kuali.rice.core.impl.config.property.ConfigLogger

BugCategoryDetailsLinePriority
Method org.kuali.rice.core.impl.config.property.ConfigLogger.logConfig(Config) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION63Medium

org.kuali.rice.core.impl.config.property.HierarchicalConfigParser

BugCategoryDetailsLinePriority
org.kuali.rice.core.impl.config.property.HierarchicalConfigParser.parse(String, Map, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR129Medium

org.kuali.rice.core.impl.config.property.JAXBConfigImpl$ConfigNamespaceURIFilter

BugCategoryDetailsLinePriority
Should org.kuali.rice.core.impl.config.property.JAXBConfigImpl$ConfigNamespaceURIFilter be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC590Medium

org.kuali.rice.core.impl.encryption.DemonstrationGradeEncryptionServiceImpl

BugCategoryDetailsLinePriority
Uninitialized read of desKey in new org.kuali.rice.core.impl.encryption.DemonstrationGradeEncryptionServiceImpl()CORRECTNESSUR_UNINIT_READ49Medium

org.kuali.rice.core.impl.encryption.NoEncryptionEncryptionServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.core.impl.encryption.NoEncryptionEncryptionServiceImpl.decrypt(String) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR51Medium

org.kuali.rice.core.impl.mocks.RiceCacheAdministratorMock

BugCategoryDetailsLinePriority
Inconsistent synchronization of org.kuali.rice.core.impl.mocks.RiceCacheAdministratorMock.cache; locked 63% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNCMedium
Inconsistent synchronization of org.kuali.rice.core.impl.mocks.RiceCacheAdministratorMock.groupToKeyMap; locked 71% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNCMedium
Inconsistent synchronization of org.kuali.rice.core.impl.mocks.RiceCacheAdministratorMock.keyToGroupMap; locked 71% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNCMedium
Incorrect lazy initialization of static field org.kuali.rice.core.impl.mocks.RiceCacheAdministratorMock.$callSiteArray in org.kuali.rice.core.impl.mocks.RiceCacheAdministratorMock.$getCallSiteArray()MT_CORRECTNESSLI_LAZY_INIT_STATICMedium

org.kuali.rice.core.impl.parameter.ParameterId

BugCategoryDetailsLinePriority
org.kuali.rice.core.impl.parameter.ParameterId.equals(Object) is unusualSTYLEEQ_UNUSUAL59Medium

org.kuali.rice.core.impl.parameter.ParameterRepositoryServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.core.impl.parameter.ParameterRepositoryServiceImpl.getParameterValueAsBoolean(ParameterKey) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL116Medium
Potentially dangerous use of non-short-circuit logic in org.kuali.rice.core.impl.parameter.ParameterRepositoryServiceImpl.getParameter(ParameterKey)STYLENS_DANGEROUS_NON_SHORT_CIRCUIT97High

org.kuali.rice.core.impl.resourceloader.SimpleServiceLocator

BugCategoryDetailsLinePriority
Method org.kuali.rice.core.impl.resourceloader.SimpleServiceLocator.getContents(String, boolean) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION45Medium

org.kuali.rice.core.impl.resourceloader.SpringResourceLoader

BugCategoryDetailsLinePriority
Method org.kuali.rice.core.impl.resourceloader.SpringResourceLoader.getContents(String, boolean) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION125Medium

org.kuali.rice.core.impl.util.spring.AnnotationAndNameMatchingTransactionAttributeSource

BugCategoryDetailsLinePriority
Method org.kuali.rice.core.impl.util.spring.AnnotationAndNameMatchingTransactionAttributeSource.setTimeout(TransactionAttribute) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR73Medium
org.kuali.rice.core.impl.util.spring.AnnotationAndNameMatchingTransactionAttributeSource doesn't override org.springframework.transaction.interceptor.NameMatchTransactionAttributeSource.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS29Medium

org.kuali.rice.core.mail.MailSenderFactoryBean$SimpleAuthenticator

BugCategoryDetailsLinePriority
Should org.kuali.rice.core.mail.MailSenderFactoryBean$SimpleAuthenticator be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC90Medium

org.kuali.rice.core.util.ImmutableProperties

BugCategoryDetailsLinePriority
Method new org.kuali.rice.core.util.ImmutableProperties(Properties) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR37Medium