Rice API - FindBugs Bug Detector Report

Last Published: 2011-06-12 | Version: 2.0.0-m5-SNAPSHOT

Project Documentation

Project Information
Project Reports
- Cobertura Test Coverage
- FindBugs Report

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is medium

Effort is min

Summary

Classes	Bugs	Errors	Missing Classes
185	63	0	0

Files

Class	Bugs
org.kuali.rice.kew.dto.ActionRequestDTO	2
org.kuali.rice.kew.dto.ActionTakenDTO	2
org.kuali.rice.kew.dto.DocumentDetailDTO	6
org.kuali.rice.kew.dto.DocumentTypeDTO	3
org.kuali.rice.kew.dto.ReportCriteriaDTO	8
org.kuali.rice.kew.dto.RouteHeaderDTO	4
org.kuali.rice.kew.dto.RouteNodeDTO	5
org.kuali.rice.kew.dto.RouteNodeInstanceDTO	4
org.kuali.rice.kew.dto.RoutePathDTO	2
org.kuali.rice.kew.dto.RuleDTO	4
org.kuali.rice.kew.dto.RuleReportCriteriaDTO	4
org.kuali.rice.kew.dto.RuleResponsibilityDTO	2
org.kuali.rice.kew.dto.UserIdDTO	1
org.kuali.rice.kew.dto.ValidActionsDTO	2
org.kuali.rice.kew.service.WorkflowDocument	5
org.kuali.rice.kew.service.WorkflowInfo	1
org.kuali.rice.kew.util.KEWConstants	2
org.kuali.rice.kns.dto.InactiveableInfo	6

org.kuali.rice.kew.dto.ActionRequestDTO

Bug	Category	Details	Line	Priority
org.kuali.rice.kew.dto.ActionRequestDTO.getChildrenRequests() may expose internal representation by returning ActionRequestDTO.childrenRequests	MALICIOUS_CODE	EI_EXPOSE_REP	310	Medium
org.kuali.rice.kew.dto.ActionRequestDTO.setChildrenRequests(ActionRequestDTO[]) may expose internal representation by storing an externally mutable object into ActionRequestDTO.childrenRequests	MALICIOUS_CODE	EI_EXPOSE_REP2	313	Medium

org.kuali.rice.kew.dto.ActionTakenDTO

Bug	Category	Details	Line	Priority
org.kuali.rice.kew.dto.ActionTakenDTO.getActionRequests() may expose internal representation by returning ActionTakenDTO.actionRequests	MALICIOUS_CODE	EI_EXPOSE_REP	45	Medium
org.kuali.rice.kew.dto.ActionTakenDTO.setActionRequests(ActionRequestDTO[]) may expose internal representation by storing an externally mutable object into ActionTakenDTO.actionRequests	MALICIOUS_CODE	EI_EXPOSE_REP2	49	Medium

org.kuali.rice.kew.dto.DocumentDetailDTO

Bug	Category	Details	Line	Priority
org.kuali.rice.kew.dto.DocumentDetailDTO.getActionRequests() may expose internal representation by returning DocumentDetailDTO.actionRequests	MALICIOUS_CODE	EI_EXPOSE_REP	39	Medium
org.kuali.rice.kew.dto.DocumentDetailDTO.getActionsTaken() may expose internal representation by returning DocumentDetailDTO.actionsTaken	MALICIOUS_CODE	EI_EXPOSE_REP	47	Medium
org.kuali.rice.kew.dto.DocumentDetailDTO.getNodeInstances() may expose internal representation by returning DocumentDetailDTO.nodeInstances	MALICIOUS_CODE	EI_EXPOSE_REP	55	Medium
org.kuali.rice.kew.dto.DocumentDetailDTO.setActionRequests(ActionRequestDTO[]) may expose internal representation by storing an externally mutable object into DocumentDetailDTO.actionRequests	MALICIOUS_CODE	EI_EXPOSE_REP2	43	Medium
org.kuali.rice.kew.dto.DocumentDetailDTO.setActionsTaken(ActionTakenDTO[]) may expose internal representation by storing an externally mutable object into DocumentDetailDTO.actionsTaken	MALICIOUS_CODE	EI_EXPOSE_REP2	51	Medium
org.kuali.rice.kew.dto.DocumentDetailDTO.setNodeInstances(RouteNodeInstanceDTO[]) may expose internal representation by storing an externally mutable object into DocumentDetailDTO.nodeInstances	MALICIOUS_CODE	EI_EXPOSE_REP2	59	Medium

org.kuali.rice.kew.dto.DocumentTypeDTO

Bug	Category	Details	Line	Priority
Method new org.kuali.rice.kew.dto.DocumentTypeDTO() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead	PERFORMANCE	DM_NUMBER_CTOR	41	Medium
org.kuali.rice.kew.dto.DocumentTypeDTO defines equals and uses Object.hashCode()	BAD_PRACTICE	HE_EQUALS_USE_HASHCODE	221	High
org.kuali.rice.kew.dto.DocumentTypeDTO.equals(Object) does not check for null argument	BAD_PRACTICE	NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT	221	High

org.kuali.rice.kew.dto.ReportCriteriaDTO

Bug	Category	Details	Line	Priority
org.kuali.rice.kew.dto.ReportCriteriaDTO.getActionsToTake() may expose internal representation by returning ReportCriteriaDTO.actionsToTake	MALICIOUS_CODE	EI_EXPOSE_REP	136	Medium
org.kuali.rice.kew.dto.ReportCriteriaDTO.getNodeNames() may expose internal representation by returning ReportCriteriaDTO.nodeNames	MALICIOUS_CODE	EI_EXPOSE_REP	128	Medium
org.kuali.rice.kew.dto.ReportCriteriaDTO.getRuleTemplateNames() may expose internal representation by returning ReportCriteriaDTO.ruleTemplateNames	MALICIOUS_CODE	EI_EXPOSE_REP	104	Medium
org.kuali.rice.kew.dto.ReportCriteriaDTO.getTargetPrincipalIds() may expose internal representation by returning ReportCriteriaDTO.targetPrincipalIds	MALICIOUS_CODE	EI_EXPOSE_REP	112	Medium
org.kuali.rice.kew.dto.ReportCriteriaDTO.setActionsToTake(ReportActionToTakeDTO[]) may expose internal representation by storing an externally mutable object into ReportCriteriaDTO.actionsToTake	MALICIOUS_CODE	EI_EXPOSE_REP2	140	Medium
org.kuali.rice.kew.dto.ReportCriteriaDTO.setNodeNames(String[]) may expose internal representation by storing an externally mutable object into ReportCriteriaDTO.nodeNames	MALICIOUS_CODE	EI_EXPOSE_REP2	132	Medium
org.kuali.rice.kew.dto.ReportCriteriaDTO.setRuleTemplateNames(String[]) may expose internal representation by storing an externally mutable object into ReportCriteriaDTO.ruleTemplateNames	MALICIOUS_CODE	EI_EXPOSE_REP2	108	Medium
org.kuali.rice.kew.dto.ReportCriteriaDTO.setTargetPrincipalIds(String[]) may expose internal representation by storing an externally mutable object into ReportCriteriaDTO.targetPrincipalIds	MALICIOUS_CODE	EI_EXPOSE_REP2	116	Medium

org.kuali.rice.kew.dto.RouteHeaderDTO

Bug	Category	Details	Line	Priority
org.kuali.rice.kew.dto.RouteHeaderDTO.getNotes() may expose internal representation by returning RouteHeaderDTO.notes	MALICIOUS_CODE	EI_EXPOSE_REP	266	Medium
org.kuali.rice.kew.dto.RouteHeaderDTO.getNotesToDelete() may expose internal representation by returning RouteHeaderDTO.notesToDelete	MALICIOUS_CODE	EI_EXPOSE_REP	274	Medium
org.kuali.rice.kew.dto.RouteHeaderDTO.setNotes(NoteDTO[]) may expose internal representation by storing an externally mutable object into RouteHeaderDTO.notes	MALICIOUS_CODE	EI_EXPOSE_REP2	270	Medium
org.kuali.rice.kew.dto.RouteHeaderDTO.setNotesToDelete(NoteDTO[]) may expose internal representation by storing an externally mutable object into RouteHeaderDTO.notesToDelete	MALICIOUS_CODE	EI_EXPOSE_REP2	278	Medium

org.kuali.rice.kew.dto.RouteNodeDTO

Bug	Category	Details	Line	Priority
Class org.kuali.rice.kew.dto.RouteNodeDTO implements Cloneable but does not define or use clone method	BAD_PRACTICE	CN_IDIOM	37	Medium
org.kuali.rice.kew.dto.RouteNodeDTO.getNextNodeIds() may expose internal representation by returning RouteNodeDTO.nextNodeIds	MALICIOUS_CODE	EI_EXPOSE_REP	79	Medium
org.kuali.rice.kew.dto.RouteNodeDTO.getPreviousNodeIds() may expose internal representation by returning RouteNodeDTO.previousNodeIds	MALICIOUS_CODE	EI_EXPOSE_REP	91	Medium
org.kuali.rice.kew.dto.RouteNodeDTO.setNextNodeIds(Long[]) may expose internal representation by storing an externally mutable object into RouteNodeDTO.nextNodeIds	MALICIOUS_CODE	EI_EXPOSE_REP2	82	Medium
org.kuali.rice.kew.dto.RouteNodeDTO.setPreviousNodeIds(Long[]) may expose internal representation by storing an externally mutable object into RouteNodeDTO.previousNodeIds	MALICIOUS_CODE	EI_EXPOSE_REP2	94	Medium

org.kuali.rice.kew.dto.RouteNodeInstanceDTO

Bug	Category	Details	Line	Priority
org.kuali.rice.kew.dto.RouteNodeInstanceDTO.getNextNodes() may expose internal representation by returning RouteNodeInstanceDTO.nextNodes	MALICIOUS_CODE	EI_EXPOSE_REP	114	Medium
org.kuali.rice.kew.dto.RouteNodeInstanceDTO.getState() may expose internal representation by returning RouteNodeInstanceDTO.state	MALICIOUS_CODE	EI_EXPOSE_REP	97	Medium
org.kuali.rice.kew.dto.RouteNodeInstanceDTO.setNextNodes(RouteNodeInstanceDTO[]) may expose internal representation by storing an externally mutable object into RouteNodeInstanceDTO.nextNodes	MALICIOUS_CODE	EI_EXPOSE_REP2	118	Medium
org.kuali.rice.kew.dto.RouteNodeInstanceDTO.setState(StateDTO[]) may expose internal representation by storing an externally mutable object into RouteNodeInstanceDTO.state	MALICIOUS_CODE	EI_EXPOSE_REP2	100	Medium

org.kuali.rice.kew.dto.RoutePathDTO

Bug	Category	Details	Line	Priority
org.kuali.rice.kew.dto.RoutePathDTO.getProcesses() may expose internal representation by returning RoutePathDTO.processes	MALICIOUS_CODE	EI_EXPOSE_REP	33	Medium
org.kuali.rice.kew.dto.RoutePathDTO.setProcesses(ProcessDTO[]) may expose internal representation by storing an externally mutable object into RoutePathDTO.processes	MALICIOUS_CODE	EI_EXPOSE_REP2	37	Medium

org.kuali.rice.kew.dto.RuleDTO

Bug	Category	Details	Line	Priority
org.kuali.rice.kew.dto.RuleDTO.getRuleExtensions() may expose internal representation by returning RuleDTO.ruleExtensions	MALICIOUS_CODE	EI_EXPOSE_REP	80	Medium
org.kuali.rice.kew.dto.RuleDTO.getRuleResponsibilities() may expose internal representation by returning RuleDTO.ruleResponsibilities	MALICIOUS_CODE	EI_EXPOSE_REP	103	Medium
org.kuali.rice.kew.dto.RuleDTO.setRuleExtensions(RuleExtensionDTO[]) may expose internal representation by storing an externally mutable object into RuleDTO.ruleExtensions	MALICIOUS_CODE	EI_EXPOSE_REP2	84	Medium
org.kuali.rice.kew.dto.RuleDTO.setRuleResponsibilities(RuleResponsibilityDTO[]) may expose internal representation by storing an externally mutable object into RuleDTO.ruleResponsibilities	MALICIOUS_CODE	EI_EXPOSE_REP2	107	Medium

org.kuali.rice.kew.dto.RuleReportCriteriaDTO

Bug	Category	Details	Line	Priority
org.kuali.rice.kew.dto.RuleReportCriteriaDTO.getActionRequestCodes() may expose internal representation by returning RuleReportCriteriaDTO.actionRequestCodes	MALICIOUS_CODE	EI_EXPOSE_REP	38	Medium
org.kuali.rice.kew.dto.RuleReportCriteriaDTO.getRuleExtensionVOs() may expose internal representation by returning RuleReportCriteriaDTO.ruleExtensionVOs	MALICIOUS_CODE	EI_EXPOSE_REP	110	Medium
org.kuali.rice.kew.dto.RuleReportCriteriaDTO.setActionRequestCodes(String[]) may expose internal representation by storing an externally mutable object into RuleReportCriteriaDTO.actionRequestCodes	MALICIOUS_CODE	EI_EXPOSE_REP2	42	Medium
org.kuali.rice.kew.dto.RuleReportCriteriaDTO.setRuleExtensionVOs(RuleExtensionDTO[]) may expose internal representation by storing an externally mutable object into RuleReportCriteriaDTO.ruleExtensionVOs	MALICIOUS_CODE	EI_EXPOSE_REP2	114	Medium

org.kuali.rice.kew.dto.RuleResponsibilityDTO

Bug	Category	Details	Line	Priority
org.kuali.rice.kew.dto.RuleResponsibilityDTO.getDelegationRules() may expose internal representation by returning RuleResponsibilityDTO.delegationRules	MALICIOUS_CODE	EI_EXPOSE_REP	60	Medium
org.kuali.rice.kew.dto.RuleResponsibilityDTO.setDelegationRules(RuleDelegationDTO[]) may expose internal representation by storing an externally mutable object into RuleResponsibilityDTO.delegationRules	MALICIOUS_CODE	EI_EXPOSE_REP2	64	Medium

org.kuali.rice.kew.dto.UserIdDTO

Bug	Category	Details	Line	Priority
Equals method for org.kuali.rice.kew.dto.UserIdDTO assumes the argument is of type UserIdDTO	BAD_PRACTICE	BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS	47	Medium

org.kuali.rice.kew.dto.ValidActionsDTO

Bug	Category	Details	Line	Priority
org.kuali.rice.kew.dto.ValidActionsDTO.getValidActionCodesAllowed() may expose internal representation by returning ValidActionsDTO.validActionCodesAllowed	MALICIOUS_CODE	EI_EXPOSE_REP	35	Medium
org.kuali.rice.kew.dto.ValidActionsDTO.setValidActionCodesAllowed(String[]) may expose internal representation by storing an externally mutable object into ValidActionsDTO.validActionCodesAllowed	MALICIOUS_CODE	EI_EXPOSE_REP2	39	Medium

org.kuali.rice.kew.service.WorkflowDocument

Bug	Category	Details	Line	Priority
Method org.kuali.rice.kew.service.WorkflowDocument.deleteNote(NoteDTO) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	1196	Medium
Method org.kuali.rice.kew.service.WorkflowDocument.updateNote(NoteDTO) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead	PERFORMANCE	DM_NUMBER_CTOR	1244	Medium
Method org.kuali.rice.kew.service.WorkflowDocument.updateNote(NoteDTO) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	1217	Medium
org.kuali.rice.kew.service.WorkflowDocument.updateNote(NoteDTO) invokes inefficient new String(String) constructor	PERFORMANCE	DM_STRING_CTOR	1227	Medium
Possible null pointer dereference of activeNodeInstances in org.kuali.rice.kew.service.WorkflowDocument.getNodeNames()	CORRECTNESS	NP_NULL_ON_SOME_PATH	1044	High

org.kuali.rice.kew.service.WorkflowInfo

Bug	Category	Details	Line	Priority
Possible null pointer dereference of currentNodeInstances in org.kuali.rice.kew.service.WorkflowInfo.getCurrentNodeNames(String)	CORRECTNESS	NP_NULL_ON_SOME_PATH	356	High

org.kuali.rice.kew.util.KEWConstants

Bug	Category	Details	Line	Priority
Method org.kuali.rice.kew.util.KEWConstants.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead	PERFORMANCE	DM_NUMBER_CTOR	293	Medium
Method org.kuali.rice.kew.util.KEWConstants.<static initializer>() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	801	Medium

org.kuali.rice.kns.dto.InactiveableInfo

Bug	Category	Details	Line	Priority
org.kuali.rice.kns.dto.InactiveableInfo.getActiveAsOfDate() may expose internal representation by returning InactiveableInfo.activeAsOfDate	MALICIOUS_CODE	EI_EXPOSE_REP	70	Medium
org.kuali.rice.kns.dto.InactiveableInfo.getActiveFromDate() may expose internal representation by returning InactiveableInfo.activeFromDate	MALICIOUS_CODE	EI_EXPOSE_REP	62	Medium
org.kuali.rice.kns.dto.InactiveableInfo.getActiveToDate() may expose internal representation by returning InactiveableInfo.activeToDate	MALICIOUS_CODE	EI_EXPOSE_REP	66	Medium
org.kuali.rice.kns.dto.InactiveableInfo.setActiveAsOfDate(Date) may expose internal representation by storing an externally mutable object into InactiveableInfo.activeAsOfDate	MALICIOUS_CODE	EI_EXPOSE_REP2	58	Medium
org.kuali.rice.kns.dto.InactiveableInfo.setActiveFromDate(Date) may expose internal representation by storing an externally mutable object into InactiveableInfo.activeFromDate	MALICIOUS_CODE	EI_EXPOSE_REP2	50	Medium
org.kuali.rice.kns.dto.InactiveableInfo.setActiveToDate(Date) may expose internal representation by storing an externally mutable object into InactiveableInfo.activeToDate	MALICIOUS_CODE	EI_EXPOSE_REP2	54	Medium