The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: org.kuali.rice.kns.authorization.BusinessObjectAuthorizerBase.persistenceStructureService | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kns.bo.AdHocRouteWorkgroupId.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.bo.SessionDocument.getSerializedDocumentForm() may expose internal representation by returning SessionDocument.serializedDocumentForm | MALICIOUS_CODE | EI_EXPOSE_REP | 62 | Medium |
| org.kuali.rice.kns.bo.SessionDocument.setSerializedDocumentForm(byte[]) may expose internal representation by storing an externally mutable object into SessionDocument.serializedDocumentForm | MALICIOUS_CODE | EI_EXPOSE_REP2 | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.kns.datadictionary.AttributeDefinition defines non-transient non-serializable instance field optionsFinder | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to collectionClasses in org.kuali.rice.kns.datadictionary.DataDictionary.buildReadDescriptor(Class, String) | STYLE | DLS_DEAD_LOCAL_STORE | 585 | Medium |
| Dead store to collectionClasses in org.kuali.rice.kns.datadictionary.DataDictionary.getCollectionElementClass(Class, String) | STYLE | DLS_DEAD_LOCAL_STORE | 526 | Medium |
| Dead store to indexName in org.kuali.rice.kns.datadictionary.DataDictionary.indexSource(String) | STYLE | DLS_DEAD_LOCAL_STORE | 131 | Medium |
| org.kuali.rice.kns.datadictionary.DataDictionary.persistenceStructureService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| Write to static field org.kuali.rice.kns.datadictionary.DataDictionary.validateEBOs from instance method org.kuali.rice.kns.datadictionary.DataDictionary.validateDD(boolean) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 201 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| String is incompatible with expected argument type AttributeDefinition in org.kuali.rice.kns.datadictionary.DataDictionaryEntryBase.addNestedAttributes(ComplexAttributeDefinition, String) | CORRECTNESS | GC_UNRELATED_TYPES | 353 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.datadictionary.DataObjectEntry.getJstlKey() uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 69 | Medium |
| Redundant nullcheck of org.kuali.rice.kns.datadictionary.DataObjectEntry.objectClass, which is known to be non-null in org.kuali.rice.kns.datadictionary.DataObjectEntry.getJstlKey() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of sourceClass in org.kuali.rice.kns.datadictionary.PrimitiveAttributeDefinition.completeValidation(Class, Class) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 103 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.ButtonControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 30 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.CheckboxControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 29 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.ControlDefinitionBase defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 411 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.CurrencyControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 37 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.FileControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.HiddenControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 27 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.KualiUserControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 48 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.LinkControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.LookupHiddenControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 28 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.LookupReadonlyControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 28 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.MultiselectControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 27 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.RadioControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 28 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.SelectControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 32 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.TextControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 29 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.TextareaControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 27 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.control.WorkflowWorkgroupControlDefinition inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 32 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to componentBeans in org.kuali.rice.kns.datadictionary.uif.UifDictionaryIndex.buildViewIndicies() | STYLE | DLS_DEAD_LOCAL_STORE | 168 | Medium |
| Method org.kuali.rice.kns.datadictionary.uif.UifDictionaryIndex.buildTypeIndex(Map) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 242 | Medium |
| Method org.kuali.rice.kns.datadictionary.uif.UifDictionaryIndex.buildTypeIndex(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 242 | Medium |
| Method org.kuali.rice.kns.datadictionary.uif.UifDictionaryIndex.buildViewIndicies() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 155 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to regexString in org.kuali.rice.kns.datadictionary.validation.CharacterLevelValidationPattern.getRegexPattern() | STYLE | DLS_DEAD_LOCAL_STORE | 81 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.validation.ValidationUtils.getBoolean(Object) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 213 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of exportMap in org.kuali.rice.kns.datadictionary.validation.charlevel.RegexValidationPattern.extendExportMap(ExportMap) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 53 | High |
| Nullcheck of exportMap at line 58 of value previously dereferenced in org.kuali.rice.kns.datadictionary.validation.charlevel.RegexValidationPattern.extendExportMap(ExportMap) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 53 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.datadictionary.validation.result.ConstraintValidationResult.getErrorParameters() may expose internal representation by returning ConstraintValidationResult.errorParameters | MALICIOUS_CODE | EI_EXPOSE_REP | 106 | Medium |
| org.kuali.rice.kns.datadictionary.validation.result.ConstraintValidationResult.setErrorParameters(String[]) may expose internal representation by storing an externally mutable object into ConstraintValidationResult.errorParameters | MALICIOUS_CODE | EI_EXPOSE_REP2 | 113 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.kuali.rice.kns.datadictionary.validation.result.EntryValidationResult.entryName | PERFORMANCE | URF_UNREAD_FIELD | 32 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.kuali.rice.kns.document.MaintenanceDocumentBase.validateBusinessRules(KualiDocumentEvent), since all org.kuali.rice.kns.document.MaintenanceDocumentBase are instances of org.kuali.rice.kns.document.MaintenanceDocument | STYLE | BC_VACUOUS_INSTANCEOF | 716 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.document.authorization.DocumentAuthorizerBase.LOG isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 43 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.document.authorization.MaintenanceDocumentPresentationControllerBase.maintenanceDocumentDictionaryService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.inquiry.KualiInquirableImpl.businessObjectService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.kuali.rice.kns.inquiry.KualiInquirableImpl.SUPER_CLASS_TRANSLATOR_LIST isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 98 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to fieldsForLookup in org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 1094 | High |
| Dead store to fields in org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.setRows() | STYLE | DLS_DEAD_LOCAL_STORE | 1045 | Medium |
| org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.getSupplementalMenuBar() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 1366 | Medium |
| org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.RESULTS_DEFAULT_MAX_COLUMN_LENGTH should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 704 | Medium |
| Method org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.preprocessDateFields(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 1232 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.lookup.HtmlData.getTitleText(String, Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 216 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl.getExternalizableBusinessObjectFieldValues(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 159 | Medium |
| Method org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 227 | Medium |
| Method org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl.removeExternalizableBusinessObjectFieldValues(Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 142 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.lookup.LookupUtils.generateFieldConversions(BusinessObject, String, BusinessObjectRelationship, String, List, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 676 | Medium |
| Method org.kuali.rice.kns.lookup.LookupUtils.generateLookupParameters(BusinessObject, String, BusinessObjectRelationship, String, List, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 715 | Medium |
| Method org.kuali.rice.kns.lookup.LookupUtils.getNestedBusinessObject(BusinessObject, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 624 | Medium |
| Method org.kuali.rice.kns.lookup.LookupUtils.setFieldDirectInquiry(Field) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 497 | Medium |
| Write to static field org.kuali.rice.kns.lookup.LookupUtils.businessObjectDictionaryService from instance method org.kuali.rice.kns.lookup.LookupUtils.setBusinessObjectDictionaryService(BusinessObjectDictionaryService) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 76 | High |
| Write to static field org.kuali.rice.kns.lookup.LookupUtils.businessObjectMetaDataService from instance method org.kuali.rice.kns.lookup.LookupUtils.setBusinessObjectMetaDataService(BusinessObjectMetaDataService) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 96 | High |
| Write to static field org.kuali.rice.kns.lookup.LookupUtils.dataDictionaryService from instance method org.kuali.rice.kns.lookup.LookupUtils.setDataDictionaryService(DataDictionaryService) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 80 | High |
| Write to static field org.kuali.rice.kns.lookup.LookupUtils.dateTimeService from instance method org.kuali.rice.kns.lookup.LookupUtils.setDateTimeService(DateTimeService) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 88 | High |
| Write to static field org.kuali.rice.kns.lookup.LookupUtils.persistenceStructureService from instance method org.kuali.rice.kns.lookup.LookupUtils.setPersistenceStructureService(PersistenceStructureService) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 84 | High |
| Method org.kuali.rice.kns.lookup.LookupUtils.forceUppercase(Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 163 | Medium |
| Method org.kuali.rice.kns.lookup.LookupUtils.getPrimitiveReference(BusinessObject, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 580 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to cachedValues in org.kuali.rice.kns.maintenance.KualiMaintainableImpl.setGenerateDefaultValues(String) | STYLE | DLS_DEAD_LOCAL_STORE | 823 | Medium |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.getMultiValueIdentifierList(Collection, List) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 636 | Medium |
| org.kuali.rice.kns.maintenance.KualiMaintainableImpl.hasBusinessObjectExisted(BusinessObject, List, List) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 650 | Medium |
| Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.getMultiValueIdentifierList(Collection, List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 638 | Medium |
| Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.hasBusinessObjectExisted(BusinessObject, List, List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 652 | Medium |
| Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.decryptEncryptedData(Map, MaintenanceDocument, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 258 | Medium |
| Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.performFieldForceUpperCase(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 1488 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on org.kuali.rice.kns.util.ErrorMessage.getMessageParameters() in org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase.showErrorMap() | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 1130 | Medium |
| org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase.LOG isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 82 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docOrBoClass in org.kuali.rice.kns.rules.DocumentRuleBase.isAddHocRoutePersonValid(Document, AdHocRoutePerson) | STYLE | DLS_DEAD_LOCAL_STORE | 388 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.kns.web.spring.form.UifFormBase to org.kuali.rice.kns.web.spring.form.DocumentFormBase in org.kuali.rice.kns.uif.authorization.DocumentAuthorizerBase.getActionFlags(UifFormBase, Person, Set) | STYLE | BC_UNCONFIRMED_CAST | 51 | Medium |
| org.kuali.rice.kns.uif.authorization.DocumentAuthorizerBase.LOG isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 42 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.kns.web.spring.form.UifFormBase to org.kuali.rice.kns.web.spring.form.DocumentFormBase in org.kuali.rice.kns.uif.authorization.DocumentPresentationControllerBase.getActionFlags(UifFormBase) | STYLE | BC_UNCONFIRMED_CAST | 42 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.uif.authorization.MaintenanceDocumentPresentationControllerBase.maintenanceDocumentDictionaryService should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.uif.container.CollectionGroupBuilder.buildLine(View, Object, CollectionGroup, String, List, boolean, Object, int) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 213 | Medium |
| org.kuali.rice.kns.uif.container.CollectionGroupBuilder.removeNonRenderLineFields(View, Object, CollectionGroup, List, Object, int) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 285 | Medium |
| Method org.kuali.rice.kns.uif.container.CollectionGroupBuilder.removeNonRenderLineFields(View, Object, CollectionGroup, List, Object, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 284 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Non-virtual method call in org.kuali.rice.kns.uif.container.LookupView.applyConditionalLogicForFieldDisplay() passes null for nonnull parameter of org.kuali.rice.kns.uif.util.LookupInquiryUtils.generateCustomLookupControlFromExisting(Class, Control) | CORRECTNESS | NP_NULL_PARAM_DEREF_NONVIRTUAL | 145 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.kns.uif.container.View to org.kuali.rice.kns.uif.container.MaintenanceView in org.kuali.rice.kns.uif.core.MaintenanceActiveCollectionFilter.filter(View, Object, CollectionGroup) | STYLE | BC_UNCONFIRMED_CAST | 39 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.uif.core.MethodInvokerConfig.getArgumentTypes() may expose internal representation by returning MethodInvokerConfig.argumentTypes | MALICIOUS_CODE | EI_EXPOSE_REP | 57 | Medium |
| org.kuali.rice.kns.uif.core.MethodInvokerConfig.setArgumentTypes(Class[]) may expose internal representation by storing an externally mutable object into MethodInvokerConfig.argumentTypes | MALICIOUS_CODE | EI_EXPOSE_REP2 | 66 | Medium |
| Read of unwritten field staticMethod in org.kuali.rice.kns.uif.core.MethodInvokerConfig.getMethodArgumentTypes() | CORRECTNESS | NP_UNWRITTEN_FIELD | 77 | Medium |
| Unwritten field: org.kuali.rice.kns.uif.core.MethodInvokerConfig.staticMethod | CORRECTNESS | UWF_UNWRITTEN_FIELD | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.uif.field.ActionField.performFinalize(View, Object, Component) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 139 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.kns.uif.field.AttributeField defines non-transient non-serializable instance field optionsFinder | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.uif.field.AttributeQuery.getQueryFieldMappingJsString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 139 | Medium |
| Method org.kuali.rice.kns.uif.field.AttributeQuery.getQueryMethodArgumentFieldsJsString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 181 | Medium |
| Method org.kuali.rice.kns.uif.field.AttributeQuery.getReturnFieldMappingJsString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 161 | Medium |
| Class org.kuali.rice.kns.uif.field.AttributeQuery defines non-transient non-serializable instance field queryMethodInvokerConfig | BAD_PRACTICE | SE_BAD_FIELD | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.uif.field.FieldBase.performFinalize(View, Object, Component) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 96 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.kns.uif.field.GeneratedField defines non-transient non-serializable instance field renderingMethodInvoker | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.uif.history.History.getGeneratedBreadcrumbs() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 199 | Medium |
| Method org.kuali.rice.kns.uif.history.History.getGeneratedCurrentBreadcrumb() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 232 | Medium |
| Method org.kuali.rice.kns.uif.history.History.getHistoryParameterString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 163 | Medium |
| Method org.kuali.rice.kns.uif.history.History.setCurrent(UifFormBase, HttpServletRequest) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 336 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.uif.layout.StackedLayoutManager.buildLineHeaderText(Object) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 184 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.uif.layout.TableLayoutManager.addHeaderField(Field, int) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 307 | Medium |
| org.kuali.rice.kns.uif.layout.TableLayoutManager.buildLine(View, Object, CollectionGroup, List, List, String, List, String, Object, int) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 182 | Medium |
| Method org.kuali.rice.kns.uif.layout.TableLayoutManager.buildLine(View, Object, CollectionGroup, List, List, String, List, String, Object, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 171 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.kns.uif.container.View to org.kuali.rice.kns.uif.container.LookupView in org.kuali.rice.kns.uif.service.impl.LookupViewHelperServiceImpl.performInitialization(View) | STYLE | BC_UNCONFIRMED_CAST | 145 | Medium |
| Method org.kuali.rice.kns.uif.service.impl.LookupViewHelperServiceImpl.getExternalizableBusinessObjectFieldValues(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 580 | Medium |
| Method org.kuali.rice.kns.uif.service.impl.LookupViewHelperServiceImpl.getSearchResultsWithBounding(Map, boolean) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 365 | Medium |
| Method org.kuali.rice.kns.uif.service.impl.LookupViewHelperServiceImpl.preprocessDateFields(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 329 | Medium |
| Method org.kuali.rice.kns.uif.service.impl.LookupViewHelperServiceImpl.removeExternalizableBusinessObjectFieldValues(Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 564 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.uif.util.ClientValidationUtils.createRule(AttributeField, Constraint, String, View) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 354 | Medium |
| Method org.kuali.rice.kns.uif.util.ClientValidationUtils.generateMessageFromLabelKey(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 126 | Medium |
| Method org.kuali.rice.kns.uif.util.ClientValidationUtils.generateValidatorMessagesOption() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 150 | Medium |
| Method org.kuali.rice.kns.uif.util.ClientValidationUtils.getMustOccurStatement(AttributeField, MustOccurConstraint) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 601 | Medium |
| Method org.kuali.rice.kns.uif.util.ClientValidationUtils.processWhenConstraint(AttributeField, View, CaseConstraint, WhenConstraint, String, String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 271 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.uif.util.CloneUtils.deepCloneObject(Object, Map) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 95 | Medium |
| Load of known null value in org.kuali.rice.kns.uif.util.CloneUtils.internalField(Object, String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 232 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.uif.util.ComponentUtils.processIds(Component, Map) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 341 | Medium |
| Method org.kuali.rice.kns.uif.util.ComponentUtils.sort(List, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 409 | Medium |
| Method org.kuali.rice.kns.uif.util.ComponentUtils.updateContextForLine(Component, Object, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 333 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.uif.util.LookupInquiryUtils.getTitleText(String, Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 216 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.uif.util.ViewModelUtils.getPropertyType(View, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 64 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to meshedRows in org.kuali.rice.kns.util.FieldUtils.meshSections(List, List, List, String, boolean, MaintenanceDocumentRestrictions, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 1073 | Medium |
| Method org.kuali.rice.kns.util.FieldUtils.fixFieldForForm(Field, List, String, String, boolean, MaintenanceDocumentRestrictions, String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 842 | Medium |
| Method org.kuali.rice.kns.util.FieldUtils.populateBusinessObjectFromMap(BusinessObject, Map, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 732 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.util.InactiveRecordsHidingUtils.setShowInactiveRecords(Map, String, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 83 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.util.KNSUtils.getIntegerValue(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 102 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to equals() with null argument in org.kuali.rice.kns.util.ObjectUtils.isNull(Object) | CORRECTNESS | EC_NULL_ARG | 833 | Medium |
| Method org.kuali.rice.kns.util.ObjectUtils.createHybridBusinessObject(BusinessObject, BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 193 | Medium |
| Method org.kuali.rice.kns.util.ObjectUtils.equalByKeys(PersistableBusinessObject, PersistableBusinessObject) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 670 | Medium |
| Method org.kuali.rice.kns.util.ObjectUtils.materializeSubObjectsToDepth(PersistableBusinessObject, int) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 933 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.kns.web.struts.pojo.PojoFormBase to org.kuali.rice.kns.web.struts.form.KualiDocumentFormBase in org.kuali.rice.kns.util.WebUtils.isFormSessionDocument(PojoFormBase) | STYLE | BC_UNCONFIRMED_CAST | 514 | Medium |
| instanceof will always return true in org.kuali.rice.kns.util.WebUtils.getMethodToCallSettingAttribute(ActionForm, HttpServletRequest, String), since all org.apache.struts.action.ActionForm are instances of org.apache.struts.action.ActionForm | STYLE | BC_VACUOUS_INSTANCEOF | 205 | Medium |
| Dead store to params in org.kuali.rice.kns.util.WebUtils.getMultipartParameters(HttpServletRequest, ActionServletWrapper, ActionForm, ActionMapping) | STYLE | DLS_DEAD_LOCAL_STORE | 395 | High |
| Dead store to files in org.kuali.rice.kns.util.WebUtils.getMultipartParameters(HttpServletRequest, ActionServletWrapper, ActionForm, ActionMapping) | STYLE | DLS_DEAD_LOCAL_STORE | 413 | Medium |
| org.kuali.rice.kns.util.WebUtils.KEY_KUALI_FORM_IN_SESSION isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 520 | High |
| "." used for regular expression in org.kuali.rice.kns.util.WebUtils.getMapFromParameterString(String) | CORRECTNESS | RE_POSSIBLE_UNINTENDED_PATTERN | 963 | High |
| Method org.kuali.rice.kns.util.WebUtils.buildMapParameterString(Map) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 945 | Medium |
| Method org.kuali.rice.kns.util.WebUtils.filterHtmlAndReplaceRiceMarkup(String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 768 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.rice.kns.util.documentserializer.DocumentSerializationState$SerializationPropertyElement be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 37 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.kuali.rice.kns.util.documentserializer.SerializationState$SerializationPropertyElement be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 35 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.web.EditablePropertiesHistoryHolder.getMaxHistoryLength() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 61 | Medium |
| org.kuali.rice.kns.web.EditablePropertiesHistoryHolder is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 40 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.web.spring.controller.DocumentControllerBase.DOCUMENT_LOAD_COMMANDS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 74 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.kns.web.spring.form.UifFormBase to org.kuali.rice.kns.web.spring.form.IncidentReportForm in org.kuali.rice.kns.web.spring.controller.IncidentReportController.submitReport(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 54 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.kns.web.spring.form.UifFormBase to org.kuali.rice.kns.web.spring.form.InquiryForm in org.kuali.rice.kns.web.spring.controller.InquiryController.start(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 52 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.kns.web.spring.form.UifFormBase to org.kuali.rice.kns.web.spring.form.LookupForm in org.kuali.rice.kns.web.spring.controller.LookupController.cancel(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 123 | Medium |
| Unchecked/unconfirmed cast from org.kuali.rice.kns.web.spring.form.UifFormBase to org.kuali.rice.kns.web.spring.form.LookupForm in org.kuali.rice.kns.web.spring.controller.LookupController.start(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 110 | Medium |
| Method org.kuali.rice.kns.web.spring.controller.LookupController.search(LookupForm, BindingResult, HttpServletRequest, HttpServletResponse) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 173 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.kuali.rice.kns.web.spring.form.DocumentFormBase to org.kuali.rice.kns.web.spring.form.MaintenanceForm in org.kuali.rice.kns.web.spring.controller.MaintenanceDocumentController.docHandler(DocumentFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 79 | Medium |
| Unchecked/unconfirmed cast from org.kuali.rice.kns.web.spring.form.UifFormBase to org.kuali.rice.kns.web.spring.form.MaintenanceForm in org.kuali.rice.kns.web.spring.controller.MaintenanceDocumentController.start(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 132 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.kns.web.spring.form.InquiryForm defines non-transient non-serializable instance field inquirable | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.web.spring.form.LookupForm.processBooleanParameter(String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 284 | Medium |
| org.kuali.rice.kns.web.spring.form.LookupForm.processBooleanParameter(String) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 286 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.kns.web.spring.form.UifFormBase defines non-transient non-serializable instance field attachmentFile | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on textAreaParams in org.kuali.rice.kns.web.struts.action.KualiAction.getTextAreaParams(HttpServletRequest) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 1045 | Medium |
| Invocation of toString on inquiryParams in org.kuali.rice.kns.web.struts.action.KualiAction.performInquiry(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 657 | Medium |
| org.kuali.rice.kns.web.struts.action.KualiAction.performLookup(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 532 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to newNote in org.kuali.rice.kns.web.struts.action.KualiDocumentActionBase.deleteBONote(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 1464 | Medium |
| org.kuali.rice.kns.web.struts.action.KualiDocumentActionBase.DOCUMENT_LOAD_COMMANDS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 117 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.kns.web.struts.form.InquiryForm defines non-transient non-serializable instance field inquirable | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.web.struts.form.KualiForm.getHeaderNavigationTabs() may expose internal representation by returning KualiForm.headerNavigationTabs | MALICIOUS_CODE | EI_EXPOSE_REP | 277 | Medium |
| org.kuali.rice.kns.web.struts.form.KualiForm.setHeaderNavigationTabs(HeaderNavigation[]) may expose internal representation by storing an externally mutable object into KualiForm.headerNavigationTabs | MALICIOUS_CODE | EI_EXPOSE_REP2 | 286 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docTypeName in org.kuali.rice.kns.web.struts.form.KualiMaintenanceForm.getAdditionalSectionsFile() | STYLE | DLS_DEAD_LOCAL_STORE | 454 | Medium |
| Method org.kuali.rice.kns.web.struts.form.KualiMaintenanceForm.populate(HttpServletRequest) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 243 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ddService in org.kuali.rice.kns.web.struts.form.LookupForm.populate(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 147 | Medium |
| org.kuali.rice.kns.web.struts.form.LookupForm.populate(HttpServletRequest) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 226 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.kuali.rice.kns.web.struts.form.MultipleValueLookupForm defines non-transient non-serializable instance field tableMetadata | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.web.struts.pojo.PojoFormBase.populate(HttpServletRequest) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 155 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.kuali.rice.kns.web.ui.Field.getPropertyValues() may expose internal representation by returning Field.propertyValues | MALICIOUS_CODE | EI_EXPOSE_REP | 1607 | Medium |
| org.kuali.rice.kns.web.ui.Field.setPropertyValues(String[]) may expose internal representation by storing an externally mutable object into Field.propertyValues | MALICIOUS_CODE | EI_EXPOSE_REP2 | 1611 | Medium |
| Method org.kuali.rice.kns.web.ui.Field.setLookupParameters(Map) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 883 | Medium |
| Method org.kuali.rice.kns.web.ui.Field.setFieldConversions(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 792 | Medium |
| Method org.kuali.rice.kns.web.ui.Field.setLookupParameters(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 880 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.web.ui.FieldBridge.getNewFormFields(CollectionDefinitionI, BusinessObject, Maintainable, List, Set, StringBuffer, String, boolean, int) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 398 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.kuali.rice.kns.web.ui.FormatAwareDecorator.createCollectionString(Object) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 75 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to row in org.kuali.rice.kns.web.ui.SectionBridge.toSection(Inquirable, InquirySectionDefinition, BusinessObject, InquiryRestrictions) | STYLE | DLS_DEAD_LOCAL_STORE | 101 | Medium |
| Dead store to sectionRows in org.kuali.rice.kns.web.ui.SectionBridge.toSection(Inquirable, InquirySectionDefinition, BusinessObject, InquiryRestrictions) | STYLE | DLS_DEAD_LOCAL_STORE | 107 | Medium |
| Method org.kuali.rice.kns.web.ui.SectionBridge.getContainerRows(Section, CollectionDefinitionI, BusinessObject, Maintainable, Maintainable, List, Set, StringBuffer, String, boolean, int, Inquirable) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 433 | Medium |
| Nullcheck of o at line 248 of value previously dereferenced in org.kuali.rice.kns.web.ui.SectionBridge.toSection(MaintainableSectionDefinition, BusinessObject, Maintainable, Maintainable, String, List, Set) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 215 | Medium |
