Tag List Report

The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.

Tag ClassTotal number of occurrencesTag strings used by tag class
FIXME's56FIXME
TODO's708TODO

Each tag is detailed below:

FIXME's

Number of occurrences found in the code: 56

org.apache.ojb.broker.platforms.KualiMySQLSequenceManagerImplLine
should we be closing this connection in a finally block?43
should we be closing this result set in a finally block?50
org.kuali.rice.core.api.CoreConstantsLine
this should be a core config property97
org.kuali.rice.core.api.criteria.LookupCustomizerLine
add wilcards to make predicate transform more flexible ie. EqualsPredicate to AndPredicate50
org.kuali.rice.core.api.resourceloader.ResourceLoaderContainerLine
RICE MODULARITY71
RICE MODULARITY77
RICE MODULARITY90
org.kuali.rice.core.api.util.collect.ConstantsMapLine
make class threadsafe33
org.kuali.rice.core.api.util.collect.PropertiesMapLine
use generics, make class threadsafe46
org.kuali.rice.core.framework.persistence.jdbc.sql.SqlBuilderLine
wtf - weird!205
org.kuali.rice.core.impl.config.module.CoreConfigurerLine
need to move the ParameterRepositoryService & NamespaceServiceImpl and load it here93
should only load the DD maintenance docs here100
org.kuali.rice.core.impl.config.module.ModuleConfigurerLine
this class must be put in an API module somehow51
attempting to see if this fixes the ksb tests...103
org.kuali.rice.core.impl.resourceloader.RiceResourceLoaderFactoryLine
RICE MODULARITY hack to not break the hack in ResourceLoaderContainer.moveKSBLoadersDownHack();45
org.kuali.rice.core.web.cache.CacheAdminControllerLine
Could optimize this such that specific cache flushes don't execute if a complete CacheManager flush was requested100
org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImplLine
this causes null pointer - actionItemExt.setGroup(actionItem.getGroup()); actionItemExt.setLastApprovedDate(actionItem.getLastApprovedDate()); actionItemExt.setRowStyleClass();121
org.kuali.rice.kew.actionrequest.ActionRequestFactoryLine
KULRICE-5201 switched rsp_id to a varchar, so the comparison below is no longer valid if (request.getResponsibilityId() != null && request.getResponsibilityId() != 0) {679
org.kuali.rice.kew.actionrequest.ActionRequestValueLine
KULRICE-5201 switched rsp_id to a varchar, so the comparison below is no longer valid return getResponsibilityId() > 0;901
org.kuali.rice.kew.actionrequest.dao.impl.ActionRequestDAOJpaImplLine
should be jpa bulk update?67
org.kuali.rice.kew.api.doctype.DocumentTypePolicyLine
needs docs36
org.kuali.rice.kew.config.ThinClientKEWConfigurerLine
RICE MODULARITY need to fix this class at some point26
org.kuali.rice.kew.doctype.DocumentTypePolicyEnumLine
needs docs30
org.kuali.rice.kew.engine.node.dao.impl.RouteNodeDAOJpaImplLine
Can we do this better using just the JPQL query?110
Not sure this query is returning what it needs to122
org.kuali.rice.kew.engine.node.var.SetVarNodeLine
validation should be checked in documenttypexmlparser to start with64
org.kuali.rice.kew.routeheader.DocumentRouteHeaderValueLine
we assume there is only one for now1145
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImplLine
Should this check for hibernate LockAcquisitionException135
org.kuali.rice.kew.rule.GenericRoleAttributeLine
ok, this MUST return true, as it IS evaluated (don't know why) maybe investigate only calling isMatch on rule attributes as it doesn't seem that matching is relevant for role attributes...is it? throw new UnsupportedOperationException("Role attributes do not implement isMatch");67
org.kuali.rice.kew.rule.bo.RuleBaseValuesLookupableHelperServiceImplLine
KULRICE-5201 / KULRICE-5329 : Need to check to see if this makes sense now that ruleId is not a Long anymore180
org.kuali.rice.kew.rule.dao.impl.RuleAttributeDAOJpaImplLine
This query is returning multiple rows, which one should it return96
org.kuali.rice.kew.rule.dao.impl.RuleDAOJpaImplLine
nothing uses this, it's not in ruleDAO interface public List findRuleBaseValuesByObjectGraph(RuleBaseValues ruleBaseValues) { ruleBaseValues.setCurrentInd(Boolean.TRUE); ruleBaseValues.setTemplateRuleInd(Boolean.FALSE); return (List) new QueryByObject(entityManager,ruleBaseValues).toQuery().getResultList(); }206
KULRICE-5201 - This used to be a cast by new Long(l) -- assuming that the Object here in result list is actually a string or is castable to string by .toString()472
org.kuali.rice.kew.rule.service.impl.RuleServiceTestLine
When the operation below throws the expected exception (when JPA/Hibernate is used), it appears to do so while returning from the method call (at which time the expected-to-fail saving operation gets committed by Hibernate). Unfortunately, the exception gets thrown at the wrong time when returning, because any attempts to run subsequent unit tests or unit test methods during the same JUnit test run will fail, due to NOWAIT exceptions during test case startup.72
org.kuali.rice.kew.superuser.web.SuperUserActionLine
KULRICE-5201 required the following refactor since action request ids are no longer numeric (and in any case the assumption that they are strictly ordinal by time of creation may be false)394
org.kuali.rice.kim.document.rule.AttributeValidationHelperLine
This does not use the correct error path yet - may need to be moved up so that the error path is known Also, the above code would overwrite messages on the same attributes (namespaceCode) but on different rows123
org.kuali.rice.kim.impl.role.RoleServiceImplLine
What is up with this!?!1343
org.kuali.rice.kim.service.impl.UiDocumentServiceImplLine
This should be pulling by the PK, not using another method which pulls multiple records and then finds the right one here!2167
org.kuali.rice.kns.service.impl.DictionaryValidationServiceImplLine
JLR : Replacing this logic with KS-style validation is trickier, since KS validation requires a DataProvider object that can look back and find other attribute values aside from the one we're working on. Also - the date stuff below is implemented very differently. validator.validateAttributeField(businessObject, fieldName);168
JLR - this is now redundant and should be using the same code as the required processing elsewhere, but the control definition stuff doesn't really fit it doesn't seem to be used anywhere330
org.kuali.rice.kns.web.struts.action.KualiLookupActionLine
any reason this is inside this "if" instead of the outer one, like above - this seems inconsistent308
org.kuali.rice.kns.web.ui.FieldLine
this one definitely seems iffy, could be confused with regular fieldType, is there another better name or can this go away?110
org.kuali.rice.krad.authorization.PermissionDerivedRoleTypeServiceImplLine
dangerous - data changes could cause an infinite loop - should add thread-local to trap state and abort119
org.kuali.rice.krad.datadictionary.AttributeDefinitionLine
JLR - need to recreate this functionality using the ValidCharsConstraint logic218
org.kuali.rice.krad.datadictionary.validation.capability.LookupConstrainableLine
rename to getLookupConstraint()27
org.kuali.rice.krad.datadictionary.validation.processor.CaseConstraintProcessorLine
not sure if the definition and attribute value reader should change under this case73
org.kuali.rice.krad.datadictionary.validation.processor.DataTypeConstraintProcessorTestLine
cannot move to unit test dir b/c DateTimeService needs to be mocked.70
org.kuali.rice.krad.datadictionary.validation.processor.ValidCharactersConstraintProcessorLine
This shouldn't surface label key itself to the user - it should look up the label key, but this needs to be implemented in Rice189
org.kuali.rice.krad.service.impl.DictionaryValidationServiceImplLine
JLR - this is what the code was doing effectively already, but seems weird not to throw an exception here if you try to validate something that doesn't have an attribute definition179
There's got to be a cleaner way of doing this.887
I think we may want to use a new CollectionConstrainable interface instead to obtain from DictionaryObjectAttributeValueReader968
It's inefficient to be creating new attribute reader for each item in collection987
org.kuali.rice.krad.service.impl.PredicateFactoryLookupLine
issues to talk to the group about. http://kuali.org/rice/documentation/1.0.3/UG_Global/Documents/lookupwildcards.htm33
org.kuali.rice.krad.service.impl.SessionDocumentServiceImplLine
Currently using formKey for sessionId174
org.kuali.rice.krad.util.ObjectUtilsLine
(laran) This dependence should be inverted. Instead of having a core class depend on PojoPropertyUtilsBean, which is in the web layer, the web layer should depend downward to the core.213
org.kuali.rice.ksb.api.bus.support.AbstractServiceDefinitionLine
it seems that the spring bean isn't available here or something.... LOG.warn("The cache manager " + cacheManager + " was not found for " + (serviceName != null ? serviceName : localServiceName) + ". This service will not have client-side caching.");281

TODO's

Number of occurrences found in the code: 708

edu.sampleu.bookstore.maintenance.AuthorMaintainableLine
Auto-generated method stub39
edu.sampleu.bookstore.maintenance.BookMaintainableLine
Auto-generated method stub40
edu.sampleu.bookstore.rule.AuthorMaintenanceDocumentRuleLine
Auto-generated method stub44
edu.sampleu.travel.document.keyvalue.SimpleTestKeyValuesLine
Administrator don't forget to fill this in.26
edu.samplu.admin.test.ConfigNameSpaceBlanketAppITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.ConfigNameSpaceITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.ConfigParameterBlanketAppITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.ConfigParameterITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.ConfigParameterTypeITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.IdentityGroupBlanketAppITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.IdentityGroupITLine
Administrator don't forget to fill this in.29
edu.samplu.admin.test.IdentityPermissionBlanketAppITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.IdentityPermissionITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.IdentityPersonBlanketAppITLine
Administrator don't forget to fill this in.29
edu.samplu.admin.test.IdentityPersonITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.IdentityResponsibilityBlanketAppITLine
Administrator don't forget to fill this in.29
edu.samplu.admin.test.IdentityResponsibilityITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.IdentityRoleBlanketAppITLine
Administrator don't forget to fill this in.29
edu.samplu.admin.test.IdentityRoleITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.LocationCampusBlanketAppITLine
Administrator don't forget to fill this in.29
edu.samplu.admin.test.LocationCampusITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.LocationCountryBlanketAppITLine
Administrator don't forget to fill this in.29
edu.samplu.admin.test.LocationCountryITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.LocationCountyBlanketAppITLine
Administrator don't forget to fill this in.29
edu.samplu.admin.test.LocationCountyITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.LocationPostCodeBlanketAppITLine
Administrator don't forget to fill this in.29
edu.samplu.admin.test.LocationPostCodeITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.LocationStateBlanketAppITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.LocationStateITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.ReferenceCampusTypeBlanketAppITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.ReferenceCampusTypeITLine
Administrator don't forget to fill this in.29
edu.samplu.admin.test.WorkFlowDocTypeBlanketAppITLine
Administrator don't forget to fill this in.30
edu.samplu.admin.test.WorkFlowDocTypeITLine
Administrator don't forget to fill this in.30
edu.samplu.mainmenu.test.LoginLogoutITLine
Administrator don't forget to fill this in.30
edu.samplu.mainmenu.test.WorkFlowRouteRulesBlanketAppITLine
Administrator don't forget to fill this in.29
edu.samplu.mainmenu.test.WorkFlowRouteRulesDelegationITLine
Administrator don't forget to fill this in.30
edu.samplu.mainmenu.test.WorkFlowRouteRulesITLine
Administrator don't forget to fill this in.30
edu.samplu.travel.krad.test.UIFComponentValidationRegexPatternITLine
Administrator don't forget to fill this in.28
edu.samplu.travel.test.FiscalOfficerInfoMaintenanceNewITLine
Administrator don't forget to fill this in.26
org.apache.ojb.broker.platforms.PlatformMckoiImplLine
Shold we throw some kind of exception here if the escape character is different ?162
org.kuali.rice.core.api.criteria.PredicateUtilsLine
how to handle different types of data when everything comes in as string....43
org.kuali.rice.core.api.resourceloader.ParentChildResourceLoaderLine
ewestfal - THIS METHOD NEEDS JAVADOCS134
org.kuali.rice.core.api.uif.RemotableAbstractControlLine
make ModelBuilder generic so I don't have to do this.46
org.kuali.rice.core.api.uif.RemotableAbstractWidgetLine
make ModelBuilder generic so I don't have to do this.45
org.kuali.rice.core.api.util.ClassLoaderUtilsLine
why not make this so that it throws ClassNoteFoundException and doesn't return null? this is more standard behavior...134
org.kuali.rice.core.framework.config.property.AbstractBaseConfigLine
why was this using ConfigContext.getCurrentConfig in the rice BaseConfig147
can this be moved to default config file240
why going to currentContextConfig241
org.kuali.rice.core.framework.persistence.jdbc.sql.CriteriaLine
Rewrite this class with a better criteria building algorithm.44
org.kuali.rice.core.framework.persistence.jdbc.sql.SqlBuilderLine
What to do here now that the JPA version does not extend platform aware?134
What to do here now that the JPA version does not extend platform aware?333
org.kuali.rice.core.framework.persistence.jpa.RiceNumericStringSequenceStyleGeneratorLine
Make sure this generator works with MySQL, and verify that the correct numeric Hibernate Type is being used in the configure() method override.31
Should we add a configuration parameter for allowing users to specify a different supported Hibernate numeric Type if desired?40
org.kuali.rice.core.framework.persistence.jpa.metadata.EntityDescriptorLine
Cache by name and probably by class142
Cache by name and probably by class155
org.kuali.rice.core.framework.persistence.jpa.metadata.MetadataManagerLine
Should we add inverse join columns?591
Implement default name See: http://www.oracle.com/technology/products/ias/toplink/jpa/resources/toplink-jpa-annotations.html#JoinColumn645
org.kuali.rice.core.framework.persistence.ojb.TransactionManagerFactoryLine
what to do here return KSBServiceLocator.getTransactionManager();61
org.kuali.rice.core.framework.persistence.platform.DatabasePlatformLine
Had to move this down into embedded source because of the OJB dependencies. This probably will go away once we get rid of the embedded plugin.26
refactor to use a parsed Date object or milliseconds instead of date String66
This method should be replaced by the "prepared statement" functionality in the future.121
org.kuali.rice.core.impl.component.ComponentServiceTestLine
- for now this test is part of KRAD even though it should be part of the core (pending further modularity work)35
org.kuali.rice.core.impl.config.property.HierarchicalConfigParserLine
consider implementing with iteration instead of recursion, and using the jakarta commons support for parameter expansion211
org.kuali.rice.core.impl.impex.xml.ClassLoaderEntityResolverLine
maybe prefix should be changed from "resource:" to "internal:" or just "workflow:" given that it can be resolved in arbitrary ways other than ClassLoader "resources"30
revisit making this more sophisticated than just the classloader of this class (thread context classloader? plugin classloader?)71
org.kuali.rice.core.impl.impex.xml.XmlExporterServiceImplLine
KULRICE-4420 - this needs cleanup66
org.kuali.rice.core.impl.impex.xml.XmlImpexRegistryImplLine
--No comment--27
org.kuali.rice.core.impl.persistence.dao.GenericDaoOjbLine
g1zhang - THIS METHOD NEEDS JAVADOCS304
g1zhang - THIS METHOD NEEDS JAVADOCS317
org.kuali.rice.core.mail.EmailContentLine
supercede this with Spring framework and/or JavaMail mail classes20
org.kuali.rice.core.web.format.FormatterLine
add registry for non-navigable classes so there's a way to disable formatting selectively for given types contained in arrays or Collections.279
org.kuali.rice.core.web.format.PhoneNumberFormatterLine
foreign phone numbers can be different lengths end Kuali Foundation modification36
org.kuali.rice.devtools.generators.mo.ImmutableJaxbGeneratorLine
modify this constructor as needed to pass any required values and invoke the appropriate 'setter' methods");323
modify as needed to pass any required values and add them to the signature of the 'create' method");335
if create() is modified to accept required parameters, this will need to be modified");345
add validation of input value if required and throw IllegalArgumentException if needed");364
org.kuali.rice.edl.impl.EDLServletLine
Fix this in a better way (reworking the command structure maybe?) fix for KULRICE-4057 to make sure we don't destory docContent on empty command params103
Do we not want to set the content type for the response?115
org.kuali.rice.edl.impl.OfficeOfAffirmativeActionTestLine
--No comment--105
--No comment--109
--No comment--113
--No comment--117
org.kuali.rice.edl.impl.components.ValidationComponentLine
in the future, allow this to be pluggable, hardcode for now106
remove - handled this in the widgets Element edlElement = EDLXmlUtils.getEDLContent(dom, false); Element edlSubElement = EDLXmlUtils.getOrCreateChildElement(edlElement, "data", true); NodeList versionNodes = edlSubElement.getChildNodes(); for (int i = 0; i < versionNodes.getLength(); i++) { Element version = (Element) versionNodes.item(i); String current = version.getAttribute("current"); if (current == "true") { NodeList fieldNodes = version.getChildNodes(); for (int j = 0; j < fieldNodes.getLength(); j++) { Element field = (Element) fieldNodes.item(j); String fieldName = field.getAttribute("name"); if(fieldName.equals(key)) { field.setAttribute("invalid", "true"); break; } } } }117
org.kuali.rice.edl.impl.components.WorkflowDocumentActionsLine
the problem here is that the XML is still updated on a cancel so we end up without any attribute content in the document content120
org.kuali.rice.edl.impl.components.WorkgroupWorkflowEDLConfigComponentLine
add support for namespace here!69
org.kuali.rice.kcb.api.exception.KCBCheckedExceptionLine
arh14 - THIS CONSTRUCTOR NEEDS A JAVADOC35
Auto-generated constructor stub37
org.kuali.rice.kcb.service.impl.MessageDelivererRegistryServiceImplLine
we'll need to implement a plugin registry discovery mechanism long term.51
org.kuali.rice.kcb.web.spring.UserPreferencesControllerLine
does not traverse bus yet83
org.kuali.rice.ken.deliverer.impl.KEWActionListMessageDelivererLine
move hardcoded web controller actions here...108
org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImplLine
modify clone recipient list so that:406
org.kuali.rice.ken.service.impl.NotificationServiceImplLine
implement pessimistic locking on the message delivery192
implement pessimistic locking on all these message deliveries now, do dispatch in reverse...dismiss each message delivery via the appropriate deliverer217
locking mark as unlocked messageDelivery.setLockedDate(null);243
org.kuali.rice.ken.services.impl.NotificationRecipientServiceKimImplTestLine
--No comment--59
org.kuali.rice.ken.util.UtilLine
optimize this196
org.kuali.rice.ken.util.XslSourceResolverLine
Auto-generated constructor stub37
org.kuali.rice.ken.xpath.XPathTestLine
optimize this90
org.kuali.rice.kew.actionlist.OutboxTestLine
this can no longer be set on the fly and grabbed through the preferences service (default values are set at startup)238
this is a prime candidate for a mocking tool239
org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImplLine
, merge will not update the outboxitem pointer to the merged entity537
org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOOjbImplLine
delyea: add all workgroups here? orCrit.addOrCriteria(userCrit); orCrit.addOrCriteria(groupCrit); crit.addAndCriteria(orCrit); crit.addEqualTo("delegationType", DelegationType.PRIMARY.getCode()); filter.setDelegationType(DelegationType.PRIMARY.getCode()); filter.setExcludeDelegationType(false); filteredByItems += filteredByItems.length() > 0 ? ", " : ""; filteredByItems += "Primary Delegator Id"; filterOn = true; } else if (filter.getDelegatorId().trim().equals(KewApiConstants.ALL_CODE)) { // user wishes to see all secondary delegations crit.addEqualTo("workflowId", user.getWorkflowUserId().getWorkflowId()); crit.addEqualTo("delegationType", DelegationType.SECONDARY.getCode()); filter.setDelegationType(DelegationType.SECONDARY.getCode()); filter.setExcludeDelegationType(false); filteredByItems += filteredByItems.length() > 0 ? ", " : ""; filteredByItems += "Secondary Delegator Id"; filterOn = true; } else if (filter.getPrimaryDelegateId() != null && !"".equals(filter.getPrimaryDelegateId().trim())) { // user wishes to see primary delegation for a single user Criteria userCrit = new Criteria(); Criteria groupCrit = new Criteria(); Criteria orCrit = new Criteria(); userCrit.addEqualTo("delegatorPrincipalId", user.getWorkflowUserId().getWorkflowId());382
delyea: add all workgroups here? orCrit.addOrCriteria(userCrit); orCrit.addOrCriteria(groupCrit); crit.addAndCriteria(orCrit); crit.addEqualTo("delegationType", DelegationType.PRIMARY.getCode()); filter.setDelegationType(DelegationType.PRIMARY.getCode()); filter.setExcludeDelegationType(false); filteredByItems += filteredByItems.length() > 0 ? ", " : ""; filteredByItems += "Primary Delegator Id"; filterOn = true; } else if (filter.getDelegatorId() != null && !"".equals(filter.getDelegatorId().trim())) { // user wishes to see secondary delegation for a single user crit.addEqualTo("workflowId", user.getWorkflowUserId().getWorkflowId()); crit.addEqualTo("delegationType", DelegationType.SECONDARY.getCode()); filter.setDelegationType(DelegationType.SECONDARY.getCode()); filter.setExcludeDelegationType(false); Criteria userCrit = new Criteria(); Criteria groupCrit = new Criteria(); if (filter.isExcludeDelegatorId()) { Criteria userNull = new Criteria(); userCrit.addNotEqualTo("delegatorPrincipalId", filter.getDelegatorId()); userNull.addIsNull("delegatorPrincipalId"); userCrit.addOrCriteria(userNull); Criteria groupNull = new Criteria(); groupCrit.addNotEqualTo("delegatorGroupId", filter.getDelegatorId()); groupNull.addIsNull("delegatorGroupId"); groupCrit.addOrCriteria(groupNull); crit.addAndCriteria(userCrit); crit.addAndCriteria(groupCrit); } else { Criteria orCrit = new Criteria(); userCrit.addEqualTo("delegatorPrincipalId", filter.getDelegatorId()); groupCrit.addEqualTo("delegatorGroupId", filter.getDelegatorId()); orCrit.addOrCriteria(userCrit); orCrit.addOrCriteria(groupCrit); crit.addAndCriteria(orCrit); } filteredByItems += filteredByItems.length() > 0 ? ", " : ""; filteredByItems += "SeDelegator Id"; filterOn = true; } else if (StringUtils.isBlank(filter.getPrimaryDelegateId()) && StringUtils.isBlank(filter.getDelegatorId())) { crit.addEqualTo("workflowId", user.getWorkflowUserId().getWorkflowId()); if (filter.getDelegationType() != null && !"".equals(filter.getDelegationType().trim())) { if (filter.isExcludeDelegationType()) { Criteria critNotEqual = new Criteria(); Criteria critNull = new Criteria(); critNotEqual.addNotEqualTo("delegationType", filter.getDelegationType()); critNull.addIsNull("delegationType"); critNotEqual.addOrCriteria(critNull); crit.addAndCriteria(critNotEqual); } else { crit.addEqualTo("delegationType", filter.getDelegationType()); } } }407
org.kuali.rice.kew.actionlist.web.ActionListActionLine
see DocumentSecurityServiceImpl.checkAuthorizations to see how the Handler replaces the Attribute552
fill this out - DocumentSecurityServiceImpl.processDocumentRequiringExtensionProcessing865
fill this out - see DocumentSecurityServiceImpl.partitionDocumentsForSecurity875
org.kuali.rice.kew.actionrequest.ActionRequestFactoryLine
KULRICE-5329 Verify that this code below makes sense and is sufficient681
org.kuali.rice.kew.actionrequest.ActionRequestValueLine
KULRICE-5329 Verify that this code below makes sense903
- this javadoc copied from DTOConverter, needs to be updated!1041
org.kuali.rice.kew.actionrequest.dao.impl.ActionRequestDAOJpaImplLine
Runtime might not be the right thing to do here...265
org.kuali.rice.kew.actionrequest.dao.impl.ActionRequestDAOOjbImplLine
Runtime might not be the right thing to do here...118
org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImplLine
this still won't work in certain cases when checking from the root816
since we only store the workgroup id for workgroup requests, if the user is in a workgroup that has a request than we need get all the requests with workgroup ids and see if our user is in that group1012
org.kuali.rice.kew.actions.ActionRegistryImplLine
ActionTakenEvent is not an interface so we can't fetch them through the GlobalResourceLoader, for now, just use the ObjectDefinitionResolver112
the exception handling here is a bit wonky116
org.kuali.rice.kew.actions.AdHocRouteTestLine
test adhocing of approve requests285
org.kuali.rice.kew.actions.MoveDocumentActionLine
this whole bit is a bit hacky at the moment120
org.kuali.rice.kew.actions.ReturnToPreviousNodeActionLine
will this work properly in the case of an ALL APPROVE role requests with some of the requests already completed?99
might not need this, if so, do role check183
what if the activeNodeInstance already has next nodes?397
really we need to call transitionTo on this node, how can we do that? this isn't an issue yet because we only allow simple nodes and split nodes at the moment which do no real work on transitionTo but we may need to enhance that in the future407
org.kuali.rice.kew.actions.RouteDocumentActionLine
this will get all pending AR's even if they haven't been in an action list... This seems bad98
org.kuali.rice.kew.actions.SuperUserActionRequestApproveEventLine
this should be checked88
org.kuali.rice.kew.actions.SuperUserApproveEventLine
this is used because calling this code from SuperUserAction without it causes an optimistic lock64
org.kuali.rice.kew.actiontaken.ActionTakenValueLine
this stinks to have to have a dependency on UserSession here118
this stinks to have to have a dependency on UserSession here152
org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOJpaImplLine
perhaps runtime isn't the best here, maybe a dao runtime exception120
org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOOjbImplLine
perhaps runtime isn't the best here, maybe a dao runtime exception110
org.kuali.rice.kew.api.WorkflowDocumentLine
..44
- it is intended that operations against document data on this are only "flushed" when an action is performed...46
- be sure to mention that once this document is deleted, this api effectively becomes "dead" when you try to execute any document operation136
org.kuali.rice.kew.api.WorkflowDocumentFactoryLine
..34
--No comment--58
--No comment--76
--No comment--95
org.kuali.rice.kew.api.action.ActionRequestLine
if create() is modified to accept required parameters, this will need to be modified507
org.kuali.rice.kew.api.action.ActionTypeLine
...26
org.kuali.rice.kew.api.action.RoutingReportCriteriaLine
add validation of input value if required and throw IllegalArgumentException if needed298
add validation of input value if required and throw IllegalArgumentException if needed303
add validation of input value if required and throw IllegalArgumentException if needed308
add validation of input value if required and throw IllegalArgumentException if needed313
add validation of input value if required and throw IllegalArgumentException if needed318
add validation of input value if required and throw IllegalArgumentException if needed323
add validation of input value if required and throw IllegalArgumentException if needed328
add validation of input value if required and throw IllegalArgumentException if needed333
add validation of input value if required and throw IllegalArgumentException if needed338
add validation of input value if required and throw IllegalArgumentException if needed343
add validation of input value if required and throw IllegalArgumentException if needed348
org.kuali.rice.kew.api.action.WorkflowDocumentActionsServiceLine
finish javadoc1090
add, annotate, and javadoc the following methods to this service1346
org.kuali.rice.kew.api.doctype.DocumentTypePolicyLine
...26
org.kuali.rice.kew.api.doctype.DocumentTypePolicyMapAdapterLine
...27
org.kuali.rice.kew.api.doctype.DocumentTypeServiceLine
...31
org.kuali.rice.kew.api.doctype.ProcessDefinitionContractLine
ewestfal don't forget to fill this in.22
org.kuali.rice.kew.api.doctype.RouteNodeConfigurationParameterContractLine
ewestfal don't forget to fill this in.22
org.kuali.rice.kew.api.doctype.RouteNodeContractLine
ewestfal don't forget to fill this in.24
org.kuali.rice.kew.api.doctype.RoutePathContractLine
ewestfal don't forget to fill this in.21
org.kuali.rice.kew.api.document.DocumentDetailLine
modify this constructor as needed to pass any required values and invoke the appropriate 'setter' methods122
org.kuali.rice.kew.api.document.DocumentStatusLine
...28
org.kuali.rice.kew.api.document.DocumentStatusCategoryLine
...26
org.kuali.rice.kew.api.document.DocumentStatusTransitionLine
add validation of input value if required and throw IllegalArgumentException if needed171
add validation of input value if required and throw IllegalArgumentException if needed176
add validation of input value if required and throw IllegalArgumentException if needed181
add validation of input value if required and throw IllegalArgumentException if needed186
add validation of input value if required and throw IllegalArgumentException if needed191
org.kuali.rice.kew.api.document.DocumentUpdateLine
document the fact that this will auto-truncate the title...157
org.kuali.rice.kew.api.document.WorkflowDocumentServiceLine
... annotate for JAX-WS!43
org.kuali.rice.kew.api.document.node.RouteNodeInstanceLine
modify this constructor as needed to pass any required values and invoke the appropriate 'setter' methods214
modify as needed to pass any required values and add them to the signature of the 'create' method218
if create() is modified to accept required parameters, this will need to be modified226
add validation of input value if required and throw IllegalArgumentException if needed315
add validation of input value if required and throw IllegalArgumentException if needed320
add validation of input value if required and throw IllegalArgumentException if needed325
add validation of input value if required and throw IllegalArgumentException if needed330
add validation of input value if required and throw IllegalArgumentException if needed335
add validation of input value if required and throw IllegalArgumentException if needed340
add validation of input value if required and throw IllegalArgumentException if needed345
add validation of input value if required and throw IllegalArgumentException if needed350
add validation of input value if required and throw IllegalArgumentException if needed355
add validation of input value if required and throw IllegalArgumentException if needed360
add validation of input value if required and throw IllegalArgumentException if needed365
org.kuali.rice.kew.api.document.node.RouteNodeInstanceStateLine
modify this constructor as needed to pass any required values and invoke the appropriate 'setter' methods98
modify as needed to pass any required values and add them to the signature of the 'create' method102
if create() is modified to accept required parameters, this will need to be modified110
add validation of input value if required and throw IllegalArgumentException if needed138
add validation of input value if required and throw IllegalArgumentException if needed143
add validation of input value if required and throw IllegalArgumentException if needed148
org.kuali.rice.kew.api.note.NoteLine
if create() is modified to accept required parameters, this will need to be modified151
org.kuali.rice.kew.api.peopleflow.PeopleFlowServiceLine
...45
org.kuali.rice.kew.api.repository.type.KewTypeAttributeLine
verify that the attributeDefinitionID field matches the id field in the builder218
org.kuali.rice.kew.api.rule.RuleExpressionLine
modify this constructor as needed to pass any required values and invoke the appropriate 'setter' methods121
modify as needed to pass any required values and add them to the signature of the 'create' method125
if create() is modified to accept required parameters, this will need to be modified133
add validation of input value if required and throw IllegalArgumentException if needed173
add validation of input value if required and throw IllegalArgumentException if needed178
add validation of input value if required and throw IllegalArgumentException if needed183
add validation of input value if required and throw IllegalArgumentException if needed188
add validation of input value if required and throw IllegalArgumentException if needed193
org.kuali.rice.kew.api.rule.RuleExtensionLine
if create() is modified to accept required parameters, this will need to be modified118
org.kuali.rice.kew.api.rule.RuleTemplateLine
modify this constructor as needed to pass any required values and invoke the appropriate 'setter' methods190
modify as needed to pass any required values and add them to the signature of the 'create' method194
if create() is modified to accept required parameters, this will need to be modified202
org.kuali.rice.kew.api.rule.RuleTemplateOptionLine
modify this constructor as needed to pass any required values and invoke the appropriate 'setter' methods121
modify as needed to pass any required values and add them to the signature of the 'create' method125
if create() is modified to accept required parameters, this will need to be modified133
add validation of input value if required and throw IllegalArgumentException if needed173
add validation of input value if required and throw IllegalArgumentException if needed178
add validation of input value if required and throw IllegalArgumentException if needed183
add validation of input value if required and throw IllegalArgumentException if needed188
add validation of input value if required and throw IllegalArgumentException if needed193
org.kuali.rice.kew.batch.XmlIngestionTestLine
beef this up need a reliable way to test if the file arrived in the right date-stamped subdirectory (maybe just pick the last, or first directory?)161
org.kuali.rice.kew.batch.XmlPollerServiceImplLine
try reading the pending file or stop?215
org.kuali.rice.kew.batch.XmlSchemaTestLine
finish this test when we figure out how to conveniently use namespaces with XPath103
org.kuali.rice.kew.clientapp.ThinClientTestLine
remove when http://jira.codehaus.org/browse/SUREFIRE-535 is fixed152
org.kuali.rice.kew.config.KEWConfigurerLine
Because a lot of our lifecycles live behind the embedded plugin and the KEWConfigurer does not, this is a simple measure to load these without having to deal with the removal of the embedded plugin right away.109
org.kuali.rice.kew.config.ThinClientKEWConfigurerLine
this seems like a total hack the way this is happening, see the addModulesResourceLoaders // method RiceConfigurer as well kewConfigurer.getResourceLoadersToRegister(); }45
org.kuali.rice.kew.config.ThinClientResourceLoaderLine
we need to add support for other invocation protocols and implementations, but for now...184
org.kuali.rice.kew.docsearch.DocumentSearchCriteriaEboLine
map to DocSearchCriteriaBo30
org.kuali.rice.kew.docsearch.DocumentSearchCriteriaProcessorKEWAdapterLine
- KULRICE-5635 - need to add back in the building of application document status row, commented out for now because this code is weird! If Application Document Status policy is in effect for this document type, add search attributes for document status, and transition dates. Note: document status field is a drop down if valid statuses are defined, a text input field otherwise. fixedDocumentAttributeRows.addAll( buildAppDocStatusRows(documentType) );175
org.kuali.rice.kew.docsearch.DocumentSearchCustomizationHandlerServiceImplLine
...46
org.kuali.rice.kew.docsearch.DocumentSearchTestLine
Add some wildcard testing for the document type attribute once wildcards are usable with it.394
finish this test494
org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImplLine
- KULRICE-5832 - need to add support for whether or not the saved search is a detailed/advanced search, this was originally stored with savedSearchString in Rice 1.x483
org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttributeLine
- KULRICE-5630 - I'm pretty sure this *won't* work because we don't store lower and upper bound keys in the document attributes637
org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttributeTestLine
put document content here?797
this is currently commented out because we can't test this properly through the unit test since the filtering of the column actually happens in the web-tier. Shoudl this be the case? Maybe we need to re-examine when we refactor document search.990
org.kuali.rice.kew.doctype.ApplicationDocumentStatusIdLine
Finish implementing this method. Compare o to pk and return true or false.94
Implement this method99
org.kuali.rice.kew.doctype.DocumentTypePermissionServiceTestLine
set up actual KIM permissions in DB and verify this permission works53
org.kuali.rice.kew.doctype.DocumentTypePolicyIdLine
Implement the equals() and hashCode() methods.27
org.kuali.rice.kew.doctype.DocumentTypeTestLine
Ignored currently, this method goes into an infinite loop in document type parsing (ick!) when invoked...not good.64
org.kuali.rice.kew.doctype.service.impl.DocumentTypePermissionServiceImplLine
See KULRICE-3490, make assembly of permission details dynamic based on db config315
org.kuali.rice.kew.document.RoutingRuleMaintainableLine
can we just let the locking key be the primary key? (ruleBaseValuesId)151
org.kuali.rice.kew.document.RoutingRuleMaintainableBusRuleLine
hook validation of rule data into PreRules237
org.kuali.rice.kew.engine.BlanketApproveEngineLine
document magical join node workage (ask Eric)112
this has been set arbitrarily high because the implemented processing model here will probably not work for large parallel object graphs. This needs to be re-evaluated, see KULWF-459.113
org.kuali.rice.kew.engine.CompatUtilsLine
potential for infinite recursion here if their document type has loops in it. Should this be a concern? If their routing version is really "route level" then there should be no cycles.55
org.kuali.rice.kew.engine.SequentialRoutingTestLine
when we are able to, we should also verify the RouteNodeInstances are correct126
org.kuali.rice.kew.engine.StandardWorkflowEngineLine
throw a new 'RoutingException' which holds the RoutingState152
update document content on context?231
more info in message269
extract this into some sort of component which handles transitioning document state390
is the logic for going processed still going to be valid?408
perhaps the policies could also be factored out?413
what route method name to pass to this?480
in some cases, someone may modify the route header in the post processor, if we don't save before and reload after we will get an optimistic lock exception, we need to work on a better solution for this!565
get the routeContext in this method - it should be a better object than the nodeInstance568
get the routeContext in this method - it should be a better object than the nodeInstance596
get the routeContext in this method - it should be a better object than the nodeInstance604
this shows up in a few places and could totally be extracted to a method632
get the routeContext in this method - it should be a better object than the nodeInstance655
get the routeContext in this method - it should be a better object than the nodeInstance667
org.kuali.rice.kew.engine.simulation.SimulationEngineLine
set document content145
delyea - deep copy below502
org.kuali.rice.kew.engine.transition.DynamicTransitionEngineLine
interate the all the nodes and attach the dynamic node as the 'process' don't include the dynamic node instance in the routing structure - require a correctly built graph change dynamic node signiture to next node because of above reconcile branching if necessary38
implement this feature throw new UnsupportedOperationException("Need to implement support for branch generation!");107
org.kuali.rice.kew.framework.actionlist.ActionListCustomizationHandlerServiceLine
Modeled from DocumentSecurityHandlerService, but get a better description43
org.kuali.rice.kew.framework.postprocessor.DocumentRouteLevelChangeLine
for now we will include the new node-based routing fields onto this object to avoid an interface change to the PostProcessor interface.29
org.kuali.rice.kew.impl.action.WorkflowDocumentActionsServiceImplLine
remove this once we stop throwing WorkflowException everywhere!314
ewestfal - THIS METHOD NEEDS JAVADOCS734
THIS NEEDS TESTING!!!!! IT WAS A GUESS ON HOW THIS WORKS1072
confirm that the initiator is not already there in the actionstaken1242
- this code is temporary until we get rid of all the crazy throwing of "WorkflowException"1307
fix this up once the checked exception goes away1330
org.kuali.rice.kew.impl.actionlist.ActionListCustomizationHandlerServiceImplLine
Iterate through the list of Action Items. Return Action Item Customizations only for those Action Items which...53
Figure out how to properly load a CAL Attribute Load the CustomActionListAttribute55
give a better message like attribute name or something64
org.kuali.rice.kew.impl.document.DefaultWorkflowDocumentProviderLine
--No comment--26
org.kuali.rice.kew.impl.document.WorkflowDocumentImplLine
..57
- it is intended that operations against document data on this are only "flushed" when an action is performed...59
- be sure to mention that once this document is deleted, this api effectively becomes "dead" when you try to execute any document operation391
org.kuali.rice.kew.impl.document.WorkflowDocumentPrototypeLine
--No comment--22
org.kuali.rice.kew.impl.document.WorkflowDocumentProviderLine
--No comment--23
org.kuali.rice.kew.impl.document.search.DocumentSearchCriteriaBoLookupableHelperServiceLine
- KULRICE-5738 - add check here to make sure the searchable attribute should be displayed in result set right now this is default always including all searchable attributes!808
- comment out for now, not sure we really want to do this... column.setPropertyName(DOCUMENT_ATTRIBUTE_PROPERTY_NAME_PREFIX + column.getPropertyName());869
org.kuali.rice.kew.impl.document.search.DocumentSearchGeneratorImplLine
- KULRICE-5755 - should probably set as many properties on the document as we can290
org.kuali.rice.kew.impl.note.NoteServiceImplLine
--No comment--30
org.kuali.rice.kew.impl.peopleflow.PeopleFlowLine
--No comment--19
*/ }21
org.kuali.rice.kew.impl.peopleflow.PeopleFlowRequestGeneratorImplLine
- KULRICE-5726 - still need to implement support for ignoring built-in kim delegates whenever peopleflow delegate(s) are defined101
org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImplLine
is there a reason we reload the document here?197
org.kuali.rice.kew.notes.web.AttachmentServletLine
This should probably be put into KewApiConstants when contributed back to Rice 1.0.354
org.kuali.rice.kew.notification.service.impl.DefaultNotificationServiceLine
JLR - replace with direct call to ActionListEmailService76
org.kuali.rice.kew.plugin.HotDeployerLine
somehow the code which checks for new plugins and which loads plugins initially needs to be consolidated, maybe with some sort of set of PluginLocators? or something along those lines?100
org.kuali.rice.kew.plugin.PluginRegistryFactoryLine
maybe ensure that if these directories are the same, that only one gets through38
org.kuali.rice.kew.plugin.ServerPluginRegistryLine
make the delay configurable69
org.kuali.rice.kew.plugin.ZipFilePluginLoaderLine
how to handle locked files under windows?!? This will throw an IOException in this case.118
org.kuali.rice.kew.preferences.service.impl.PreferencesServiceImplLine
JLR - I'm not sure why this isSaveRequired logic is necessary -- couldn't we do something like the following? if (isSaveRequired) getUserOptionService().save(principalId, optionValueMap);138
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImplLine
Should this happen???137
org.kuali.rice.kew.responsibility.dao.ResponsibilityIdDAOLine
To change the template for this generated type comment go to Window - Preferences - Java - Code Style - Code Templates21
org.kuali.rice.kew.responsibility.service.impl.ResponsibilityIdServiceImplLine
To change the template for this generated type comment go to Window - Preferences - Java - Code Style - Code Templates24
org.kuali.rice.kew.routeheader.AppDocStatusTestLine
when we are able to, we should also verify the RouteNodeInstances are correct121
when we are able to, we should also verify the RouteNodeInstances are correct205
org.kuali.rice.kew.routeheader.DocumentRouteHeaderValueLine
the isRouteLevelDocument junk can be ripped out287
org.kuali.rice.kew.routeheader.StandardDocumentContentLine
can we have application content without a root node?121
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImplLine
What cache do we clear when using JPA148
What cache do we clear when using JPA169
org.kuali.rice.kew.routeheader.service.impl.WorkflowDocumentServiceImplLine
As with superUserReturnDocumentToPreviousNode, we allow for the passing in of a document ID here to allow for the document load inside the current running transaction. Otherwise we get an optimistic lock exception when attempting to save the branch after the transition to the 'A' status.375
As with superUserReturnDocumentToPreviousNode, we allow for the passing in of a document ID here to allow for the document load inside the current running transaction. Otherwise we get an optimistic lock exception when attempting to save the branch after the transition to the 'A' status.420
remove this implementation in favor of having the SuperUserAction call through the WorkflowDocument object. This method is here to resolve KULWF-727 where we were getting an optimistic lock exception from the super user screen on return to previous node. This allows us to load the DocumentRouteHeaderValue inside of the transaction interceptor so that we can stay within the same PersistenceBroker cache.429
org.kuali.rice.kew.routing.web.ClientAppDocHandlerRedirectActionLine
what should happen here if parms are missing; no proper ActionForward from here83
org.kuali.rice.kew.rule.AbstractWorkflowAttributeLine
document these two methods ... what are these for?66
org.kuali.rice.kew.rule.BSFRuleExpressionLine
this should really be renamed since it is no longer using apache BSF35
org.kuali.rice.kew.rule.FlexRMLine
really the route context just needs to be able to support nested create and clears (i.e. a Stack model similar to transaction intercepting in Spring) and we wouldn't have to do this174
org.kuali.rice.kew.rule.GenericWorkflowAttributeLine
implement me!138
this is not fully implemented! e.g. generic property map like StandardGenericXmlAttribute154
org.kuali.rice.kew.rule.TemplateRuleSelectorLine
really the route context just needs to be able to support nested create and clears (i.e. a Stack model similar to transaction intercepting in Spring) and we wouldn't have to do this87
org.kuali.rice.kew.rule.bo.RuleBaseValuesLookupableHelperServiceImplLine
replace this with new API find method ??288
org.kuali.rice.kew.rule.bo.RuleDelegationLookupableHelperServiceImplLine
KULRICE-5201 - verify that this is a reasonable initialization given that ruleId is no longer a Long167
replace this with new API find method ??275
jjhanso - THIS METHOD NEEDS JAVADOCS return super.performLookup(lookupForm, resultTable, bounded);374
org.kuali.rice.kew.rule.dao.impl.RuleDelegationDAOJpaImplLine
jjhanso - THIS METHOD NEEDS JAVADOCS90
jjhanso - THIS METHOD NEEDS JAVADOCS103
org.kuali.rice.kew.rule.service.impl.RuleServiceInternalImplLine
if more than one delegate is edited from the create delegation screen (which currently can not happen), then this logic will not work.186
consolidate this method with makeCurrent. The reason there's a seperate implementation is because the original makeCurrent(...) could not properly handle versioning a List of multiple rules (including multiple delegates rules for a single parent. ALso, this work is being done for a patch so we want to mitigate the impact on the existing rule code.231
this method ended up being a mess, we should get rid of this as soon as we can830
FIXME: need to copy the rule expression here too?1031
this method is extremely slow, if we could implement a more optimized query here, that would help tremendously1128
org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttributeLine
possibly simplify this even further by making WorkflowAttributeValidationError a WorkflowServiceError, and dispense with custom error generators...623
org.kuali.rice.kew.server.BeanConverterTesterLine
there is some crossover between this test and the DocumentContentTest, do we really need both of them???122
org.kuali.rice.kew.server.DTOConverterTestLine
there is some crossover between this test and the DocumentContentTest, do we really need both of them???104
org.kuali.rice.kew.superuser.web.SuperUserActionLine
As part of KULRICE-5329 this change above needs to be verified and compared with code below // Search the list for the action request with the highest action request value. for (Iterator<?> actnReqIter = superUserForm.getActionRequests().iterator(); actnReqIter.hasNext();) { ActionRequestValue tmpActnReq = (ActionRequestValue) actnReqIter.next(); if (tmpActnReq.getActionRequestId().longValue() > latestId) { latestActnReq = tmpActnReq; latestId = tmpActnReq.getActionRequestId().longValue(); } }427
org.kuali.rice.kew.support.xstream.XStreamSafeEvaluatorTestLine
we currently can't support xpath expressions that start with .// When we can, uncomment this test code. nodeList = (NodeList)xpath.evaluate(XPATH_GLOBAL_VALUE, node, XPathConstants.NODESET); assertEquals("There should be two value elements.", 2, nodeList.getLength()); // evaluate as xstreamsafe nodeList = (NodeList)xpath.evaluate(wrapXStreamSafe(XPATH_GLOBAL_VALUE), node, XPathConstants.NODESET); assertEquals("There should be three value elements now.", 3, nodeList.getLength());173
org.kuali.rice.kew.test.FakeServiceLine
consider merging with {@link TestServiceInterface}/{@link GenericTestService} in KSB module24
org.kuali.rice.kew.test.FakeServiceImplLine
consider merging with {@link TestServiceInterface}/{@link GenericTestService} in KSB module26
org.kuali.rice.kew.useroptions.UserOptionsIdLine
Implement the equals() and hashCode() methods.26
org.kuali.rice.kew.xml.ClassLoaderEntityResolverLine
maybe prefix should be changed from "resource:" to "internal:" or just "workflow:" given that it can be resolved in arbitrary ways other than ClassLoader "resources"30
revisit making this more sophisticated than just the classloader of this class (thread context classloader? plugin classloader?)71
org.kuali.rice.kew.xml.DocumentTypeXmlParserLine
have a validation function that takes an xpath statement and blows chunks if that statement returns false305
org.kuali.rice.kew.xml.RuleExtensionXmlParserLine
need test case for this96
org.kuali.rice.kew.xml.export.GroupXmlExporterLine
jjhanso - THIS METHOD NEEDS JAVADOCS63
org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluatorLine
I noticed that the original implementation of this method was not doing the following work so I'm just tacking it on the end, there's probably a more elegent way to integrate it with the algorithm above...96
we currently can't support expressions that start with .//150
org.kuali.rice.kim.api.common.assignee.AssigneeContractLine
Get a better description22
org.kuali.rice.kim.api.identity.CodedAttributeLine
if create() is modified to accept required parameters, this will need to be modified144
org.kuali.rice.kim.api.identity.affiliation.EntityAffiliationTypeLine
if create() is modified to accept required parameters, this will need to be modified153
org.kuali.rice.kim.api.identity.personal.EntityBioDemographicsLine
modify as needed to pass any required values and add them to the signature of the 'create' method400
org.kuali.rice.kim.api.identity.personal.EntityEthnicityLine
add validation of input value if required and throw IllegalArgumentException if needed240
org.kuali.rice.kim.api.identity.phone.EntityPhoneLine
get extension from country code table359
append "+xxx" if country is not the default country360
org.kuali.rice.kim.api.identity.principal.PrincipalLine
modify as needed to pass any required values and add them to the signature of the 'create' method148
if create() is modified to accept required parameters, this will need to be modified156
org.kuali.rice.kim.api.identity.privacy.EntityPrivacyPreferencesLine
add validation of input value if required and throw IllegalArgumentException if needed229
add validation of input value if required and throw IllegalArgumentException if needed234
add validation of input value if required and throw IllegalArgumentException if needed239
add validation of input value if required and throw IllegalArgumentException if needed244
add validation of input value if required and throw IllegalArgumentException if needed249
add validation of input value if required and throw IllegalArgumentException if needed254
add validation of input value if required and throw IllegalArgumentException if needed259
org.kuali.rice.kim.api.test.JAXBAssertLine
- copied this from the core api test module, find a better way to share this code!33
org.kuali.rice.kim.bo.ui.GroupDocumentMemberLine
remove the default62
org.kuali.rice.kim.bo.ui.KimDocumentRoleMemberLine
remove the default71
org.kuali.rice.kim.bo.ui.KimDocumentRoleResponsibilityLine
this needs to be changed to use the KimResponsibilityInfo object but the changes are involved in the UiDocumentService based on the copyProperties method used to move the data to/from the document/real objects84
org.kuali.rice.kim.bo.ui.KimDocumentRoleResponsibilityActionLine
this needs to be changed to use the KimResponsibilityInfo object but the changes are involved in the UiDocumentService based on the copyProperties method used to move the data to/from the document/real objects85
this needs to be changed to use the KimResponsibilityInfo object but the changes are involved in the UiDocumentService based on the copyProperties method used to move the data to/from the document/real objects161
org.kuali.rice.kim.bo.ui.PersonDocumentPhoneLine
get extension from country code table170
append "+xxx" if country is not the default country171
org.kuali.rice.kim.client.acegi.KualiDistributedSessionExpiredAuthenticationLine
lsymms - THIS METHOD NEEDS JAVADOCS40
lsymms - THIS METHOD NEEDS JAVADOCS50
org.kuali.rice.kim.client.acegi.KualiDistributedSessionFilterLine
Need to add check for missing DST (update {@link org.kuali.rice.kim.sesn.DistributedSession})32
org.kuali.rice.kim.document.rule.IdentityManagementGroupDocumentRuleLine
do not have detail bus rule yet, so just check this for now.154
org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRuleLine
do not have detail bus rule yet, so just check this for now.565
org.kuali.rice.kim.document.rule.IdentityManagementRoleDocumentRuleLine
do not have detail bus rule yet, so just check this for now.591
org.kuali.rice.kim.impl.group.GroupServiceImplLine
PRIME example of something for new Criteria API312
org.kuali.rice.kim.impl.identity.IdentityArchiveServiceLine
this should probably return some kind of Future<EntityDefault> if we can find a way to remote that89
org.kuali.rice.kim.impl.identity.PersonServiceImplLine
- now check if these people have the given role build a principal list270
convert this to the new criteria predicates332
org.kuali.rice.kim.impl.jaxb.PermissionDataXmlDTOLine
Verify that the above behavior is correct.62
org.kuali.rice.kim.impl.jaxb.RoleDataXmlDTOLine
Verify that the above behavior is correct.147
org.kuali.rice.kim.impl.jaxb.RolePermissionsXmlDTOLine
Alter the role/permission service APIs so that finding all the permissions assigned to a role is possible; the current lack of such an API method prevents role permissions from being exported.42
Use new API method once it becomes available!!!!158
org.kuali.rice.kim.impl.permission.PermissionServiceImplLine
This could be made a little better by collecting the role IDs into a set and then processing the distinct list rather than a check for every permission198
org.kuali.rice.kim.impl.responsibility.ResponsibilityLookupableHelperServiceImplLine
why is this not using the businessObject parmeter's class?77
org.kuali.rice.kim.impl.responsibility.ResponsibilityServiceImplLine
filter with qualifiers332
filter with qualifiers441
org.kuali.rice.kim.impl.role.RoleDaoOjbLine
if no role id found that means principalname not matched, need to do something to force to return empty list372
org.kuali.rice.kim.impl.role.RoleServiceBaseLine
pulling attribute IDs repeatedly is inefficient - consider caching the entire list as a map511
org.kuali.rice.kim.impl.role.RoleServiceImplLine
remove reference to Attributes here and use Attributes instead.1137
org.kuali.rice.kim.impl.type.KimTypeLookupableHelperServiceImplLine
clean this up.79
org.kuali.rice.kim.lookup.KimLookupableHelperServiceImplLine
to let it rendering 'create new' and 'edit'/'copy' button43
org.kuali.rice.kim.service.impl.LdapUiDocumentServiceImplLine
verify if you want to add && newRoleMember.isActive() condition to if...422
org.kuali.rice.kim.service.impl.UiDocumentServiceImplLine
in order to resolve optimistic locking issue. has to get identity and set the version number if identity records matched Need to look into this. kimEntity = origEntity;182
- remove this hack... This is here because currently jpa only seems to be going 2 levels deep on the eager fetching.622
this should be replaced with the retrieval and storage of that value in the document tables and not re-retrieved here1307
principalId is not ready here yet ?1357
verify if you want to add && newRoleMember.isActive() condition to if...1431
verify if you want to add && newRoleMember.isActive() condition to if...2247
verify if you want to add && newRoleMember.isActive() condition to if...2425
implement logic same as role members - do not insert qualifiers with blank values2484
when a group is inactivated, inactivate the memberships of principals in that group and the memberships of that group in roles2637
verify if you want to add && newGroupMember.isActive() condition to if...2697
org.kuali.rice.kim.sesn.DistributedSessionLine
add clear principals to clearSesn33
org.kuali.rice.kim.sesn.timeouthandlers.AbstractTimeoutHandlerLine
change how TimoutHandlers choose fields from ndx to name.20
org.kuali.rice.kim.sesn.timeouthandlers.DisabledTimeoutHandlerLine
lsymms - THIS METHOD NEEDS JAVADOCS33
org.kuali.rice.kim.test.service.PermissionServiceTestLine
- getting a SOAPFaultException on this call; fix and un-comment assertFalse(getPermissionService().hasPermissionByTemplateName("entity124pId", "KUALI", "Default", new Map<String, String>()));67
- jax-ws remoted service returns null; local return empty List. Fix webservice return86
org.kuali.rice.kim.test.service.PersonServiceImplTestLine
property is being appended in the wrong place - fix208
org.kuali.rice.kim.web.struts.action.IdentityManagementPersonDocumentActionLine
how should this forward be handled589
org.kuali.rice.kns.datadictionary.LookupDefinitionLine
catch exception if service locator call fails161
org.kuali.rice.kns.datadictionary.exporter.AttributesMapBuilderLine
consider whether to export class names from the attribute security99
org.kuali.rice.kns.document.authorization.MaintenanceDocumentRestrictionsBaseLine
next block could probably be removed since the superclass would return null for a read-only field52
org.kuali.rice.kns.inquiry.KualiInquirableImplLine
generics do not match between call to module service and call to lookup service98
If this is to get a single BO, why using the lookup service?126
replace with inquiry menu bar461
org.kuali.rice.kns.kim.type.DataDictionaryTypeServiceBaseLine
will this work for user ID attributes?284
org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImplLine
why is this not using the businessObject parmeter's class?495
org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImplLine
Fix? - this does not handle nested properties within the EBO.78
org.kuali.rice.kns.lookup.LookupResultsServiceImplLine
use the other identifier165
use the other identifier186
org.kuali.rice.kns.lookup.LookupUtilsLine
chb: that should not be the case -- the relationship object the two rely upon should be established outside of the lookup/quickfinder code419
org.kuali.rice.kns.maintenance.KualiGlobalMaintainableImplLine
this needs refactoring ... its kind of lame that we have this set of compound list statements, this should all be refactored. This could be moved into a method on all GBOs, like GBO.prepareForSave(), or even better, subclass KualiGlobalMaintainableImpl for each global, since this is all maintainable-related stuff.63
remove this whole pseudo-assertion code block once this gets moved into a doc-specific maintainableImpl class.73
Revisit this. Changing since getPrimaryKeys and listPrimaryKeyFieldNames are apparently same. May be we might want to replace listPrimaryKeyFieldNames with getPrimaryKeys... Not sure.79
org.kuali.rice.kns.maintenance.KualiMaintainableImplLine
rename once 'newCollectionLines' is removed88
org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBaseLine
when/if we have standard support for DO retrieval, do this check for DO's765
Good suggestion from Aaron, dont bother checking the DB, if all of the objects PK fields dont have values. If any are null or empty, then we're done. The current way wont fail, but it will make a wasteful DB call that may not be necessary, and we want to minimize these.771
should this be getting labels from the view dictionary use the DataDictionary service to translate field name into human-readable label811
org.kuali.rice.kns.service.BusinessObjectAuthorizationServiceLine
refactor for general objects32
org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImplLine
what is the equivalent of control.isButton in KRAD314
this requires intimate knowledge of DocumentHelperServiceImpl536
org.kuali.rice.kns.service.impl.BusinessObjectMetaDataServiceImplLine
four different exit points?!192
move out to a separate method so that the logic for finding the relationships is similar to primitiveReference280
org.kuali.rice.kns.service.impl.DictionaryValidationServiceImplLine
reenable when we come up with a strategy to handle fields that are not editable else if (itemDefinition instanceof MaintainableCollectionDefinition) { MaintainableCollectionDefinition collectionDefinition = (MaintainableCollectionDefinition) itemDefinition; Collection<BusinessObject> c = (Collection<BusinessObject>) ObjectUtils.getPropertyValue(businessObject, itemDefinition.getName()); if (c != null) { int i = 0; for (BusinessObject o : c) { String newErrorPrefix = errorPrefix + itemDefinition.getName() + "[" + i + "]."; validateBusinessObjectOnMaintenanceDocumentHelper(o, collectionDefinition.getMaintainableCollections(), newErrorPrefix); validateBusinessObjectOnMaintenanceDocumentHelper(o, collectionDefinition.getMaintainableFields(), newErrorPrefix); i++; } } }*/ } }92
Formatter for currency?268
Formatter for currency?286
org.kuali.rice.kns.util.FieldUtilsLine
do we need to prefix the universalIdAttributeName in Field as well?922
assign the correct propertyName to the container in the first place. For now, I'm wary of the weird usages of constructContainerField().1409
- KULRICE-5743 - maybe need this to be smaller than the actual attribute's max length?1709
org.kuali.rice.kns.web.comparator.CellComparatorHelperLine
, do we really need to create so many comparators (1 per each cell)?98
org.kuali.rice.kns.web.struts.action.KualiActionLine
create a method for this to be used by both lookup & inquiry ?650
org.kuali.rice.kns.web.struts.action.KualiDocumentActionBaseLine
this should be pulled into a properties file303
remove this when further testing passed if (form instanceof KualiDocumentFormBase) { UserSession userSession = (UserSession) request.getSession().getAttribute(RiceConstants.USER_SESSION_KEY); // force to recreate formkey in execute method if (document instanceof SessionDocumentService && userSession.retrieveObject(kualiDocumentFormBase.getFormKey()) != null) { userSession.removeObject(kualiDocumentFormBase.getFormKey());; } }550
remove this when further testing passed if (form instanceof KualiDocumentFormBase) { UserSession userSession = (UserSession) request.getSession().getAttribute(RiceConstants.USER_SESSION_KEY); // force to recreate formkey in execute method if (document instanceof SessionDocumentService && userSession.retrieveObject(kualiDocumentFormBase.getFormKey()) != null) { userSession.removeObject(kualiDocumentFormBase.getFormKey());; } }590
gah! this is awful1391
org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentActionLine
this code should be abstracted out into a helper also is it a problem that we're not calling setGenerateDefaultValues? it blanked out the below values when I did maybe we need a new generateDefaultValues that doesn't overwrite?318
Cathy remember to delete this block of comments after I've tested. PersistableBusinessObject bo = document.getNewMaintainableObject().getBusinessObject(); Collection maintCollection = this.extractCollection(bo, collectionName); String docTypeName = ((MaintenanceDocument) maintenanceForm.getDocument()).getDocumentHeader().getWorkflowDocument().getDocumentType(); Class collectionClass = extractCollectionClass(docTypeName, collectionName);535
sort of collection, new instance should be first678
Should we keep this logic and continue using currentTabIndex as the key in the tabStates HashMap ?739
Should we keep this logic and continue using currentTabIndex as the key in the tabStates HashMap ?866
org.kuali.rice.kns.web.struts.form.KualiDocumentFormBaseLine
we should not be referencing kew constants from this class and wedding ourselves to that workflow application This class is the base action form for all documents.62
is this still needed? I think it's obsolete now84
Chris - Notes: remove the above and change the below from boNotes when notes are finished overriding note formatter to make sure they post back the full timestamp155
rk implemented to account for caps coming from kuali user service from workflow573
org.kuali.rice.kns.web.struts.form.KualiMaintenanceFormLine
to be persisted in the lookup results service instead?89
org.kuali.rice.kns.web.struts.form.LookupFormLine
remove these once DD changes have been made469
remove these once DD changes have been made474
remove these once DD changes have been made479
remove these once DD changes have been made484
org.kuali.rice.kns.web.struts.form.pojo.PojoFormBaseLine
see KULOWF-194 testForPojoHack(this, keypath);180
org.kuali.rice.kns.web.ui.FieldBridgeLine
St. Ailish says review this. A question was raised on 11-16-2006 Tuscon meeting as to why this is done here and not in the formatter.323
org.kuali.rice.kns.web.ui.SectionBridgeLine
Revisit this. Changing since getPrimaryKeys and listPrimaryKeyFieldNames are apparently same. May be we might want to replace listPrimaryKeyFieldNames with getPrimaryKeys... Not sure.762
org.kuali.rice.krad.app.persistence.jpa.RiceLocalContainerEntityManagerFactoryBeanLine
Add more vendor specific defaults...112
org.kuali.rice.krad.bo.AdHocRoutePersonLine
need some way of handling types that cannot be instantiated due to module dependencies44
org.kuali.rice.krad.bo.AdHocRoutePersonIdLine
Implement the equals() and hashCode() methods.28
org.kuali.rice.krad.bo.AdHocRouteRecipientLine
we should not be referencing kew constants from this class and wedding ourselves to that workflow application Ad Hoc Route Recipient Business Object30
org.kuali.rice.krad.bo.AdHocRouteWorkgroupIdLine
Implement the equals() and hashCode() methods.28
org.kuali.rice.krad.config.KRADConfigurerLine
FIXME hack! KRAD should not be loading core! (needed for now to publish core services)56
org.kuali.rice.krad.criteria.CriteriaLookupDaoJpaLine
There has to be a better way to do this.143
org.kuali.rice.krad.dao.impl.LookupDaoJpaLine
What to do here now that the JPA version does not extend platform aware? propertyName = getDbPlatform().getUpperCaseFunction() + "(__JPA_ALIAS[[0]]__." + propertyName + ")";431
org.kuali.rice.krad.dao.impl.NoteDaoJpaLine
Notes - Chris move remoteObjectId string to constants72
org.kuali.rice.krad.dao.impl.NoteDaoOjbLine
look into avoiding the default empty attachments being added to the note55
Notes - Chris move remoteObjectId string to constants90
Notes - Chris move remoteObjectId string to constants113
org.kuali.rice.krad.datadictionary.AttributeDefinitionLine
rename to control once ControlDefinition is removed73
This may not be required since we now use ComplexAttributeDefinition92
currently requiring a control or controlField, but this should not be case (AttrField should probably do the check)313
org.kuali.rice.krad.datadictionary.DataDictionaryLine
determine property type using generics type definition547
org.kuali.rice.krad.datadictionary.DataDictionaryIndexMapperLine
arh14 - THIS METHOD NEEDS JAVADOCS214
org.kuali.rice.krad.datadictionary.DocumentCollectionPathLine
mpham - THIS METHOD NEEDS JAVADOCS65
org.kuali.rice.krad.datadictionary.DocumentValuePathGroupLine
mpham - THIS METHOD NEEDS JAVADOCS65
org.kuali.rice.krad.datadictionary.RoutingTypeDefinitionLine
wliang - THIS METHOD NEEDS JAVADOCS65
org.kuali.rice.krad.datadictionary.mask.MaskFormatterSubStringLine
MOVE TO UNIT TEST: move this validation into the unit tests38
org.kuali.rice.krad.datadictionary.validation.ValidationPatternLine
UNIT TEST: compile all patterns to test92
org.kuali.rice.krad.datadictionary.validation.constraint.FixedPointPatternConstraintLine
delyea don't forget to fill this in.26
org.kuali.rice.krad.datadictionary.validation.constraint.IntegerPatternConstraintLine
Administrator don't forget to fill this in.26
org.kuali.rice.krad.datadictionary.validation.processor.BasePrerequisiteConstraintProcessorLine
Does this code need to be able to look at more than just the other immediate members of the object?45
org.kuali.rice.krad.datadictionary.validation.processor.RangeConstraintProcessorLine
decide if there is any reason why the following would be insufficient - i.e. if something numeric could still be cast to String at this point82
JLR - need a code review of the conversions below to make sure this is the best way to ensure accuracy across all numerics This will throw NumberFormatException if the value is 'NaN' or infinity... probably shouldn't be a NFE but something more intelligible at a higher level106
org.kuali.rice.krad.document.DocumentAuthorizerBaseTestLine
rewrite this test private static final Logger LOG = Logger.getLogger(DocumentAuthorizerBaseTest.class);24
the test for preRouteEditAuthorization should be removed GlobalVariables.setUserSession(new UserSession("quickstart")); PessimisticLockTestDocumentAuthorizer lockDocumentAuthorizer = new PessimisticLockTestDocumentAuthorizer(); lockDocumentAuthorizer.USES_PESSIMISTIC_LOCKING = false;522
sp20369 - THIS METHOD NEEDS JAVADOCS698
org.kuali.rice.krad.document.DocumentBaseLine
Auto-generated method stub129
Auto-generated method stub461
better error handling at the lower level and a better error message are needed here488
org.kuali.rice.krad.document.MaintenanceDocumentBaseLine
- build out with bo label once we get the data dictionary stuff in place build out the right classname175
refactor this out into a method380
need to convert this from using struts form file refreshAttachment();659
better error handling at the lower level and a better error message are needed here739
org.kuali.rice.krad.lookup.LookupableImplLine
delyea: where to take into account the sort ascending value (old KNS appeared to ignore?)82
force uppercase will be done in binding at some point147
delyea - is this the best way to set that the entire set has a returnable row?151
check secure fields if (field.isSecure()) { field.setSecure(false); field.setDisplayMaskValue(null); field.setEncryptedValue(null); }409
need formatting on default value and make sure it works when control converts from checkbox to radio416
this will be done by the uif validation service at some point441
; need hooks for code generated components and also this doesn't have lifecycle which could change fields471
need to handle returning anchor571
need to handle returning anchor718
do not hardcode the _self string731
org.kuali.rice.krad.maintenance.MaintainableImplLine
should this write some sort of missing message on the old side instead?414
org.kuali.rice.krad.maintenance.MaintenanceUtilsLine
implement real authorization for Maintenance Document Save/Route - KULNRVSYS-948135
org.kuali.rice.krad.rules.MaintenanceDocumentRuleBaseLine
when/if we have standard support for DO retrieval, do this check for DO's709
Good suggestion from Aaron, dont bother checking the DB, if all of the objects PK fields dont have values. If any are null or empty, then we're done. The current way wont fail, but it will make a wasteful DB call that may not be necessary, and we want to minimize these.715
should this be getting labels from the view dictionary use the DataDictionary service to translate field name into human-readable label754
org.kuali.rice.krad.service.KualiRuleServiceTestLine
commenting thse out for now, need to analyze and see if it still makes sense with new notes"copied from document " + // sourceDocumentHeaderId);391
org.kuali.rice.krad.service.impl.BusinessObjectDictionaryServiceImplLine
stupid, change to return int325
org.kuali.rice.krad.service.impl.BusinessObjectSerializerServiceImplLine
need to determine view properties to serialize63
org.kuali.rice.krad.service.impl.DictionaryValidationServiceImplLine
Implement custom validators807
Do we need to be able to handle simple collections (ie. String, etc)973
org.kuali.rice.krad.service.impl.DocumentHelperServiceImplLine
in krad documents could have multiple views and multiple authorizer classes48
in krad documents could have multiple views and multiple presentation controller108
org.kuali.rice.krad.service.impl.DocumentServiceImplLine
gah! this is awful875
org.kuali.rice.krad.service.impl.MaintenanceDocumentServiceImplLine
should we be using ObjectUtils? also, this needs dictionary enhancement to indicate fields to/not to copy128
rework for KRAD MaintenanceDocumentRestrictions maintenanceDocumentRestrictions = getBusinessObjectAuthorizationService().getMaintenanceDocumentRestrictions(document, user);302
make sure we are doing formatting here eventually364
org.kuali.rice.krad.service.impl.NoteServiceImplLine
this method seems awfully out of place in this service104
Why is a deep copy being done? Nowhere that this is called uses the given note argument again after calling this method.116
org.kuali.rice.krad.service.impl.PersistenceStructureServiceJpaImplLine
Write JPA Version108
Write JPA Version139
org.kuali.rice.krad.uif.component.ComponentLine
javadoc408
this should not be on component interface since it only applies if the layout manager supports it, need some sort of layoutOptions map for field level options that depend on the manager425
this should not be on component interface since it only applies if the layout manager supports it, need some sort of layoutOptions map for field level options that depend on the manager450
org.kuali.rice.krad.uif.component.ComponentBaseLine
does conditional render have the el placeholder? if so this will not work166
setting of the control names should probably be done in finalize, and we need KeepExpression on progressiveRender and conditionalRefresh173
org.kuali.rice.krad.uif.container.CollectionGroupLine
is this necessary to call again?206
org.kuali.rice.krad.uif.container.MaintenanceActiveCollectionFilterLine
if newly added line, show record If only new and no old add the newline76
org.kuali.rice.krad.uif.container.TreeGroupLine
set object path for prototypes equal to the tree group object path?79
hack */ ".rootElement", "root");145
org.kuali.rice.krad.uif.field.ActionFieldLine
possibly fix some other way - this is a workaround, prevents showing history and showing home again on actions which submit the form166
org.kuali.rice.krad.uif.field.DataFieldLine
should this check the view#readOnly?142
Check authorization if (attributeSecurity.isMask() && !boAuthzService.canFullyUnmaskField(user,dataObjectClass, field.getPropertyName(), null)) {194
format by type215
format by type243
org.kuali.rice.krad.uif.field.ErrorsFieldLine
this may be changed to: if this is set on a field it will attempt show client side validation errors in the closest parent container error container394
org.kuali.rice.krad.uif.field.LookupInputFieldLine
what about formatter?92
delyea: FieldUtils.createAndPopulateFieldsForLookup used to allow for a set of property names to be passed in via the URL parameters of the lookup url to set fields as 'read only'113
org.kuali.rice.krad.uif.layout.TableLayoutManagerLine
implement repeat header211
remove once we have modifier228
org.kuali.rice.krad.uif.modifier.CompareFieldCreateModifierLine
add script for value changed?233
org.kuali.rice.krad.uif.service.ViewServiceLine
remove once can get beans by type90
org.kuali.rice.krad.uif.service.impl.AttributeQueryServiceImplLine
need to apply formatter for field or have method in object property utils94
org.kuali.rice.krad.uif.service.impl.ExpressionEvaluatorServiceImplLine
possibly reflect ExpressionFunctions and add automatically131
org.kuali.rice.krad.uif.service.impl.ViewHelperServiceImplLine
this should handle groups as well, going through nested data fields214
should check default value216
need to handle updating client state for component refresh227
duplicate ID check298
initialize from dictionary325
should check to see if there is an add line method on the collection parent and if so call that instead of just adding to the collection (so that sequence can be set)1041
this should invoke rules, subclasses like the document view should create the document add line event1073
look into other ways of identifying a line so we can deal with unordered collections1096
this should invoke rules, sublclasses like the document view should create the document delete line event1125
need to put this in data object service so logic can be reused1170
duplicate identifier check1195
this should go through our formatters1271
org.kuali.rice.krad.uif.service.impl.ViewServiceImplLine
remove once we can get beans by type from spring49
org.kuali.rice.krad.uif.util.ClientValidationUtilsLine
make this show the fields its requiring595
org.kuali.rice.krad.uif.util.ComponentFactoryLine
how to deal with remotable field regexContraintMsg?358
org.kuali.rice.krad.uif.util.ExpressionUtilsLine
In progress, adjusting paths in expressions if (defaultPathSet) { String adjustedExpression = "";80
org.kuali.rice.krad.uif.util.ScriptUtilsLine
should this go through property editors?99
org.kuali.rice.krad.uif.util.UifBeanFactoryPostProcessorLine
this only handles one level of nesting171
this is not handled correctly474
org.kuali.rice.krad.uif.view.HistoryLine
Possibly move so it can be used for the actual view title, not just history388
org.kuali.rice.krad.uif.view.HistoryEntryLine
a variety of these settings are not used in the current implementation of breadcrumbs and history, they may be removed later if they prove unuseful in future changes25
unsure of use138
org.kuali.rice.krad.uif.view.LookupViewLine
need to check lookupForm.isAtLeastOneRowHasActions() somewhere139
work into view lifecycle LookupViewHelperService lookupViewHelperService = (LookupViewHelperService) getViewHelperService(); Set<String> readOnlyFields = lookupViewHelperService.getConditionallyReadOnlyPropertyNames(); Set<String> requiredFields = lookupViewHelperService.getConditionallyRequiredPropertyNames(); Set<String> hiddenFields = lookupViewHelperService.getConditionallyHiddenPropertyNames(); if ( (readOnlyFields != null && !readOnlyFields.isEmpty()) || (requiredFields != null && !requiredFields.isEmpty()) || (hiddenFields != null && !hiddenFields.isEmpty()) ) { for (Field field : getResultsGroup().getItems()) { if (InputField.class.isAssignableFrom(field.getClass())) { InputField attributeField = (InputField) field; if (readOnlyFields != null && readOnlyFields.contains(attributeField.getBindingInfo().getBindingName())) { attributeField.setReadOnly(true); } if (requiredFields != null && requiredFields.contains(attributeField.getBindingInfo().getBindingName())) { attributeField.setRequired(Boolean.TRUE); } if (hiddenFields != null && hiddenFields.contains(attributeField.getBindingInfo().getBindingName())) { attributeField.setControl(LookupInquiryUtils.generateCustomLookupControlFromExisting(HiddenControl.class, null)); } } } }170
org.kuali.rice.krad.uif.view.ViewLine
move to VHS initialize if (initializedComponentIds.contains(component.getId())) { throw new RiceRuntimeException( "Circular reference or duplicate id found for component with id: " + component.getId()); } initializedComponentIds.add(component.getId());254
fix this generic issue945
org.kuali.rice.krad.uif.widget.InquiryLine
need general format util that uses spring174
this should set base inquiry URL from module service as well, but right now set for KNS212
org.kuali.rice.krad.uif.widget.QuickFinderLine
--No comment--194
displayedFieldnames in org.kuali.rice.kns.lookup.LookupUtils.generateFieldConversions(BusinessObject, String, DataObjectRelationship, String, List, String)226
displayedFieldnames and displayedQFFieldNames in generateLookupParameters(BusinessObject, String, DataObjectRelationship, String, List, String)240
org.kuali.rice.krad.uif.widget.RichTableLine
does this handle multiple rows correctly?148
org.kuali.rice.krad.util.KRADConstantsLine
new krad constants, previous needs to be cleaned up591
org.kuali.rice.krad.util.KRADUtilsLine
this method will probably need to be exposed in a public KRADUtils class as it is used by several different modules. That will have to wait until ModuleService and KualiModuleService are moved to core though.154
need to apply formatting to return value once util class is ready435
org.kuali.rice.krad.util.ObjectUtilsLine
The rules about this dot notation needs to be explained in Confluence using examples.229
genericize collectionContainsObjectWithIdentitcalKey() to leverage this method?714
org.kuali.rice.krad.web.bind.UifConfigurableWebBindingInitializerLine
do we need this since we are switching to spring tags53
org.kuali.rice.krad.web.bind.UifViewBeanWrapperLine
clear cache?188
clear cache?195
org.kuali.rice.krad.web.controller.DocumentControllerBaseLine
authorization on document actions if (KEWConstants.SUPERUSER_COMMAND.equalsIgnoreCase(command)) { form.setSuppressAllButtons(true); }140
prompt user to confirm the cancel, need question framework238
need to prompt for disapproval note text310
need question and prompt framework357
need to get disapprove note from user387
need to move containsSensitiveDataPatternMatch to util class in krad649
not ready for question framework yet673
figure out what to return689
org.kuali.rice.krad.web.controller.MaintenanceDocumentControllerLine
getting double view if we call base, not sure how to handle so pasting in superclass code super.docHandler(formBase, request, response); * begin copy/paste from the base71
set state in view form.setReadOnly(true);92
should be in the view as permission212
org.kuali.rice.krad.web.controller.ModuleLockingHandlerInterceptorLine
jawbenne don't forget to fill this in.39
org.kuali.rice.krad.web.controller.UifControllerBaseLine
should use property editors once we have util class262
this needs setup for lightbox and possible home location property302
this code still needs to handle reference refreshes388
lookup anchors and doc number?478
should call module service to get full URL, but right now it is coded to direct to the KNS lookups Map<String, String> parameterMap = new HashMap<String, String>(); Enumeration<Object> e = lookupParameters.keys(); while (e.hasMoreElements()) { String paramName = (String) e.nextElement(); parameterMap.put(paramName, lookupParameters.getProperty(paramName)); }509
org.kuali.rice.krad.web.controller.UifControllerHandlerInterceptorLine
do we need to clear the messages before this so that formatting and validation errors done during the binding are not cleared out?69
org.kuali.rice.krad.web.form.LookupFormLine
replace with check to history97
org.kuali.rice.krad.web.form.UifFormBaseLine
make sure action parameters are getting reinitialized on each request348
org.kuali.rice.krad.web.session.NonSerializableSessionListenerLine
May want to have a way to turn this off that way we aren't incurring the overhead of testing every session object if it is serializable by actually serializing it!30
org.kuali.rice.krad.workflow.DataDictionarySearchableAttributeTestLine
Add the commented-out boolean search expressions back in once KULRICE-3698 is complete.179
org.kuali.rice.krad.workflow.attribute.DataDictionarySearchableAttributeLine
this is a workaround to hide the Field from the search criteria. This should be removed once hiding the entire Row is working282
org.kuali.rice.krad.workflow.attribute.KualiXmlAttributeHelperLine
- enter JIRA below removes wf:xstreamsafe( and ) below separates each wf:xstreamsafe() section into separate 'finds'55
- Fix the document content element generation141
org.kuali.rice.krad.workflow.service.impl.WorkflowDocumentServiceImplLine
do we really need to do this or just let the IllegalArgument propogate?120
make the 1 a constant322
org.kuali.rice.krms.api.engine.EngineResultsLine
- need to determine what goes here...22
org.kuali.rice.krms.api.engine.ExecutionEnvironmentLine
we don't support updating facts, refactor this method52
org.kuali.rice.krms.api.engine.TermLine
make this pretty110
org.kuali.rice.krms.api.repository.agenda.AgendaTreeEntryDefinitionLine
...21
org.kuali.rice.krms.api.repository.context.ContextDefinitionContractLine
this java doc is confusing67
org.kuali.rice.krms.api.repository.proposition.PropositionDefinitionLine
change this to field name to id76
org.kuali.rice.krms.api.repository.proposition.PropositionParameterLine
isBlank or is null ???195
check against valid values209
org.kuali.rice.krms.api.repository.proposition.PropositionParameterTypeLine
...24
org.kuali.rice.krms.api.repository.proposition.PropositionTypeLine
...25
org.kuali.rice.krms.api.repository.term.TermResolverDefinitionLine
proper validation & javadocs176
*/);183
*/);193
*/);203
*/);213
*/);223
org.kuali.rice.krms.api.test.JAXBAssertLine
- copied this from the core api test module, find a better way to share this code!33
org.kuali.rice.krms.framework.TermResolutionEngineTestLine
test exception variants: - TermResolver throws TermResolutionException - TermResolutionEngine is passed a null termName307
what should the TermResolutionEngine do if a resolver throws a RuntimeException?312
org.kuali.rice.krms.framework.engine.AgendaTreeEntryLine
...21
org.kuali.rice.krms.framework.engine.CollectionOfComparablesTermBasedPropositionLine
log this appropriately57
org.kuali.rice.krms.framework.engine.EngineResultsImplLine
Auto-generated method stub44
Auto-generated method stub50
org.kuali.rice.krms.framework.engine.StringTermBasedPropositionLine
remove? ComparableTermBasedProposition does this generically20
org.kuali.rice.krms.framework.engine.TermResolutionEngineImplLine
could cache these plans somewhere, since future agendas will likely require the same plans78
org.kuali.rice.krms.framework.engine.expression.BinaryOperatorExpressionLine
...21
org.kuali.rice.krms.framework.engine.expression.BooleanValidatingExpressionLine
...22
org.kuali.rice.krms.framework.engine.expression.ComparisonOperatorLine
this implementation seems largely incomplete, it seems we are need to have some kind of engine or utility which can coerce types to possible forms for comparision purposes? For now, let's verify they are of the same type55
not sure what to do about this cast and whether or not it will safe, be sure to hit this in unit testing!73
org.kuali.rice.krms.framework.engine.expression.ConstantExpressionLine
...21
org.kuali.rice.krms.framework.engine.expression.ExpressionLine
...21
org.kuali.rice.krms.framework.engine.expression.ExpressionBasedPropositionLine
...26
org.kuali.rice.krms.framework.engine.expression.FunctionExpressionLine
...25
org.kuali.rice.krms.framework.engine.expression.TermExpressionLine
...23
org.kuali.rice.krms.framework.engine.result.Log4jResultListenerLine
Auto-generated method stub27
org.kuali.rice.krms.framework.type.ValidationActionServiceLine
...49
org.kuali.rice.krms.impl.peopleflow.PeopleFlowActionTypeServiceLine
where should this constant really go?62
include the ATTRIBUTE_FIELD_NAME in an error message like "The " + ATTRIBUTE_FIELD_NAME + " must be a valid ID for an existing PeopleFlow". Currently the RemotableAttributeError doesn't support arguments in the error messages.244
include the ATTRIBUTE_FIELD_NAME in an error message like ATTRIBUTE_FIELD_NAME + " is required". Currently the RemotableAttributeError doesn't support arguments in the error messages.250
org.kuali.rice.krms.impl.peopleflow.PeopleFlowActionTypeServiceTestLine
test ActionDefinition w/o the attribute we need110
org.kuali.rice.krms.impl.provider.repository.LazyActionLine
...25
org.kuali.rice.krms.impl.provider.repository.LazyAgendaTreeLine
...23
org.kuali.rice.krms.impl.provider.repository.LazyPropositionLine
...29
org.kuali.rice.krms.impl.provider.repository.LazyRuleLine
...25
org.kuali.rice.krms.impl.provider.repository.RepositoryToEngineTranslatorImplLine
...55
log warning when termResolver comes back null? or throw exception?107
this limits an agenda to a single event. Is that good enough?114
org.kuali.rice.krms.impl.provider.repository.RuleRepositoryContextProviderLine
should have an execution option that throws an error here if a context does not exist?44
org.kuali.rice.krms.impl.provider.repository.SimplePropositionTypeServiceLine
- need some way to define data type on the prop parameter as well? Not all constants will actually be String values!!!87
throw an exception if function is null?97
need to check types here? expression object probably needs a getType on it so that we can confirm that the types will be compatible?107
org.kuali.rice.krms.impl.repository.ActionTypeValuesFinderLine
Only select the actions for the specific context of the agenda Map<String, String> fieldValues = new HashMap<String, String>(); fieldValues.put(KrmsImplConstants.PropertyNames.Context.CONTEXT_ID, form.getAgenda().getContextId); Collection<ContextValidActionBo> contextValidActions = KRADServiceLocator.getBusinessObjectService().findMatching(ContextValidActionBo.class, fieldValues);46
org.kuali.rice.krms.impl.repository.AgendaBoServiceImplLine
deal with active flag39
org.kuali.rice.krms.impl.repository.AgendaNamespaceValuesFinderLine
this is not efficient -- do a smart 'select distinct' and make sure we have a good index!47
org.kuali.rice.krms.impl.repository.ContextTypeValuesFinderLine
Currently we hardcoded any types named "CONTEXT" to be valid with contexts.66
org.kuali.rice.krms.impl.repository.RuleRepositoryServiceImplLine
prevent circular, endless looping147
validate that only either rule or subagenda, not both156
inject this instead241
org.kuali.rice.krms.impl.repository.RuleTypeValuesFinderLine
Only select the rules for the specific context of the agenda Map<String, String> fieldValues = new HashMap<String, String>(); fieldValues.put(KrmsImplConstants.PropertyNames.Context.CONTEXT_ID, form.getAgenda().getContextId); Collection<ContextValidRuleBo> contextValidRules = KRADServiceLocator.getBusinessObjectService().findMatching(ContextValidRuleBo.class, fieldValues);42
org.kuali.rice.krms.impl.repository.TermBoServiceLine
javadocs32
org.kuali.rice.krms.impl.rule.AgendaEditorBusRuleLine
when/if we have standard support for DO retrieval, do this check for DO's89
Good suggestion from Aaron, dont bother checking the DB, if all of the objects PK fields dont have values. If any are null or empty, then we're done. The current way wont fail, but it will make a wasteful DB call that may not be necessary, and we want to minimize these.95
org.kuali.rice.krms.impl.ui.AgendaEditorLine
Determine proper default values of agenda's typeId58
org.kuali.rice.krms.impl.ui.AgendaEditorControllerLine
Add a copy not the reference132
this is confusing, refactor987
how to add compound proposition. - just add another to the firs simple1352
do we allow moving up to the root? we could add a new top level compound node, with current root as 1st child, and move the node to the second child.1550
determine edit mode. boolean editMode = (SimplePropositionEditNode.NODE_TYPE.equalsIgnoreCase(child.getNodeType()));1668
handle edit mode1696
org.kuali.rice.krms.impl.ui.AgendaEditorMaintainableLine
change this, it makes more sense for MAINTENANCE_EDIT_ACTION String agendaId = agendaIds[0];263
org.kuali.rice.krms.impl.ui.SimplePropositionEditNodeLine
enhance to get term names for term type parameters.49
use termBoService63
org.kuali.rice.krms.impl.ui.SimplePropositionNodeLine
enhance to get term names for term type parameters.48
use termBoService62
org.kuali.rice.krms.impl.ui.ValidTermsValuesFinderLine
get the list of valid terms for this context. (currently gets all)43
org.kuali.rice.ksb.config.xfire.XFireWSS4JInHandlerLine
Replace this class with cxf wss4j in interceptor30
org.kuali.rice.ksb.config.xfire.XFireWSS4JOutHandlerLine
Replace this class with a cxf wss4j out interceptor29
org.kuali.rice.ksb.impl.bus.ServiceBusImplLine
- would be better to return an Endpoint that contained an internal proxy to all the services so fail-over would be easier to implement!261
- this should also probably check the current status of the service?265
org.kuali.rice.ksb.impl.registry.LazyRemoteServiceRegistryConnectorLine
...41
org.kuali.rice.ksb.impl.registry.diff.LocalServicesDiffLine
...26
org.kuali.rice.ksb.impl.registry.diff.RemoteServicesDiffLine
...25
org.kuali.rice.ksb.impl.registry.diff.ServiceRegistryDiffCalculatorLine
...25
org.kuali.rice.ksb.messaging.DelayedAsynchronousServiceTestLine
this isn't the best test ever because it's relying on waits and timing which is most likely doomed to occasional failure in the CI environment. If this occurs than I may need to yank this. A better long term solution would be to allow for the use of callbacks for delayed asynchronous services but that's not something I wanted to try to tackle at the moment74
org.kuali.rice.ksb.messaging.JmsMessagingNoRunLine
renable this test25
org.kuali.rice.ksb.messaging.config.KSBConfigurerLine
redo this once we're back to JPA springFileLocations.add("classpath:org/kuali/rice/ksb/config/KSBJPASpringBeans.xml");116
hack 'cause KSB used KNS - this needs to be fixed!!!134
org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnectorLine
we need to add support for other invocation protocols and implementations, but for now...102
org.kuali.rice.ksb.messaging.serviceconnectors.ServiceConnectorFactoryLine
switch this to use serviceConfiguration.getType() at some point in the future and allow for this to be easily "pluggable" with new connector types85
org.kuali.rice.ksb.messaging.servlet.KSBDispatcherServletLine
this just seems weird as this controller is initially null when it's created, does there need to be some synchronization here?105
org.kuali.rice.ksb.messaging.web.MessageQueueActionLine
better error handling here392
org.kuali.rice.ksb.messaging.web.ServiceRegistryActionLine
is this what really constitutes a "refresh" of the service registry?61
org.kuali.rice.ksb.security.soap.CXFWSS4JInInterceptorLine
Replace this class with cxf wss4j in interceptor40
org.kuali.rice.ksb.testclient1.JaxWsEchoServiceImplLine
Will Gomes - THIS METHOD NEEDS JAVADOCS52
org.kuali.rice.test.data.UnitTestDataLine
Come back and add the JPQL equivalents42
org.kuali.rice.test.lifecycles.SQLDataLoaderLifecycleLine
may way to do something with the dataLoader58
org.rice.krms.test.RepositoryCreateAndExecuteIntegrationTestLine
custom functions too.160
do this fur eel202
org.rice.krms.test.ValidationIntegrationTestLine
do this fur eel257