FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
1143400

Files

ClassBugs
org.kuali.rice.kim.impl.group.GroupInternalServiceImpl$MembersDiff1
org.kuali.rice.kim.impl.group.GroupServiceBase1
org.kuali.rice.kim.impl.group.GroupServiceImpl1
org.kuali.rice.kim.impl.identity.EntityTypeBo1
org.kuali.rice.kim.impl.identity.PersonImpl2
org.kuali.rice.kim.impl.identity.PersonServiceImpl5
org.kuali.rice.kim.impl.identity.address.EntityAddressTypeBo1
org.kuali.rice.kim.impl.identity.affiliation.EntityAffiliationTypeBo1
org.kuali.rice.kim.impl.identity.citizenship.EntityCitizenshipStatusBo1
org.kuali.rice.kim.impl.identity.email.EntityEmailTypeBo1
org.kuali.rice.kim.impl.identity.employment.EntityEmploymentStatusBo1
org.kuali.rice.kim.impl.identity.employment.EntityEmploymentTypeBo1
org.kuali.rice.kim.impl.identity.entity.EntityBo1
org.kuali.rice.kim.impl.identity.external.EntityExternalIdentifierTypeBo1
org.kuali.rice.kim.impl.identity.name.EntityNameBo1
org.kuali.rice.kim.impl.identity.name.EntityNameTypeBo1
org.kuali.rice.kim.impl.identity.personal.EntityBioDemographicsBo4
org.kuali.rice.kim.impl.identity.phone.EntityPhoneTypeBo1
org.kuali.rice.kim.impl.identity.type.EntityTypeContactInfoId1
org.kuali.rice.kim.impl.identity.visa.EntityVisaBo1
org.kuali.rice.kim.impl.permission.PermissionBo2
org.kuali.rice.kim.impl.responsibility.ResponsibilityBo2
org.kuali.rice.kim.impl.type.KimTypeAttributeBo1
org.kuali.rice.kim.impl.type.KimTypeBo1

org.kuali.rice.kim.impl.group.GroupInternalServiceImpl$MembersDiff

BugCategoryDetailsLinePriority
Should org.kuali.rice.kim.impl.group.GroupInternalServiceImpl$MembersDiff be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC112Medium

org.kuali.rice.kim.impl.group.GroupServiceBase

BugCategoryDetailsLinePriority
Unused field: org.kuali.rice.kim.impl.group.GroupServiceBase.criteriaLookupServicePERFORMANCEUUF_UNUSED_FIELDMedium

org.kuali.rice.kim.impl.group.GroupServiceImpl

BugCategoryDetailsLinePriority
Field GroupServiceImpl.businessObjectService masks field in superclass org.kuali.rice.kim.impl.group.GroupServiceBaseCORRECTNESSMF_CLASS_MASKS_FIELD55Medium

org.kuali.rice.kim.impl.identity.EntityTypeBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.EntityTypeBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID47Medium

org.kuali.rice.kim.impl.identity.PersonImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.PersonImpl.identityService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kim.impl.identity.PersonImpl.personService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium

org.kuali.rice.kim.impl.identity.PersonServiceImpl

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kim.impl.identity.PersonServiceImpl.convertEntityToPerson(EntityDefault, Principal), since all RuntimeException are instances of RuntimeExceptionSTYLEBC_VACUOUS_INSTANCEOF173Medium
Method org.kuali.rice.kim.impl.identity.PersonServiceImpl.findPeople(Map, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR281Medium
Method org.kuali.rice.kim.impl.identity.PersonServiceImpl.convertPersonPropertiesToEntityProperties(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR381Medium
Method org.kuali.rice.kim.impl.identity.PersonServiceImpl.getNonPersonSearchCriteria(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR592Medium
Method org.kuali.rice.kim.impl.identity.PersonServiceImpl.resolvePrincipalNamesToPrincipalIds(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR657Medium

org.kuali.rice.kim.impl.identity.address.EntityAddressTypeBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.address.EntityAddressTypeBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID50Medium

org.kuali.rice.kim.impl.identity.affiliation.EntityAffiliationTypeBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.affiliation.EntityAffiliationTypeBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID53Medium

org.kuali.rice.kim.impl.identity.citizenship.EntityCitizenshipStatusBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.citizenship.EntityCitizenshipStatusBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID47Medium

org.kuali.rice.kim.impl.identity.email.EntityEmailTypeBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.email.EntityEmailTypeBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID47Medium

org.kuali.rice.kim.impl.identity.employment.EntityEmploymentStatusBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.employment.EntityEmploymentStatusBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID47Medium

org.kuali.rice.kim.impl.identity.employment.EntityEmploymentTypeBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.employment.EntityEmploymentTypeBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID47Medium

org.kuali.rice.kim.impl.identity.entity.EntityBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.entity.EntityBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID69Medium

org.kuali.rice.kim.impl.identity.external.EntityExternalIdentifierTypeBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.external.EntityExternalIdentifierTypeBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID53Medium

org.kuali.rice.kim.impl.identity.name.EntityNameBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.name.EntityNameBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID93Medium

org.kuali.rice.kim.impl.identity.name.EntityNameTypeBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.name.EntityNameTypeBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID47Medium

org.kuali.rice.kim.impl.identity.personal.EntityBioDemographicsBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.personal.EntityBioDemographicsBo.getBirthDateValue() may expose internal representation by returning EntityBioDemographicsBo.birthDateValueMALICIOUS_CODEEI_EXPOSE_REPMedium
org.kuali.rice.kim.impl.identity.personal.EntityBioDemographicsBo.getDeceasedDateValue() may expose internal representation by returning EntityBioDemographicsBo.deceasedDateValueMALICIOUS_CODEEI_EXPOSE_REPMedium
org.kuali.rice.kim.impl.identity.personal.EntityBioDemographicsBo.setBirthDateValue(Date) may expose internal representation by storing an externally mutable object into EntityBioDemographicsBo.birthDateValueMALICIOUS_CODEEI_EXPOSE_REP2Medium
org.kuali.rice.kim.impl.identity.personal.EntityBioDemographicsBo.setDeceasedDateValue(Date) may expose internal representation by storing an externally mutable object into EntityBioDemographicsBo.deceasedDateValueMALICIOUS_CODEEI_EXPOSE_REP2Medium

org.kuali.rice.kim.impl.identity.phone.EntityPhoneTypeBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.phone.EntityPhoneTypeBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID47Medium

org.kuali.rice.kim.impl.identity.type.EntityTypeContactInfoId

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.type.EntityTypeContactInfoId.equals(Object) is unusualSTYLEEQ_UNUSUAL50Medium

org.kuali.rice.kim.impl.identity.visa.EntityVisaBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.identity.visa.EntityVisaBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID59Medium

org.kuali.rice.kim.impl.permission.PermissionBo

BugCategoryDetailsLinePriority
Class org.kuali.rice.kim.impl.permission.PermissionBo defines non-transient non-serializable instance field dataDictionaryServiceBAD_PRACTICESE_BAD_FIELDMedium
Class org.kuali.rice.kim.impl.permission.PermissionBo defines non-transient non-serializable instance field kimTypeInfoServiceBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kim.impl.responsibility.ResponsibilityBo

BugCategoryDetailsLinePriority
Class org.kuali.rice.kim.impl.responsibility.ResponsibilityBo defines non-transient non-serializable instance field dataDictionaryServiceBAD_PRACTICESE_BAD_FIELDMedium
Class org.kuali.rice.kim.impl.responsibility.ResponsibilityBo defines non-transient non-serializable instance field kimTypeInfoServiceBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kim.impl.type.KimTypeAttributeBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.type.KimTypeAttributeBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID37High

org.kuali.rice.kim.impl.type.KimTypeBo

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.type.KimTypeBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID36Medium