The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unread field: org.kuali.rice.krms.impl.provider.repository.RepositoryToEngineTranslatorImpl.typeRepositoryService | PERFORMANCE | URF_UNREAD_FIELD | 298 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.kuali.rice.krms.impl.provider.repository.RuleRepositoryContextProvider.constructContextSelectionCriteria(SelectionCriteria) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 76 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.ActionAttributeBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.ActionBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 38 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.AgendaAttributeBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.AgendaBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 39 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to context in org.kuali.rice.krms.impl.repository.AgendaBoServiceImpl.buildAgendaAttributeBo(AgendaDefinition) | STYLE | DLS_DEAD_LOCAL_STORE | 347 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.AgendaItemBoFoo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 41 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.kuali.rice.krms.impl.repository.AgendaLookupableHelperServiceImpl.getActionUrlHref(LookupForm, Object, String, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 72 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.BaseAttributeBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 41 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.CategoryBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 34 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.ContextAttributeBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.ContextBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.ContextValidActionBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.ContextValidAgendaBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.ContextValidEventBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.ContextValidRuleBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.ContextValidTermBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.FunctionBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 42 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.FunctionParameterBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 38 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.KrmsAttributeDefinitionBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 39 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.KrmsTypeAttributeBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 37 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.KrmsTypeBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.PropositionBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 53 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.PropositionParameterBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 37 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.RuleAttributeBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.RuleBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 58 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to pList in org.kuali.rice.krms.impl.repository.RuleRepositoryServiceImpl.getRules(List) | STYLE | DLS_DEAD_LOCAL_STORE | 125 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.TermBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.TermParameterBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 35 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.TermResolverAttributeBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.TermResolverBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 40 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.kuali.rice.krms.impl.repository.TermResolverParameterSpecificationBo is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 38 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in org.kuali.rice.krms.impl.rule.AgendaEditorBusRule.primaryKeyCheck(MaintenanceDocument), since all org.kuali.rice.krms.impl.repository.AgendaBo are instances of org.kuali.rice.krad.bo.PersistableBusinessObject | STYLE | BC_VACUOUS_INSTANCEOF | 90 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to typeAttributeFields in org.kuali.rice.krms.impl.type.KrmsTypeServiceBase.getAttributeFields(String) | STYLE | DLS_DEAD_LOCAL_STORE | 87 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.MaintenanceForm in org.kuali.rice.krms.impl.ui.AgendaEditorController.addRule(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 231 | Medium |
Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.MaintenanceForm in org.kuali.rice.krms.impl.ui.AgendaEditorController.editRule(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 345 | Medium |
Unchecked/unconfirmed cast from org.kuali.rice.krad.web.form.UifFormBase to org.kuali.rice.krad.web.form.MaintenanceForm in org.kuali.rice.krms.impl.ui.AgendaEditorController.refresh(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 79 | Medium |
Dead store to firstItem in org.kuali.rice.krms.impl.ui.AgendaEditorController.ajaxCut(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 1013 | Medium |
Dead store to child in org.kuali.rice.krms.impl.ui.AgendaEditorController.movePropositionRight(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 1582 | Medium |
Comparison of String objects using == or != in org.kuali.rice.krms.impl.ui.AgendaEditorController.pasteProposition(UifFormBase, BindingResult, HttpServletRequest, HttpServletResponse) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 1622 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Load of known null value in org.kuali.rice.krms.impl.ui.AgendaEditorMaintainable.saveDataObject() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 326 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to sortCodeMap in org.kuali.rice.krms.impl.validation.RadioButtonTypeServiceUtil.getAttributeFields(String) | STYLE | DLS_DEAD_LOCAL_STORE | 51 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.kuali.rice.krms.impl.validation.RadioButtonTypeServiceUtil$LabelSequenceComparator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 113 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unread field: org.kuali.rice.krms.impl.validation.ValidationActionTypeServiceImpl.validationService | PERFORMANCE | URF_UNREAD_FIELD | 83 | Medium |