FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
142639001

Files

ClassBugs
org.apache.commons.httpclient.contrib.ssl.EasySSLProtocolSocketFactory1
org.kuali.rice.ken.bo.NotificationChannel3
org.kuali.rice.ken.dao.impl.NotificationMessegeDeliveryDaoJpa1
org.kuali.rice.ken.service.impl.KENAPIServiceImpl1
org.kuali.rice.ken.service.impl.NotificationChannelServiceImpl2
org.kuali.rice.ken.service.impl.NotificationContentTypeServiceImpl2
org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl2
org.kuali.rice.ken.service.impl.NotificationMessageDeliveryAutoRemovalServiceImpl1
org.kuali.rice.ken.service.impl.NotificationMessageDeliveryResolverServiceImpl2
org.kuali.rice.ken.service.impl.NotificationRecipientServiceKimImpl2
org.kuali.rice.ken.util.Util6
org.kuali.rice.ken.web.spring.AdministerNotificationRequestController2
org.kuali.rice.ken.web.spring.ContentTypeController5
org.kuali.rice.ken.web.spring.SendEventNotificationMessageController2
org.kuali.rice.ken.web.spring.SendNotificationMessageController2
org.kuali.rice.ken.web.spring.UserPreferencesController4
org.kuali.rice.kew.actionitem.ActionItemComparator1
org.kuali.rice.kew.actionlist.ActionListFilter8
org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImpl1
org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOOjbImpl1
org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl4
org.kuali.rice.kew.actionlist.web.ActionListAction1
org.kuali.rice.kew.actionlist.web.ActionListAction$ActionItemComparator1
org.kuali.rice.kew.actionlist.web.ActionListForm2
org.kuali.rice.kew.actionrequest.ActionRequestFactory3
org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl3
org.kuali.rice.kew.actions.DisapproveAction1
org.kuali.rice.kew.actions.LogDocumentActionAction1
org.kuali.rice.kew.actions.SuperUserActionTakenEvent1
org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOJpaImpl1
org.kuali.rice.kew.attribute.XMLAttributeUtils4
org.kuali.rice.kew.config.ThinClientResourceLoader2
org.kuali.rice.kew.docsearch.DocumentSearchCustomizationMediatorImpl3
org.kuali.rice.kew.docsearch.SearchableAttributeDateTimeValue1
org.kuali.rice.kew.docsearch.SearchableAttributeFloatValue1
org.kuali.rice.kew.docsearch.SearchableAttributeLongValue1
org.kuali.rice.kew.docsearch.SearchableAttributeStringValue1
org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl3
org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute3
org.kuali.rice.kew.doctype.DocumentTypeAttribute1
org.kuali.rice.kew.doctype.DocumentTypePolicy2
org.kuali.rice.kew.doctype.DocumentTypeSecurity1
org.kuali.rice.kew.doctype.bo.DocumentType1
org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOJpaImpl1
org.kuali.rice.kew.doctype.service.impl.DocumentSecurityServiceImpl3
org.kuali.rice.kew.doctype.service.impl.DocumentTypeServiceImpl1
org.kuali.rice.kew.documentoperation.web.DocumentOperationAction2
org.kuali.rice.kew.documentoperation.web.DocumentOperationForm6
org.kuali.rice.kew.dto.DTOConverter1
org.kuali.rice.kew.engine.BlanketApproveEngine$ProcessEntry1
org.kuali.rice.kew.engine.CompatUtils4
org.kuali.rice.kew.engine.OrchestrationConfig1
org.kuali.rice.kew.engine.StandardWorkflowEngine2
org.kuali.rice.kew.engine.node.FYIByNetworkId1
org.kuali.rice.kew.engine.node.KRAMetaRuleNode$FinalApproverContext1
org.kuali.rice.kew.engine.node.NodeJotter2
org.kuali.rice.kew.engine.node.NodeType$ExtensionDepthComparator1
org.kuali.rice.kew.engine.node.ProcessDefinitionBo1
org.kuali.rice.kew.engine.node.RequestActivationNode1
org.kuali.rice.kew.engine.node.RequestsNode$FinalApproverContext1
org.kuali.rice.kew.engine.node.RoleNode$RoleRequestSorter1
org.kuali.rice.kew.engine.node.RouteNodeUtils1
org.kuali.rice.kew.engine.node.RouteNodeUtils$RouteNodeSorter1
org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode3
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl1
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$NodeInstanceIdSorter1
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$RouteNodeSorter1
org.kuali.rice.kew.engine.simulation.SimulationEngine2
org.kuali.rice.kew.impl.action.WorkflowDocumentActionsServiceImpl2
org.kuali.rice.kew.impl.document.search.DocumentSearchCriteriaBo1
org.kuali.rice.kew.impl.document.search.DocumentSearchCriteriaBoLookupableHelperService2
org.kuali.rice.kew.impl.document.search.DocumentSearchGeneratorImpl2
org.kuali.rice.kew.impl.peopleflow.PeopleFlowRouteModule1
org.kuali.rice.kew.impl.peopleflow.PeopleFlowRouteModule$PeopleFlowConfig3
org.kuali.rice.kew.impl.repository.KewTypeBoServiceImpl1
org.kuali.rice.kew.impl.rule.RuleServiceImpl1
org.kuali.rice.kew.impl.rule.attribute.WorkflowRuleAttributeHandlerServiceImpl2
org.kuali.rice.kew.mail.service.impl.ActionListEmailServiceImpl2
org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl2
org.kuali.rice.kew.notes.Note1
org.kuali.rice.kew.notes.web.AttachmentServlet1
org.kuali.rice.kew.notes.web.NoteAction7
org.kuali.rice.kew.plugin.PluginConfig1
org.kuali.rice.kew.plugin.PluginEnvironment1
org.kuali.rice.kew.plugin.PluginNameComparator1
org.kuali.rice.kew.plugin.ServerPluginRegistry1
org.kuali.rice.kew.plugin.ZipFilePluginLoader1
org.kuali.rice.kew.preferences.service.impl.PreferencesServiceImpl$UserOptionsWrapper1
org.kuali.rice.kew.quicklinks.ActionListStats1
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOJpaImpl1
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$11
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$21
org.kuali.rice.kew.resourceloader.CoreResourceLoader1
org.kuali.rice.kew.role.XPathQualifierResolver$ResolverConfig1
org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue5
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImpl1
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl5
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl$11
org.kuali.rice.kew.routeheader.service.impl.WorkflowDocumentServiceImpl1
org.kuali.rice.kew.routelog.web.RouteLogAction1
org.kuali.rice.kew.rule.FlexRM2
org.kuali.rice.kew.rule.GroupRuleResponsibility1
org.kuali.rice.kew.rule.KRAMetaRuleEngine1
org.kuali.rice.kew.rule.PersonRuleResponsibility1
org.kuali.rice.kew.rule.RuleBaseValues3
org.kuali.rice.kew.rule.RuleExpressionDef1
org.kuali.rice.kew.rule.RuleExtensionBo1
org.kuali.rice.kew.rule.RuleExtensionValue1
org.kuali.rice.kew.rule.RuleRoutingAttribute1
org.kuali.rice.kew.rule.TemplateRuleSelector1
org.kuali.rice.kew.rule.bo.RuleTemplateAttributeBo1
org.kuali.rice.kew.rule.bo.RuleTemplateBo1
org.kuali.rice.kew.rule.dao.impl.RuleDAOJpaImpl1
org.kuali.rice.kew.rule.dao.impl.RuleDAOOjbImpl1
org.kuali.rice.kew.rule.service.impl.RuleServiceInternalImpl2
org.kuali.rice.kew.rule.service.impl.RuleServiceInternalImpl$RuleDelegationSorter2
org.kuali.rice.kew.rule.web.RoutingReportAction2
org.kuali.rice.kew.rule.web.RoutingReportAction$RouteReportRuleTemplateContainer1
org.kuali.rice.kew.rule.web.WebRuleResponsibility2
org.kuali.rice.kew.rule.web.WebRuleResponsibility$DelegationRulesProxy1
org.kuali.rice.kew.rule.web.WebRuleUtils1
org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute2
org.kuali.rice.kew.service.impl.KEWModuleService1
org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl15
org.kuali.rice.kew.stats.web.StatsForm5
org.kuali.rice.kew.superuser.web.SuperUserAction1
org.kuali.rice.kew.superuser.web.SuperUserForm2
org.kuali.rice.kew.useroptions.UserOptions1
org.kuali.rice.kew.useroptions.UserOptionsId1
org.kuali.rice.kew.util.Utilities$PrioritySorter1
org.kuali.rice.kew.util.Utilities$RouteLogActionRequestSorter1
org.kuali.rice.kew.web.FilterMapping1
org.kuali.rice.kew.web.UserLoginFilter1
org.kuali.rice.kew.xml.AbstractTransformationFilter$CurrentElement1
org.kuali.rice.kew.xml.DocumentTypeXmlParser2
org.kuali.rice.kew.xml.DocumentTypeXmlParser$DocTypeNode1
org.kuali.rice.kew.xml.DocumentTypeXmlParser$RoutePathContext1
org.kuali.rice.kew.xml.GroupXmlParser1
org.kuali.rice.kew.xml.RuleTemplateXmlParser3
org.kuali.rice.kew.xml.RuleXmlParser2
org.kuali.rice.kew.xml.UserXmlParser1
org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$DocumentTypeParentComparator2
org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$SplitJoinContext1
org.kuali.rice.kew.xml.export.GroupXmlExporter1
org.kuali.rice.kew.xml.export.RuleTemplateXmlExporter1
org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$SimpleNodeList1
org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$XPathSegment1
org.kuali.rice.kim.bo.ui.PersonDocumentRole2
org.kuali.rice.kim.document.GenericPermissionMaintainable1
org.kuali.rice.kim.document.IdentityManagementKimDocument1
org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule2
org.kuali.rice.kim.impl.responsibility.ResponsibilityInquirableImpl2
org.kuali.rice.kim.impl.responsibility.ResponsibilityLookupableHelperServiceImpl1
org.kuali.rice.kim.impl.type.KimTypeAttributesHelper3
org.kuali.rice.kim.impl.type.KimTypeQualifierResolver1
org.kuali.rice.kim.inquiry.PermissionInquirableImpl2
org.kuali.rice.kim.lookup.KimDocumentRoleMemberLookupableHelperServiceImpl2
org.kuali.rice.kim.lookup.PermissionLookupableHelperServiceImpl1
org.kuali.rice.kim.lookup.PersonLookupableHelperServiceImpl1
org.kuali.rice.kim.lookup.RoleLookupableHelperServiceImpl1
org.kuali.rice.kim.lookup.RoleMemberLookupableHelperServiceImpl1
org.kuali.rice.kim.rules.ui.PersonDocumentDelegationMemberRule1
org.kuali.rice.kim.service.impl.KimModuleService2
org.kuali.rice.kim.service.impl.UiDocumentServiceImpl4
org.kuali.rice.kim.service.impl.UiDocumentServiceImpl$GroupMemberNameComparator1
org.kuali.rice.kim.web.struts.action.IdentityManagementPersonDocumentAction1
org.kuali.rice.kim.web.struts.action.IdentityManagementRoleDocumentAction1
org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl3
org.kuali.rice.kns.service.impl.BusinessObjectMetaDataServiceImpl1
org.kuali.rice.kns.service.impl.BusinessObjectSerializerServiceImpl1
org.kuali.rice.kns.service.impl.DataDictionaryServiceImpl1
org.kuali.rice.kns.service.impl.DictionaryValidationServiceImpl1
org.kuali.rice.kns.service.impl.MaintenanceDocumentDictionaryServiceImpl2
org.kuali.rice.kns.web.struts.action.KualiActionServlet1
org.kuali.rice.kns.web.struts.action.KualiActionServlet$KualiActionServletConfig1
org.kuali.rice.krad.dao.impl.BusinessObjectDaoJpa1
org.kuali.rice.krad.dao.impl.LookupDaoJpa7
org.kuali.rice.krad.dao.impl.LookupDaoOjb6
org.kuali.rice.krad.dao.impl.NoteDaoOjb1
org.kuali.rice.krad.dao.impl.PersistenceDaoJpa1
org.kuali.rice.krad.dao.proxy.DocumentHeaderDaoProxy1
org.kuali.rice.krad.dao.proxy.MaintenanceDocumentDaoProxy1
org.kuali.rice.krad.dao.proxy.NoteDaoProxy1
org.kuali.rice.krad.dao.proxy.PersistedLookupMetadataDaoProxy1
org.kuali.rice.krad.dao.proxy.PersistenceDaoProxy1
org.kuali.rice.krad.document.authorization.MaintenanceDocumentAuthorizerBase1
org.kuali.rice.krad.service.impl.AttachmentServiceImpl4
org.kuali.rice.krad.service.impl.BusinessObjectSerializerServiceImpl1
org.kuali.rice.krad.service.impl.BusinessObjectServiceImpl1
org.kuali.rice.krad.service.impl.DataObjectMetaDataServiceImpl2
org.kuali.rice.krad.service.impl.DictionaryValidationServiceImpl1
org.kuali.rice.krad.service.impl.DocumentServiceImpl1
org.kuali.rice.krad.service.impl.InactivateableFromToServiceImpl1
org.kuali.rice.krad.service.impl.InactivationBlockingDisplayServiceImpl1
org.kuali.rice.krad.service.impl.KualiExceptionIncidentServiceImpl1
org.kuali.rice.krad.service.impl.MaintenanceDocumentServiceImpl1
org.kuali.rice.krad.service.impl.ModuleServiceBase3
org.kuali.rice.krad.service.impl.PersistenceStructureServiceJpaImpl3
org.kuali.rice.krad.service.impl.PersistenceStructureServiceOjbImpl3
org.kuali.rice.krad.service.impl.PostProcessorServiceImpl2
org.kuali.rice.krad.service.impl.PredicateFactoryLookup1
org.kuali.rice.krad.service.impl.SessionDocumentServiceImpl1
org.kuali.rice.krad.uif.service.impl.ExpressionEvaluatorServiceImpl1
org.kuali.rice.krad.workflow.attribute.DataDictionarySearchableAttribute2
org.kuali.rice.krad.workflow.attribute.KualiXmlAttributeHelper1
org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl1
org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl$RoutingAttributeTracker2
org.kuali.rice.ksb.impl.registry.ServiceDescriptorBo1
org.kuali.rice.ksb.messaging.HttpException1
org.kuali.rice.ksb.messaging.MessageServiceInvoker1
org.kuali.rice.ksb.messaging.dao.impl.MessageQueueDAOOjbImpl1
org.kuali.rice.ksb.messaging.exceptionhandling.DefaultMessageExceptionHandler2
org.kuali.rice.ksb.messaging.quartz.KSBSchedulerFactoryBean2
org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector3
org.kuali.rice.ksb.messaging.servlet.KSBDispatcherServlet2
org.kuali.rice.ksb.messaging.threadpool.PriorityBlockingQueuePersistedMessageComparator1
org.kuali.rice.ksb.messaging.web.MessageQueueAction2
org.kuali.rice.ksb.messaging.web.ThreadPoolForm1
org.kuali.rice.ksb.security.SignatureVerifyingInputStream1
org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer3
org.kuali.rice.ksb.security.admin.service.impl.JavaSecurityManagementServiceImpl1
org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction4
org.kuali.rice.ksb.util.KSBConstants1

org.apache.commons.httpclient.contrib.ssl.EasySSLProtocolSocketFactory

BugCategoryDetailsLinePriority
org.apache.commons.httpclient.contrib.ssl.EasySSLProtocolSocketFactory.equals(Object) fails for subtypesBAD_PRACTICEEQ_GETCLASS_AND_CLASS_CONSTANT210Medium

org.kuali.rice.ken.bo.NotificationChannel

BugCategoryDetailsLinePriority
Equals method for org.kuali.rice.ken.bo.NotificationChannel assumes the argument is of type NotificationChannelBAD_PRACTICEBC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS260Medium
org.kuali.rice.ken.bo.NotificationChannel defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE260High
org.kuali.rice.ken.bo.NotificationChannel.equals(Object) does not check for null argumentBAD_PRACTICENP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT260High

org.kuali.rice.ken.dao.impl.NotificationMessegeDeliveryDaoJpa

BugCategoryDetailsLinePriority
Dead store to lockedDeliveries in org.kuali.rice.ken.dao.impl.NotificationMessegeDeliveryDaoJpa.getLockedDeliveries(Class, GenericDao)STYLEDLS_DEAD_LOCAL_STORE100Medium

org.kuali.rice.ken.service.impl.KENAPIServiceImpl

BugCategoryDetailsLinePriority
Unread field: org.kuali.rice.ken.service.impl.KENAPIServiceImpl.prefsServicePERFORMANCEURF_UNREAD_FIELD53Medium

org.kuali.rice.ken.service.impl.NotificationChannelServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.ken.service.impl.NotificationChannelServiceImpl.getAllNotificationChannels() invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR76Medium
org.kuali.rice.ken.service.impl.NotificationChannelServiceImpl.getSubscribableChannels() invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR67Medium

org.kuali.rice.ken.service.impl.NotificationContentTypeServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.ken.service.impl.NotificationContentTypeServiceImpl.getAllCurrentContentTypes() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR132Medium
org.kuali.rice.ken.service.impl.NotificationContentTypeServiceImpl.getNotificationContentType(String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR60Medium

org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of d in org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl.parseSerializedNotificationXml(byte[]) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION564Medium
Possible null pointer dereference of d2 in org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl.parseSerializedNotificationXml(byte[]) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION574Medium

org.kuali.rice.ken.service.impl.NotificationMessageDeliveryAutoRemovalServiceImpl

BugCategoryDetailsLinePriority
Dead store to firstMessageDelivery in org.kuali.rice.ken.service.impl.NotificationMessageDeliveryAutoRemovalServiceImpl.processWorkItems(Collection)STYLEDLS_DEAD_LOCAL_STORE70Medium

org.kuali.rice.ken.service.impl.NotificationMessageDeliveryResolverServiceImpl

BugCategoryDetailsLinePriority
Call to equals() comparing different types in org.kuali.rice.ken.service.impl.NotificationMessageDeliveryResolverServiceImpl.buildCompleteRecipientList(Notification)CORRECTNESSEC_UNRELATED_TYPES106High
Call to equals() comparing different types in org.kuali.rice.ken.service.impl.NotificationMessageDeliveryResolverServiceImpl.buildCompleteRecipientList(Notification)CORRECTNESSEC_UNRELATED_TYPES122High

org.kuali.rice.ken.service.impl.NotificationRecipientServiceKimImpl

BugCategoryDetailsLinePriority
Call to equals() comparing different types in org.kuali.rice.ken.service.impl.NotificationRecipientServiceKimImpl.isRecipientValid(String, String)CORRECTNESSEC_UNRELATED_TYPES79High
Call to equals() comparing different types in org.kuali.rice.ken.service.impl.NotificationRecipientServiceKimImpl.isRecipientValid(String, String)CORRECTNESSEC_UNRELATED_TYPES83High

org.kuali.rice.ken.util.Util

BugCategoryDetailsLinePriority
Primitive value is boxed and then immediately unboxed in org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED294Medium
org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR294Medium
Method org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR310Medium
Method org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR280Medium
org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR277Medium
org.kuali.rice.ken.util.Util.transformContent(Notification) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR172Medium

org.kuali.rice.ken.web.spring.AdministerNotificationRequestController

BugCategoryDetailsLinePriority
Call to equals() comparing different types in org.kuali.rice.ken.web.spring.AdministerNotificationRequestController.view(HttpServletRequest, HttpServletResponse, AdministerNotificationRequestController$AdministerNotificationRequestCommand)CORRECTNESSEC_UNRELATED_TYPES213High
Call to equals() comparing different types in org.kuali.rice.ken.web.spring.AdministerNotificationRequestController.view(HttpServletRequest, HttpServletResponse, AdministerNotificationRequestController$AdministerNotificationRequestCommand)CORRECTNESSEC_UNRELATED_TYPES209High

org.kuali.rice.ken.web.spring.ContentTypeController

BugCategoryDetailsLinePriority
org.kuali.rice.ken.web.spring.ContentTypeController.displayContentTypeForm(HttpServletRequest, HttpServletResponse) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR121Medium
Write to static field org.kuali.rice.ken.web.spring.ContentTypeController.view from instance method org.kuali.rice.ken.web.spring.ContentTypeController.addContentType(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD143High
Write to static field org.kuali.rice.ken.web.spring.ContentTypeController.view from instance method org.kuali.rice.ken.web.spring.ContentTypeController.displayContentTypeForm(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD114High
Write to static field org.kuali.rice.ken.web.spring.ContentTypeController.view from instance method org.kuali.rice.ken.web.spring.ContentTypeController.displayContentTypes(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD96High
Write to static field org.kuali.rice.ken.web.spring.ContentTypeController.view from instance method org.kuali.rice.ken.web.spring.ContentTypeController.updateContentType(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD182High

org.kuali.rice.ken.web.spring.SendEventNotificationMessageController

BugCategoryDetailsLinePriority
Call to equals() comparing different types in org.kuali.rice.ken.web.spring.SendEventNotificationMessageController.submitEventNotificationMessage(HttpServletRequest, HttpServletResponse)CORRECTNESSEC_UNRELATED_TYPES262High
Call to equals() comparing different types in org.kuali.rice.ken.web.spring.SendEventNotificationMessageController.submitEventNotificationMessage(HttpServletRequest, HttpServletResponse)CORRECTNESSEC_UNRELATED_TYPES258High

org.kuali.rice.ken.web.spring.SendNotificationMessageController

BugCategoryDetailsLinePriority
Call to equals() comparing different types in org.kuali.rice.ken.web.spring.SendNotificationMessageController.submitSimpleNotificationMessage(HttpServletRequest, HttpServletResponse)CORRECTNESSEC_UNRELATED_TYPES264High
Call to equals() comparing different types in org.kuali.rice.ken.web.spring.SendNotificationMessageController.submitSimpleNotificationMessage(HttpServletRequest, HttpServletResponse)CORRECTNESSEC_UNRELATED_TYPES260High

org.kuali.rice.ken.web.spring.UserPreferencesController

BugCategoryDetailsLinePriority
Write to static field org.kuali.rice.ken.web.spring.UserPreferencesController.view from instance method org.kuali.rice.ken.web.spring.UserPreferencesController.displayActionListPreferences(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD87High
Write to static field org.kuali.rice.ken.web.spring.UserPreferencesController.view from instance method org.kuali.rice.ken.web.spring.UserPreferencesController.displayUserPreferences(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD103High
Write to static field org.kuali.rice.ken.web.spring.UserPreferencesController.view from instance method org.kuali.rice.ken.web.spring.UserPreferencesController.subscribeToChannel(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD135High
Write to static field org.kuali.rice.ken.web.spring.UserPreferencesController.view from instance method org.kuali.rice.ken.web.spring.UserPreferencesController.unsubscribeFromChannel(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD176High

org.kuali.rice.kew.actionitem.ActionItemComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actionitem.ActionItemComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE29Medium

org.kuali.rice.kew.actionlist.ActionListFilter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actionlist.ActionListFilter.getCreateDateFrom() may expose internal representation by returning ActionListFilter.createDateFromMALICIOUS_CODEEI_EXPOSE_REP68Medium
org.kuali.rice.kew.actionlist.ActionListFilter.getCreateDateTo() may expose internal representation by returning ActionListFilter.createDateToMALICIOUS_CODEEI_EXPOSE_REP148Medium
org.kuali.rice.kew.actionlist.ActionListFilter.getLastAssignedDateFrom() may expose internal representation by returning ActionListFilter.lastAssignedDateFromMALICIOUS_CODEEI_EXPOSE_REP154Medium
org.kuali.rice.kew.actionlist.ActionListFilter.getLastAssignedDateTo() may expose internal representation by returning ActionListFilter.lastAssignedDateToMALICIOUS_CODEEI_EXPOSE_REP134Medium
org.kuali.rice.kew.actionlist.ActionListFilter.setCreateDateFrom(Date) may expose internal representation by storing an externally mutable object into ActionListFilter.createDateFromMALICIOUS_CODEEI_EXPOSE_REP271Medium
org.kuali.rice.kew.actionlist.ActionListFilter.setCreateDateTo(Date) may expose internal representation by storing an externally mutable object into ActionListFilter.createDateToMALICIOUS_CODEEI_EXPOSE_REP2151Medium
org.kuali.rice.kew.actionlist.ActionListFilter.setLastAssignedDateFrom(Date) may expose internal representation by storing an externally mutable object into ActionListFilter.lastAssignedDateFromMALICIOUS_CODEEI_EXPOSE_REP2157Medium
org.kuali.rice.kew.actionlist.ActionListFilter.setLastAssignedDateTo(Date) may expose internal representation by storing an externally mutable object into ActionListFilter.lastAssignedDateToMALICIOUS_CODEEI_EXPOSE_REP2137Medium

org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImpl

BugCategoryDetailsLinePriority
Dead store to filterDescription in org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImpl.addToFilterDescription(String, String)STYLEDLS_DEAD_LOCAL_STORE445High

org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOOjbImpl

BugCategoryDetailsLinePriority
Dead store to filterDescription in org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOOjbImpl.addToFilterDescription(String, String)STYLEDLS_DEAD_LOCAL_STORE552High

org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of docType in org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl.validateActionItem(ActionItem)CORRECTNESSNP_NULL_ON_SOME_PATH261Medium
Possible null pointer dereference of docType in org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl.validateActionItem(ActionItem)CORRECTNESSNP_NULL_ON_SOME_PATH261Medium
Possible null pointer dereference of docType in org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl.validateActionItem(ActionItem)CORRECTNESSNP_NULL_ON_SOME_PATH261Medium
Nullcheck of docType at line 265 of value previously dereferenced in org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl.validateActionItem(ActionItem)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE261Medium

org.kuali.rice.kew.actionlist.web.ActionListAction

BugCategoryDetailsLinePriority
Dead store to partitions in org.kuali.rice.kew.actionlist.web.ActionListAction.processActionListCustomizations(String, List)STYLEDLS_DEAD_LOCAL_STORE863Medium

org.kuali.rice.kew.actionlist.web.ActionListAction$ActionItemComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actionlist.web.ActionListAction$ActionItemComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE814Medium

org.kuali.rice.kew.actionlist.web.ActionListForm

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actionlist.web.ActionListForm.getOutboxItems() may expose internal representation by returning ActionListForm.outboxItemsMALICIOUS_CODEEI_EXPOSE_REP283Medium
org.kuali.rice.kew.actionlist.web.ActionListForm.setOutboxItems(String[]) may expose internal representation by storing an externally mutable object into ActionListForm.outboxItemsMALICIOUS_CODEEI_EXPOSE_REP2287Medium

org.kuali.rice.kew.actionrequest.ActionRequestFactory

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.actionrequest.ActionRequestFactory.createActionRequest(String, Recipient, String, Boolean, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR116Medium
Method org.kuali.rice.kew.actionrequest.ActionRequestFactory.setDefaultProperties(ActionRequestValue) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR260Medium
Method org.kuali.rice.kew.actionrequest.ActionRequestFactory.addRoleResponsibilityRequest(List, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR423Medium

org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl

BugCategoryDetailsLinePriority
Questionable cast from Collection to abstract class java.util.List in org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl.findAllValidRequests(String, Collection, String)STYLEBC_BAD_CAST_TO_ABSTRACT_COLLECTION547High
Dead store to matchedArs in org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl.findAllValidRequests(String, Collection, String)STYLEDLS_DEAD_LOCAL_STORE545High
Possible null pointer dereference of documentType in org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl.updateActionRequestsForResponsibilityChange(Set)CORRECTNESSNP_NULL_ON_SOME_PATH616Medium

org.kuali.rice.kew.actions.DisapproveAction

BugCategoryDetailsLinePriority
Nullcheck of systemUserWorkgroup at line 182 of value previously dereferenced in org.kuali.rice.kew.actions.DisapproveAction.generateNotifications(RouteNodeInstance)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE182Medium

org.kuali.rice.kew.actions.LogDocumentActionAction

BugCategoryDetailsLinePriority
Dead store to actionTaken in org.kuali.rice.kew.actions.LogDocumentActionAction.recordAction()STYLEDLS_DEAD_LOCAL_STORE78Medium

org.kuali.rice.kew.actions.SuperUserActionTakenEvent

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actions.SuperUserActionTakenEvent.AUTHORIZATION isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL46High

org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOJpaImpl

BugCategoryDetailsLinePriority
Impossible cast from org.kuali.rice.core.framework.persistence.jpa.criteria.QueryByCriteria to java.util.List in org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOJpaImpl.findByDocumentIdIgnoreCurrentInd(String)CORRECTNESSBC_IMPOSSIBLE_CAST94High

org.kuali.rice.kew.attribute.XMLAttributeUtils

BugCategoryDetailsLinePriority
Call to equals() comparing unrelated class and interface in org.kuali.rice.kew.attribute.XMLAttributeUtils.establishFieldLookup(RemotableAttributeField$Builder, Node)CORRECTNESSEC_UNRELATED_CLASS_AND_INTERFACE90High
Call to equals() comparing unrelated class and interface in org.kuali.rice.kew.attribute.XMLAttributeUtils.establishFieldLookup(RemotableAttributeField$Builder, Node)CORRECTNESSEC_UNRELATED_CLASS_AND_INTERFACE87High
Call to equals() comparing unrelated class and interface in org.kuali.rice.kew.attribute.XMLAttributeUtils.establishFieldLookup(Field, Node)CORRECTNESSEC_UNRELATED_CLASS_AND_INTERFACE57High
Call to equals() comparing unrelated class and interface in org.kuali.rice.kew.attribute.XMLAttributeUtils.establishFieldLookup(Field, Node)CORRECTNESSEC_UNRELATED_CLASS_AND_INTERFACE54High

org.kuali.rice.kew.config.ThinClientResourceLoader

BugCategoryDetailsLinePriority
org.kuali.rice.kew.config.ThinClientResourceLoader.configureDefaultHttpClientParams(HttpParams) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR232Medium
Method org.kuali.rice.kew.config.ThinClientResourceLoader.initializeHttpClientParams() makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR198Medium

org.kuali.rice.kew.docsearch.DocumentSearchCustomizationMediatorImpl

BugCategoryDetailsLinePriority
Dead store to orderedResultSetFieldMap in org.kuali.rice.kew.docsearch.DocumentSearchCustomizationMediatorImpl.getDocumentSearchCriteriaConfiguration(DocumentType)STYLEDLS_DEAD_LOCAL_STORE61High
Method org.kuali.rice.kew.docsearch.DocumentSearchCustomizationMediatorImpl.getDocumentSearchCriteriaConfiguration(DocumentType) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR78Medium
Method org.kuali.rice.kew.docsearch.DocumentSearchCustomizationMediatorImpl.validateLookupFieldParameters(DocumentType, DocumentSearchCriteria) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR109Medium

org.kuali.rice.kew.docsearch.SearchableAttributeDateTimeValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.SearchableAttributeDateTimeValue.isRangeValid(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL218Medium

org.kuali.rice.kew.docsearch.SearchableAttributeFloatValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.SearchableAttributeFloatValue.isRangeValid(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL242Medium

org.kuali.rice.kew.docsearch.SearchableAttributeLongValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.SearchableAttributeLongValue.isRangeValid(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL236Medium

org.kuali.rice.kew.docsearch.SearchableAttributeStringValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.SearchableAttributeStringValue.isRangeValid(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL161Medium

org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl.saveSearch(String, DocumentSearchCriteria)STYLEREC_CATCH_EXCEPTION552Medium
Method org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl.saveSearch(String, DocumentSearchCriteria) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION516Medium
Method org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl.getSavedSearchAbbreviatedString(DocumentSearchCriteria) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR432Medium

org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute.getBooleanValue(NamedNodeMap, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL519Medium
org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute.getBooleanWithPotentialOverrides(List, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL511Medium
Method org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute.generateSearchContent(ExtensionDefinition, String, WorkflowAttributeDefinition) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION98Medium

org.kuali.rice.kew.doctype.DocumentTypeAttribute

BugCategoryDetailsLinePriority
org.kuali.rice.kew.doctype.DocumentTypeAttribute defines compareTo(Object) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS150Medium

org.kuali.rice.kew.doctype.DocumentTypePolicy

BugCategoryDetailsLinePriority
org.kuali.rice.kew.doctype.DocumentTypePolicy.copy(boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR158Medium
org.kuali.rice.kew.doctype.DocumentTypePolicy.copy(boolean) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR154Medium

org.kuali.rice.kew.doctype.DocumentTypeSecurity

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in new org.kuali.rice.kew.doctype.DocumentTypeSecurity(String, String)STYLEREC_CATCH_EXCEPTION262Medium

org.kuali.rice.kew.doctype.bo.DocumentType

BugCategoryDetailsLinePriority
Method new org.kuali.rice.kew.doctype.bo.DocumentType() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR119Medium

org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOJpaImpl

BugCategoryDetailsLinePriority
Dead store to docType in org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOJpaImpl.delete(DocumentType)STYLEDLS_DEAD_LOCAL_STORE61Medium

org.kuali.rice.kew.doctype.service.impl.DocumentSecurityServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.doctype.service.impl.DocumentSecurityServiceImpl.isAuthenticatedByPermission(String, String, String, Map, Map, SecuritySession) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR352Medium
Method org.kuali.rice.kew.doctype.service.impl.DocumentSecurityServiceImpl.partitionDocumentsForSecurity(List, SecuritySession) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR167Medium
Method org.kuali.rice.kew.doctype.service.impl.DocumentSecurityServiceImpl.processDocumentRequiringExtensionProcessing(List, SecuritySession, Set) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR138Medium

org.kuali.rice.kew.doctype.service.impl.DocumentTypeServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.doctype.service.impl.DocumentTypeServiceImpl.versionAndSave(DocumentType) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR109Medium

org.kuali.rice.kew.documentoperation.web.DocumentOperationAction

BugCategoryDetailsLinePriority
Dead store to ruleTemplate in org.kuali.rice.kew.documentoperation.web.DocumentOperationAction.refresh(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE633Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationAction.getDocument(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION130Medium

org.kuali.rice.kew.documentoperation.web.DocumentOperationForm

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getActionItemOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR172Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getActionRequestOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR144Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getActionTakenOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR151Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getBranchOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR165Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getNodeStateDeleteOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR179Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getRouteNodeInstanceOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR158Medium

org.kuali.rice.kew.dto.DTOConverter

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.dto.DTOConverter.createDocumentContentSection(Document, Element, List, String, String, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION191Medium

org.kuali.rice.kew.engine.BlanketApproveEngine$ProcessEntry

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.engine.BlanketApproveEngine$ProcessEntry be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC263Medium

org.kuali.rice.kew.engine.CompatUtils

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.CompatUtils.getLevelForNode(DocumentType, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR49Medium
Method org.kuali.rice.kew.engine.CompatUtils.getLevelForNode(RouteNode, String, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR68Medium
Method org.kuali.rice.kew.engine.CompatUtils.getNodeForLevel(DocumentType, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR77Medium
Method org.kuali.rice.kew.engine.CompatUtils.getNodeForLevel(RouteNode, Integer, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR99Medium

org.kuali.rice.kew.engine.OrchestrationConfig

BugCategoryDetailsLinePriority
Unread field: org.kuali.rice.kew.engine.OrchestrationConfig.notificationType; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC37Medium

org.kuali.rice.kew.engine.StandardWorkflowEngine

BugCategoryDetailsLinePriority
Dead store to processContext in org.kuali.rice.kew.engine.StandardWorkflowEngine.process(String, String)STYLEDLS_DEAD_LOCAL_STORE140Medium
Method org.kuali.rice.kew.engine.StandardWorkflowEngine.handleBackwardCompatibility(RouteContext, RouteNodeInstance) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR348Medium

org.kuali.rice.kew.engine.node.FYIByNetworkId

BugCategoryDetailsLinePriority
Dead store to documentId in org.kuali.rice.kew.engine.node.FYIByNetworkId.process(RouteContext, RouteHelper)STYLEDLS_DEAD_LOCAL_STORE51Medium

org.kuali.rice.kew.engine.node.KRAMetaRuleNode$FinalApproverContext

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.engine.node.KRAMetaRuleNode$FinalApproverContext be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC219Medium

org.kuali.rice.kew.engine.node.NodeJotter

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.node.NodeJotter.orchestrateOutput(RouteNodeInstance, NodeType, NodeJotter$SplitJoinContext, int) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION71Medium
Method org.kuali.rice.kew.engine.node.NodeJotter.outputNodeInstanceToLog(RouteNodeInstance, NodeType, int) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION92Medium

org.kuali.rice.kew.engine.node.NodeType$ExtensionDepthComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.NodeType$ExtensionDepthComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE179Medium

org.kuali.rice.kew.engine.node.ProcessDefinitionBo

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.node.ProcessDefinitionBo.getVersionNumber() invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR130Medium

org.kuali.rice.kew.engine.node.RequestActivationNode

BugCategoryDetailsLinePriority
Dead store to isParallel in org.kuali.rice.kew.engine.node.RequestActivationNode.activateRequestsCustom(RouteContext, List, List, DocumentRouteHeaderValue, RouteNodeInstance)STYLEDLS_DEAD_LOCAL_STORE132Medium

org.kuali.rice.kew.engine.node.RequestsNode$FinalApproverContext

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.engine.node.RequestsNode$FinalApproverContext be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC283Medium

org.kuali.rice.kew.engine.node.RoleNode$RoleRequestSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.RoleNode$RoleRequestSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE211Medium

org.kuali.rice.kew.engine.node.RouteNodeUtils

BugCategoryDetailsLinePriority
Possible null pointer dereference of nodeList in org.kuali.rice.kew.engine.node.RouteNodeUtils.getCustomRouteNodeElements(RouteNode, String)CORRECTNESSNP_NULL_ON_SOME_PATH102Medium

org.kuali.rice.kew.engine.node.RouteNodeUtils$RouteNodeSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.RouteNodeUtils$RouteNodeSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE199Medium

org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode

BugCategoryDetailsLinePriority
Dead store to documentType in org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode.transitioningOutOf(RouteContext, RouteHelper)STYLEDLS_DEAD_LOCAL_STORE155Medium
Possible null pointer dereference of result in org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode.transitioningOutOf(RouteContext, RouteHelper)CORRECTNESSNP_NULL_ON_SOME_PATH191Medium
Nullcheck of requestNodeStop at line 242 of value previously dereferenced in org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode.canTransitionFrom(HierarchyProvider, HierarchyProvider$Stop, Collection, RouteHelper)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE242Medium

org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl.searchNodeGraphBackward(NodeGraphContext, NodeMatcher) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR347Medium

org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$NodeInstanceIdSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$NodeInstanceIdSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE429Medium

org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$RouteNodeSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$RouteNodeSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE421Medium

org.kuali.rice.kew.engine.simulation.SimulationEngine

BugCategoryDetailsLinePriority
Dead store to processContext in org.kuali.rice.kew.engine.simulation.SimulationEngine.process(String, String)STYLEDLS_DEAD_LOCAL_STORE147Medium
Method org.kuali.rice.kew.engine.simulation.SimulationEngine.createSimulationDocument(String, SimulationCriteria, RouteContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR332Medium

org.kuali.rice.kew.impl.action.WorkflowDocumentActionsServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.impl.action.WorkflowDocumentActionsServiceImpl.routeNodeHasApproverActionRequest(String, String, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR1053Medium
Method org.kuali.rice.kew.impl.action.WorkflowDocumentActionsServiceImpl.determineRequestedActionsInternal(DocumentRouteHeaderValue, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR357Medium

org.kuali.rice.kew.impl.document.search.DocumentSearchCriteriaBo

BugCategoryDetailsLinePriority
org.kuali.rice.kew.impl.document.search.DocumentSearchCriteriaBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID61High

org.kuali.rice.kew.impl.document.search.DocumentSearchCriteriaBoLookupableHelperService

BugCategoryDetailsLinePriority
Dead store to superUserSearch in org.kuali.rice.kew.impl.document.search.DocumentSearchCriteriaBoLookupableHelperService.repopulateSearchTypeFlags()STYLEDLS_DEAD_LOCAL_STORE728Medium
Method org.kuali.rice.kew.impl.document.search.DocumentSearchCriteriaBoLookupableHelperService.cleanupFieldValues(Map, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR197Medium

org.kuali.rice.kew.impl.document.search.DocumentSearchGeneratorImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.impl.document.search.DocumentSearchGeneratorImpl.populateDocumentAttributesValues(DocumentSearchResult$Builder, Statement) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE317High
Method org.kuali.rice.kew.impl.document.search.DocumentSearchGeneratorImpl.getSearchableAttributeSql(Map, List, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR124Medium

org.kuali.rice.kew.impl.peopleflow.PeopleFlowRouteModule

BugCategoryDetailsLinePriority
Nullcheck of config at line 117 of value previously dereferenced in org.kuali.rice.kew.impl.peopleflow.PeopleFlowRouteModule.parsePeopleFlowConfiguration(RouteContext)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE117High

org.kuali.rice.kew.impl.peopleflow.PeopleFlowRouteModule$PeopleFlowConfig

BugCategoryDetailsLinePriority
Impossible cast from String to org.kuali.rice.kew.impl.peopleflow.PeopleFlowRouteModule$NameConfig in org.kuali.rice.kew.impl.peopleflow.PeopleFlowRouteModule$PeopleFlowConfig.getName()CORRECTNESSBC_IMPOSSIBLE_CAST214High
instanceof will always return false in org.kuali.rice.kew.impl.peopleflow.PeopleFlowRouteModule$PeopleFlowConfig.isName(), since a String can't be a org.kuali.rice.kew.impl.peopleflow.PeopleFlowRouteModule$NameConfigCORRECTNESSBC_IMPOSSIBLE_INSTANCEOF210Medium
instanceof will always return true in org.kuali.rice.kew.impl.peopleflow.PeopleFlowRouteModule$PeopleFlowConfig.isId(), since all String are instances of StringSTYLEBC_VACUOUS_INSTANCEOF207Medium

org.kuali.rice.kew.impl.repository.KewTypeBoServiceImpl

BugCategoryDetailsLinePriority
Dead store to bo in org.kuali.rice.kew.impl.repository.KewTypeBoServiceImpl.createKewTypeAttribute(KewTypeAttribute)STYLEDLS_DEAD_LOCAL_STORE188Medium

org.kuali.rice.kew.impl.rule.RuleServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.impl.rule.RuleServiceImpl.getRulesByTemplateNameAndDocumentTypeNameAndEffectiveDate(String, String, DateTime) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR142Medium

org.kuali.rice.kew.impl.rule.attribute.WorkflowRuleAttributeHandlerServiceImpl

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kew.impl.rule.attribute.WorkflowRuleAttributeHandlerServiceImpl.isWorkflowRuleAttribute(String), since all org.kuali.rice.kew.rule.WorkflowRuleAttribute are instances of org.kuali.rice.kew.rule.WorkflowRuleAttributeSTYLEBC_VACUOUS_INSTANCEOF69Medium
Dead store to errors in org.kuali.rice.kew.impl.rule.attribute.WorkflowRuleAttributeHandlerServiceImpl.validateRuleData(String, Map)STYLEDLS_DEAD_LOCAL_STORE127Medium

org.kuali.rice.kew.mail.service.impl.ActionListEmailServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.mail.service.impl.ActionListEmailServiceImpl.getActionListItemsStat(Collection) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR602Medium
Method org.kuali.rice.kew.mail.service.impl.ActionListEmailServiceImpl.getDailyWeeklyMessageBody(Collection) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR580Medium

org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl.generateExceptionGroupRequests(RouteContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR150Medium
Method call in org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl.placeInExceptionRouting(String, PersistedMessageBO, String) passes null for nonnull parameter of placeInExceptionRouting(String, RouteNodeInstance, PersistedMessageBO, RouteContext, DocumentRouteHeaderValue, boolean)CORRECTNESSNP_NULL_PARAM_DEREF63Medium

org.kuali.rice.kew.notes.Note

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.notes.Note.getVersionNumber() invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR258Medium

org.kuali.rice.kew.notes.web.AttachmentServlet

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.kuali.rice.kew.notes.web.AttachmentServlet.doPost(HttpServletRequest, HttpServletResponse)STYLEREC_CATCH_EXCEPTION124Medium

org.kuali.rice.kew.notes.web.NoteAction

BugCategoryDetailsLinePriority
org.kuali.rice.kew.notes.web.NoteAction.initForm(HttpServletRequest, ActionForm) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR211Medium
org.kuali.rice.kew.notes.web.NoteAction.retrieveNoteList(HttpServletRequest, NoteForm) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR240Medium
Method org.kuali.rice.kew.notes.web.NoteAction.edit(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR115Medium
Method org.kuali.rice.kew.notes.web.NoteAction.retrieveNoteList(HttpServletRequest, NoteForm) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR258Medium
Method org.kuali.rice.kew.notes.web.NoteAction.retrieveNoteList(HttpServletRequest, NoteForm) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR234Medium
note could be null and is guaranteed to be dereferenced in org.kuali.rice.kew.notes.web.NoteAction.getAuthorData(Note)CORRECTNESSNP_GUARANTEED_DEREF277Medium
Nullcheck of routeHeader at line 222 of value previously dereferenced in org.kuali.rice.kew.notes.web.NoteAction.retrieveNoteList(HttpServletRequest, NoteForm)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE222Medium

org.kuali.rice.kew.plugin.PluginConfig

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.plugin.PluginConfig.getObjects() makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR102Medium

org.kuali.rice.kew.plugin.PluginEnvironment

BugCategoryDetailsLinePriority
Inconsistent synchronization of org.kuali.rice.kew.plugin.PluginEnvironment.supressStartupFailure; locked 50% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC145Medium

org.kuali.rice.kew.plugin.PluginNameComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kew.plugin.PluginNameComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE25Medium

org.kuali.rice.kew.plugin.ServerPluginRegistry

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.plugin.ServerPluginRegistry.loadPlugins(File) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR139Medium

org.kuali.rice.kew.plugin.ZipFilePluginLoader

BugCategoryDetailsLinePriority
org.kuali.rice.kew.plugin.ZipFilePluginLoader.createPluginClassLoader() creates a org.kuali.rice.kew.plugin.PluginClassLoader classloader, which should be performed within a doPrivileged blockBAD_PRACTICEDP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED179Medium

org.kuali.rice.kew.preferences.service.impl.PreferencesServiceImpl$UserOptionsWrapper

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.preferences.service.impl.PreferencesServiceImpl$UserOptionsWrapper be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC240Medium

org.kuali.rice.kew.quicklinks.ActionListStats

BugCategoryDetailsLinePriority
org.kuali.rice.kew.quicklinks.ActionListStats defines compareTo(Object) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS61Medium

org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOJpaImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOJpaImpl.getInitiatedDocumentTypesList(String) invokes substring(0), which returns the original valueSTYLEDMI_USELESS_SUBSTRING96Medium

org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$1

BugCategoryDetailsLinePriority
A prepared statement is generated from a nonconstant String at org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$1.doInPersistenceBroker(PersistenceBroker) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING62High

org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$2

BugCategoryDetailsLinePriority
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$2.doInPersistenceBroker(PersistenceBroker) invokes substring(0), which returns the original valueSTYLEDMI_USELESS_SUBSTRING154Medium

org.kuali.rice.kew.resourceloader.CoreResourceLoader

BugCategoryDetailsLinePriority
org.kuali.rice.kew.resourceloader.CoreResourceLoader.useRemoteEmailServices() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR104Medium

org.kuali.rice.kew.role.XPathQualifierResolver$ResolverConfig

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.role.XPathQualifierResolver$ResolverConfig be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC227Medium

org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue

BugCategoryDetailsLinePriority
Method new org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR155Medium
Comparison of String parameter using == or != in org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue.setRouteStatus(String, boolean) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ692High
Method org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue.getCurrentRouteLevelName() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION302Medium
Method org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue.applyDocumentUpdate(DocumentUpdate) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR822Medium
Method org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue.from(Document) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR1209Medium

org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImpl.findPendingByResponsibilityIds(Set) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION213Medium

org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findByDocTypeAndAppId(String, String) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR394Medium
Method org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findByDocTypeAndAppId(String, String) may fail to clean up java.sql.StatementEXPERIMENTALOBL_UNSATISFIED_OBLIGATION388Medium
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findByDocTypeAndAppId(String, String) may fail to close PreparedStatementBAD_PRACTICEODR_OPEN_DATABASE_RESOURCE388Medium
Method org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findPendingByResponsibilityIds(Set) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION212Medium
Method org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findPendingByResponsibilityIds(Set) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE224High

org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl$1

BugCategoryDetailsLinePriority
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl$1.doInPersistenceBroker(PersistenceBroker) might ignore java.sql.SQLExceptionBAD_PRACTICEDE_MIGHT_IGNORE132Medium

org.kuali.rice.kew.routeheader.service.impl.WorkflowDocumentServiceImpl

BugCategoryDetailsLinePriority
Dead store to principal in org.kuali.rice.kew.routeheader.service.impl.WorkflowDocumentServiceImpl.takeMassActions(String, List)STYLEDLS_DEAD_LOCAL_STORE451Medium

org.kuali.rice.kew.routelog.web.RouteLogAction

BugCategoryDetailsLinePriority
Dead store to applicationId in org.kuali.rice.kew.routelog.web.RouteLogAction.populateRouteLogFutureRequests(RouteLogForm, DocumentRouteHeaderValue)STYLEDLS_DEAD_LOCAL_STORE213Medium

org.kuali.rice.kew.rule.FlexRM

BugCategoryDetailsLinePriority
Dead store to actionRequests in org.kuali.rice.kew.rule.FlexRM.getActionRequests(DocumentRouteHeaderValue, RouteNode, RouteNodeInstance, String)STYLEDLS_DEAD_LOCAL_STORE205Medium
Private method org.kuali.rice.kew.rule.FlexRM.makeActionRequests(ActionRequestFactory, RouteContext, Rule, DocumentRouteHeaderValue, ActionRequestValue, RuleDelegation) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD244Medium

org.kuali.rice.kew.rule.GroupRuleResponsibility

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.GroupRuleResponsibility doesn't override RuleResponsibilityBo.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS27Medium

org.kuali.rice.kew.rule.KRAMetaRuleEngine

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.KRAMetaRuleEngine.getStatements() may expose internal representation by returning KRAMetaRuleEngine.statementsMALICIOUS_CODEEI_EXPOSE_REP69Medium

org.kuali.rice.kew.rule.PersonRuleResponsibility

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.PersonRuleResponsibility doesn't override RuleResponsibilityBo.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS26Medium

org.kuali.rice.kew.rule.RuleBaseValues

BugCategoryDetailsLinePriority
Method new org.kuali.rice.kew.rule.RuleBaseValues() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR108Medium
Method org.kuali.rice.kew.rule.RuleBaseValues.addRuleResponsibility(RuleResponsibilityBo) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR277Medium
Call to equals() comparing different types in org.kuali.rice.kew.rule.RuleBaseValues.getResponsibility(Long)CORRECTNESSEC_UNRELATED_TYPES361High

org.kuali.rice.kew.rule.RuleExpressionDef

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.RuleExpressionDef defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE102High

org.kuali.rice.kew.rule.RuleExtensionBo

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.RuleExtensionBo defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE179High

org.kuali.rice.kew.rule.RuleExtensionValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.RuleExtensionValue defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE117High

org.kuali.rice.kew.rule.RuleRoutingAttribute

BugCategoryDetailsLinePriority
Nullcheck of ruleRoutingElement at line 172 of value previously dereferenced in org.kuali.rice.kew.rule.RuleRoutingAttribute.parseDocContent(DocumentContent)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE172Medium

org.kuali.rice.kew.rule.TemplateRuleSelector

BugCategoryDetailsLinePriority
Dead store to documentContent in org.kuali.rice.kew.rule.TemplateRuleSelector.selectRules(RouteContext, DocumentRouteHeaderValue, RouteNodeInstance, String, Timestamp)STYLEDLS_DEAD_LOCAL_STORE95Medium

org.kuali.rice.kew.rule.bo.RuleTemplateAttributeBo

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.bo.RuleTemplateAttributeBo defines compareTo(RuleTemplateAttributeBo) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS96Medium

org.kuali.rice.kew.rule.bo.RuleTemplateBo

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.bo.RuleTemplateBo.DEFAULT_OPTION_KEYS should be package protectedMALICIOUS_CODEMS_PKGPROTECT70Medium

org.kuali.rice.kew.rule.dao.impl.RuleDAOJpaImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.dao.impl.RuleDAOJpaImpl.fetchAllRules(boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR125Medium

org.kuali.rice.kew.rule.dao.impl.RuleDAOOjbImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.dao.impl.RuleDAOOjbImpl.fetchAllRules(boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR125Medium

org.kuali.rice.kew.rule.service.impl.RuleServiceInternalImpl

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kew.rule.service.impl.RuleServiceInternalImpl.validate2(RuleBaseValues, RuleDelegationBo, List), since all RuntimeException are instances of RuntimeExceptionSTYLEBC_VACUOUS_INSTANCEOF627Medium
Method org.kuali.rice.kew.rule.service.impl.RuleServiceInternalImpl.createNewRuleVersion(RuleBaseValues, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR1059Medium

org.kuali.rice.kew.rule.service.impl.RuleServiceInternalImpl$RuleDelegationSorter

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.service.impl.RuleServiceInternalImpl$RuleDelegationSorter.compare(Object, Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR931Medium
Should org.kuali.rice.kew.rule.service.impl.RuleServiceInternalImpl$RuleDelegationSorter be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC926Medium

org.kuali.rice.kew.rule.web.RoutingReportAction

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.web.RoutingReportAction.calculateRoute(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR145Medium
Method org.kuali.rice.kew.rule.web.RoutingReportAction.populateActionRequestsWithRouteLevelInformationAndIterateMagicCounter(RouteNode, List, long) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR290Medium

org.kuali.rice.kew.rule.web.RoutingReportAction$RouteReportRuleTemplateContainer

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.rule.web.RoutingReportAction$RouteReportRuleTemplateContainer be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC273Medium

org.kuali.rice.kew.rule.web.WebRuleResponsibility

BugCategoryDetailsLinePriority
Dead store to o in org.kuali.rice.kew.rule.web.WebRuleResponsibility.injectWebMembers()STYLEDLS_DEAD_LOCAL_STORE147Medium
org.kuali.rice.kew.rule.web.WebRuleResponsibility doesn't override org.kuali.rice.kew.rule.RuleResponsibilityBo.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS52Medium

org.kuali.rice.kew.rule.web.WebRuleResponsibility$DelegationRulesProxy

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.web.WebRuleResponsibility$DelegationRulesProxy is serializable and an inner classBAD_PRACTICESE_INNER_CLASS456Medium

org.kuali.rice.kew.rule.web.WebRuleUtils

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.web.WebRuleUtils.transformFieldConversions(List, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR314Medium

org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute

BugCategoryDetailsLinePriority
Nullcheck of map at line 507 of value previously dereferenced in org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute.getDocContent()CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE507Medium
Method org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute.getDocContent() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION498Medium

org.kuali.rice.kew.service.impl.KEWModuleService

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.service.impl.KEWModuleService.getExternalizableBusinessObjectInquiryUrl(Class, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR175Medium

org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.DocumentsRoutedReport(Stats, Date, Date) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR94Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumActiveItemsReport(Stats) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR58Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumInitiatedDocsByDocTypeReport(Stats) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR152Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumUsersReport(Stats) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR127Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumberOfDocTypesReport(Stats) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR74Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.DocumentsRoutedReport(Stats, Date, Date) may fail to clean up java.sql.ResultSetEXPERIMENTALOBL_UNSATISFIED_OBLIGATION89Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.DocumentsRoutedReport(Stats, Date, Date) may fail to clean up java.sql.StatementEXPERIMENTALOBL_UNSATISFIED_OBLIGATION86Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumActiveItemsReport(Stats) may fail to clean up java.sql.ResultSetEXPERIMENTALOBL_UNSATISFIED_OBLIGATION55Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumActiveItemsReport(Stats) may fail to clean up java.sql.StatementEXPERIMENTALOBL_UNSATISFIED_OBLIGATION54Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumInitiatedDocsByDocTypeReport(Stats) may fail to clean up java.sql.ResultSetEXPERIMENTALOBL_UNSATISFIED_OBLIGATION147Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumInitiatedDocsByDocTypeReport(Stats) may fail to clean up java.sql.StatementEXPERIMENTALOBL_UNSATISFIED_OBLIGATION139Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumUsersReport(Stats) may fail to clean up java.sql.ResultSetEXPERIMENTALOBL_UNSATISFIED_OBLIGATION124Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumUsersReport(Stats) may fail to clean up java.sql.StatementEXPERIMENTALOBL_UNSATISFIED_OBLIGATION123Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumberOfDocTypesReport(Stats) may fail to clean up java.sql.ResultSetEXPERIMENTALOBL_UNSATISFIED_OBLIGATION71Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumberOfDocTypesReport(Stats) may fail to clean up java.sql.StatementEXPERIMENTALOBL_UNSATISFIED_OBLIGATION70Medium

org.kuali.rice.kew.stats.web.StatsForm

BugCategoryDetailsLinePriority
org.kuali.rice.kew.stats.web.StatsForm.getBeginningDate() may expose internal representation by returning StatsForm.beginningDateMALICIOUS_CODEEI_EXPOSE_REP247Medium
org.kuali.rice.kew.stats.web.StatsForm.getEndingDate() may expose internal representation by returning StatsForm.endingDateMALICIOUS_CODEEI_EXPOSE_REP255Medium
org.kuali.rice.kew.stats.web.StatsForm.setBeginningDate(Date) may expose internal representation by storing an externally mutable object into StatsForm.beginningDateMALICIOUS_CODEEI_EXPOSE_REP2251Medium
org.kuali.rice.kew.stats.web.StatsForm.setEndingDate(Date) may expose internal representation by storing an externally mutable object into StatsForm.endingDateMALICIOUS_CODEEI_EXPOSE_REP2259Medium
Class org.kuali.rice.kew.stats.web.StatsForm defines non-transient non-serializable instance field statsBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kew.superuser.web.SuperUserAction

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.superuser.web.SuperUserAction.actionRequestApprove(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES221Medium

org.kuali.rice.kew.superuser.web.SuperUserForm

BugCategoryDetailsLinePriority
org.kuali.rice.kew.superuser.web.SuperUserForm.getActionRequestRunPostProcessorCheck() may expose internal representation by returning SuperUserForm.actionRequestRunPostProcessorCheckMALICIOUS_CODEEI_EXPOSE_REP252Medium
org.kuali.rice.kew.superuser.web.SuperUserForm.setActionRequestRunPostProcessorCheck(String[]) may expose internal representation by storing an externally mutable object into SuperUserForm.actionRequestRunPostProcessorCheckMALICIOUS_CODEEI_EXPOSE_REP2255Medium

org.kuali.rice.kew.useroptions.UserOptions

BugCategoryDetailsLinePriority
org.kuali.rice.kew.useroptions.UserOptions defines compareTo(Object) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS116Medium

org.kuali.rice.kew.useroptions.UserOptionsId

BugCategoryDetailsLinePriority
Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kew.useroptions.UserOptionsId.equals(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE46Medium

org.kuali.rice.kew.util.Utilities$PrioritySorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.util.Utilities$PrioritySorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE105Medium

org.kuali.rice.kew.util.Utilities$RouteLogActionRequestSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.util.Utilities$RouteLogActionRequestSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE128Medium

org.kuali.rice.kew.web.FilterMapping

BugCategoryDetailsLinePriority
org.kuali.rice.kew.web.FilterMapping defines compareTo(FilterMapping) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS356Medium

org.kuali.rice.kew.web.UserLoginFilter

BugCategoryDetailsLinePriority
Unread field: org.kuali.rice.kew.web.UserLoginFilter.filterConfigPERFORMANCEURF_UNREAD_FIELD71Medium

org.kuali.rice.kew.xml.AbstractTransformationFilter$CurrentElement

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.AbstractTransformationFilter$CurrentElement be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC143Medium

org.kuali.rice.kew.xml.DocumentTypeXmlParser

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.xml.DocumentTypeXmlParser.checkForOrphanedRouteNodes(Node, Node) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION954Medium
Method org.kuali.rice.kew.xml.DocumentTypeXmlParser.parseAllDocumentTypes(Document) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR233Medium

org.kuali.rice.kew.xml.DocumentTypeXmlParser$DocTypeNode

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.DocumentTypeXmlParser$DocTypeNode be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC1480Medium

org.kuali.rice.kew.xml.DocumentTypeXmlParser$RoutePathContext

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.DocumentTypeXmlParser$RoutePathContext be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC1454Medium

org.kuali.rice.kew.xml.GroupXmlParser

BugCategoryDetailsLinePriority
Dead store to kimTypeAttributes in org.kuali.rice.kew.xml.GroupXmlParser.parseGroup(Element)STYLEDLS_DEAD_LOCAL_STORE146Medium

org.kuali.rice.kew.xml.RuleTemplateXmlParser

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.xml.RuleTemplateXmlParser.parseRuleTemplateAttribute(Element, RuleTemplateBo) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR487Medium
Method org.kuali.rice.kew.xml.RuleTemplateXmlParser.updateRuleDefaults(Element, RuleTemplateBo) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR298Medium
Load of known null value in org.kuali.rice.kew.xml.RuleTemplateXmlParser.updateRuleDefaults(Element, RuleTemplateBo)STYLENP_LOAD_OF_KNOWN_NULL_VALUE285Medium

org.kuali.rice.kew.xml.RuleXmlParser

BugCategoryDetailsLinePriority
Dead store to delegations in org.kuali.rice.kew.xml.RuleXmlParser.parseResponsibility(Element, RuleBaseValues)STYLEDLS_DEAD_LOCAL_STORE378Medium
Method org.kuali.rice.kew.xml.RuleXmlParser.setDefaultRuleValues(RuleBaseValues) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR342Medium

org.kuali.rice.kew.xml.UserXmlParser

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.xml.UserXmlParser.constructEntity(Element) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR138Medium

org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$DocumentTypeParentComparator

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$DocumentTypeParentComparator.getDepth(DocumentType) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR469Medium
Should org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$DocumentTypeParentComparator be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC454Medium

org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$SplitJoinContext

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$SplitJoinContext be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC478Medium

org.kuali.rice.kew.xml.export.GroupXmlExporter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.xml.export.GroupXmlExporter.exportGroup(Element, Group) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR87Medium

org.kuali.rice.kew.xml.export.RuleTemplateXmlExporter

BugCategoryDetailsLinePriority
Redundant nullcheck of defaultActionOption, which is known to be non-null in org.kuali.rice.kew.xml.export.RuleTemplateXmlExporter.exportDefaults(Element, RuleTemplateBo)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE113Medium

org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$SimpleNodeList

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$SimpleNodeList be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC253Medium

org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$XPathSegment

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$XPathSegment be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC227Medium

org.kuali.rice.kim.bo.ui.PersonDocumentRole

BugCategoryDetailsLinePriority
The field org.kuali.rice.kim.bo.ui.PersonDocumentRole.attributeEntry is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium
The field org.kuali.rice.kim.bo.ui.PersonDocumentRole.definitions is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium

org.kuali.rice.kim.document.GenericPermissionMaintainable

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kim.document.GenericPermissionMaintainable.prepareBusinessObject(BusinessObject), since all org.kuali.rice.kim.impl.permission.GenericPermissionBo are instances of org.kuali.rice.krad.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF138Medium

org.kuali.rice.kim.document.IdentityManagementKimDocument

BugCategoryDetailsLinePriority
org.kuali.rice.kim.document.IdentityManagementKimDocument is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID55Medium

org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule.checkUnassignableRoles(IdentityManagementPersonDocument) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR186Medium
Method org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule.checkUnpopulatableGroups(IdentityManagementPersonDocument) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR204Medium

org.kuali.rice.kim.impl.responsibility.ResponsibilityInquirableImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.impl.responsibility.ResponsibilityInquirableImpl.buildInquirableLink(Object, String, Inquiry) uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES63Medium
org.kuali.rice.kim.impl.responsibility.ResponsibilityInquirableImpl is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID41Medium

org.kuali.rice.kim.impl.responsibility.ResponsibilityLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.impl.responsibility.ResponsibilityLookupableHelperServiceImpl.getMemberSearchResults(Map, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR103Medium

org.kuali.rice.kim.impl.type.KimTypeAttributesHelper

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.type.KimTypeAttributesHelper is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID46Medium
Unwritten field: org.kuali.rice.kim.impl.type.KimTypeAttributesHelper.attributesCORRECTNESSUWF_UNWRITTEN_FIELD54Medium
Method org.kuali.rice.kim.impl.type.KimTypeAttributesHelper.getAttributeValue(Map, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR109Medium

org.kuali.rice.kim.impl.type.KimTypeQualifierResolver

BugCategoryDetailsLinePriority
org.kuali.rice.kim.impl.type.KimTypeQualifierResolver.typeServices isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL62High

org.kuali.rice.kim.inquiry.PermissionInquirableImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.inquiry.PermissionInquirableImpl.buildInquirableLink(Object, String, Inquiry) uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES68Medium
org.kuali.rice.kim.inquiry.PermissionInquirableImpl is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID48Medium

org.kuali.rice.kim.lookup.KimDocumentRoleMemberLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Call to equals() comparing different types in org.kuali.rice.kim.lookup.KimDocumentRoleMemberLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean)CORRECTNESSEC_UNRELATED_TYPES65High
Call to equals() comparing different types in org.kuali.rice.kim.lookup.KimDocumentRoleMemberLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean)CORRECTNESSEC_UNRELATED_TYPES65High

org.kuali.rice.kim.lookup.PermissionLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.lookup.PermissionLookupableHelperServiceImpl.getMemberSearchResults(Map, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR104Medium

org.kuali.rice.kim.lookup.PersonLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Class org.kuali.rice.kim.lookup.PersonLookupableHelperServiceImpl defines non-transient non-serializable instance field titleBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kim.lookup.RoleLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.lookup.RoleLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR241Medium

org.kuali.rice.kim.lookup.RoleMemberLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.lookup.RoleMemberLookupableHelperServiceImpl.getActualSizeIfTruncated(List) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR300Medium

org.kuali.rice.kim.rules.ui.PersonDocumentDelegationMemberRule

BugCategoryDetailsLinePriority
Dead store to document in org.kuali.rice.kim.rules.ui.PersonDocumentDelegationMemberRule.processAddPersonDelegationMember(AddPersonDelegationMemberEvent)STYLEDLS_DEAD_LOCAL_STORE42Medium

org.kuali.rice.kim.service.impl.KimModuleService

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.service.impl.KimModuleService.getUrlParameters(String, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR309Medium
Method org.kuali.rice.kim.service.impl.KimModuleService.toQuery(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR209Medium

org.kuali.rice.kim.service.impl.UiDocumentServiceImpl

BugCategoryDetailsLinePriority
Dead store to origRole in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.saveRole(IdentityManagementRoleDocument)STYLEDLS_DEAD_LOCAL_STORE2035High
Dead store to pndMember in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadGroupMembers(IdentityManagementGroupDocument, List)STYLEDLS_DEAD_LOCAL_STORE2558Medium
Dead store to pndGroupQualifier in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadGroupQualifiers(IdentityManagementGroupDocument, Map)STYLEDLS_DEAD_LOCAL_STORE2585Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.toQuery(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR2841Medium

org.kuali.rice.kim.service.impl.UiDocumentServiceImpl$GroupMemberNameComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kim.service.impl.UiDocumentServiceImpl$GroupMemberNameComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE2544Medium

org.kuali.rice.kim.web.struts.action.IdentityManagementPersonDocumentAction

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.web.struts.action.IdentityManagementPersonDocumentAction.addEmpInfo(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR209Medium

org.kuali.rice.kim.web.struts.action.IdentityManagementRoleDocumentAction

BugCategoryDetailsLinePriority
Method call in org.kuali.rice.kim.web.struts.action.IdentityManagementRoleDocumentAction.addResponsibility(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) passes null for nonnull parameter of org.kuali.rice.kim.document.IdentityManagementRoleDocument.addResponsibility(KimDocumentRoleResponsibility)CORRECTNESSNP_NULL_PARAM_DEREF269Medium

org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl.getButtonFieldPermissionDetails(Object, String) uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES624Medium
Unused field: org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl.dataDictionaryServicePERFORMANCEUUF_UNUSED_FIELDMedium
Unused field: org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl.documentHelperServicePERFORMANCEUUF_UNUSED_FIELDMedium

org.kuali.rice.kns.service.impl.BusinessObjectMetaDataServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.service.impl.BusinessObjectMetaDataServiceImpl.getNestedBOClass(BusinessObject, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION361Medium

org.kuali.rice.kns.service.impl.BusinessObjectSerializerServiceImpl

BugCategoryDetailsLinePriority
The class name org.kuali.rice.kns.service.impl.BusinessObjectSerializerServiceImpl shadows the simple name of the superclass org.kuali.rice.krad.service.impl.BusinessObjectSerializerServiceImplBAD_PRACTICENM_SAME_SIMPLE_NAME_AS_SUPERCLASS30High

org.kuali.rice.kns.service.impl.DataDictionaryServiceImpl

BugCategoryDetailsLinePriority
The class name org.kuali.rice.kns.service.impl.DataDictionaryServiceImpl shadows the simple name of the superclass org.kuali.rice.krad.service.impl.DataDictionaryServiceImplBAD_PRACTICENM_SAME_SIMPLE_NAME_AS_SUPERCLASS32High

org.kuali.rice.kns.service.impl.DictionaryValidationServiceImpl

BugCategoryDetailsLinePriority
The class name org.kuali.rice.kns.service.impl.DictionaryValidationServiceImpl shadows the simple name of the superclass org.kuali.rice.krad.service.impl.DictionaryValidationServiceImplBAD_PRACTICENM_SAME_SIMPLE_NAME_AS_SUPERCLASS43High

org.kuali.rice.kns.service.impl.MaintenanceDocumentDictionaryServiceImpl

BugCategoryDetailsLinePriority
Dead store to subItems in org.kuali.rice.kns.service.impl.MaintenanceDocumentDictionaryServiceImpl.getMaintainableItem(String, String)STYLEDLS_DEAD_LOCAL_STORE400Medium
org.kuali.rice.kns.service.impl.MaintenanceDocumentDictionaryServiceImpl.LOG isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL50High

org.kuali.rice.kns.web.struts.action.KualiActionServlet

BugCategoryDetailsLinePriority
Class org.kuali.rice.kns.web.struts.action.KualiActionServlet defines non-transient non-serializable instance field serverConfigOverrideBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kns.web.struts.action.KualiActionServlet$KualiActionServletConfig

BugCategoryDetailsLinePriority
Should org.kuali.rice.kns.web.struts.action.KualiActionServlet$KualiActionServletConfig be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC114Medium

org.kuali.rice.krad.dao.impl.BusinessObjectDaoJpa

BugCategoryDetailsLinePriority
Unused field: org.kuali.rice.krad.dao.impl.BusinessObjectDaoJpa.ojbCollectionHelperPERFORMANCEUUF_UNUSED_FIELDMedium

org.kuali.rice.krad.dao.impl.LookupDaoJpa

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.dao.impl.LookupDaoJpa.executeSearch(Class, Criteria, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR218Medium
Comparison of String parameter using == or != in org.kuali.rice.krad.dao.impl.LookupDaoJpa.addLogicalOperatorCriteria(String, String, Class, boolean, Criteria, String) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ597Medium
Potentially dangerous use of non-short-circuit logic in org.kuali.rice.krad.dao.impl.LookupDaoJpa.findObjectByMap(Object, Map)STYLENS_DANGEROUS_NON_SHORT_CIRCUIT367High
Method org.kuali.rice.krad.dao.impl.LookupDaoJpa.addInactivateableFromToCurrentCriteria(Object, String, Criteria, Map) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION550Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoJpa.findCountByMap(Object, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR79Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoJpa.findObjectByMap(Object, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR363Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoJpa.getCollectionCriteriaFromMap(PersistableBusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR140Medium

org.kuali.rice.krad.dao.impl.LookupDaoOjb

BugCategoryDetailsLinePriority
Dead store to searchResults in org.kuali.rice.krad.dao.impl.LookupDaoOjb.executeSearch(Class, Criteria, boolean)STYLEDLS_DEAD_LOCAL_STORE163Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoOjb.executeSearch(Class, Criteria, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR170Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoOjb.findCountByMap(Object, Map) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR272Medium
Potentially dangerous use of non-short-circuit logic in org.kuali.rice.krad.dao.impl.LookupDaoOjb.findObjectByMap(Object, Map)STYLENS_DANGEROUS_NON_SHORT_CIRCUIT292High
Method org.kuali.rice.krad.dao.impl.LookupDaoOjb.findCountByMap(Object, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR239Medium
Method org.kuali.rice.krad.dao.impl.LookupDaoOjb.getCollectionCriteriaFromMap(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR92Medium

org.kuali.rice.krad.dao.impl.NoteDaoOjb

BugCategoryDetailsLinePriority
Nullcheck of note at line 60 of value previously dereferenced in org.kuali.rice.krad.dao.impl.NoteDaoOjb.save(Note)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE56Medium

org.kuali.rice.krad.dao.impl.PersistenceDaoJpa

BugCategoryDetailsLinePriority
org.kuali.rice.krad.dao.impl.PersistenceDaoJpa.getField(Class, String) might ignore java.lang.ExceptionBAD_PRACTICEDE_MIGHT_IGNORE111High

org.kuali.rice.krad.dao.proxy.DocumentHeaderDaoProxy

BugCategoryDetailsLinePriority
Dead store to START_INDEX in org.kuali.rice.krad.dao.proxy.DocumentHeaderDaoProxy.getDao(Class)STYLEDLS_DEAD_LOCAL_STORE28Medium

org.kuali.rice.krad.dao.proxy.MaintenanceDocumentDaoProxy

BugCategoryDetailsLinePriority
Dead store to START_INDEX in org.kuali.rice.krad.dao.proxy.MaintenanceDocumentDaoProxy.getDao(Class)STYLEDLS_DEAD_LOCAL_STORE32Medium

org.kuali.rice.krad.dao.proxy.NoteDaoProxy

BugCategoryDetailsLinePriority
Dead store to START_INDEX in org.kuali.rice.krad.dao.proxy.NoteDaoProxy.getDao(Class)STYLEDLS_DEAD_LOCAL_STORE32Medium

org.kuali.rice.krad.dao.proxy.PersistedLookupMetadataDaoProxy

BugCategoryDetailsLinePriority
Dead store to START_INDEX in org.kuali.rice.krad.dao.proxy.PersistedLookupMetadataDaoProxy.getDao(Class)STYLEDLS_DEAD_LOCAL_STORE32Medium

org.kuali.rice.krad.dao.proxy.PersistenceDaoProxy

BugCategoryDetailsLinePriority
Dead store to entityManager in org.kuali.rice.krad.dao.proxy.PersistenceDaoProxy.getDao(Class)STYLEDLS_DEAD_LOCAL_STORE59Medium

org.kuali.rice.krad.document.authorization.MaintenanceDocumentAuthorizerBase

BugCategoryDetailsLinePriority
org.kuali.rice.krad.document.authorization.MaintenanceDocumentAuthorizerBase.documentDictionaryService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium

org.kuali.rice.krad.service.impl.AttachmentServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.service.impl.AttachmentServiceImpl.createAttachment(PersistableBusinessObject, String, String, int, InputStream, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR91Medium
org.kuali.rice.krad.service.impl.AttachmentServiceImpl.deleteAttachmentContents(Attachment) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE165Medium
org.kuali.rice.krad.service.impl.AttachmentServiceImpl.deletePendingAttachmentsModifiedBefore(long) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE246Medium
org.kuali.rice.krad.service.impl.AttachmentServiceImpl.moveAttachmentFromPending(Attachment, String) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE154Medium

org.kuali.rice.krad.service.impl.BusinessObjectSerializerServiceImpl

BugCategoryDetailsLinePriority
Dead store to maintenanceDocumentEntry in org.kuali.rice.krad.service.impl.BusinessObjectSerializerServiceImpl.getPropertySerizabilityEvaluator(Object)STYLEDLS_DEAD_LOCAL_STORE60Medium

org.kuali.rice.krad.service.impl.BusinessObjectServiceImpl

BugCategoryDetailsLinePriority
Possible doublecheck on org.kuali.rice.krad.service.impl.BusinessObjectServiceImpl.illegalBusinessObjectsForSaveInitialized in org.kuali.rice.krad.service.impl.BusinessObjectServiceImpl.isBusinessObjectAllowedForSave(PersistableBusinessObject)MT_CORRECTNESSDC_DOUBLECHECK123Medium

org.kuali.rice.krad.service.impl.DataObjectMetaDataServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.service.impl.DataObjectMetaDataServiceImpl.getDataObjectIdentifierString(Object) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION425Medium
Method org.kuali.rice.krad.service.impl.DataObjectMetaDataServiceImpl.equalsByPrimaryKeys(Object, Object) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR134Medium

org.kuali.rice.krad.service.impl.DictionaryValidationServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.service.impl.DictionaryValidationServiceImpl.validateBusinessObjectsFromDescriptors(Object, PropertyDescriptor[], int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR398Medium

org.kuali.rice.krad.service.impl.DocumentServiceImpl

BugCategoryDetailsLinePriority
Inconsistent synchronization of org.kuali.rice.krad.service.impl.DocumentServiceImpl.workflowDocumentService; locked 66% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC649Medium

org.kuali.rice.krad.service.impl.InactivateableFromToServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.service.impl.InactivateableFromToServiceImpl.buildGroupByValueString(BusinessObject, List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION195Medium

org.kuali.rice.krad.service.impl.InactivationBlockingDisplayServiceImpl

BugCategoryDetailsLinePriority
Unread field: org.kuali.rice.krad.service.impl.InactivationBlockingDisplayServiceImpl.persistenceServicePERFORMANCEURF_UNREAD_FIELD135Medium

org.kuali.rice.krad.service.impl.KualiExceptionIncidentServiceImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of exceptionIncident in org.kuali.rice.krad.service.impl.KualiExceptionIncidentServiceImpl.report(KualiExceptionIncident)CORRECTNESSNP_NULL_ON_SOME_PATH190High

org.kuali.rice.krad.service.impl.MaintenanceDocumentServiceImpl

BugCategoryDetailsLinePriority
Dead store to user in org.kuali.rice.krad.service.impl.MaintenanceDocumentServiceImpl.clearUnauthorizedNewFields(MaintenanceDocument)STYLEDLS_DEAD_LOCAL_STORE299Medium

org.kuali.rice.krad.service.impl.ModuleServiceBase

BugCategoryDetailsLinePriority
Dead store to classModifiers in org.kuali.rice.krad.service.impl.ModuleServiceBase.getExternalizableBusinessObjectImplementation(Class)STYLEDLS_DEAD_LOCAL_STORE330Medium
Method org.kuali.rice.krad.service.impl.ModuleServiceBase.getExternalizableBusinessObjectLookupUrl(Class, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR230Medium
Method org.kuali.rice.krad.service.impl.ModuleServiceBase.getUrlParameters(String, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR189Medium

org.kuali.rice.krad.service.impl.PersistenceStructureServiceJpaImpl

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.krad.service.impl.PersistenceStructureServiceJpaImpl.listCollectionObjectTypes(PersistableBusinessObject), since all org.kuali.rice.krad.bo.PersistableBusinessObject are instances of org.kuali.rice.krad.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF606Medium
instanceof will always return true in org.kuali.rice.krad.service.impl.PersistenceStructureServiceJpaImpl.listReferenceObjectFields(PersistableBusinessObject), since all org.kuali.rice.krad.bo.PersistableBusinessObject are instances of org.kuali.rice.krad.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF621Medium
org.kuali.rice.krad.service.impl.PersistenceStructureServiceJpaImpl.referenceConversionMap isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL58High

org.kuali.rice.krad.service.impl.PersistenceStructureServiceOjbImpl

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.krad.service.impl.PersistenceStructureServiceOjbImpl.listCollectionObjectTypes(PersistableBusinessObject), since all org.kuali.rice.krad.bo.PersistableBusinessObject are instances of org.kuali.rice.krad.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF647Medium
instanceof will always return true in org.kuali.rice.krad.service.impl.PersistenceStructureServiceOjbImpl.listReferenceObjectFields(PersistableBusinessObject), since all org.kuali.rice.krad.bo.PersistableBusinessObject are instances of org.kuali.rice.krad.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF662Medium
org.kuali.rice.krad.service.impl.PersistenceStructureServiceOjbImpl.referenceConversionMap isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL62High

org.kuali.rice.krad.service.impl.PostProcessorServiceImpl

BugCategoryDetailsLinePriority
Call to equals() comparing different types in org.kuali.rice.krad.service.impl.PostProcessorServiceImpl.doActionTaken(ActionTakenEvent)CORRECTNESSEC_UNRELATED_TYPES144High
org.kuali.rice.kew.api.action.ActionType is incompatible with expected argument type String in org.kuali.rice.krad.service.impl.PostProcessorServiceImpl.doActionTaken(ActionTakenEvent)CORRECTNESSGC_UNRELATED_TYPES145High

org.kuali.rice.krad.service.impl.PredicateFactoryLookup

BugCategoryDetailsLinePriority
Dead store to caseInsensitive in org.kuali.rice.krad.service.impl.PredicateFactoryLookup.createFromComplexCriteriaValue(Class, String, String, String)STYLEDLS_DEAD_LOCAL_STORE198Medium

org.kuali.rice.krad.service.impl.SessionDocumentServiceImpl

BugCategoryDetailsLinePriority
Dead store to key in org.kuali.rice.krad.service.impl.SessionDocumentServiceImpl.setDocumentForm(DocumentFormBase, UserSession, String)STYLEDLS_DEAD_LOCAL_STORE170Medium

org.kuali.rice.krad.uif.service.impl.ExpressionEvaluatorServiceImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of replacers in org.kuali.rice.krad.uif.service.impl.ExpressionEvaluatorServiceImpl.evaluatePropertyReplacers(Object, Object, Map)CORRECTNESSNP_NULL_ON_SOME_PATH162Medium

org.kuali.rice.krad.workflow.attribute.DataDictionarySearchableAttribute

BugCategoryDetailsLinePriority
Dead store to boEntry in org.kuali.rice.krad.workflow.attribute.DataDictionarySearchableAttribute.createFieldRowsForBusinessObject(Class)STYLEDLS_DEAD_LOCAL_STORE434Medium
Method org.kuali.rice.krad.workflow.attribute.DataDictionarySearchableAttribute.validateDocumentAttributeCriteria(ExtensionDefinition, DocumentSearchCriteria) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR223Medium

org.kuali.rice.krad.workflow.attribute.KualiXmlAttributeHelper

BugCategoryDetailsLinePriority
Dead store to theEnd in org.kuali.rice.krad.workflow.attribute.KualiXmlAttributeHelper.getXPathTerms(Element)STYLEDLS_DEAD_LOCAL_STORE431Medium

org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl.copyQualifications(Map, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR187Medium

org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl$RoutingAttributeTracker

BugCategoryDetailsLinePriority
Method org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl$RoutingAttributeTracker.checkPoint() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR500Medium
Should org.kuali.rice.krad.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl$RoutingAttributeTracker be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC477Medium

org.kuali.rice.ksb.impl.registry.ServiceDescriptorBo

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.impl.registry.ServiceDescriptorBo is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID60Medium

org.kuali.rice.ksb.messaging.HttpException

BugCategoryDetailsLinePriority
The class name org.kuali.rice.ksb.messaging.HttpException shadows the simple name of the superclass org.apache.commons.httpclient.HttpExceptionBAD_PRACTICENM_SAME_SIMPLE_NAME_AS_SUPERCLASS26High

org.kuali.rice.ksb.messaging.MessageServiceInvoker

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.MessageServiceInvoker.run() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR76Medium

org.kuali.rice.ksb.messaging.dao.impl.MessageQueueDAOOjbImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.ksb.messaging.dao.impl.MessageQueueDAOOjbImpl.findByValues(Map, int) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR85Medium

org.kuali.rice.ksb.messaging.exceptionhandling.DefaultMessageExceptionHandler

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.exceptionhandling.DefaultMessageExceptionHandler.getImmediateExceptionRouting() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR142Medium
Method org.kuali.rice.ksb.messaging.exceptionhandling.DefaultMessageExceptionHandler.requeue(Throwable, PersistedMessageBO) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR92Medium

org.kuali.rice.ksb.messaging.quartz.KSBSchedulerFactoryBean

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.quartz.KSBSchedulerFactoryBean.afterPropertiesSet() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR67Medium
Unused field: org.kuali.rice.ksb.messaging.quartz.KSBSchedulerFactoryBean.transactionManagerPERFORMANCEUUF_UNUSED_FIELDMedium

org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector.configureDefaultHttpClientParams(HttpParams) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR139Medium
Method org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector.configureDefaultHttpClientParams(HttpParams) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR132Medium
Method org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector.initializeHttpClientParams() makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR118Medium

org.kuali.rice.ksb.messaging.servlet.KSBDispatcherServlet

BugCategoryDetailsLinePriority
Class org.kuali.rice.ksb.messaging.servlet.KSBDispatcherServlet defines non-transient non-serializable instance field cxfServletControllerBAD_PRACTICESE_BAD_FIELDMedium
Class org.kuali.rice.ksb.messaging.servlet.KSBDispatcherServlet defines non-transient non-serializable instance field httpInvokerHandlerBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.ksb.messaging.threadpool.PriorityBlockingQueuePersistedMessageComparator

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.threadpool.PriorityBlockingQueuePersistedMessageComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE32Medium

org.kuali.rice.ksb.messaging.web.MessageQueueAction

BugCategoryDetailsLinePriority
Method org.kuali.rice.ksb.messaging.web.MessageQueueAction.quickRequeueMessage(PersistedMessageBO) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR204Medium
Call to equals() comparing different types in org.kuali.rice.ksb.messaging.web.MessageQueueAction.establishRequiredState(HttpServletRequest, ActionForm)CORRECTNESSEC_UNRELATED_TYPES337High

org.kuali.rice.ksb.messaging.web.ThreadPoolForm

BugCategoryDetailsLinePriority
Class org.kuali.rice.ksb.messaging.web.ThreadPoolForm defines non-transient non-serializable instance field threadPoolBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.ksb.security.SignatureVerifyingInputStream

BugCategoryDetailsLinePriority
new org.kuali.rice.ksb.security.SignatureVerifyingInputStream(byte[], Signature, InputStream) may expose internal representation by storing an externally mutable object into SignatureVerifyingInputStream.digitalSignatureMALICIOUS_CODEEI_EXPOSE_REP239Medium

org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer.getCreateDate() may expose internal representation by returning KeyStoreEntryDataContainer.createDateMALICIOUS_CODEEI_EXPOSE_REP82Medium
new org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer(String, Date) may expose internal representation by storing an externally mutable object into KeyStoreEntryDataContainer.createDateMALICIOUS_CODEEI_EXPOSE_REP250Medium
org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer.setCreateDate(Date) may expose internal representation by storing an externally mutable object into KeyStoreEntryDataContainer.createDateMALICIOUS_CODEEI_EXPOSE_REP289Medium

org.kuali.rice.ksb.security.admin.service.impl.JavaSecurityManagementServiceImpl

BugCategoryDetailsLinePriority
Unread field: org.kuali.rice.ksb.security.admin.service.impl.JavaSecurityManagementServiceImpl.CLIENT_CERT_EXPIRATION_DAYS; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC57Medium

org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction

BugCategoryDetailsLinePriority
Dead store to form in org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction.clear(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE81High
Dead store to form in org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction.generateClientKeyStore(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE121High
Dead store to data in org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction.generateClientKeyStore(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE100Medium
The parameter form to org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction.clear(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) is dead upon entry but overwrittenCORRECTNESSIP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN81High

org.kuali.rice.ksb.util.KSBConstants

BugCategoryDetailsLinePriority
Method org.kuali.rice.ksb.util.KSBConstants.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR71Medium