FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
261386600

Files

ClassBugs
org.apache.commons.httpclient.contrib.ssl.EasySSLProtocolSocketFactory1
org.apache.ojb.broker.platforms.KualiMySQLSequenceManagerImpl1
org.kuali.rice.core.config.AbstractBaseConfig1
org.kuali.rice.core.config.BaseConfig1
org.kuali.rice.core.config.ConfigLogger1
org.kuali.rice.core.config.HierarchicalConfigParser1
org.kuali.rice.core.config.JAXBConfigImpl$ConfigNamespaceURIFilter1
org.kuali.rice.core.config.RiceConfigurer1
org.kuali.rice.core.config.RiceConfigurerBase1
org.kuali.rice.core.config.SimpleNodeSettingsStore3
org.kuali.rice.core.config.logging.Log4jLifeCycle$WorkflowLog4j_1_2_13_PropertyConfigurator1
org.kuali.rice.core.config.spring.ConfigFactoryBean2
org.kuali.rice.core.database.PreparedStatementCachingConnection1
org.kuali.rice.core.database.platform.MySQLDatabasePlatform4
org.kuali.rice.core.database.platform.OracleDatabasePlatform2
org.kuali.rice.core.jdbc.PreparedObject2
org.kuali.rice.core.jdbc.SqlBuilder2
org.kuali.rice.core.jdbc.criteria.Criteria6
org.kuali.rice.core.jdbc.criteria.Criteria$AndCriteria1
org.kuali.rice.core.jdbc.criteria.Criteria$OrCriteria1
org.kuali.rice.core.jpa.criteria.Criteria5
org.kuali.rice.core.jpa.criteria.Criteria$AndCriteria1
org.kuali.rice.core.jpa.criteria.Criteria$OrCriteria1
org.kuali.rice.core.jpa.dialect.MySQLDialect1
org.kuali.rice.core.jpa.metadata.CollectionDescriptor2
org.kuali.rice.core.jpa.metadata.EntityDescriptor1
org.kuali.rice.core.jpa.metadata.FieldDescriptor1
org.kuali.rice.core.jpa.metadata.MetadataManager1
org.kuali.rice.core.jpa.metadata.ObjectDescriptor2
org.kuali.rice.core.jpa.spring.RiceLocalContainerEntityManagerFactoryBean1
org.kuali.rice.core.ojb.BaseOjbConfigurer2
org.kuali.rice.core.ojb.ContextClassLoaderSetProxy1
org.kuali.rice.core.ojb.TransactionManagerFactory1
org.kuali.rice.core.proxy.BaseInvocationHandler1
org.kuali.rice.core.resourceloader.SimpleServiceLocator1
org.kuali.rice.core.resourceloader.SpringLoader3
org.kuali.rice.core.resourceloader.SpringResourceLoader1
org.kuali.rice.core.service.impl.DemonstrationGradeEncryptionServiceImpl1
org.kuali.rice.core.service.impl.NoEncryptionEncryptionServiceImpl1
org.kuali.rice.core.util.GRLServiceInjectionPostProcessor$AnnotatedMember1
org.kuali.rice.core.util.ImmutableProperties1
org.kuali.rice.core.util.KeyValue1
org.kuali.rice.core.util.OrmUtils1
org.kuali.rice.core.web.jetty.JettyServer1
org.kuali.rice.core.web.listener.StandaloneInitializeListener1
org.kuali.rice.kcb.quartz.MessageDeletionListener1
org.kuali.rice.ken.bo.NotificationChannel3
org.kuali.rice.ken.service.impl.KENAPIServiceImpl1
org.kuali.rice.ken.service.impl.NotificationChannelServiceImpl2
org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl2
org.kuali.rice.ken.service.impl.NotificationMessageDeliveryAutoRemovalServiceImpl1
org.kuali.rice.ken.util.OjbCharBooleanConversion2
org.kuali.rice.ken.util.Util6
org.kuali.rice.ken.web.spring.AdministerNotificationRequestController1
org.kuali.rice.ken.web.spring.ContentTypeController5
org.kuali.rice.ken.web.spring.UserPreferencesController4
org.kuali.rice.kew.actionitem.ActionItem1
org.kuali.rice.kew.actionitem.ActionItemComparator1
org.kuali.rice.kew.actionlist.ActionListFilter8
org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImpl1
org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOOjbImpl1
org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl4
org.kuali.rice.kew.actionlist.web.ActionListAction$ActionItemComparator1
org.kuali.rice.kew.actionlist.web.ActionListForm2
org.kuali.rice.kew.actionrequest.ActionRequestFactory1
org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl2
org.kuali.rice.kew.actions.DisapproveAction1
org.kuali.rice.kew.actions.LogDocumentActionAction1
org.kuali.rice.kew.actions.SuperUserActionTakenEvent1
org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOJpaImpl1
org.kuali.rice.kew.attribute.XMLAttributeUtils2
org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl6
org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl10
org.kuali.rice.kew.config.ThinClientResourceLoader2
org.kuali.rice.kew.docsearch.DocSearchUtils2
org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder4
org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter1
org.kuali.rice.kew.docsearch.SearchableAttributeDateTimeValue1
org.kuali.rice.kew.docsearch.SearchableAttributeFloatValue1
org.kuali.rice.kew.docsearch.SearchableAttributeLongValue1
org.kuali.rice.kew.docsearch.SearchableAttributeStringValue1
org.kuali.rice.kew.docsearch.StandardDocumentSearchCriteriaProcessor1
org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator11
org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor6
org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor$DisplayValues1
org.kuali.rice.kew.docsearch.dao.impl.DocumentSearchDAOOjbImpl2
org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl4
org.kuali.rice.kew.docsearch.web.SearchAttributeFormContainer3
org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute4
org.kuali.rice.kew.doctype.DocumentTypeAttribute1
org.kuali.rice.kew.doctype.DocumentTypeLookupableHelperServiceImpl1
org.kuali.rice.kew.doctype.DocumentTypePolicy3
org.kuali.rice.kew.doctype.DocumentTypeSecurity1
org.kuali.rice.kew.doctype.bo.DocumentType1
org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOJpaImpl1
org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOOjbImpl2
org.kuali.rice.kew.doctype.service.impl.DocumentTypeServiceImpl1
org.kuali.rice.kew.document.RoutingRuleMaintainableBusRule1
org.kuali.rice.kew.documentoperation.web.DocumentOperationAction1
org.kuali.rice.kew.documentoperation.web.DocumentOperationForm6
org.kuali.rice.kew.dto.DTOConverter4
org.kuali.rice.kew.edl.EDLDatabasePostProcessor1
org.kuali.rice.kew.edl.EDLXmlUtils1
org.kuali.rice.kew.edl.UserAction5
org.kuali.rice.kew.edl.components.NoteConfigComponent5
org.kuali.rice.kew.edl.components.NoteConfigComponent$NoteForm1
org.kuali.rice.kew.edl.components.SelectControlEDLComponent1
org.kuali.rice.kew.edl.components.ValidationComponent1
org.kuali.rice.kew.edl.components.VersioningPreprocessor2
org.kuali.rice.kew.edl.components.WorkflowDocumentActions1
org.kuali.rice.kew.engine.BlanketApproveEngine$ProcessEntry1
org.kuali.rice.kew.engine.CompatUtils4
org.kuali.rice.kew.engine.EngineState1
org.kuali.rice.kew.engine.StandardWorkflowEngine2
org.kuali.rice.kew.engine.node.FYIByNetworkId1
org.kuali.rice.kew.engine.node.IteratedRequestActivationNode1
org.kuali.rice.kew.engine.node.KRAMetaRuleNode$FinalApproverContext1
org.kuali.rice.kew.engine.node.NodeJotter2
org.kuali.rice.kew.engine.node.NodeType$ExtensionDepthComparator1
org.kuali.rice.kew.engine.node.RequestActivationNode1
org.kuali.rice.kew.engine.node.RequestsNode$FinalApproverContext1
org.kuali.rice.kew.engine.node.RoleNode$RoleRequestSorter1
org.kuali.rice.kew.engine.node.RouteNodeUtils$RouteNodeSorter1
org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode3
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl1
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$NodeInstanceIdSorter1
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$RouteNodeSorter1
org.kuali.rice.kew.engine.simulation.SimulationEngine2
org.kuali.rice.kew.help.service.impl.HelpServiceImpl1
org.kuali.rice.kew.help.web.HelpForm1
org.kuali.rice.kew.mail.service.impl.ActionListEmailServiceImpl2
org.kuali.rice.kew.mail.service.impl.HardCodedActionListEmailServiceImpl2
org.kuali.rice.kew.mail.service.impl.HardCodedEmailContentServiceImpl2
org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl2
org.kuali.rice.kew.notes.service.impl.AttachmentServiceImpl1
org.kuali.rice.kew.notes.web.AttachmentServlet1
org.kuali.rice.kew.notes.web.NoteAction7
org.kuali.rice.kew.plugin.ModificationTracker1
org.kuali.rice.kew.plugin.ModificationTracker$Node3
org.kuali.rice.kew.plugin.PluginConfig1
org.kuali.rice.kew.plugin.PluginEnvironment1
org.kuali.rice.kew.plugin.PluginNameComparator1
org.kuali.rice.kew.plugin.ServerPluginRegistry1
org.kuali.rice.kew.plugin.ZipFilePluginLoader1
org.kuali.rice.kew.preferences.service.impl.PreferencesServiceImpl1
org.kuali.rice.kew.quicklinks.ActionListStats1
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOJpaImpl1
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$21
org.kuali.rice.kew.removereplace.service.impl.RemoveReplaceDocumentServiceImpl1
org.kuali.rice.kew.removereplace.web.RemoveReplaceAction$ResponsibilityEvaluation1
org.kuali.rice.kew.resourceloader.CoreResourceLoader1
org.kuali.rice.kew.role.RoleRouteModule1
org.kuali.rice.kew.role.XPathQualifierResolver$ResolverConfig1
org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue3
org.kuali.rice.kew.routeheader.PartialAttributeContent2
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImpl1
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl5
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl$11
org.kuali.rice.kew.routeheader.service.impl.WorkflowDocumentServiceImpl1
org.kuali.rice.kew.rule.FlexRM3
org.kuali.rice.kew.rule.GroupRuleResponsibility1
org.kuali.rice.kew.rule.KRAMetaRuleEngine1
org.kuali.rice.kew.rule.MyRules21
org.kuali.rice.kew.rule.PersonRuleResponsibility1
org.kuali.rice.kew.rule.RemoveReplaceRuleRoutingAttribute1
org.kuali.rice.kew.rule.RemoveReplaceRuleRoutingAttribute$RuleDocumentType2
org.kuali.rice.kew.rule.RuleBaseValues6
org.kuali.rice.kew.rule.RuleDelegation2
org.kuali.rice.kew.rule.RuleExpressionDef1
org.kuali.rice.kew.rule.RuleExtension2
org.kuali.rice.kew.rule.RuleExtensionValue3
org.kuali.rice.kew.rule.RuleRoutingAttribute1
org.kuali.rice.kew.rule.RuleTemplateOption2
org.kuali.rice.kew.rule.TemplateRuleSelector1
org.kuali.rice.kew.rule.bo.RuleAttribute2
org.kuali.rice.kew.rule.bo.RuleBaseValuesLookupableHelperServiceImpl2
org.kuali.rice.kew.rule.bo.RuleDelegationLookupableHelperServiceImpl2
org.kuali.rice.kew.rule.bo.RuleTemplate3
org.kuali.rice.kew.rule.bo.RuleTemplateAttribute5
org.kuali.rice.kew.rule.dao.impl.RuleDAOJpaImpl1
org.kuali.rice.kew.rule.dao.impl.RuleDAOOjbImpl1
org.kuali.rice.kew.rule.dao.impl.RuleDAOOjbImpl$11
org.kuali.rice.kew.rule.service.impl.RuleDelegationServiceImpl1
org.kuali.rice.kew.rule.service.impl.RuleServiceImpl$RuleDelegationSorter2
org.kuali.rice.kew.rule.web.RoutingReportAction4
org.kuali.rice.kew.rule.web.RoutingReportAction$RouteReportRuleTemplateContainer1
org.kuali.rice.kew.rule.web.WebRuleBaseValues2
org.kuali.rice.kew.rule.web.WebRuleResponsibility2
org.kuali.rice.kew.rule.web.WebRuleResponsibility$DelegationRulesProxy1
org.kuali.rice.kew.rule.web.WebRuleUtils1
org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute2
org.kuali.rice.kew.service.impl.KEWModuleService1
org.kuali.rice.kew.service.impl.WorkflowDocumentActionsWebServiceImpl3
org.kuali.rice.kew.service.impl.WorkflowUtilityWebServiceImpl4
org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl15
org.kuali.rice.kew.stats.web.StatsForm5
org.kuali.rice.kew.superuser.web.SuperUserAction1
org.kuali.rice.kew.superuser.web.SuperUserForm2
org.kuali.rice.kew.useroptions.UserOptions1
org.kuali.rice.kew.useroptions.UserOptionsId1
org.kuali.rice.kew.util.ByteArrayDataSource2
org.kuali.rice.kew.util.Utilities$PrioritySorter1
org.kuali.rice.kew.util.Utilities$RouteLogActionRequestSorter1
org.kuali.rice.kew.web.DummyLoginFilter1
org.kuali.rice.kew.web.FilterMapping1
org.kuali.rice.kew.web.ModuleRelativeForwardAction1
org.kuali.rice.kew.web.UserLoginFilter1
org.kuali.rice.kew.web.session.UserSession1
org.kuali.rice.kew.workgroup.BaseWorkgroupId2
org.kuali.rice.kew.workgroup.BaseWorkgroupMemberId1
org.kuali.rice.kew.xml.AbstractTransformationFilter$CurrentElement1
org.kuali.rice.kew.xml.DocumentTypeXmlParser2
org.kuali.rice.kew.xml.DocumentTypeXmlParser$DocTypeNode1
org.kuali.rice.kew.xml.DocumentTypeXmlParser$RoutePathContext1
org.kuali.rice.kew.xml.GroupXmlJAXBParser$DataNamespaceURIFilter1
org.kuali.rice.kew.xml.GroupXmlParser1
org.kuali.rice.kew.xml.HelpEntryXmlParser1
org.kuali.rice.kew.xml.RuleTemplateXmlParser3
org.kuali.rice.kew.xml.RuleXmlParser2
org.kuali.rice.kew.xml.XmlRenderer1
org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$DocumentTypeParentComparator2
org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$SplitJoinContext1
org.kuali.rice.kew.xml.export.GroupXmlExporter1
org.kuali.rice.kew.xml.export.RuleTemplateXmlExporter1
org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$SimpleNodeList1
org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$XPathSegment1
org.kuali.rice.kim.bo.entity.impl.KimEntityBioDemographicsImpl5
org.kuali.rice.kim.bo.entity.impl.KimEntityCitizenshipImpl4
org.kuali.rice.kim.bo.impl.GenericPermission1
org.kuali.rice.kim.bo.impl.PersonImpl2
org.kuali.rice.kim.bo.role.impl.KimResponsibilityImpl1
org.kuali.rice.kim.bo.ui.KimAttributeDataComparator1
org.kuali.rice.kim.bo.ui.PersonDocumentGroup1
org.kuali.rice.kim.bo.ui.PersonDocumentRole2
org.kuali.rice.kim.client.acegi.KualiCasProxyTicketValidator1
org.kuali.rice.kim.client.acegi.KualiUserDetailsServiceImpl1
org.kuali.rice.kim.dao.impl.KimRoleDaoOjb1
org.kuali.rice.kim.document.GenericPermissionMaintainable1
org.kuali.rice.kim.document.IdentityManagementKimDocument2
org.kuali.rice.kim.document.KimTypeAttributesHelper4
org.kuali.rice.kim.document.ReviewResponsibilityMaintainable2
org.kuali.rice.kim.document.rule.AttributeValidationHelper3
org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule2
org.kuali.rice.kim.document.rule.IdentityManagementRoleDocumentRule2
org.kuali.rice.kim.lookup.KimDocumentRoleMemberLookupableHelperServiceImpl2
org.kuali.rice.kim.lookup.PermissionLookupableHelperServiceImpl3
org.kuali.rice.kim.lookup.PersonLookupableHelperServiceImpl1
org.kuali.rice.kim.lookup.ResponsibilityLookupableHelperServiceImpl3
org.kuali.rice.kim.lookup.RoleLookupableHelperServiceImpl3
org.kuali.rice.kim.lookup.RoleMemberLookupableHelperServiceImpl1
org.kuali.rice.kim.rule.event.ui.AddPersonDocumentDelegationMemberQualifierEvent1
org.kuali.rice.kim.rules.ui.PersonDocumentDelegationMemberRule1
org.kuali.rice.kim.service.impl.GroupInternalServiceImpl$MembersDiff1
org.kuali.rice.kim.service.impl.IdentityManagementServiceImpl6
org.kuali.rice.kim.service.impl.KimModuleService1
org.kuali.rice.kim.service.impl.KimTypeInfoServiceImpl1
org.kuali.rice.kim.service.impl.PermissionServiceImpl1
org.kuali.rice.kim.service.impl.PermissionUpdateServiceImpl1
org.kuali.rice.kim.service.impl.PersonServiceImpl5
org.kuali.rice.kim.service.impl.RoleManagementServiceImpl2
org.kuali.rice.kim.service.impl.RoleServiceBase2
org.kuali.rice.kim.service.impl.RoleServiceImpl6
org.kuali.rice.kim.service.impl.RoleUpdateServiceImpl2
org.kuali.rice.kim.service.impl.UiDocumentServiceImpl19
org.kuali.rice.kim.service.impl.UiDocumentServiceImpl$GroupMemberNameComparator1
org.kuali.rice.kim.service.impl.UiDocumentServiceImpl$RoleMemberNameComparator1
org.kuali.rice.kim.service.support.impl.KimTypeServiceBase7
org.kuali.rice.kim.sesn.DistributedSession2
org.kuali.rice.kim.util.KualiDateMask1
org.kuali.rice.kim.web.struts.action.IdentityManagementPersonDocumentAction1
org.kuali.rice.kim.workflow.attribute.KimTypeQualifierResolver1
org.kuali.rice.kns.UserSession1
org.kuali.rice.kns.authorization.BusinessObjectAuthorizerBase1
org.kuali.rice.kns.bo.AdHocRoutePersonId1
org.kuali.rice.kns.bo.AdHocRouteRecipient2
org.kuali.rice.kns.bo.AdHocRouteRecipientId1
org.kuali.rice.kns.bo.AdHocRouteWorkgroupId1
org.kuali.rice.kns.bo.ConcurrentLockId1
org.kuali.rice.kns.bo.Namespace1
org.kuali.rice.kns.bo.ParameterDetailTypeId1
org.kuali.rice.kns.bo.ParameterId1
org.kuali.rice.kns.bo.PersistableAttachmentBase2
org.kuali.rice.kns.bo.SessionDocument2
org.kuali.rice.kns.bo.options.StateValuesFinder1
org.kuali.rice.kns.dao.impl.LookupDaoJpa7
org.kuali.rice.kns.dao.impl.LookupDaoOjb8
org.kuali.rice.kns.dao.impl.PersistenceDaoJpa2
org.kuali.rice.kns.dao.proxy.PersistenceDaoProxy1
org.kuali.rice.kns.datadictionary.DataDictionary6
org.kuali.rice.kns.datadictionary.PrimitiveAttributeDefinition1
org.kuali.rice.kns.datadictionary.control.ApcSelectControlDefinition1
org.kuali.rice.kns.datadictionary.control.ButtonControlDefinition1
org.kuali.rice.kns.datadictionary.control.CheckboxControlDefinition1
org.kuali.rice.kns.datadictionary.control.ControlDefinitionBase1
org.kuali.rice.kns.datadictionary.control.CurrencyControlDefinition1
org.kuali.rice.kns.datadictionary.control.FileControlDefinition1
org.kuali.rice.kns.datadictionary.control.HiddenControlDefinition1
org.kuali.rice.kns.datadictionary.control.KualiUserControlDefinition1
org.kuali.rice.kns.datadictionary.control.LinkControlDefinition1
org.kuali.rice.kns.datadictionary.control.LookupHiddenControlDefinition1
org.kuali.rice.kns.datadictionary.control.LookupReadonlyControlDefinition1
org.kuali.rice.kns.datadictionary.control.MultiselectControlDefinition1
org.kuali.rice.kns.datadictionary.control.RadioControlDefinition1
org.kuali.rice.kns.datadictionary.control.SelectControlDefinition1
org.kuali.rice.kns.datadictionary.control.TextControlDefinition1
org.kuali.rice.kns.datadictionary.control.TextareaControlDefinition1
org.kuali.rice.kns.datadictionary.control.WorkflowWorkgroupControlDefinition1
org.kuali.rice.kns.datadictionary.validation.CharacterLevelValidationPattern1
org.kuali.rice.kns.datadictionary.validation.charlevel.RegexValidationPattern2
org.kuali.rice.kns.document.MaintenanceDocumentBase1
org.kuali.rice.kns.document.authorization.DocumentAuthorizerBase1
org.kuali.rice.kns.document.authorization.MaintenanceDocumentAuthorizerBase1
org.kuali.rice.kns.document.authorization.MaintenanceDocumentPresentationControllerBase1
org.kuali.rice.kns.document.authorization.MaintenanceDocumentRestrictionsBase1
org.kuali.rice.kns.exception.ExceptionIncident1
org.kuali.rice.kns.inquiry.KualiInquirableImpl2
org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl5
org.kuali.rice.kns.lookup.HtmlData2
org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl3
org.kuali.rice.kns.lookup.LookupUtils12
org.kuali.rice.kns.lookup.keyvalues.ApcValuesFinder2
org.kuali.rice.kns.lookup.keyvalues.CampusTypeComparator1
org.kuali.rice.kns.lookup.keyvalues.CampusValuesFinder4
org.kuali.rice.kns.lookup.keyvalues.NamespaceComparator1
org.kuali.rice.kns.lookup.keyvalues.ParameterTypeComparator1
org.kuali.rice.kns.maintenance.KualiMaintainableImpl18
org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase4
org.kuali.rice.kns.rule.event.DocumentAuditEvent1
org.kuali.rice.kns.rules.DocumentRuleBase1
org.kuali.rice.kns.rules.PromptBeforeValidationBase2
org.kuali.rice.kns.rules.PromptBeforeValidationBase$ContextSession1
org.kuali.rice.kns.rules.PromptBeforeValidationBase$IsAskingException1
org.kuali.rice.kns.service.impl.AttachmentServiceImpl4
org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl1
org.kuali.rice.kns.service.impl.BusinessObjectMetaDataServiceImpl1
org.kuali.rice.kns.service.impl.BusinessObjectServiceImpl4
org.kuali.rice.kns.service.impl.ConfigurableDateTimeServiceImpl2
org.kuali.rice.kns.service.impl.DictionaryValidationServiceImpl1
org.kuali.rice.kns.service.impl.InactivateableFromToServiceImpl1
org.kuali.rice.kns.service.impl.InactivationBlockingDisplayServiceImpl1
org.kuali.rice.kns.service.impl.KualiExceptionIncidentServiceImpl1
org.kuali.rice.kns.service.impl.MaintenanceDocumentDictionaryServiceImpl2
org.kuali.rice.kns.service.impl.ModuleServiceBase2
org.kuali.rice.kns.service.impl.ParameterServiceBase1
org.kuali.rice.kns.service.impl.PersistenceStructureServiceJpaImpl3
org.kuali.rice.kns.service.impl.PersistenceStructureServiceOjbImpl3
org.kuali.rice.kns.service.impl.PostProcessorServiceImpl1
org.kuali.rice.kns.service.impl.SessionDocumentServiceImpl1
org.kuali.rice.kns.util.AuditError2
org.kuali.rice.kns.util.BeanPropertyComparator1
org.kuali.rice.kns.util.DateUtils2
org.kuali.rice.kns.util.ErrorMessage2
org.kuali.rice.kns.util.FieldUtils3
org.kuali.rice.kns.util.InactiveRecordsHidingUtils1
org.kuali.rice.kns.util.KNSUtils1
org.kuali.rice.kns.util.MessageMap2
org.kuali.rice.kns.util.NumberUtils1
org.kuali.rice.kns.util.ObjectUtils3
org.kuali.rice.kns.util.OjbCharBooleanConversion2
org.kuali.rice.kns.util.OjbKualiIntegerFieldConversion1
org.kuali.rice.kns.util.WebUtils6
org.kuali.rice.kns.util.cache.FastByteArrayInputStream1
org.kuali.rice.kns.util.cache.FastByteArrayOutputStream1
org.kuali.rice.kns.util.cache.ObjectCacheOSCacheImpl1
org.kuali.rice.kns.util.comparator.BeanPropertyComparator1
org.kuali.rice.kns.util.documentserializer.DocumentSerializationState$SerializationPropertyElement1
org.kuali.rice.kns.util.documentserializer.SerializationState$SerializationPropertyElement1
org.kuali.rice.kns.util.spring.AnnotationAndNameMatchingTransactionAttributeSource2
org.kuali.rice.kns.util.spring.ClassPathXmlApplicationContext1
org.kuali.rice.kns.web.EditablePropertiesHistoryHolder2
org.kuali.rice.kns.web.format.FormatException1
org.kuali.rice.kns.web.format.Formatter2
org.kuali.rice.kns.web.servlet.KualiDWRServlet2
org.kuali.rice.kns.web.servlet.PostDataLoadEncryptionServlet2
org.kuali.rice.kns.web.servlet.dwr.GlobalResourceDelegatingSpringCreator1
org.kuali.rice.kns.web.struts.action.KualiAction3
org.kuali.rice.kns.web.struts.action.KualiActionServlet1
org.kuali.rice.kns.web.struts.action.KualiActionServlet$KualiActionServletConfig1
org.kuali.rice.kns.web.struts.action.KualiDocumentActionBase2
org.kuali.rice.kns.web.struts.action.KualiExceptionHandlerAction1
org.kuali.rice.kns.web.struts.action.KualiHelpAction2
org.kuali.rice.kns.web.struts.action.KualiInquiryAction3
org.kuali.rice.kns.web.struts.action.KualiLookupAction2
org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction5
org.kuali.rice.kns.web.struts.action.KualiMultipleValueLookupAction4
org.kuali.rice.kns.web.struts.form.InquiryForm1
org.kuali.rice.kns.web.struts.form.KualiForm2
org.kuali.rice.kns.web.struts.form.KualiMaintenanceForm2
org.kuali.rice.kns.web.struts.form.LookupForm2
org.kuali.rice.kns.web.struts.form.MultipleValueLookupForm1
org.kuali.rice.kns.web.struts.pojo.ArrayUtils5
org.kuali.rice.kns.web.struts.pojo.PojoFormBase1
org.kuali.rice.kns.web.ui.Field6
org.kuali.rice.kns.web.ui.FieldBridge2
org.kuali.rice.kns.web.ui.FormatAwareDecorator1
org.kuali.rice.kns.web.ui.SectionBridge4
org.kuali.rice.kns.workflow.attribute.DataDictionaryDocumentSearchCustomizer1
org.kuali.rice.kns.workflow.attribute.DataDictionarySearchableAttribute2
org.kuali.rice.kns.workflow.attribute.KualiXmlAttributeHelper1
org.kuali.rice.kns.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl2
org.kuali.rice.kns.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl$RoutingAttributeTracker2
org.kuali.rice.ksb.cache.RiceCacheAdministratorImpl1
org.kuali.rice.ksb.cache.RiceDistributedCacheListener2
org.kuali.rice.ksb.messaging.AsynchronousCall4
org.kuali.rice.ksb.messaging.HttpException1
org.kuali.rice.ksb.messaging.MessageServiceInvoker1
org.kuali.rice.ksb.messaging.PropertyConditionalKSBExporter1
org.kuali.rice.ksb.messaging.RemotedServiceRegistryImpl3
org.kuali.rice.ksb.messaging.ServiceDefinition2
org.kuali.rice.ksb.messaging.config.KSBConfigurer$11
org.kuali.rice.ksb.messaging.dao.impl.MessageQueueDAOOjbImpl1
org.kuali.rice.ksb.messaging.exceptionhandling.DefaultMessageExceptionHandler2
org.kuali.rice.ksb.messaging.quartz.KSBSchedulerFactoryBean2
org.kuali.rice.ksb.messaging.quartz.QuartzConfigPropertiesFactoryBean1
org.kuali.rice.ksb.messaging.service.impl.MessageQueueServiceImpl2
org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector3
org.kuali.rice.ksb.messaging.serviceexporters.RESTServiceExporter1
org.kuali.rice.ksb.messaging.serviceproxies.MessageSender1
org.kuali.rice.ksb.messaging.serviceproxies.MessageSendingTransactionSynchronization2
org.kuali.rice.ksb.messaging.serviceproxies.SynchronousServiceCallProxy1
org.kuali.rice.ksb.messaging.servlet.CXFServletControllerAdapter1
org.kuali.rice.ksb.messaging.threadpool.PriorityBlockingQueuePersistedMessageComparator1
org.kuali.rice.ksb.messaging.web.MessageQueueAction2
org.kuali.rice.ksb.messaging.web.ThreadPoolForm1
org.kuali.rice.ksb.security.SignatureVerifyingInputStream1
org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer3
org.kuali.rice.ksb.security.admin.service.impl.JavaSecurityManagementServiceImpl3
org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction4
org.kuali.rice.ksb.util.KSBConstants1
org.kuali.rice.ksb.util.KSBConstants$Config1
org.kuali.rice.ksb.util.KSBConstants$ServiceNames1
org.kuali.rice.test.BaselineTestCase2
org.kuali.rice.test.BaselineTestCase$11
org.kuali.rice.test.ClearDatabaseLifecycle$11
org.kuali.rice.test.JettyServerTestCase1
org.kuali.rice.test.RiceInternalSuiteDataTestCase1
org.kuali.rice.test.RiceTestCase3
org.kuali.rice.test.SQLDataLoader1
org.kuali.rice.test.SQLDataLoader$1$11
org.kuali.rice.test.runners.RiceUnitTestClassRunner1

org.apache.commons.httpclient.contrib.ssl.EasySSLProtocolSocketFactory

BugCategoryDetailsLinePriority
org.apache.commons.httpclient.contrib.ssl.EasySSLProtocolSocketFactory.equals(Object) fails for subtypesBAD_PRACTICEEQ_GETCLASS_AND_CLASS_CONSTANT221Medium

org.apache.ojb.broker.platforms.KualiMySQLSequenceManagerImpl

BugCategoryDetailsLinePriority

org.kuali.rice.core.config.AbstractBaseConfig

BugCategoryDetailsLinePriority
org.kuali.rice.core.config.AbstractBaseConfig.getBatchMode() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR78Medium

org.kuali.rice.core.config.BaseConfig

BugCategoryDetailsLinePriority
org.kuali.rice.core.config.BaseConfig.getBatchMode() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR326Medium

org.kuali.rice.core.config.ConfigLogger

BugCategoryDetailsLinePriority
Method org.kuali.rice.core.config.ConfigLogger.logConfig(Config) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION57Medium

org.kuali.rice.core.config.HierarchicalConfigParser

BugCategoryDetailsLinePriority
org.kuali.rice.core.config.HierarchicalConfigParser.parse(String, Map, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR125Medium

org.kuali.rice.core.config.JAXBConfigImpl$ConfigNamespaceURIFilter

BugCategoryDetailsLinePriority
Should org.kuali.rice.core.config.JAXBConfigImpl$ConfigNamespaceURIFilter be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC574Medium

org.kuali.rice.core.config.RiceConfigurer

BugCategoryDetailsLinePriority
Write to static field org.kuali.rice.kns.web.servlet.dwr.GlobalResourceDelegatingSpringCreator.APPLICATION_BEAN_FACTORY from instance method org.kuali.rice.core.config.RiceConfigurer.loadLifecycles()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD129Medium

org.kuali.rice.core.config.RiceConfigurerBase

BugCategoryDetailsLinePriority
Method org.kuali.rice.core.config.RiceConfigurerBase.loadSpringContext() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION146Medium

org.kuali.rice.core.config.SimpleNodeSettingsStore

BugCategoryDetailsLinePriority
Inconsistent synchronization of org.kuali.rice.core.config.SimpleNodeSettingsStore.properties; locked 77% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC54Medium
org.kuali.rice.core.config.SimpleNodeSettingsStore.load() ignores exceptional return value of java.io.File.createNewFile()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE67Medium
org.kuali.rice.core.config.SimpleNodeSettingsStore.load() ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE65Medium

org.kuali.rice.core.config.logging.Log4jLifeCycle$WorkflowLog4j_1_2_13_PropertyConfigurator

BugCategoryDetailsLinePriority

org.kuali.rice.core.config.spring.ConfigFactoryBean

BugCategoryDetailsLinePriority
Dead store to baseProperties in org.kuali.rice.core.config.spring.ConfigFactoryBean.getObject()STYLEDLS_DEAD_LOCAL_STORE40High
org.kuali.rice.core.config.spring.ConfigFactoryBean.CONFIG_OVERRIDE_LOCATION isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINALHigh

org.kuali.rice.core.database.PreparedStatementCachingConnection

BugCategoryDetailsLinePriority
org.kuali.rice.core.database.PreparedStatementCachingConnection doesn't override org.apache.commons.dbcp.DelegatingConnection.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS36Medium

org.kuali.rice.core.database.platform.MySQLDatabasePlatform

BugCategoryDetailsLinePriority
Method org.kuali.rice.core.database.platform.MySQLDatabasePlatform.getNextValSQL(String, EntityManager) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR96Medium
Method org.kuali.rice.core.database.platform.MySQLDatabasePlatform.getNextValSQL(String, PersistenceBroker) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR70Medium
org.kuali.rice.core.database.platform.MySQLDatabasePlatform.getNextValSQL(String, PersistenceBroker) may fail to close PreparedStatementBAD_PRACTICEODR_OPEN_DATABASE_RESOURCE62Medium

org.kuali.rice.core.database.platform.OracleDatabasePlatform

BugCategoryDetailsLinePriority
Method org.kuali.rice.core.database.platform.OracleDatabasePlatform.getNextValSQL(String, EntityManager) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR68Medium
Method org.kuali.rice.core.database.platform.OracleDatabasePlatform.getNextValSQL(String, PersistenceBroker) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR83Medium

org.kuali.rice.core.jdbc.PreparedObject

BugCategoryDetailsLinePriority
new org.kuali.rice.core.jdbc.PreparedObject() invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR29Medium
org.kuali.rice.core.jdbc.PreparedObject.append(PreparedObject) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR59Medium

org.kuali.rice.core.jdbc.SqlBuilder

BugCategoryDetailsLinePriority
Dead store to bd in org.kuali.rice.core.jdbc.SqlBuilder.isValidNumber(String)STYLEDLS_DEAD_LOCAL_STORE289Medium
Comparison of String parameter using == or != in org.kuali.rice.core.jdbc.SqlBuilder.addLogicalOperatorCriteria(String, String, Class, boolean, Criteria, String, boolean) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ213Medium

org.kuali.rice.core.jdbc.criteria.Criteria

BugCategoryDetailsLinePriority
Method org.kuali.rice.core.jdbc.criteria.Criteria.getParameteres(List, Map) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR388Medium
Method org.kuali.rice.core.jdbc.criteria.Criteria.prepareParameters(Query, List, Map) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR408Medium
Method org.kuali.rice.core.jdbc.criteria.Criteria.buildWhere(Criteria) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION364Medium
Method org.kuali.rice.core.jdbc.criteria.Criteria.in(String, List, Class) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION269Medium
Method org.kuali.rice.core.jdbc.criteria.Criteria.notIn(String, List, Class) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION280Medium
Method org.kuali.rice.core.jdbc.criteria.Criteria.toQuery(QueryByCriteria$QueryByCriteriaType) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION324Medium

org.kuali.rice.core.jdbc.criteria.Criteria$AndCriteria

BugCategoryDetailsLinePriority
Should org.kuali.rice.core.jdbc.criteria.Criteria$AndCriteria be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC424Medium

org.kuali.rice.core.jdbc.criteria.Criteria$OrCriteria

BugCategoryDetailsLinePriority
Should org.kuali.rice.core.jdbc.criteria.Criteria$OrCriteria be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC432Medium

org.kuali.rice.core.jpa.criteria.Criteria

BugCategoryDetailsLinePriority
Method org.kuali.rice.core.jpa.criteria.Criteria.prepareParameters(Query, List, Map) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR255Medium
Method org.kuali.rice.core.jpa.criteria.Criteria.buildWhere() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION238Medium
Method org.kuali.rice.core.jpa.criteria.Criteria.in(String, List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION147Medium
Method org.kuali.rice.core.jpa.criteria.Criteria.notIn(String, List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION158Medium
Method org.kuali.rice.core.jpa.criteria.Criteria.toQuery(QueryByCriteria$QueryByCriteriaType) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION202Medium

org.kuali.rice.core.jpa.criteria.Criteria$AndCriteria

BugCategoryDetailsLinePriority
Should org.kuali.rice.core.jpa.criteria.Criteria$AndCriteria be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC271Medium

org.kuali.rice.core.jpa.criteria.Criteria$OrCriteria

BugCategoryDetailsLinePriority
Should org.kuali.rice.core.jpa.criteria.Criteria$OrCriteria be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC279Medium

org.kuali.rice.core.jpa.dialect.MySQLDialect

BugCategoryDetailsLinePriority

org.kuali.rice.core.jpa.metadata.CollectionDescriptor

BugCategoryDetailsLinePriority
org.kuali.rice.core.jpa.metadata.CollectionDescriptor.getCascade() may expose internal representation by returning CollectionDescriptor.cascadeMALICIOUS_CODEEI_EXPOSE_REP84Medium
org.kuali.rice.core.jpa.metadata.CollectionDescriptor.setCascade(CascadeType[]) may expose internal representation by storing an externally mutable object into CollectionDescriptor.cascadeMALICIOUS_CODEEI_EXPOSE_REP288Medium

org.kuali.rice.core.jpa.metadata.EntityDescriptor

BugCategoryDetailsLinePriority
Class org.kuali.rice.core.jpa.metadata.EntityDescriptor defines non-transient non-serializable instance field sequenceBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.core.jpa.metadata.FieldDescriptor

BugCategoryDetailsLinePriority
org.kuali.rice.core.jpa.metadata.FieldDescriptor defines compareTo(Object) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS198Medium

org.kuali.rice.core.jpa.metadata.MetadataManager

BugCategoryDetailsLinePriority

org.kuali.rice.core.jpa.metadata.ObjectDescriptor

BugCategoryDetailsLinePriority
org.kuali.rice.core.jpa.metadata.ObjectDescriptor.getCascade() may expose internal representation by returning ObjectDescriptor.cascadeMALICIOUS_CODEEI_EXPOSE_REP68Medium
org.kuali.rice.core.jpa.metadata.ObjectDescriptor.setCascade(CascadeType[]) may expose internal representation by storing an externally mutable object into ObjectDescriptor.cascadeMALICIOUS_CODEEI_EXPOSE_REP272Medium

org.kuali.rice.core.jpa.spring.RiceLocalContainerEntityManagerFactoryBean

BugCategoryDetailsLinePriority
org.kuali.rice.core.jpa.spring.RiceLocalContainerEntityManagerFactoryBean.prepareJpaVendorAdapter(Config, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR77Medium

org.kuali.rice.core.ojb.BaseOjbConfigurer

BugCategoryDetailsLinePriority
new org.kuali.rice.core.ojb.BaseOjbConfigurer(String[], String) may expose internal representation by storing an externally mutable object into BaseOjbConfigurer.jcdAliasesMALICIOUS_CODEEI_EXPOSE_REP2102Medium
org.kuali.rice.core.ojb.BaseOjbConfigurer.setJcdAliases(String[]) may expose internal representation by storing an externally mutable object into BaseOjbConfigurer.jcdAliasesMALICIOUS_CODEEI_EXPOSE_REP2255Medium

org.kuali.rice.core.ojb.ContextClassLoaderSetProxy

BugCategoryDetailsLinePriority
Class org.kuali.rice.core.ojb.ContextClassLoaderSetProxy defines non-transient non-serializable instance field contextClassLoaderBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.core.ojb.TransactionManagerFactory

BugCategoryDetailsLinePriority

org.kuali.rice.core.proxy.BaseInvocationHandler

BugCategoryDetailsLinePriority
Method org.kuali.rice.core.proxy.BaseInvocationHandler.proxyHashCode(Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR68Medium

org.kuali.rice.core.resourceloader.SimpleServiceLocator

BugCategoryDetailsLinePriority
Method org.kuali.rice.core.resourceloader.SimpleServiceLocator.getContents(String, boolean) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION45Medium

org.kuali.rice.core.resourceloader.SpringLoader

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.core.resourceloader.SpringLoader.close(), since all org.springframework.context.support.ClassPathXmlApplicationContext are instances of org.springframework.context.ConfigurableApplicationContextSTYLEBC_VACUOUS_INSTANCEOF170Medium
Method org.kuali.rice.core.resourceloader.SpringLoader.getContents(String, boolean) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION195Medium
Write to static field org.kuali.rice.core.resourceloader.SpringLoader.suppressedServices from instance method org.kuali.rice.core.resourceloader.SpringLoader.close()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD175High

org.kuali.rice.core.resourceloader.SpringResourceLoader

BugCategoryDetailsLinePriority
new org.kuali.rice.core.resourceloader.SpringResourceLoader(QName, String[]) may expose internal representation by storing an externally mutable object into SpringResourceLoader.fileLocsMALICIOUS_CODEEI_EXPOSE_REP252Medium

org.kuali.rice.core.service.impl.DemonstrationGradeEncryptionServiceImpl

BugCategoryDetailsLinePriority
Uninitialized read of desKey in new org.kuali.rice.core.service.impl.DemonstrationGradeEncryptionServiceImpl()CORRECTNESSUR_UNINIT_READ50Medium

org.kuali.rice.core.service.impl.NoEncryptionEncryptionServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.core.service.impl.NoEncryptionEncryptionServiceImpl.decrypt(String) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR51Medium

org.kuali.rice.core.util.GRLServiceInjectionPostProcessor$AnnotatedMember

BugCategoryDetailsLinePriority
Should org.kuali.rice.core.util.GRLServiceInjectionPostProcessor$AnnotatedMember be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC152Medium

org.kuali.rice.core.util.ImmutableProperties

BugCategoryDetailsLinePriority
Method new org.kuali.rice.core.util.ImmutableProperties(Properties) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR37Medium

org.kuali.rice.core.util.KeyValue

BugCategoryDetailsLinePriority
org.kuali.rice.core.util.KeyValue defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE56High

org.kuali.rice.core.util.OrmUtils

BugCategoryDetailsLinePriority
org.kuali.rice.core.util.OrmUtils.isJpaAnnotated(Class) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR131Medium

org.kuali.rice.core.web.jetty.JettyServer

BugCategoryDetailsLinePriority
org.kuali.rice.core.web.jetty.JettyServer.createServer() ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE123Medium

org.kuali.rice.core.web.listener.StandaloneInitializeListener

BugCategoryDetailsLinePriority
org.kuali.rice.core.web.listener.StandaloneInitializeListener.shouldExecuteMessageFetcher() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR211Medium

org.kuali.rice.kcb.quartz.MessageDeletionListener

BugCategoryDetailsLinePriority
Dead store to mode in org.kuali.rice.kcb.quartz.MessageDeletionListener.jobWasExecuted(JobExecutionContext, JobExecutionException)STYLEDLS_DEAD_LOCAL_STORE73Medium

org.kuali.rice.ken.bo.NotificationChannel

BugCategoryDetailsLinePriority
Equals method for org.kuali.rice.ken.bo.NotificationChannel assumes the argument is of type NotificationChannelBAD_PRACTICEBC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS250Medium
org.kuali.rice.ken.bo.NotificationChannel defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE250High
org.kuali.rice.ken.bo.NotificationChannel.equals(Object) does not check for null argumentBAD_PRACTICENP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT250High

org.kuali.rice.ken.service.impl.KENAPIServiceImpl

BugCategoryDetailsLinePriority
Unread field: org.kuali.rice.ken.service.impl.KENAPIServiceImpl.prefsServicePERFORMANCEURF_UNREAD_FIELD51Medium

org.kuali.rice.ken.service.impl.NotificationChannelServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.ken.service.impl.NotificationChannelServiceImpl.getAllNotificationChannels() invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR76Medium
org.kuali.rice.ken.service.impl.NotificationChannelServiceImpl.getSubscribableChannels() invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR67Medium

org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of d in org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl.parseSerializedNotificationXml(byte[]) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION567Medium
Possible null pointer dereference of d2 in org.kuali.rice.ken.service.impl.NotificationMessageContentServiceImpl.parseSerializedNotificationXml(byte[]) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION577Medium

org.kuali.rice.ken.service.impl.NotificationMessageDeliveryAutoRemovalServiceImpl

BugCategoryDetailsLinePriority
Dead store to firstMessageDelivery in org.kuali.rice.ken.service.impl.NotificationMessageDeliveryAutoRemovalServiceImpl.processWorkItems(Collection)STYLEDLS_DEAD_LOCAL_STORE70Medium

org.kuali.rice.ken.util.OjbCharBooleanConversion

BugCategoryDetailsLinePriority
Redundant nullcheck of source, which is known to be non-null in org.kuali.rice.ken.util.OjbCharBooleanConversion.javaToSql(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE33Medium
Redundant nullcheck of source, which is known to be non-null in org.kuali.rice.ken.util.OjbCharBooleanConversion.sqlToJava(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE60Medium

org.kuali.rice.ken.util.Util

BugCategoryDetailsLinePriority
Primitive value is boxed and then immediately unboxed in org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED396Medium
org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR396Medium
Method org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR412Medium
Method org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR382Medium
org.kuali.rice.ken.util.Util.cloneNotificationWithoutObjectReferences(Notification) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR379Medium
org.kuali.rice.ken.util.Util.transformContent(Notification) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR199Medium

org.kuali.rice.ken.web.spring.AdministerNotificationRequestController

BugCategoryDetailsLinePriority
Method org.kuali.rice.ken.web.spring.AdministerNotificationRequestController.view(HttpServletRequest, HttpServletResponse, AdministerNotificationRequestController$AdministerNotificationRequestCommand) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR185Medium

org.kuali.rice.ken.web.spring.ContentTypeController

BugCategoryDetailsLinePriority
org.kuali.rice.ken.web.spring.ContentTypeController.displayContentTypeForm(HttpServletRequest, HttpServletResponse) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR121Medium
Write to static field org.kuali.rice.ken.web.spring.ContentTypeController.view from instance method org.kuali.rice.ken.web.spring.ContentTypeController.addContentType(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD143High
Write to static field org.kuali.rice.ken.web.spring.ContentTypeController.view from instance method org.kuali.rice.ken.web.spring.ContentTypeController.displayContentTypeForm(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD114High
Write to static field org.kuali.rice.ken.web.spring.ContentTypeController.view from instance method org.kuali.rice.ken.web.spring.ContentTypeController.displayContentTypes(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD96High
Write to static field org.kuali.rice.ken.web.spring.ContentTypeController.view from instance method org.kuali.rice.ken.web.spring.ContentTypeController.updateContentType(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD182High

org.kuali.rice.ken.web.spring.UserPreferencesController

BugCategoryDetailsLinePriority
Write to static field org.kuali.rice.ken.web.spring.UserPreferencesController.view from instance method org.kuali.rice.ken.web.spring.UserPreferencesController.displayActionListPreferences(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD87High
Write to static field org.kuali.rice.ken.web.spring.UserPreferencesController.view from instance method org.kuali.rice.ken.web.spring.UserPreferencesController.displayUserPreferences(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD103High
Write to static field org.kuali.rice.ken.web.spring.UserPreferencesController.view from instance method org.kuali.rice.ken.web.spring.UserPreferencesController.subscribeToChannel(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD135High
Write to static field org.kuali.rice.ken.web.spring.UserPreferencesController.view from instance method org.kuali.rice.ken.web.spring.UserPreferencesController.unsubscribeFromChannel(HttpServletRequest, HttpServletResponse)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD176High

org.kuali.rice.kew.actionitem.ActionItem

BugCategoryDetailsLinePriority
Method new org.kuali.rice.kew.actionitem.ActionItem() invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR103Medium

org.kuali.rice.kew.actionitem.ActionItemComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actionitem.ActionItemComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE29Medium

org.kuali.rice.kew.actionlist.ActionListFilter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actionlist.ActionListFilter.getCreateDateFrom() may expose internal representation by returning ActionListFilter.createDateFromMALICIOUS_CODEEI_EXPOSE_REP69Medium
org.kuali.rice.kew.actionlist.ActionListFilter.getCreateDateTo() may expose internal representation by returning ActionListFilter.createDateToMALICIOUS_CODEEI_EXPOSE_REP149Medium
org.kuali.rice.kew.actionlist.ActionListFilter.getLastAssignedDateFrom() may expose internal representation by returning ActionListFilter.lastAssignedDateFromMALICIOUS_CODEEI_EXPOSE_REP155Medium
org.kuali.rice.kew.actionlist.ActionListFilter.getLastAssignedDateTo() may expose internal representation by returning ActionListFilter.lastAssignedDateToMALICIOUS_CODEEI_EXPOSE_REP135Medium
org.kuali.rice.kew.actionlist.ActionListFilter.setCreateDateFrom(Date) may expose internal representation by storing an externally mutable object into ActionListFilter.createDateFromMALICIOUS_CODEEI_EXPOSE_REP272Medium
org.kuali.rice.kew.actionlist.ActionListFilter.setCreateDateTo(Date) may expose internal representation by storing an externally mutable object into ActionListFilter.createDateToMALICIOUS_CODEEI_EXPOSE_REP2152Medium
org.kuali.rice.kew.actionlist.ActionListFilter.setLastAssignedDateFrom(Date) may expose internal representation by storing an externally mutable object into ActionListFilter.lastAssignedDateFromMALICIOUS_CODEEI_EXPOSE_REP2158Medium
org.kuali.rice.kew.actionlist.ActionListFilter.setLastAssignedDateTo(Date) may expose internal representation by storing an externally mutable object into ActionListFilter.lastAssignedDateToMALICIOUS_CODEEI_EXPOSE_REP2138Medium

org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImpl

BugCategoryDetailsLinePriority
Dead store to filterDescription in org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOJpaImpl.addToFilterDescription(String, String)STYLEDLS_DEAD_LOCAL_STORE436High

org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOOjbImpl

BugCategoryDetailsLinePriority
Dead store to filterDescription in org.kuali.rice.kew.actionlist.dao.impl.ActionListDAOOjbImpl.addToFilterDescription(String, String)STYLEDLS_DEAD_LOCAL_STORE550High

org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of docType in org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl.validateActionItem(ActionItem)CORRECTNESSNP_NULL_ON_SOME_PATH262Medium
Possible null pointer dereference of docType in org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl.validateActionItem(ActionItem)CORRECTNESSNP_NULL_ON_SOME_PATH262Medium
Possible null pointer dereference of docType in org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl.validateActionItem(ActionItem)CORRECTNESSNP_NULL_ON_SOME_PATH262Medium
Nullcheck of docType at line 266 of value previously dereferenced in org.kuali.rice.kew.actionlist.service.impl.ActionListServiceImpl.validateActionItem(ActionItem)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE262Medium

org.kuali.rice.kew.actionlist.web.ActionListAction$ActionItemComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actionlist.web.ActionListAction$ActionItemComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE782Medium

org.kuali.rice.kew.actionlist.web.ActionListForm

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actionlist.web.ActionListForm.getOutboxItems() may expose internal representation by returning ActionListForm.outboxItemsMALICIOUS_CODEEI_EXPOSE_REP282Medium
org.kuali.rice.kew.actionlist.web.ActionListForm.setOutboxItems(String[]) may expose internal representation by storing an externally mutable object into ActionListForm.outboxItemsMALICIOUS_CODEEI_EXPOSE_REP2286Medium

org.kuali.rice.kew.actionrequest.ActionRequestFactory

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.actionrequest.ActionRequestFactory.addRoleResponsibilityRequest(List, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR388Medium

org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl

BugCategoryDetailsLinePriority
Questionable cast from Collection to abstract class java.util.List in org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl.findAllValidRequests(String, Collection, String)STYLEBC_BAD_CAST_TO_ABSTRACT_COLLECTION521High
Dead store to matchedArs in org.kuali.rice.kew.actionrequest.service.impl.ActionRequestServiceImpl.findAllValidRequests(String, Collection, String)STYLEDLS_DEAD_LOCAL_STORE519High

org.kuali.rice.kew.actions.DisapproveAction

BugCategoryDetailsLinePriority
Nullcheck of systemUserWorkgroup at line 181 of value previously dereferenced in org.kuali.rice.kew.actions.DisapproveAction.generateNotifications(RouteNodeInstance)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE181Medium

org.kuali.rice.kew.actions.LogDocumentActionAction

BugCategoryDetailsLinePriority
Dead store to actionTaken in org.kuali.rice.kew.actions.LogDocumentActionAction.recordAction()STYLEDLS_DEAD_LOCAL_STORE80Medium

org.kuali.rice.kew.actions.SuperUserActionTakenEvent

BugCategoryDetailsLinePriority
org.kuali.rice.kew.actions.SuperUserActionTakenEvent.AUTHORIZATION isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL48High

org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOJpaImpl

BugCategoryDetailsLinePriority
Impossible cast from org.kuali.rice.core.jpa.criteria.QueryByCriteria to java.util.List in org.kuali.rice.kew.actiontaken.dao.impl.ActionTakenDAOJpaImpl.findByRouteHeaderIdIgnoreCurrentInd(Long)CORRECTNESSBC_IMPOSSIBLE_CAST94High

org.kuali.rice.kew.attribute.XMLAttributeUtils

BugCategoryDetailsLinePriority
Call to equals() comparing unrelated class and interface in org.kuali.rice.kew.attribute.XMLAttributeUtils.establishFieldLookup(Field, Node)CORRECTNESSEC_UNRELATED_CLASS_AND_INTERFACE44High
Call to equals() comparing unrelated class and interface in org.kuali.rice.kew.attribute.XMLAttributeUtils.establishFieldLookup(Field, Node)CORRECTNESSEC_UNRELATED_CLASS_AND_INTERFACE41High

org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Impossible downcast of toArray() result to String[] in org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl.setRowsAfterClear(DocSearchCriteriaDTO, Map)CORRECTNESSBC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY616High
Possible null pointer dereference of criteria in org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl.performCustomAction(boolean)CORRECTNESSNP_NULL_ON_SOME_PATH1062Medium
Class org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl defines non-transient non-serializable instance field dateTimeServiceBAD_PRACTICESE_BAD_FIELDMedium
Class org.kuali.rice.kew.bo.lookup.DocSearchCriteriaDTOLookupableHelperServiceImpl defines non-transient non-serializable instance field processorBAD_PRACTICESE_BAD_FIELDMedium
org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter stored into non-transient field DocSearchCriteriaDTOLookupableHelperServiceImpl.processorBAD_PRACTICESE_BAD_FIELD_STORE475Medium
org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter stored into non-transient field DocSearchCriteriaDTOLookupableHelperServiceImpl.processorBAD_PRACTICESE_BAD_FIELD_STORE554Medium

org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
instanceof will always return false in org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean), since a String can't be a BooleanCORRECTNESSBC_IMPOSSIBLE_INSTANCEOF201Medium
instanceof will always return false in org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean), since a String can't be a java.sql.DateCORRECTNESSBC_IMPOSSIBLE_INSTANCEOF207Medium
instanceof will always return false in org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean), since a String can't be a java.util.CollectionCORRECTNESSBC_IMPOSSIBLE_INSTANCEOF213Medium
Dead store to pkNames in org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean)STYLEDLS_DEAD_LOCAL_STORE136Medium
Dead store to returnKeys in org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean)STYLEDLS_DEAD_LOCAL_STORE135Medium
Dead store to user in org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean)STYLEDLS_DEAD_LOCAL_STORE137Medium
Class org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl defines non-transient non-serializable instance field dateTimeServiceBAD_PRACTICESE_BAD_FIELDMedium
Class org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl defines non-transient non-serializable instance field processorBAD_PRACTICESE_BAD_FIELDMedium
org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter stored into non-transient field DocumentRouteHeaderValueLookupableHelperServiceImpl.processorBAD_PRACTICESE_BAD_FIELD_STORE370Medium
Method org.kuali.rice.kew.bo.lookup.DocumentRouteHeaderValueLookupableHelperServiceImpl.constructCriteria(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR289Medium

org.kuali.rice.kew.config.ThinClientResourceLoader

BugCategoryDetailsLinePriority
org.kuali.rice.kew.config.ThinClientResourceLoader.configureDefaultHttpClientParams(HttpParams) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR233Medium
Method org.kuali.rice.kew.config.ThinClientResourceLoader.initializeHttpClientParams() makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR199Medium

org.kuali.rice.kew.docsearch.DocSearchUtils

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kew.docsearch.DocSearchUtils.addSearchableAttributesToCriteria(DocSearchCriteriaDTO, List, String, boolean), since all org.kuali.rice.kns.web.ui.Field are instances of org.kuali.rice.kns.web.ui.FieldSTYLEBC_VACUOUS_INSTANCEOF519Medium
instanceof will always return true in org.kuali.rice.kew.docsearch.DocSearchUtils.buildSearchableAttributesFromString(String, String), since all org.kuali.rice.kns.web.ui.Field are instances of org.kuali.rice.kns.web.ui.FieldSTYLEBC_VACUOUS_INSTANCEOF344Medium

org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder.addSearchableAttributesToCriteria(DocSearchCriteriaDTO, Map), since all org.kuali.rice.kns.web.ui.Field are instances of org.kuali.rice.kns.web.ui.FieldSTYLEBC_VACUOUS_INSTANCEOF107Medium
Method org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder.populateCriteria(Map) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION59Medium
Method org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder.addSearchableAttributesToCriteria(DocSearchCriteriaDTO, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR139Medium
Method org.kuali.rice.kew.docsearch.DocumentLookupCriteriaBuilder.populateCriteria(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR48Medium

org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter

BugCategoryDetailsLinePriority
Dead store to searchAttRows in org.kuali.rice.kew.docsearch.DocumentLookupCriteriaProcessorKEWAdapter.getRows(DocumentType, List, boolean, boolean)STYLEDLS_DEAD_LOCAL_STORE69Medium

org.kuali.rice.kew.docsearch.SearchableAttributeDateTimeValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.SearchableAttributeDateTimeValue.isRangeValid(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL211Medium

org.kuali.rice.kew.docsearch.SearchableAttributeFloatValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.SearchableAttributeFloatValue.isRangeValid(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL236Medium

org.kuali.rice.kew.docsearch.SearchableAttributeLongValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.SearchableAttributeLongValue.isRangeValid(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL229Medium

org.kuali.rice.kew.docsearch.SearchableAttributeStringValue

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.SearchableAttributeStringValue.isRangeValid(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL165Medium

org.kuali.rice.kew.docsearch.StandardDocumentSearchCriteriaProcessor

BugCategoryDetailsLinePriority
Self assignment of field StandardDocumentSearchCriteriaProcessor.searchingUser in org.kuali.rice.kew.docsearch.StandardDocumentSearchCriteriaProcessor.setSearchingUser(String)CORRECTNESSSA_FIELD_SELF_ASSIGNMENT49High

org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator

BugCategoryDetailsLinePriority
Dead store to queryTableColumnName in org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.generateSearchableAttributeSql(SearchAttributeCriteriaComponent, String, int)STYLEDLS_DEAD_LOCAL_STORE648Medium
Method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.processRow(Statement, ResultSet) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR1085Medium
Method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.getDocRouteStatusSql(String, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION1687Medium
Method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.getViewerSql(String, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION1506Medium
Write to static field org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.searchableAttributes from instance method new org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD103High
Write to static field org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.searchableAttributes from instance method new org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator(List)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD111High
Write to static field org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.criteria from instance method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.setCriteria(DocSearchCriteriaDTO)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD119High
Write to static field org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.searchableAttributes from instance method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.setSearchableAttributes(List)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD127High
Write to static field org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.searchingUser from instance method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.setSearchingUser(String)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD135High
Method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.combineAndFormatSearchableComponents(List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR459Medium
Method org.kuali.rice.kew.docsearch.StandardDocumentSearchGenerator.getSearchableAttributeSql(List, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR630Medium

org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor.addSearchableAttributeColumnsBasedOnFields(List, DocSearchCriteriaDTO, List), since all org.kuali.rice.kns.web.ui.Field are instances of org.kuali.rice.kns.web.ui.FieldSTYLEBC_VACUOUS_INSTANCEOF285Medium
instanceof will always return true in org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor.getFields(DocSearchCriteriaDTO, List), since all org.kuali.rice.kns.web.ui.Field are instances of org.kuali.rice.kns.web.ui.FieldSTYLEBC_VACUOUS_INSTANCEOF382Medium
instanceof will always return true in org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor.setUpCustomDisplayColumns(DocSearchCriteriaDTO, List), since all org.kuali.rice.kns.web.ui.Column are instances of org.kuali.rice.kns.web.ui.ColumnSTYLEBC_VACUOUS_INSTANCEOF95Medium
instanceof will always return true in org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor.setUpCustomDisplayColumns(DocSearchCriteriaDTO, List), since all org.kuali.rice.kns.web.ui.Field are instances of org.kuali.rice.kns.web.ui.FieldSTYLEBC_VACUOUS_INSTANCEOF98Medium
Dead store to sortable in org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor.constructColumnUsingKey(String, String, Boolean)STYLEDLS_DEAD_LOCAL_STORE741High
org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor.addCustomColumn(List, Column) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR338Medium

org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor$DisplayValues

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.docsearch.StandardDocumentSearchResultProcessor$DisplayValues be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC417Medium

org.kuali.rice.kew.docsearch.dao.impl.DocumentSearchDAOOjbImpl

BugCategoryDetailsLinePriority
Dead store to docList in org.kuali.rice.kew.docsearch.dao.impl.DocumentSearchDAOOjbImpl.getList(DocumentSearchGenerator, DocSearchCriteriaDTO, Integer, String)STYLEDLS_DEAD_LOCAL_STORE68Medium
Dead store to documentSecurityService in org.kuali.rice.kew.docsearch.dao.impl.DocumentSearchDAOOjbImpl.getList(DocumentSearchGenerator, DocSearchCriteriaDTO, Integer, String)STYLEDLS_DEAD_LOCAL_STORE67Medium

org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl

BugCategoryDetailsLinePriority
Dead store to pList in org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl.validatePersonByName(String)STYLEDLS_DEAD_LOCAL_STORE380Medium
Method org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl.saveSearch(String, DocSearchCriteriaDTO) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION542Medium
Private method org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl.validateNetworkId(List) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD352Medium
Private method org.kuali.rice.kew.docsearch.service.impl.DocumentSearchServiceImpl.validateNumber(List) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD402Medium

org.kuali.rice.kew.docsearch.web.SearchAttributeFormContainer

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.web.SearchAttributeFormContainer.getValues() may expose internal representation by returning SearchAttributeFormContainer.valuesMALICIOUS_CODEEI_EXPOSE_REP100Medium
new org.kuali.rice.kew.docsearch.web.SearchAttributeFormContainer(String, String[]) may expose internal representation by storing an externally mutable object into SearchAttributeFormContainer.valuesMALICIOUS_CODEEI_EXPOSE_REP245Medium
org.kuali.rice.kew.docsearch.web.SearchAttributeFormContainer.setValues(String[]) may expose internal representation by storing an externally mutable object into SearchAttributeFormContainer.valuesMALICIOUS_CODEEI_EXPOSE_REP2104Medium

org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute

BugCategoryDetailsLinePriority
org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute.getBooleanValue(NamedNodeMap, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL558Medium
org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute.getBooleanWithPotentialOverrides(ArrayList, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL550Medium
Method org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute.getSearchContent(DocumentSearchContext) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION88Medium
Private method org.kuali.rice.kew.docsearch.xml.StandardGenericXMLSearchableAttribute.getBooleanWithPotentialOverrides(String, NamedNodeMap, NamedNodeMap, NamedNodeMap) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD533Medium

org.kuali.rice.kew.doctype.DocumentTypeAttribute

BugCategoryDetailsLinePriority
org.kuali.rice.kew.doctype.DocumentTypeAttribute defines compareTo(Object) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS153Medium

org.kuali.rice.kew.doctype.DocumentTypeLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.doctype.DocumentTypeLookupableHelperServiceImpl.loadDocumentTypeForSearch(Map) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR106Medium

org.kuali.rice.kew.doctype.DocumentTypePolicy

BugCategoryDetailsLinePriority
org.kuali.rice.kew.doctype.DocumentTypePolicy.copy(boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR155Medium
Method org.kuali.rice.kew.doctype.DocumentTypePolicy.copy(boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR148Medium
org.kuali.rice.kew.doctype.DocumentTypePolicy.copy(boolean) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR151Medium

org.kuali.rice.kew.doctype.DocumentTypeSecurity

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in new org.kuali.rice.kew.doctype.DocumentTypeSecurity(String, String)STYLEREC_CATCH_EXCEPTION225Medium

org.kuali.rice.kew.doctype.bo.DocumentType

BugCategoryDetailsLinePriority
Method new org.kuali.rice.kew.doctype.bo.DocumentType() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR116Medium

org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOJpaImpl

BugCategoryDetailsLinePriority
Dead store to docType in org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOJpaImpl.delete(DocumentType)STYLEDLS_DEAD_LOCAL_STORE62Medium

org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOOjbImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOOjbImpl.findDocumentTypeIdByDocumentId(Long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR270Medium
Method org.kuali.rice.kew.doctype.dao.impl.DocumentTypeDAOOjbImpl.getChildDocumentTypeIds(Long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR89Medium

org.kuali.rice.kew.doctype.service.impl.DocumentTypeServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.doctype.service.impl.DocumentTypeServiceImpl.versionAndSave(DocumentType) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR296Medium

org.kuali.rice.kew.document.RoutingRuleMaintainableBusRule

BugCategoryDetailsLinePriority
Dead store to extensions in org.kuali.rice.kew.document.RoutingRuleMaintainableBusRule.setRuleAttributeErrors(RuleBaseValues)STYLEDLS_DEAD_LOCAL_STORE243High

org.kuali.rice.kew.documentoperation.web.DocumentOperationAction

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationAction.getDocument(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION129Medium

org.kuali.rice.kew.documentoperation.web.DocumentOperationForm

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getActionItemOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR173Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getActionRequestOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR145Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getActionTakenOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR152Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getBranchOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR166Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getNodeStateDeleteOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR180Medium
Method org.kuali.rice.kew.documentoperation.web.DocumentOperationForm.getRouteNodeInstanceOp(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR159Medium

org.kuali.rice.kew.dto.DTOConverter

BugCategoryDetailsLinePriority
Impossible downcast of toArray() result to String[] in org.kuali.rice.kew.dto.DTOConverter.convertDocumentSearchCriteriaDTO(DocumentSearchCriteriaDTO)CORRECTNESSBC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY1319High
Method org.kuali.rice.kew.dto.DTOConverter.createDocumentContentSection(Document, Element, WorkflowAttributeDefinitionDTO[], String, String, DocumentType) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION399Medium
Method org.kuali.rice.kew.dto.DTOConverter.convertDocumentSearchCriteriaDTO(DocumentSearchCriteriaDTO) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR1314Medium
Method org.kuali.rice.kew.dto.DTOConverter.convertRouteHeader(DocumentRouteHeaderValue, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR136Medium

org.kuali.rice.kew.edl.EDLDatabasePostProcessor

BugCategoryDetailsLinePriority
Possible null pointer dereference of activeNodeInstances in org.kuali.rice.kew.edl.EDLDatabasePostProcessor.getNodeNames(Long)CORRECTNESSNP_NULL_ON_SOME_PATH120High

org.kuali.rice.kew.edl.EDLXmlUtils

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.edl.EDLXmlUtils.addErrorsAndMessagesToDocument(Document, List, List, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR236Medium

org.kuali.rice.kew.edl.UserAction

BugCategoryDetailsLinePriority
org.kuali.rice.kew.edl.UserAction.ANNOTATABLE_ACTIONS is a mutable arrayMALICIOUS_CODEMS_MUTABLE_ARRAY78High
org.kuali.rice.kew.edl.UserAction.EDITABLE_ACTIONS is a mutable arrayMALICIOUS_CODEMS_MUTABLE_ARRAY88High
org.kuali.rice.kew.edl.UserAction.LOAD_ACTIONS should be package protectedMALICIOUS_CODEMS_PKGPROTECT58Medium
org.kuali.rice.kew.edl.UserAction.REPLACE_VERSION_ACTIONS should be package protectedMALICIOUS_CODEMS_PKGPROTECT63Medium
org.kuali.rice.kew.edl.UserAction.VALIDATABLE_ACTIONS should be package protectedMALICIOUS_CODEMS_PKGPROTECT67Medium

org.kuali.rice.kew.edl.components.NoteConfigComponent

BugCategoryDetailsLinePriority
org.kuali.rice.kew.edl.components.NoteConfigComponent.retrieveNoteList(NoteConfigComponent$NoteForm, EDLContext) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR189Medium
Method org.kuali.rice.kew.edl.components.NoteConfigComponent.editNote(NoteConfigComponent$NoteForm) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR204Medium
Method org.kuali.rice.kew.edl.components.NoteConfigComponent.retrieveNoteList(NoteConfigComponent$NoteForm, EDLContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR188Medium
Method org.kuali.rice.kew.edl.components.NoteConfigComponent.retrieveNoteList(NoteConfigComponent$NoteForm, EDLContext) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR165Medium
note could be null and is guaranteed to be dereferenced in org.kuali.rice.kew.edl.components.NoteConfigComponent.getAuthorData(Note)CORRECTNESSNP_GUARANTEED_DEREF850Medium

org.kuali.rice.kew.edl.components.NoteConfigComponent$NoteForm

BugCategoryDetailsLinePriority
Method new org.kuali.rice.kew.edl.components.NoteConfigComponent$NoteForm(RequestParser) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR625Medium

org.kuali.rice.kew.edl.components.SelectControlEDLComponent

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.edl.components.SelectControlEDLComponent.updateDOM(Document, Element, EDLContext) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION64Medium

org.kuali.rice.kew.edl.components.ValidationComponent

BugCategoryDetailsLinePriority
Unused field: org.kuali.rice.kew.edl.components.ValidationComponent.edlContextPERFORMANCEUUF_UNUSED_FIELDMedium

org.kuali.rice.kew.edl.components.VersioningPreprocessor

BugCategoryDetailsLinePriority
org.kuali.rice.kew.edl.components.VersioningPreprocessor.findCurrentVersion(Document) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR82Medium
Method org.kuali.rice.kew.edl.components.VersioningPreprocessor.updateDOM(Document, Element, EDLContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR56Medium

org.kuali.rice.kew.edl.components.WorkflowDocumentActions

BugCategoryDetailsLinePriority
Dead store to requestParser in org.kuali.rice.kew.edl.components.WorkflowDocumentActions.doPostProcessWork(Document, EDLContext)STYLEDLS_DEAD_LOCAL_STORE92Medium

org.kuali.rice.kew.engine.BlanketApproveEngine$ProcessEntry

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.engine.BlanketApproveEngine$ProcessEntry be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC289Medium

org.kuali.rice.kew.engine.CompatUtils

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.CompatUtils.getLevelForNode(DocumentType, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR45Medium
Method org.kuali.rice.kew.engine.CompatUtils.getLevelForNode(RouteNode, String, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR64Medium
Method org.kuali.rice.kew.engine.CompatUtils.getNodeForLevel(DocumentType, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR73Medium
Method org.kuali.rice.kew.engine.CompatUtils.getNodeForLevel(RouteNode, Integer, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR95Medium

org.kuali.rice.kew.engine.EngineState

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.EngineState.getNextSimulationId() invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR74Medium

org.kuali.rice.kew.engine.StandardWorkflowEngine

BugCategoryDetailsLinePriority
Dead store to processContext in org.kuali.rice.kew.engine.StandardWorkflowEngine.process(Long, Long)STYLEDLS_DEAD_LOCAL_STORE118Medium
Method org.kuali.rice.kew.engine.StandardWorkflowEngine.handleBackwardCompatibility(RouteContext, RouteNodeInstance) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR326Medium

org.kuali.rice.kew.engine.node.FYIByNetworkId

BugCategoryDetailsLinePriority
Dead store to routeHeaderId in org.kuali.rice.kew.engine.node.FYIByNetworkId.process(RouteContext, RouteHelper)STYLEDLS_DEAD_LOCAL_STORE52Medium

org.kuali.rice.kew.engine.node.IteratedRequestActivationNode

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.node.IteratedRequestActivationNode.saveActionRequest(RouteContext, ActionRequestValue) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR268Medium

org.kuali.rice.kew.engine.node.KRAMetaRuleNode$FinalApproverContext

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.engine.node.KRAMetaRuleNode$FinalApproverContext be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC218Medium

org.kuali.rice.kew.engine.node.NodeJotter

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.node.NodeJotter.orchestrateOutput(RouteNodeInstance, NodeType, NodeJotter$SplitJoinContext, int) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION72Medium
Method org.kuali.rice.kew.engine.node.NodeJotter.outputNodeInstanceToLog(RouteNodeInstance, NodeType, int) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION93Medium

org.kuali.rice.kew.engine.node.NodeType$ExtensionDepthComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.NodeType$ExtensionDepthComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE180Medium

org.kuali.rice.kew.engine.node.RequestActivationNode

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.node.RequestActivationNode.saveActionRequest(RouteContext, ActionRequestValue) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR168Medium

org.kuali.rice.kew.engine.node.RequestsNode$FinalApproverContext

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.engine.node.RequestsNode$FinalApproverContext be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC250Medium

org.kuali.rice.kew.engine.node.RoleNode$RoleRequestSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.RoleNode$RoleRequestSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE218Medium

org.kuali.rice.kew.engine.node.RouteNodeUtils$RouteNodeSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.RouteNodeUtils$RouteNodeSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE154Medium

org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode

BugCategoryDetailsLinePriority
Dead store to documentType in org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode.transitioningOutOf(RouteContext, RouteHelper)STYLEDLS_DEAD_LOCAL_STORE158Medium
Possible null pointer dereference of result in org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode.transitioningOutOf(RouteContext, RouteHelper)CORRECTNESSNP_NULL_ON_SOME_PATH194Medium
Nullcheck of requestNodeStop at line 242 of value previously dereferenced in org.kuali.rice.kew.engine.node.hierarchyrouting.HierarchyRoutingNode.canTransitionFrom(HierarchyProvider, HierarchyProvider$Stop, Collection, RouteHelper)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE242Medium

org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl.searchNodeGraphBackward(NodeGraphContext, NodeMatcher) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR337Medium

org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$NodeInstanceIdSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$NodeInstanceIdSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE420Medium

org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$RouteNodeSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.engine.node.service.impl.RouteNodeServiceImpl$RouteNodeSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE412Medium

org.kuali.rice.kew.engine.simulation.SimulationEngine

BugCategoryDetailsLinePriority
Dead store to processContext in org.kuali.rice.kew.engine.simulation.SimulationEngine.process(Long, Long)STYLEDLS_DEAD_LOCAL_STORE105Medium
Method org.kuali.rice.kew.engine.simulation.SimulationEngine.createSimulationDocument(Long, SimulationCriteria, RouteContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR290Medium

org.kuali.rice.kew.help.service.impl.HelpServiceImpl

BugCategoryDetailsLinePriority
Dead store to errors in org.kuali.rice.kew.help.service.impl.HelpServiceImpl.validateHelpEntry(HelpEntry)STYLEDLS_DEAD_LOCAL_STORE107High

org.kuali.rice.kew.help.web.HelpForm

BugCategoryDetailsLinePriority
Class org.kuali.rice.kew.help.web.HelpForm defines non-transient non-serializable instance field helpEntryBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kew.mail.service.impl.ActionListEmailServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.mail.service.impl.ActionListEmailServiceImpl.getActionListItemsStat(Collection) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR529Medium
Method org.kuali.rice.kew.mail.service.impl.ActionListEmailServiceImpl.getDailyWeeklyMessageBody(Collection) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR508Medium

org.kuali.rice.kew.mail.service.impl.HardCodedActionListEmailServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.mail.service.impl.HardCodedActionListEmailServiceImpl.getActionListItemsStat(Collection) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR314Medium
Method org.kuali.rice.kew.mail.service.impl.HardCodedActionListEmailServiceImpl.getDailyWeeklyMessageBody(Collection) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR293Medium

org.kuali.rice.kew.mail.service.impl.HardCodedEmailContentServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.mail.service.impl.HardCodedEmailContentServiceImpl.getActionListItemsStat(Collection) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR225Medium
Method org.kuali.rice.kew.mail.service.impl.HardCodedEmailContentServiceImpl.getDailyWeeklyMessageBody(Collection) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR204Medium

org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl.generateExceptionGroupRequests(RouteContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR153Medium
Method call in org.kuali.rice.kew.messaging.exceptionhandling.ExceptionRoutingServiceImpl.placeInExceptionRouting(String, PersistedMessage, Long) passes null for nonnull parameter of placeInExceptionRouting(String, RouteNodeInstance, PersistedMessage, RouteContext, DocumentRouteHeaderValue, boolean)CORRECTNESSNP_NULL_PARAM_DEREF65Medium

org.kuali.rice.kew.notes.service.impl.AttachmentServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kew.notes.service.impl.AttachmentServiceImpl.createStorageDirIfNecessary() ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE87Medium

org.kuali.rice.kew.notes.web.AttachmentServlet

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.kuali.rice.kew.notes.web.AttachmentServlet.doPost(HttpServletRequest, HttpServletResponse)STYLEREC_CATCH_EXCEPTION122Medium

org.kuali.rice.kew.notes.web.NoteAction

BugCategoryDetailsLinePriority
org.kuali.rice.kew.notes.web.NoteAction.initForm(HttpServletRequest, ActionForm) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR207Medium
org.kuali.rice.kew.notes.web.NoteAction.retrieveNoteList(HttpServletRequest, NoteForm) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR236Medium
Method org.kuali.rice.kew.notes.web.NoteAction.edit(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR111Medium
Method org.kuali.rice.kew.notes.web.NoteAction.retrieveNoteList(HttpServletRequest, NoteForm) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR253Medium
Method org.kuali.rice.kew.notes.web.NoteAction.retrieveNoteList(HttpServletRequest, NoteForm) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR230Medium
note could be null and is guaranteed to be dereferenced in org.kuali.rice.kew.notes.web.NoteAction.getAuthorData(Note)CORRECTNESSNP_GUARANTEED_DEREF272Medium
Nullcheck of routeHeader at line 218 of value previously dereferenced in org.kuali.rice.kew.notes.web.NoteAction.retrieveNoteList(HttpServletRequest, NoteForm)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE218Medium

org.kuali.rice.kew.plugin.ModificationTracker

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.plugin.ModificationTracker.isModified(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR68Medium

org.kuali.rice.kew.plugin.ModificationTracker$Node

BugCategoryDetailsLinePriority
org.kuali.rice.kew.plugin.ModificationTracker$Node.equals(Object) invokes java.net.URL.equals(Object), which blocks to do domain name resolutionPERFORMANCEDMI_BLOCKING_METHODS_ON_URL98High
org.kuali.rice.kew.plugin.ModificationTracker$Node.hashCode() invokes java.net.URL.hashCode(), which blocks to do domain name resolutionPERFORMANCEDMI_BLOCKING_METHODS_ON_URL103High
Should org.kuali.rice.kew.plugin.ModificationTracker$Node be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC79Medium

org.kuali.rice.kew.plugin.PluginConfig

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.plugin.PluginConfig.getObjects() makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR104Medium

org.kuali.rice.kew.plugin.PluginEnvironment

BugCategoryDetailsLinePriority
Inconsistent synchronization of org.kuali.rice.kew.plugin.PluginEnvironment.supressStartupFailure; locked 50% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC146Medium

org.kuali.rice.kew.plugin.PluginNameComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kew.plugin.PluginNameComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE26Medium

org.kuali.rice.kew.plugin.ServerPluginRegistry

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.plugin.ServerPluginRegistry.loadPlugins(File) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR140Medium

org.kuali.rice.kew.plugin.ZipFilePluginLoader

BugCategoryDetailsLinePriority

org.kuali.rice.kew.preferences.service.impl.PreferencesServiceImpl

BugCategoryDetailsLinePriority
Dead store to stagingDirectory in org.kuali.rice.kew.preferences.service.impl.PreferencesServiceImpl.getPreferences(String)STYLEDLS_DEAD_LOCAL_STORE98Medium

org.kuali.rice.kew.quicklinks.ActionListStats

BugCategoryDetailsLinePriority
org.kuali.rice.kew.quicklinks.ActionListStats defines compareTo(Object) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS62Medium

org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOJpaImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOJpaImpl.getInitiatedDocumentTypesList(String) invokes substring(0), which returns the original valueSTYLEDMI_USELESS_SUBSTRING94Medium

org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$2

BugCategoryDetailsLinePriority
org.kuali.rice.kew.quicklinks.dao.impl.QuickLinksDAOOjbImpl$2.doInPersistenceBroker(PersistenceBroker) invokes substring(0), which returns the original valueSTYLEDMI_USELESS_SUBSTRING149Medium

org.kuali.rice.kew.removereplace.service.impl.RemoveReplaceDocumentServiceImpl

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.kuali.rice.kew.removereplace.service.impl.RemoveReplaceDocumentServiceImpl.attachDocumentContent(RemoveReplaceDocument, WorkflowDocument)STYLEREC_CATCH_EXCEPTION143Medium

org.kuali.rice.kew.removereplace.web.RemoveReplaceAction$ResponsibilityEvaluation

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.removereplace.web.RemoveReplaceAction$ResponsibilityEvaluation be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC384Medium

org.kuali.rice.kew.resourceloader.CoreResourceLoader

BugCategoryDetailsLinePriority
org.kuali.rice.kew.resourceloader.CoreResourceLoader.useRemoteEmailServices() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR107Medium

org.kuali.rice.kew.role.RoleRouteModule

BugCategoryDetailsLinePriority
Dead store to actionRequests in org.kuali.rice.kew.role.RoleRouteModule.findActionRequests(RouteContext)STYLEDLS_DEAD_LOCAL_STORE70Medium

org.kuali.rice.kew.role.XPathQualifierResolver$ResolverConfig

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.role.XPathQualifierResolver$ResolverConfig be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC230Medium

org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue

BugCategoryDetailsLinePriority
Method new org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR133Medium
Comparison of String parameter using == or != in org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue.setRouteStatus(String, boolean) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ659High
Method org.kuali.rice.kew.routeheader.DocumentRouteHeaderValue.getCurrentRouteLevelName() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION270Medium

org.kuali.rice.kew.routeheader.PartialAttributeContent

BugCategoryDetailsLinePriority
Class org.kuali.rice.kew.routeheader.PartialAttributeContent defines non-transient non-serializable instance field attributeContentBAD_PRACTICESE_BAD_FIELDMedium
Class org.kuali.rice.kew.routeheader.PartialAttributeContent defines non-transient non-serializable instance field documentBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOJpaImpl.findPendingByResponsibilityIds(Set) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION201Medium

org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findByDocTypeAndAppId(String, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR380Medium
Method org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findPendingByResponsibilityIds(Set) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR212Medium
org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findByDocTypeAndAppId(String, String) may fail to close PreparedStatementBAD_PRACTICEODR_OPEN_DATABASE_RESOURCE374Medium
Method org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl.findPendingByResponsibilityIds(Set) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION199Medium

org.kuali.rice.kew.routeheader.dao.impl.DocumentRouteHeaderDAOOjbImpl$1

BugCategoryDetailsLinePriority

org.kuali.rice.kew.routeheader.service.impl.WorkflowDocumentServiceImpl

BugCategoryDetailsLinePriority
Dead store to principal in org.kuali.rice.kew.routeheader.service.impl.WorkflowDocumentServiceImpl.takeMassActions(String, List)STYLEDLS_DEAD_LOCAL_STORE451Medium

org.kuali.rice.kew.rule.FlexRM

BugCategoryDetailsLinePriority
Dead store to actionRequests in org.kuali.rice.kew.rule.FlexRM.getActionRequests(DocumentRouteHeaderValue, RouteNode, RouteNodeInstance, String)STYLEDLS_DEAD_LOCAL_STORE203Medium
Private method org.kuali.rice.kew.rule.FlexRM.makeActionRequests(ActionRequestFactory, RouteContext, RuleBaseValues, DocumentRouteHeaderValue, ActionRequestValue, RuleDelegation) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD241Medium

org.kuali.rice.kew.rule.GroupRuleResponsibility

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.GroupRuleResponsibility doesn't override RuleResponsibility.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS26Medium

org.kuali.rice.kew.rule.KRAMetaRuleEngine

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.KRAMetaRuleEngine.getStatements() may expose internal representation by returning KRAMetaRuleEngine.statementsMALICIOUS_CODEEI_EXPOSE_REP70Medium

org.kuali.rice.kew.rule.MyRules2

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.MyRules2.addRule(WebRuleBaseValues) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR43Medium

org.kuali.rice.kew.rule.PersonRuleResponsibility

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.PersonRuleResponsibility doesn't override RuleResponsibility.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS27Medium

org.kuali.rice.kew.rule.RemoveReplaceRuleRoutingAttribute

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.RemoveReplaceRuleRoutingAttribute.filterNonMatchingRules(RouteContext, List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION93Medium

org.kuali.rice.kew.rule.RemoveReplaceRuleRoutingAttribute$RuleDocumentType

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.RemoveReplaceRuleRoutingAttribute$RuleDocumentType.equals(Object) checks for operand being a String BAD_PRACTICEEQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS142High
Should org.kuali.rice.kew.rule.RemoveReplaceRuleRoutingAttribute$RuleDocumentType be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC121Medium

org.kuali.rice.kew.rule.RuleBaseValues

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.RuleBaseValues.getRuleExtensionValueLabels() uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES198Medium
org.kuali.rice.kew.rule.RuleBaseValues.copy(boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR442Medium
Method org.kuali.rice.kew.rule.RuleBaseValues.addRuleResponsibility(RuleResponsibility) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR282Medium
Method org.kuali.rice.kew.rule.RuleBaseValues.copy(boolean) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR489Medium
Method org.kuali.rice.kew.rule.RuleBaseValues.copy(boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR436Medium
org.kuali.rice.kew.rule.RuleBaseValues.copy(boolean) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR451Medium

org.kuali.rice.kew.rule.RuleDelegation

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.RuleDelegation.copy(boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR75Medium
org.kuali.rice.kew.rule.RuleDelegation.copy(boolean) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR80Medium

org.kuali.rice.kew.rule.RuleExpressionDef

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.RuleExpressionDef defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE99High

org.kuali.rice.kew.rule.RuleExtension

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.RuleExtension.copy(boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR168Medium
org.kuali.rice.kew.rule.RuleExtension defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE191High

org.kuali.rice.kew.rule.RuleExtensionValue

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.RuleExtensionValue.copy(boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR126Medium
org.kuali.rice.kew.rule.RuleExtensionValue.copy(boolean) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR123Medium
org.kuali.rice.kew.rule.RuleExtensionValue defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE136High

org.kuali.rice.kew.rule.RuleRoutingAttribute

BugCategoryDetailsLinePriority
Nullcheck of ruleRoutingElement at line 174 of value previously dereferenced in org.kuali.rice.kew.rule.RuleRoutingAttribute.parseDocContent(DocumentContent)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE174Medium

org.kuali.rice.kew.rule.RuleTemplateOption

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.RuleTemplateOption.copy(boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR90Medium
org.kuali.rice.kew.rule.RuleTemplateOption.copy(boolean) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR84Medium

org.kuali.rice.kew.rule.TemplateRuleSelector

BugCategoryDetailsLinePriority
Dead store to documentContent in org.kuali.rice.kew.rule.TemplateRuleSelector.selectRules(RouteContext, DocumentRouteHeaderValue, RouteNodeInstance, String, Timestamp)STYLEDLS_DEAD_LOCAL_STORE92Medium

org.kuali.rice.kew.rule.bo.RuleAttribute

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.bo.RuleAttribute.copy(boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR154Medium
org.kuali.rice.kew.rule.bo.RuleAttribute.copy(boolean) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR142Medium

org.kuali.rice.kew.rule.bo.RuleBaseValuesLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Dead store to attributeLabel in org.kuali.rice.kew.rule.bo.RuleBaseValuesLookupableHelperServiceImpl.validateSearchParameters(Map)STYLEDLS_DEAD_LOCAL_STORE455Medium
Method org.kuali.rice.kew.rule.bo.RuleBaseValuesLookupableHelperServiceImpl.getSearchResults(Map) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR229Medium

org.kuali.rice.kew.rule.bo.RuleDelegationLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Dead store to attributeLabel in org.kuali.rice.kew.rule.bo.RuleDelegationLookupableHelperServiceImpl.validateSearchParameters(Map)STYLEDLS_DEAD_LOCAL_STORE419Medium
Method org.kuali.rice.kew.rule.bo.RuleDelegationLookupableHelperServiceImpl.getSearchResults(Map) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR215Medium

org.kuali.rice.kew.rule.bo.RuleTemplate

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.bo.RuleTemplate.copy(boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR272Medium
org.kuali.rice.kew.rule.bo.RuleTemplate.copy(boolean) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR266Medium
org.kuali.rice.kew.rule.bo.RuleTemplate.DEFAULT_OPTION_KEYS should be package protectedMALICIOUS_CODEMS_PKGPROTECT55Medium

org.kuali.rice.kew.rule.bo.RuleTemplateAttribute

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.bo.RuleTemplateAttribute.copy(boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR266Medium
Method org.kuali.rice.kew.rule.bo.RuleTemplateAttribute.copy(boolean) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR263Medium
Method org.kuali.rice.kew.rule.bo.RuleTemplateAttribute.copy(boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR275Medium
org.kuali.rice.kew.rule.bo.RuleTemplateAttribute.copy(boolean) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR260Medium
org.kuali.rice.kew.rule.bo.RuleTemplateAttribute defines compareTo(RuleTemplateAttribute) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS90Medium

org.kuali.rice.kew.rule.dao.impl.RuleDAOJpaImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.dao.impl.RuleDAOJpaImpl.fetchAllRules(boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR121Medium

org.kuali.rice.kew.rule.dao.impl.RuleDAOOjbImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.dao.impl.RuleDAOOjbImpl.fetchAllRules(boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR118Medium

org.kuali.rice.kew.rule.dao.impl.RuleDAOOjbImpl$1

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.dao.impl.RuleDAOOjbImpl$1.doInPersistenceBroker(PersistenceBroker) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR474Medium

org.kuali.rice.kew.rule.service.impl.RuleDelegationServiceImpl

BugCategoryDetailsLinePriority
Load of known null value in org.kuali.rice.kew.rule.service.impl.RuleDelegationServiceImpl.findByResponsibilityId(Long, boolean)STYLENP_LOAD_OF_KNOWN_NULL_VALUE194Medium

org.kuali.rice.kew.rule.service.impl.RuleServiceImpl$RuleDelegationSorter

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.service.impl.RuleServiceImpl$RuleDelegationSorter.compare(Object, Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR1274Medium
Should org.kuali.rice.kew.rule.service.impl.RuleServiceImpl$RuleDelegationSorter be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC1269Medium

org.kuali.rice.kew.rule.web.RoutingReportAction

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.web.RoutingReportAction.calculateRoute(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR147Medium
Method org.kuali.rice.kew.rule.web.RoutingReportAction.calculateRoute(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR145Medium
Method org.kuali.rice.kew.rule.web.RoutingReportAction.populateActionRequestsWithRouteLevelInformationAndIterateMagicCounter(RouteNode, List, long) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR294Medium
Method org.kuali.rice.kew.rule.web.RoutingReportAction.populateActionRequestsWithRouteLevelInformationAndIterateMagicCounter(RouteNode, List, long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR296Medium

org.kuali.rice.kew.rule.web.RoutingReportAction$RouteReportRuleTemplateContainer

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.rule.web.RoutingReportAction$RouteReportRuleTemplateContainer be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC276Medium

org.kuali.rice.kew.rule.web.WebRuleBaseValues

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.web.WebRuleBaseValues.loadFields() uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES108Medium
Method org.kuali.rice.kew.rule.web.WebRuleBaseValues.loadFieldsWithDefaultValues() uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES214Medium

org.kuali.rice.kew.rule.web.WebRuleResponsibility

BugCategoryDetailsLinePriority
Dead store to o in org.kuali.rice.kew.rule.web.WebRuleResponsibility.injectWebMembers()STYLEDLS_DEAD_LOCAL_STORE146Medium
org.kuali.rice.kew.rule.web.WebRuleResponsibility doesn't override org.kuali.rice.kew.rule.RuleResponsibility.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS51Medium

org.kuali.rice.kew.rule.web.WebRuleResponsibility$DelegationRulesProxy

BugCategoryDetailsLinePriority
org.kuali.rice.kew.rule.web.WebRuleResponsibility$DelegationRulesProxy is serializable and an inner classBAD_PRACTICESE_INNER_CLASS455Medium

org.kuali.rice.kew.rule.web.WebRuleUtils

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.rule.web.WebRuleUtils.transformFieldConversions(List, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR309Medium

org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute

BugCategoryDetailsLinePriority
Nullcheck of map at line 507 of value previously dereferenced in org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute.getDocContent()CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE507Medium
Method org.kuali.rice.kew.rule.xmlrouting.StandardGenericXMLRuleAttribute.getDocContent() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION498Medium

org.kuali.rice.kew.service.impl.KEWModuleService

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.service.impl.KEWModuleService.getExternalizableBusinessObjectInquiryUrl(Class, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR172Medium

org.kuali.rice.kew.service.impl.WorkflowDocumentActionsWebServiceImpl

BugCategoryDetailsLinePriority
Dead store to document in org.kuali.rice.kew.service.impl.WorkflowDocumentActionsWebServiceImpl.superUserActionRequestApproveAction(String, Long, Long, String, boolean)STYLEDLS_DEAD_LOCAL_STORE378Medium
org.kuali.rice.kew.service.impl.WorkflowDocumentActionsWebServiceImpl.adHocRouteDocumentToGroup(String, RouteHeaderDTO, String, String, String, String, String, boolean, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR154Medium
org.kuali.rice.kew.service.impl.WorkflowDocumentActionsWebServiceImpl.adHocRouteDocumentToPrincipal(String, RouteHeaderDTO, String, String, String, String, String, boolean, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR143Medium

org.kuali.rice.kew.service.impl.WorkflowUtilityWebServiceImpl

BugCategoryDetailsLinePriority
Dead store to principalId in org.kuali.rice.kew.service.impl.WorkflowUtilityWebServiceImpl.getDocumentStatusTransitionHistory(Long)STYLEDLS_DEAD_LOCAL_STORE1181Medium
Method org.kuali.rice.kew.service.impl.WorkflowUtilityWebServiceImpl.routeNodeHasApproverActionRequest(String, String, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR742Medium
Method org.kuali.rice.kew.service.impl.WorkflowUtilityWebServiceImpl.routeNodeHasApproverActionRequest(DocumentType, String, RouteNode, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR767Medium
Method org.kuali.rice.kew.service.impl.WorkflowUtilityWebServiceImpl.routeNodeHasApproverActionRequest(DocumentType, String, RouteNode, Integer) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR764Medium

org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.DocumentsRoutedReport(Stats, Date, Date) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR91Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumActiveItemsReport(Stats) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR57Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumInitiatedDocsByDocTypeReport(Stats) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR149Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumUsersReport(Stats) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR125Medium
Method org.kuali.rice.kew.stats.dao.impl.StatsDAOOjbImpl.NumberOfDocTypesReport(Stats) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR72Medium

org.kuali.rice.kew.stats.web.StatsForm

BugCategoryDetailsLinePriority
org.kuali.rice.kew.stats.web.StatsForm.getBeginningDate() may expose internal representation by returning StatsForm.beginningDateMALICIOUS_CODEEI_EXPOSE_REP251Medium
org.kuali.rice.kew.stats.web.StatsForm.getEndingDate() may expose internal representation by returning StatsForm.endingDateMALICIOUS_CODEEI_EXPOSE_REP259Medium
org.kuali.rice.kew.stats.web.StatsForm.setBeginningDate(Date) may expose internal representation by storing an externally mutable object into StatsForm.beginningDateMALICIOUS_CODEEI_EXPOSE_REP2255Medium
org.kuali.rice.kew.stats.web.StatsForm.setEndingDate(Date) may expose internal representation by storing an externally mutable object into StatsForm.endingDateMALICIOUS_CODEEI_EXPOSE_REP2263Medium
Class org.kuali.rice.kew.stats.web.StatsForm defines non-transient non-serializable instance field statsBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kew.superuser.web.SuperUserAction

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.superuser.web.SuperUserAction.actionRequestApprove(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES182Medium

org.kuali.rice.kew.superuser.web.SuperUserForm

BugCategoryDetailsLinePriority
org.kuali.rice.kew.superuser.web.SuperUserForm.getActionRequestRunPostProcessorCheck() may expose internal representation by returning SuperUserForm.actionRequestRunPostProcessorCheckMALICIOUS_CODEEI_EXPOSE_REP254Medium
org.kuali.rice.kew.superuser.web.SuperUserForm.setActionRequestRunPostProcessorCheck(String[]) may expose internal representation by storing an externally mutable object into SuperUserForm.actionRequestRunPostProcessorCheckMALICIOUS_CODEEI_EXPOSE_REP2257Medium

org.kuali.rice.kew.useroptions.UserOptions

BugCategoryDetailsLinePriority
org.kuali.rice.kew.useroptions.UserOptions defines compareTo(Object) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS117Medium

org.kuali.rice.kew.useroptions.UserOptionsId

BugCategoryDetailsLinePriority
Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kew.useroptions.UserOptionsId.equals(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE46Medium

org.kuali.rice.kew.util.ByteArrayDataSource

BugCategoryDetailsLinePriority
new org.kuali.rice.kew.util.ByteArrayDataSource(byte[], String) may expose internal representation by storing an externally mutable object into ByteArrayDataSource.dataMALICIOUS_CODEEI_EXPOSE_REP260Medium

org.kuali.rice.kew.util.Utilities$PrioritySorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.util.Utilities$PrioritySorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE205Medium

org.kuali.rice.kew.util.Utilities$RouteLogActionRequestSorter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.util.Utilities$RouteLogActionRequestSorter implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE227Medium

org.kuali.rice.kew.web.DummyLoginFilter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.web.DummyLoginFilter.init(FilterConfig) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR46Medium

org.kuali.rice.kew.web.FilterMapping

BugCategoryDetailsLinePriority
org.kuali.rice.kew.web.FilterMapping defines compareTo(FilterMapping) and uses Object.equals()BAD_PRACTICEEQ_COMPARETO_USE_OBJECT_EQUALS358Medium

org.kuali.rice.kew.web.ModuleRelativeForwardAction

BugCategoryDetailsLinePriority
org.kuali.rice.kew.web.ModuleRelativeForwardAction.messages isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL36High

org.kuali.rice.kew.web.UserLoginFilter

BugCategoryDetailsLinePriority
Possible null pointer dereference of userSession in org.kuali.rice.kew.web.UserLoginFilter.doFilter(ServletRequest, ServletResponse, FilterChain)CORRECTNESSNP_NULL_ON_SOME_PATH88Medium

org.kuali.rice.kew.web.session.UserSession

BugCategoryDetailsLinePriority
The field org.kuali.rice.kew.web.session.UserSession.objectMap is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium

org.kuali.rice.kew.workgroup.BaseWorkgroupId

BugCategoryDetailsLinePriority
Dead store to pk in org.kuali.rice.kew.workgroup.BaseWorkgroupId.equals(Object)STYLEDLS_DEAD_LOCAL_STORE44Medium
Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kew.workgroup.BaseWorkgroupId.equals(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE43Medium

org.kuali.rice.kew.workgroup.BaseWorkgroupMemberId

BugCategoryDetailsLinePriority
Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kew.workgroup.BaseWorkgroupMemberId.equals(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE50Medium

org.kuali.rice.kew.xml.AbstractTransformationFilter$CurrentElement

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.AbstractTransformationFilter$CurrentElement be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC141Medium

org.kuali.rice.kew.xml.DocumentTypeXmlParser

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.xml.DocumentTypeXmlParser.checkForOrphanedRouteNodes(Node, Node) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION946Medium
Method org.kuali.rice.kew.xml.DocumentTypeXmlParser.parseAllDocumentTypes(Document) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR232Medium

org.kuali.rice.kew.xml.DocumentTypeXmlParser$DocTypeNode

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.DocumentTypeXmlParser$DocTypeNode be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC1443Medium

org.kuali.rice.kew.xml.DocumentTypeXmlParser$RoutePathContext

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.DocumentTypeXmlParser$RoutePathContext be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC1417Medium

org.kuali.rice.kew.xml.GroupXmlJAXBParser$DataNamespaceURIFilter

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.GroupXmlJAXBParser$DataNamespaceURIFilter be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC281Medium

org.kuali.rice.kew.xml.GroupXmlParser

BugCategoryDetailsLinePriority
Dead store to kimTypeAttributes in org.kuali.rice.kew.xml.GroupXmlParser.parseGroup(Element)STYLEDLS_DEAD_LOCAL_STORE163Medium

org.kuali.rice.kew.xml.HelpEntryXmlParser

BugCategoryDetailsLinePriority

org.kuali.rice.kew.xml.RuleTemplateXmlParser

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.xml.RuleTemplateXmlParser.parseRuleTemplateAttribute(Element, RuleTemplate) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR485Medium
Method org.kuali.rice.kew.xml.RuleTemplateXmlParser.updateRuleDefaults(Element, RuleTemplate) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR296Medium
Method org.kuali.rice.kew.xml.RuleTemplateXmlParser.updateRuleDefaults(Element, RuleTemplate) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR317Medium

org.kuali.rice.kew.xml.RuleXmlParser

BugCategoryDetailsLinePriority
Dead store to delegations in org.kuali.rice.kew.xml.RuleXmlParser.parseResponsibility(Element, RuleBaseValues)STYLEDLS_DEAD_LOCAL_STORE379Medium
Method org.kuali.rice.kew.xml.RuleXmlParser.setDefaultRuleValues(RuleBaseValues) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR342Medium

org.kuali.rice.kew.xml.XmlRenderer

BugCategoryDetailsLinePriority
org.kuali.rice.kew.xml.XmlRenderer.renderBooleanElement(Element, String, Boolean, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR60Medium

org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$DocumentTypeParentComparator

BugCategoryDetailsLinePriority
Method org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$DocumentTypeParentComparator.getDepth(DocumentType) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR463Medium
Should org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$DocumentTypeParentComparator be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC448Medium

org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$SplitJoinContext

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.export.DocumentTypeXmlExporter$SplitJoinContext be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC472Medium

org.kuali.rice.kew.xml.export.GroupXmlExporter

BugCategoryDetailsLinePriority
org.kuali.rice.kew.xml.export.GroupXmlExporter.exportGroup(Element, Group) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR78Medium

org.kuali.rice.kew.xml.export.RuleTemplateXmlExporter

BugCategoryDetailsLinePriority
Redundant nullcheck of defaultActionOption, which is known to be non-null in org.kuali.rice.kew.xml.export.RuleTemplateXmlExporter.exportDefaults(Element, RuleTemplate)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE108Medium

org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$SimpleNodeList

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$SimpleNodeList be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC254Medium

org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$XPathSegment

BugCategoryDetailsLinePriority
Should org.kuali.rice.kew.xml.xstream.XStreamSafeEvaluator$XPathSegment be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC228Medium

org.kuali.rice.kim.bo.entity.impl.KimEntityBioDemographicsImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kim.bo.entity.impl.KimEntityBioDemographicsImpl.getBirthDate() may expose internal representation by returning KimEntityBioDemographicsImpl.birthDateMALICIOUS_CODEEI_EXPOSE_REP88Medium
org.kuali.rice.kim.bo.entity.impl.KimEntityBioDemographicsImpl.getBirthDateUnmasked() may expose internal representation by returning KimEntityBioDemographicsImpl.birthDateMALICIOUS_CODEEI_EXPOSE_REP97Medium
org.kuali.rice.kim.bo.entity.impl.KimEntityBioDemographicsImpl.getDeceasedDate() may expose internal representation by returning KimEntityBioDemographicsImpl.deceasedDateMALICIOUS_CODEEI_EXPOSE_REP104Medium
org.kuali.rice.kim.bo.entity.impl.KimEntityBioDemographicsImpl.setBirthDate(Date) may expose internal representation by storing an externally mutable object into KimEntityBioDemographicsImpl.birthDateMALICIOUS_CODEEI_EXPOSE_REP2230Medium
org.kuali.rice.kim.bo.entity.impl.KimEntityBioDemographicsImpl.setDeceasedDate(Date) may expose internal representation by storing an externally mutable object into KimEntityBioDemographicsImpl.deceasedDateMALICIOUS_CODEEI_EXPOSE_REP2237Medium

org.kuali.rice.kim.bo.entity.impl.KimEntityCitizenshipImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kim.bo.entity.impl.KimEntityCitizenshipImpl.getEndDate() may expose internal representation by returning KimEntityCitizenshipImpl.endDateMALICIOUS_CODEEI_EXPOSE_REP79Medium
org.kuali.rice.kim.bo.entity.impl.KimEntityCitizenshipImpl.getStartDate() may expose internal representation by returning KimEntityCitizenshipImpl.startDateMALICIOUS_CODEEI_EXPOSE_REP93Medium
org.kuali.rice.kim.bo.entity.impl.KimEntityCitizenshipImpl.setEndDate(Date) may expose internal representation by storing an externally mutable object into KimEntityCitizenshipImpl.endDateMALICIOUS_CODEEI_EXPOSE_REP2107Medium
org.kuali.rice.kim.bo.entity.impl.KimEntityCitizenshipImpl.setStartDate(Date) may expose internal representation by storing an externally mutable object into KimEntityCitizenshipImpl.startDateMALICIOUS_CODEEI_EXPOSE_REP2114Medium

org.kuali.rice.kim.bo.impl.GenericPermission

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.bo.impl.GenericPermission.setDetailValues(AttributeSet) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR119Medium

org.kuali.rice.kim.bo.impl.PersonImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kim.bo.impl.PersonImpl.identityManagementService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kim.bo.impl.PersonImpl.personService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium

org.kuali.rice.kim.bo.role.impl.KimResponsibilityImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of KimResponsibilityImpl.template in org.kuali.rice.kim.bo.role.impl.KimResponsibilityImpl.getNameToDisplay()CORRECTNESSNP_NULL_ON_SOME_PATH117Medium

org.kuali.rice.kim.bo.ui.KimAttributeDataComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kim.bo.ui.KimAttributeDataComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE28Medium

org.kuali.rice.kim.bo.ui.PersonDocumentGroup

BugCategoryDetailsLinePriority
The field org.kuali.rice.kim.bo.ui.PersonDocumentGroup.kimGroupType is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium

org.kuali.rice.kim.bo.ui.PersonDocumentRole

BugCategoryDetailsLinePriority
The field org.kuali.rice.kim.bo.ui.PersonDocumentRole.attributeEntry is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium
The field org.kuali.rice.kim.bo.ui.PersonDocumentRole.definitions is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium

org.kuali.rice.kim.client.acegi.KualiCasProxyTicketValidator

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.kuali.rice.kim.client.acegi.KualiCasProxyTicketValidator.validateNow(ProxyTicketValidator)STYLEREC_CATCH_EXCEPTION113Medium

org.kuali.rice.kim.client.acegi.KualiUserDetailsServiceImpl

BugCategoryDetailsLinePriority
Invocation of toString on newAuthorities in org.kuali.rice.kim.client.acegi.KualiUserDetailsServiceImpl.loadUserByUsernameAndAuthorities(String, GrantedAuthority[])CORRECTNESSDMI_INVOKING_TOSTRING_ON_ARRAY82High

org.kuali.rice.kim.dao.impl.KimRoleDaoOjb

BugCategoryDetailsLinePriority
Dead store to groupIdValues in org.kuali.rice.kim.dao.impl.KimRoleDaoOjb.getGroupMembers(Collection)STYLEDLS_DEAD_LOCAL_STORE146Medium

org.kuali.rice.kim.document.GenericPermissionMaintainable

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kim.document.GenericPermissionMaintainable.prepareBusinessObject(BusinessObject), since all org.kuali.rice.kim.bo.impl.GenericPermission are instances of org.kuali.rice.kns.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF105Medium

org.kuali.rice.kim.document.IdentityManagementKimDocument

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from org.kuali.rice.kns.datadictionary.AttributeDefinition to org.kuali.rice.kns.datadictionary.KimNonDataDictionaryAttributeDefinition in org.kuali.rice.kim.document.IdentityManagementKimDocument.getKimAttributeDefnId(AttributeDefinition)STYLEBC_UNCONFIRMED_CAST135Medium
org.kuali.rice.kim.document.IdentityManagementKimDocument is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID39Medium

org.kuali.rice.kim.document.KimTypeAttributesHelper

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from org.kuali.rice.kns.datadictionary.AttributeDefinition to org.kuali.rice.kns.datadictionary.KimNonDataDictionaryAttributeDefinition in org.kuali.rice.kim.document.KimTypeAttributesHelper.getKimAttributeDefnId(AttributeDefinition)STYLEBC_UNCONFIRMED_CAST84Medium
org.kuali.rice.kim.document.KimTypeAttributesHelper is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID43Medium
Unwritten field: org.kuali.rice.kim.document.KimTypeAttributesHelper.attributesCORRECTNESSUWF_UNWRITTEN_FIELD57Medium
Method org.kuali.rice.kim.document.KimTypeAttributesHelper.getAttributeValue(AttributeSet, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR132Medium

org.kuali.rice.kim.document.ReviewResponsibilityMaintainable

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kim.document.ReviewResponsibilityMaintainable.prepareBusinessObject(BusinessObject), since all org.kuali.rice.kim.bo.impl.ReviewResponsibility are instances of org.kuali.rice.kns.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF154Medium
org.kuali.rice.kim.document.ReviewResponsibilityMaintainable.reviewTemplateId should be package protectedMALICIOUS_CODEMS_PKGPROTECT50Medium

org.kuali.rice.kim.document.rule.AttributeValidationHelper

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.document.rule.AttributeValidationHelper.convertErrors(String, AttributeSet, AttributeSet) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR158Medium
Method org.kuali.rice.kim.document.rule.AttributeValidationHelper.convertErrorsForMappedFields(String, AttributeSet) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR144Medium
Method org.kuali.rice.kim.document.rule.AttributeValidationHelper.moveValidationErrorsToErrorMap(AttributeSet) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR125Medium

org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule.checkUnassignableRoles(IdentityManagementPersonDocument) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR178Medium
Method org.kuali.rice.kim.document.rule.IdentityManagementPersonDocumentRule.checkUnpopulatableGroups(IdentityManagementPersonDocument) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR196Medium

org.kuali.rice.kim.document.rule.IdentityManagementRoleDocumentRule

BugCategoryDetailsLinePriority
Dead store to errorsTemp in org.kuali.rice.kim.document.rule.IdentityManagementRoleDocumentRule.validateDelegationMemberRoleQualifier(List, List, KimTypeInfo)STYLEDLS_DEAD_LOCAL_STORE454Medium
Dead store to errorsTemp in org.kuali.rice.kim.document.rule.IdentityManagementRoleDocumentRule.validateRoleQualifier(List, KimTypeInfo)STYLEDLS_DEAD_LOCAL_STORE305Medium

org.kuali.rice.kim.lookup.KimDocumentRoleMemberLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Call to equals() comparing different types in org.kuali.rice.kim.lookup.KimDocumentRoleMemberLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean)CORRECTNESSEC_UNRELATED_TYPES66High
Call to equals() comparing different types in org.kuali.rice.kim.lookup.KimDocumentRoleMemberLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean)CORRECTNESSEC_UNRELATED_TYPES66High

org.kuali.rice.kim.lookup.PermissionLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.lookup.PermissionLookupableHelperServiceImpl.getMemberSearchResults(Map, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR121Medium
Possible null pointer dereference in org.kuali.rice.kim.lookup.PermissionLookupableHelperServiceImpl.getPermissionsWithPermissionSearchCriteria(Map, boolean) due to return value of called methodSTYLENP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE237Medium
Possible null pointer dereference in org.kuali.rice.kim.lookup.PermissionLookupableHelperServiceImpl.getPermissionsWithPermissionSearchCriteria(Map, boolean) due to return value of called methodSTYLENP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE237Medium

org.kuali.rice.kim.lookup.PersonLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Class org.kuali.rice.kim.lookup.PersonLookupableHelperServiceImpl defines non-transient non-serializable instance field titleBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kim.lookup.ResponsibilityLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.lookup.ResponsibilityLookupableHelperServiceImpl.getMemberSearchResults(Map, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR124Medium
Possible null pointer dereference in org.kuali.rice.kim.lookup.ResponsibilityLookupableHelperServiceImpl.getResponsibilitiesWithResponsibilitySearchCriteria(Map, boolean) due to return value of called methodSTYLENP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE247Medium
Possible null pointer dereference in org.kuali.rice.kim.lookup.ResponsibilityLookupableHelperServiceImpl.getResponsibilitiesWithResponsibilitySearchCriteria(Map, boolean) due to return value of called methodSTYLENP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE247Medium

org.kuali.rice.kim.lookup.RoleLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Dead store to attributeRows in org.kuali.rice.kim.lookup.RoleLookupableHelperServiceImpl.getRows()STYLEDLS_DEAD_LOCAL_STORE253High
Dead store to kimTypeId in org.kuali.rice.kim.lookup.RoleLookupableHelperServiceImpl.getSearchResults(Map)STYLEDLS_DEAD_LOCAL_STORE113Medium
Method org.kuali.rice.kim.lookup.RoleLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR297Medium

org.kuali.rice.kim.lookup.RoleMemberLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.lookup.RoleMemberLookupableHelperServiceImpl.getActualSizeIfTruncated(List) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR318Medium

org.kuali.rice.kim.rule.event.ui.AddPersonDocumentDelegationMemberQualifierEvent

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from org.kuali.rice.kns.rule.BusinessRule to org.kuali.rice.kim.rule.ui.AddPersonDocumentDelegationMemberQualifierRule in org.kuali.rice.kim.rule.event.ui.AddPersonDocumentDelegationMemberQualifierEvent.invokeRuleMethod(BusinessRule)STYLEBC_UNCONFIRMED_CAST58Medium

org.kuali.rice.kim.rules.ui.PersonDocumentDelegationMemberRule

BugCategoryDetailsLinePriority
Dead store to document in org.kuali.rice.kim.rules.ui.PersonDocumentDelegationMemberRule.processAddPersonDelegationMember(AddPersonDelegationMemberEvent)STYLEDLS_DEAD_LOCAL_STORE42Medium

org.kuali.rice.kim.service.impl.GroupInternalServiceImpl$MembersDiff

BugCategoryDetailsLinePriority
Should org.kuali.rice.kim.service.impl.GroupInternalServiceImpl$MembersDiff be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC121Medium

org.kuali.rice.kim.service.impl.IdentityManagementServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kim.service.impl.IdentityManagementServiceImpl.getHasPermissionByTemplateCache(String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL322Medium
org.kuali.rice.kim.service.impl.IdentityManagementServiceImpl.getHasPermissionCache(String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL314Medium
org.kuali.rice.kim.service.impl.IdentityManagementServiceImpl.getIsAuthorizedByTemplateNameFromCache(String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL330Medium
org.kuali.rice.kim.service.impl.IdentityManagementServiceImpl.getIsAuthorizedFromCache(String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL338Medium
org.kuali.rice.kim.service.impl.IdentityManagementServiceImpl.getIsGroupMemberOfGroupCache(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL298Medium
org.kuali.rice.kim.service.impl.IdentityManagementServiceImpl.getIsMemberOfGroupCache(String, String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL289Medium

org.kuali.rice.kim.service.impl.KimModuleService

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.service.impl.KimModuleService.getUrlParameters(String, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR185Medium

org.kuali.rice.kim.service.impl.KimTypeInfoServiceImpl

BugCategoryDetailsLinePriority
Possible doublecheck on org.kuali.rice.kim.service.impl.KimTypeInfoServiceImpl.allLoaded in org.kuali.rice.kim.service.impl.KimTypeInfoServiceImpl.getAllTypes()MT_CORRECTNESSDC_DOUBLECHECK47Medium

org.kuali.rice.kim.service.impl.PermissionServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.service.impl.PermissionServiceImpl.getMatchingPermissions(List, AttributeSet) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR275Medium

org.kuali.rice.kim.service.impl.PermissionUpdateServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.service.impl.PermissionUpdateServiceImpl.savePermission(String, String, String, String, String, boolean, AttributeSet) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR88Medium

org.kuali.rice.kim.service.impl.PersonServiceImpl

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kim.service.impl.PersonServiceImpl.convertEntityToPerson(KimEntityDefaultInfo, KimPrincipal), since all RuntimeException are instances of RuntimeExceptionSTYLEBC_VACUOUS_INSTANCEOF184Medium
Method org.kuali.rice.kim.service.impl.PersonServiceImpl.findPeople(Map, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR340Medium
Method org.kuali.rice.kim.service.impl.PersonServiceImpl.convertPersonPropertiesToEntityProperties(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR416Medium
Method org.kuali.rice.kim.service.impl.PersonServiceImpl.getNonPersonSearchCriteria(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR630Medium
Method org.kuali.rice.kim.service.impl.PersonServiceImpl.resolvePrincipalNamesToPrincipalIds(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR696Medium

org.kuali.rice.kim.service.impl.RoleManagementServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kim.service.impl.RoleManagementServiceImpl.shouldCacheRole(String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR415Medium
org.kuali.rice.kim.service.impl.RoleManagementServiceImpl.getPrincipalHasRoleCacheCache(String) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL160Medium

org.kuali.rice.kim.service.impl.RoleServiceBase

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.service.impl.RoleServiceBase.convertQualifierKeys(AttributeSet) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR186Medium
Method org.kuali.rice.kim.service.impl.RoleServiceBase.findDelegateMembersCompleteInfo(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR1000Medium

org.kuali.rice.kim.service.impl.RoleServiceImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of tempService in org.kuali.rice.kim.service.impl.RoleServiceImpl.getDelegationTypeService(String)CORRECTNESSNP_NULL_ON_SOME_PATH640Medium
Method org.kuali.rice.kim.service.impl.RoleServiceImpl.findDelegateMembersCompleteInfo(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR1327Medium
Method org.kuali.rice.kim.service.impl.RoleServiceImpl.getRoleMembers(List, AttributeSet, boolean, Set) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR466Medium
Method org.kuali.rice.kim.service.impl.RoleServiceImpl.getRoleQualifiersForPrincipal(String, List, AttributeSet) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR305Medium
Method org.kuali.rice.kim.service.impl.RoleServiceImpl.getRoleQualifiersForPrincipalIncludingNested(String, List, AttributeSet) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR264Medium
Method org.kuali.rice.kim.service.impl.RoleServiceImpl.principalHasRole(String, List, AttributeSet, boolean) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR895Medium

org.kuali.rice.kim.service.impl.RoleUpdateServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.service.impl.RoleUpdateServiceImpl.addDelegationMemberAttributeData(KimDelegationMemberImpl, AttributeSet, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR392Medium
Method org.kuali.rice.kim.service.impl.RoleUpdateServiceImpl.addMemberAttributeData(RoleMemberImpl, AttributeSet, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR363Medium

org.kuali.rice.kim.service.impl.UiDocumentServiceImpl

BugCategoryDetailsLinePriority
Dead store to origRole in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.saveRole(IdentityManagementRoleDocument)STYLEDLS_DEAD_LOCAL_STORE1999High
Dead store to origMembers in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.getRoleDelegations(IdentityManagementRoleDocument, List)STYLEDLS_DEAD_LOCAL_STORE2370Medium
Dead store to origAttributes in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.getRoleMembers(IdentityManagementRoleDocument, List)STYLEDLS_DEAD_LOCAL_STORE2183Medium
Dead store to pndMemberRoleQualifier in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadDelegationMemberQualifiers(IdentityManagementPersonDocument, AttributeDefinitionMap, List)STYLEDLS_DEAD_LOCAL_STORE454Medium
Dead store to pndMemberRoleQualifier in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadDelegationMemberQualifiers(IdentityManagementRoleDocument, List)STYLEDLS_DEAD_LOCAL_STORE1942Medium
Dead store to pndMember in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadDelegationMembers(IdentityManagementPersonDocument, List, RoleImpl)STYLEDLS_DEAD_LOCAL_STORE423Medium
Dead store to pndMember in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadDelegationMembers(IdentityManagementRoleDocument, List)STYLEDLS_DEAD_LOCAL_STORE1906Medium
Dead store to pndMember in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadGroupMembers(IdentityManagementGroupDocument, List)STYLEDLS_DEAD_LOCAL_STORE2506Medium
Dead store to pndGroupQualifier in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadGroupQualifiers(IdentityManagementGroupDocument, List)STYLEDLS_DEAD_LOCAL_STORE2532Medium
Dead store to pndMemberRoleQualifier in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadRoleMemberQualifiers(IdentityManagementRoleDocument, List)STYLEDLS_DEAD_LOCAL_STORE1825Medium
Dead store to pndMember in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadRoleMembers(IdentityManagementRoleDocument, List)STYLEDLS_DEAD_LOCAL_STORE1593Medium
Dead store to origMembers in org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.populateDelegations(IdentityManagementPersonDocument)STYLEDLS_DEAD_LOCAL_STORE1344Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.getAttributeEntries(AttributeDefinitionMap) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR264Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.getGroupsByIds(List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR2634Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadDelegationMemberQualifiers(IdentityManagementPersonDocument, AttributeDefinitionMap, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR459Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadDelegationMemberQualifiers(IdentityManagementRoleDocument, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR1948Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadGroupQualifiers(IdentityManagementGroupDocument, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR2538Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.loadRoleMemberQualifiers(IdentityManagementRoleDocument, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR1849Medium
Method org.kuali.rice.kim.service.impl.UiDocumentServiceImpl.populateDocRoleQualifier(List, AttributeDefinitionMap) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR718Medium

org.kuali.rice.kim.service.impl.UiDocumentServiceImpl$GroupMemberNameComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kim.service.impl.UiDocumentServiceImpl$GroupMemberNameComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE2492Medium

org.kuali.rice.kim.service.impl.UiDocumentServiceImpl$RoleMemberNameComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kim.service.impl.UiDocumentServiceImpl$RoleMemberNameComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE1580Medium

org.kuali.rice.kim.service.support.impl.KimTypeServiceBase

BugCategoryDetailsLinePriority
instanceof will always return false in org.kuali.rice.kim.service.support.impl.KimTypeServiceBase.extractErrorsFromGlobalVariablesErrorMap(String), since a org.kuali.rice.kns.util.TypedArrayList can't be a StringCORRECTNESSBC_IMPOSSIBLE_INSTANCEOF502Medium
instanceof will always return true in org.kuali.rice.kim.service.support.impl.KimTypeServiceBase.extractErrorsFromGlobalVariablesErrorMap(String), since all org.kuali.rice.kns.util.TypedArrayList are instances of java.util.ListSTYLEBC_VACUOUS_INSTANCEOF505Medium
Method org.kuali.rice.kim.service.support.impl.KimTypeServiceBase.extractErrorsFromGlobalVariablesErrorMap(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION511Medium
Method org.kuali.rice.kim.service.support.impl.KimTypeServiceBase.areAllAttributeValuesEmpty(AttributeSet) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR862Medium
Method org.kuali.rice.kim.service.support.impl.KimTypeServiceBase.getAttributeValue(AttributeSet, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR874Medium
Method org.kuali.rice.kim.service.support.impl.KimTypeServiceBase.validateAttributes(String, AttributeSet) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR178Medium
Method org.kuali.rice.kim.service.support.impl.KimTypeServiceBase.validateReferencesExistAndActive(KimTypeInfo, AttributeSet, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR260Medium

org.kuali.rice.kim.sesn.DistributedSession

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.sesn.DistributedSession.getMaxIdleTime(Long, Date) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR229Medium
Method org.kuali.rice.kim.sesn.DistributedSession.touchSesn(String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR200Medium

org.kuali.rice.kim.util.KualiDateMask

BugCategoryDetailsLinePriority
org.kuali.rice.kim.util.KualiDateMask doesn't override java.util.Date.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS34Medium

org.kuali.rice.kim.web.struts.action.IdentityManagementPersonDocumentAction

BugCategoryDetailsLinePriority
Method org.kuali.rice.kim.web.struts.action.IdentityManagementPersonDocumentAction.addEmpInfo(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR213Medium

org.kuali.rice.kim.workflow.attribute.KimTypeQualifierResolver

BugCategoryDetailsLinePriority
org.kuali.rice.kim.workflow.attribute.KimTypeQualifierResolver.typeServices isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL64High

org.kuali.rice.kns.UserSession

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.UserSession.hasMatchingSessionTicket(String, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR346Medium

org.kuali.rice.kns.authorization.BusinessObjectAuthorizerBase

BugCategoryDetailsLinePriority
Unused field: org.kuali.rice.kns.authorization.BusinessObjectAuthorizerBase.persistenceStructureServicePERFORMANCEUUF_UNUSED_FIELDMedium

org.kuali.rice.kns.bo.AdHocRoutePersonId

BugCategoryDetailsLinePriority
Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kns.bo.AdHocRoutePersonId.equals(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE61Medium

org.kuali.rice.kns.bo.AdHocRouteRecipient

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.bo.AdHocRouteRecipient.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR40Medium
Method new org.kuali.rice.kns.bo.AdHocRouteRecipient() invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR60Medium

org.kuali.rice.kns.bo.AdHocRouteRecipientId

BugCategoryDetailsLinePriority
Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kns.bo.AdHocRouteRecipientId.equals(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE52Medium

org.kuali.rice.kns.bo.AdHocRouteWorkgroupId

BugCategoryDetailsLinePriority
Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kns.bo.AdHocRouteWorkgroupId.equals(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE61Medium

org.kuali.rice.kns.bo.ConcurrentLockId

BugCategoryDetailsLinePriority
Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kns.bo.ConcurrentLockId.equals(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE48Medium

org.kuali.rice.kns.bo.Namespace

BugCategoryDetailsLinePriority
org.kuali.rice.kns.bo.Namespace doesn't override KualiCodeBase.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS27Medium

org.kuali.rice.kns.bo.ParameterDetailTypeId

BugCategoryDetailsLinePriority
Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kns.bo.ParameterDetailTypeId.equals(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE48Medium

org.kuali.rice.kns.bo.ParameterId

BugCategoryDetailsLinePriority
Redundant nullcheck of o, which is known to be non-null in org.kuali.rice.kns.bo.ParameterId.equals(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE52Medium

org.kuali.rice.kns.bo.PersistableAttachmentBase

BugCategoryDetailsLinePriority
org.kuali.rice.kns.bo.PersistableAttachmentBase.getAttachmentContent() may expose internal representation by returning PersistableAttachmentBase.attachmentContentMALICIOUS_CODEEI_EXPOSE_REP37Medium
org.kuali.rice.kns.bo.PersistableAttachmentBase.setAttachmentContent(byte[]) may expose internal representation by storing an externally mutable object into PersistableAttachmentBase.attachmentContentMALICIOUS_CODEEI_EXPOSE_REP246Medium

org.kuali.rice.kns.bo.SessionDocument

BugCategoryDetailsLinePriority
org.kuali.rice.kns.bo.SessionDocument.getSerializedDocumentForm() may expose internal representation by returning SessionDocument.serializedDocumentFormMALICIOUS_CODEEI_EXPOSE_REP46Medium
org.kuali.rice.kns.bo.SessionDocument.setSerializedDocumentForm(byte[]) may expose internal representation by storing an externally mutable object into SessionDocument.serializedDocumentFormMALICIOUS_CODEEI_EXPOSE_REP253Medium

org.kuali.rice.kns.bo.options.StateValuesFinder

BugCategoryDetailsLinePriority
Write to static field org.kuali.rice.kns.bo.options.StateValuesFinder.labels from instance method org.kuali.rice.kns.bo.options.StateValuesFinder.clearInternalCache()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD62High

org.kuali.rice.kns.dao.impl.LookupDaoJpa

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.dao.impl.LookupDaoJpa.executeSearch(Class, Criteria, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR205Medium
Comparison of String parameter using == or != in org.kuali.rice.kns.dao.impl.LookupDaoJpa.addLogicalOperatorCriteria(String, String, Class, boolean, Criteria, String) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ558Medium
Potentially dangerous use of non-short-circuit logic in org.kuali.rice.kns.dao.impl.LookupDaoJpa.findObjectByMap(Object, Map)STYLENS_DANGEROUS_NON_SHORT_CIRCUIT354High
Method org.kuali.rice.kns.dao.impl.LookupDaoJpa.addInactivateableFromToCurrentCriteria(Object, String, Criteria, Map) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION511Medium
Method org.kuali.rice.kns.dao.impl.LookupDaoJpa.findCountByMap(Object, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR80Medium
Method org.kuali.rice.kns.dao.impl.LookupDaoJpa.findObjectByMap(Object, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR350Medium
Method org.kuali.rice.kns.dao.impl.LookupDaoJpa.getCollectionCriteriaFromMap(PersistableBusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR141Medium

org.kuali.rice.kns.dao.impl.LookupDaoOjb

BugCategoryDetailsLinePriority
Dead store to searchResults in org.kuali.rice.kns.dao.impl.LookupDaoOjb.executeSearch(Class, Criteria, boolean)STYLEDLS_DEAD_LOCAL_STORE153Medium
Method org.kuali.rice.kns.dao.impl.LookupDaoOjb.executeSearch(Class, Criteria, boolean) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR158Medium
Method org.kuali.rice.kns.dao.impl.LookupDaoOjb.findCountByMap(Object, Map) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR254Medium
Comparison of String parameter using == or != in org.kuali.rice.kns.dao.impl.LookupDaoOjb.addLogicalOperatorCriteria(String, String, Class, boolean, Criteria, String) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ483Medium
Potentially dangerous use of non-short-circuit logic in org.kuali.rice.kns.dao.impl.LookupDaoOjb.findObjectByMap(Object, Map)STYLENS_DANGEROUS_NON_SHORT_CIRCUIT273High
Method org.kuali.rice.kns.dao.impl.LookupDaoOjb.findCountByMap(Object, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR226Medium
Method org.kuali.rice.kns.dao.impl.LookupDaoOjb.findObjectByMap(Object, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR269Medium
Method org.kuali.rice.kns.dao.impl.LookupDaoOjb.getCollectionCriteriaFromMap(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR96Medium

org.kuali.rice.kns.dao.impl.PersistenceDaoJpa

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.kuali.rice.kns.dao.impl.PersistenceDaoJpa.retrieveReference(Object, String)STYLEREC_CATCH_EXCEPTION108Medium

org.kuali.rice.kns.dao.proxy.PersistenceDaoProxy

BugCategoryDetailsLinePriority
Dead store to entityManager in org.kuali.rice.kns.dao.proxy.PersistenceDaoProxy.getDao(Class)STYLEDLS_DEAD_LOCAL_STORE58Medium

org.kuali.rice.kns.datadictionary.DataDictionary

BugCategoryDetailsLinePriority
Dead store to collectionClasses in org.kuali.rice.kns.datadictionary.DataDictionary.buildReadDescriptor(Class, String)STYLEDLS_DEAD_LOCAL_STORE516Medium
Dead store to collectionClasses in org.kuali.rice.kns.datadictionary.DataDictionary.getCollectionElementClass(Class, String)STYLEDLS_DEAD_LOCAL_STORE457Medium
Dead store to indexName in org.kuali.rice.kns.datadictionary.DataDictionary.indexSource(String)STYLEDLS_DEAD_LOCAL_STORE122Medium
org.kuali.rice.kns.datadictionary.DataDictionary.persistenceStructureService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
Write to static field org.kuali.rice.kns.datadictionary.DataDictionary.validateEBOs from instance method org.kuali.rice.kns.datadictionary.DataDictionary.validateDD()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD183High
Write to static field org.kuali.rice.kns.datadictionary.DataDictionary.validateEBOs from instance method org.kuali.rice.kns.datadictionary.DataDictionary.validateDD(boolean)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD171High

org.kuali.rice.kns.datadictionary.PrimitiveAttributeDefinition

BugCategoryDetailsLinePriority
Possible null pointer dereference of sourceClass in org.kuali.rice.kns.datadictionary.PrimitiveAttributeDefinition.completeValidation(Class, Class)CORRECTNESSNP_NULL_ON_SOME_PATH103Medium

org.kuali.rice.kns.datadictionary.control.ApcSelectControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.ApcSelectControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE37Medium

org.kuali.rice.kns.datadictionary.control.ButtonControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.ButtonControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE30Medium

org.kuali.rice.kns.datadictionary.control.CheckboxControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.CheckboxControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE29Medium

org.kuali.rice.kns.datadictionary.control.ControlDefinitionBase

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.ControlDefinitionBase defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE420Medium

org.kuali.rice.kns.datadictionary.control.CurrencyControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.CurrencyControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE37Medium

org.kuali.rice.kns.datadictionary.control.FileControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.FileControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE31Medium

org.kuali.rice.kns.datadictionary.control.HiddenControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.HiddenControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE27Medium

org.kuali.rice.kns.datadictionary.control.KualiUserControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.KualiUserControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE48Medium

org.kuali.rice.kns.datadictionary.control.LinkControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.LinkControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE34Medium

org.kuali.rice.kns.datadictionary.control.LookupHiddenControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.LookupHiddenControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE28Medium

org.kuali.rice.kns.datadictionary.control.LookupReadonlyControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.LookupReadonlyControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE28Medium

org.kuali.rice.kns.datadictionary.control.MultiselectControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.MultiselectControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE27Medium

org.kuali.rice.kns.datadictionary.control.RadioControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.RadioControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE28Medium

org.kuali.rice.kns.datadictionary.control.SelectControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.SelectControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE32Medium

org.kuali.rice.kns.datadictionary.control.TextControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.TextControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE29Medium

org.kuali.rice.kns.datadictionary.control.TextareaControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.TextareaControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE27Medium

org.kuali.rice.kns.datadictionary.control.WorkflowWorkgroupControlDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.kns.datadictionary.control.WorkflowWorkgroupControlDefinition inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE32Medium

org.kuali.rice.kns.datadictionary.validation.CharacterLevelValidationPattern

BugCategoryDetailsLinePriority
Dead store to regexString in org.kuali.rice.kns.datadictionary.validation.CharacterLevelValidationPattern.getRegexPattern()STYLEDLS_DEAD_LOCAL_STORE81Medium

org.kuali.rice.kns.datadictionary.validation.charlevel.RegexValidationPattern

BugCategoryDetailsLinePriority
Possible null pointer dereference of exportMap in org.kuali.rice.kns.datadictionary.validation.charlevel.RegexValidationPattern.extendExportMap(ExportMap)CORRECTNESSNP_NULL_ON_SOME_PATH53High
Nullcheck of exportMap at line 58 of value previously dereferenced in org.kuali.rice.kns.datadictionary.validation.charlevel.RegexValidationPattern.extendExportMap(ExportMap)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE53High

org.kuali.rice.kns.document.MaintenanceDocumentBase

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kns.document.MaintenanceDocumentBase.validateBusinessRules(KualiDocumentEvent), since all org.kuali.rice.kns.document.MaintenanceDocumentBase are instances of org.kuali.rice.kns.document.MaintenanceDocumentSTYLEBC_VACUOUS_INSTANCEOF704Medium

org.kuali.rice.kns.document.authorization.DocumentAuthorizerBase

BugCategoryDetailsLinePriority
org.kuali.rice.kns.document.authorization.DocumentAuthorizerBase.LOG isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL47High

org.kuali.rice.kns.document.authorization.MaintenanceDocumentAuthorizerBase

BugCategoryDetailsLinePriority
org.kuali.rice.kns.document.authorization.MaintenanceDocumentAuthorizerBase.maintenanceDocumentDictionaryService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium

org.kuali.rice.kns.document.authorization.MaintenanceDocumentPresentationControllerBase

BugCategoryDetailsLinePriority
org.kuali.rice.kns.document.authorization.MaintenanceDocumentPresentationControllerBase.maintenanceDocumentDictionaryService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium

org.kuali.rice.kns.document.authorization.MaintenanceDocumentRestrictionsBase

BugCategoryDetailsLinePriority
Possible null pointer dereference of fieldRestriction in org.kuali.rice.kns.document.authorization.MaintenanceDocumentRestrictionsBase.getFieldRestriction(String)CORRECTNESSNP_NULL_ON_SOME_PATH54Medium

org.kuali.rice.kns.exception.ExceptionIncident

BugCategoryDetailsLinePriority
Method call in new org.kuali.rice.kns.exception.ExceptionIncident(Exception, Map) passes null for nonnull parameter of initialize(Exception, Map)CORRECTNESSNP_NULL_PARAM_DEREF79High

org.kuali.rice.kns.inquiry.KualiInquirableImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kns.inquiry.KualiInquirableImpl.businessObjectService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kns.inquiry.KualiInquirableImpl.SUPER_CLASS_TRANSLATOR_LIST isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL88High

org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Dead store to fieldsForLookup in org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.performLookup(LookupForm, Collection, boolean)STYLEDLS_DEAD_LOCAL_STORE1085High
Dead store to fields in org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.setRows()STYLEDLS_DEAD_LOCAL_STORE1036Medium
org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.getSupplementalMenuBar() invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR1362Medium
org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.RESULTS_DEFAULT_MAX_COLUMN_LENGTH should be package protectedMALICIOUS_CODEMS_PKGPROTECT694Medium
Method org.kuali.rice.kns.lookup.AbstractLookupableHelperServiceImpl.preprocessDateFields(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR1226Medium

org.kuali.rice.kns.lookup.HtmlData

BugCategoryDetailsLinePriority
Dead store to elementClass in org.kuali.rice.kns.lookup.HtmlData.getTitleText(String, Class, Map)STYLEDLS_DEAD_LOCAL_STORE214Medium
Method org.kuali.rice.kns.lookup.HtmlData.getTitleText(String, Class, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR217Medium

org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl.getExternalizableBusinessObjectFieldValues(String, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR159Medium
Method org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl.getSearchResultsHelper(Map, boolean) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR227Medium
Method org.kuali.rice.kns.lookup.KualiLookupableHelperServiceImpl.removeExternalizableBusinessObjectFieldValues(Class, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR142Medium

org.kuali.rice.kns.lookup.LookupUtils

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.lookup.LookupUtils.generateFieldConversions(BusinessObject, String, BusinessObjectRelationship, String, List, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION686Medium
Method org.kuali.rice.kns.lookup.LookupUtils.generateLookupParameters(BusinessObject, String, BusinessObjectRelationship, String, List, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION724Medium
Method org.kuali.rice.kns.lookup.LookupUtils.getNestedBusinessObject(BusinessObject, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION635Medium
Method org.kuali.rice.kns.lookup.LookupUtils.setFieldDirectInquiry(Field) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION509Medium
Write to static field org.kuali.rice.kns.lookup.LookupUtils.businessObjectDictionaryService from instance method org.kuali.rice.kns.lookup.LookupUtils.setBusinessObjectDictionaryService(BusinessObjectDictionaryService)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD77High
Write to static field org.kuali.rice.kns.lookup.LookupUtils.businessObjectMetaDataService from instance method org.kuali.rice.kns.lookup.LookupUtils.setBusinessObjectMetaDataService(BusinessObjectMetaDataService)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD101High
Write to static field org.kuali.rice.kns.lookup.LookupUtils.dataDictionaryService from instance method org.kuali.rice.kns.lookup.LookupUtils.setDataDictionaryService(DataDictionaryService)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD81High
Write to static field org.kuali.rice.kns.lookup.LookupUtils.dateTimeService from instance method org.kuali.rice.kns.lookup.LookupUtils.setDateTimeService(DateTimeService)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD93High
Write to static field org.kuali.rice.kns.lookup.LookupUtils.kualiConfigurationService from instance method org.kuali.rice.kns.lookup.LookupUtils.setKualiConfigurationService(KualiConfigurationService)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD89High
Write to static field org.kuali.rice.kns.lookup.LookupUtils.persistenceStructureService from instance method org.kuali.rice.kns.lookup.LookupUtils.setPersistenceStructureService(PersistenceStructureService)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD85High
Method org.kuali.rice.kns.lookup.LookupUtils.forceUppercase(Class, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR173Medium
Method org.kuali.rice.kns.lookup.LookupUtils.getPrimitiveReference(BusinessObject, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR591Medium

org.kuali.rice.kns.lookup.keyvalues.ApcValuesFinder

BugCategoryDetailsLinePriority
Self assignment of field ApcValuesFinder.parameterNamespace in new org.kuali.rice.kns.lookup.keyvalues.ApcValuesFinder(String, String, String)CORRECTNESSSA_FIELD_SELF_ASSIGNMENT42High
Uninitialized read of parameterNamespace in new org.kuali.rice.kns.lookup.keyvalues.ApcValuesFinder(String, String, String)CORRECTNESSUR_UNINIT_READ42High

org.kuali.rice.kns.lookup.keyvalues.CampusTypeComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kns.lookup.keyvalues.CampusTypeComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE24Medium

org.kuali.rice.kns.lookup.keyvalues.CampusValuesFinder

BugCategoryDetailsLinePriority
Incorrect lazy initialization of static field org.kuali.rice.kns.lookup.keyvalues.CampusValuesFinder.campusCache in org.kuali.rice.kns.lookup.keyvalues.CampusValuesFinder.getKeyValues()MT_CORRECTNESSLI_LAZY_INIT_STATIC41Medium
org.kuali.rice.kns.lookup.keyvalues.CampusValuesFinder.campusCache should be package protectedMALICIOUS_CODEMS_PKGPROTECT34Medium
Write to static field org.kuali.rice.kns.lookup.keyvalues.CampusValuesFinder.campusCache from instance method org.kuali.rice.kns.lookup.keyvalues.CampusValuesFinder.clearInternalCache()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD60High
Sychronization on getClass rather than class literal in org.kuali.rice.kns.lookup.keyvalues.CampusValuesFinder.getKeyValues()MT_CORRECTNESSWL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL42Medium

org.kuali.rice.kns.lookup.keyvalues.NamespaceComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kns.lookup.keyvalues.NamespaceComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE22Medium

org.kuali.rice.kns.lookup.keyvalues.ParameterTypeComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kns.lookup.keyvalues.ParameterTypeComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE22Medium

org.kuali.rice.kns.maintenance.KualiMaintainableImpl

BugCategoryDetailsLinePriority
Dead store to cachedValues in org.kuali.rice.kns.maintenance.KualiMaintainableImpl.setGenerateDefaultValues(String)STYLEDLS_DEAD_LOCAL_STORE710Medium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.getMultiValueIdentifierList(Collection, List) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR544Medium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.hasBusinessObjectExisted(BusinessObject, List, List) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR556Medium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.businessObjectAuthorizationService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.businessObjectDictionaryService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.businessObjectMetaDataService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.businessObjectService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.dataDictionaryService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.documentHelperService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.encryptionService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.maintenanceDocumentDictionaryService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.maintenanceDocumentService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.persistenceStructureService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
org.kuali.rice.kns.maintenance.KualiMaintainableImpl.personService should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.getMultiValueIdentifierList(Collection, List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION546Medium
Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.hasBusinessObjectExisted(BusinessObject, List, List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION558Medium
Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.decryptEncryptedData(Map, MaintenanceDocument, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR219Medium
Method org.kuali.rice.kns.maintenance.KualiMaintainableImpl.performFieldForceUpperCase(BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR1387Medium

org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase

BugCategoryDetailsLinePriority
Dead store to fieldValues in org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase.putInactivationBlockingErrorOnPage(MaintenanceDocument, InactivationBlockingMetadata)STYLEDLS_DEAD_LOCAL_STORE306Medium
Invocation of toString on org.kuali.rice.kns.util.ErrorMessage.getMessageParameters() in org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase.showErrorMap()CORRECTNESSDMI_INVOKING_TOSTRING_ON_ARRAY1108Medium
org.kuali.rice.kns.maintenance.rules.MaintenanceDocumentRuleBase.LOG isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL76High

org.kuali.rice.kns.rule.event.DocumentAuditEvent

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from org.kuali.rice.kns.rule.BusinessRule to org.kuali.rice.kns.rule.DocumentAuditRule in org.kuali.rice.kns.rule.event.DocumentAuditEvent.invokeRuleMethod(BusinessRule)STYLEBC_UNCONFIRMED_CAST63Medium

org.kuali.rice.kns.rules.DocumentRuleBase

BugCategoryDetailsLinePriority
Dead store to docOrBoClass in org.kuali.rice.kns.rules.DocumentRuleBase.isAddHocRoutePersonValid(Document, AdHocRoutePerson)STYLEDLS_DEAD_LOCAL_STORE382Medium

org.kuali.rice.kns.rules.PromptBeforeValidationBase

BugCategoryDetailsLinePriority
org.kuali.rice.kns.rules.PromptBeforeValidationBase.askOrAnalyzeYesNoQuestion(String, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR222Medium
org.kuali.rice.kns.rules.PromptBeforeValidationBase.LOG isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL48High

org.kuali.rice.kns.rules.PromptBeforeValidationBase$ContextSession

BugCategoryDetailsLinePriority
Should org.kuali.rice.kns.rules.PromptBeforeValidationBase$ContextSession be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC74Medium

org.kuali.rice.kns.rules.PromptBeforeValidationBase$IsAskingException

BugCategoryDetailsLinePriority
Should org.kuali.rice.kns.rules.PromptBeforeValidationBase$IsAskingException be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC55Medium

org.kuali.rice.kns.service.impl.AttachmentServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.service.impl.AttachmentServiceImpl.createAttachment(PersistableBusinessObject, String, String, int, InputStream, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR92Medium
org.kuali.rice.kns.service.impl.AttachmentServiceImpl.deleteAttachmentContents(Attachment) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE164Medium
org.kuali.rice.kns.service.impl.AttachmentServiceImpl.deletePendingAttachmentsModifiedBefore(long) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE244Medium
org.kuali.rice.kns.service.impl.AttachmentServiceImpl.moveAttachmentFromPending(Attachment, String) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE153Medium

org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.service.impl.BusinessObjectAuthorizationServiceImpl.getButtonFieldPermissionDetails(BusinessObject, String) uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES653Medium

org.kuali.rice.kns.service.impl.BusinessObjectMetaDataServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.service.impl.BusinessObjectMetaDataServiceImpl.getNestedBOClass(BusinessObject, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION445Medium

org.kuali.rice.kns.service.impl.BusinessObjectServiceImpl

BugCategoryDetailsLinePriority
Possible doublecheck on org.kuali.rice.kns.service.impl.BusinessObjectServiceImpl.illegalBusinessObjectsForSaveInitialized in org.kuali.rice.kns.service.impl.BusinessObjectServiceImpl.isBusinessObjectAllowedForSave(PersistableBusinessObject)MT_CORRECTNESSDC_DOUBLECHECK141Medium
org.kuali.rice.kns.service.impl.BusinessObjectServiceImpl.isBusinessObjectAllowedForSave(PersistableBusinessObject) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR146Medium
Method org.kuali.rice.kns.service.impl.BusinessObjectServiceImpl.getReferenceIfExists(BusinessObject, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR315Medium
Method org.kuali.rice.kns.service.impl.BusinessObjectServiceImpl.linkUserFields(List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR414Medium

org.kuali.rice.kns.service.impl.ConfigurableDateTimeServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.kns.service.impl.ConfigurableDateTimeServiceImpl.getCurrentDate() may expose internal representation by returning ConfigurableDateTimeServiceImpl.currentDateMALICIOUS_CODEEI_EXPOSE_REP36Medium
org.kuali.rice.kns.service.impl.ConfigurableDateTimeServiceImpl.setCurrentDate(Date) may expose internal representation by storing an externally mutable object into ConfigurableDateTimeServiceImpl.currentDateMALICIOUS_CODEEI_EXPOSE_REP231Medium

org.kuali.rice.kns.service.impl.DictionaryValidationServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.service.impl.DictionaryValidationServiceImpl.validateBusinessObjectsFromDescriptors(Object, PropertyDescriptor[], int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR555Medium

org.kuali.rice.kns.service.impl.InactivateableFromToServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.service.impl.InactivateableFromToServiceImpl.buildGroupByValueString(BusinessObject, List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION193Medium

org.kuali.rice.kns.service.impl.InactivationBlockingDisplayServiceImpl

BugCategoryDetailsLinePriority
Unread field: org.kuali.rice.kns.service.impl.InactivationBlockingDisplayServiceImpl.persistenceServicePERFORMANCEURF_UNREAD_FIELD141Medium

org.kuali.rice.kns.service.impl.KualiExceptionIncidentServiceImpl

BugCategoryDetailsLinePriority
Possible null pointer dereference of exceptionIncident in org.kuali.rice.kns.service.impl.KualiExceptionIncidentServiceImpl.report(KualiExceptionIncident)CORRECTNESSNP_NULL_ON_SOME_PATH173High

org.kuali.rice.kns.service.impl.MaintenanceDocumentDictionaryServiceImpl

BugCategoryDetailsLinePriority
Dead store to subItems in org.kuali.rice.kns.service.impl.MaintenanceDocumentDictionaryServiceImpl.getMaintainableItem(String, String)STYLEDLS_DEAD_LOCAL_STORE423Medium
org.kuali.rice.kns.service.impl.MaintenanceDocumentDictionaryServiceImpl.LOG isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL49High

org.kuali.rice.kns.service.impl.ModuleServiceBase

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.service.impl.ModuleServiceBase.getExternalizableBusinessObjectLookupUrl(Class, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR221Medium
Method org.kuali.rice.kns.service.impl.ModuleServiceBase.getUrlParameters(String, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR182Medium

org.kuali.rice.kns.service.impl.ParameterServiceBase

BugCategoryDetailsLinePriority
Dead store to key in org.kuali.rice.kns.service.impl.ParameterServiceBase.getParameter(Class, String)STYLEDLS_DEAD_LOCAL_STORE426Medium

org.kuali.rice.kns.service.impl.PersistenceStructureServiceJpaImpl

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kns.service.impl.PersistenceStructureServiceJpaImpl.listCollectionObjectTypes(PersistableBusinessObject), since all org.kuali.rice.kns.bo.PersistableBusinessObject are instances of org.kuali.rice.kns.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF609Medium
instanceof will always return true in org.kuali.rice.kns.service.impl.PersistenceStructureServiceJpaImpl.listReferenceObjectFields(PersistableBusinessObject), since all org.kuali.rice.kns.bo.PersistableBusinessObject are instances of org.kuali.rice.kns.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF624Medium
org.kuali.rice.kns.service.impl.PersistenceStructureServiceJpaImpl.referenceConversionMap isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL62High

org.kuali.rice.kns.service.impl.PersistenceStructureServiceOjbImpl

BugCategoryDetailsLinePriority
instanceof will always return true in org.kuali.rice.kns.service.impl.PersistenceStructureServiceOjbImpl.listCollectionObjectTypes(PersistableBusinessObject), since all org.kuali.rice.kns.bo.PersistableBusinessObject are instances of org.kuali.rice.kns.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF648Medium
instanceof will always return true in org.kuali.rice.kns.service.impl.PersistenceStructureServiceOjbImpl.listReferenceObjectFields(PersistableBusinessObject), since all org.kuali.rice.kns.bo.PersistableBusinessObject are instances of org.kuali.rice.kns.bo.PersistableBusinessObjectSTYLEBC_VACUOUS_INSTANCEOF663Medium
org.kuali.rice.kns.service.impl.PersistenceStructureServiceOjbImpl.referenceConversionMap isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL63High

org.kuali.rice.kns.service.impl.PostProcessorServiceImpl

BugCategoryDetailsLinePriority
Call to equals() comparing different types in org.kuali.rice.kns.service.impl.PostProcessorServiceImpl.doActionTaken(ActionTakenEventDTO)CORRECTNESSEC_UNRELATED_TYPES146High

org.kuali.rice.kns.service.impl.SessionDocumentServiceImpl

BugCategoryDetailsLinePriority
Nullcheck of form at line 212 of value previously dereferenced in org.kuali.rice.kns.service.impl.SessionDocumentServiceImpl.setDocumentForm(KualiDocumentFormBase, UserSession, String)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE163High

org.kuali.rice.kns.util.AuditError

BugCategoryDetailsLinePriority
org.kuali.rice.kns.util.AuditError.getParams() may expose internal representation by returning AuditError.paramsMALICIOUS_CODEEI_EXPOSE_REP103Medium
org.kuali.rice.kns.util.AuditError.setParams(String[]) may expose internal representation by storing an externally mutable object into AuditError.paramsMALICIOUS_CODEEI_EXPOSE_REP2112Medium

org.kuali.rice.kns.util.BeanPropertyComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kns.util.BeanPropertyComparator$1 stored into non-transient field BeanPropertyComparator.booleanComparatorBAD_PRACTICESE_BAD_FIELD_STORE77High

org.kuali.rice.kns.util.DateUtils

BugCategoryDetailsLinePriority
integral division result cast to double or float in org.kuali.rice.kns.util.DateUtils.getDifferenceInDays(Timestamp, Timestamp)STYLEICAST_IDIV_CAST_TO_DOUBLE146Medium

org.kuali.rice.kns.util.ErrorMessage

BugCategoryDetailsLinePriority
org.kuali.rice.kns.util.ErrorMessage.getMessageParameters() may expose internal representation by returning ErrorMessage.messageParametersMALICIOUS_CODEEI_EXPOSE_REP75Medium
org.kuali.rice.kns.util.ErrorMessage.setMessageParameters(String[]) may expose internal representation by storing an externally mutable object into ErrorMessage.messageParametersMALICIOUS_CODEEI_EXPOSE_REP271Medium

org.kuali.rice.kns.util.FieldUtils

BugCategoryDetailsLinePriority
Dead store to meshedRows in org.kuali.rice.kns.util.FieldUtils.meshSections(List, List, List, String, boolean, MaintenanceDocumentRestrictions, String, String)STYLEDLS_DEAD_LOCAL_STORE1085Medium
Method org.kuali.rice.kns.util.FieldUtils.fixFieldForForm(Field, List, String, String, boolean, MaintenanceDocumentRestrictions, String, String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION854Medium
Method org.kuali.rice.kns.util.FieldUtils.populateBusinessObjectFromMap(BusinessObject, Map, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR743Medium

org.kuali.rice.kns.util.InactiveRecordsHidingUtils

BugCategoryDetailsLinePriority
org.kuali.rice.kns.util.InactiveRecordsHidingUtils.setShowInactiveRecords(Map, String, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR78Medium

org.kuali.rice.kns.util.KNSUtils

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.util.KNSUtils.getIntegerValue(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR86Medium

org.kuali.rice.kns.util.MessageMap

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.util.MessageMap.getMessageCount(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR355Medium
Method org.kuali.rice.kns.util.MessageMap.merge(Map, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR84Medium

org.kuali.rice.kns.util.NumberUtils

BugCategoryDetailsLinePriority

org.kuali.rice.kns.util.ObjectUtils

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.util.ObjectUtils.createHybridBusinessObject(BusinessObject, BusinessObject, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR196Medium
Method org.kuali.rice.kns.util.ObjectUtils.equalByKeys(PersistableBusinessObject, PersistableBusinessObject) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR692Medium
Method org.kuali.rice.kns.util.ObjectUtils.materializeSubObjectsToDepth(PersistableBusinessObject, int) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR930Medium

org.kuali.rice.kns.util.OjbCharBooleanConversion

BugCategoryDetailsLinePriority
Redundant nullcheck of source, which is known to be non-null in org.kuali.rice.kns.util.OjbCharBooleanConversion.javaToSql(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE32Medium
Redundant nullcheck of source, which is known to be non-null in org.kuali.rice.kns.util.OjbCharBooleanConversion.sqlToJava(Object)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE57Medium

org.kuali.rice.kns.util.OjbKualiIntegerFieldConversion

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.util.OjbKualiIntegerFieldConversion.javaToSql(Object) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR31Medium

org.kuali.rice.kns.util.WebUtils

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from org.kuali.rice.kns.web.struts.pojo.PojoFormBase to org.kuali.rice.kns.web.struts.form.KualiDocumentFormBase in org.kuali.rice.kns.util.WebUtils.isFormSessionDocument(PojoFormBase)STYLEBC_UNCONFIRMED_CAST476Medium
instanceof will always return true in org.kuali.rice.kns.util.WebUtils.getMethodToCallSettingAttribute(ActionForm, HttpServletRequest, String), since all org.apache.struts.action.ActionForm are instances of org.apache.struts.action.ActionFormSTYLEBC_VACUOUS_INSTANCEOF164Medium
Dead store to params in org.kuali.rice.kns.util.WebUtils.getMultipartParameters(HttpServletRequest, ActionServletWrapper, ActionForm, ActionMapping)STYLEDLS_DEAD_LOCAL_STORE346High
Dead store to files in org.kuali.rice.kns.util.WebUtils.getMultipartParameters(HttpServletRequest, ActionServletWrapper, ActionForm, ActionMapping)STYLEDLS_DEAD_LOCAL_STORE364Medium
org.kuali.rice.kns.util.WebUtils.KEY_KUALI_FORM_IN_SESSION isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL482High
Method org.kuali.rice.kns.util.WebUtils.filterHtmlAndReplaceRiceMarkup(String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR705Medium

org.kuali.rice.kns.util.cache.FastByteArrayInputStream

BugCategoryDetailsLinePriority
new org.kuali.rice.kns.util.cache.FastByteArrayInputStream(byte[], int) may expose internal representation by storing an externally mutable object into FastByteArrayInputStream.bufMALICIOUS_CODEEI_EXPOSE_REP240Medium

org.kuali.rice.kns.util.cache.FastByteArrayOutputStream

BugCategoryDetailsLinePriority
org.kuali.rice.kns.util.cache.FastByteArrayOutputStream.getByteArray() may expose internal representation by returning FastByteArrayOutputStream.bufMALICIOUS_CODEEI_EXPOSE_REP69Medium

org.kuali.rice.kns.util.cache.ObjectCacheOSCacheImpl

BugCategoryDetailsLinePriority
Dead store to cache in org.kuali.rice.kns.util.cache.ObjectCacheOSCacheImpl.cache(Identity, Object)STYLEDLS_DEAD_LOCAL_STORE83Medium

org.kuali.rice.kns.util.comparator.BeanPropertyComparator

BugCategoryDetailsLinePriority
org.kuali.rice.kns.util.comparator.BeanPropertyComparator$1 stored into non-transient field BeanPropertyComparator.booleanComparatorBAD_PRACTICESE_BAD_FIELD_STORE78High

org.kuali.rice.kns.util.documentserializer.DocumentSerializationState$SerializationPropertyElement

BugCategoryDetailsLinePriority
Should org.kuali.rice.kns.util.documentserializer.DocumentSerializationState$SerializationPropertyElement be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC38Medium

org.kuali.rice.kns.util.documentserializer.SerializationState$SerializationPropertyElement

BugCategoryDetailsLinePriority
Should org.kuali.rice.kns.util.documentserializer.SerializationState$SerializationPropertyElement be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC38Medium

org.kuali.rice.kns.util.spring.AnnotationAndNameMatchingTransactionAttributeSource

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.util.spring.AnnotationAndNameMatchingTransactionAttributeSource.setTimeout(TransactionAttribute) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR70Medium
org.kuali.rice.kns.util.spring.AnnotationAndNameMatchingTransactionAttributeSource doesn't override org.springframework.transaction.interceptor.NameMatchTransactionAttributeSource.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS29Medium

org.kuali.rice.kns.util.spring.ClassPathXmlApplicationContext

BugCategoryDetailsLinePriority

org.kuali.rice.kns.web.EditablePropertiesHistoryHolder

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.web.EditablePropertiesHistoryHolder.getMaxHistoryLength() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR59Medium
org.kuali.rice.kns.web.EditablePropertiesHistoryHolder is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONID38Medium

org.kuali.rice.kns.web.format.FormatException

BugCategoryDetailsLinePriority
org.kuali.rice.kns.web.format.FormatException.getErrorArgs() may expose internal representation by returning FormatException.errorArgsMALICIOUS_CODEEI_EXPOSE_REP113Medium

org.kuali.rice.kns.web.format.Formatter

BugCategoryDetailsLinePriority
org.kuali.rice.kns.web.format.Formatter.unwrapString(Object) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR516Medium
Nullcheck of target at line 515 of value previously dereferenced in org.kuali.rice.kns.web.format.Formatter.unwrapString(Object)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE509High

org.kuali.rice.kns.web.servlet.KualiDWRServlet

BugCategoryDetailsLinePriority
org.kuali.rice.kns.web.servlet.KualiDWRServlet.init(ServletConfig) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR50Medium
org.kuali.rice.kns.web.servlet.KualiDWRServlet.HACK_ADDITIONAL_FILES isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL44High

org.kuali.rice.kns.web.servlet.PostDataLoadEncryptionServlet

BugCategoryDetailsLinePriority
org.kuali.rice.kns.web.servlet.PostDataLoadEncryptionServlet.service(ServletRequest, ServletResponse) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR70Medium
Method org.kuali.rice.kns.web.servlet.PostDataLoadEncryptionServlet.execute(String, boolean) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR92Medium

org.kuali.rice.kns.web.servlet.dwr.GlobalResourceDelegatingSpringCreator

BugCategoryDetailsLinePriority
org.kuali.rice.kns.web.servlet.dwr.GlobalResourceDelegatingSpringCreator.APPLICATION_BEAN_FACTORY isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINALMedium

org.kuali.rice.kns.web.struts.action.KualiAction

BugCategoryDetailsLinePriority
Invocation of toString on textAreaParams in org.kuali.rice.kns.web.struts.action.KualiAction.getTextAreaParams(HttpServletRequest)CORRECTNESSDMI_INVOKING_TOSTRING_ON_ARRAY1055Medium
Invocation of toString on inquiryParams in org.kuali.rice.kns.web.struts.action.KualiAction.performInquiry(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)CORRECTNESSDMI_INVOKING_TOSTRING_ON_ARRAY667Medium
org.kuali.rice.kns.web.struts.action.KualiAction.performLookup(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR542Medium

org.kuali.rice.kns.web.struts.action.KualiActionServlet

BugCategoryDetailsLinePriority
Class org.kuali.rice.kns.web.struts.action.KualiActionServlet defines non-transient non-serializable instance field serverConfigOverrideBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kns.web.struts.action.KualiActionServlet$KualiActionServletConfig

BugCategoryDetailsLinePriority
Should org.kuali.rice.kns.web.struts.action.KualiActionServlet$KualiActionServletConfig be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC116Medium

org.kuali.rice.kns.web.struts.action.KualiDocumentActionBase

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.web.struts.action.KualiDocumentActionBase.disapprove(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR942Medium
org.kuali.rice.kns.web.struts.action.KualiDocumentActionBase.DOCUMENT_LOAD_COMMANDS should be package protectedMALICIOUS_CODEMS_PKGPROTECT115Medium

org.kuali.rice.kns.web.struts.action.KualiExceptionHandlerAction

BugCategoryDetailsLinePriority
Dead store to cancelForward in org.kuali.rice.kns.web.struts.action.KualiExceptionHandlerAction.executeException(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE128Medium

org.kuali.rice.kns.web.struts.action.KualiHelpAction

BugCategoryDetailsLinePriority
Dead store to helpForm in org.kuali.rice.kns.web.struts.action.KualiHelpAction.getHelpUrlByNamespace(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE458Medium
org.kuali.rice.kns.web.struts.action.KualiHelpAction.getAttributeValidationPatternName(AttributeDefinition) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR132Medium

org.kuali.rice.kns.web.struts.action.KualiInquiryAction

BugCategoryDetailsLinePriority
Dead store to kualiInquirable in org.kuali.rice.kns.web.struts.action.KualiInquiryAction.toggleTab(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE297Medium
Load of known null value in org.kuali.rice.kns.web.struts.action.KualiInquiryAction.export(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLENP_LOAD_OF_KNOWN_NULL_VALUE363Medium
Method org.kuali.rice.kns.web.struts.action.KualiInquiryAction.getRoleQualification(ActionForm, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR95Medium

org.kuali.rice.kns.web.struts.action.KualiLookupAction

BugCategoryDetailsLinePriority
Dead store to displayList in org.kuali.rice.kns.web.struts.action.KualiLookupAction.search(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE198Medium
Dead store to refreshCaller in org.kuali.rice.kns.web.struts.action.KualiLookupAction.search(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE241Medium

org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction

BugCategoryDetailsLinePriority
Dead store to documentAuthorizer in org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction.clearUnauthorizedNewFields(MaintenanceDocument)STYLEDLS_DEAD_LOCAL_STORE952Medium
Dead store to newBo in org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction.clearUnauthorizedNewFields(MaintenanceDocument)STYLEDLS_DEAD_LOCAL_STORE958Medium
Dead store to maintenanceDocumentAuthorizer in org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction.populateAuthorizationFields(KualiDocumentFormBase)STYLEDLS_DEAD_LOCAL_STORE994Medium
Redundant nullcheck of collectionName, which is known to be non-null in org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction.deleteLine(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE822Medium
Method org.kuali.rice.kns.web.struts.action.KualiMaintenanceDocumentAction.copyParametersToBO(Map, PersistableBusinessObject) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR366Medium

org.kuali.rice.kns.web.struts.action.KualiMultipleValueLookupAction

BugCategoryDetailsLinePriority
Dead store to displayList in org.kuali.rice.kns.web.struts.action.KualiMultipleValueLookupAction.search(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE93Medium
Dead store to refreshCaller in org.kuali.rice.kns.web.struts.action.KualiMultipleValueLookupAction.search(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE137Medium
Method org.kuali.rice.kns.web.struts.action.KualiMultipleValueLookupAction.getMaxRowsPerPage(MultipleValueLookupForm) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR612Medium
Possible null pointer dereference of resultTable in org.kuali.rice.kns.web.struts.action.KualiMultipleValueLookupAction.performMultipleValueLookup(MultipleValueLookupForm, List, int, boolean)CORRECTNESSNP_NULL_ON_SOME_PATH342Medium

org.kuali.rice.kns.web.struts.form.InquiryForm

BugCategoryDetailsLinePriority
Class org.kuali.rice.kns.web.struts.form.InquiryForm defines non-transient non-serializable instance field inquirableBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kns.web.struts.form.KualiForm

BugCategoryDetailsLinePriority
org.kuali.rice.kns.web.struts.form.KualiForm.getHeaderNavigationTabs() may expose internal representation by returning KualiForm.headerNavigationTabsMALICIOUS_CODEEI_EXPOSE_REP278Medium
org.kuali.rice.kns.web.struts.form.KualiForm.setHeaderNavigationTabs(HeaderNavigation[]) may expose internal representation by storing an externally mutable object into KualiForm.headerNavigationTabsMALICIOUS_CODEEI_EXPOSE_REP2287Medium

org.kuali.rice.kns.web.struts.form.KualiMaintenanceForm

BugCategoryDetailsLinePriority
Dead store to docTypeName in org.kuali.rice.kns.web.struts.form.KualiMaintenanceForm.getAdditionalSectionsFile()STYLEDLS_DEAD_LOCAL_STORE453Medium
Method org.kuali.rice.kns.web.struts.form.KualiMaintenanceForm.populate(HttpServletRequest) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR242Medium

org.kuali.rice.kns.web.struts.form.LookupForm

BugCategoryDetailsLinePriority
Dead store to ddService in org.kuali.rice.kns.web.struts.form.LookupForm.populate(HttpServletRequest)STYLEDLS_DEAD_LOCAL_STORE147Medium
org.kuali.rice.kns.web.struts.form.LookupForm.populate(HttpServletRequest) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR223Medium

org.kuali.rice.kns.web.struts.form.MultipleValueLookupForm

BugCategoryDetailsLinePriority
Class org.kuali.rice.kns.web.struts.form.MultipleValueLookupForm defines non-transient non-serializable instance field tableMetadataBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kns.web.struts.pojo.ArrayUtils

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.web.struts.pojo.ArrayUtils.toObject(Object) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) insteadPERFORMANCEDM_NUMBER_CTOR69Medium
Method org.kuali.rice.kns.web.struts.pojo.ArrayUtils.toObject(Object) invokes inefficient new Character(char) constructor; use Character.valueOf(char) insteadPERFORMANCEDM_NUMBER_CTOR67Medium
Method org.kuali.rice.kns.web.struts.pojo.ArrayUtils.toObject(Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR71Medium
Method org.kuali.rice.kns.web.struts.pojo.ArrayUtils.toObject(Object) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR73Medium
Method org.kuali.rice.kns.web.struts.pojo.ArrayUtils.toObject(Object) invokes inefficient new Short(short) constructor; use Short.valueOf(short) insteadPERFORMANCEDM_NUMBER_CTOR75Medium

org.kuali.rice.kns.web.struts.pojo.PojoFormBase

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.web.struts.pojo.PojoFormBase.populate(HttpServletRequest) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR151Medium

org.kuali.rice.kns.web.ui.Field

BugCategoryDetailsLinePriority
org.kuali.rice.kns.web.ui.Field.getPropertyValues() may expose internal representation by returning Field.propertyValuesMALICIOUS_CODEEI_EXPOSE_REP1625Medium
org.kuali.rice.kns.web.ui.Field.setPropertyValues(String[]) may expose internal representation by storing an externally mutable object into Field.propertyValuesMALICIOUS_CODEEI_EXPOSE_REP21629Medium
Method org.kuali.rice.kns.web.ui.Field.setFieldConversions(Map) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION810Medium
Method org.kuali.rice.kns.web.ui.Field.setLookupParameters(Map) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION899Medium
Method org.kuali.rice.kns.web.ui.Field.setFieldConversions(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR807Medium
Method org.kuali.rice.kns.web.ui.Field.setLookupParameters(Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR896Medium

org.kuali.rice.kns.web.ui.FieldBridge

BugCategoryDetailsLinePriority
Possible null pointer dereference of finder in org.kuali.rice.kns.web.ui.FieldBridge.lookupFinderValue(ControlDefinition, Object, KeyValuesFinder)CORRECTNESSNP_NULL_ON_SOME_PATH222Medium
Method org.kuali.rice.kns.web.ui.FieldBridge.getNewFormFields(CollectionDefinitionI, BusinessObject, Maintainable, List, Set, StringBuffer, String, boolean, int) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION416Medium

org.kuali.rice.kns.web.ui.FormatAwareDecorator

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.web.ui.FormatAwareDecorator.createCollectionString(Object) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION75Medium

org.kuali.rice.kns.web.ui.SectionBridge

BugCategoryDetailsLinePriority
Dead store to row in org.kuali.rice.kns.web.ui.SectionBridge.toSection(Inquirable, InquirySectionDefinition, BusinessObject, InquiryRestrictions)STYLEDLS_DEAD_LOCAL_STORE101Medium
Dead store to sectionRows in org.kuali.rice.kns.web.ui.SectionBridge.toSection(Inquirable, InquirySectionDefinition, BusinessObject, InquiryRestrictions)STYLEDLS_DEAD_LOCAL_STORE107Medium
Method org.kuali.rice.kns.web.ui.SectionBridge.getContainerRows(Section, CollectionDefinitionI, BusinessObject, Maintainable, Maintainable, List, Set, StringBuffer, String, boolean, int, Inquirable) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR433Medium
Nullcheck of o at line 248 of value previously dereferenced in org.kuali.rice.kns.web.ui.SectionBridge.toSection(MaintainableSectionDefinition, BusinessObject, Maintainable, Maintainable, String, List, Set)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE215Medium

org.kuali.rice.kns.workflow.attribute.DataDictionaryDocumentSearchCustomizer

BugCategoryDetailsLinePriority
Class org.kuali.rice.kns.workflow.attribute.DataDictionaryDocumentSearchCustomizer defines non-transient non-serializable instance field documentSearchGeneratorBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.kns.workflow.attribute.DataDictionarySearchableAttribute

BugCategoryDetailsLinePriority
Dead store to boEntry in org.kuali.rice.kns.workflow.attribute.DataDictionarySearchableAttribute.createFieldRowsForBusinessObject(Class)STYLEDLS_DEAD_LOCAL_STORE436Medium
Method org.kuali.rice.kns.workflow.attribute.DataDictionarySearchableAttribute.validateUserSearchInputs(Map, DocumentSearchContext) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR202Medium

org.kuali.rice.kns.workflow.attribute.KualiXmlAttributeHelper

BugCategoryDetailsLinePriority
Dead store to theEnd in org.kuali.rice.kns.workflow.attribute.KualiXmlAttributeHelper.getXPathTerms(Element)STYLEDLS_DEAD_LOCAL_STORE441Medium

org.kuali.rice.kns.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl.buildSearchableFixnumAttribute(String, Object) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR403Medium
Method org.kuali.rice.kns.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl.copyQualifications(AttributeSet, AttributeSet) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR188Medium

org.kuali.rice.kns.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl$RoutingAttributeTracker

BugCategoryDetailsLinePriority
Method org.kuali.rice.kns.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl$RoutingAttributeTracker.checkPoint() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR593Medium
Should org.kuali.rice.kns.workflow.service.impl.WorkflowAttributePropertyResolutionServiceImpl$RoutingAttributeTracker be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC570Medium

org.kuali.rice.ksb.cache.RiceCacheAdministratorImpl

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.cache.RiceCacheAdministratorImpl.loadCacheSettings() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR141Medium

org.kuali.rice.ksb.cache.RiceDistributedCacheListener

BugCategoryDetailsLinePriority
Primitive value is boxed and then immediately unboxed in org.kuali.rice.ksb.cache.RiceDistributedCacheListener.initialize(Cache, Config)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED62Medium
org.kuali.rice.ksb.cache.RiceDistributedCacheListener.initialize(Cache, Config) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR62Medium

org.kuali.rice.ksb.messaging.AsynchronousCall

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.AsynchronousCall.getArguments() may expose internal representation by returning AsynchronousCall.argumentsMALICIOUS_CODEEI_EXPOSE_REP56Medium
org.kuali.rice.ksb.messaging.AsynchronousCall.getParamTypes() may expose internal representation by returning AsynchronousCall.paramTypesMALICIOUS_CODEEI_EXPOSE_REP60Medium
new org.kuali.rice.ksb.messaging.AsynchronousCall(Class[], Object[], ServiceInfo, String, AsynchronousCallback, Serializable) may expose internal representation by storing an externally mutable object into AsynchronousCall.argumentsMALICIOUS_CODEEI_EXPOSE_REP247Medium
new org.kuali.rice.ksb.messaging.AsynchronousCall(Class[], Object[], ServiceInfo, String, AsynchronousCallback, Serializable) may expose internal representation by storing an externally mutable object into AsynchronousCall.paramTypesMALICIOUS_CODEEI_EXPOSE_REP248Medium

org.kuali.rice.ksb.messaging.HttpException

BugCategoryDetailsLinePriority

org.kuali.rice.ksb.messaging.MessageServiceInvoker

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.MessageServiceInvoker.run() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR72Medium

org.kuali.rice.ksb.messaging.PropertyConditionalKSBExporter

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.PropertyConditionalKSBExporter.shouldRemoteThisService() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR58Medium

org.kuali.rice.ksb.messaging.RemotedServiceRegistryImpl

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.RemotedServiceRegistryImpl.createServiceInfoAndServiceInfoCopy(ServiceDefinition) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR121Medium
Inconsistent synchronization of org.kuali.rice.ksb.messaging.RemotedServiceRegistryImpl.serviceLocator; locked 66% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC424Medium
Method org.kuali.rice.ksb.messaging.RemotedServiceRegistryImpl.getContents(String, boolean) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION391Medium

org.kuali.rice.ksb.messaging.ServiceDefinition

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.ServiceDefinition.isSame(ServiceDefinition) invokes java.net.URL.equals(Object), which blocks to do domain name resolutionPERFORMANCEDMI_BLOCKING_METHODS_ON_URL249High
Method org.kuali.rice.ksb.messaging.ServiceDefinition.validate() invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR223Medium

org.kuali.rice.ksb.messaging.config.KSBConfigurer$1

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.config.KSBConfigurer$1.start() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR172Medium

org.kuali.rice.ksb.messaging.dao.impl.MessageQueueDAOOjbImpl

BugCategoryDetailsLinePriority
Method org.kuali.rice.ksb.messaging.dao.impl.MessageQueueDAOOjbImpl.findByValues(Map, int) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR86Medium

org.kuali.rice.ksb.messaging.exceptionhandling.DefaultMessageExceptionHandler

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.exceptionhandling.DefaultMessageExceptionHandler.getImmediateExceptionRouting() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR140Medium
Method org.kuali.rice.ksb.messaging.exceptionhandling.DefaultMessageExceptionHandler.requeue(Throwable, PersistedMessage) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR90Medium

org.kuali.rice.ksb.messaging.quartz.KSBSchedulerFactoryBean

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.quartz.KSBSchedulerFactoryBean.afterPropertiesSet() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR64Medium
Unused field: org.kuali.rice.ksb.messaging.quartz.KSBSchedulerFactoryBean.transactionManagerPERFORMANCEUUF_UNUSED_FIELDMedium

org.kuali.rice.ksb.messaging.quartz.QuartzConfigPropertiesFactoryBean

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.quartz.QuartzConfigPropertiesFactoryBean.createInstance() invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR41Medium

org.kuali.rice.ksb.messaging.service.impl.MessageQueueServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.service.impl.MessageQueueServiceImpl.delete(PersistedMessage) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR43Medium
org.kuali.rice.ksb.messaging.service.impl.MessageQueueServiceImpl.save(PersistedMessage) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR52Medium

org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector.configureDefaultHttpClientParams(HttpParams) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR136Medium
Method org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector.configureDefaultHttpClientParams(HttpParams) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR129Medium
Method org.kuali.rice.ksb.messaging.serviceconnectors.HttpInvokerConnector.initializeHttpClientParams() makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR115Medium

org.kuali.rice.ksb.messaging.serviceexporters.RESTServiceExporter

BugCategoryDetailsLinePriority
Dead store to server in org.kuali.rice.ksb.messaging.serviceexporters.RESTServiceExporter.publishService(ServiceDefinition, Object, String)STYLEDLS_DEAD_LOCAL_STORE102Medium

org.kuali.rice.ksb.messaging.serviceproxies.MessageSender

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.serviceproxies.MessageSender.sendMessage(PersistedMessage) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR35Medium

org.kuali.rice.ksb.messaging.serviceproxies.MessageSendingTransactionSynchronization

BugCategoryDetailsLinePriority
Write to static field org.kuali.rice.ksb.messaging.serviceproxies.MessageSendingTransactionSynchronization.CALLED_TRANS_COMMITTED from instance method org.kuali.rice.ksb.messaging.serviceproxies.MessageSendingTransactionSynchronization.afterCompletion(int)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD53Medium
Write to static field org.kuali.rice.ksb.messaging.serviceproxies.MessageSendingTransactionSynchronization.CALLED_TRANS_ROLLEDBACKED from instance method org.kuali.rice.ksb.messaging.serviceproxies.MessageSendingTransactionSynchronization.afterCompletion(int)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD56Medium

org.kuali.rice.ksb.messaging.serviceproxies.SynchronousServiceCallProxy

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.serviceproxies.SynchronousServiceCallProxy.executeMessage(PersistedMessage) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR63Medium

org.kuali.rice.ksb.messaging.servlet.CXFServletControllerAdapter

BugCategoryDetailsLinePriority
Unread field: org.kuali.rice.ksb.messaging.servlet.CXFServletControllerAdapter.serviceInfoPERFORMANCEURF_UNREAD_FIELD42Medium

org.kuali.rice.ksb.messaging.threadpool.PriorityBlockingQueuePersistedMessageComparator

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.messaging.threadpool.PriorityBlockingQueuePersistedMessageComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE33Medium

org.kuali.rice.ksb.messaging.web.MessageQueueAction

BugCategoryDetailsLinePriority
Dead store to routeQueueId in org.kuali.rice.ksb.messaging.web.MessageQueueAction.save(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE77Medium
Method org.kuali.rice.ksb.messaging.web.MessageQueueAction.quickRequeueMessage(PersistedMessage) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR205Medium

org.kuali.rice.ksb.messaging.web.ThreadPoolForm

BugCategoryDetailsLinePriority
Class org.kuali.rice.ksb.messaging.web.ThreadPoolForm defines non-transient non-serializable instance field threadPoolBAD_PRACTICESE_BAD_FIELDMedium

org.kuali.rice.ksb.security.SignatureVerifyingInputStream

BugCategoryDetailsLinePriority
new org.kuali.rice.ksb.security.SignatureVerifyingInputStream(byte[], Signature, InputStream) may expose internal representation by storing an externally mutable object into SignatureVerifyingInputStream.digitalSignatureMALICIOUS_CODEEI_EXPOSE_REP240Medium

org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer.getCreateDate() may expose internal representation by returning KeyStoreEntryDataContainer.createDateMALICIOUS_CODEEI_EXPOSE_REP82Medium
new org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer(String, Date) may expose internal representation by storing an externally mutable object into KeyStoreEntryDataContainer.createDateMALICIOUS_CODEEI_EXPOSE_REP250Medium
org.kuali.rice.ksb.security.admin.KeyStoreEntryDataContainer.setCreateDate(Date) may expose internal representation by storing an externally mutable object into KeyStoreEntryDataContainer.createDateMALICIOUS_CODEEI_EXPOSE_REP289Medium

org.kuali.rice.ksb.security.admin.service.impl.JavaSecurityManagementServiceImpl

BugCategoryDetailsLinePriority
org.kuali.rice.ksb.security.admin.service.impl.JavaSecurityManagementServiceImpl.loadKeyStore() may fail to close streamBAD_PRACTICEOS_OPEN_STREAM111Medium
Unread field: org.kuali.rice.ksb.security.admin.service.impl.JavaSecurityManagementServiceImpl.CLIENT_CERT_EXPIRATION_DAYS; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC57Medium

org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction

BugCategoryDetailsLinePriority
Dead store to form in org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction.clear(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE83High
Dead store to form in org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction.generateClientKeyStore(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE123High
Dead store to data in org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction.generateClientKeyStore(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse)STYLEDLS_DEAD_LOCAL_STORE102Medium
The parameter form to org.kuali.rice.ksb.security.admin.web.JavaSecurityManagementAction.clear(ActionMapping, ActionForm, HttpServletRequest, HttpServletResponse) is dead upon entry but overwrittenCORRECTNESSIP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN83High

org.kuali.rice.ksb.util.KSBConstants

BugCategoryDetailsLinePriority
Method org.kuali.rice.ksb.util.KSBConstants.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR67Medium

org.kuali.rice.ksb.util.KSBConstants$Config

BugCategoryDetailsLinePriority
Should org.kuali.rice.ksb.util.KSBConstants$Config be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC32Medium

org.kuali.rice.ksb.util.KSBConstants$ServiceNames

BugCategoryDetailsLinePriority
Should org.kuali.rice.ksb.util.KSBConstants$ServiceNames be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC77Medium

org.kuali.rice.test.BaselineTestCase

BugCategoryDetailsLinePriority
org.kuali.rice.test.BaselineTestCase.dirty should be package protectedMALICIOUS_CODEMS_PKGPROTECT75Medium
Write to static field org.kuali.rice.test.BaselineTestCase.dirty from instance method org.kuali.rice.test.BaselineTestCase.setUp()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD115High

org.kuali.rice.test.BaselineTestCase$1

BugCategoryDetailsLinePriority
Write to static field org.kuali.rice.test.BaselineTestCase.dirty from instance method org.kuali.rice.test.BaselineTestCase$1.stop()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD155Medium

org.kuali.rice.test.ClearDatabaseLifecycle$1

BugCategoryDetailsLinePriority
org.kuali.rice.test.ClearDatabaseLifecycle$1.doInConnection(Connection) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR97Medium

org.kuali.rice.test.JettyServerTestCase

BugCategoryDetailsLinePriority
Dead store to portConfigParam in org.kuali.rice.test.JettyServerTestCase.constructJettyServerLifecycle(JettyServer)STYLEDLS_DEAD_LOCAL_STORE88Medium

org.kuali.rice.test.RiceInternalSuiteDataTestCase

BugCategoryDetailsLinePriority
org.kuali.rice.test.RiceInternalSuiteDataTestCase.loadSuiteTestData() may fail to close streamBAD_PRACTICEOS_OPEN_STREAM37Medium

org.kuali.rice.test.RiceTestCase

BugCategoryDetailsLinePriority
org.kuali.rice.test.RiceTestCase.SUITE_LIFE_CYCLES_FAILED should be package protectedMALICIOUS_CODEMS_PKGPROTECT60Medium
org.kuali.rice.test.RiceTestCase.SUITE_LIFE_CYCLES_RAN should be package protectedMALICIOUS_CODEMS_PKGPROTECT59Medium
org.kuali.rice.test.RiceTestCase.failedSuiteTestName should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium

org.kuali.rice.test.SQLDataLoader

BugCategoryDetailsLinePriority
Method org.kuali.rice.test.SQLDataLoader.getContentsAsString(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION99Medium

org.kuali.rice.test.SQLDataLoader$1$1

BugCategoryDetailsLinePriority

org.kuali.rice.test.runners.RiceUnitTestClassRunner

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.kuali.rice.test.runners.RiceUnitTestClassRunner.setTestName(Object, Method)STYLEREC_CATCH_EXCEPTION91Medium