The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.Identity.hashCode() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| org.apache.ojb.broker.Identity.getPrimaryKeyValues() may expose internal representation by returning Identity.m_pkValues | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| new org.apache.ojb.broker.Identity(Class, Class, Object[]) may expose internal representation by storing an externally mutable object into Identity.m_pkValues | MALICIOUS_CODE | EI_EXPOSE_REP2 | Medium | |
| new org.apache.ojb.broker.Identity(Class, Class, Object[], boolean) may expose internal representation by storing an externally mutable object into Identity.m_pkValues | MALICIOUS_CODE | EI_EXPOSE_REP2 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.ojb.broker.PBKey implements Cloneable but does not define or use clone method | BAD_PRACTICE | CN_IDIOM | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.ojb.broker.PBLifeCycleEvent defines non-transient non-serializable instance field eventType | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Impossible cast from org.apache.ojb.broker.PBStateEvent to org.apache.ojb.broker.PBLifeCycleEvent$Type in org.apache.ojb.broker.PBLifeCycleEvent$Type.equals(Object) | CORRECTNESS | BC_IMPOSSIBLE_CAST | High | |
| org.apache.ojb.broker.PBLifeCycleEvent$Type.equals(Object) checks for operand being a PBStateEvent | BAD_PRACTICE | EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.ojb.broker.PBStateEvent defines non-transient non-serializable instance field eventType | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Impossible cast from org.apache.ojb.broker.PBStateEvent to org.apache.ojb.broker.PBStateEvent$Type in org.apache.ojb.broker.PBStateEvent$Type.equals(Object) | CORRECTNESS | BC_IMPOSSIBLE_CAST | High | |
| org.apache.ojb.broker.PBStateEvent$Type.equals(Object) checks for operand being a PBStateEvent | BAD_PRACTICE | EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.ojb.broker.accesslayer.ChainingIterator.disableLifeCycleEvents | PERFORMANCE | URF_UNREAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| A prepared statement is generated from a nonconstant String at org.apache.ojb.broker.accesslayer.ConnectionFactoryPooledImpl$ConPoolFactory.validateConnection(Connection, String) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.ojb.broker.accesslayer.PkIterator defines non-transient non-serializable instance field internalEnum | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.accesslayer.ReportQueryRsIterator.getObjectFromResultSet() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.ojb.broker.accesslayer.RsIterator.disableLifeCycleEvents; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.accesslayer.SqlBasedReportQueryRsIterator.getObjectFromResultSet() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return false in org.apache.ojb.broker.accesslayer.StatementManager.bindProcedure(PreparedStatement, ClassDescriptor, Object, ProcedureDescriptor), since a ClassCastException can't be a java.sql.SQLException | CORRECTNESS | BC_IMPOSSIBLE_INSTANCEOF | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.accesslayer.conversions.Boolean2IntFieldConversion.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.accesslayer.conversions.Int2IntegerFieldConversion.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.ojb.broker.accesslayer.conversions.Object2Base64StringFieldConversion defines non-transient non-serializable instance field byteOut | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.apache.ojb.broker.accesslayer.conversions.Object2Base64StringFieldConversion defines non-transient non-serializable instance field gzipOut | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.apache.ojb.broker.accesslayer.conversions.Object2Base64StringFieldConversion defines non-transient non-serializable instance field objOut | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class org.apache.ojb.broker.accesslayer.conversions.Object2Base64StringFieldConversion defines non-transient non-serializable instance field uuOut | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.ojb.broker.accesslayer.sql.SqlMNStatement(String, String[], Logger) may expose internal representation by storing an externally mutable object into SqlMNStatement.m_columns | MALICIOUS_CODE | EI_EXPOSE_REP2 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.ojb.broker.accesslayer.sql.SqlProcedureStatement.logger | PERFORMANCE | URF_UNREAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.accesslayer.sql.SqlQueryStatement.getColName(SqlQueryStatement$TableAlias, SqlHelper$PathInfo, boolean) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | Medium | |
| Load of known null value in org.apache.ojb.broker.accesslayer.sql.SqlQueryStatement.appendSQLClause(SelectionCriteria, StringBuffer) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Equals method for org.apache.ojb.broker.accesslayer.sql.SqlQueryStatement$Join assumes the argument is of type SqlQueryStatement$Join | BAD_PRACTICE | BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS | Medium | |
| org.apache.ojb.broker.accesslayer.sql.SqlQueryStatement$Join.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Equals method for org.apache.ojb.broker.accesslayer.sql.SqlQueryStatement$TableAlias assumes the argument is of type SqlQueryStatement$TableAlias | BAD_PRACTICE | BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS | Medium | |
| org.apache.ojb.broker.accesslayer.sql.SqlQueryStatement$TableAlias.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.ojb.broker.accesslayer.sql.SqlSelectMNStatement(String, String[], String[], Logger) may expose internal representation by storing an externally mutable object into SqlSelectMNStatement.m_selectColumns | MALICIOUS_CODE | EI_EXPOSE_REP2 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of ? in org.apache.ojb.broker.ant.DBUtility.exists(String, String, String, boolean) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | Medium | |
| Possible null pointer dereference of ? in org.apache.ojb.broker.ant.DBUtility.exists(String, String, boolean) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | Medium | |
| Possible null pointer dereference of ? in org.apache.ojb.broker.ant.DBUtility.existsUseWarnings(String, String, String, boolean) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | Medium | |
| org.apache.ojb.broker.ant.DBUtility.exists(String) may fail to close PreparedStatement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | Medium | |
| org.apache.ojb.broker.ant.DBUtility.exists(String, String, String, boolean) may fail to close PreparedStatement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | Medium | |
| org.apache.ojb.broker.ant.DBUtility.exists(String, String, boolean) may fail to close PreparedStatement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | Medium | |
| org.apache.ojb.broker.ant.DBUtility.existsUseWarnings(String, String, String, boolean) may fail to close PreparedStatement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.ant.PreparedModel.extractIndirectionTables(DescriptorRepository, Database) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.ant.RepositoryDataTask.initOJB() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | Medium | |
| Exception is caught when Exception is not thrown in org.apache.ojb.broker.ant.RepositoryDataTask.initOJB() | STYLE | REC_CATCH_EXCEPTION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.ojb.broker.ant.RepositoryVerifierHandler.m_CurrentCLD | PERFORMANCE | URF_UNREAD_FIELD | Medium | |
| Unread field: org.apache.ojb.broker.ant.RepositoryVerifierHandler.m_CurrentCOD | PERFORMANCE | URF_UNREAD_FIELD | Medium | |
| Unread field: org.apache.ojb.broker.ant.RepositoryVerifierHandler.m_CurrentORD | PERFORMANCE | URF_UNREAD_FIELD | Medium | |
| Unused field: org.apache.ojb.broker.ant.RepositoryVerifierHandler.m_repository | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.ant.VerifyMappingsTask.getPersistentFieldClass() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.ant.WriteDataToDatabaseCommand.setBatchSize(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.cache.ObjectCacheDefaultImpl.buildKey(Identity) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.ojb.broker.cache.ObjectCacheSoftImpl.cache in new org.apache.ojb.broker.cache.ObjectCacheSoftImpl(PersistenceBroker, Properties) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.ojb.broker.cache.ObjectCacheSoftImpl$SoftHashMap$SoftValue be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.cache.ObjectCacheTwoLevelImpl$CacheEntry is Serializable but its superclass doesn't define an accessible void constructor | BAD_PRACTICE | SE_NO_SUITABLE_CONSTRUCTOR | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method new org.apache.ojb.broker.core.MtoNBroker$Key(ValueContainer[]) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.ojb.broker.core.PersistenceBrokerFactorySyncImpl.getStatusFlagAsString(int) | STYLE | REC_CATCH_EXCEPTION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.ojb.broker.core.PersistenceBrokerFactorySyncImpl$PersistenceBrokerSyncHandle be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.ojb.broker.core.proxy.AbstractIndirectionHandler._listeners; locked 42% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.ojb.broker.core.proxy.CollectionProxyDefaultImpl._data; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | Medium | |
| org.apache.ojb.broker.core.proxy.CollectionProxyDefaultImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.ojb.broker.locking.LockIsolationManager$ReadCommittedIsolation be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.ojb.broker.locking.LockIsolationManager$ReadUncommittedIsolation be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.ojb.broker.locking.LockIsolationManager$RepeatableReadIsolation be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.ojb.broker.locking.LockIsolationManager$SerializableIsolation be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.locking.LockManagerCommonsImpl.readLock(Object, Object, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.locking.LockManagerCommonsImpl.upgradeLock(Object, Object, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.locking.LockManagerCommonsImpl.writeLock(Object, Object, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.locking.LockManagerInMemoryImpl$LockEntry is serializable but also an inner class of a non-serializable class | BAD_PRACTICE | SE_BAD_FIELD_INNER_CLASS | Medium | |
| Should org.apache.ojb.broker.locking.LockManagerInMemoryImpl$LockEntry be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.ojb.broker.locking.LockManagerRemoteImpl.lockservlet from instance method org.apache.ojb.broker.locking.LockManagerRemoteImpl.configure(Configuration) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.locking.LockManagerServlet.doPost(HttpServletRequest, HttpServletResponse) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | Medium | |
| Method org.apache.ojb.broker.locking.LockManagerServlet.doPost(HttpServletRequest, HttpServletResponse) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Incorrect lazy initialization and update of static field org.apache.ojb.broker.locking.LockManagerServlet.lockmanager in org.apache.ojb.broker.locking.LockManagerServlet.init(ServletConfig) | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | Medium | |
| org.apache.ojb.broker.locking.LockManagerServlet.lockmanager should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| Write to static field org.apache.ojb.broker.locking.LockManagerServlet.lastError from instance method org.apache.ojb.broker.locking.LockManagerServlet.init(ServletConfig) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | Medium | |
| Write to static field org.apache.ojb.broker.locking.LockManagerServlet.numRequests from instance method org.apache.ojb.broker.locking.LockManagerServlet.init(ServletConfig) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.metadata.ClassDescriptor.updateLockingValues(Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.ClassDescriptor.updateLockingValues(Object) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| org.apache.ojb.broker.metadata.ClassDescriptor.getAllRwFields() may expose internal representation by returning ClassDescriptor.m_RwFieldDescriptors | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| org.apache.ojb.broker.metadata.ClassDescriptor.getFieldDescriptions() may expose internal representation by returning ClassDescriptor.m_FieldDescriptions | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| org.apache.ojb.broker.metadata.ClassDescriptor.getFieldDescriptor(boolean) may expose internal representation by returning ClassDescriptor.m_FieldDescriptions | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| org.apache.ojb.broker.metadata.ClassDescriptor.getLockingFields() may expose internal representation by returning ClassDescriptor.m_lockingFieldDescriptors | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| org.apache.ojb.broker.metadata.ClassDescriptor.getNonPkFields() may expose internal representation by returning ClassDescriptor.m_nonPkFieldDescriptors | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| org.apache.ojb.broker.metadata.ClassDescriptor.getNonPkRwFields() may expose internal representation by returning ClassDescriptor.m_RwNonPkFieldDescriptors | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| org.apache.ojb.broker.metadata.ClassDescriptor.getPkFields() may expose internal representation by returning ClassDescriptor.m_PkFieldDescriptors | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| Inconsistent synchronization of org.apache.ojb.broker.metadata.ClassDescriptor.proxyClass; locked 42% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.metadata.CollectionDescriptor.getFksToItemClass() may expose internal representation by returning CollectionDescriptor.fksToItemClassAry | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| org.apache.ojb.broker.metadata.CollectionDescriptor.getFksToThisClass() may expose internal representation by returning CollectionDescriptor.fksToThisClassAry | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| Method org.apache.ojb.broker.metadata.CollectionDescriptor.toXML() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.ojb.broker.metadata.ConnectionDescriptorXmlHandler.startElement(String, String, String, Attributes) | STYLE | REC_CATCH_EXCEPTION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.metadata.ConnectionPoolDescriptor doesn't override java.util.Hashtable.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.ojb.broker.metadata.ConnectionRepository defines non-transient non-serializable instance field utils | BAD_PRACTICE | SE_BAD_FIELD | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.metadata.FieldDescriptor defines clone() but doesn't implement Cloneable | BAD_PRACTICE | CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper.setJdbcTypeByTypesIndex(int, JdbcType) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Exception is caught when Exception is not thrown in org.apache.ojb.broker.metadata.JdbcTypesHelper.getSqlTypeAsString(int) | STYLE | REC_CATCH_EXCEPTION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_BigInt.readValueFromResultSet(ResultSet, int) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_BigInt.readValueFromResultSet(ResultSet, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_BigInt.readValueFromStatement(CallableStatement, int) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_Integer.readValueFromResultSet(ResultSet, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_Integer.readValueFromResultSet(ResultSet, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_Integer.readValueFromStatement(CallableStatement, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_Integer.sequenceKeyConversion(Long) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_SmallInt.readValueFromResultSet(ResultSet, int) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_SmallInt.readValueFromResultSet(ResultSet, String) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_SmallInt.readValueFromStatement(CallableStatement, int) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_SmallInt.sequenceKeyConversion(Long) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_TinyInt.readValueFromResultSet(ResultSet, int) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_TinyInt.readValueFromResultSet(ResultSet, String) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_TinyInt.readValueFromStatement(CallableStatement, int) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.JdbcTypesHelper$T_TinyInt.sequenceKeyConversion(Long) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.ojb.broker.metadata.MetadataManager.currentProfileKey from instance method org.apache.ojb.broker.metadata.MetadataManager.shutdown() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | High | |
| Write to static field org.apache.ojb.broker.metadata.MetadataManager.singleton from instance method org.apache.ojb.broker.metadata.MetadataManager.shutdown() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | High | |
| Write to static field org.apache.ojb.broker.metadata.MetadataManager.threadedRepository from instance method org.apache.ojb.broker.metadata.MetadataManager.shutdown() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.metadata.ObjectReferenceDescriptor.addForeignKeyField(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.ojb.broker.metadata.RepositoryPersistor$OJBErrorHandler be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method new org.apache.ojb.broker.metadata.RepositoryTags() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.RepositoryTags.getAttribute(int, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.RepositoryTags.getClosingTagById(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.RepositoryTags.getOpeningTagById(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.RepositoryTags.getOpeningTagById(int, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.RepositoryTags.getOpeningTagNonClosingById(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.metadata.RepositoryTags.getTagById(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Possible null pointer dereference of ? in org.apache.ojb.broker.metadata.RepositoryTags.getIdByTag(String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.ojb.broker.metadata.RepositoryXmlHandler.startElement(String, String, String, Attributes) | STYLE | REC_CATCH_EXCEPTION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.metadata.SuperReferenceDescriptor is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.metadata.SuperReferenceDescriptor$SuperReferenceField is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.platforms.BlobWrapper.createTemporary(Connection, boolean, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.platforms.BlobWrapper.open(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.platforms.BlobWrapper.trim(long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| org.apache.ojb.broker.platforms.BlobWrapper.close isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.BlobWrapper.createTemporary isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.BlobWrapper.durationCall isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.BlobWrapper.durationSession isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.BlobWrapper.freeTemporary isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.BlobWrapper.getBinaryOutputStream isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.BlobWrapper.getBinaryStream isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.BlobWrapper.getBufferSize isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.BlobWrapper.isOpen isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.BlobWrapper.modeReadOnly isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.BlobWrapper.modeReadWrite isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.BlobWrapper.open isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.BlobWrapper.trim isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| Exception is caught when Exception is not thrown in org.apache.ojb.broker.platforms.BlobWrapper.<static initializer>() | STYLE | REC_CATCH_EXCEPTION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.platforms.ClobWrapper.createTemporary(Connection, boolean, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.platforms.ClobWrapper.open(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.platforms.ClobWrapper.trim(long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| org.apache.ojb.broker.platforms.ClobWrapper.close isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.ClobWrapper.createTemporary isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.ClobWrapper.durationCall isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.ClobWrapper.durationSession isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.ClobWrapper.freeTemporary isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.ClobWrapper.getBufferSize isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.ClobWrapper.getCharacterOutputStream isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.ClobWrapper.getCharacterStream isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.ClobWrapper.isOpen isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.ClobWrapper.modeReadOnly isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.ClobWrapper.modeReadWrite isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.ClobWrapper.open isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.broker.platforms.ClobWrapper.trim isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| Exception is caught when Exception is not thrown in org.apache.ojb.broker.platforms.ClobWrapper.<static initializer>() | STYLE | REC_CATCH_EXCEPTION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.platforms.Oracle9iLobHandler.logger isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.platforms.PlatformOracle9iImpl.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.platforms.PlatformOracle9iImpl.setObjectForStatement(PreparedStatement, int, Object, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.JBOSS_CONN_CLASS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.METHOD_SET_BLOB should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.METHOD_SET_CLOB should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.METHOD_SET_IMPLICIT_CACHING_ENABLED should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.METHOD_SET_ROW_PREFETCH should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.METHOD_SET_STATEMENT_CACHE_SIZE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.ORA_BLOB_CLASS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.ORA_BLOB_HANDLING_AVAILABLE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.ORA_CLOB_CLASS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.ORA_CLOB_HANDLING_AVAILABLE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.ORA_CONN_CLASS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.ORA_PS_CLASS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.ORA_ROW_PREFETCH_AVAILABLE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.ORA_STATEMENT_CACHING_AVAILABLE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.PARAM_BOOLEAN_TRUE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.PARAM_ROW_PREFETCH_SIZE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.PARAM_STATEMENT_BATCH_SIZE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.PARAM_STATEMENT_CACHE_SIZE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.PARAM_TYPE_BOOLEAN should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.PARAM_TYPE_INTEGER should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.PARAM_TYPE_INT_ORABLOB should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.PARAM_TYPE_INT_ORACLOB should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.UNWRAP_CONN_METHOD_NAMES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.UNWRAP_CONN_PARAM_TYPES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.UNWRAP_PS_METHOD_NAMES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.UNWRAP_PS_PARAM_TYPES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformOracle9iImpl.m_batchStatementsInProgress isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.platforms.PlatformOracleImpl.ORACLE_JDBC_TYPE_CURSOR should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| Exception is caught when Exception is not thrown in org.apache.ojb.broker.platforms.PlatformOracleImpl.changePreparedStatementResultSetType(PreparedStatement) | STYLE | REC_CATCH_EXCEPTION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.platforms.PlatformWLOracle9iImpl.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.platforms.PlatformWLOracle9iImpl.setObjectForStatement(PreparedStatement, int, Object, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| org.apache.ojb.broker.platforms.PlatformWLOracle9iImpl.PARAM_ROW_PREFETCH_SIZE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformWLOracle9iImpl.PARAM_STATEMENT_BATCH_SIZE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformWLOracle9iImpl.PARAM_TYPE_INTEGER should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| org.apache.ojb.broker.platforms.PlatformWLOracle9iImpl.m_batchStatementsInProgress isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.query.OJBSearchFilter.matchList(String, int[], int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.query.OJBSearchFilter.matchValue(String, int, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.query.ReportQueryByCriteria.getAttributes() may expose internal representation by returning ReportQueryByCriteria.m_attributes | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| org.apache.ojb.broker.query.ReportQueryByCriteria.getJdbcTypes() may expose internal representation by returning ReportQueryByCriteria.m_jdbcTypes | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| org.apache.ojb.broker.query.ReportQueryByCriteria.getJoinAttributes() may expose internal representation by returning ReportQueryByCriteria.m_joinAttributes | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| org.apache.ojb.broker.query.ReportQueryByCriteria.setAttributes(String[]) may expose internal representation by storing an externally mutable object into ReportQueryByCriteria.m_attributes | MALICIOUS_CODE | EI_EXPOSE_REP2 | Medium | |
| org.apache.ojb.broker.query.ReportQueryByCriteria.setJdbcTypes(int[]) may expose internal representation by storing an externally mutable object into ReportQueryByCriteria.m_jdbcTypes | MALICIOUS_CODE | EI_EXPOSE_REP2 | Medium | |
| org.apache.ojb.broker.query.ReportQueryByCriteria.setJoinAttributes(String[]) may expose internal representation by storing an externally mutable object into ReportQueryByCriteria.m_joinAttributes | MALICIOUS_CODE | EI_EXPOSE_REP2 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The method name org.apache.ojb.broker.query.SearchFilter.ConvertBinaryOperator(int) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.query.UserAlias.initMapping(String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.transaction.tm.AbstractTransactionManagerFactory.TM_DEFAULT_METHOD_NAME isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.transaction.tm.JBossTransactionManagerFactory.getLookupInfo() may expose internal representation by returning JBossTransactionManagerFactory.config | MALICIOUS_CODE | EI_EXPOSE_REP | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.transaction.tm.JOnASTransactionManagerFactory.getLookupInfo() may expose internal representation by returning JOnASTransactionManagerFactory.config | MALICIOUS_CODE | EI_EXPOSE_REP | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.transaction.tm.OrionTransactionManagerFactory.getLookupInfo() may expose internal representation by returning OrionTransactionManagerFactory.config | MALICIOUS_CODE | EI_EXPOSE_REP | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.transaction.tm.SunOneTransactionManagerFactory.getLookupInfo() may expose internal representation by returning SunOneTransactionManagerFactory.config | MALICIOUS_CODE | EI_EXPOSE_REP | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.transaction.tm.WebSphereTransactionManagerFactory.getLookupInfo() may expose internal representation by returning WebSphereTransactionManagerFactory.config | MALICIOUS_CODE | EI_EXPOSE_REP | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.transaction.tm.WeblogicTransactionManagerFactory.getLookupInfo() may expose internal representation by returning WeblogicTransactionManagerFactory.config | MALICIOUS_CODE | EI_EXPOSE_REP | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.ojb.broker.util.Base64.main(String[]) | STYLE | REC_CATCH_EXCEPTION | Medium | |
| Private method org.apache.ojb.broker.util.Base64.encode3to4(byte[]) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on java.sql.BatchUpdateException.getUpdateCounts() in org.apache.ojb.broker.util.ExceptionHelper.generateException(String, SQLException, String, ClassDescriptor, ValueContainer[], Logger, Object) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | High | |
| ? could be null and is guaranteed to be dereferenced in org.apache.ojb.broker.util.ExceptionHelper.generateException(String, SQLException, String, ClassDescriptor, ValueContainer[], Logger, Object) | CORRECTNESS | NP_GUARANTEED_DEREF | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.util.IdentityHashMap$IdentityKey.equals(Object) is unusual | STYLE | EQ_UNUSUAL | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.ojb.broker.util.ReferenceMap$DefaultMapEntry be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.ojb.broker.util.ReferenceMap$EntryIterator.currentValue | PERFORMANCE | URF_UNREAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.util.batch.PreparedStatementInvocationHandler.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Write to static field org.apache.ojb.broker.util.batch.PreparedStatementInvocationHandler.ADD_BATCH from instance method new org.apache.ojb.broker.util.batch.PreparedStatementInvocationHandler(BatchConnection, String, JdbcConnectionDescriptor) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.util.collections.RemovalAwareCollection doesn't override java.util.Vector.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.ojb.broker.util.configuration.impl.OjbConfigurator.log from instance method org.apache.ojb.broker.util.configuration.impl.OjbConfigurator.setLogger(Logger) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.ojb.broker.util.dbhandling.DBHandlingTask.createDBHandling() | STYLE | REC_CATCH_EXCEPTION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.util.dbhandling.TorqueDBHandling.createCreationScript() ignores exceptional return value of java.io.File.mkdir() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | Medium | |
| org.apache.ojb.broker.util.dbhandling.TorqueDBHandling.createDB() ignores exceptional return value of java.io.File.mkdir() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | Medium | |
| org.apache.ojb.broker.util.dbhandling.TorqueDBHandling.createInitScripts() ignores exceptional return value of java.io.File.createNewFile() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | Medium | |
| org.apache.ojb.broker.util.dbhandling.TorqueDBHandling.createInitScripts() ignores exceptional return value of java.io.File.mkdir() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | Medium | |
| org.apache.ojb.broker.util.dbhandling.TorqueDBHandling.deleteDir(File) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | Medium | |
| org.apache.ojb.broker.util.dbhandling.TorqueDBHandling.getWorkDir() ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | Medium | |
| org.apache.ojb.broker.util.dbhandling.TorqueDBHandling.initDB() ignores exceptional return value of java.io.File.mkdir() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | Medium | |
| Method org.apache.ojb.broker.util.dbhandling.TorqueDBHandling.writeCompressedTexts(File, HashMap) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field org.apache.ojb.broker.util.interceptor.InterceptorFactory.instance in org.apache.ojb.broker.util.interceptor.InterceptorFactory.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.util.logging.CommonsLoggerImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.util.logging.Log4jLoggerImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.ojb.broker.util.logging.LoggingConfiguration.load() | STYLE | REC_CATCH_EXCEPTION | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.util.sequence.AbstractSequenceManager.getUniqueValue(FieldDescriptor) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method new org.apache.ojb.broker.util.sequence.HighLowSequence() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.util.sequence.SequenceManagerHelper.getSeqCacheValue(Properties) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.util.sequence.SequenceManagerHelper.getSeqIncrementBy(Properties) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.util.sequence.SequenceManagerHelper.getSeqMaxValue(Properties) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.util.sequence.SequenceManagerHelper.getSeqMinValue(Properties) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| Method org.apache.ojb.broker.util.sequence.SequenceManagerHelper.getSeqStart(Properties) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| org.apache.ojb.broker.util.sequence.SequenceManagerHelper.getSeqCycleValue(Properties) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | Medium | |
| org.apache.ojb.broker.util.sequence.SequenceManagerHelper.getSeqOrderValue(Properties) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.broker.util.sequence.SequenceManagerHighLowImpl.sequencesDBMap isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.util.sequence.SequenceManagerInMemoryImpl.getUniqueLong(FieldDescriptor) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| org.apache.ojb.broker.util.sequence.SequenceManagerInMemoryImpl.sequencesDBMap isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.util.sequence.SequenceManagerNativeImpl.afterStore(JdbcAccess, ClassDescriptor, Object) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.broker.util.sequence.SequenceManagerTransientImpl.getUniqueValue(FieldDescriptor) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.ojb.odmg.DatabaseImpl.pbKey; locked 40% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.odmg.NamedRootsMap$NamedEntry.getOid() may expose internal representation by returning NamedRootsMap$NamedEntry.oid | MALICIOUS_CODE | EI_EXPOSE_REP | Medium | |
| org.apache.ojb.odmg.NamedRootsMap$NamedEntry.setOid(byte[]) may expose internal representation by storing an externally mutable object into NamedRootsMap$NamedEntry.oid | MALICIOUS_CODE | EI_EXPOSE_REP2 | Medium | |
| The field org.apache.ojb.odmg.NamedRootsMap$NamedEntry.object is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium | |
| The field org.apache.ojb.odmg.NamedRootsMap$NamedEntry.useIdentity is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.ojb.odmg.ObjectEnvelope defines non-transient non-serializable instance field buffer | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field org.apache.ojb.odmg.collections.DListEntry.realSubject is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field org.apache.ojb.odmg.collections.DMapEntry.keyRealSubject is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium | |
| The field org.apache.ojb.odmg.collections.DMapEntry.log is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium | |
| The field org.apache.ojb.odmg.collections.DMapEntry.valueRealSubject is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.odmg.locking.AbstractLockStrategy.DEFAULT_LOCK_TIMEOUT should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium | |
| Write to static field org.apache.ojb.odmg.locking.AbstractLockStrategy.DEFAULT_LOCK_TIMEOUT from instance method new org.apache.ojb.odmg.locking.AbstractLockStrategy() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.odmg.locking.LockEntry.LOCK_READ isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| org.apache.ojb.odmg.locking.LockEntry.LOCK_WRITE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.ojb.odmg.locking.LockManagerFactory.init() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.ojb.odmg.locking.RemoteLockMapImpl.lockservlet from instance method org.apache.ojb.odmg.locking.RemoteLockMapImpl.configure(Configuration) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method new org.apache.ojb.odmg.oql.OQLLexer(LexerSharedInputState) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.ojb.odmg.oql.OQLParser.literal() invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | Medium | |
| org.apache.ojb.odmg.oql.OQLParser._tokenNames should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.ojb.otm.core.ConcreteEditingContext$1.equals(Object) always returns false | CORRECTNESS | EQ_ALWAYS_FALSE | High |
