Tag List Report

The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.

Tag ClassTotal number of occurrencesTag strings used by tag class
FIXME's2FIXME
TODO's77TODO

Each tag is detailed below:

FIXME's

Number of occurrences found in the code: 2

liquibase.sqlgenerator.core.DropDefaultValueGeneratorLine
this syntax does not supported by MSSQL 200066
liquibase.statementexecute.AddUniqueConstraintExecutorTestLine
Syntax for mysql is correct, but exception "Table 'liquibaseb.adduqtest' doesn't exist" is thrown assertCorrect("alter table `liquibaseb`.`adduqtest` add constraint `uq_test` unique (`coltomakeuq`)", MySQLDatabase.class);128

TODO's

Number of occurrences found in the code: 77

liquibase.LiquibaseTestLine
reintroduce @Test public void isSaveToRunMigration() throws Exception { TestLiquibase liquibase = testLiquibase;53
liquibase.change.AbstractChangeTestLine
reintroduce @Test public void executeStatement() throws Exception { Change change = new AbstractChange("test", "Test Refactorign", ChangeMetaData.PRIORITY_DEFAULT) { public SqlStatement[] generateStatements(Database database) { return new SqlStatement[]{new RawSqlStatement("GENERATED STATEMENT;")}; }136
liquibase.change.ColumnConfigLine
find where this is being called with the tag body and fix the code there. this logic does not belong here because it prevents a column from being the empty string97
liquibase.change.core.AddLookupTableChangeTestLine
this test should reorganized first statement is RawSql to create new (Lookup) Table second - Set Not Null Constraint for the Field in the created Lookup table third - primary key constraint of the Lookup Table forth - add foreign key reference from old (base) table to the lookup table Take into account that different databases could produce different number of the statements.32
liquibase.change.core.AddPrimaryKeyChangeLine
} else if (database instanceof SQLiteDatabase) { // return special statements for SQLite databases return generateStatementsForSQLiteDatabase(database);86
liquibase.change.core.AddUniqueConstraintChangeLine
if (database instanceof SQLiteDatabase) { // return special statements for SQLite databases return generateStatementsForSQLiteDatabase(database); }103
liquibase.change.core.DropColumnChangeLine
if (database instanceof SQLiteDatabase) { // return special statements for SQLite databases return generateStatementsForSQLiteDatabase(database); }58
liquibase.change.core.DropDefaultValueChangeLine
if (database instanceof SQLiteDatabase) { // return special statements for SQLite databases return generateStatementsForSQLiteDatabase(database); }66
liquibase.change.core.DropNotNullConstraintChangeLine
if (database instanceof SQLiteDatabase) { // return special statements for SQLite databases return generateStatementsForSQLiteDatabase(database); }66
liquibase.change.core.DropPrimaryKeyChangeLine
if (database instanceof SQLiteDatabase) { // return special statements for SQLite databases return generateStatementsForSQLiteDatabase(database); }55
liquibase.change.core.DropUniqueConstraintChangeLine
if (database instanceof SQLiteDatabase) { // return special statements for SQLite databases return generateStatementsForSQLiteDatabase(database); }68
liquibase.change.core.LoadDataChangeTestLine
test with file opener160
test with file opener165
liquibase.change.core.LoadUpdateDataChangeTestLine
To change body of overridden methods use File | Settings | File Templates.204
To change body of overridden methods use File | Settings | File Templates.209
liquibase.change.core.RenameColumnChangeLine
if (database instanceof SQLiteDatabase) { // return special statements for SQLite databases return generateStatementsForSQLiteDatabase(database); }74
liquibase.change.custom.CustomChangeWrapperLine
be smarter about handling upgrade99
liquibase.database.core.InformixDatabaseLine
Maybe there is a better place for this. For each session this statement has to be executed, to allow newlines in quoted strings110
dont know if this correct186
liquibase.database.core.MySQLDatabaseLine
handle @Override public String getConnectionUsername() throws DatabaseException { return super.getConnection().getConnectionUserName().replaceAll("\\@.*", ""); }19
liquibase.database.core.PostgresDatabaseLine
throw?144
Something?310
liquibase.database.core.PostgresDatabaseTestLine
test has troubles, fix later39
test has troubles, fix later44
liquibase.database.core.SybaseASADatabaseLine
Auto-generated method stub202
Auto-generated method stub208
liquibase.database.core.UnsupportedDatabaseLine
reintroduce try { String nowFunction = null; String dateFunction = null; String dateTimeFunction = null; String timeStampFunction = null;58
reintroduce? @Override protected boolean canCreateChangeLogTable() throws DatabaseException { //check index size. Many drivers just return 0, so it's not a great test int maxIndexLength; try { maxIndexLength = getConnection().getMetaData().getMaxIndexLength();99
liquibase.dbdoc.TableWriterLine
add foreign key info to columns?41
liquibase.dbtest.AbstractIntegrationTestLine
We need better data diff support to be able to do that Diff diff = new Diff(utf8Snapshot,iso88951Snapshot); diff.setDiffData(true); assertFalse("There are no differences setting the same data in utf-8 and iso-8895-1 " ,diff.compare().differencesFound());756
liquibase.dbtest.unsupported.UnsupportedDBIntegrationTestLine
find a good way to implement that doesn't require wrapping the connection object. Use to test using Derby, but changing the reported type so Liquibase doesn't recognize it.4
liquibase.lockservice.LockServiceExecuteTestLine
failing on build server: re-enable66
liquibase.serializer.core.string.StringChangeLogSerializerLine
--No comment--33
liquibase.serializer.core.xml.XMLChangeLogSerializerLine
--No comment--65
liquibase.snapshot.jvm.JdbcDatabaseSnapshotGeneratorLine
there are some filters bellow in for loop. Are they needed here too?480
Informix generates indexnames with a leading blank if no name given. An identifier with a leading blank is not allowed. So here is it replaced.730
maybe bug in jdbc driver? Need to investigate. If this "if" is commented out ArrayOutOfBoundsException is thrown because it tries to access an element -1 of a List (position-1)747
liquibase.sqlgenerator.core.AddDefaultValueSQLiteLine
--No comment--74
liquibase.sqlgenerator.core.AddForeignKeyConstraintGeneratorLine
don't know if correct68
Informix can handle ON DELETE CASCADE only, but I don't know if this is really correct see "REFERENCES Clause" in manual82
liquibase.sqlgenerator.core.AlterSequenceGeneratorTestLine
assert increment by is 1 }25
assert increment by value } }); }30
; assert minValue is 1 }41
assert min valuevalue } }); }46
assert initial max value }62
assert max value } }); }67
assert order default }83
assert max value } }); }88
assert increment by is 1 }103
assert increment by value } }); }108
liquibase.sqlgenerator.core.CreateIndexGeneratorTestLine
assert that index was created in the correct location. What schema does it go in? // snapshot = new DatabaseSnapshotGenerator(database, TestContext.ALT_SCHEMA); // assertNotNull(snapshot.getIndex(INDEX_NAME)); // assertEquals(COLUMN_NAME.toUpperCase(), snapshot.getIndex(INDEX_NAME).getColumnNames().toUpperCase()); } }); }30
assert tablespace location } }); }49
liquibase.sqlgenerator.core.CreateSequenceGeneratorTestLine
assert start value } }); }60
assert increment by value }80
assert min valuevalue } }); }101
assert max value } }); }120
assert max value } }); }138
liquibase.sqlgenerator.core.CreateTableGeneratorLine
informixdb104
ORA-00972: identifier is too long If tableName lenght is more then 28 symbols then generated pkName will be incorrect121
liquibase.sqlgenerator.core.CreateTableGeneratorTestLine
test when tested by diff assertTrue(foundForeignKey.isDeleteCascade()); }223
actually test for uniqueness when diff can check for it assertTrue(table.getColumn("username").isUnique()); }250
test that tablespace is correct when diff returns it } }); }332
liquibase.sqlgenerator.core.DropDefaultValueGeneratorLine
If dropped from a not null column the not null constraint will be dropped, too. If the column is "NOT NULL" it has to be added behind the datatype.98
liquibase.sqlgenerator.core.DropIndexGeneratorTestLine
issues with schemas on some databases // @Test // public void execute_altSchema() throws Exception { // new DatabaseTestTemplate().testOnAvailableDatabases( // new SqlStatementDatabaseTest(TestContext.ALT_SCHEMA, new DropIndexStatement(ALT_IDX_NAME, TestContext.ALT_SCHEMA, TABLE_NAME)) { // // protected void preExecuteAssert(DatabaseSnapshotGenerator snapshot) { // //todo: how do we assert indexes within a schema snapshot? //// assertNotNull(snapshot.getIndex(ALT_IDX_NAME)); // } // // protected void postExecuteAssert(DatabaseSnapshotGenerator snapshot) { // //todo: how do we assert indexes within a schema snapshot? //// assertNull(snapshot.getIndex(ALT_IDX_NAME)); // } // // }); // }20
how do we assert indexes within a schema snapshot? //// assertNotNull(snapshot.getIndex(ALT_IDX_NAME)); // } // // protected void postExecuteAssert(DatabaseSnapshotGenerator snapshot) { // //todo: how do we assert indexes within a schema snapshot? //// assertNull(snapshot.getIndex(ALT_IDX_NAME)); // } // // }); // }27
how do we assert indexes within a schema snapshot? //// assertNull(snapshot.getIndex(ALT_IDX_NAME)); // } // // }); // }32
liquibase.sqlgenerator.core.DropUniqueConstraintGeneratorTestLine
assert when isUnique works: assertTrue(snapshot.getTable(TABLE_NAME).getColumn(COL_NAME).isUnique()); }10
assert when isUnique works: assertFalse(snapshot.getTable(TABLE_NAME).getColumn(COL_NAME).isUnique()); }14
liquibase.sqlgenerator.core.GetViewDefinitionGeneratorInformixLine
owner is schemaName ? view definition is distributed over multiple rows, each 64 chars see InformixDatabase.getViewDefinition24
liquibase.statement.core.ReindexStatementTestLine
remove override once SQLite is back in TestContext.AllDatabases11
liquibase.statementexecute.AddAutoIncrementExecuteTestLine
sqlserver (at least 2000) does not allows add not null column. this type or refactoring should include adding nullable column, updating it to some default value, and final adding primary constraint. assertCorrect(null, MSSQLDatabase.class);102
liquibase.statementexecute.AddUniqueConstraintExecutorTestLine
enable snapshot and assertion when snapshot can check for unique constraints //snapshot = new DatabaseSnapshotGenerator(snapshot); assertTrue(snapshot.getTable(TABLE_NAME).getColumn(COLUMN_NAME).isUnique()); } }); }53
enable snapshot and assertion when snapshot can check for unique constraints snapshot = new DatabaseSnapshotGenerator(database, TestContext.ALT_SCHEMA); assertTrue(snapshot.getTable(TABLE_NAME).getColumn(COLUMN_NAME).isUnique()); }69
enable snapshot and assertion when snapshot can check for unique constraints // snapshot = new DatabaseSnapshotGenerator(database); // assertTrue(snapshot.getTable(TABLE_NAME).getColumn(COLUMN_NAME).isUnique()); } }); }86
liquibase.test.DatabaseTestContextLine
re-enable sqlite testing210
liquibase.test.DatabaseTestTemplateLine
find how to get tests to run correctly on SQLite25
liquibase.test.TestContextLine
re-enable sqlite testing40