The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.BasicDynaBean.get(String) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | 160 | Medium |
| Method org.apache.commons.beanutils.BasicDynaBean.get(String) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 162 | Medium |
| Method org.apache.commons.beanutils.BasicDynaBean.get(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 168 | Medium |
| Method org.apache.commons.beanutils.BasicDynaBean.get(String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 170 | Medium |
| Method org.apache.commons.beanutils.BasicDynaBean.get(String) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | 172 | Medium |
| org.apache.commons.beanutils.BasicDynaBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 58 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.commons.beanutils.BasicDynaClass.getDynaProperties() may expose internal representation by returning BasicDynaClass.properties | MALICIOUS_CODE | EI_EXPOSE_REP | 197 | Medium |
| org.apache.commons.beanutils.BasicDynaClass.constructorTypes should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 108 | Medium |
| org.apache.commons.beanutils.BasicDynaClass is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 51 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.BeanMap$3.transform(Object) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 134 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.ConvertUtilsBean.<static initializer>() invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 134 | Medium |
| Method org.apache.commons.beanutils.ConvertUtilsBean.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 133 | Medium |
| Method org.apache.commons.beanutils.ConvertUtilsBean.<static initializer>() invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | 387 | Medium |
| Method new org.apache.commons.beanutils.ConvertUtilsBean() invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | 205 | Medium |
| Method new org.apache.commons.beanutils.ConvertUtilsBean() invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 235 | Medium |
| Method new org.apache.commons.beanutils.ConvertUtilsBean() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 327 | Medium |
| Method new org.apache.commons.beanutils.ConvertUtilsBean() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 357 | Medium |
| Method org.apache.commons.beanutils.ConvertUtilsBean.setDefaultByte(byte) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | 224 | Medium |
| Method org.apache.commons.beanutils.ConvertUtilsBean.setDefaultCharacter(char) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 254 | Medium |
| Method org.apache.commons.beanutils.ConvertUtilsBean.setDefaultInteger(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 346 | Medium |
| Method org.apache.commons.beanutils.ConvertUtilsBean.setDefaultLong(long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 376 | Medium |
| Method org.apache.commons.beanutils.ConvertUtilsBean.setDefaultShort(short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | 406 | Medium |
| Write to static field org.apache.commons.beanutils.ConvertUtilsBean.defaultShort from instance method org.apache.commons.beanutils.ConvertUtilsBean.setDefaultShort(short) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 406 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.DynaBeanMapDecorator.putAll(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 285 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.commons.beanutils.DynaProperty is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 77 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.LazyDynaBean.<static initializer>() invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | 128 | Medium |
| Method org.apache.commons.beanutils.LazyDynaBean.<static initializer>() invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 126 | Medium |
| Method org.apache.commons.beanutils.LazyDynaBean.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 132 | Medium |
| Method org.apache.commons.beanutils.LazyDynaBean.<static initializer>() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 134 | Medium |
| Method org.apache.commons.beanutils.LazyDynaBean.<static initializer>() invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | 130 | Medium |
| org.apache.commons.beanutils.LazyDynaBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 119 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.commons.beanutils.LazyDynaList is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 197 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.commons.beanutils.MappedPropertyDescriptor doesn't override java.beans.PropertyDescriptor.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 49 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.PropertyUtilsBean.getIndexedProperty(Object, String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 483 | Medium |
| Method org.apache.commons.beanutils.PropertyUtilsBean.setIndexedProperty(Object, String, int, Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 1689 | Medium |
| Method org.apache.commons.beanutils.PropertyUtilsBean.invokeMethod(Method, Object, Object[]) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 2191 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.commons.beanutils.WeakFastHashMap$CollectionView.equals(Object) is unusual | STYLE | EQ_UNUSUAL | 619 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.commons.beanutils.WrapDynaBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 62 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.commons.beanutils.WrapDynaClass.getDynaProperties() may expose internal representation by returning WrapDynaClass.properties | MALICIOUS_CODE | EI_EXPOSE_REP | 282 | Medium |
| Method org.apache.commons.beanutils.WrapDynaClass.introspect() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 406 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.commons.beanutils.converters.AbstractArrayConverter.strings isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 104 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.converters.AbstractConverter.toString(Class) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 444 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.commons.beanutils.converters.ArrayConverter.setAllowedChars(char[]) may expose internal representation by storing an externally mutable object into ArrayConverter.allowedChars | MALICIOUS_CODE | EI_EXPOSE_REP2 | 201 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.converters.CharacterConverter.convertToType(Class, Object) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 84 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.commons.beanutils.converters.DateTimeConverter.getPatterns() may expose internal representation by returning DateTimeConverter.patterns | MALICIOUS_CODE | EI_EXPOSE_REP | 182 | Medium |
| org.apache.commons.beanutils.converters.DateTimeConverter.setPatterns(String[]) may expose internal representation by storing an externally mutable object into DateTimeConverter.patterns | MALICIOUS_CODE | EI_EXPOSE_REP2 | 193 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.converters.NumberConverter.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 87 | Medium |
| Method org.apache.commons.beanutils.converters.NumberConverter.convertToType(Class, Object) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 245 | Medium |
| Method org.apache.commons.beanutils.converters.NumberConverter.toNumber(Class, Class, Number) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | 315 | Medium |
| Method org.apache.commons.beanutils.converters.NumberConverter.toNumber(Class, Class, Number) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 343 | Medium |
| Method org.apache.commons.beanutils.converters.NumberConverter.toNumber(Class, Class, Number) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 348 | Medium |
| Method org.apache.commons.beanutils.converters.NumberConverter.toNumber(Class, Class, Number) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | 329 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.commons.beanutils.locale.LocaleBeanUtilsBean$Descriptor be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 943 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.locale.converters.ByteLocaleConverter.parse(Object, String) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | 222 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.locale.converters.IntegerLocaleConverter.parse(Object, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 222 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.locale.converters.LongLocaleConverter.parse(Object, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 223 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.commons.beanutils.locale.converters.ShortLocaleConverter.parse(Object, String) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | 229 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.commons.collections.FastHashMap$CollectionView.equals(Object) is unusual | STYLE | EQ_UNUSUAL | 595 | Medium |